GNU bug report logs -
#58518
29.0.50; [PATCH] Turning off compilation-minor-mode removes fontification of other modes
Previous Next
Reported by: miha <at> kamnitnik.top
Date: Fri, 14 Oct 2022 15:16:02 UTC
Severity: normal
Tags: patch
Found in version 29.0.50
Full log
Message #8 received at 58518 <at> debbugs.gnu.org (full text, mbox):
miha <at> kamnitnik.top writes:
> The attached patch makes them return to the face they had after step 2,
> as specified by the grep command.
[...]
> - `(font-lock-face ,(if leave
> - compilation-leave-directory-face
> - compilation-enter-directory-face)
> + `(compilation-face ,(if leave
> + compilation-leave-directory-face
[...]
> + (let ((alist (copy-alist char-property-alias-alist)))
> + (cl-pushnew 'compilation-face (alist-get 'face alist))
Hm, it's an interesting approach -- we don't use this trick elsewhere in
other mode (I mean, except for `font-lock-face'), but this seems like a
good solution.
But since it's so unusual, I wonder whether there's any reason we don't
use this more in general. Are there performance impacts, for instance?
(I don't think so, since it's a buffer-local variable.) But I've added
Stefan and Eli to the CCs; perhaps they have comments.
This bug report was last modified 2 years and 244 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.