GNU bug report logs - #58516
28.1; add option/key to rerun current diff without whitespace changes

Previous Next

Package: emacs;

Reported by: gert <gertopc <at> proton.me>

Date: Fri, 14 Oct 2022 14:55:02 UTC

Severity: normal

Tags: fixed, patch

Found in version 28.1

Fixed in version 30.1

Done: Robert Pluim <rpluim <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Robert Pluim <rpluim <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 58516 <at> debbugs.gnu.org, gert <gertopc <at> proton.me>, Daniel Martín <mardani29 <at> yahoo.es>
Subject: bug#58516: 28.1; add option/key to rerun  current diff without whitespace changes
Date: Mon, 17 Oct 2022 15:01:28 +0200

>>>>> On Mon, 17 Oct 2022 14:33:27 +0200, Lars Ingebrigtsen <larsi <at> gnus.org> said:

    Lars> Robert Pluim <rpluim <at> gmail.com> writes:
    >> Comments welcome

    Lars> Looks good to me, but:

    >> +(defun diff-ignore-whitespace-hunk (whole-buffer)
    >> +  "Re-diff the current hunk, ignoring whitespace differences.
    >> +With non-nil prefix arg, re-diff all the hunks."
    >> +  (interactive "P")

    Lars> That should be "&optional whole-buffer".

The interaction between `interactive' and &optional is one of those
things that my brain always seems to page out, so I believe you :-)

Robert
--
This bug report was last modified 2 years and 153 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.