GNU bug report logs - #58488
[PATCH] gnu: gnome: Include aarch64 in librsvg-for-system.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58488 in the body.
You can then email your comments to 58488 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: gnome: Include aarch64 in librsvg-for-system.
Date: Thu, 13 Oct 2022 11:20:48 +0100

Since the staging merge, librsvg has been buildable for aarch64.

* gnu/packages/gnome.scm (librsvg-for-system): Use librsvg for aarch64.
---
 gnu/packages/gnome.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 09a991b14c..ff9d95c244 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -3753,8 +3753,10 @@ (define* (librsvg-for-system #:optional
                              (system (or (%current-target-system)
                                          (%current-system))))
   ;; Since librsvg 2.50 depends on Rust, and Rust is only correctly supported
-  ;; on x86_64 so far, use the ancient C version on other platforms (FIXME).
-  (if (string-prefix? "x86_64-" system)
+  ;; on x86_64 and aarch64 so far, use the ancient C version on other
+  ;; platforms (FIXME).
+  (if (or (string-prefix? "x86_64-" system)
+          (string-prefix? "aarch64-" system))
       librsvg
       librsvg-2.40))
 
-- 
2.37.3

Message #8 received at 58488 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 58488 <at> debbugs.gnu.org
Subject: Re: bug#58488: [PATCH] gnu: gnome: Include aarch64 in
 librsvg-for-system.
Date: Sun, 23 Oct 2022 15:10:14 +0200

Hi Chris,

Christopher Baines <mail <at> cbaines.net> skribis:

> Since the staging merge, librsvg has been buildable for aarch64.
>
> * gnu/packages/gnome.scm (librsvg-for-system): Use librsvg for aarch64.

[...]

> +  ;; on x86_64 and aarch64 so far, use the ancient C version on other
> +  ;; platforms (FIXME).
> +  (if (or (string-prefix? "x86_64-" system)
> +          (string-prefix? "aarch64-" system))
>        librsvg
>        librsvg-2.40))

Looks like a reasonable workaround to me.  Go for it!

Thanks,
Ludo’.

Message #11 received at 58488 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 58488 <at> debbugs.gnu.org
Subject: Re: bug#58488: [PATCH] gnu: gnome: Include aarch64 in
 librsvg-for-system.
Date: Thu, 03 Nov 2022 16:32:59 +0100

Christopher Baines <mail <at> cbaines.net> skribis:

> Since the staging merge, librsvg has been buildable for aarch64.
>
> * gnu/packages/gnome.scm (librsvg-for-system): Use librsvg for aarch64.
> ---
>  gnu/packages/gnome.scm | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 09a991b14c..ff9d95c244 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -3753,8 +3753,10 @@ (define* (librsvg-for-system #:optional
>                               (system (or (%current-target-system)
>                                           (%current-system))))
>    ;; Since librsvg 2.50 depends on Rust, and Rust is only correctly supported
> -  ;; on x86_64 so far, use the ancient C version on other platforms (FIXME).
> -  (if (string-prefix? "x86_64-" system)
> +  ;; on x86_64 and aarch64 so far, use the ancient C version on other
> +  ;; platforms (FIXME).
> +  (if (or (string-prefix? "x86_64-" system)
> +          (string-prefix? "aarch64-" system))

With <https://issues.guix.gnu.org/58661> now fixed, I think you can go
ahead and push this one, no?

Ludo’.

Message #16 received at 58488-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 58488-done <at> debbugs.gnu.org
Subject: Re: bug#58488: [PATCH] gnu: gnome: Include aarch64 in
 librsvg-for-system.
Date: Thu, 03 Nov 2022 17:46:16 +0100

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> Since the staging merge, librsvg has been buildable for aarch64.
>>
>> * gnu/packages/gnome.scm (librsvg-for-system): Use librsvg for aarch64.
>> ---
>>  gnu/packages/gnome.scm | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
>> index 09a991b14c..ff9d95c244 100644
>> --- a/gnu/packages/gnome.scm
>> +++ b/gnu/packages/gnome.scm
>> @@ -3753,8 +3753,10 @@ (define* (librsvg-for-system #:optional
>>                               (system (or (%current-target-system)
>>                                           (%current-system))))
>>    ;; Since librsvg 2.50 depends on Rust, and Rust is only correctly supported
>> -  ;; on x86_64 so far, use the ancient C version on other platforms (FIXME).
>> -  (if (string-prefix? "x86_64-" system)
>> +  ;; on x86_64 and aarch64 so far, use the ancient C version on other
>> +  ;; platforms (FIXME).
>> +  (if (or (string-prefix? "x86_64-" system)
>> +          (string-prefix? "aarch64-" system))
>
> With <https://issues.guix.gnu.org/58661> now fixed, I think you can go
> ahead and push this one, no?

Indeed, thanks for the reminder, I've pushed to master as
754f260753fb6ebe28325616bc08336a184e4621.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.