GNU bug report logs - #58484
[PATCH 0/1] gnu: home: home-dbus-service-type: Fix make-forkexec-constructor call.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58484 in the body.
You can then email your comments to 58484 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: "\(" <paren <at> disroot.org>
Subject: [PATCH 0/1] gnu: home: home-dbus-service-type: Fix
 make-forkexec-constructor call.
Date: Thu, 13 Oct 2022 07:47:25 +0100

This fixes a stupid mistake I made with the home-dbus-service-type, where I
tried to use #~ inside another #~.

( (1):
  gnu: home: home-dbus-service-type: Fix make-forkexec-constructor call.

 gnu/home/services/desktop.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.38.0

Message #8 received at 58484 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: 58484 <at> debbugs.gnu.org
Cc: "\(" <paren <at> disroot.org>
Subject: [PATCH 1/1] gnu: home: home-dbus-service-type: Fix
 make-forkexec-constructor call.
Date: Thu, 13 Oct 2022 07:48:25 +0100

* gnu/home/services/desktop.scm (home-dbus-shepherd-services)[start]
  <#:environment-variables>: Use a quote instead of a gexp.
---
 gnu/home/services/desktop.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/home/services/desktop.scm b/gnu/home/services/desktop.scm
index 6549efd8df..e94e666d93 100644
--- a/gnu/home/services/desktop.scm
+++ b/gnu/home/services/desktop.scm
@@ -201,7 +201,7 @@ (define (home-dbus-shepherd-services config)
                                      (format #f "/run/user/~a"
                                              (getuid)))))
                    #:environment-variables
-                   #~(list "DBUS_VERBOSE=1")
+                   '(list "DBUS_VERBOSE=1")
                    #:log-file
                    (format #f "~a/dbus.log"
                            (or (getenv "XDG_LOG_HOME")
-- 
2.38.0

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: "( via Guix-patches via" <guix-patches <at> gnu.org>, 58484 <at> debbugs.gnu.org
Cc: "\(" <paren <at> disroot.org>
Subject: Re: [bug#58484] [PATCH 1/1] gnu: home: home-dbus-service-type: Fix
 make-forkexec-constructor call.
Date: Fri, 14 Oct 2022 11:11:58 +0400

[Message part 1 (text/plain, inline)]

On 2022-10-13 07:48, guix-patches <at> gnu.org wrote:

> * gnu/home/services/desktop.scm (home-dbus-shepherd-services)[start]
>   <#:environment-variables>: Use a quote instead of a gexp.
> ---

It's possible to type arbitrary text after ---, which won't be added to
commit message or affect a patch.  Just in case you would like to send
one email instead of two, this trick can be used.

>  gnu/home/services/desktop.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/home/services/desktop.scm b/gnu/home/services/desktop.scm
> index 6549efd8df..e94e666d93 100644
> --- a/gnu/home/services/desktop.scm
> +++ b/gnu/home/services/desktop.scm
> @@ -201,7 +201,7 @@ (define (home-dbus-shepherd-services config)
>                                       (format #f "/run/user/~a"
>                                               (getuid)))))
>                     #:environment-variables
> -                   #~(list "DBUS_VERBOSE=1")
> +                   '(list "DBUS_VERBOSE=1")
>                     #:log-file
>                     (format #f "~a/dbus.log"
>                             (or (getenv "XDG_LOG_HOME")

Applied, pushed, thank you :)

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Andrew Tropin" <andrew <at> trop.in>, "( via Guix-patches via"
 <guix-patches <at> gnu.org>, <58484 <at> debbugs.gnu.org>
Subject: Re: [bug#58484] [PATCH 1/1] gnu: home: home-dbus-service-type: Fix
 make-forkexec-constructor call.
Date: Fri, 14 Oct 2022 08:12:45 +0100

On Fri Oct 14, 2022 at 8:11 AM BST, Andrew Tropin wrote:
> Applied, pushed, thank you :)

Thanks! :)

    -- (

Message #23 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Andrew Tropin" <andrew <at> trop.in>, "( via Guix-patches via"
 <guix-patches <at> gnu.org>, <58484 <at> debbugs.gnu.org>
Subject: Re: [bug#58484] [PATCH 1/1] gnu: home: home-dbus-service-type: Fix
 make-forkexec-constructor call.
Date: Fri, 14 Oct 2022 08:18:17 +0100

On Fri Oct 14, 2022 at 8:11 AM BST, Andrew Tropin wrote:
> It's possible to type arbitrary text after ---, which won't be added to
> commit message or affect a patch.  Just in case you would like to send
> one email instead of two, this trick can be used.

I know, but I prefer to use the --cover-letter feature to generate the leading email :)

    -- (

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.