GNU bug report logs - #5848
23.1.95; bands of background after font change if --with-x-toolkit=no

Previous Next

Package: emacs;

Reported by: Ted Phelps <phelps <at> pobox.com>

Date: Tue, 6 Apr 2010 14:28:02 UTC

Severity: normal

Done: Jan Djärv <jan.h.d <at> swipnet.se>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>
To: Jan Djärv <jan.h.d <at> swipnet.se>
Cc: Ted Phelps <phelps <at> pobox.com>, 5848 <at> debbugs.gnu.org
Subject: bug#5848: 23.1.95; bands of background after font change if --with-x-toolkit=no
Date: Wed, 07 Apr 2010 09:16:05 +0900
>>>>> On Tue, 06 Apr 2010 20:54:24 +0200, Jan Djärv <jan.h.d <at> swipnet.se> said:

> /* Return the pixel width/height of frame F if it has
>     COLS columns/LINES rows.  */

> #define FRAME_TEXT_COLS_TO_PIXEL_WIDTH(f, cols) \
>    (FRAME_COL_TO_PIXEL_X (f, cols) \
>     + (f)->scroll_bar_actual_width \
>     + FRAME_TOTAL_FRINGE_WIDTH (f)      \
>     + FRAME_INTERNAL_BORDER_WIDTH (f))

> #define FRAME_TEXT_LINES_TO_PIXEL_HEIGHT(f, lines) \
>    (FRAME_LINE_TO_PIXEL_Y (f, lines) \
>     + FRAME_INTERNAL_BORDER_WIDTH (f))


> and

> #define FRAME_INTERNAL_BORDER_WIDTH(F) ((F)->internal_border_width)

> But the internal border is on two sides, so it should be 
> 2*FRAME_INTERNAL_BORDER_WIDTH (f).

FRAME_COL_TO_PIXEL_X and FRAME_LINE_TO_PIXEL_Y include the left and
top side internal border width, respectively.  So, the internal border
is already counted twice in FRAME_TEXT_COLS_TO_PIXEL_WIDTH and
FRAME_TEXT_LINES_TO_PIXEL_HEIGHT above.

				     YAMAMOTO Mitsuharu
				mituharu <at> math.s.chiba-u.ac.jp




This bug report was last modified 15 years and 107 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.