GNU bug report logs - #58465
[PATCH] gnu: Add guile-dns.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58465 in the body.
You can then email your comments to 58465 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH] gnu: Add guile-dns.
Date: Wed, 12 Oct 2022 15:18:01 +0530

* gnu/packages/guile-xyz.scm (guile-dns): New variable.
---
 gnu/packages/guile-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 379d9aa264..b7909e8f8d 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -4426,6 +4426,42 @@ (define-public guile-avahi
       (home-page "https://www.nongnu.org/guile-avahi/")
       (license license:lgpl3+))))
 
+(define-public guile-dns
+  (package
+    (name "guile-dns")
+    (version "0.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://git.lysator.liu.se/hugo/guile-dns")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "18skivracv6jh1zab9dknkcpbizc416n0pb2mcwb20dpzc2md9yf"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:make-flags #~(list (string-append "PREFIX=" #$output))
+           #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'prefer-curdir
+                 (lambda _
+                   ;; CURDIR is a standard GNU Make variable. Prefer it to
+                   ;; PWD. PWD is set by the shell and is absent in the build
+                   ;; process.
+                   (substitute* "Makefile"
+                     (("PWD") "CURDIR"))))
+               (delete 'configure))))
+    (inputs
+     (list guile-3.0))
+    (native-inputs
+     (list texinfo))
+    (home-page "https://git.lysator.liu.se/hugo/guile-dns")
+    (synopsis "Guile DNS library")
+    (description "@code{guile-dns} is a DNS library written in pure Guile
+Scheme.")
+    (license license:gpl3+)))
+
 (define-public guile-jwt
   (package
     (name "guile-jwt")
-- 
2.37.3

Message #8 received at 58465 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 58465 <at> debbugs.gnu.org
Subject: Re: [bug#58465] [PATCH] gnu: Add guile-dns.
Date: Thu, 13 Oct 2022 11:05:58 +0100

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> writes:

> * gnu/packages/guile-xyz.scm (guile-dns): New variable.
> ---
>  gnu/packages/guile-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)

This looks to fail to build on i686-linux:

  https://qa.guix.gnu.org/issue/58465

Given this is a new package, ideally we'd either fix that, or change the
supported systems to match what builds.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 58465 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 58465 <at> debbugs.gnu.org
Subject: Re: [bug#58465] [PATCH] gnu: Add guile-dns.
Date: Sat, 15 Oct 2022 02:10:39 +0530

Hi Chris,

> This looks to fail to build on i686-linux:
>
>   https://qa.guix.gnu.org/issue/58465

Good catch, and love the new QA system! :-)

> Given this is a new package, ideally we'd either fix that, or change the
> supported systems to match what builds.

Disabling the coverage report fixes this. Is that a satisfactory
solution? A patch follows.

Thanks,
Arun

Message #14 received at 58465 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Arun Isaac <arunisaac <at> systemreboot.net>,
 Christopher Baines <mail <at> cbaines.net>
Cc: 58465 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add guile-dns.
Date: Sat, 15 Oct 2022 02:11:23 +0530

* gnu/packages/guile-xyz.scm (guile-dns): New variable.
---
 gnu/packages/guile-xyz.scm | 42 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 379d9aa264..934762f631 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -4426,6 +4426,48 @@ (define-public guile-avahi
       (home-page "https://www.nongnu.org/guile-avahi/")
       (license license:lgpl3+))))
 
+(define-public guile-dns
+  (package
+    (name "guile-dns")
+    (version "0.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://git.lysator.liu.se/hugo/guile-dns")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "18skivracv6jh1zab9dknkcpbizc416n0pb2mcwb20dpzc2md9yf"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:make-flags #~(list (string-append "PREFIX=" #$output)
+                                ;; Prevent guild warnings.
+                                "GUILE_AUTO_COMPILE=0"
+                                ;; Make tests verbose and disable coverage
+                                ;; report. The coverage report fails on
+                                ;; i686-linux.
+                                "TEST_FLAGS=--verbose")
+           #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'prefer-curdir
+                 (lambda _
+                   ;; CURDIR is a standard GNU Make variable. Prefer it to
+                   ;; PWD. PWD is set by the shell and is absent in the build
+                   ;; process.
+                   (substitute* "Makefile"
+                     (("PWD") "CURDIR"))))
+               (delete 'configure))))
+    (inputs
+     (list guile-3.0))
+    (native-inputs
+     (list texinfo))
+    (home-page "https://git.lysator.liu.se/hugo/guile-dns")
+    (synopsis "Guile DNS library")
+    (description "@code{guile-dns} is a DNS library written in pure Guile
+Scheme.")
+    (license license:gpl3+)))
+
 (define-public guile-jwt
   (package
     (name "guile-jwt")
-- 
2.37.3

Message #17 received at 58465 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Arun Isaac <arunisaac <at> systemreboot.net>,
 Christopher Baines <mail <at> cbaines.net>
Cc: 58465 <at> debbugs.gnu.org
Subject: [PATCH v3 0/1] Add guile-dns
Date: Sat, 15 Oct 2022 02:25:48 +0530

I just found that the info file was installed into the wrong path. I have
fixed it in this v3 patch.

Arun Isaac (1):
  gnu: Add guile-dns.

 gnu/packages/guile-xyz.scm | 44 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

-- 
2.37.3

Message #20 received at 58465 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Arun Isaac <arunisaac <at> systemreboot.net>,
 Christopher Baines <mail <at> cbaines.net>
Cc: 58465 <at> debbugs.gnu.org
Subject: [PATCH v3 1/1] gnu: Add guile-dns.
Date: Sat, 15 Oct 2022 02:25:49 +0530

* gnu/packages/guile-xyz.scm (guile-dns): New variable.
---
 gnu/packages/guile-xyz.scm | 44 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 379d9aa264..16ee197c2a 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -4426,6 +4426,50 @@ (define-public guile-avahi
       (home-page "https://www.nongnu.org/guile-avahi/")
       (license license:lgpl3+))))
 
+(define-public guile-dns
+  (package
+    (name "guile-dns")
+    (version "0.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://git.lysator.liu.se/hugo/guile-dns")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "18skivracv6jh1zab9dknkcpbizc416n0pb2mcwb20dpzc2md9yf"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:make-flags #~(list (string-append "PREFIX=" #$output)
+                                ;; Prevent guild warnings.
+                                "GUILE_AUTO_COMPILE=0"
+                                ;; Make tests verbose and disable coverage
+                                ;; report. The coverage report fails on
+                                ;; i686-linux.
+                                "TEST_FLAGS=--verbose")
+           #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'fix-makefile
+                 (lambda _
+                   (substitute* "Makefile"
+                     ;; CURDIR is a standard GNU Make variable. Prefer it to
+                     ;; PWD. PWD is set by the shell and is absent in the
+                     ;; build process.
+                     (("PWD") "CURDIR")
+                     ;; Install info file at share/info, not at share.
+                     (("share doc") "share/info doc"))))
+               (delete 'configure))))
+    (inputs
+     (list guile-3.0))
+    (native-inputs
+     (list texinfo))
+    (home-page "https://git.lysator.liu.se/hugo/guile-dns")
+    (synopsis "Guile DNS library")
+    (description "@code{guile-dns} is a DNS library written in pure Guile
+Scheme.")
+    (license license:gpl3+)))
+
 (define-public guile-jwt
   (package
     (name "guile-jwt")
-- 
2.37.3

Message #23 received at 58465 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 58465 <at> debbugs.gnu.org
Subject: Re: [bug#58465] [PATCH] gnu: Add guile-dns.
Date: Sat, 15 Oct 2022 21:30:18 +0100

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> writes:

>> This looks to fail to build on i686-linux:
>>
>>   https://qa.guix.gnu.org/issue/58465
>
> Good catch, and love the new QA system! :-)
>
>> Given this is a new package, ideally we'd either fix that, or change the
>> supported systems to match what builds.
>
> Disabling the coverage report fixes this. Is that a satisfactory
> solution? A patch follows.

Yeah, that sounds fine to me, please go ahead and push :)

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 58465-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 58465-done <at> debbugs.gnu.org
Subject: Re: [bug#58465] [PATCH] gnu: Add guile-dns.
Date: Sun, 16 Oct 2022 14:07:10 +0530

Pushed, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.