GNU bug report logs - #58461
[PATCH] gnu: emacs-eval-in-repl-erlang: Fix unbound variable.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58461 in the body.
You can then email your comments to 58461 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Kubisiak <brian <at> kubisiak.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-eval-in-repl-erlang: Fix unbound variable.
Date: Tue, 11 Oct 2022 19:20:43 -0700

Commit 0b120ad5f88d32e0c716b1442fe1ea3c562b5586 introduced a circular
dependency where (gnu packages erlang) would transitively load (gnu
packages emacs-xyz) before the emacs-erlang package was defined. This
would result in "error: emacs-erlang: unbound variable" in the
definition of emacs-eval-in-repl-erlang when trying to use (gnu
packages erlang) from the repl.

This commit fixes the unbound variable by adding a delay to the inputs
in make-emacs-eval-in-repl.

* gnu/packages/emacs-xyz.scm (emacs-eval-in-repl-erlang): Add delay.
---
 gnu/packages/emacs-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2ac29e8225..1b0f07731d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -27911,7 +27911,7 @@ (define-public emacs-eval-in-repl-elm
   (make-emacs-eval-in-repl "elm" #:inputs (list emacs-elm-mode)))
 
 (define-public emacs-eval-in-repl-erlang
-  (make-emacs-eval-in-repl "erlang" #:inputs (list emacs-erlang)))
+  (make-emacs-eval-in-repl "erlang" #:inputs (delay (list emacs-erlang))))
 
 (define-public emacs-eval-in-repl-geiser
   (make-emacs-eval-in-repl "geiser" #:language "Scheme"
-- 
2.37.3

Message #8 received at 58461 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Brian Kubisiak <brian <at> kubisiak.com>, 58461 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: emacs-eval-in-repl-erlang: Fix unbound variable.
Date: Fri, 14 Oct 2022 23:52:45 +0200

Am Dienstag, dem 11.10.2022 um 19:20 -0700 schrieb Brian Kubisiak:
> Commit 0b120ad5f88d32e0c716b1442fe1ea3c562b5586 introduced a circular
> dependency where (gnu packages erlang) would transitively load (gnu
> packages emacs-xyz) before the emacs-erlang package was defined. This
> would result in "error: emacs-erlang: unbound variable" in the
> definition of emacs-eval-in-repl-erlang when trying to use (gnu
> packages erlang) from the repl.
> 
> This commit fixes the unbound variable by adding a delay to the
> inputs in make-emacs-eval-in-repl.
Pushed with a slightly shorter commit message.

Cheers

Message #13 received at 58461-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 58461-done <at> debbugs.gnu.org
Subject: Re: [bug#58461] [PATCH] gnu: emacs-eval-in-repl-erlang: Fix unbound
 variable.
Date: Sun, 16 Oct 2022 18:12:18 +0100

[Message part 1 (text/plain, inline)]

Marking as done as the patch has been pushed to master.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.