GNU bug report logs - #5845
load-library vs. list-load-path-shadows

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5845 in the body.
You can then email your comments to 5845 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Bug-Gnu-Emacs <bug-gnu-emacs <at> gnu.org>
Subject: load-library vs. list-load-path-shadows
Date: Tue, 6 Apr 2010 15:36:12 +0200

[Forward of http://lists.gnu.org/archive/html/emacs-devel/2010-04/msg00182.html]


(This is on Windows, so case insensitive search, etc.)

I installed color-theme in my site-lisp, and then

  M-x load-library <RET> authors <RET>

fails because it finds site-lisp/color-theme/AUTHORS instead of
lisp/emacs-lisp/authors.el[c], which is or isn't a bug (I think it's
not, given that `load-library' clearly says that "LIBRARY is searched
[...] both with and without `load-suffixes'").

But at least `list-load-path-shadows' should use the same heuristics,
so it could point out the problem...

   Juanma

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#5845: load-library vs. list-load-path-shadows
Date: Tue, 06 Apr 2010 15:40:56 +0100

On 2010-04-06 14:36 +0100, Juanma Barranquero wrote:
> [Forward of http://lists.gnu.org/archive/html/emacs-devel/2010-04/msg00182.html]
>
>
> (This is on Windows, so case insensitive search, etc.)
>
> I installed color-theme in my site-lisp, and then
>
>   M-x load-library <RET> authors <RET>
>
> fails because it finds site-lisp/color-theme/AUTHORS instead of
> lisp/emacs-lisp/authors.el[c], which is or isn't a bug (I think it's
> not, given that `load-library' clearly says that "LIBRARY is searched
> [...] both with and without `load-suffixes'").
>
> But at least `list-load-path-shadows' should use the same heuristics,
> so it could point out the problem...
>
>    Juanma

I wonder if it would be better not to include files with no extensions.
Quite a few packages include things like README/ChangeLog.

Leo

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Leo <sdl.web <at> gmail.com>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#5845: load-library vs. list-load-path-shadows
Date: Tue, 6 Apr 2010 18:11:09 +0200

> I wonder if it would be better not to include files with no extensions.

`load' is used to load ~/.emacs

    Juanma

Message #14 received at 5845 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: 5845 <at> debbugs.gnu.org
Subject: Bug#5845: load-library vs. list-load-path-shadows
Date: Tue, 16 Jan 2018 10:54:42 -0500

[Message part 1 (text/plain, inline)]

Should we just use case-insensitive compare for `windows-nt' systems?
The idea of using "the same heuristics" as `load' sounds nice, but as
far as I can tell, `load' just queries the file system directly. Doing
the same in `load-path-shadow-find' is far too slow (raises execution
time from 0.38s to 5.64s, and that's without any packages adding to
the load-path).

--- i/lisp/emacs-lisp/shadow.el
+++ w/lisp/emacs-lisp/shadow.el
@@ -123,7 +123,9 @@ load-path-shadows-find
         ;; XXX.elc (or vice-versa) when they are in the same directory.
         (setq files-seen-this-dir (cons file files-seen-this-dir))

-        (if (setq orig-dir (assoc file files))
+        (if (setq orig-dir (assoc file files
+                                      (if (memq system-type
'(windows-nt ms-dos))
+                      (lambda (f1 f2) (eq (compare-strings f1 nil nil
f2 nil nil t) t)))))
         ;; This file was seen before, we have a shadowing.
         ;; Report it unless the files are identical.
         (let ((base1 (concat (cdr orig-dir) "/" file))

[naive-shadow-list.el (application/octet-stream, attachment)]

Message #17 received at 5845 <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>, 5845 <at> debbugs.gnu.org
Subject: Re: bug#5845: load-library vs. list-load-path-shadows
Date: Tue, 16 Jan 2018 12:25:35 -0500

On 1/16/2018 10:54 AM, Noam Postavsky wrote:
> Should we just use case-insensitive compare for `windows-nt' systems?
> The idea of using "the same heuristics" as `load' sounds nice, but as
> far as I can tell, `load' just queries the file system directly. Doing
> the same in `load-path-shadow-find' is far too slow (raises execution
> time from 0.38s to 5.64s, and that's without any packages adding to
> the load-path).

Would it help to use file-name-case-insensitive-p?

Ken

Message #20 received at 5845 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 5845 <at> debbugs.gnu.org
Subject: Re: bug#5845: load-library vs. list-load-path-shadows
Date: Tue, 16 Jan 2018 16:32:11 -0500

[Message part 1 (text/plain, inline)]

On Tue, Jan 16, 2018 at 12:25 PM, Ken Brown <kbrown <at> cornell.edu> wrote:
> On 1/16/2018 10:54 AM, Noam Postavsky wrote:
>>
>> Should we just use case-insensitive compare for `windows-nt' systems?
>> The idea of using "the same heuristics" as `load' sounds nice, but as
>> far as I can tell, `load' just queries the file system directly. Doing
>> the same in `load-path-shadow-find' is far too slow (raises execution
>> time from 0.38s to 5.64s, and that's without any packages adding to
>> the load-path).
>
>
> Would it help to use file-name-case-insensitive-p?

Ah, good point. How about the attached?

[v2-0001-Handle-case-insensitive-filenames-for-load-path-s.patch (application/octet-stream, attachment)]

Message #23 received at 5845 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: 5845 <at> debbugs.gnu.org, kbrown <at> cornell.edu
Subject: Re: bug#5845: load-library vs. list-load-path-shadows
Date: Wed, 17 Jan 2018 17:37:39 +0200

> From: Noam Postavsky <npostavs <at> users.sourceforge.net>
> Date: Tue, 16 Jan 2018 16:32:11 -0500
> Cc: 5845 <at> debbugs.gnu.org
> 
> > Would it help to use file-name-case-insensitive-p?
> 
> Ah, good point. How about the attached?

LGTM, thanks.  Could we have a test for this issue?

Message #26 received at 5845 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 5845 <at> debbugs.gnu.org, Ken Brown <kbrown <at> cornell.edu>
Subject: Re: bug#5845: load-library vs. list-load-path-shadows
Date: Thu, 18 Jan 2018 12:05:48 -0500

[Message part 1 (text/plain, inline)]

On Wed, Jan 17, 2018 at 10:37 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:

> LGTM, thanks.  Could we have a test for this issue?

Yes, good idea, caught some silly typos. Should this go to emacs-26?

[v3-0001-Handle-case-insensitive-filenames-for-load-path-s.patch (application/octet-stream, attachment)]

Message #29 received at 5845 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: 5845 <at> debbugs.gnu.org, kbrown <at> cornell.edu
Subject: Re: bug#5845: load-library vs. list-load-path-shadows
Date: Thu, 18 Jan 2018 20:51:38 +0200

> From: Noam Postavsky <npostavs <at> users.sourceforge.net>
> Date: Thu, 18 Jan 2018 12:05:48 -0500
> Cc: Ken Brown <kbrown <at> cornell.edu>, 5845 <at> debbugs.gnu.org
> 
> > LGTM, thanks.  Could we have a test for this issue?
> 
> Yes, good idea, caught some silly typos. Should this go to emacs-26?

Not sure.  The issue doesn't sound urgent/important, what with its
being unsolved for such a long time.  OTOH, the change is simple and
localized.  WDYT?

Message #32 received at 5845 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 5845 <at> debbugs.gnu.org, Ken Brown <kbrown <at> cornell.edu>
Subject: Re: bug#5845: load-library vs. list-load-path-shadows
Date: Thu, 18 Jan 2018 14:39:57 -0500

On Thu, Jan 18, 2018 at 1:51 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:

>> Should this go to emacs-26?
>
> Not sure.  The issue doesn't sound urgent/important, what with its
> being unsolved for such a long time.  OTOH, the change is simple and
> localized.  WDYT?

Agreed on both points. The simpleness of the fix outweighs the urgency
for me I think, so I'm leaning to emacs-26.

Message #35 received at 5845 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: 5845 <at> debbugs.gnu.org, kbrown <at> cornell.edu
Subject: Re: bug#5845: load-library vs. list-load-path-shadows
Date: Thu, 18 Jan 2018 22:46:40 +0200

> From: Noam Postavsky <npostavs <at> users.sourceforge.net>
> Date: Thu, 18 Jan 2018 14:39:57 -0500
> Cc: Ken Brown <kbrown <at> cornell.edu>, 5845 <at> debbugs.gnu.org
> 
> On Thu, Jan 18, 2018 at 1:51 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> >> Should this go to emacs-26?
> >
> > Not sure.  The issue doesn't sound urgent/important, what with its
> > being unsolved for such a long time.  OTOH, the change is simple and
> > localized.  WDYT?
> 
> Agreed on both points. The simpleness of the fix outweighs the urgency
> for me I think, so I'm leaning to emacs-26.

OK.

Message #38 received at 5845 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 5845 <at> debbugs.gnu.org, Ken Brown <kbrown <at> cornell.edu>
Subject: Re: bug#5845: load-library vs. list-load-path-shadows
Date: Thu, 18 Jan 2018 16:40:46 -0500

tag 5845 fixed
close 5845 26.1
quit

On Thu, Jan 18, 2018 at 3:46 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> From: Noam Postavsky <npostavs <at> users.sourceforge.net>
>> Date: Thu, 18 Jan 2018 14:39:57 -0500
>> Cc: Ken Brown <kbrown <at> cornell.edu>, 5845 <at> debbugs.gnu.org
>>
>> On Thu, Jan 18, 2018 at 1:51 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>>
>> >> Should this go to emacs-26?
>> >
>> > Not sure.  The issue doesn't sound urgent/important, what with its
>> > being unsolved for such a long time.  OTOH, the change is simple and
>> > localized.  WDYT?
>>
>> Agreed on both points. The simpleness of the fix outweighs the urgency
>> for me I think, so I'm leaning to emacs-26.
>
> OK.

Pushed.

[1: 76040d1]: 2018-01-18 16:26:52 -0500
  Handle case-insensitive filenames for load-path shadows (Bug#5845)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=76040d1eae4464b468481231c15e7fb86f4b11d8

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.