From unknown Fri Aug 22 01:03:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#58448] [PATCH] gnu: helm: fix not finding Factory Presets Resent-From: Sughosha Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 11 Oct 2022 18:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58448 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 58448@debbugs.gnu.org X-Debbugs-Original-To: "guix-patches@gnu.org" Received: via spool by submit@debbugs.gnu.org id=B.166551328119182 (code B ref -1); Tue, 11 Oct 2022 18:35:01 +0000 Received: (at submit) by debbugs.gnu.org; 11 Oct 2022 18:34:41 +0000 Received: from localhost ([127.0.0.1]:54806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiK5R-0004zI-Dv for submit@debbugs.gnu.org; Tue, 11 Oct 2022 14:34:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:53590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiK5O-0004z9-Ps for submit@debbugs.gnu.org; Tue, 11 Oct 2022 14:34:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41132) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiK5O-0001Z1-Jk for guix-patches@gnu.org; Tue, 11 Oct 2022 14:34:38 -0400 Received: from mail-4324.protonmail.ch ([185.70.43.24]:35913) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiK5K-0005wW-EU for guix-patches@gnu.org; Tue, 11 Oct 2022 14:34:38 -0400 Date: Tue, 11 Oct 2022 18:34:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=nwu4olw7prcvrdqfgnw6wcbv5y.protonmail; t=1665513269; x=1665772469; bh=xPDCv3AslfQzBqOh8WIrTkX4jCu4nnzqHQMTQ5OIZrA=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID; b=HwhLQppMvGNU028O9vp5UstFXPDRYiTsNoG7bn5SZVmd5KbavcwbP5ELJxwPjeoTV ZOr7P3OWGC0BfYzGd6RgNBNrEEyRFaMD+n8Ep5qlDJweASLzIph+UR/uB1wE9uyBv1 /Zkvt0/w7Sy8X03wZgnHyE9Mxmu3T+Vp8OecYleIYppwn9fVm2F/DOE16VeD01uzsh Uyx4hbmQG4a8JU9fQ/hb4mHBSy4V3ynRSwQY+b7yDb6Lig87iIyyP7y7F/K8gxk6rf KLD4PazTmheQ5TZmdvnwKBlY6wcuhcdWM4+aCBVEhWniejhr5yku77yVRZa1aVHy0e WlRNHRDFGujMA== From: Sughosha Message-ID: <1Hb23qlXeqgl88MZf-yTifjb8ONE252Dzr2UuXWINnpJSUKbtAroTIZsmCKV4SuSkQkVihMEVjP6KiHbdhD1qrjB5GZCqIU6TI4ZeSBH9Xc=@proton.me> Feedback-ID: 45211691:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.43.24; envelope-from=Sughosha@proton.me; helo=mail-4324.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/music.scm (helm): Fix not finding Factory Presets. This change fixes hardcoded paths so that Factory Presets can be found. --- gnu/packages/music.scm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index 6b37c79389..000b372303 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -6144,6 +6144,13 @@ (define-public helm (substitute* "Makefile" (("/usr") "")) #t)) + (add-after 'unpack 'fix-hardcoded-paths + (lambda* (#:key outputs #:allow-other-keys) + (substitute* "src/common/load_save.cpp" + (("/usr") (assoc-ref outputs "out"))) + (substitute* "src/editor_sections/patch_browser.cpp" + (("/usr") (assoc-ref outputs "out"))) + #t)) (delete 'configure)))) (inputs `(("alsa-lib" ,alsa-lib) --=20 2.38.0 From unknown Fri Aug 22 01:03:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#58448] [PATCH] gnu: helm: fix not finding Factory Presets Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 29 Oct 2022 21:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58448 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 58448@debbugs.gnu.org Cc: Sughosha , 58448-done@debbugs.gnu.org X-Debbugs-Original-To: Sughosha via Guix-patches via Received: via spool by submit@debbugs.gnu.org id=B.16670804507233 (code B ref -1); Sat, 29 Oct 2022 21:55:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 Oct 2022 21:54:10 +0000 Received: from localhost ([127.0.0.1]:36811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ootmM-0001sa-6r for submit@debbugs.gnu.org; Sat, 29 Oct 2022 17:54:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:39286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ootmL-0001sN-3b for submit@debbugs.gnu.org; Sat, 29 Oct 2022 17:54:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ootmK-0001Pq-UH for guix-patches@gnu.org; Sat, 29 Oct 2022 17:54:08 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ootmI-0008IM-UJ for guix-patches@gnu.org; Sat, 29 Oct 2022 17:54:08 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 8AF2C60003; Sat, 29 Oct 2022 21:54:01 +0000 (UTC) From: Nicolas Goaziou References: <1Hb23qlXeqgl88MZf-yTifjb8ONE252Dzr2UuXWINnpJSUKbtAroTIZsmCKV4SuSkQkVihMEVjP6KiHbdhD1qrjB5GZCqIU6TI4ZeSBH9Xc=@proton.me> Date: Sat, 29 Oct 2022 23:53:59 +0200 In-Reply-To: <1Hb23qlXeqgl88MZf-yTifjb8ONE252Dzr2UuXWINnpJSUKbtAroTIZsmCKV4SuSkQkVihMEVjP6KiHbdhD1qrjB5GZCqIU6TI4ZeSBH9Xc=@proton.me> (Sughosha via Guix-patches via's message of "Tue, 11 Oct 2022 18:34:21 +0000") Message-ID: <87bkpupa88.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.195; envelope-from=mail@nicolasgoaziou.fr; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, Sughosha via Guix-patches via writes: > * gnu/packages/music.scm (helm): Fix not finding Factory Presets. > This change fixes hardcoded paths so that Factory Presets can be > found. Thank you. Applied with the following changes: > + (add-after 'unpack 'fix-hardcoded-paths > + (lambda* (#:key outputs #:allow-other-keys) > + (substitute* "src/common/load_save.cpp" > + (("/usr") (assoc-ref outputs "out"))) > + (substitute* "src/editor_sections/patch_browser.cpp" > + (("/usr") (assoc-ref outputs "out"))) > + #t)) I removed trailing #t, and merged both substitute* calls. Regards, -- Nicolas Goaziou From unknown Fri Aug 22 01:03:35 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Sughosha Subject: bug#58448: closed (Re: [bug#58448] [PATCH] gnu: helm: fix not finding Factory Presets) Message-ID: References: <87bkpupa88.fsf@nicolasgoaziou.fr> <1Hb23qlXeqgl88MZf-yTifjb8ONE252Dzr2UuXWINnpJSUKbtAroTIZsmCKV4SuSkQkVihMEVjP6KiHbdhD1qrjB5GZCqIU6TI4ZeSBH9Xc=@proton.me> X-Gnu-PR-Message: they-closed 58448 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 58448@debbugs.gnu.org Date: Sat, 29 Oct 2022 21:55:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1667080502-7305-1" This is a multi-part message in MIME format... ------------=_1667080502-7305-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #58448: [PATCH] gnu: helm: fix not finding Factory Presets which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 58448@debbugs.gnu.org. --=20 58448: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D58448 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1667080502-7305-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 58448-done) by debbugs.gnu.org; 29 Oct 2022 21:54:10 +0000 Received: from localhost ([127.0.0.1]:36809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ootmL-0001sU-UW for submit@debbugs.gnu.org; Sat, 29 Oct 2022 17:54:10 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:51107) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ootmJ-0001sB-Pc for 58448-done@debbugs.gnu.org; Sat, 29 Oct 2022 17:54:08 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 8AF2C60003; Sat, 29 Oct 2022 21:54:01 +0000 (UTC) From: Nicolas Goaziou To: Sughosha via Guix-patches via Subject: Re: [bug#58448] [PATCH] gnu: helm: fix not finding Factory Presets References: <1Hb23qlXeqgl88MZf-yTifjb8ONE252Dzr2UuXWINnpJSUKbtAroTIZsmCKV4SuSkQkVihMEVjP6KiHbdhD1qrjB5GZCqIU6TI4ZeSBH9Xc=@proton.me> Date: Sat, 29 Oct 2022 23:53:59 +0200 In-Reply-To: <1Hb23qlXeqgl88MZf-yTifjb8ONE252Dzr2UuXWINnpJSUKbtAroTIZsmCKV4SuSkQkVihMEVjP6KiHbdhD1qrjB5GZCqIU6TI4ZeSBH9Xc=@proton.me> (Sughosha via Guix-patches via's message of "Tue, 11 Oct 2022 18:34:21 +0000") Message-ID: <87bkpupa88.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 58448-done Cc: Sughosha , 58448-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Sughosha via Guix-patches via writes: > * gnu/packages/music.scm (helm): Fix not finding Factory Presets. > This change fixes hardcoded paths so that Factory Presets can be > found. Thank you. Applied with the following changes: > + (add-after 'unpack 'fix-hardcoded-paths > + (lambda* (#:key outputs #:allow-other-keys) > + (substitute* "src/common/load_save.cpp" > + (("/usr") (assoc-ref outputs "out"))) > + (substitute* "src/editor_sections/patch_browser.cpp" > + (("/usr") (assoc-ref outputs "out"))) > + #t)) I removed trailing #t, and merged both substitute* calls. Regards, -- Nicolas Goaziou ------------=_1667080502-7305-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Oct 2022 18:34:41 +0000 Received: from localhost ([127.0.0.1]:54806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiK5R-0004zI-Dv for submit@debbugs.gnu.org; Tue, 11 Oct 2022 14:34:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:53590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiK5O-0004z9-Ps for submit@debbugs.gnu.org; Tue, 11 Oct 2022 14:34:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41132) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiK5O-0001Z1-Jk for guix-patches@gnu.org; Tue, 11 Oct 2022 14:34:38 -0400 Received: from mail-4324.protonmail.ch ([185.70.43.24]:35913) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiK5K-0005wW-EU for guix-patches@gnu.org; Tue, 11 Oct 2022 14:34:38 -0400 Date: Tue, 11 Oct 2022 18:34:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=nwu4olw7prcvrdqfgnw6wcbv5y.protonmail; t=1665513269; x=1665772469; bh=xPDCv3AslfQzBqOh8WIrTkX4jCu4nnzqHQMTQ5OIZrA=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID; b=HwhLQppMvGNU028O9vp5UstFXPDRYiTsNoG7bn5SZVmd5KbavcwbP5ELJxwPjeoTV ZOr7P3OWGC0BfYzGd6RgNBNrEEyRFaMD+n8Ep5qlDJweASLzIph+UR/uB1wE9uyBv1 /Zkvt0/w7Sy8X03wZgnHyE9Mxmu3T+Vp8OecYleIYppwn9fVm2F/DOE16VeD01uzsh Uyx4hbmQG4a8JU9fQ/hb4mHBSy4V3ynRSwQY+b7yDb6Lig87iIyyP7y7F/K8gxk6rf KLD4PazTmheQ5TZmdvnwKBlY6wcuhcdWM4+aCBVEhWniejhr5yku77yVRZa1aVHy0e WlRNHRDFGujMA== To: "guix-patches@gnu.org" From: Sughosha Subject: [PATCH] gnu: helm: fix not finding Factory Presets Message-ID: <1Hb23qlXeqgl88MZf-yTifjb8ONE252Dzr2UuXWINnpJSUKbtAroTIZsmCKV4SuSkQkVihMEVjP6KiHbdhD1qrjB5GZCqIU6TI4ZeSBH9Xc=@proton.me> Feedback-ID: 45211691:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.43.24; envelope-from=Sughosha@proton.me; helo=mail-4324.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/music.scm (helm): Fix not finding Factory Presets. This change fixes hardcoded paths so that Factory Presets can be found. --- gnu/packages/music.scm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index 6b37c79389..000b372303 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -6144,6 +6144,13 @@ (define-public helm (substitute* "Makefile" (("/usr") "")) #t)) + (add-after 'unpack 'fix-hardcoded-paths + (lambda* (#:key outputs #:allow-other-keys) + (substitute* "src/common/load_save.cpp" + (("/usr") (assoc-ref outputs "out"))) + (substitute* "src/editor_sections/patch_browser.cpp" + (("/usr") (assoc-ref outputs "out"))) + #t)) (delete 'configure)))) (inputs `(("alsa-lib" ,alsa-lib) --=20 2.38.0 ------------=_1667080502-7305-1--