From unknown Sat Sep 06 09:27:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Oct 2022 18:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 58446@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166551227017498 (code B ref -1); Tue, 11 Oct 2022 18:18:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Oct 2022 18:17:50 +0000 Received: from localhost ([127.0.0.1]:54782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiJp8-0004Y9-0z for submit@debbugs.gnu.org; Tue, 11 Oct 2022 14:17:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:50894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiJp6-0004Y2-7z for submit@debbugs.gnu.org; Tue, 11 Oct 2022 14:17:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiJp6-0006aa-13 for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2022 14:17:48 -0400 Received: from mout01.posteo.de ([185.67.36.65]:40769) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiJp3-0003RC-5P for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2022 14:17:47 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id DAD00240028 for ; Tue, 11 Oct 2022 20:17:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665512259; bh=nAGQYIzs25msjU0NDYYQlQyhQjpSbRjO7DWeD4KekbQ=; h=From:To:Subject:Date:Autocrypt:OpenPGP:From; b=rXtYF3LfOzYsUVLIug68O082N5CVjgU79pi1XRIHantPJZX8Ua+GgKNT969Upm1+P vmaUds6HAyMR0Jbfhp20OJS6aOU6HnxRDRnjMOYtKGww3kInL9BidWrM0l9lzJf7eS C5V/2ohYJVj1cLNs6IjfVVG8+KtCCa83BcEehzfJBGiVoxIDuigLn/JrN2Kmtv0XqO yGY0idPd3LhZHYtUeAi4vyPjiFnsGaozBC6rm1ox/yF1CnvH6YnmMFLnFNY9d2Scby LxUURmp1pQc8B6oi522SdWS9rxq+qBF14yebUsWr3yhaehA7cGtzDMw37+1FxcV+k+ JkeHK+iVhudHw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Mn3sr5Jdqz9rxD for ; Tue, 11 Oct 2022 20:17:36 +0200 (CEST) From: Thierry Volpiatto Date: Tue, 11 Oct 2022 18:11:18 +0000 Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata= mQGNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA AbQSdGhpZXZvbEBwb3N0ZW8ubmV0iQHOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaAtdXm5bYnSHsnL7cx8z7lukA/ EsJocE+GD7QXnsrdlicvdobI0TEN4l73221a72oCvHfYLCVsB6YsNJ5ZGkA1zSjzln5uLAgZ/2r/ aqlao/AlSZkAk6+hvK0RyAZ/YR4YRZxO8Fsd0gWgFkanRfKfufJ1V0OHZg7yszi3q/hRzS+rZtJ0 OuzDlh/dyQkxVkZb9vis/+HnGDJrBE5MsmJLcy2Sy3uUnio0fq8q9CrZbudvd1DajlZxPzTm0csP eUk45QEgbhEU7MfyAX/mkKxjHajz2cMcHKIap1BqEgJl4BKFeLMcBZ4O1p9ivwtf1Ht2JTp5lOi0 ItPfhQ4DP8LZ1ZIkN5Kg9v0cyw9meRzAuuR0V2GtuQGNBF8ylcIBDADnIDHEkmk4lUwTlOhwb2yj UfmGPnpH3MCCHkjM9H/P1gTHxFWtwFVPcNMCwXWvKSBTF2dZXKERD0yzG06zT53ZMN7EIIeuY6m4 R8IcMvpohciisWxbFoB4ZY117tVSeqjo946itgbpdeESKl9a8dpn7ytZMyYxPdojlQAqxeAJ8444 raESh1oTKXb64hlk4l2pSRlrLgjpJBo8asAfZndaxIUKhw68tV8sqeZh9P6cGtHbUELKVJqefNV7 V7jF5wf3xvRG6Ces3kSKXalLfs+vrVaoOjQeWrc0AtwFWHmt9JLfKrqF+Q2Q7jUidboWmazQM56E SJFPpPHmWq8k6DHspsFHOforLouTHJL1556IPne7IV2BGfWc0+xLxalZ8F5F+vnPF/OkrC1CD5iC KTjXKa2iZbcYdYQAiL6P8Ac8CgN6EkhpbxRtzrEgChuNGevdi/G/GHG4Zqrh6YFwIa/NHq2aVaFq 5C1yNTMJd1FRjRzs5JPPlJKpYDnNx+MSp7UAEQEAAYkBtgQYAQoAIAIbDBYhBCPbcH0Te6954oP8 cA7FbRQdFu+TBQJi9x1ZAAoJEA7FbRQdFu+To6QMAIcvUSiFwCIggxkmYy3ZY0QAMLmIPga8DNPM XbfSOBDb2KLGBd+FAA8p2GExpul4r6kOYnGogtojByHmVgrd30/3ZURTM8Vj51wwD05viMZccQHl Wd9J/qZIvhBJlJWYnwVxh+2Kg4/hkx7SGc7JJS5GS37+PFQOJHPGMxc+fe4Ty2FdjIOVf3P1Hov9 K6yBI7Af66qqcL3aKJ4jJidRYN8sMaKOqEu4rcSpTxp8/3Ddbs9HezUgXeUzOLJMcEYFlvCyC8ZS l/QDZmpobKbxZ1JAqZM8lnmcZYSV7OsWnxJIYDV1gH5LTLj7bGswXaB4B+qkckihWkRZixu8q1IK 0c/xwUzyF092uFRM/sQKrSmnwA1+hQiiIuEl4XVz5li0/TmMta3ijUM7GNbl2IjioTRxWWecwad1 mNHvKTcXPsKDAbHFdLvQzurnroBHQV0jSPNLTP5Suo7RnLbehfg5INpGjToCUlrd2qQqgXW7h5qZ TgUq5UmBc7YZ0JYWQgPTbQ== Message-ID: <87lepmusw5.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=thievol@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The device-number in file-attributes (nth 11) is a cons cell when called on remote files (see tramp-get-device). It would be great to notify this in Emacs documentation and how to interpret this value e.g. (-1 . 1). I noticed this in fixing a bug in dired-async.el, the code was using `=3D` to compare the two values which is legitimate according to docstring. In GNU Emacs 28.2 (build 1, x86_64-pc-linux-gnu, Motif Version 2.3.8, cairo= version 1.16.0) of 2022-09-12 built on IPad-S340 Windowing system distributor 'The X.Org Foundation', version 11.0.12013000 System Description: Linux Mint 20.3 Configured using: 'configure CFLAGS=3D-O8 --with-mailutils --with-cairo --without-dbus --without-gconf --without-gsettings --with-x-toolkit=3Dmotif' Configured features: ACL CAIRO FREETYPE GIF GLIB GMP GNUTLS GPM HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM MOTIF ZLIB Important settings: value of $LANG: fr_FR.UTF-8 locale-coding-system: utf-8-unix Major mode: =C6=90=C4=BD Minor modes in effect: bug-reference-prog-mode: t global-undo-tree-mode: t undo-tree-mode: t psession-mode: t psession-savehist-mode: t global-git-gutter-mode: t git-gutter-mode: t display-time-mode: t winner-mode: t helm-epa-mode: t helm-descbinds-mode: t helm-adaptive-mode: t helm-mode: t helm-minibuffer-history-mode: t helm-ff-icon-mode: t shell-dirtrack-mode: t helm-popup-tip-mode: t async-bytecomp-package-mode: t dired-async-mode: t minibuffer-depth-indicate-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (epa-mail face-remap addressbook-bookmark tv-mu4e-config mu4e-contrib mu4e-patch mu4e mu4e-org mu4e-main mu4e-view gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range gnus-win mu4e-headers mu4e-compose mu4e-draft mu4e-actions smtpmail mu4e-search mu4e-lists mu4e-bookmarks mu4e-mark mu4e-message shr kinsoku svg flow-fill hl-line mu4e-contacts mu4e-update mu4e-folders mu4e-server mu4e-context mu4e-obsolete mu4e-vars mu4e-helpers mu4e-config ido shadow sort mail-extr helm-ring eieio-opt speedbar ezimage dframe shortdoc help-fns radix-tree emacsbug sendmail cl-print etags fileloop generator xref tabify jka-compr helm-command image-file image-converter tramp-cache epa-file char-fold em-unix em-term term disp-table ehelp em-script em-prompt em-ls em-hist em-pred em-glob em-cmpl em-dirs esh-var em-basic em-banner em-alias esh-mode eshell esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util esh-toggle tramp-archive tramp-gvfs dbus helm-x-files helm-for-files markdown-mode flymake-shellcheck flymake-proc flymake project warnings sh-script smie executable bug-reference naquadah-theme view solar cal-dst holidays hol-loaddefs tv-utils osm dom yaml-mode undo-tree diff queue rainbow-mode color psession frameset log-view pcvs-util bash-completion cl-indent pcase ffap thingatpt autocrypt-message message rmc puny rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader autocrypt-gnus gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 mail-utils mm-util mail-prsvr autocrypt-mu4e autocrypt ietf-drums config-w3m git-gutter mule-util appt diary-lib diary-loaddefs gud wdired dired-extension org-config ob-gnuplot org-crypt net-utils time winner autotest-mode autoconf-mode woman man ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util init-helm helm-ls-git vc-git diff-mode vc vc-dispatcher helm-fd epa derived epg rfc6068 epg-config helm-epa helm-imenu imenu helm-elisp-package helm-find helm-org org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic bibtex ol rx org-keys oc org-compat advice org-macs org-loaddefs cal-menu calendar cal-loaddefs helm-external isl helm-descbinds helm-wikipedia all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons cus-edit wid-edit wfnames helm-ipython helm-elisp helm-eval edebug backtrace find-func python tramp-sh popup helm-bookmark helm-net xml helm-info bookmark pp helm-adaptive helm-mode helm-misc helm-files image-dired image-mode exif filenotify tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat shell pcomplete parse-time iso8601 time-date ls-lisp helm-buffers helm-occur helm-tags helm-locate helm-grep wgrep-helm wgrep grep compile text-property-search comint ring helm-regexp format-spec ansi-color helm-utils helm-help helm-types helm-extensions-autoloads helm-config helm-autoloads helm helm-global-bindings helm-easymenu helm-core async-bytecomp helm-source helm-multi-match helm-lib dired-async dired-aux dired dired-loaddefs async diminish cl-extra help-mode mb-depth server edmacro kmacro avoid cus-load use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key easy-mmode use-package-core finder-inf package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib info w3m-load iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads inotify lcms2 dynamic-setting font-render-setting cairo motif x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 1834152 77310) (symbols 48 43794 4) (strings 32 346905 22367) (string-bytes 1 12371838) (vectors 16 89769) (vector-slots 8 1894146 124249) (floats 8 3996 656) (intervals 56 347767 1990) (buffers 992 115)) <#secure method=3Dpgpmime mode=3Dsign> --=20 Thierry From unknown Sat Sep 06 09:27:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Oct 2022 11:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Thierry Volpiatto Cc: Michael Albinus , 58446@debbugs.gnu.org Received: via spool by 58446-submit@debbugs.gnu.org id=B58446.166557322132242 (code B ref 58446); Wed, 12 Oct 2022 11:14:02 +0000 Received: (at 58446) by debbugs.gnu.org; 12 Oct 2022 11:13:41 +0000 Received: from localhost ([127.0.0.1]:55869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiZgC-0008Ny-UH for submit@debbugs.gnu.org; Wed, 12 Oct 2022 07:13:41 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiZgB-0008Nj-CT for 58446@debbugs.gnu.org; Wed, 12 Oct 2022 07:13:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2QbpvwrnpJeIY9CfSzWHvT9qTFEtuv66iiBGalgEy0U=; b=A+2EFb8WIku06tOHGwlMhiAXg+ o1CuRiPPgnS9+A9vtOBqzIp6YbTONjQfUdH3fb2awqqGXL4GVnOZQTn7g07xhq3aq31Ef4sgL+HGg wcRk7LX628qgAyY0WRRkQwGMP/E1oUlI58ddnTfwMCDHDvivHAnh7U82iEgUIbaY2D5s=; Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oiZg2-00064Z-R8; Wed, 12 Oct 2022 13:13:33 +0200 From: Lars Ingebrigtsen In-Reply-To: <87lepmusw5.fsf@posteo.net> (Thierry Volpiatto's message of "Tue, 11 Oct 2022 18:11:18 +0000") References: <87lepmusw5.fsf@posteo.net> X-Now-Playing: Nobukazu Takemura's _Music for the exhibition "Einheit"_: "(untitled)" Date: Wed, 12 Oct 2022 13:13:30 +0200 Message-ID: <87pmexcn1h.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Thierry Volpiatto writes: > The device-number in file-attributes (nth 11) is a cons cell when called > on remote files (see tramp-get-device). > It would be great to notify this in Emacs documentation and how to > interpret th [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thierry Volpiatto writes: > The device-number in file-attributes (nth 11) is a cons cell when called > on remote files (see tramp-get-device). > It would be great to notify this in Emacs documentation and how to > interpret this value e.g. (-1 . 1). > I noticed this in fixing a bug in dired-async.el, the code was using `=` > to compare the two values which is legitimate according to docstring. Hm... would it be possible for Tramp to stash that information somewhere else? It is (as you say) documented to be a number. From unknown Sat Sep 06 09:27:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Oct 2022 14:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: Thierry Volpiatto , 58446@debbugs.gnu.org Received: via spool by 58446-submit@debbugs.gnu.org id=B58446.166558664031668 (code B ref 58446); Wed, 12 Oct 2022 14:58:02 +0000 Received: (at 58446) by debbugs.gnu.org; 12 Oct 2022 14:57:20 +0000 Received: from localhost ([127.0.0.1]:58197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oidAe-0008Ei-4k for submit@debbugs.gnu.org; Wed, 12 Oct 2022 10:57:20 -0400 Received: from mout.gmx.net ([212.227.17.20]:45199) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oidAb-0008ES-9r for 58446@debbugs.gnu.org; Wed, 12 Oct 2022 10:57:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1665586630; bh=wOKX35GRrrGK+YfAR3wqZUsFUvOX2ISXb45i1lv9ssg=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=j+07RYdUCFfNk4a0/lHcfM9U6mluwPmNZL73WzjpECUmH5tqNRlKW01Jl7P+6B1+m 4blolDbljErXMDRaLvuxBgc9/WvsaDwOYhsREwAjI8/wv3RjmPc5TUi7QTse/5IQBG k3quYVv4DcgEea3Ve5i60bw+dHclqHVz02yADJcg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.151.192]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MBDj4-1os1N527TS-00Cg90; Wed, 12 Oct 2022 16:57:10 +0200 From: Michael Albinus In-Reply-To: <87pmexcn1h.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 12 Oct 2022 13:13:30 +0200") References: <87lepmusw5.fsf@posteo.net> <87pmexcn1h.fsf@gnus.org> Date: Wed, 12 Oct 2022 16:57:04 +0200 Message-ID: <87edvd5bun.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:UIAJMMRaEWUU0gjQnUvs82vQxeuCkcRIz0plz6glHqtt43CpjC2 bm1jHP5mZiEb5G9SJxGe3SOIFHwRLYcUmyL6Wu4Um20rZtj4jKlW1nuaosJPX8VHSOTeHe+ qd22+DT2x/ytVzDKMoPz+0xuTroA+rWP9+9KN3zT2psTPTZlsrtCGMPMz0uzDIVIhz6LArF fGjOmmZmuzoaY00RjHNiA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:5rHAUgUEWBY=:SBQCwNjofgDc5NtaGBsUG9 qj60lajJIaVSDGiYPD+kibI3lazvtquhfChtg0py/LgfkaMlveLijPWCF/Jjg5z9+a0kBgQLp 4OBqdDDcAdLqK+zlgZhZnqB4rIj8ZXT6VAolIbEmRhR7PE+99XE6GMTJhg706tjUsBHw6/3vu POt+7NRSeZfh2MN/VMuyGUnToBFWdA+tqkG/jIHhjjkaMqbtPJ0KLTOs+ndgtwLww1jq8kbln 6k6+5dhrXptTirEi+IKUV2J6RNXmeGhTLGF3y8cmaO66aBwUScnEfoSgKfCKjg+0AtxQDGHx2 /Eao0MAH6OxFkV868cgNXW10NnW+5cq720vlTD6Vhz6Ci5GUz4NeWJgbReGJ7GVvAWYzD3cpd jsXQutKIlkQ03W8az5pBDSRTwCZdFMXlxKpy3S+gXICg2l9DkyQt0X7ivi5YnsTm0HX3u1gdw LoAm+rJkxDpmNtGEGaERVHedo9I1dsNi8EAcoCxecWDsSsk61iB9OJGr3w361xSPhg7GHByAq cynFzG/iNwPLPhAs21Ps0RNfuG5bqvhEJ7VWkkvZIOhqSJNiMG3+6jxmRKscLxB7BEVCbMPzK iRob/e5BrWwxX2cMBDBWbVf7jbl/g1CDU/DR7anIHClSJdQL7lRi9dElAuwDiYNr9RkHoEngF iUWNwWH9VFw0h7DbZ01P/Ar1cXeU0jtLguYO8oTukxqI/88cyKTsMqN2xMA4ZYnGuYtpPDtNI no9Ulq8jJOfcw4e+hnXZubrOH/uGfZpFxXG9lM6IcQFWUeR5RMc3mxm6gH1IOh16IKgz8fXij uTb8mAx74wZw4HZlqU0SZ+fOAa+MsgQMysTnfj7Ypmm6ZCRjiCa7ZgtbyTMvSggKfJQGnUn/a uNn0JFxBcxoGpJnKrZhdqrthKjHFTP8DBeTZhNE+bMgvazbI8wuN4BQICr9kQCLT7Nj7AErD3 dNW9bR3ceS/gDgnZaNW78f/xm4EOfYimqCYW9ztVvxFmCTM7Q3fA22gM9ECHw0RsxqnsBjw43 dEw55GAQtaKpularND09XBsTPoSm/TUjJbhQHqV1mWsLoxtCwpAXVLWLWM2stiGgAUkjBBBW0 ISQaoUkxqQYR3j8KhhzRm/+sTPXHH7NL/70scGH2CJ0hqUt6yKyoWhZuNERAajcQ/+Ww/jj+L 2Ps2fDyvvGT8dDExaIc6VSzdlUup3BvMq+u4x61nW7O0BcLd8gxj+PVNsmoiZxb8+oWyToIE+ MnRqxWzxDFKH8IRIUQ678chgi3lpNJam2TlO25CyO5VBH3MsShFbvQFO+o5HTzLUV6XrByq9u uYh6tIo4R8CKm6yRn5VUZvrKTNZAkTGXU2kqNu6g/VOE1J19jM4jvkLWu+Ox8CC+/jXF1ZOGS oYZ3nCfNcNsLjOJtCoetZ9Jswlent7wgKhcNY6j+jkAjibAt2pIgc1TIyeg1kUfCLayZdqfCu NlyHo438nxHjCjcxAWRSJZ+RnWmRDnfj8Ekj4yZL1Nr/c9VVS90i6nOiE+ca/o6T7l+gbl4Pb PFe/vo8kYm+w3aRqJPYvRWwLicQTTiADy+3VEVTQNf8op X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: Hi Lars, >> The device-number in file-attributes (nth 11) is a cons cell when called >> on remote files (see tramp-get-device). >> It would be great to notify this in Emacs documentation and how to >> interpret this value e.g. (-1 . 1). >> I noticed this in fixing a bug in dired-async.el, the code was using `=` >> to compare the two values which is legitimate according to docstring. > > Hm... would it be possible for Tramp to stash that information > somewhere else? It is (as you say) documented to be a number. Yes, Tramp is out of the documented API in this case. And no, it cannot be kept somewhere else. Inodes are unique only on the given file system. That's why there are device numbers, which identify a file system. A remote file is not related to any (local) file system. That's why ange-ftp returns -1 as device-number, always. This is good enough for practical purposes, because it is different to any device number of a file system visible on the local host. For the inode number, ange-ftp uses a "virtual" one, which means for every accessed file it increases its internal counter. By this, all files accessed by ange-ftp are regarded as different if they differ in the remote file name, even if they are equal. Tramp did inherit this approach from ange-ftp, with the difference that it uses virtual inode numbers only in case it couldn't determine the real inode number. It has its own counter for virtual inode numbers, divided from ange-ftp. This had several problems. The device number of all connected remote devices, be it via any Tramp method or via ange-ftp, was always the same. Remote files were regarded as equal if just the inode number was the same, be it a real inode number or a virtual number. Therefore, in January 2003 (almost 20 years ago :-) the device number in Tramp has changed. It is now a cons cell (-1 . REMOTE), with REMOTE being a virtual device number generated by Tramp for very connection. By this, the tupel (inode, device) still identifies a file uniquely, being it local or remote. As said, this change happend almost 20 years ago. Device numbers are usually ignored by Emacs and external packages, I don't remember a problem report for this over the years. Emacs core creates the buffer-local variable buffer-file-number, which is indeed (INODE DEVNUM). See basic-save-buffer: (setq buffer-file-number (nthcdr 10 (file-attributes buffer-file-name))) And this variable is used for checking whether two files are equal, see find-buffer-visiting: (equal buffer-file-number number) That's why it works also with Tramp's interpretation of device numbers. And again, w/o blame over the years. I tend to agree with Thierry: we shall document the status quo, i.e. device numbers can be more than just an integer, and should be compared via equal. The details of that structure don't matter I believe. And perhaps we could even add a helper function to extract the information for a file's uniqueness: (defsubst file-attribute-file-number (attributes) "The inode and device numbers in ATTRIBUTES returned by `file-attributes'. It can be used to determine whether two files are identical." (nthcdr 10 attributes)) WDYT? Best regards, Michael. From unknown Sat Sep 06 09:27:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Oct 2022 06:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: Thierry Volpiatto , 58446@debbugs.gnu.org Received: via spool by 58446-submit@debbugs.gnu.org id=B58446.16656426783813 (code B ref 58446); Thu, 13 Oct 2022 06:32:01 +0000 Received: (at 58446) by debbugs.gnu.org; 13 Oct 2022 06:31:18 +0000 Received: from localhost ([127.0.0.1]:59071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oirkU-0000zQ-0t for submit@debbugs.gnu.org; Thu, 13 Oct 2022 02:31:18 -0400 Received: from quimby.gnus.org ([95.216.78.240]:59442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oirkS-0000zC-91 for 58446@debbugs.gnu.org; Thu, 13 Oct 2022 02:31:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VLuBpitqmfF/yC22UjbGsHQBLlXi9poEfmUr3N1ht9c=; b=vQiA6q1xLFX/WqMfEplpmTgyz/ ou13A1BhIu/GYeqzrIiT07UPo980f0RfGJDynflnu/NrTTHZnuNsbA1KxFwiwXFDf/0Vl7d1TKr8m wRyhRKe2ZKM+cwXTObuiAEz+G88qUYxSKi8GFunlIUhAuExCyyrf2KSXi+sDuCdbUAIo=; Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oirkI-0005H4-M5; Thu, 13 Oct 2022 08:31:09 +0200 From: Lars Ingebrigtsen In-Reply-To: <87edvd5bun.fsf@gmx.de> (Michael Albinus's message of "Wed, 12 Oct 2022 16:57:04 +0200") References: <87lepmusw5.fsf@posteo.net> <87pmexcn1h.fsf@gnus.org> <87edvd5bun.fsf@gmx.de> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEXR0MuAf31OTU3/ //8fmzB2AAAAAWJLR0QDEQxM8gAAAAd0SU1FB+YKDQYbFANy8RYAAAFVSURBVCjPTdKxTsMwEAbg /6I4opmCRJHSHUTzFI7UdmDy0A7NxACoyVOABBJjQChSmTokqL6nxGfTKh5sf7J9PucCIGdpWwPX 1LPMbdMKGv4Rdd9uTtz5bYMgsZB5Pz86pEcS6HTrMDtEsoBkL3gtuCoNonfB/Ywz0qCVgLUFuahf HswboNp8SjR3O+uIl4LE3cdtxGbwGUhk4t6G3Kqhp21W+6z3arN2460AH77HzRiFlv5ijEnAfIw7 jFd8n46RAOv4DI06B+oTCvfRbECLqQt7PEFaH+AHCkgtcW0uw7ZZRU8GV/9IJat1uGebaGVol3tM qVet2k10gCUXUnnExEtzfSCPRc7d4KrokdXc7bnUmYetpFovfoW44sHiIeTGK4vHM0ouWxx0QMu/ Gv4hk4j7hkFvEq1I5G9BtCApSRlKH2clqCnrxr1SKRhQRU3tDsfKZH96SXyAqR/HgQAAACV0RVh0 ZGF0ZTpjcmVhdGUAMjAyMi0xMC0xM1QwNjoyNzoyMCswMDowMLG1kZ0AAAAldEVYdGRhdGU6bW9k aWZ5ADIwMjItMTAtMTNUMDY6Mjc6MjArMDA6MDDA6CkhAAAAAElFTkSuQmCC X-Now-Playing: Rival Consoles's _Kid Velo_: "Kid Velo" Date: Thu, 13 Oct 2022 08:31:06 +0200 Message-ID: <87edvc9qvp.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Albinus writes: [explanation snipped] > As said, this change happend almost 20 years ago. Device numbers are > usually ignored by Emacs and external packages, I don't remember a > problem report for this over the years. Emacs core creates [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Michael Albinus writes: [explanation snipped] > As said, this change happend almost 20 years ago. Device numbers are > usually ignored by Emacs and external packages, I don't remember a > problem report for this over the years. Emacs core creates the > buffer-local variable buffer-file-number, which is indeed (INODE > DEVNUM). See basic-save-buffer: > > (setq buffer-file-number > (nthcdr 10 (file-attributes buffer-file-name))) > > And this variable is used for checking whether two files are equal, see > find-buffer-visiting: > > (equal buffer-file-number number) > > That's why it works also with Tramp's interpretation of device > numbers. And again, w/o blame over the years. Yes, I agree -- we should probably just document this. But I was wondering whether it would be useful to make the `file-attribute' structure extendable? We could have a twelfth (optional) element that could be an plist of properties, and then we'd have a place to stash stuff. (That might break stuff, though.) But if we haven't needed that until now, we're probably not going to need it going forward, and we should just document the current status quo. > And perhaps we could even add a helper function to extract the > information for a file's uniqueness: > > (defsubst file-attribute-file-number (attributes) > "The inode and device numbers in ATTRIBUTES returned by `file-attributes'. > It can be used to determine whether two files are identical." > (nthcdr 10 attributes)) > > WDYT? Makes sense to me. From unknown Sat Sep 06 09:27:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Oct 2022 07:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: thievol@posteo.net, 58446@debbugs.gnu.org, michael.albinus@gmx.de Received: via spool by 58446-submit@debbugs.gnu.org id=B58446.166564494025080 (code B ref 58446); Thu, 13 Oct 2022 07:09:01 +0000 Received: (at 58446) by debbugs.gnu.org; 13 Oct 2022 07:09:00 +0000 Received: from localhost ([127.0.0.1]:59255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oisKy-0006WS-FT for submit@debbugs.gnu.org; Thu, 13 Oct 2022 03:09:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oisKx-0006WG-7o for 58446@debbugs.gnu.org; Thu, 13 Oct 2022 03:08:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45862) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oisKr-0000xQ-Aw; Thu, 13 Oct 2022 03:08:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7LyaBe6wgBFeeTP/ntGSLNsJeOqocE3V/T5DP0lCW4s=; b=KT08Bvru17HH 3m3k578nH7NxSuX5jw/AI2WkDAd5Nd9WLY2R6u4CobpINNrPON3/WJY4ujurDwjU65kdax3TBihYP 594BVu0u6nhRuetquhcqqkDrgKL21brv33eBLYCJCT/m2OxJimRJKiTXTTr9qqWEEv51lvBdiiqVz LerrtxW/pN9C7kenokkAYOMW0ZDiXKxQ66Tpv6w+kXUSJr6T++gxTeRxU9k9aL7e7TNjw4X2zifL/ LcXeXNnfLzvU4VzsEKgsuZRmlgbv8QbGZMR/VoICggkB2dsbmmIJIT2NPBSZXCpBdrFeCpbPJzCri 2W7hcU/5ttc1h7vRrVP5pg==; Received: from [87.69.77.57] (port=2022 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oisKq-0004Dm-Cw; Thu, 13 Oct 2022 03:08:53 -0400 Date: Thu, 13 Oct 2022 10:09:05 +0300 Message-Id: <83zge09p4e.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87edvc9qvp.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 13 Oct 2022 08:31:06 +0200) References: <87lepmusw5.fsf@posteo.net> <87pmexcn1h.fsf@gnus.org> <87edvd5bun.fsf@gmx.de> <87edvc9qvp.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Thierry Volpiatto , 58446@debbugs.gnu.org > From: Lars Ingebrigtsen > Date: Thu, 13 Oct 2022 08:31:06 +0200 > > Michael Albinus writes: > > But if we haven't needed that until now, we're probably not going to > need it going forward, and we should just document the current status > quo. > > > And perhaps we could even add a helper function to extract the > > information for a file's uniqueness: > > > > (defsubst file-attribute-file-number (attributes) > > "The inode and device numbers in ATTRIBUTES returned by `file-attributes'. > > It can be used to determine whether two files are identical." > > (nthcdr 10 attributes)) > > > > WDYT? > > Makes sense to me. Agreed. From unknown Sat Sep 06 09:27:43 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Thierry Volpiatto Subject: bug#58446: closed (Re: bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer) Message-ID: References: <87o7ufzg7z.fsf@gmx.de> <87lepmusw5.fsf@posteo.net> X-Gnu-PR-Message: they-closed 58446 X-Gnu-PR-Package: emacs Reply-To: 58446@debbugs.gnu.org Date: Thu, 13 Oct 2022 19:17:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1665688623-10580-1" This is a multi-part message in MIME format... ------------=_1665688623-10580-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #58446: 28.2; file-attribute-device-number returns a cons cell instead of a= n integer which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 58446@debbugs.gnu.org. --=20 58446: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D58446 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1665688623-10580-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 58446-done) by debbugs.gnu.org; 13 Oct 2022 19:17:01 +0000 Received: from localhost ([127.0.0.1]:34988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oj3hU-0002k9-Mw for submit@debbugs.gnu.org; Thu, 13 Oct 2022 15:17:00 -0400 Received: from mout.gmx.net ([212.227.17.20]:44203) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oj3hS-0002jm-Lc for 58446-done@debbugs.gnu.org; Thu, 13 Oct 2022 15:16:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1665688609; bh=KhRDnPtN5NIq+Gng1LJCcWt39wjbc/FqjROvt9KP4D8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=PWpYQYYB2fpvHNr+KG97zXQTvlmGiXTNJRorGRSWc6YmuyTO17abTezqO7Ol+GUfj mxh9Nr3VxLlLwXxhrV9b9b8v/IdFL8f+1XZ3HQtExKpiMGD4AZI6eh4gk/GgmsEz79 BWo05raVugCBxysfL1ELpIBhCRF+wPwPawy09FNY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([79.140.125.47]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MlNtF-1pQL882KQX-00lk6c; Thu, 13 Oct 2022 21:16:49 +0200 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer In-Reply-To: <83zge09p4e.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 Oct 2022 10:09:05 +0300") References: <87lepmusw5.fsf@posteo.net> <87pmexcn1h.fsf@gnus.org> <87edvd5bun.fsf@gmx.de> <87edvc9qvp.fsf@gnus.org> <83zge09p4e.fsf@gnu.org> Date: Thu, 13 Oct 2022 21:16:48 +0200 Message-ID: <87o7ufzg7z.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:GMhJTBYWc/bLtYQcTusm68Le+5dQulRLvfQaLn8du7CQu0m0ulR AnQEXwsZGbGyYWgXAD4Bf6ryyH5DBPVtMKY2dh0EuwhJK7glvKjxID4UwQud53CP3gTqEBr szl5ayYNtpwlYZCSWz3yli6DBdynDEY114n6FQCsvkEtmGqObJ5IdS04cJGNO1n0aYhSqWO iIk8h8c3GdyDoWW0aK5Xw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ZiWVfKV0Jz8=:Q3YEU/pcm3NCo22aJdFCtK Sybwj36lAA2b7xIbXFQ2beAF7/IWLnMqN0YXYK4l6+VpM/zyeQLLwfjiBtaud60kMEOp70xus o5jK9iDP9LeUR2UXllX17XEITyHuG+Zt6gj2T7PC6s8bLuislnGuV3UIZDgdyYIVDrDBhc/NH Oss2wemvhqslsn2cOvdnKewQWmDCThzX4aSNLUuKgTCHddOetlk781Gq31Rw1MbFXzwO2kkVS cVXUv5KXUkHjsAM4GAGYgJuqowCNu8+dLslblJLaC/Lr6oEXqamFWCWVPvIm5EFPW0sbfFBNt YLKbQYiZnzTp+1N8AvYzoEVM53zPpt70GxwC9sBoRzt+98S2ZNoGUiUWNwsH/D3PZg7Dits+e VwsovzeYTqBJNwVut4WMy667IWf1dFsEAU4By+OIA1yBhnZ9DyzArlxA+K7QBgBmVZZueO6gS 3Aa7VNgbHHNzOGxSgRmtPogv2jfcYc/3vhXIpI/yWhAJ2/TeQ+T2aHOEg3y8gcRj1BbfScYjS eIBDLO2PfLea/uqP658w5USd/Q4R+rDR28YPq75YDlk6g9wMY1pdeOtNy0SrSgifZzG8GtkJ/ o/rpKPp68s4PdLYccCWIPqOZaK1o2Qklam4dD0oCDkxH96vkyk99F5wNKP0y/3oLbVsI6dUXK EUBA+FbSXo/sDqDoPpjD2xqIlleSqpKUPEcwwopPYg6GZEOUSRa1xxj/5yOusbYbG9PJGCXFA Y3G8SVNuBiSQeLskbhmWhKzY+/RMiHjhiYhVbzMjeQdsAa6acl87IkqwG1RML97rWsI5s5/Vi Huoiqo6W4ydo2eh6qdljvuCWlPRIQ120VIyr7WkHlWLaNqYf/CIGqTJHYNbyiAkxz9iU6PFRt OdV4N1p5HCkbmkUJU8axPMlMD9j79r7oWYW77qh0rKuc18uHtIx34mT/kFKa/sxQE50KkILM+ vY/w55eCfL1w/vCuEYOlhWUg4lNIG3mLzkisSVIbUbpjJpCgd6dnTLkvJMvbbNUf0DSxhkmVP /lbycQZ0Enh8Q36UMcV3Krf0+n6Qtn1IOv7ouZE35Tyxwvnj8mWvVn3xISze7hrHCgzyb0+KD ZyEkQMjvN+nAnk8NYiG3DK/CmIn/occ3qMmKXd0367PLqyVynUkWSupBDx2bvZdVICu/xfWn/ utrUn52KTTJX2PDFyxLq5YRsFXtQy+03sdixE9PkzRls/K/bBJdKJMlhxtdPybM9GWOJdBuYQ nWNWvgodx4phtwXNfznhy/d9/cqsq5pJMn/ZSQLfyWum3XTRFB88c3GGcRnYhNKSQGmiZ9Aug Qb6LZhjmQnj3kitWtPdQtDFuH+dwsAuUeejEeL+z2CHzV28MeQFk4OVQ1wTnhTMCOIYqE2dsR 2grIZrZ/GqsFFXddJS//zrYDhj/YvbhA/b+faZdGNTQ5MrL1m7iUyNB+yayBA3Qgpy0qHCDKy BI02xSwP7kJWlT5JG3owvhiP+AiVyRfD2VQJqqBrXyicbOrezeHcVUpC6ZpIZAOoIAeWEjFb2 KJ875H4xm5UF7MhJqit3j0hwB5d5q2Xh+z/G5E7X/BLiH Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 58446-done Cc: thievol@posteo.net, Lars Ingebrigtsen , 58446-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Version: 29.1 Eli Zaretskii writes: >> But if we haven't needed that until now, we're probably not going to >> need it going forward, and we should just document the current status >> quo. >> >> > And perhaps we could even add a helper function to extract the >> > information for a file's uniqueness: >> > >> > (defsubst file-attribute-file-number (attributes) >> > "The inode and device numbers in ATTRIBUTES returned by `file-attri= butes'. >> > It can be used to determine whether two files are identical." >> > (nthcdr 10 attributes)) >> > >> > WDYT? >> >> Makes sense to me. > > Agreed. Pushed to master. Closing the bug. Best regards, Michael. ------------=_1665688623-10580-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Oct 2022 18:17:50 +0000 Received: from localhost ([127.0.0.1]:54782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiJp8-0004Y9-0z for submit@debbugs.gnu.org; Tue, 11 Oct 2022 14:17:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:50894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiJp6-0004Y2-7z for submit@debbugs.gnu.org; Tue, 11 Oct 2022 14:17:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiJp6-0006aa-13 for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2022 14:17:48 -0400 Received: from mout01.posteo.de ([185.67.36.65]:40769) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiJp3-0003RC-5P for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2022 14:17:47 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id DAD00240028 for ; Tue, 11 Oct 2022 20:17:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665512259; bh=nAGQYIzs25msjU0NDYYQlQyhQjpSbRjO7DWeD4KekbQ=; h=From:To:Subject:Date:Autocrypt:OpenPGP:From; b=rXtYF3LfOzYsUVLIug68O082N5CVjgU79pi1XRIHantPJZX8Ua+GgKNT969Upm1+P vmaUds6HAyMR0Jbfhp20OJS6aOU6HnxRDRnjMOYtKGww3kInL9BidWrM0l9lzJf7eS C5V/2ohYJVj1cLNs6IjfVVG8+KtCCa83BcEehzfJBGiVoxIDuigLn/JrN2Kmtv0XqO yGY0idPd3LhZHYtUeAi4vyPjiFnsGaozBC6rm1ox/yF1CnvH6YnmMFLnFNY9d2Scby LxUURmp1pQc8B6oi522SdWS9rxq+qBF14yebUsWr3yhaehA7cGtzDMw37+1FxcV+k+ JkeHK+iVhudHw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Mn3sr5Jdqz9rxD for ; Tue, 11 Oct 2022 20:17:36 +0200 (CEST) From: Thierry Volpiatto To: bug-gnu-emacs@gnu.org Subject: 28.2; file-attribute-device-number returns a cons cell instead of an integer Date: Tue, 11 Oct 2022 18:11:18 +0000 Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata= mQGNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA AbQSdGhpZXZvbEBwb3N0ZW8ubmV0iQHOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaAtdXm5bYnSHsnL7cx8z7lukA/ EsJocE+GD7QXnsrdlicvdobI0TEN4l73221a72oCvHfYLCVsB6YsNJ5ZGkA1zSjzln5uLAgZ/2r/ aqlao/AlSZkAk6+hvK0RyAZ/YR4YRZxO8Fsd0gWgFkanRfKfufJ1V0OHZg7yszi3q/hRzS+rZtJ0 OuzDlh/dyQkxVkZb9vis/+HnGDJrBE5MsmJLcy2Sy3uUnio0fq8q9CrZbudvd1DajlZxPzTm0csP eUk45QEgbhEU7MfyAX/mkKxjHajz2cMcHKIap1BqEgJl4BKFeLMcBZ4O1p9ivwtf1Ht2JTp5lOi0 ItPfhQ4DP8LZ1ZIkN5Kg9v0cyw9meRzAuuR0V2GtuQGNBF8ylcIBDADnIDHEkmk4lUwTlOhwb2yj UfmGPnpH3MCCHkjM9H/P1gTHxFWtwFVPcNMCwXWvKSBTF2dZXKERD0yzG06zT53ZMN7EIIeuY6m4 R8IcMvpohciisWxbFoB4ZY117tVSeqjo946itgbpdeESKl9a8dpn7ytZMyYxPdojlQAqxeAJ8444 raESh1oTKXb64hlk4l2pSRlrLgjpJBo8asAfZndaxIUKhw68tV8sqeZh9P6cGtHbUELKVJqefNV7 V7jF5wf3xvRG6Ces3kSKXalLfs+vrVaoOjQeWrc0AtwFWHmt9JLfKrqF+Q2Q7jUidboWmazQM56E SJFPpPHmWq8k6DHspsFHOforLouTHJL1556IPne7IV2BGfWc0+xLxalZ8F5F+vnPF/OkrC1CD5iC KTjXKa2iZbcYdYQAiL6P8Ac8CgN6EkhpbxRtzrEgChuNGevdi/G/GHG4Zqrh6YFwIa/NHq2aVaFq 5C1yNTMJd1FRjRzs5JPPlJKpYDnNx+MSp7UAEQEAAYkBtgQYAQoAIAIbDBYhBCPbcH0Te6954oP8 cA7FbRQdFu+TBQJi9x1ZAAoJEA7FbRQdFu+To6QMAIcvUSiFwCIggxkmYy3ZY0QAMLmIPga8DNPM XbfSOBDb2KLGBd+FAA8p2GExpul4r6kOYnGogtojByHmVgrd30/3ZURTM8Vj51wwD05viMZccQHl Wd9J/qZIvhBJlJWYnwVxh+2Kg4/hkx7SGc7JJS5GS37+PFQOJHPGMxc+fe4Ty2FdjIOVf3P1Hov9 K6yBI7Af66qqcL3aKJ4jJidRYN8sMaKOqEu4rcSpTxp8/3Ddbs9HezUgXeUzOLJMcEYFlvCyC8ZS l/QDZmpobKbxZ1JAqZM8lnmcZYSV7OsWnxJIYDV1gH5LTLj7bGswXaB4B+qkckihWkRZixu8q1IK 0c/xwUzyF092uFRM/sQKrSmnwA1+hQiiIuEl4XVz5li0/TmMta3ijUM7GNbl2IjioTRxWWecwad1 mNHvKTcXPsKDAbHFdLvQzurnroBHQV0jSPNLTP5Suo7RnLbehfg5INpGjToCUlrd2qQqgXW7h5qZ TgUq5UmBc7YZ0JYWQgPTbQ== Message-ID: <87lepmusw5.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=thievol@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The device-number in file-attributes (nth 11) is a cons cell when called on remote files (see tramp-get-device). It would be great to notify this in Emacs documentation and how to interpret this value e.g. (-1 . 1). I noticed this in fixing a bug in dired-async.el, the code was using `=3D` to compare the two values which is legitimate according to docstring. In GNU Emacs 28.2 (build 1, x86_64-pc-linux-gnu, Motif Version 2.3.8, cairo= version 1.16.0) of 2022-09-12 built on IPad-S340 Windowing system distributor 'The X.Org Foundation', version 11.0.12013000 System Description: Linux Mint 20.3 Configured using: 'configure CFLAGS=3D-O8 --with-mailutils --with-cairo --without-dbus --without-gconf --without-gsettings --with-x-toolkit=3Dmotif' Configured features: ACL CAIRO FREETYPE GIF GLIB GMP GNUTLS GPM HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM MOTIF ZLIB Important settings: value of $LANG: fr_FR.UTF-8 locale-coding-system: utf-8-unix Major mode: =C6=90=C4=BD Minor modes in effect: bug-reference-prog-mode: t global-undo-tree-mode: t undo-tree-mode: t psession-mode: t psession-savehist-mode: t global-git-gutter-mode: t git-gutter-mode: t display-time-mode: t winner-mode: t helm-epa-mode: t helm-descbinds-mode: t helm-adaptive-mode: t helm-mode: t helm-minibuffer-history-mode: t helm-ff-icon-mode: t shell-dirtrack-mode: t helm-popup-tip-mode: t async-bytecomp-package-mode: t dired-async-mode: t minibuffer-depth-indicate-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (epa-mail face-remap addressbook-bookmark tv-mu4e-config mu4e-contrib mu4e-patch mu4e mu4e-org mu4e-main mu4e-view gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range gnus-win mu4e-headers mu4e-compose mu4e-draft mu4e-actions smtpmail mu4e-search mu4e-lists mu4e-bookmarks mu4e-mark mu4e-message shr kinsoku svg flow-fill hl-line mu4e-contacts mu4e-update mu4e-folders mu4e-server mu4e-context mu4e-obsolete mu4e-vars mu4e-helpers mu4e-config ido shadow sort mail-extr helm-ring eieio-opt speedbar ezimage dframe shortdoc help-fns radix-tree emacsbug sendmail cl-print etags fileloop generator xref tabify jka-compr helm-command image-file image-converter tramp-cache epa-file char-fold em-unix em-term term disp-table ehelp em-script em-prompt em-ls em-hist em-pred em-glob em-cmpl em-dirs esh-var em-basic em-banner em-alias esh-mode eshell esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util esh-toggle tramp-archive tramp-gvfs dbus helm-x-files helm-for-files markdown-mode flymake-shellcheck flymake-proc flymake project warnings sh-script smie executable bug-reference naquadah-theme view solar cal-dst holidays hol-loaddefs tv-utils osm dom yaml-mode undo-tree diff queue rainbow-mode color psession frameset log-view pcvs-util bash-completion cl-indent pcase ffap thingatpt autocrypt-message message rmc puny rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader autocrypt-gnus gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 mail-utils mm-util mail-prsvr autocrypt-mu4e autocrypt ietf-drums config-w3m git-gutter mule-util appt diary-lib diary-loaddefs gud wdired dired-extension org-config ob-gnuplot org-crypt net-utils time winner autotest-mode autoconf-mode woman man ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util init-helm helm-ls-git vc-git diff-mode vc vc-dispatcher helm-fd epa derived epg rfc6068 epg-config helm-epa helm-imenu imenu helm-elisp-package helm-find helm-org org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic bibtex ol rx org-keys oc org-compat advice org-macs org-loaddefs cal-menu calendar cal-loaddefs helm-external isl helm-descbinds helm-wikipedia all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons cus-edit wid-edit wfnames helm-ipython helm-elisp helm-eval edebug backtrace find-func python tramp-sh popup helm-bookmark helm-net xml helm-info bookmark pp helm-adaptive helm-mode helm-misc helm-files image-dired image-mode exif filenotify tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat shell pcomplete parse-time iso8601 time-date ls-lisp helm-buffers helm-occur helm-tags helm-locate helm-grep wgrep-helm wgrep grep compile text-property-search comint ring helm-regexp format-spec ansi-color helm-utils helm-help helm-types helm-extensions-autoloads helm-config helm-autoloads helm helm-global-bindings helm-easymenu helm-core async-bytecomp helm-source helm-multi-match helm-lib dired-async dired-aux dired dired-loaddefs async diminish cl-extra help-mode mb-depth server edmacro kmacro avoid cus-load use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key easy-mmode use-package-core finder-inf package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib info w3m-load iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads inotify lcms2 dynamic-setting font-render-setting cairo motif x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 1834152 77310) (symbols 48 43794 4) (strings 32 346905 22367) (string-bytes 1 12371838) (vectors 16 89769) (vector-slots 8 1894146 124249) (floats 8 3996 656) (intervals 56 347767 1990) (buffers 992 115)) <#secure method=3Dpgpmime mode=3Dsign> --=20 Thierry ------------=_1665688623-10580-1-- From unknown Sat Sep 06 09:27:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Oct 2022 17:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: Thierry Volpiatto , Lars Ingebrigtsen , 58446@debbugs.gnu.org Received: via spool by 58446-submit@debbugs.gnu.org id=B58446.16657670845085 (code B ref 58446); Fri, 14 Oct 2022 17:05:02 +0000 Received: (at 58446) by debbugs.gnu.org; 14 Oct 2022 17:04:44 +0000 Received: from localhost ([127.0.0.1]:38496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojO71-0001Jx-T0 for submit@debbugs.gnu.org; Fri, 14 Oct 2022 13:04:44 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:33177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojO6z-0001Jk-D7 for 58446@debbugs.gnu.org; Fri, 14 Oct 2022 13:04:42 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BFADD10012E; Fri, 14 Oct 2022 13:04:35 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 22D67100098; Fri, 14 Oct 2022 13:04:34 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1665767074; bh=rhBVn+ikBxzEUdmZbvy2TaM2rjxSLSNLFLjEiK+R2R4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Vo0CHso9n3Ls4zJcO8MHpK+ENqf1VpYuFDEDkZ+HGPp8kMeziM4k+10h3eBZNBtF4 p2gBhVWtCnbcSF0ejrNbqpyWFg9toOYabcgqrUbNVdfq98NtQQDbbU8unEguZF8ySc /uMeq8/CUegnvMsZbfYAKiJtHx/9RIxrV67UKOenz0nveqkZ/a+rLx3mIAnClPV/fO qIebrUz64zmECTF4bTw4XyrQgh610M9QpSwkH/UXuiCz5fCeHmRA4Y8NUAoc8SWcSC Lm2MC79DyeYRYC7z+1nwXi734mMYEArD7kVKecJ7+seuFXrd9ug9aqQpRo2WNxtT1y xRxrHUT3CW9cA== Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EB9D0120F32; Fri, 14 Oct 2022 13:04:33 -0400 (EDT) From: Stefan Monnier In-Reply-To: <87edvd5bun.fsf@gmx.de> (Michael Albinus's message of "Wed, 12 Oct 2022 16:57:04 +0200") Message-ID: References: <87lepmusw5.fsf@posteo.net> <87pmexcn1h.fsf@gnus.org> <87edvd5bun.fsf@gmx.de> Date: Fri, 14 Oct 2022 13:04:31 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.081 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > (defsubst file-attribute-file-number (attributes) > "The inode and device numbers in ATTRIBUTES returned by `file-attributes'. > It can be used to determine whether two files are identical." > (nthcdr 10 attributes)) > > WDYT? Sounds good, except: - The name `file-attribute-file-number` doesn't sound right because it doesn't return a number. - I wouldn't use `defsubst` (so it can more easily be modified in the future, e.g. in case we add more fields to the attributes or use some other representation for attributes). - I would document it more abstractly, mentioning inode and device number only as *examples* of things it might contain. Stefan From unknown Sat Sep 06 09:27:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Oct 2022 17:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Thierry Volpiatto , Lars Ingebrigtsen , 58446@debbugs.gnu.org Received: via spool by 58446-submit@debbugs.gnu.org id=B58446.16657685047603 (code B ref 58446); Fri, 14 Oct 2022 17:29:02 +0000 Received: (at 58446) by debbugs.gnu.org; 14 Oct 2022 17:28:24 +0000 Received: from localhost ([127.0.0.1]:38519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojOTw-0001yY-62 for submit@debbugs.gnu.org; Fri, 14 Oct 2022 13:28:24 -0400 Received: from mout.gmx.net ([212.227.17.21]:39065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojOTt-0001yL-Lo for 58446@debbugs.gnu.org; Fri, 14 Oct 2022 13:28:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1665768492; bh=nGgG3SI628v0Kb71HaxnL4CYrNcFysUyeE+BmFWAR28=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=X99JuV/sQp/F6uJQfUxoHBpPmd7rKao43ioQXi7VZvO5hMdx9HoX7tW9Ls3UEceBs tTnFv79NrlzPXYf3RecHhnYUQUpDo/Dp2+RKSiPQEmiy4WMLjvJ6U49GrO2VXScKgV 15pEkuYnqvqnEovWXN9kEWLoNgo7ny2kn2yqg0RQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.151.229]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MsHru-1ozGhV41ak-00tmqm; Fri, 14 Oct 2022 19:28:12 +0200 From: Michael Albinus In-Reply-To: (Stefan Monnier's message of "Fri, 14 Oct 2022 13:04:31 -0400") References: <87lepmusw5.fsf@posteo.net> <87pmexcn1h.fsf@gnus.org> <87edvd5bun.fsf@gmx.de> Date: Fri, 14 Oct 2022 19:28:10 +0200 Message-ID: <87wn92xql1.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:EtvympWu/01WBcJAy9TaA8fjb+xYxCLuQLmQ56ruNQXlyl2qmmi RFNbFK4z+es/1d7IFw/0DJrp6BqjBZP6jLRTqA/RsLR3sh8zF1SDUpEvG9HJK8ZMfwVbevo MgdGMy1ETA0hCTYRM91xgnlE2V0CH5KVs3IlOD++/7sqoqxV6cTeJwxafN6nlttAH0MeFPs 8ppPLA/OtCsfSAxtBgcrw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:fhVXl5WPncA=:PlxL3daZrSW1Bgqaxq42wP HME6s3xcMfObOv7kkQjLFYF7boAF70Amf9ADZ/iRO+VeUZrCeU3zGlL6Yam/U1G3OJ492UKUj BvjYyMYF6SzAQkHAQcQ42ys6/obTiJv0TMDTIZcwP3QFatNUmUW2Z6bvzdHudJ29QrH11gzKP NH+e57Qi4HZ+mgKFX/akZl/YpnjGdt0MKUJ4FrN2BwQN6AIC93SfR/anW/Ccw3J93Aj2OhQ56 opyXWZhNpP+ZAnpwQjvQginGfGr/u6lxqExzjrhqcgsuIi5fTdB+AefuTgiYMUFIF0xcBpPHi hSXUAiF2nZDAFt75+KfVgnKRoehJTGbKbg7t+TAESU11tbWBYuvIXBZoJRA5XbsUmrzKJMHHr lGZKCGflEFvOl7LBFVUZItaXfiybpwWUSJB0kpJUI9SskGl8SD+IIniE2eaqcNzBrGTkadHJ4 fcjTtQCHPKaj6BIULXB0kB8EEncYVLJAYuS/h+s+3832x2TcfDwS5Z2LQhv+8moTv4ic8Kei0 d4kIRdF6AnrMcUXTn7QalMOZ9z5R++ujJY3QQVV/YDJUIJca5UrT4G/pGtijFxtTiWA8enmt9 wp6Ef1fvq8pjygUgNo77Ud0hFAUeSHBkNlmKrhdaB8wb7E/8tqiKjCgIlDuSECWU6OeNBbScR ENF3zirmFGZdI5xtvM1yYhhuN1AdLuHQE9X4m13bzcGXjsJC3KT41liqnH7rmSHdLTqNfchGQ lqCfEy+q7aN5eZcwNT7PU5hzpYIA4lyZjz9UEcdKA5vzqfGa+ZLonM1dAOyMtnuUf1f1GXCt/ RR9Neh4kT+1IBk26RddmA8DwquwqwbCqQcGBntd/P+SUS87UPjkfNvNPo9NeMUpuBE5Z7KHuW SZc1rY8JOjOehFFHET86XX3EE0zSEt0+S2hAVNb2nmaWrW++CkTMWI3ebSh2fDrhs+EOOZq1X uQkykMqO8un3zauNkRdykDj2Qq0zWT68h/ZYgBD8lZ/7CApCtCv9yu+R0Ht/ydUmLtP4sFkoX K3AomJTIlkM2fxmUt4rNKoE5t2RHcsDiYDZUaJaxk1p8j6Slxmod9dqpGnzJWG1x9M7iqyjkx vbj7mepTAo+3j+BmqI6TYRatx1UXxcFnUp5Yg0/6Qwfphlb5MnDwpdeRiUGxUvxKaqf37IUYd Njof+GetgiO7CZjVQQ7RWeBAMNHWrbCVbciZS3Eo9zDy3PVlo6d0AcdHNFLaXCudVo76HcZ+4 UA8Dfb9zPmIUZhlVJPyU19/UO/M9oxt/cPwy3iUREo3YkW4XLVU9YbD0mZCk8mWKuZhJ+o8oR fWIqBrk+nnHQBfD5eP/be+3MUhH36ZvjEssn9TIpvSfJOc00tdiawOTgYQE0yZfdCC7xloDS5 M2M7iZ0r6w/Ilr0qSnMKhws9dNDRQtHVgsPguKVgxboDaoioTQF/Y6e6RD2MHCcXFMHVAYKm5 olgE1DSIYqofeydzsEDRImzFcM8GPv1500HlTsKXTIlufK+4//DJKcBoWKdUkk6/aY7/yFZQx mlzSRNhjfw2k/FfXIBbXmeztMFE4H4Xck17f4A3rBkxD8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: Hi Stefan, >> (defsubst file-attribute-file-number (attributes) >> "The inode and device numbers in ATTRIBUTES returned by `file-attributes'. >> It can be used to determine whether two files are identical." >> (nthcdr 10 attributes)) >> >> WDYT? > > Sounds good, except: > > - The name `file-attribute-file-number` doesn't sound right > because it doesn't return a number. The name is a reminiscence of the existing variable buffer-file-number, which serves exactly the same purpose. > - I wouldn't use `defsubst` (so it can more easily be modified in the > future, e.g. in case we add more fields to the attributes or use some > other representation for attributes). All other accessor functions for file-attributes are defsubsts. > - I would document it more abstractly, mentioning inode and device > number only as *examples* of things it might contain. There is no intention to use it for anything else. It shall return (nthcdr 10 attributes) like all the other file-attributes accessor functions return for the respective slots. > Stefan Best regards, Michael. From unknown Sat Sep 06 09:27:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Oct 2022 18:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: Thierry Volpiatto , Lars Ingebrigtsen , 58446@debbugs.gnu.org Received: via spool by 58446-submit@debbugs.gnu.org id=B58446.166577246514958 (code B ref 58446); Fri, 14 Oct 2022 18:35:02 +0000 Received: (at 58446) by debbugs.gnu.org; 14 Oct 2022 18:34:25 +0000 Received: from localhost ([127.0.0.1]:38617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojPVp-0003tC-0K for submit@debbugs.gnu.org; Fri, 14 Oct 2022 14:34:25 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:35019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojPVm-0003sk-5i for 58446@debbugs.gnu.org; Fri, 14 Oct 2022 14:34:23 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 47782441211; Fri, 14 Oct 2022 14:34:16 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9E16C4411A6; Fri, 14 Oct 2022 14:34:10 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1665772450; bh=d7s0RYF2oegQtVEmV5m/MXB5QeD6kpGa1LYs1gZQf8Q=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=G1sVJZDHSP1C8jMn1aOfp+KMctpXTu8dQRjIhJ/ZT4Tu82gZfwRTJu3UdbgvzghKp 9WVKrdOVa6fC8yMf6JwQqAOyCiI/4ORW2MKbBUu8wQa3y4iNBj1U48TIVoYN0SqIJ1 9m5SdtX6H6r+ygLS0bFlxdjXfLtUhWRffS6tfqXa5WKvFXQFgtEtpKdkIM/Q7EC6wd d/rWelrLF/pie+3oKKvk8CSXQZyfqcoSBCi+39ejzdXF9mUPl/vbTX7XGf8fz8l3jl LFZD90qvyk6nes9ezDldmnCERxvGOELsanEKpU/cyZLg2eHNCTPZN5rPzNlaZXhEdX XxHv5w6lZiGhw== Received: from pastel (65-110-220-202.cpe.pppoe.ca [65.110.220.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7200D1208E2; Fri, 14 Oct 2022 14:34:10 -0400 (EDT) From: Stefan Monnier In-Reply-To: <87wn92xql1.fsf@gmx.de> (Michael Albinus's message of "Fri, 14 Oct 2022 19:28:10 +0200") Message-ID: References: <87lepmusw5.fsf@posteo.net> <87pmexcn1h.fsf@gnus.org> <87edvd5bun.fsf@gmx.de> <87wn92xql1.fsf@gmx.de> Date: Fri, 14 Oct 2022 14:34:09 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> - The name `file-attribute-file-number` doesn't sound right >> because it doesn't return a number. > The name is a reminiscence of the existing variable buffer-file-number, > which serves exactly the same purpose. One error doesn't justify another. Maybe a better name would be "file identifier"? >> - I wouldn't use `defsubst` (so it can more easily be modified in the >> future, e.g. in case we add more fields to the attributes or use some >> other representation for attributes). > All other accessor functions for file-attributes are defsubsts. Every `defsubst` should be judged on its own individual value. This one doesn't seem to be justified. >> - I would document it more abstractly, mentioning inode and device >> number only as *examples* of things it might contain. > There is no intention to use it for anything else. It shall return > (nthcdr 10 attributes) like all the other file-attributes accessor > functions return for the respective slots. I did not suggest changing its implementation. Only its documentation. The doc should describe the intended semantics of the return value without documenting how it's implemented. Stefan From unknown Sat Sep 06 09:27:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Oct 2022 19:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Thierry Volpiatto , Lars Ingebrigtsen , 58446@debbugs.gnu.org Received: via spool by 58446-submit@debbugs.gnu.org id=B58446.166577420918244 (code B ref 58446); Fri, 14 Oct 2022 19:04:02 +0000 Received: (at 58446) by debbugs.gnu.org; 14 Oct 2022 19:03:29 +0000 Received: from localhost ([127.0.0.1]:38628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojPxx-0004kC-4N for submit@debbugs.gnu.org; Fri, 14 Oct 2022 15:03:29 -0400 Received: from mout.gmx.net ([212.227.15.15]:35705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojPxu-0004jt-St for 58446@debbugs.gnu.org; Fri, 14 Oct 2022 15:03:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1665774197; bh=+H93OVmAo1lmXhkhGQOdH2gi4RsfCE86lEnVwX5HHNQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=guwZnMtsPJJgynhea8OdxGYEcZNrfHJcg1pTDmo0HY24BvjThJqaZx8dylP4J0sAh +QpW1ptyvPryxaQXUXx6oo68JWAZV9rGRPf7DT42o7RHUdC8s0dVryFkxixIIu9l2E COoAp9edBI7wkPi092t7FypdHYUxtqSpglLyG/Ao= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.151.229]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N0XCw-1p6R1N0ibk-00wY6L; Fri, 14 Oct 2022 21:03:17 +0200 From: Michael Albinus In-Reply-To: (Stefan Monnier's message of "Fri, 14 Oct 2022 14:34:09 -0400") References: <87lepmusw5.fsf@posteo.net> <87pmexcn1h.fsf@gnus.org> <87edvd5bun.fsf@gmx.de> <87wn92xql1.fsf@gmx.de> Date: Fri, 14 Oct 2022 21:03:15 +0200 Message-ID: <87sfjqxm6k.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:N+yLtJ++PgtA+3sAglBMOmfHcVTU6l4wYAwoRnLx5pSuFZcyrDD lhfubKbrM2l8LeiniGV2hKj5zsIDPLbZesFfUwLaXsfVU2f7BvXlKZsmb6i4ITzEKauzcj/ U3geIG6fhkVSxldMSSVo2JQdVI7p9nD1DTaTvwwqE3QNXhcfc2br482rOn2W8BqvWrQwbZE cgd5/SmdnEUjBKthC0hyQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:G6xzO0w8S/Q=:NqW58A1ElZgU5NxBcJGE1o 1t2P6HsYwVcjUaRYNtg9OS0cadgSiN5jyTDNgzZ6bfN8SNKueKaGhMir/1VZqR4eTMs6wYYpM Wrv7/QRzi0LdJVeMio63lc/poQwXbtXduo2Y+VEPQZXYeZ9BO46JNVGYdk4UP7MNWW0zx7QnX vsONljv7uyrEbTltU8Ii7j34gjD067On3fWOg9PaURl6y9Q/ds9XWWDZoWcby+CIDWqVrNzrs I3schW+b0NaQhS84pepVkgxWWfxDbuY2PRJkw9rs6/0aGcmmFpuxe8Ah52YtWLzK/6eW/YPBt JdJL1S+HAa2BtIMNEzX1jszz11d7RDukY6pIsURJiDKhcRa6fbFdxM/2SkFEhtS/NrX9XmBE7 GwFsIbQa2Da6E+ffzO/tIBlCnnYo1X68eZIkRTxBbY3CR5z0id7slf0idPZJqB8hQr02JPRRu dpwnWGVyYPg00phI/Egb1ZOGeLu+O/5AH97FqTm46mi1yPkGwL/4I34pObxLZjUhfCm3Zz6EG 2ZWUz99Gi9tCUboFjW+AS/P6kIzvNfsYBMlHjR7H0QkuLXyKy8Ku8+EoKXiTDYDv3paOuL3TG gG6i+GQep8zrvMQkTvtBFFtAKEIUpGGET4vXISq2+mTz97xeB7n9jlSx9wIIK5rsUF6X4xGfV lK7lse4FnJK/mw/oKgSg74Xf9a4UExLGLAh0nrRoAKtBag4eRae461/p0X2ZGQqra2OEmglha ExCiSYq0llDN9SoW8vl+6Yc7POULTBjQuHG1CSdeCfQ1CLM8etX/FPyDzBWnfDbXWRDfBQ7Iu 7fPZWBuRGdES6te1k7XV4A7I/T2wXu6n0SiEEEmUiTgaZ5BFB1DGYnbZsG54ih+jTjxUs9XyN uUREr4GpPH4fqGs9pmeuIo/nnWbBfpO/V703LdUkJfMyxM8Zi81WB2+PpfHV+fVb5N59qEcsS 5hY+133oJ1JJC48b9aFyv/q7kEd7l0oQeWU+iQEMY8r74lJKdHxY3FTRA9lfgG+exXllSOPyw AGs6E9YffZ2lp7t/LXxD4y5sx5wz6ZRxcn/boTa2C0kEz7RR0QFY2RFVRsZf2/A4ZvKJMkJUO QaQo4rLK4yiCff7hnftgGbVd4dQUQBDpC6wCs4DRmK910qXS2eiz3BDe23e2Hk9hTSpAqEm0P zG8/VzE7uXrL635yYKw+ZwI0CMZihaGxQzjoTsEBuQioUNiHUqgR3LrXbZ58iVoAhGSkRMz4u EnqUUEOQBEiudQ6pAcJ7UcftB4xMd/p7OAH03FJnkJNoKaYko+u1iVpyFphvDy483u9pyvjPn OshBnQS41mVappYLA9GtNj5uVIjZlULcdmIFayPMQfywfpU0FohLgmuGkF3YwL5AmPsfH6+J7 1frrhKFZ3xtTiFubYOzSF5rI9p25WEJjvtFUx5EHXhoWqMWRQkjEWy3e4Hl8Wl6Bcfyr43mD6 HKuqdTPLPxpiOOGBQXopf5oNUACI9p/mJScLDOdO+lqUrZlqNXn0uiC4kVGuDUGpRveOAcK3D YOJXFv010AaN0kRRRJmVaGMCnoYfuahCfxRzhqTSfJnpp X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: Hi Stefan, >>> - The name `file-attribute-file-number` doesn't sound right >>> because it doesn't return a number. >> The name is a reminiscence of the existing variable buffer-file-number, >> which serves exactly the same purpose. > > One error doesn't justify another. > Maybe a better name would be "file identifier"? True, but I'd let decide the maintainers. >>> - I wouldn't use `defsubst` (so it can more easily be modified in the >>> future, e.g. in case we add more fields to the attributes or use some >>> other representation for attributes). >> All other accessor functions for file-attributes are defsubsts. > > Every `defsubst` should be judged on its own individual value. > This one doesn't seem to be justified. As I said, it should be an "accessor function" for the result of file-attributes. Just a stupid one, which returns inode and device. That's the intention, and not something more sophisticated about identifying a file. >>> - I would document it more abstractly, mentioning inode and device >>> number only as *examples* of things it might contain. >> There is no intention to use it for anything else. It shall return >> (nthcdr 10 attributes) like all the other file-attributes accessor >> functions return for the respective slots. > > I did not suggest changing its implementation. Only its documentation. > The doc should describe the intended semantics of the return value > without documenting how it's implemented. The intended semantics is what's described. I understand that you see something more for the future. I don't see it, sorry. No other use case I could think of. We have file-equal-p for more sophisticated checks, and this has even file name handler support. > Stefan Best regards, Michael. From unknown Sat Sep 06 09:27:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Oct 2022 19:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: thievol@posteo.net, larsi@gnus.org, 58446@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 58446-submit@debbugs.gnu.org id=B58446.166577486919300 (code B ref 58446); Fri, 14 Oct 2022 19:15:03 +0000 Received: (at 58446) by debbugs.gnu.org; 14 Oct 2022 19:14:29 +0000 Received: from localhost ([127.0.0.1]:38634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojQ8a-000518-BF for submit@debbugs.gnu.org; Fri, 14 Oct 2022 15:14:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojQ8Y-00050t-6j for 58446@debbugs.gnu.org; Fri, 14 Oct 2022 15:14:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56786) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojQ8S-00056A-BN; Fri, 14 Oct 2022 15:14:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=++mKxEjlVhw1jwXEghws8eQh5B33BBT7IH1e1VmkZr4=; b=KDJx+Zp3jJzp KqCEX/Zpk7ks68m2cPeKHuPhPnd/nXIk1oiTniCIsaTQZAQ9SH9JGYZ+5Bmil6SCVSJPxSikOxx5l +bYd30sK1Q4nSV3BR7x303Z1eV6MvK7xeIEY5f6cdmTfQkPDltjRWi+XBNSUeX0tTevOZxD1Z4XvU tpkNCHaJpTsCHDDe5T1vu/xzktFTbAaLYoDCvf/7zp+ihGeKxnMRZueuEQ+wqC1PBUjDLhb0tKW62 DOBLfmApbrg9o62VUNMdHY4mjiMQgk3o4My1vsAWEiQDHP/dBo3TuuJrSNDE/AIt6tBevbWzv5fFq XLx9jaFLtW8S8PgEsO7dbA==; Received: from [87.69.77.57] (port=4100 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojQ8R-0000iX-PB; Fri, 14 Oct 2022 15:14:20 -0400 Date: Fri, 14 Oct 2022 22:14:06 +0300 Message-Id: <83tu466ww1.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87sfjqxm6k.fsf@gmx.de> (message from Michael Albinus on Fri, 14 Oct 2022 21:03:15 +0200) References: <87lepmusw5.fsf@posteo.net> <87pmexcn1h.fsf@gnus.org> <87edvd5bun.fsf@gmx.de> <87wn92xql1.fsf@gmx.de> <87sfjqxm6k.fsf@gmx.de> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Thierry Volpiatto , Lars Ingebrigtsen , > 58446@debbugs.gnu.org > From: Michael Albinus > Date: Fri, 14 Oct 2022 21:03:15 +0200 > > Stefan Monnier writes: > > Hi Stefan, > > >>> - The name `file-attribute-file-number` doesn't sound right > >>> because it doesn't return a number. > >> The name is a reminiscence of the existing variable buffer-file-number, > >> which serves exactly the same purpose. > > > > One error doesn't justify another. > > Maybe a better name would be "file identifier"? > > True, but I'd let decide the maintainers. It would be better, yes. I already changed "device number" to eithe just "device" or "device identifier", in the documentation you touched today, since talking about "device number" when it can be a cons of 2 numbers doesn't sound like a good idea. From unknown Sat Sep 06 09:27:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Oct 2022 19:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: thievol@posteo.net, larsi@gnus.org, 58446@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 58446-submit@debbugs.gnu.org id=B58446.166577605021491 (code B ref 58446); Fri, 14 Oct 2022 19:35:01 +0000 Received: (at 58446) by debbugs.gnu.org; 14 Oct 2022 19:34:10 +0000 Received: from localhost ([127.0.0.1]:38670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojQRd-0005aZ-QC for submit@debbugs.gnu.org; Fri, 14 Oct 2022 15:34:10 -0400 Received: from mout.gmx.net ([212.227.17.22]:38137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojQRb-0005aM-PP for 58446@debbugs.gnu.org; Fri, 14 Oct 2022 15:34:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1665776038; bh=2bzhnXS9YLv4IyqdJByaLXj/Rxq+8MFj2trGUUSxJhs=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=XLp8cwdLVd2Q7lvUbAz5jllxAK9/O6yCa8iOR1AwXsiA/g+a5cTUpfiZ0SHTqAat/ CI6pKeFPyjWXs8P78TJ7fguNa3wdTC7cCbV6DawGXuVsngFgfcLCq4w9FKN/gp/fza CffMNqmEYF4lJ0J2+hEitHpGW+pvsONDZL9FgeV8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.151.229]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N4zAy-1pApBC1zvg-010uvI; Fri, 14 Oct 2022 21:33:58 +0200 From: Michael Albinus In-Reply-To: <83tu466ww1.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 14 Oct 2022 22:14:06 +0300") References: <87lepmusw5.fsf@posteo.net> <87pmexcn1h.fsf@gnus.org> <87edvd5bun.fsf@gmx.de> <87wn92xql1.fsf@gmx.de> <87sfjqxm6k.fsf@gmx.de> <83tu466ww1.fsf@gnu.org> Date: Fri, 14 Oct 2022 21:33:56 +0200 Message-ID: <87o7ueurmj.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:o5Ll/Ct6QGKjM9IJT/w309gocUtSmZyPQMf92fBduBZSQQR1BuC 0PlxfjJ7WlhpCDMT3KDM+/tnE4Jr3MUlEbpqAncT0fXlJfcZXK92AcIlfuyBI2l6hAcPGcN xlnPnZjxbtnOi5PAy8Uu4CIsBKdbFAot+87kGoe1sONUCaDue82VOJKLW4M63xbHWt48C0/ OlCBe/83D7PXQXJtNJTnQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:7I3sDmjLo5c=:mevogoRYi9yY88iX5aNB5H h/pux2fAUhwRSb0lYk68AmrcU5r+id8bTpAJ+yhdKxOgoE4UGp8UPk0OAIGpm5xy7hhmh5A5d o2BhSMCtDGxlL1kxA/eVH28W60MTtXme4cvRiC3bEoEUBoCw6UvzBGBMR40t27/OpivwAgp0E rGDaqcVVDTBYCQVzQwvERHE0Zv/Lpe9aFbBYKWpsNzvN8e/kooTmT4Ig91VNdLeaHW2cSnVek iYlsdptVIGhj/h38YbCGYO++UDjls6thswLXLsc2S7NhigPxwG+Du0NNNO7wno0OImzq6n0OE osXRenTU24gm5DlJdcxgBEJP4CvVwcxJQ9QjGffL5Ah/OrAuGOzGj6JnqNZkR10K7Jl9tBjA1 Q9H65LA7RQcn165+m2toyieBe1mTUxToC6QpSkcDs3gQRuV+Hvc+/uhn1Fsa6O627HlSk7UPw 0Hv4uolhNhfYNe1PG2orlgjnJx78xYkzjfRcSZ7Hfuxf8v5QxYzrvcjdRAF3l93N4EJOvgTow KgzpEakg4OAZPww2bAavugaDP4JpqG3bXnih3MSYyeHEJbKKcZd9jNYJ7os2NCFPwZLJLrO+5 kqOW/oWuIMm5QdFTzc2QqCx3oSeElotF3EWXcR2BN8pSZEVJV8I6nXN8/yIbyPMwxtjVwvNLX +/mcqvFgYSddyJ9PzLSURVgrKnC2ok2El3f94VT7Zd4HiQjCF+0GNudzXKFPAmpdE2i15Rg+h cnR2Kj7SBJeUvrvyT24vALGk1FZmFVX4ly5Z13btwlppcaR1V8dayLGKwdN3O6y0Jz2y2ZE9x PBRrLdanKLYO9LSQ8n9Y+BHU6lSAgsEjKQZOXuQ50dCK6aNcpsgwTacQaSZTY425anJlV42Zt ms6o21tIARect9yNmj/pljNGWnbXavkLxEWj/hwvNgnHpsAFdb1bvPikg5Kci/IKiLSxAY+w0 6MF/SMqqV6CoenfeZv2u8AuZB2ZEBxKy7ZMDlSA4eYP4fgWrrNav3qUdwuNY4gnAZ8Dw/kywy Tax/KI/BFmDg2UBAIe+Dx/ysZin1P4sv86b101gZUiCtBlVM2elT7A8bRG+3RVlkx8RTqYO9g Tlgb67kOk7vvMBVAQpBg75NE0MeYyoIRSPnVGpGopCRx9BJIWp0GMQwfWFEcXz0Ma7jBKgJJ9 yMdtVdFqb1XDeeTFqslh7hTRsXnqD/zZLa/JBdZ9kkalyEyCF7KqkH4yPjHiZxdjNlX0E/g/n 9w1yk/bFSObq6k1rWlLYsPXrvJpnPRnRcd8zymkHiPpVn0nIhH2yJtglLcr2Kk2jm08TM9SKr euh/svavkOcl7TxcB1XV64WZIxe/w/YMnPyMLtdOXrqGB7dQSdLNQUUUgKBvFjmXd8qb1ySAN 6ArbCZ/9bYqAxR7ZWwBseRudlG/oXEE3LaUnY3HxqgIWnNF/sm9aqfGeHyxiyncx1WD38tPt3 qrwr5U6Fn0RvVqViqeqNBmwguytXa0eY02/HK2990QCb/PSq9AO2RnTzToTUEyFarPlui8S/d bWF9qTRX12E4pzWUCSPv4TR6x2PyCXy4oYe+RgAsf+gDB X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: Hi Eli, > It would be better, yes. I already changed "device number" to eithe > just "device" or "device identifier", in the documentation you touched > today, since talking about "device number" when it can be a cons of 2 > numbers doesn't sound like a good idea. I've changed the name to file-attribute-file-identifier. Pushed to master. Best regards, Michael.