GNU bug report logs - #58442
[PATCH 0/1] Add EditorConfig specification.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58442 in the body.
You can then email your comments to 58442 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: "\(" <paren <at> disroot.org>
Subject: [PATCH 0/1] Add EditorConfig specification.
Date: Tue, 11 Oct 2022 16:06:53 +0100

This patch adds a .editorconfig file to the project root. This is especially
useful for ~~nonbelievers~~ non-Emacs users.

( (1):
  Add EditorConfig specification.

 .editorconfig | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 .editorconfig

-- 
2.38.0

Message #8 received at 58442 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: 58442 <at> debbugs.gnu.org
Cc: "\(" <paren <at> disroot.org>
Subject: [PATCH 1/1] Add EditorConfig specification.
Date: Tue, 11 Oct 2022 16:22:32 +0100

* .editorconfig: New file.
---
 .editorconfig | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 .editorconfig

diff --git a/.editorconfig b/.editorconfig
new file mode 100644
index 0000000000..bc68ff24c8
--- /dev/null
+++ b/.editorconfig
@@ -0,0 +1,16 @@
+root = true
+
+[*.{c,h,cpp,hpp,el,scm,ac,am,m4,po}{,.in}]
+end_of_line = lf
+insert_final_newline = true
+charset = utf-8
+trim_trailing_whitespace = true
+
+[*.{c,h,cpp,hpp,ac,am,m4,el,scm}{,.in}]
+max_line_length = 85
+
+[*.{c,h,cpp,hpp,ac,m4,el,scm}{,.in}]
+indent_style = space
+
+[*.{c,h,cpp,hpp}{,.in}]
+indent_size = 4
-- 
2.38.0

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: "(" <paren <at> disroot.org>
Cc: 58442 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#58442] [PATCH 1/1] Add EditorConfig specification.
Date: Tue, 11 Oct 2022 17:59:18 +0200

[Message part 1 (text/plain, inline)]

Hi!

"( via Guix-patches" via 写道：
> * .editorconfig: New file.

All these values LGTM, but I use the correct editor.

> max_line_length = 85

As discussed on IRC, it's obvious to ‘us’ what this really means, 
but I wonder if it's universal.  Unless someone disagrees, I think 
it's OK.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>, "(" <paren <at> disroot.org>
Cc: 58442 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#58442] [PATCH 1/1] Add EditorConfig specification.
Date: Thu, 13 Oct 2022 12:32:20 +0200

Am Dienstag, dem 11.10.2022 um 17:59 +0200 schrieb Tobias Geerinckx-
Rice:
> Hi!
> 
> "( via Guix-patches" via 写道：
> > * .editorconfig: New file.
> 
> All these values LGTM, but I use the correct editor.
> 
> > max_line_length = 85
> 
> As discussed on IRC, it's obvious to ‘us’ what this really means, 
> but I wonder if it's universal.  Unless someone disagrees, I think 
> it's OK.
If I recall correctly, the correct editor uses 79 as fill-column.  Even
if extended URLs are nasty in other editors, as discussed in IRC, I'd
claim that to be "a good thing", because the failed word-wrapping shows
the writer how nasty that'd be and makes them use string-append.

Cheers

Message #23 received at 58442 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: "(" <paren <at> disroot.org>
Cc: 58442 <at> debbugs.gnu.org
Subject: Re: [bug#58442] [PATCH 0/1] Add EditorConfig specification.
Date: Thu, 03 Nov 2022 16:52:15 +0100

[Message part 1 (text/plain, inline)]

"( via Guix-patches" via <guix-patches <at> gnu.org> writes:

> This patch adds a .editorconfig file to the project root. This is especially
> useful for ~~nonbelievers~~ non-Emacs users.
>
> ( (1):
>   Add EditorConfig specification.
>
>  .editorconfig | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>  create mode 100644 .editorconfig

Is this just waiting to be merged? It seems fine to me, although I
probably won't notice it's addition.

Given it's easy to change, I don't think we need to do much upfront
review.

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 58442-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: "(" <paren <at> disroot.org>
Cc: 58442-done <at> debbugs.gnu.org
Subject: Re: [bug#58442] [PATCH 0/1] Add EditorConfig specification.
Date: Sat, 05 Nov 2022 11:50:41 +0100

[Message part 1 (text/plain, inline)]

Christopher Baines <mail <at> cbaines.net> writes:

> "( via Guix-patches" via <guix-patches <at> gnu.org> writes:
>
>> This patch adds a .editorconfig file to the project root. This is especially
>> useful for ~~nonbelievers~~ non-Emacs users.
>>
>> ( (1):
>>   Add EditorConfig specification.
>>
>>  .editorconfig | 16 ++++++++++++++++
>>  1 file changed, 16 insertions(+)
>>  create mode 100644 .editorconfig
>
> Is this just waiting to be merged? It seems fine to me, although I
> probably won't notice it's addition.
>
> Given it's easy to change, I don't think we need to do much upfront
> review.

I've gone ahead and pushed this as
6123f0e467aa5249f0a497c89ce434222702a535.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #31 received at 58442-done <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Christopher Baines" <mail <at> cbaines.net>
Cc: 58442-done <at> debbugs.gnu.org
Subject: Re: [bug#58442] [PATCH 0/1] Add EditorConfig specification.
Date: Sat, 05 Nov 2022 10:52:02 +0000

On Sat Nov 5, 2022 at 10:50 AM GMT, Christopher Baines wrote:
> I've gone ahead and pushed this as
> 6123f0e467aa5249f0a497c89ce434222702a535.

Thanks!

    -- (

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.