GNU bug report logs - #58439
[PATCH] [ELPA GNU] rcirc-color: Fix color assigning

Previous Next

Package: emacs;

Reported by: Thuna <thuna.cing <at> gmail.com>

Date: Tue, 11 Oct 2022 13:40:02 UTC

Severity: normal

Tags: patch

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58439 in the body.
You can then email your comments to 58439 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#58439; Package emacs. (Tue, 11 Oct 2022 13:40:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Thuna <thuna.cing <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 11 Oct 2022 13:40:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thuna <thuna.cing <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] [ELPA GNU] rcirc-color: Fix color assigning
Date: Tue, 11 Oct 2022 15:39:31 +0200

[0001-rcirc-color-Fix-color-assigning.patch (text/x-patch, attachment)]
From 73f917c6de3acbab3f34fa839cc9e1b56517d084 Mon Sep 17 00:00:00 2001
From: Thuna <thuna.cing <at> gmail.com>
Date: Tue, 11 Oct 2022 15:35:47 +0200
Subject: [PATCH] rcirc-color: Fix color assigning

* rcirc-color.el (rcirc-do-color): When a color is given to
rcirc-color with `/color NICK COLOR', use the specified COLOR instead
of getting a random one.
---
 rcirc-color.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rcirc-color.el b/rcirc-color.el
index b66f4a1143..ee96ae8bd5 100644
--- a/rcirc-color.el
+++ b/rcirc-color.el
@@ -162,7 +162,7 @@ commands."
         (rcirc-print process (rcirc-nick process) "NOTICE" target
                      (mapconcat 'identity names " ")))
     (let* ((index (random (length rcirc-colors)))
-           (color (elt rcirc-colors index))
+           (color (or color (elt rcirc-colors index)))
            (face `(:foreground ,color ,@rcirc-color-other-attributes)))
       (puthash nick face rcirc-color-mapping))))
 
-- 
2.35.1
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#58439; Package emacs. (Wed, 12 Oct 2022 11:26:02 GMT) Full text and rfc822 format available.

Message #8 received at 58439 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Thuna <thuna.cing <at> gmail.com>
Cc: 58439 <at> debbugs.gnu.org
Subject: Re: bug#58439: [PATCH] [ELPA GNU] rcirc-color: Fix color assigning
Date: Wed, 12 Oct 2022 13:24:50 +0200

Thuna <thuna.cing <at> gmail.com> writes:

> * rcirc-color.el (rcirc-do-color): When a color is given to
> rcirc-color with `/color NICK COLOR', use the specified COLOR instead
> of getting a random one.

Thanks; pushed to ELPA.
bug marked as fixed in version 29.1, send any further explanations to 58439 <at> debbugs.gnu.org and Thuna <thuna.cing <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 12 Oct 2022 11:26:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 09 Nov 2022 12:24:07 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 250 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.