From unknown Thu Sep 11 16:39:34 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#58433 <58433@debbugs.gnu.org> To: bug#58433 <58433@debbugs.gnu.org> Subject: Status: [PATCH 0/2] Accept tags in the 'commit' field of Reply-To: bug#58433 <58433@debbugs.gnu.org> Date: Thu, 11 Sep 2025 23:39:34 +0000 retitle 58433 [PATCH 0/2] Accept tags in the 'commit' field of reassign 58433 guix-patches submitter 58433 Ludovic Court=C3=A8s severity 58433 normal tag 58433 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 11 05:51:30 2022 Received: (at submit) by debbugs.gnu.org; 11 Oct 2022 09:51:30 +0000 Received: from localhost ([127.0.0.1]:50930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiBv8-000385-CP for submit@debbugs.gnu.org; Tue, 11 Oct 2022 05:51:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:48516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiBv5-00037w-Ru for submit@debbugs.gnu.org; Tue, 11 Oct 2022 05:51:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiBv4-0007rP-D9 for guix-patches@gnu.org; Tue, 11 Oct 2022 05:51:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34574) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiBv3-00049Q-7r; Tue, 11 Oct 2022 05:51:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=iEBPf7pQwE0vlH6CUaOiu9eXkbwxmkfV+w6M7Csj5cQ=; b=Z4uxsLWPICTtyv QYrUKPiYjhIKvGeWGiucwlykCKdcw4Nr921GyRciPhVzFhQzuCpm0M+DakNQ8i0LolEnMCJcfN6Ok CRGcqBfp0MYbHseJSVBylexQKCwq7L3NelkAL0qyv3ID5l/asVVjZ81/PVKLXkiQKnfgzdLuH4e0R qsthlhEH1kCeg/V9Gq6AY3GSgofSj64/QSxIpUzuJDhsJUOAcY6f5RQT8jhVNg6gkQFvLfH1i1KuA 60t0+s+zW3RqRTksFNOIUGD1ONS24nH7LrgPEDAkWdv1vYj/8YOxL4kyk8RjW5/Jit0ZT6wsJFeT1 LGASJ3zCzC7ksnWnxXLQ==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=39814 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oiBv2-0002CY-Qe; Tue, 11 Oct 2022 05:51:25 -0400 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH 0/2] Accept tags in the 'commit' field of Date: Tue, 11 Oct 2022 11:51:17 +0200 Message-Id: <20221011095117.31182-1-ludo@gnu.org> X-Mailer: git-send-email 2.38.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! This change lets us pass tags to ‘guix time-machine’ and ‘guix pull’, as in: guix time-machine --commit=v1.2.0 -- describe At last! Thoughts? Ludo’. Ludovic Courtès (2): git: 'update-cached-checkout' returns the commit ID when given a tag. channels: Interpret the 'commit' field of channel as a tag or commit. doc/guix.texi | 23 +++++++++++++++++++++-- guix/channels.scm | 2 +- guix/git.scm | 15 +++++++++------ guix/inferior.scm | 2 +- tests/git.scm | 32 +++++++++++++++++++++++++++++++- 5 files changed, 63 insertions(+), 11 deletions(-) base-commit: 5d5bc072059f514394afdaccfcc72cdb282d7ce2 -- 2.38.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 11 05:52:46 2022 Received: (at 58433) by debbugs.gnu.org; 11 Oct 2022 09:52:46 +0000 Received: from localhost ([127.0.0.1]:50938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiBwL-0003AU-SQ for submit@debbugs.gnu.org; Tue, 11 Oct 2022 05:52:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiBwJ-0003AA-Np for 58433@debbugs.gnu.org; Tue, 11 Oct 2022 05:52:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38638) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiBwE-0004OG-Go; Tue, 11 Oct 2022 05:52:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=TOCdwkx4K3JXDMR3tV9x85hP8HO21P6DQXpx5VQjtlY=; b=Jb+ujAUgV+kPAI tV02JlHZxagLahkN6eVB4JL/jqcHoKfjgVkW+ZOJsvmRxN5rkKaCKuyvwPxPfIwEYpsetDwmIPWld iW6mj0njpyeuYz2Q4/jWZRwMjciN8bsrM54mWOHIE2WjSFWQKTI9rnATJnsvU2KoK6q4Ltap0uwEZ oHpKlJTEn+4RrM8hfDhda8+zx5pkY3sLj568b5BOu4qfpgTH58VxWH4+wj3jwjYb0ci8YHhY3A+8s 32AjawgcTrwngdys51epXhTKaa5U3PAXEoQYLAPqQY1po++oXaMJZhuhMFqVIQRnAKbBvGVhlS1IW z5xT2W16TvvB96in31wQ==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=59686 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oiBwD-0002Tv-O7; Tue, 11 Oct 2022 05:52:38 -0400 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 58433@debbugs.gnu.org Subject: [PATCH 1/2] git: 'update-cached-checkout' returns the commit ID when given a tag. Date: Tue, 11 Oct 2022 11:52:28 +0200 Message-Id: <20221011095229.31244-1-ludo@gnu.org> X-Mailer: git-send-email 2.38.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58433 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Previously, starting with commit efa578ecaece67366b4b0e2266de7c2faaa4ae54, 'update-cached-checkout' would return the OID of the annotated tag the tag points to. With this change it returns the OID of the commit object in all cases. * guix/git.scm (resolve-reference): In the 'tag' case, call 'tag-target-id' and 'tag-lookup' when OID designates an annotated tag. * tests/git.scm ("update-cached-checkout, tag"): New test. --- guix/git.scm | 15 +++++++++------ tests/git.scm | 32 +++++++++++++++++++++++++++++++- 2 files changed, 40 insertions(+), 7 deletions(-) diff --git a/guix/git.scm b/guix/git.scm index d7fd320f50..0220fe1068 100644 --- a/guix/git.scm +++ b/guix/git.scm @@ -271,12 +271,15 @@ (define (resolve-reference repository ref) ;; There's no such tag, so it must be a commit ID. (resolve `(commit . ,str))))))) (('tag . tag) - (let ((oid (reference-name->oid repository - (string-append "refs/tags/" tag)))) - ;; OID may point to a "tag" object, but it can also point directly - ;; to a "commit" object, as surprising as it may seem. Return that - ;; object, whatever that is. - (object-lookup repository oid)))))) + (let* ((oid (reference-name->oid repository + (string-append "refs/tags/" tag))) + (obj (object-lookup repository oid))) + ;; OID may designate an "annotated tag" object or a "commit" object. + ;; Return the commit object in both cases. + (if (= OBJ-TAG (object-type obj)) + (object-lookup repository + (tag-target-id (tag-lookup repository oid))) + obj)))))) (define (switch-to-ref repository ref) "Switch to REPOSITORY's branch, commit or tag specified by REF. Return the diff --git a/tests/git.scm b/tests/git.scm index ca59d2a33e..9c944d65b1 100644 --- a/tests/git.scm +++ b/tests/git.scm @@ -22,8 +22,12 @@ (define-module (test-git) #:use-module (guix git) #:use-module (guix tests git) #:use-module (guix build utils) + #:use-module ((guix utils) #:select (call-with-temporary-directory)) #:use-module (srfi srfi-1) - #:use-module (srfi srfi-64)) + #:use-module (srfi srfi-64) + #:use-module (srfi srfi-71) + #:use-module (ice-9 popen) + #:use-module (ice-9 textual-ports)) ;; Test the (guix git) tools. @@ -239,4 +243,30 @@ (define-module (test-git) (tag "v1.1" "Release 1.1")) (remote-refs directory #:tags? #t))) +(unless (which (git-command)) (test-skip 1)) +(test-assert "update-cached-checkout, tag" + (call-with-temporary-directory + (lambda (cache) + (with-temporary-git-repository directory + '((add "a.txt" "A") + (commit "First commit") + (tag "v1.0" "release-1.0") + (branch "develop") + (checkout "develop") + (add "b.txt" "B") + (commit "Second commit") + (tag "v1.1" "release-1.1")) + (let ((directory commit relation + (update-cached-checkout directory + #:ref '(tag . "v1.1") + #:cache-directory cache)) + (head (let* ((pipe (open-pipe* OPEN_READ (git-command) + "-C" directory + "rev-parse" "HEAD")) + (str (get-string-all pipe))) + (close-pipe pipe) + (string-trim-right str)))) + ;; COMMIT should be the ID of the commit object, not that of the tag. + (string=? commit head)))))) + (test-end "git") -- 2.38.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 11 05:52:46 2022 Received: (at 58433) by debbugs.gnu.org; 11 Oct 2022 09:52:46 +0000 Received: from localhost ([127.0.0.1]:50940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiBwM-0003AW-8y for submit@debbugs.gnu.org; Tue, 11 Oct 2022 05:52:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiBwK-0003AC-C0 for 58433@debbugs.gnu.org; Tue, 11 Oct 2022 05:52:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38640) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiBwF-0004ON-51; Tue, 11 Oct 2022 05:52:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=ZZbrTrrqxE9FfAdnfglO9jifxPLtvHu2KwAaEtRq9sI=; b=DkGFbF+BkHgMfGfEVHzC 2+glWjpLKP3CeaPP84H7RIpFVqtPEY4afoPJQfqUPEdbO2xpKtSYvRVGzrbydHwJd+OY/1TZ6QISJ 6q4WPTseH+zFHRpkCJWL6m9GHUKH5Yu24u9F9owwJJeKDLjtbT4/hFXqStgvnOqk6sOkaYxSXKY/K zFvw0xj6gn0O2Ow5cGcFoqqggSgjRQ+oYmT52POMoD/WADaEXa8sgu15vI/rCGvKR7ns0TSDgz/1+ pGw81zGcJMiif3Ucyk1eCmeoYnDFT/u/NQbhwpRXaBHtpWL9ftOzpgrCzvei1Y10vwXR33EpKMtmF p2DwzLiZ5ZEmCQ==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=59686 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oiBwE-0002Tv-O0; Tue, 11 Oct 2022 05:52:38 -0400 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 58433@debbugs.gnu.org Subject: [PATCH 2/2] channels: Interpret the 'commit' field of channel as a tag or commit. Date: Tue, 11 Oct 2022 11:52:29 +0200 Message-Id: <20221011095229.31244-2-ludo@gnu.org> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221011095229.31244-1-ludo@gnu.org> References: <20221011095229.31244-1-ludo@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58433 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Previously the 'commit' field would always be interpreted as a commit ID. This change adds flexibility, allowing for things like: guix time-machine --commit=v1.2.0 -- describe * guix/channels.scm (channel-reference): Use 'tag-or-commit' rather than 'commit'. * guix/inferior.scm (channel-full-commit): Likewise. * doc/guix.texi (Invoking guix pull): Document it. (Invoking guix time-machine): Likewise. --- doc/guix.texi | 23 +++++++++++++++++++++-- guix/channels.scm | 2 +- guix/inferior.scm | 2 +- 3 files changed, 23 insertions(+), 4 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 14592142dd..4c24600f04 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -4631,7 +4631,7 @@ but it supports the following options: @itemx --branch=@var{branch} Download code for the @code{guix} channel from the specified @var{url}, at the given @var{commit} (a valid Git commit ID represented as a hexadecimal -string), or @var{branch}. +string or the name of a tag), or @var{branch}. @cindex @file{channels.scm}, configuration file @cindex configuration file for channels @@ -4783,6 +4783,25 @@ of Guix to be used is defined by a commit or by a channel description file created by @command{guix describe} (@pxref{Invoking guix describe}). +Let's assume that you want to travel to those days of November 2020 when +version 1.2.0 of Guix was released and, once you're there, run the +@command{guile} of that time: + +@example +guix time-machine --commit=v1.2.0 -- \ + environment -C --ad-hoc guile -- guile +@end example + +The command above fetches Guix@tie{}1.2.0 and runs its @command{guix +environment} command to spawn an environment in a container running +@command{guile} (@command{guix environment} has since been subsumed by +@command{guix shell}; @pxref{Invoking guix shell}). It's like driving a +DeLorean@footnote{If you don't know what a DeLorean is, consider +traveling back to the 1980's.}! The first @command{guix time-machine} +invocation can be expensive: it may have to download or even build a +large number of packages; the result is cached though and subsequent +commands targeting the same commit are almost instantaneous. + The general syntax is: @example @@ -4799,7 +4818,7 @@ this revision are the same as for @command{guix pull} (@pxref{Invoking guix pull @itemx --branch=@var{branch} Use the @code{guix} channel from the specified @var{url}, at the given @var{commit} (a valid Git commit ID represented as a hexadecimal -string), or @var{branch}. +string or the name of a tag), or @var{branch}. @item --channels=@var{file} @itemx -C @var{file} diff --git a/guix/channels.scm b/guix/channels.scm index f1c23c17fb..d84228c47e 100644 --- a/guix/channels.scm +++ b/guix/channels.scm @@ -248,7 +248,7 @@ (define (channel-reference channel) 'latest-repository-commit'." (match (channel-commit channel) (#f `(branch . ,(channel-branch channel))) - (commit `(commit . ,(channel-commit channel))))) + (commit `(tag-or-commit . ,(channel-commit channel))))) (define sexp->channel-introduction (match-lambda diff --git a/guix/inferior.scm b/guix/inferior.scm index cbb3c0a36e..2fe34ca0dc 100644 --- a/guix/inferior.scm +++ b/guix/inferior.scm @@ -835,7 +835,7 @@ (define (channel-full-commit channel) (branch (channel-branch channel))) (if (and commit (commit-id? commit)) commit - (let* ((ref (if commit `(commit . ,commit) `(branch . ,branch))) + (let* ((ref (if commit `(tag-or-commit . ,commit) `(branch . ,branch))) (cache commit relation (update-cached-checkout (channel-url channel) #:ref ref -- 2.38.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 13 09:03:45 2022 Received: (at 58433) by debbugs.gnu.org; 13 Oct 2022 13:03:46 +0000 Received: from localhost ([127.0.0.1]:59898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oixsH-00041U-NQ for submit@debbugs.gnu.org; Thu, 13 Oct 2022 09:03:45 -0400 Received: from mira.cbaines.net ([212.71.252.8]:41584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oixsF-00041L-Ts for 58433@debbugs.gnu.org; Thu, 13 Oct 2022 09:03:44 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:fc93:27fb:8412:c8b7]) by mira.cbaines.net (Postfix) with ESMTPSA id CB06827BBE9; Thu, 13 Oct 2022 14:03:42 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id aa722a17; Thu, 13 Oct 2022 13:03:42 +0000 (UTC) References: <20221011095117.31182-1-ludo@gnu.org> User-agent: mu4e 1.8.9; emacs 28.1 From: Christopher Baines To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#58433] [PATCH 0/2] Accept tags in the 'commit' field of Date: Thu, 13 Oct 2022 14:03:21 +0100 In-reply-to: <20221011095117.31182-1-ludo@gnu.org> Message-ID: <8735br7u4y.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58433 Cc: 58433@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > This change lets us pass tags to =E2=80=98guix time-machine=E2=80=99 and = =E2=80=98guix pull=E2=80=99, > as in: > > guix time-machine --commit=3Dv1.2.0 -- describe > > At last! > > Thoughts? This sounds good to me :) Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmNIDK1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XeZHg/9HWXoo3l2Sb+GyO0epCyDAvJJQkX06Keb WbifeIF1dCclqzr/l+fyh6xSTEd8H0TYUH14U8J47RowNe1Uv0c8eNv5zfBfgr7b TIAyQdAgTzBOjHzB2/mjMmlHrNy0YmmkF8Z1zfYdoyvAZKRBOFM79awnMkD/6Ly4 928v3YyM+2dDpckJ9ugONCAbNAhJTz7gP3rvCxsBk4gTUSZw2/2UdUmK5O0Z+PId 0iurr4fzEd53DHmPUil/gW7FQde2nwkwXZHWG7cQrsQhYylkBK+u5cOn7ukjMb14 5QzVYvjfPl1n4SNmJod+AG371UhdrjaROfplycAbONhJaZU0WzFhspNMpOLTu/yo nu+jsmAgJHZy9n0U2AyTdmqg3PpfbnlXgNWQ3RW35+w34RrspzB7mdiwnLQR9+DM Yqo3cBVrJDwSLoCwzSssxyC5ZRuwUwsfDQIq9xmEIDlPaMsDmsWKkIUmgjvZdYm2 XM7mnb2/J8c+BXwPZtgyjE50RrtGXRO9pZBY3AtKXsCrD0ZiynLXrEGX6stH7a1y VXrjYqRoDlrY26yjP9HMJ9OFxZcwshGuBAO6dTULIsfVogMySRhVV88/oH4gJZHP leXb6iHL7nmoXGcA286+jfy7Tbowbrya3HJMQ5qIHWV3Zf8Rj2wicVDHLH1FNIeP 2Lz35BnaHXU= =ZChd -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 17 04:47:46 2022 Received: (at 58433-done) by debbugs.gnu.org; 17 Oct 2022 08:47:46 +0000 Received: from localhost ([127.0.0.1]:47258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okLmk-0004kc-AR for submit@debbugs.gnu.org; Mon, 17 Oct 2022 04:47:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okLmi-0004k0-Tt for 58433-done@debbugs.gnu.org; Mon, 17 Oct 2022 04:47:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52750) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okLmd-0004ya-OV; Mon, 17 Oct 2022 04:47:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=AulOxIM2QM3ezNssc9RVKwGG/ollb3SFF0i6a1aCOBU=; b=PfYTwnjZhOT1+mEurvIm sa52FJHfzIWyuDbCkNgz65MkHF92lbTSZoWSpAqUajJ3E4mhoVvo61w79+1eRUTyR/2KG1y77TG5B DXm3LU7zWGkp4NXADIzBh2TZSr0nAnDrUchfFfd/i+gRUFXQhd72YzdI3/JfLWEhjtcAyx6okMK38 21aMvWSS+ngoA29Bf6V5aZ0QlLUPiqySfi/RXIi2Gjvb9C1KZH34MjSDfe54XHYkD8mpzJcLodtyL CNcTg8LMHqsziMnIlR1pQguMV0t2l5Cnzs1CQX6pjd1ekYrW0Mzx1uPE9qIRspnvib84vOy8TUNC+ RNjIroeAfuvN+Q==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=41466 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okLmd-0001pH-80; Mon, 17 Oct 2022 04:47:39 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Christopher Baines Subject: Re: bug#58433: [PATCH 0/2] Accept tags in the 'commit' field of References: <20221011095117.31182-1-ludo@gnu.org> <8735br7u4y.fsf@cbaines.net> Date: Mon, 17 Oct 2022 10:47:37 +0200 In-Reply-To: <8735br7u4y.fsf@cbaines.net> (Christopher Baines's message of "Thu, 13 Oct 2022 14:03:21 +0100") Message-ID: <87zgdug7km.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58433-done Cc: 58433-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Christopher Baines skribis: > Ludovic Court=C3=A8s writes: > >> This change lets us pass tags to =E2=80=98guix time-machine=E2=80=99 and= =E2=80=98guix pull=E2=80=99, >> as in: >> >> guix time-machine --commit=3Dv1.2.0 -- describe >> >> At last! >> >> Thoughts? > > This sounds good to me :) Pushed, thanks for taking a look! f36522416e * channels: Interpret the 'commit' field of channel as a tag o= r commit. 46f7011591 * git: 'update-cached-checkout' returns the commit ID when giv= en a tag. Ludo=E2=80=99. From unknown Thu Sep 11 16:39:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 14 Nov 2022 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator