Subject: Re: [bug#58432] [PATCH] gnu: Add hiredis

From: "(" <[email-masked]>
Date: Tue, 11 Oct 2022 10:50:39 +0100

Heya Thomas,

Looks mostly good, just a few nitpicks:

On Tue Oct 11, 2022 at 10:19 AM BST, Thomas Albers via Guix-patches via wrote:
> +(define-public hiredis
> +  (package
> +   (name "hiredis")
     ^
We usually have two spaces of indentation here.

> +   (source (origin
> +            (method git-fetch)
              ^
Here too.

> +            (sha256
> +             (base32 "0a55zk3qrw9yl27i87h3brg2hskmmzbfda77dhq9a4if7y70xnfb"))))

Put the hash string on a new line.

> +   (description "Library for sending commands and receiving replies to and
> +from a Redis server.  It comes with a synchronous API, asynchronous API and
> +reply parsing API.  Only the binary-safe Redis protocol is supported.")

"This package provides a library for ..." is probably better.

    -- (