GNU bug report logs - #58432
[PATCH] gnu: Add hiredis

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58432 in the body.
You can then email your comments to 58432 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thomas Albers <thomas <at> thomaslabs.org>
To: guix-patches <at> gnu.org
Cc: Thomas Albers <thomas <at> thomaslabs.org>
Subject: [PATCH] gnu: Add hiredis
Date: Tue, 11 Oct 2022 11:19:49 +0200

* gnu/packages/databases.scm (hiredis): New variable.
---
 gnu/packages/databases.scm | 26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index cf07832df7..b372423a77 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -58,6 +58,7 @@
 ;;; Copyright © 2022 Zhu Zihao <all_but_last <at> 163.com>
 ;;; Copyright © 2021 Brice Waegeneire <brice <at> waegenei.re>
 ;;; Copyright © 2022 muradm <mail <at> muradm.net>
+;;; Copyright © 2022 Thomas Albers Raviola <thomas <at> thomaslabs.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2515,6 +2516,29 @@ (define-public ruby-redis
     (home-page "https://github.com/redis/redis-rb")
     (license license:expat)))

+(define-public hiredis
+  (package
+   (name "hiredis")
+   (version "1.0.2")
+   (source (origin
+            (method git-fetch)
+            (uri (git-reference
+                  (url "https://github.com/redis/hiredis")
+                  (commit (string-append "v" version))))
+            (file-name (git-file-name name version))
+            (sha256
+             (base32 "0a55zk3qrw9yl27i87h3brg2hskmmzbfda77dhq9a4if7y70xnfb"))))
+   (build-system cmake-build-system)
+   (native-inputs
+    ;; needed for testing
+    (list redis))
+   (synopsis "Minimalistic C client library for the Redis database")
+   (description "Library for sending commands and receiving replies to and
+from a Redis server.  It comes with a synchronous API, asynchronous API and
+reply parsing API.  Only the binary-safe Redis protocol is supported.")
+   (home-page "https://github.com/redis/hiredis")
+   (license license:bsd-3)))
+
 (define-public go-github-com-cupcake-rdb
   (package
     (name "go-github-com-cupcake-rdb")
--
2.37.3

Message #8 received at 58432 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Thomas Albers" <thomas <at> thomaslabs.org>, <58432 <at> debbugs.gnu.org>
Subject: Re: [bug#58432] [PATCH] gnu: Add hiredis
Date: Tue, 11 Oct 2022 10:50:39 +0100

Heya Thomas,

Looks mostly good, just a few nitpicks:

On Tue Oct 11, 2022 at 10:19 AM BST, Thomas Albers via Guix-patches via wrote:
> +(define-public hiredis
> +  (package
> +   (name "hiredis")
     ^
We usually have two spaces of indentation here.

> +   (source (origin
> +            (method git-fetch)
              ^
Here too.

> +            (sha256
> +             (base32 "0a55zk3qrw9yl27i87h3brg2hskmmzbfda77dhq9a4if7y70xnfb"))))

Put the hash string on a new line.

> +   (description "Library for sending commands and receiving replies to and
> +from a Redis server.  It comes with a synchronous API, asynchronous API and
> +reply parsing API.  Only the binary-safe Redis protocol is supported.")

"This package provides a library for ..." is probably better.

    -- (

Message #11 received at 58432 <at> debbugs.gnu.org (full text, mbox):

From: Thomas Albers <thomas <at> thomaslabs.org>
To: 58432 <at> debbugs.gnu.org
Cc: Thomas Albers <thomas <at> thomaslabs.org>
Subject: [PATCH] gnu: Add hiredis
Date: Tue, 11 Oct 2022 15:08:34 +0200

* gnu/packages/databases.scm (hiredis): New variable.
---
 gnu/packages/databases.scm | 28 +++++++++++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index cf07832df7..8523c084e4 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -58,6 +58,7 @@
 ;;; Copyright © 2022 Zhu Zihao <all_but_last <at> 163.com>
 ;;; Copyright © 2021 Brice Waegeneire <brice <at> waegenei.re>
 ;;; Copyright © 2022 muradm <mail <at> muradm.net>
+;;; Copyright © 2022 Thomas Albers Raviola <thomas <at> thomaslabs.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2494,6 +2495,31 @@ (define-public redis
     (home-page "https://redis.io/")
     (license license:bsd-3)))

+(define-public hiredis
+  (package
+    (name "hiredis")
+    (version "1.0.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/redis/hiredis")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0a55zk3qrw9yl27i87h3brg2hskmmzbfda77dhq9a4if7y70xnfb"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     ;; needed for testing
+     (list redis))
+    (synopsis "Minimalistic C client library for the Redis database")
+    (description "This package provides a library for sending commands and
+receiving replies to and from a Redis server.  It comes with a synchronous
+API, asynchronous API and reply parsing API.  Only the binary-safe Redis
+protocol is supported.")
+    (home-page "https://github.com/redis/hiredis")
+    (license license:bsd-3)))
+
 (define-public ruby-redis
   (package
     (name "ruby-redis")
--
2.37.3

Message #14 received at 58432 <at> debbugs.gnu.org (full text, mbox):

From: Thomas Albers Raviola <thomas <at> thomaslabs.org>
To: "(" <paren <at> disroot.org>
Cc: 58432 <at> debbugs.gnu.org
Subject: Re: [bug#58432] [PATCH] gnu: Add hiredis
Date: Tue, 11 Oct 2022 15:10:46 +0200

Thanks ( for the observations. I have sent a new patch with the
corrections.

Message #17 received at 58432 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Thomas Albers" <thomas <at> thomaslabs.org>, <58432 <at> debbugs.gnu.org>
Subject: Re: [bug#58432] [PATCH] gnu: Add hiredis
Date: Tue, 11 Oct 2022 14:34:52 +0100

LGTM :)

    -- (

Message #22 received at 58432-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Thomas Albers <thomas <at> thomaslabs.org>
Cc: 58432-done <at> debbugs.gnu.org
Subject: Re: [bug#58432] [PATCH] gnu: Add hiredis
Date: Thu, 13 Oct 2022 11:10:15 +0100

[Message part 1 (text/plain, inline)]

Thomas Albers via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/databases.scm (hiredis): New variable.
> ---
>  gnu/packages/databases.scm | 28 +++++++++++++++++++++++++++-
>  1 file changed, 27 insertions(+), 1 deletion(-)

Thanks both, I've pushed this to master as
cc58a0c62739d93c1d22a9930f11abdb0bd7ac04.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.