From unknown Sat Aug 16 21:19:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#5843: 23.1.95; Bug in recentf-include-p causes data loss Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Apr 2010 12:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 5843 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 5843@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.12705551671690 (code B ref -1); Tue, 06 Apr 2010 12:00:03 +0000 Received: (at submit) by debbugs.gnu.org; 6 Apr 2010 11:59:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nz7RG-0000RD-LV for submit@debbugs.gnu.org; Tue, 06 Apr 2010 07:59:26 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nz7RE-0000R6-GI for submit@debbugs.gnu.org; Tue, 06 Apr 2010 07:59:24 -0400 Received: from lists.gnu.org ([199.232.76.165]:51855) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Nz7R9-0005w3-BK for submit@debbugs.gnu.org; Tue, 06 Apr 2010 07:59:19 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nz7R8-0004aq-Pn for bug-gnu-emacs@gnu.org; Tue, 06 Apr 2010 07:59:18 -0400 Received: from [140.186.70.92] (port=54889 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nz7R7-0004aD-Kw for bug-gnu-emacs@gnu.org; Tue, 06 Apr 2010 07:59:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.0 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nz7R4-0001pI-6d for bug-gnu-emacs@gnu.org; Tue, 06 Apr 2010 07:59:16 -0400 Received: from ppsw-6.csi.cam.ac.uk ([131.111.8.136]:59925) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nz7R2-0001ot-EG for bug-gnu-emacs@gnu.org; Tue, 06 Apr 2010 07:59:12 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from lapwing-gw-1.csx.cam.ac.uk ([131.111.1.66]:55833 helo=Victoria.local) by ppsw-6.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.156]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1Nz7R0-0006eO-LP (Exim 4.70) for bug-gnu-emacs@gnu.org (return-path ); Tue, 06 Apr 2010 12:59:10 +0100 From: Leo Date: Tue, 06 Apr 2010 12:59:17 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.2 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) There's a bug in `recentf-include-p' that could cause losing all entries in recentf-list. When a predicate in `recentf-exclude' errs, `recentf-include-p' returns nil and thus causes an corresponding entry to be removed. My entire recentf-list (500ish entries) has been damaged because of this and before I found out the data saved has already been overwritten. I think recentf-include-p should not silently ignore an error from any predicates in recentf-exclude because an error signals a bug in the predicate itself. In GNU Emacs 23.1.95.1 (x86_64-apple-darwin10.3.0, Carbon Version 1.6.0 AppKit 1038.29) of 2010-04-03 on Victoria.local Windowing system distributor `Apple Inc.', version 10.6.3 From unknown Sat Aug 16 21:19:07 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Leo Subject: bug#5843: closed (Re: 23.1.95; Bug in recentf-include-p causes data loss) Message-ID: References: X-Gnu-PR-Message: they-closed 5843 X-Gnu-PR-Package: emacs Reply-To: 5843@debbugs.gnu.org Date: Fri, 04 Mar 2011 08:15:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1299226502-11013-1" This is a multi-part message in MIME format... ------------=_1299226502-11013-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #5843: 23.1.95; Bug in recentf-include-p causes data loss which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 5843@debbugs.gnu.org. --=20 5843: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D5843 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1299226502-11013-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 5843-done) by debbugs.gnu.org; 4 Mar 2011 08:14:44 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvQ9s-0002r4-39 for submit@debbugs.gnu.org; Fri, 04 Mar 2011 03:14:44 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvQ9p-0002qo-F0 for 5843-done@debbugs.gnu.org; Fri, 04 Mar 2011 03:14:41 -0500 Received: from localhost ([127.0.0.1]:49068) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PvQ9j-0000ea-7x; Fri, 04 Mar 2011 03:14:35 -0500 From: Glenn Morris To: 5843-done@debbugs.gnu.org Subject: Re: 23.1.95; Bug in recentf-include-p causes data loss References: X-Spook: MIT-LL EuroFed Bosnia enforcers Jiang Zemin AVN ISEC X-Ran: L}`)}_G`sK]h%1W8eWx``'"\(=]z*+KeYX{KZe:QK'sk/_9jaG]=ErF!3z*']q,j"M&uk* X-Hue: red X-Attribution: GM Date: Fri, 04 Mar 2011 03:14:35 -0500 In-Reply-To: (Leo's message of "Tue, 06 Apr 2010 12:59:17 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 5843-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) Version: 24.1 It does seem better to err on the side of caution and include in case of error. ------------=_1299226502-11013-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Apr 2010 11:59:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nz7RG-0000RD-LV for submit@debbugs.gnu.org; Tue, 06 Apr 2010 07:59:26 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nz7RE-0000R6-GI for submit@debbugs.gnu.org; Tue, 06 Apr 2010 07:59:24 -0400 Received: from lists.gnu.org ([199.232.76.165]:51855) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Nz7R9-0005w3-BK for submit@debbugs.gnu.org; Tue, 06 Apr 2010 07:59:19 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nz7R8-0004aq-Pn for bug-gnu-emacs@gnu.org; Tue, 06 Apr 2010 07:59:18 -0400 Received: from [140.186.70.92] (port=54889 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nz7R7-0004aD-Kw for bug-gnu-emacs@gnu.org; Tue, 06 Apr 2010 07:59:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.0 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nz7R4-0001pI-6d for bug-gnu-emacs@gnu.org; Tue, 06 Apr 2010 07:59:16 -0400 Received: from ppsw-6.csi.cam.ac.uk ([131.111.8.136]:59925) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nz7R2-0001ot-EG for bug-gnu-emacs@gnu.org; Tue, 06 Apr 2010 07:59:12 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from lapwing-gw-1.csx.cam.ac.uk ([131.111.1.66]:55833 helo=Victoria.local) by ppsw-6.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.156]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1Nz7R0-0006eO-LP (Exim 4.70) for bug-gnu-emacs@gnu.org (return-path ); Tue, 06 Apr 2010 12:59:10 +0100 From: Leo To: bug-gnu-emacs@gnu.org Subject: 23.1.95; Bug in recentf-include-p causes data loss Date: Tue, 06 Apr 2010 12:59:17 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) There's a bug in `recentf-include-p' that could cause losing all entries in recentf-list. When a predicate in `recentf-exclude' errs, `recentf-include-p' returns nil and thus causes an corresponding entry to be removed. My entire recentf-list (500ish entries) has been damaged because of this and before I found out the data saved has already been overwritten. I think recentf-include-p should not silently ignore an error from any predicates in recentf-exclude because an error signals a bug in the predicate itself. In GNU Emacs 23.1.95.1 (x86_64-apple-darwin10.3.0, Carbon Version 1.6.0 AppKit 1038.29) of 2010-04-03 on Victoria.local Windowing system distributor `Apple Inc.', version 10.6.3 ------------=_1299226502-11013-1--