From unknown Wed Sep 24 10:43:04 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#58405 <58405@debbugs.gnu.org> To: bug#58405 <58405@debbugs.gnu.org> Subject: Status: [PATCH] services: nginx: Add reload action Reply-To: bug#58405 <58405@debbugs.gnu.org> Date: Wed, 24 Sep 2025 17:43:04 +0000 retitle 58405 [PATCH] services: nginx: Add reload action reassign 58405 guix-patches submitter 58405 EuAndreh severity 58405 normal tag 58405 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 10 00:40:29 2022 Received: (at submit) by debbugs.gnu.org; 10 Oct 2022 04:40:29 +0000 Received: from localhost ([127.0.0.1]:45347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohkaa-0000XX-Tg for submit@debbugs.gnu.org; Mon, 10 Oct 2022 00:40:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:49424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohkaZ-0000XO-BP for submit@debbugs.gnu.org; Mon, 10 Oct 2022 00:40:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohkaY-0006HG-TC for guix-patches@gnu.org; Mon, 10 Oct 2022 00:40:27 -0400 Received: from box.euandre.org ([46.101.160.115]:49551) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohkaX-0008Iy-1M for guix-patches@gnu.org; Mon, 10 Oct 2022 00:40:26 -0400 Received: from authenticated-user (box.euandre.org [46.101.160.115]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.euandre.org (Postfix) with ESMTPSA id C1210FC3D4; Mon, 10 Oct 2022 01:39:49 -0300 (-03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=euandre.org; s=mail; t=1665376790; bh=1lyHw7/3zgNoZ7hno+DURF3kWONiuZHb/eceFkD3Hu4=; h=From:To:Cc:Subject:Date:From; b=gBeZQlS2RKZ1gdTgqu88vfQqMjJMZDzHTZreUjWQP5N14vfioLFq9kk9QjCLm+OBQ tPtLucjdssjZIwd8fIbTP0G4pMBjVzSxwp1zLLYqNHI1KY/4LTyEs5kc3ijuzas3cV IK6bl9jtiZC7B8Mhft3HD7cVQStvt+YbfH0CMie8OwvVIoq8sJwT2+G5AkEmxnAVdw fDVE3kB3jk9TCe+45vINwSrJkzwSMyzpiXsoxsbyzTOL/DEir2LZlqUmsPkR+Fex3w t09RHMo6o1BW2VnJspNQI/8LCxVtPPJt6pzMRFKsePcUbs5i/DNrHoobm2WX+/RyeH ehMHWIZpyc1WA== From: EuAndreh To: guix-patches@gnu.org Subject: [PATCH] services: nginx: Add reload action Date: Mon, 10 Oct 2022 01:39:32 -0300 Message-Id: <20221010043932.28384-1-eu@euandre.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=46.101.160.115; envelope-from=eu@euandre.org; helo=box.euandre.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: EuAndreh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) In a new "reload" shepherd-action, send a SIGHUP to the NGINX master process, so that it can re-read the configuration file and start new worker processes. * gnu/services/web.scm (nginx-shepherd-service): Add the "reload" shepherd-action --- gnu/services/web.scm | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/gnu/services/web.scm b/gnu/services/web.scm index e5ab1a1180..227a577de3 100644 --- a/gnu/services/web.scm +++ b/gnu/services/web.scm @@ -807,7 +807,6 @@ (define (nginx-shepherd-service config) #~#t #~(read-pid-file #$pid-file)))))))) - ;; TODO: Add 'reload' action. (list (shepherd-service (provision '(nginx)) (documentation "Run the nginx daemon.") @@ -815,7 +814,19 @@ (define (nginx-shepherd-service config) (modules `((ice-9 match) ,@%default-modules)) (start (nginx-action "-p" run-directory)) - (stop (nginx-action "-s" "stop"))))))) + (stop (nginx-action "-s" "stop")) + (actions + (list + (shepherd-action + (name 'reload) + (documentation "Reload NGINX configuration file and restart worker processes.") + (procedure + #~(lambda (pid) + (if pid + (begin + (kill pid SIGHUP) + (format #t "Service NGINX (PID ~a) has been reloaded." pid)) + (format #t "Service NGINX is not running.")))))))))))) (define nginx-service-type (service-type (name 'nginx) -- 2.37.3 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 11 06:53:14 2022 Received: (at 58405) by debbugs.gnu.org; 11 Oct 2022 10:53:14 +0000 Received: from localhost ([127.0.0.1]:51149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiCss-0004xh-8k for submit@debbugs.gnu.org; Tue, 11 Oct 2022 06:53:14 -0400 Received: from mira.cbaines.net ([212.71.252.8]:41542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiCsq-0004xX-1Z for 58405@debbugs.gnu.org; Tue, 11 Oct 2022 06:53:12 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:fc93:27fb:8412:c8b7]) by mira.cbaines.net (Postfix) with ESMTPSA id 9C2F027BBE9; Tue, 11 Oct 2022 11:53:11 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 3e6bf79f; Tue, 11 Oct 2022 10:53:11 +0000 (UTC) References: <20221010043932.28384-1-eu@euandre.org> User-agent: mu4e 1.8.9; emacs 28.1 From: Christopher Baines To: EuAndreh Subject: Re: [bug#58405] [PATCH] services: nginx: Add reload action Date: Tue, 11 Oct 2022 11:51:50 +0100 In-reply-to: <20221010043932.28384-1-eu@euandre.org> Message-ID: <87h70aaay0.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58405 Cc: 58405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain EuAndreh via Guix-patches via writes: > In a new "reload" shepherd-action, send a SIGHUP to the NGINX master > process, so that it can re-read the configuration file and start new > worker processes. > > * gnu/services/web.scm (nginx-shepherd-service): Add the "reload" > shepherd-action > --- > gnu/services/web.scm | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) With the NGinx service currently, you need to restart it to change the NGinx binary or configuration file. What's the purpose of the reload action here given that neither the binary or configuration file being used will change? Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmNFSxdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XdLPQ//UfzDl3d0jA0tHOjiVPlzXQ+52p/Segu4 SwQWEY4ClL1bramqZlAKNtkhFmVcCKKR+951bCu69VqIHONRpJCT/y1tUTZGARi7 F8koTFOrJY0hSEt0/z4tD/KMMtwaRL+aoIIYo2NKjfDKwz2UqZ50eSdOibqvBJza 2QTkTJ4Skbr3MdiqUesbZyDJVzWUciXHSiN9FAUThK2aIEQogh+xISz+ZTQRKsbO +goG6/dlpfAGQqRtuSKJqbV06mA7ajxkK6LzeGAfXCINIMtMof2JpAnV1F2apViQ 4c6/lpiczEOJ3r/dMYsO8U9bIAjzavH48BfDA9v0Dk9s3NhjJDlNfyDbjLsYzNkn q/FXxyWsxYtIMbEhN5xhG2VpT6wGlEN6EEeKI9WmBMB44eXHzsnxJGaeMpXB7YOb YxlFaFnUFDMWRFsstnABt9bEhYXF3nmwfv1jdt3xetSduCg5G1eJwexne9jV95ft yn+OTVvJwQz04JOeAB+SLijIWGYT1sxWlkNOdgQ74zKmPio580610v84UsmPFOrK sty3xAM0tpEVDbcmsnbR5PWXSlUwU+aYETqp/2kATaoyXYQ3z0OitVpTYQ9tG2GQ PV13Io2dCqa6dcQk1b+wwOcpErdqR25U8IqRaSIUe0LRpzl8ksg/uF/GMKNXlFJn g8saQ/aXyLs= =U4kc -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 12 03:01:10 2022 Received: (at 58405) by debbugs.gnu.org; 12 Oct 2022 07:01:10 +0000 Received: from localhost ([127.0.0.1]:55480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiVjq-0005r7-9R for submit@debbugs.gnu.org; Wed, 12 Oct 2022 03:01:10 -0400 Received: from box.euandre.org ([46.101.160.115]:41395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiVjk-0005qR-EK for 58405@debbugs.gnu.org; Wed, 12 Oct 2022 03:01:08 -0400 Received: from authenticated-user (box.euandre.org [46.101.160.115]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.euandre.org (Postfix) with ESMTPSA id AF871FC3D4; Wed, 12 Oct 2022 04:00:55 -0300 (-03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=euandre.org; s=mail; t=1665558056; bh=ympI30cu8UJ0osGz+VooUn37iGDWeZ7pODTuOqbTlZ0=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=bssflA/IC/1o4RaRWPfJ8YR1U3HOakwP9O6CvmHPiJNQplzYOzQ08HwlOhKnKU2Lr 4sde2rrwJB0OVXXncHRRhxIbtNdtTRqXwyYaVapCk6CSpihftNcqb2JpexNYlxQvc0 Mv4NBdSHLpo5KsmrmHlkcx+ypxDnm+F2rjlrhRajMiw54Jcmr+Z50Hwi5Ge0WrxCfC IsXZI0EutPXoKU3ymxap9h6rOL15C2AwA1evZFKHByWRsK47+hYwRB54/H5JTctWqe 18XlOkZmi+/2aDg0fnoG2Ao9IIW48T9jzh3CYQKEo449VqlV5z85ApH08+tftmbUqN FDUYgAuri6cwQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <87h70aaay0.fsf@cbaines.net> References: <20221010043932.28384-1-eu@euandre.org> <87h70aaay0.fsf@cbaines.net> Subject: Re: [bug#58405] [PATCH] services: nginx: Add reload action From: EuAndreh To: Christopher Baines Date: Wed, 12 Oct 2022 04:00:46 -0300 Message-ID: <166555804644.2805.1693234721157753050@localhost> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58405 Cc: 58405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > With the NGinx service currently, you need to restart it to change the > NGinx binary or configuration file. It is true that you need to restart to change the NGINX binary, but this is not true for changing the configuration file. NGINX's master process reloads the configuration file, which could have an "include" line that points to ad-hoc files in /etc. So even though the NGINX service is using the immutable file inside /gnu/store, reloading it can have it change its runtime behaviour. The same behaviour is relied upon for certbot certificates: the current certificate lives in /etc/letsencrypt/live, but it is a symlink that points to /etc/letsencrypt/archive. When a certificate is renewed, a SIGHUP ought to be sent to NGINX in order to reload the configuration file, so that the certificates themselves can be reloaded, even though neither the NGINX binary nor the configuration file changed, but only what they point to did. > What's the purpose of the reload action here given that neither the > binary or configuration file being used will change? I'm doing blue/green deployments on a web service. I have the equivalent of /etc/my-service/{blue,green,active}.conf files, and an "include" line in the main NGINX configuration that includes the "active" one. Doing a deploy from blue to green is done by changing the `active.conf` symlink to point to `green.conf` instead, and sending a SIGHUP to NGINX. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 13 06:56:22 2022 Received: (at 58405) by debbugs.gnu.org; 13 Oct 2022 10:56:22 +0000 Received: from localhost ([127.0.0.1]:59714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oivsz-0006t9-U3 for submit@debbugs.gnu.org; Thu, 13 Oct 2022 06:56:22 -0400 Received: from mira.cbaines.net ([212.71.252.8]:41562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oivsy-0006t0-2R for 58405@debbugs.gnu.org; Thu, 13 Oct 2022 06:56:20 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:fc93:27fb:8412:c8b7]) by mira.cbaines.net (Postfix) with ESMTPSA id 09AFA27BBE9; Thu, 13 Oct 2022 11:56:19 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 3a519043; Thu, 13 Oct 2022 10:56:18 +0000 (UTC) References: <20221010043932.28384-1-eu@euandre.org> <87h70aaay0.fsf@cbaines.net> <166555804644.2805.1693234721157753050@localhost> User-agent: mu4e 1.8.9; emacs 28.1 From: Christopher Baines To: EuAndreh Subject: Re: [bug#58405] [PATCH] services: nginx: Add reload action Date: Thu, 13 Oct 2022 11:40:23 +0100 In-reply-to: <166555804644.2805.1693234721157753050@localhost> Message-ID: <87a660801b.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58405 Cc: 58405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain EuAndreh writes: >> With the NGinx service currently, you need to restart it to change the >> NGinx binary or configuration file. > > It is true that you need to restart to change the NGINX binary, but this > is not true for changing the configuration file. > > NGINX's master process reloads the configuration file, which could have > an "include" line that points to ad-hoc files in /etc. So even though > the NGINX service is using the immutable file inside /gnu/store, > reloading it can have it change its runtime behaviour. > > The same behaviour is relied upon for certbot certificates: the current > certificate lives in /etc/letsencrypt/live, but it is a symlink that > points to /etc/letsencrypt/archive. When a certificate is renewed, a > SIGHUP ought to be sent to NGINX in order to reload the configuration > file, so that the certificates themselves can be reloaded, even though > neither the NGINX binary nor the configuration file changed, but only > what they point to did. That makes sense. I do think this still might cause confusion, since I think some will expect this to change NGinx to use the configuration defined in the system configuration. I'm not quite sure how to address that, but I think this can still be merged. Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmNH7tBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xd3Mw//cOibUqQovSdIMApd/pHe+Gn5ObOJrIwF D0a+34yubn/4xFWXeY9GFuRXhv/7jyQtuk+opSlkgo0ZAK3jt8YnyAIuUgvW05Ac XsJ8k2DA4LD6XALfsyNlPdk0C79nwiPEnv43rW6+Kae0q4CjyrMR+rx4Oqdzend9 uky5MtUhRohkkeZiuSIFRsnUS4pMwI9ynhUwl28XAVaXAH8gfsqSo8grGt3Rhq6p MlZ3X+ulaoJVhWScOqNYuvcvKxoOunot84cj090z5hkvxRyN35CzCTbRz1ro+s4y ehxIqV/V94q4LUwlPddLDZBs6dTxcjRzPhFJSy7mS81xQFdcVSDHfYGZigpcyeSm GgAYX692QjB9yeA606bu4ajFup4lrc20a/TxvkJh2p/0OKRebKofU5ba1P1agr8m hgqO+yPVDmdB+kZe2lqKNY6Y9Kk5/RY9wKNu7oTtai5owXDx0tOSv5h0QnpD9eTc Pce6w0A5VaNJWqmBgKTpst+8QG1xipveyVeghdMDHQz75W9YXZS0kjH0vH6UfLvE jENcCXld6VTtWQFNVA+xSf6mT5mal6WaVrkJRhcM7FLc0O+YLFzYECSsGZDp1Ic7 xLPra/DOrSjXzkERxlJeIKfJ3iA0Qd1VbX9JROJ6degu5BKZVSP8rZ5gIu64ZhnT 2MCMjZ0XCaY= =QmHO -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 13 07:39:29 2022 Received: (at 58405-done) by debbugs.gnu.org; 13 Oct 2022 11:39:30 +0000 Received: from localhost ([127.0.0.1]:59753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiwYj-0001lH-Lb for submit@debbugs.gnu.org; Thu, 13 Oct 2022 07:39:29 -0400 Received: from mira.cbaines.net ([212.71.252.8]:41568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiwYh-0001l8-1y for 58405-done@debbugs.gnu.org; Thu, 13 Oct 2022 07:39:27 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:fc93:27fb:8412:c8b7]) by mira.cbaines.net (Postfix) with ESMTPSA id 3A63927BBE9; Thu, 13 Oct 2022 12:39:26 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 9a5ac3b4; Thu, 13 Oct 2022 11:39:25 +0000 (UTC) References: <20221010043932.28384-1-eu@euandre.org> <87h70aaay0.fsf@cbaines.net> <166555804644.2805.1693234721157753050@localhost> <87a660801b.fsf@cbaines.net> User-agent: mu4e 1.8.9; emacs 28.1 From: Christopher Baines To: EuAndreh Subject: Re: [bug#58405] [PATCH] services: nginx: Add reload action Date: Thu, 13 Oct 2022 12:38:14 +0100 In-reply-to: <87a660801b.fsf@cbaines.net> Message-ID: <87wn946jh0.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58405-done Cc: 58405-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Christopher Baines writes: > I'm not quite sure how to address that, but I think this can still be > merged. I've gone ahead and pushed this as 10d429f2fce321d8285684503094694ec3979865. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKkBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmNH+OtfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XeiNg/4n3lBPKGWPRYmai/qfTVLbfxTAliEtVlZ bzLFNwlwtX02i1psVtj68Aw8uVu4A0jYoZjaRdtruELcsPXu71lvWhtzNhoJjc3d lkQ1PPMNyUMudsKmtLSixI6NgE2MtSDEGEzGu+ITXfKFrb1Ntrsb/OFxNb8tGTaT TcpQlSbtyjvVBcktikwhB0YSw8ixCcO//ywUwWRdDJX3h8mTf7MvjEIA7wvhP5Qt bHy2vgqFVoVXmjW/TH5Y8fteN/a20FLGdNUy2aI+KHYc58uYilNo8En5GauBiMeQ gA6688lye2hcFpIzSBcRmUcvR3NSYTrZtDVdUrMTKyMJgtvNg4Yi0aSbolMGFCAb txFY/i4HuxHsTg+a+ljDGe5pvWxspSrKqjl+8PUAQCXy0KEZDHl7bgVHBW8YIIjf ZM/xpVjdFUVe8hC32qJxSCrdepQvwaqXj/wIw+YYoGV3lnRZL1fr1lEpLBlL6REY xf+F4Uu0RjqKL4axuX+Y2/X943EAL3SDQuf7E11cu4WY9bnZEnhlSLzdbYw3O10T sh1l6ExTAIqc4M9+VUtfK9s+JPPweUfVxGB89SH6qabcm+jcBMm4dNgpuVqcQPuJ P35z9mIgUiPDvCoQJ/fazIAFbDJhdlm7igvg2PlhxMU8/fFtJg8yrvkUZyBbk2pg W6ptAwqNNA== =sn0c -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 13 10:02:14 2022 Received: (at 58405) by debbugs.gnu.org; 13 Oct 2022 14:02:14 +0000 Received: from localhost ([127.0.0.1]:34376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiyms-0000Be-Fp for submit@debbugs.gnu.org; Thu, 13 Oct 2022 10:02:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53114) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiymq-0000BG-9e for 58405@debbugs.gnu.org; Thu, 13 Oct 2022 10:02:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33122) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiymk-00048d-5b; Thu, 13 Oct 2022 10:02:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=tf+Y5wIymf0XRtUwpT8ydCvChoh6mSE1mkPeukfe4Ew=; b=maYgqgvwCcsCnQ4fzD85 8p/Ar0qmXLqHJRIYDoY54L9ACNE5hCw0rF2orLCtNg7Tfa7zIuASm9h/60okx3GXgHGCMVqFpGdad NMCvS0YMvHzHXNEil015Gl7sUw8jTFu8bM0h+lJVkoLmwsQyo1vqMbf69kmy6mVIDhePE8xkl7AX8 5mSAIOykj5Ip5EVXpRuZrQkrK1GIy/mNo/C5YK4QMR2JiNDOrMvHJzj+awNesN95M069jLnE7XIuh 72Ixbqw1ASKWIDEWQSLPWjmZSq+S7PtlB6+EucKljI0iCUTz/+vbwbZbENHtRV2IsudHZs/Tqadke ezwzx1WFg9BDeg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:51338 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiymj-0005rg-Od; Thu, 13 Oct 2022 10:02:05 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: EuAndreh Subject: Re: bug#58405: [PATCH] services: nginx: Add reload action References: <20221010043932.28384-1-eu@euandre.org> Date: Thu, 13 Oct 2022 16:02:03 +0200 In-Reply-To: <20221010043932.28384-1-eu@euandre.org> (EuAndreh's message of "Mon, 10 Oct 2022 01:39:32 -0300") Message-ID: <87v8onq0tg.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58405 Cc: 58405@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, A late comment=E2=80=A6 EuAndreh skribis: > + (shepherd-action > + (name 'reload) > + (documentation "Reload NGINX configuration file and res= tart worker processes.") > + (procedure > + #~(lambda (pid) > + (if pid > + (begin > + (kill pid SIGHUP) Isn=E2=80=99t =E2=80=98nginx -s reload=E2=80=99 the documented way to do th= at? Or maybe it=E2=80=99s completely equivalent? > + (format #t "Service NGINX (PID ~a) has been r= eloaded." pid)) > + (format #t "Service NGINX is not running.")))))= ))))))) Nitpick: According to it seems that the correct spelling is =E2=80=9Cnginx=E2=80=9D, lowercase. :-) Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 13 12:02:18 2022 Received: (at 58405) by debbugs.gnu.org; 13 Oct 2022 16:02:18 +0000 Received: from localhost ([127.0.0.1]:34655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oj0f4-0005km-KW for submit@debbugs.gnu.org; Thu, 13 Oct 2022 12:02:18 -0400 Received: from box.euandre.org ([46.101.160.115]:44151) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oj0f2-0005kW-J7 for 58405@debbugs.gnu.org; Thu, 13 Oct 2022 12:02:17 -0400 Received: from authenticated-user (box.euandre.org [46.101.160.115]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.euandre.org (Postfix) with ESMTPSA id 4165CFC495; Thu, 13 Oct 2022 13:02:09 -0300 (-03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=euandre.org; s=mail; t=1665676930; bh=S9WLhlp7EnS5Xp47DirjBcg2qxOkSnWTJcmKLSZPzOw=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=ppjGcffCponwcpqjXT1prpX6KeIU32bfrUmhKaWPEKfjz2A6l9eKkgtCsRYfHzSlJ rPkquaHLHslfG4kmBzOV653t84gMS+Dy+GCjCpYyLeQvMTv27Cqa/CJIvAcburOncz ejK0RRgDdJPkxXKJldUOhv4aJ8uZ8wtcdXom05dxTfzS2KhTRZZRQN9vare/oZ2ubK Wxeztmx0WBBDrueEroBpEBFSe26Y5jfqFKg6JG6rYiblJlzbL8+ky1jmhsz3c6J/ZX 0YyNZO6QpoIWUOeTMXOA5Quy2h+7Qxzm4VlYM6RJTcPucRQUHtv1P3J3bxXAotirt4 /d5GcbQ3mWTRQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <87a660801b.fsf@cbaines.net> References: <20221010043932.28384-1-eu@euandre.org> <87h70aaay0.fsf@cbaines.net> <166555804644.2805.1693234721157753050@localhost> <87a660801b.fsf@cbaines.net> Subject: Re: [bug#58405] [PATCH] services: nginx: Add reload action From: EuAndreh To: Christopher Baines Date: Thu, 13 Oct 2022 13:02:03 -0300 Message-ID: <166567692392.1002.1128529192389237246@localhost> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58405 Cc: 58405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > That makes sense. I do think this still might cause confusion, since I > think some will expect this to change NGinx to use the configuration > defined in the system configuration. How about being more explicit in the action documentation about the scope o= f the reload? From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 13 12:06:07 2022 Received: (at 58405) by debbugs.gnu.org; 13 Oct 2022 16:06:07 +0000 Received: from localhost ([127.0.0.1]:34665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oj0il-0005rq-Gc for submit@debbugs.gnu.org; Thu, 13 Oct 2022 12:06:07 -0400 Received: from box.euandre.org ([46.101.160.115]:60365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oj0ih-0005qv-Sr for 58405@debbugs.gnu.org; Thu, 13 Oct 2022 12:06:05 -0400 Received: from authenticated-user (box.euandre.org [46.101.160.115]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.euandre.org (Postfix) with ESMTPSA id D7A73FC495; Thu, 13 Oct 2022 13:05:56 -0300 (-03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=euandre.org; s=mail; t=1665677158; bh=JgN5EnXj6lzZfHHLxkVLMcqzc4byS4bJXBqE1Sb6mkE=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=Rotf82vELHn1P5+jE+YQsdx/HZwDekw/HxemaUVhA47iatP4ov+ScDGPVbaGWx2vv D8GymAu9ZQm6MvflHY4kloZgwT5JJRNc3ofRaX5+Bcv74usqFZIEUIcV0s0G7sPyzO 4AwRPvAd0D72bz8BCyoXA6MCs8lczXmfV7J0RPKvYIzUZrLISWEIqYUSWCXgMyGgEA rtv0R0DZSd4GCteD7WF3epAMBommwRCpqV3Dd8zAul+LHeyFJSbmowybG0q8p7xxNn +Sg6GcfIFR1w6bHtqZYZKlkV3bxu2KnnmL6GL3zq2ylFFwY2S3o6p2o4CsBDdZBe2H rDB4BcBNGxNEg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <87v8onq0tg.fsf@gnu.org> References: <20221010043932.28384-1-eu@euandre.org> <87v8onq0tg.fsf@gnu.org> Subject: Re: bug#58405: [PATCH] services: nginx: Add reload action From: EuAndreh To: Ludovic =?utf-8?q?Court=C3=A8s?= Date: Thu, 13 Oct 2022 13:05:51 -0300 Message-ID: <166567715189.1002.10471412833004207259@localhost> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58405 Cc: 58405@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) They're compleltely equivalent :) Both are documented ways of doing the same, see: - https://nginx.org/en/docs/control.html - https://nginx.org/en/docs/beginners_guide.html > Nitpick: According to it seems that the correct > spelling is =E2=80=9Cnginx=E2=80=9D, lowercase. :-) Oh, TIL. I'll fix that. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 13 12:38:42 2022 Received: (at 58405) by debbugs.gnu.org; 13 Oct 2022 16:38:42 +0000 Received: from localhost ([127.0.0.1]:34784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oj1EI-0006pt-DQ for submit@debbugs.gnu.org; Thu, 13 Oct 2022 12:38:42 -0400 Received: from box.euandre.org ([46.101.160.115]:48057) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oj1E9-0006pK-K8 for 58405@debbugs.gnu.org; Thu, 13 Oct 2022 12:38:40 -0400 Received: from authenticated-user (box.euandre.org [46.101.160.115]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.euandre.org (Postfix) with ESMTPSA id 540D1FC495; Thu, 13 Oct 2022 13:38:26 -0300 (-03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=euandre.org; s=mail; t=1665679107; bh=gHZvR2TBagCXr5tVe9hrSf+UePYvHgadaKlpjbPJ+OQ=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=0cE3inhcasuSp7d+S/g6hsV6I+fJFZdo+6zZ4DcTQjVcztMgukI7Qvn0fL3HZgtzJ EDTpeRjxFFQbeRg5CT/xWjqXo/uF06+1Mufua48hr/Xint8FhoQsSbWWpmyh2xRViH Qm9T6ZF2hv2Qys63+IJkPxSV8UKgfYWTAxrp/PB4bDvA0R7mE2AZshrLLqBN3p3Y7a cOVicqTeh8G0TsTB1xj3EG1RzjmWohvi/o6TUoI/SR0GvC/K7GMhtcfJj6giX42m0b yp3g+FavSH6btr4M9+C2fa4KQ6/lGRY2eAwImp/S2y5WRdRU8IsB1LvsHzPzqg8sjv pek+Krd02+WAQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <166567692392.1002.1128529192389237246@localhost> References: <20221010043932.28384-1-eu@euandre.org> <87h70aaay0.fsf@cbaines.net> <166555804644.2805.1693234721157753050@localhost> <87a660801b.fsf@cbaines.net> <166567692392.1002.1128529192389237246@localhost> Subject: Re: [bug#58405] [PATCH] services: nginx: Add reload action From: EuAndreh To: Christopher Baines Date: Thu, 13 Oct 2022 13:38:19 -0300 Message-ID: <166567909990.18703.909407946097887605@localhost> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58405 Cc: 58405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I think it would address your concerns on confusion of users.=20 I'm up for doing it if you agree. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 14 06:43:34 2022 Received: (at 58405) by debbugs.gnu.org; 14 Oct 2022 10:43:34 +0000 Received: from localhost ([127.0.0.1]:35867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojIAA-0004e2-JG for submit@debbugs.gnu.org; Fri, 14 Oct 2022 06:43:34 -0400 Received: from mira.cbaines.net ([212.71.252.8]:41586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojIA8-0004dq-67 for 58405@debbugs.gnu.org; Fri, 14 Oct 2022 06:43:32 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:fc93:27fb:8412:c8b7]) by mira.cbaines.net (Postfix) with ESMTPSA id 4A70C27BBEA; Fri, 14 Oct 2022 11:43:31 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id c5fcbf5e; Fri, 14 Oct 2022 10:43:30 +0000 (UTC) References: <20221010043932.28384-1-eu@euandre.org> <87h70aaay0.fsf@cbaines.net> <166555804644.2805.1693234721157753050@localhost> <87a660801b.fsf@cbaines.net> <166567692392.1002.1128529192389237246@localhost> User-agent: mu4e 1.8.9; emacs 28.1 From: Christopher Baines To: EuAndreh Subject: Re: [bug#58405] [PATCH] services: nginx: Add reload action Date: Fri, 14 Oct 2022 11:43:19 +0100 In-reply-to: <166567692392.1002.1128529192389237246@localhost> Message-ID: <87mt9y65yo.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58405 Cc: 58405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain EuAndreh writes: >> That makes sense. I do think this still might cause confusion, since I >> think some will expect this to change NGinx to use the configuration >> defined in the system configuration. > > How about being more explicit in the action documentation about the scope of the > reload? Yeah, that sounds good to me. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmNJPU9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XdO/xAApU8SoKgCYJzPvy8Tg1CMV/MD6VFi1ijm q5SW8fBvWCnPsdS7gAvv/INUTBEMAcjInh+CaeUpcqfhPbfS0PT4VWqvSzPspNyw 414OZB/IzkudOM1HG5y0gK2zsLqbDtNfamuNauSurUI2Ehh/M/KwFMGtC+PVHb6M 53qK8ttn823JOGFxOp0LHhZuZKlFY5QWOtw7r5MClIjtmLl2mv2cWWdE1FQzZNvq pFRfKCx5QhLT0v8ufuT2e0sImscxnfPaZpx+Ug/YnlmAfifCrvfy03fJW70tJIsk +6HWuxHevDHipsPdv9U3zqj+3RWEQWaQYi/WG9PKLutCzMMkQPbTjR9etT2szXbS avKeTa+L9z5bCjEWhJXOMwRwMhZRk2L6uOMQ8F/HqDESyp3qtJLJ/cFMri+jCJeN BMCl8NtHdXryIAtf/xPEYZlqINuLr2i2JbCEiv8W5zZsz6wZFoAk/ydg9O/uJXhk aNcOLqNj4t0Z9KoSr9Owla2bIf6EBGcPZ0osmuF971aW/wXmsLbaNqR7XcYYduB2 DIboUPUiNkKlF3DdZIjryetcJlVInhFM+Nrx2/9JaFUxPz0s+i7F7ueGXa9xSDVK deGxnVZVSNe7nKJA/a/e8XSMteRz+cgLnd2tGscnhbIbrpStqmbnCfdyYRXNz/Ft vt+OIBRQTlE= =nZvm -----END PGP SIGNATURE----- --=-=-=-- From unknown Wed Sep 24 10:43:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 11 Nov 2022 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator