GNU bug report logs - #58404
29.0.50; [PATCH] When killing Emacs from the last client, don't warn about the session having clients

Previous Next

Package: emacs;

Reported by: Jim Porter <jporterbugs <at> gmail.com>

Date: Sun, 9 Oct 2022 23:33:01 UTC

Severity: normal

Tags: patch

Found in version 29.0.50

Done: Jim Porter <jporterbugs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #23 received at 58404 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58404 <at> debbugs.gnu.org
Subject: Re: bug#58404: 29.0.50; [PATCH] When killing Emacs from the last
 client, don't warn about the session having clients
Date: Mon, 10 Oct 2022 10:49:05 -0700
[Message part 1 (text/plain, inline)]
On 10/10/2022 9:59 AM, Eli Zaretskii wrote:
>> Date: Mon, 10 Oct 2022 09:43:55 -0700
>> Cc: 58404 <at> debbugs.gnu.org
>> From: Jim Porter <jporterbugs <at> gmail.com>
>>
>> Here's why I think prompting then makes sense: when you're in an
>> emacsclient frame and there are other non-client frames (i.e. ones
>> "owned" by the main Emacs process), that looks very similar to the user
>> as when you have a second emacsclient running.
> 
> No, there's a very fundamental difference between the two.  When there
> are client frames showing buffers, for each client buffer there's a
> process waiting, the process which requested the buffer to be edited.
> That's why we prompt: we don't want to fail those waiting processes.
> 
> Non-client frames don't have this problem.

Ok, I think that makes sense. I was hesitant about removing prompts too 
aggressively, since I didn't want to open users up to losing some Emacs 
state without prompting when they would have gotten a prompt before. 
However, you've convinced me that we don't need to worry about 
non-client frames since they don't have processes waiting on them. 
(Maybe some users would want more prompts in case they accidentally kill 
Emacs, but they can always add to 'kill-emacs-query-functions'.)

Attached is a new patch that removes the prompt when called from the 
last remaining client. I also expanded the docstring to explain why the 
prompt is there.
[0001-Don-t-prompt-when-killing-an-Emacs-client-if-it-s-th.patch (text/plain, attachment)]

This bug report was last modified 2 years and 265 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.