From unknown Sun Jun 15 08:26:34 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#58404 <58404@debbugs.gnu.org> To: bug#58404 <58404@debbugs.gnu.org> Subject: Status: 29.0.50; [PATCH] When killing Emacs from the last client, don't warn about the session having clients Reply-To: bug#58404 <58404@debbugs.gnu.org> Date: Sun, 15 Jun 2025 15:26:34 +0000 retitle 58404 29.0.50; [PATCH] When killing Emacs from the last client, don= 't warn about the session having clients reassign 58404 emacs submitter 58404 Jim Porter severity 58404 normal tag 58404 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 09 19:32:35 2022 Received: (at submit) by debbugs.gnu.org; 9 Oct 2022 23:32:35 +0000 Received: from localhost ([127.0.0.1]:45108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohfmc-0001RW-Rs for submit@debbugs.gnu.org; Sun, 09 Oct 2022 19:32:35 -0400 Received: from lists.gnu.org ([209.51.188.17]:33360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohfmb-0001RN-1E for submit@debbugs.gnu.org; Sun, 09 Oct 2022 19:32:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38880) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohfma-0002KP-SC for bug-gnu-emacs@gnu.org; Sun, 09 Oct 2022 19:32:32 -0400 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:42741) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohfmZ-0000ya-5j for bug-gnu-emacs@gnu.org; Sun, 09 Oct 2022 19:32:32 -0400 Received: by mail-pl1-x62a.google.com with SMTP id c24so8964781pls.9 for ; Sun, 09 Oct 2022 16:32:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:from:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=w1sKjuIxKCCGztqBEQUiVhewW24v341Tgh+/PbOB9Fo=; b=g0TuSi/osdRyjd6oqFgTJja82WSC6F9k75idBIeBri5nBuKQIMpH5EZtlU68ULimmq 0qSL5yrGV/jrHlOSO1gV1yZxGwM/7xckNoLlp0Vlzg6Y2GlAkfolpR3pioWJX5hAZCCV mIGq/rFpcHs+eTujeOXZdOdSJ6/jqIa7rM+vgjItOlJPJeugNZM9hHhEmHk/zWycbbuw 4dfbZIeOjeuUdBAGuwpUx7aZOt2JDtc51xyN68KdgCGGDsv4vA0X5b0F3+85RIz4qj8g IzDC/biQ3vrScdlfphTlX0dPEl6r8jeHVQh8eVXVOQmUYJ6DSbW1/02r+OHu5bn8Zuw9 dKLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:from:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w1sKjuIxKCCGztqBEQUiVhewW24v341Tgh+/PbOB9Fo=; b=kVdcJULkXnZ9zxY6rkdyKY66D+6qGC9WwVzdUkfHyqo8P4d4uf8yke6CVuM1Evybv+ 8NDb8KqG/MNh4OHCE29ZUQSy+3oT2KGTzXDqm1FIlZWfxaUFpBkcBm6O9UT/HLhfgElS AmkBpgKZClXoYCzzl93Ih44/ZltOoxFLrqT0Ku/pijJZQEYaYUwAfuLP0FvcO0IaaJDt 8WjxaBQsd9QYtCE+Hb1qUEjAQrZyRycYSKxB1bubnnM0K71vOoDu2spc3/vI/l1g9MIV t5NP5z01X8nQKuDn8BLq/a4dULfy3gKSSHK4rIyIIWQKI+Wk79ZIbZfHiSlC764yjobT 8xFw== X-Gm-Message-State: ACrzQf1xVzvVpR0jI7W4hnleIPiyFGtCKoxyrjVs5v9bbVOzjJ0uzQL2 D3+70QcCtT8l8bYr3YZ4yjAOERAPAco= X-Google-Smtp-Source: AMsMyM46WHdsT/8OP15m4vS99/agLOXysNUlW6Op2eL/rs+1gkdA17yW5DehwBKbw9c6XeWATQiJ5g== X-Received: by 2002:a17:90b:1811:b0:20a:dfbe:522f with SMTP id lw17-20020a17090b181100b0020adfbe522fmr29004157pjb.78.1665358349616; Sun, 09 Oct 2022 16:32:29 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id gt16-20020a17090af2d000b002009db534d1sm4833306pjb.24.2022.10.09.16.32.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Oct 2022 16:32:28 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------xayq8Ou3rZPi2ESATVQ4N2Gg" Message-ID: <20194da7-2318-46db-7536-bbd9e3ddf945@gmail.com> Date: Sun, 9 Oct 2022 16:32:28 -0700 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US From: Jim Porter Subject: 29.0.50; [PATCH] When killing Emacs from the last client, don't warn about the session having clients To: bug-gnu-emacs@gnu.org Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------xayq8Ou3rZPi2ESATVQ4N2Gg Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To reproduce: $ emacs -Q --daemon $ emacsclient foo.txt M-x save-buffers-kill-emacs => This Emacs session has clients; exit anyway? I think that's unnecessary. Since we're in the last (only) client, we can't accidentally kill other clients that we don't see right now (e.g. ones in an SSH connection); they don't exist! Couldn't we just proceed ahead without the prompt? On the other hand, I think it *would* be useful to prompt if you're in the last client, but there are other non-client frames. This can happen if you start the main Emacs process without --daemon or if you use --no-wait. For example: $ emacs -Q --daemon $ emacsclient foo.txt $ emacsclient --no-wait -c bar.txt ;; From the first client: M-x save-buffers-kill-emacs => This Emacs session has clients; exit anyway? This is ok, except the prompt could be clearer. The real issue is that the session has non-client frames that would get killed. Attached is a patch to do this. --------------xayq8Ou3rZPi2ESATVQ4N2Gg Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-prompt-when-killing-an-Emacs-client-if-it-s-th.patch" Content-Disposition: attachment; filename*0="0001-Don-t-prompt-when-killing-an-Emacs-client-if-it-s-th.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAyZmI2YzZkYTk5Yjg0YzI1MGU1OTQwOWQ0ZGMwYWRiZGJlNzA0ZmVkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgOSBPY3QgMjAyMiAxNTo1MzoyNyAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIERvbid0IHByb21wdCB3aGVuIGtpbGxpbmcgYW4gRW1hY3MgY2xpZW50IGlmIGl0J3Mg dGhlIGxhc3QKIGNsaWVudAoKKiBsaXNwL3NlcnZlci5lbCAoc2VydmVyLWtpbGwtZW1hY3Mt cXVlcnktZnVuY3Rpb24pOiBJZ25vcmUgdGhlCmN1cnJlbnQgY2xpZW50LCBpZiBhbnkuICBQ cm9tcHQgaWYgdGhlcmUgYXJlIG5vbi1jbGllbnQgZnJhbWVzLgotLS0KIGxpc3Avc2VydmVy LmVsIHwgMjYgKysrKysrKysrKysrKysrKysrKystLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAy MCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avc2Vy dmVyLmVsIGIvbGlzcC9zZXJ2ZXIuZWwKaW5kZXggM2NhYTMzNWM0ZS4uOWViZGFiYmY4NyAx MDA2NDQKLS0tIGEvbGlzcC9zZXJ2ZXIuZWwKKysrIGIvbGlzcC9zZXJ2ZXIuZWwKQEAgLTE1 ODksMTQgKzE1ODksMjggQEAgc2VydmVyLWRvbmUKICAgICAoc2VydmVyLWJ1ZmZlci1kb25l IChjdXJyZW50LWJ1ZmZlcikpKSkKIAogKGRlZnVuIHNlcnZlci1raWxsLWVtYWNzLXF1ZXJ5 LWZ1bmN0aW9uICgpCi0gICJBc2sgYmVmb3JlIGV4aXRpbmcgRW1hY3MgaWYgaXQgaGFzIGxp dmUgY2xpZW50cy4KKyAgIkFzayBiZWZvcmUgZXhpdGluZyBFbWFjcyBpZiBpdCBoYXMgb3Ro ZXIgbGl2ZSBjbGllbnRzIG9yIG5vbi1jbGllbnQgZnJhbWVzLgogQSBcImxpdmUgY2xpZW50 XCIgaXMgYSBjbGllbnQgd2l0aCBhdCBsZWFzdCBvbmUgbGl2ZSBidWZmZXIKIGFzc29jaWF0 ZWQgd2l0aCBpdC4iCi0gIChvciAobm90IChzZXEtc29tZSAobGFtYmRhIChwcm9jKQotICAg ICAgICAgICAgICAgICAgICAgICAoc2VxLXNvbWUgIydidWZmZXItbGl2ZS1wCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAocHJvY2Vzcy1nZXQgcHJvYyAnYnVmZmVycykp KQotICAgICAgICAgICAgICAgICAgICAgc2VydmVyLWNsaWVudHMpKQotICAgICAgKHllcy1v ci1uby1wICJUaGlzIEVtYWNzIHNlc3Npb24gaGFzIGNsaWVudHM7IGV4aXQgYW55d2F5PyAi KSkpCisgIChsZXQgKCh0aGlzLWNsaWVudCAoZnJhbWUtcGFyYW1ldGVyIG5pbCAnY2xpZW50 KSkpCisgICAgKGlmIChzZXEtc29tZSAobGFtYmRhIChwcm9jKQorICAgICAgICAgICAgICAg ICAgICA7OyBJZ25vcmUgdGhlIGN1cnJlbnQgY2xpZW50IHdoZW4gY2hlY2tpbmcgZm9yCisg ICAgICAgICAgICAgICAgICAgIDs7IGxpdmUgY2xpZW50cy4KKyAgICAgICAgICAgICAgICAg ICAgKHVubGVzcyAoZXEgcHJvYyB0aGlzLWNsaWVudCkKKyAgICAgICAgICAgICAgICAgICAg ICAoc2VxLXNvbWUgIydidWZmZXItbGl2ZS1wCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIChwcm9jZXNzLWdldCBwcm9jICdidWZmZXJzKSkpKQorICAgICAgICAgICAgICAg ICAgc2VydmVyLWNsaWVudHMpCisgICAgICAgICh5ZXMtb3Itbm8tcCAiVGhpcyBFbWFjcyBz ZXNzaW9uIGhhcyBvdGhlciBjbGllbnRzOyBleGl0IGFueXdheT8gIikKKyAgICAgIChvciAo bm90IChwcm9jZXNzcCB0aGlzLWNsaWVudCkpCisgICAgICAgICAgOzsgQ2hlY2sgaWYgdGhl cmUgYXJlIGFueSBub24tY2xpZW50IGZyYW1lcywgaWdub3JpbmcgdGhlCisgICAgICAgICAg OzsgaW5pdGlhbCBmcmFtZSB3aGVuIGluIGRhZW1vbiBtb2RlLgorICAgICAgICAgICg+PSAo aWYgKGRhZW1vbnApIDEgMCkKKyAgICAgICAgICAgICAgKHNlcS1jb3VudAorICAgICAgICAg ICAgICAgKGxhbWJkYSAoZnJhbWUpCisgICAgICAgICAgICAgICAgIChub3QgKHByb2Nlc3Nw IChmcmFtZS1wYXJhbWV0ZXIgZnJhbWUgJ2NsaWVudCkpKSkKKyAgICAgICAgICAgICAgIChm cmFtZS1saXN0KSkpCisgICAgICAgICAgKHllcy1vci1uby1wCisgICAgICAgICAgICJUaGlz IEVtYWNzIHNlc3Npb24gaGFzIG5vbi1jbGllbnQgZnJhbWVzOyBleGl0IGFueXdheT8gIikp KSkpCiAKIChkZWZ1biBzZXJ2ZXIta2lsbC1idWZmZXIgKCkKICAgIlJlbW92ZSB0aGUgY3Vy cmVudCBidWZmZXIgZnJvbSBpdHMgY2xpZW50cycgYnVmZmVyIGxpc3QuCi0tIAoyLjI1LjEK Cg== --------------xayq8Ou3rZPi2ESATVQ4N2Gg-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 10 02:11:02 2022 Received: (at 58404) by debbugs.gnu.org; 10 Oct 2022 06:11:02 +0000 Received: from localhost ([127.0.0.1]:45521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohm0E-00034h-8M for submit@debbugs.gnu.org; Mon, 10 Oct 2022 02:11:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohm0D-000344-0A for 58404@debbugs.gnu.org; Mon, 10 Oct 2022 02:11:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38728) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohm07-0005cO-O1; Mon, 10 Oct 2022 02:10:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hLi9N77+x60r8OMVkWy4t9/oYWyaUAjtJRsIcHQlDO8=; b=fTo63yBYWt5O ieVmYDoBKvvyklp+FH7psaiC8nFkga247sBb/1EZ8kqfUIghMzK4o9iv1ipZHzaDhL9y6jqnBwffp 8NBYk7+Z+WoCK7T9f/suXlbaLvIs4z19K9XGzus+uHZ0IV/r5e/c2VYhTvYP5j0y5Kc+WLZiNSuSe mgxdLfXDHI8L40DuU8SZlTv3yVmOi9D6J/vYcjAzYSI9eQ2VsrUsJxlC8drH3ziN+XrG5VIh8RYoU 95urrunJRxvEB9jLcgsSur2gZp+9yoWyEVR9k4HeocLCMqUE3noKUXUwyfMrzH8aIcsSPtHoGBVY6 BTnqRfMMoWrYLIHqMIYBxg==; Received: from [87.69.77.57] (port=1999 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohm06-0000sU-Cu; Mon, 10 Oct 2022 02:10:55 -0400 Date: Mon, 10 Oct 2022 09:11:01 +0300 Message-Id: <83k058i4y2.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <20194da7-2318-46db-7536-bbd9e3ddf945@gmail.com> (message from Jim Porter on Sun, 9 Oct 2022 16:32:28 -0700) Subject: Re: bug#58404: 29.0.50; [PATCH] When killing Emacs from the last client, don't warn about the session having clients References: <20194da7-2318-46db-7536-bbd9e3ddf945@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58404 Cc: 58404@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 9 Oct 2022 16:32:28 -0700 > From: Jim Porter > > On the other hand, I think it *would* be useful to prompt if you're in > the last client, but there are other non-client frames. This can happen > if you start the main Emacs process without --daemon or if you use > --no-wait. For example: > > $ emacs -Q --daemon > $ emacsclient foo.txt > $ emacsclient --no-wait -c bar.txt > > ;; From the first client: > M-x save-buffers-kill-emacs > => This Emacs session has clients; exit anyway? > > This is ok, except the prompt could be clearer. The real issue is that > the session has non-client frames that would get killed. > > Attached is a patch to do this. IMO, this is an unnecessary annoyance. We don't by default ask the user any questions today, when they want to kill an Emacs session. Why should we change that in this case? What is the use case where this command could be invoked by mistake and will risk losing edits or other valuable work? From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 10 04:08:27 2022 Received: (at 58404) by debbugs.gnu.org; 10 Oct 2022 08:08:27 +0000 Received: from localhost ([127.0.0.1]:45825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohnpq-0006D8-KH for submit@debbugs.gnu.org; Mon, 10 Oct 2022 04:08:27 -0400 Received: from mail-pf1-f178.google.com ([209.85.210.178]:45024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohnpo-0006Cw-1A for 58404@debbugs.gnu.org; Mon, 10 Oct 2022 04:08:24 -0400 Received: by mail-pf1-f178.google.com with SMTP id i3so586611pfc.11 for <58404@debbugs.gnu.org>; Mon, 10 Oct 2022 01:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=5ATvTHsRlgcJ9bDjDfyVqxfmFBdYhoLEHRnb8qAAPFg=; b=Om8mQHKKMV22T6BHGRIfRHhLF1hMguQQG+v5gggPNZqIv8/lYVecVGieJaU56iSoDC AAjt7Fyq5smLN0HpyM7dbqsoa2jbBKXSYXUbKZQqCJnFY6/6oQsb3XUkj+l+nVTp3Ytr ixETQSd/b2+03LuSglAVv5vLCVwHiOXc4ON79tLHc5BKKtqHLhUR6Q8dDGwtfEmpLmdB 91uKk9XPA7Fpi9b4FpSasuhZe7dSC1wGRS7s2W8yCnrBw+cNhUKKBjoug9fLyI9EEVql azX2d8cXEWiA+tHfSn7Gcv/se7F94DHyaK8eFDnlTub+HjAFVeO1mJjX8BLPaK8TXjE1 IXzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5ATvTHsRlgcJ9bDjDfyVqxfmFBdYhoLEHRnb8qAAPFg=; b=l+EXl0aKQWKrDXu/FC1KexWMGmXDfa5/ecstzsQuU77Nk9qzzIoSjngy/xAuotJ/pb 15thvOb+qI/+pETHpqjh1MXcTv3474S6/Zp7Y07Afg+91y0E1Mz+OvpXwcUYOTvMXZaW 1VgLy1jdcn4FAZZEvtwq7f1Zti5mbeW6Rs/hZCzubgSTu3fAbRWpi62Jn//s5UwPa6tX lEN5+zF9xPzJTJKXDyybO5ZbFongi3JOXrg5q8O8iMi8NtEXcE+T5XKGwQPS/1c6Q38h CG3nfhJm8I/zBprjc6drtUYGup7fFxSek5979As6O02dsaomMGICk1/mqt+1lKrpHdvu hnpQ== X-Gm-Message-State: ACrzQf3mRYr0Ut3Ut0kEYIMRcK9vmrTteeuojxjKFZzw1rSMCLcin8p8 aQnPKfxW6ewuGbCtbkluidQ= X-Google-Smtp-Source: AMsMyM4My2jQw/sqpyvbZzouGz02cunMShpTgxSlTj+ZzR4OUKuc/oew56MJPf5DzdMTvGNJQ0OF9A== X-Received: by 2002:a65:4689:0:b0:458:764a:221b with SMTP id h9-20020a654689000000b00458764a221bmr16017895pgr.296.1665389297993; Mon, 10 Oct 2022 01:08:17 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id kx14-20020a17090b228e00b0020d24a9ad1fsm2686687pjb.52.2022.10.10.01.08.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 01:08:17 -0700 (PDT) Message-ID: <02eb7516-bccc-16ab-84f2-4688849bfba8@gmail.com> Date: Mon, 10 Oct 2022 01:08:17 -0700 MIME-Version: 1.0 Subject: Re: bug#58404: 29.0.50; [PATCH] When killing Emacs from the last client, don't warn about the session having clients Content-Language: en-US To: Eli Zaretskii References: <20194da7-2318-46db-7536-bbd9e3ddf945@gmail.com> <83k058i4y2.fsf@gnu.org> From: Jim Porter In-Reply-To: <83k058i4y2.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58404 Cc: 58404@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 10/9/2022 11:11 PM, Eli Zaretskii wrote: > IMO, this is an unnecessary annoyance. We don't by default ask the > user any questions today, when they want to kill an Emacs session. But Emacs *does* prompt the user today. If you call 'save-buffers-kill-emacs' from an emacsclient frame, it will (almost) always ask you, "This Emacs session has clients; exit anyway?" My patch just gets rid of that annoyance when we can be sure it's unnecessary (i.e. it won't ask if there are no other emacsclients and no other frames not owned by a client). The patch does also change the prompt to be more-precise when there is an open frame not owned by a client[1]. However, it doesn't add any new prompts where there were none before; it only removes a prompt in one case. > What is the use case where this command could be invoked by mistake > and will risk losing edits or other valuable work? I didn't write this code initially, but here's my understanding of why the prompt is useful. If you use "emacs --daemon", 'C-x C-c' ('save-buffers-kill-terminal') will only close the current emacsclient, not shut down the daemon entirely. If you'd like to shut down the daemon too, you can call 'save-buffers-kill-emacs' instead. Maybe you'd even bind that to a key combo or do it automatically in some cases. So given the above, imagine you're at the office. You start the Emacs daemon and connect a GUI emacsclient instance[2]. Then you do a bunch of work until it's time to go home, but you leave your emacsclient running to pick up where you left off the next day. When you get home, you remember that you wanted to edit something quickly, so you SSH into you work computer and start a second emacsclient instance. By now, you forgot about your first emacsclient instance you made while at work. If you call 'save-buffers-kill-emacs' from your SSH emacsclient, it's nice that it can remind you that you have another emacsclient instance still running: since you don't see the GUI frames for the other client, it would be easy to forget about them and kill the session entirely. Then when you go into work the next day, the buffers you had open yesterday would be gone. In this case, you likely haven't lost changes to any files, since you saved before killing the session, but you'd lose non-file buffers, window configuration, etc. (Of course, this assumes you're not using desktop.el.) As for the code I added to check for non-client frames, the story is pretty much the same, although that code is there to handle situations where users start Emacs normally (i.e. by running "emacs") and then start the Emacs server via '(server-start)'. When connecting to that Emacs session remotely, it would be useful to get a prompt for the same reasons above. The only difference is that the GUI frames on your work system are "non-client" frames, so the code checks for them in a different way. [1] Excluding the initial frame for "emacs --daemon", that is. [2] This could be as simple as clicking the "Emacs (client)" icon on your desktop. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 10 04:53:14 2022 Received: (at 58404) by debbugs.gnu.org; 10 Oct 2022 08:53:14 +0000 Received: from localhost ([127.0.0.1]:45952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohoXC-0001BF-8n for submit@debbugs.gnu.org; Mon, 10 Oct 2022 04:53:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohoWx-0001AX-TL for 58404@debbugs.gnu.org; Mon, 10 Oct 2022 04:53:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45656) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohoWs-0006F8-Mu; Mon, 10 Oct 2022 04:52:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=iOa9Vm5PdbKJo9UrlqewB3z3zeqgY8hvJrOUektFqEI=; b=IkWMQU277jZk 9wn8siFoqKxKPCcdvYmc3pM/f6SzGdZArZY6V8hJCzaQ7MvLSLQvFKVGcS5eA+Ne9uLbFF2Pc2A7v JacpN7a0PSGmIjddYtulWJjWZr3+nT1XF44XWjZ9DA7mywVnv3i32fDbunXriQKvdWvZCB4h0x/sY 6hmoQoQN3Ws5uxR076/FM6gvzko+rtPvA1iCvOQSuyXPPkQ+qaKmWLisUs3loxWhjhxuJJuCYrVD7 nH562JOWfnQZPYcLI19dpQVrcdTv/AdCWMp6cicbjZVgnu/Ytom//0rPAvY5iyjbtv/zpxBFuNWr7 tN86fvvFj+by8JAYDfD9XA==; Received: from [87.69.77.57] (port=4004 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohoWs-0004Jr-6h; Mon, 10 Oct 2022 04:52:54 -0400 Date: Mon, 10 Oct 2022 11:53:00 +0300 Message-Id: <83tu4cgivn.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <02eb7516-bccc-16ab-84f2-4688849bfba8@gmail.com> (message from Jim Porter on Mon, 10 Oct 2022 01:08:17 -0700) Subject: Re: bug#58404: 29.0.50; [PATCH] When killing Emacs from the last client, don't warn about the session having clients References: <20194da7-2318-46db-7536-bbd9e3ddf945@gmail.com> <83k058i4y2.fsf@gnu.org> <02eb7516-bccc-16ab-84f2-4688849bfba8@gmail.com> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58404 Cc: 58404@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 10 Oct 2022 01:08:17 -0700 > Cc: 58404@debbugs.gnu.org > From: Jim Porter > > On 10/9/2022 11:11 PM, Eli Zaretskii wrote: > > IMO, this is an unnecessary annoyance. We don't by default ask the > > user any questions today, when they want to kill an Emacs session. > > But Emacs *does* prompt the user today. If you call > 'save-buffers-kill-emacs' from an emacsclient frame, it will (almost) > always ask you, "This Emacs session has clients; exit anyway?" My patch > just gets rid of that annoyance when we can be sure it's unnecessary > (i.e. it won't ask if there are no other emacsclients and no other > frames not owned by a client). It is okay not to prompt when there's no need. That wasn't the part on which I commented, AFAIU. You said: > On the other hand, I think it *would* be useful to prompt if you're in > the last client, but there are other non-client frames. I'm saying that no, it will not be useful to prompt in that case: if the only frames left are non-client frames, we should not prompt, because we don't prompt when there are no client frames to begin with. Apologies if I misunderstood the use case. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 10 12:44:03 2022 Received: (at 58404) by debbugs.gnu.org; 10 Oct 2022 16:44:03 +0000 Received: from localhost ([127.0.0.1]:49695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohvsp-0001lP-4V for submit@debbugs.gnu.org; Mon, 10 Oct 2022 12:44:03 -0400 Received: from mail-pg1-f173.google.com ([209.85.215.173]:43649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohvsn-0001kQ-TO for 58404@debbugs.gnu.org; Mon, 10 Oct 2022 12:44:02 -0400 Received: by mail-pg1-f173.google.com with SMTP id h185so3660560pgc.10 for <58404@debbugs.gnu.org>; Mon, 10 Oct 2022 09:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=GFVk1FD8zGDVrKJN3UZUGhtGDDot0mcqlJlYI3q5eOc=; b=pbFRPkfln4ifpYaKx3RHmGfc1ZoMFXbkrDa19Ui8ZIqA8uVXO6gfw8IMs4iRZuXkkQ gtDEVV8SU3yT9jRbpae6/hiT9sl3t4M0gZJ6YUOlJ+QxkglMU3cczKvLH3JEpsXjSo8v qKE1vE3/rwmCXEYRvvidpgP5cwEV0ktUg97XJwB5hcboPKab1ow155ouSHdE/W7g9Xnu lNFlrW3R8aPk14cSZSPzg6XZvhJBhLZQC/Vu2eAXVfwf5ovumMDF5hRYeqGUVtyq7akv Yzm/vL7RG18vw4iU1ZF0MDjzrbl7SimLarZleTWgw8aHVphFXW1dBkHXH7Z3bSH2r3or tN7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=GFVk1FD8zGDVrKJN3UZUGhtGDDot0mcqlJlYI3q5eOc=; b=sfM/6wDHuOXcME0xUGRvu+q9gUXdZzDnnuvoiX99qXFGLj+uALSeq7xcmo8bYEV8L6 s+rf9CNJlx2FBUWzJDWDDaqb+wHl5w5SN1gdhdEGh2VmQykf9DLVnYZI+T7DVAsZKesz BBx2dyRE4ec12N5ZyW0CB4YUN3cFEn8uMpsfED3tEMTtDgd7JlQPfy8EmDSekUqbETOV cd82PBW4XDuPjxpvHnMJq/BNnpSKuZQr11rWtICv+OLjjY4j+ozYyFrrpmz7R3HSmsZC J56vZIV7fiEVg9E5KmZ0xq+Wkt7xBhk32zADsrYS1CIaEae8qJGmzdp/q44xW5uHawPF rkFQ== X-Gm-Message-State: ACrzQf3xI/L+jl9q+LnpUORJfhTasII923chNIdAwcxZGxPhOm6wA1SE k1+JR/pZphdV3Q0PWjnmG9s= X-Google-Smtp-Source: AMsMyM4DQ5aeZkis8RdjdA+HMJlzEudVkIGYjTwTG8iw3yPiAsFvCk5YFnTmtp9kr2PrpD3OtvGphQ== X-Received: by 2002:a65:5583:0:b0:461:25fe:e982 with SMTP id j3-20020a655583000000b0046125fee982mr8675397pgs.4.1665420235936; Mon, 10 Oct 2022 09:43:55 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id f13-20020a170902f38d00b00172fc5b0764sm6783355ple.270.2022.10.10.09.43.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 09:43:54 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------FT1ttZEE0UrVtkPsIua64HoQ" Message-ID: Date: Mon, 10 Oct 2022 09:43:55 -0700 MIME-Version: 1.0 Subject: Re: bug#58404: 29.0.50; [PATCH] When killing Emacs from the last client, don't warn about the session having clients Content-Language: en-US To: Eli Zaretskii References: <20194da7-2318-46db-7536-bbd9e3ddf945@gmail.com> <83k058i4y2.fsf@gnu.org> <02eb7516-bccc-16ab-84f2-4688849bfba8@gmail.com> <83tu4cgivn.fsf@gnu.org> From: Jim Porter In-Reply-To: <83tu4cgivn.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58404 Cc: 58404@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------FT1ttZEE0UrVtkPsIua64HoQ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/10/2022 1:53 AM, Eli Zaretskii wrote: > It is okay not to prompt when there's no need. That wasn't the part > on which I commented, AFAIU. > > You said: > >> On the other hand, I think it *would* be useful to prompt if you're in >> the last client, but there are other non-client frames. > > I'm saying that no, it will not be useful to prompt in that case: if > the only frames left are non-client frames, we should not prompt, > because we don't prompt when there are no client frames to begin with. > Apologies if I misunderstood the use case. Ah, I see. In that part of my original message, I wanted to say that this was a case where I thought the old code made sense, since it prompts the user then. However, I also thought that the prompt message could be more informative. Here's why I think prompting then makes sense: when you're in an emacsclient frame and there are other non-client frames (i.e. ones "owned" by the main Emacs process), that looks very similar to the user as when you have a second emacsclient running. In other words, I think it would be good for this function to prompt when doing this: $ emacs -Q --daemon $ emacsclient foo.txt $ emacsclient -c bar.txt ;; From either frame: M-x save-buffers-kill-emacs Or this: $ emacs -Q --daemon $ emacsclient foo.txt $ emacsclient --no-wait -c bar.txt ;; From either frame: M-x save-buffers-kill-emacs Or this: $ emacs foo.txt M-x server-start $ emacsclient -c bar.txt ;; From either frame: M-x save-buffers-kill-emacs In all of those cases, the user would have 2 (visible) frames, possibly on different displays/terminals. Since they're visually similar, I think it makes sense to have similar prompts. Next, if the user ran 'save-buffers-kill-emacs' a second time in any of those examples, it *wouldn't* prompt, since then all the remaining frames are associated with a single emacsclient (or no client at all). Since the use case for this is non-obvious (it actually took me several iterations to identify all the possible cases), I updated my patch with clearer (to me) code, plus comments explaining the reasoning. --------------FT1ttZEE0UrVtkPsIua64HoQ Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-prompt-when-killing-an-Emacs-client-if-it-s-th.patch" Content-Disposition: attachment; filename*0="0001-Don-t-prompt-when-killing-an-Emacs-client-if-it-s-th.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAzZjA4YjEyMGE4M2IzYzA2YTc3NzgyM2FjZWU2MDRmOTRmZDQxMjEwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgOSBPY3QgMjAyMiAxNTo1MzoyNyAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIERvbid0IHByb21wdCB3aGVuIGtpbGxpbmcgYW4gRW1hY3MgY2xpZW50IGlmIGl0J3Mg dGhlIGxhc3QKIGNsaWVudAoKUHJldmlvdXNseSwgdGhpcyBmdW5jdGlvbiBwcm9tcHRlZCB3 aGVuZXZlciB0aGVyZSB3YXMgYSBsaXZlIGNsaWVudCwKaW5jbHVkaW5nIHRoZSBjdXJyZW50 IG9uZS4gIE5vdywgb25seSBwcm9tcHQgaW4gb25lIG9mOgoKICAxLiBUaGVyZSBhcmUgbGl2 ZSBFbWFjcyBjbGllbnRzIG90aGVyIHRoYW4gdGhlIGN1cnJlbnQgb25lLCBvcgogIDIuIFRo ZSBjdXJyZW50IGZyYW1lIGlzIGEgY2xpZW50IGZyYW1lIGFuZCB0aGVyZSBhcmUgYWxzbyBu b24tY2xpZW50CiAgICAgZnJhbWVzIG9wZW4uCgoqIGxpc3Avc2VydmVyLmVsIChzZXJ2ZXIt a2lsbC1lbWFjcy1xdWVyeS1mdW5jdGlvbik6IFJld3JpdGUgdG8gYXZvaWQKcHJvbXB0aW5n IGFzIGFib3ZlIChidWcjNTg0MDQpLgotLS0KIGxpc3Avc2VydmVyLmVsIHwgMzIgKysrKysr KysrKysrKysrKysrKysrKysrKystLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyNiBpbnNlcnRp b25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avc2VydmVyLmVsIGIv bGlzcC9zZXJ2ZXIuZWwKaW5kZXggM2NhYTMzNWM0ZS4uZjc0ZjI2MjEwYSAxMDA2NDQKLS0t IGEvbGlzcC9zZXJ2ZXIuZWwKKysrIGIvbGlzcC9zZXJ2ZXIuZWwKQEAgLTE1ODksMTQgKzE1 ODksMzQgQEAgc2VydmVyLWRvbmUKICAgICAoc2VydmVyLWJ1ZmZlci1kb25lIChjdXJyZW50 LWJ1ZmZlcikpKSkKIAogKGRlZnVuIHNlcnZlci1raWxsLWVtYWNzLXF1ZXJ5LWZ1bmN0aW9u ICgpCi0gICJBc2sgYmVmb3JlIGV4aXRpbmcgRW1hY3MgaWYgaXQgaGFzIGxpdmUgY2xpZW50 cy4KKyAgIkFzayBiZWZvcmUgZXhpdGluZyBFbWFjcyBpZiBpdCBoYXMgb3RoZXIgbGl2ZSBj bGllbnRzIG9yIG5vbi1jbGllbnQgZnJhbWVzLgogQSBcImxpdmUgY2xpZW50XCIgaXMgYSBj bGllbnQgd2l0aCBhdCBsZWFzdCBvbmUgbGl2ZSBidWZmZXIKIGFzc29jaWF0ZWQgd2l0aCBp dC4iCi0gIChvciAobm90IChzZXEtc29tZSAobGFtYmRhIChwcm9jKQotICAgICAgICAgICAg ICAgICAgICAgICAoc2VxLXNvbWUgIydidWZmZXItbGl2ZS1wCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAocHJvY2Vzcy1nZXQgcHJvYyAnYnVmZmVycykpKQotICAgICAg ICAgICAgICAgICAgICAgc2VydmVyLWNsaWVudHMpKQotICAgICAgKHllcy1vci1uby1wICJU aGlzIEVtYWNzIHNlc3Npb24gaGFzIGNsaWVudHM7IGV4aXQgYW55d2F5PyAiKSkpCisgIChs ZXQgKCh0aGlzLWNsaWVudCAoZnJhbWUtcGFyYW1ldGVyIG5pbCAnY2xpZW50KSkpCisgICAg KGNvbmQKKyAgICAgOzsgQ2hlY2sgZm9yIEVtYWNzIGNsaWVudHMsIGV4Y2x1ZGluZyB0aGUg Y3VycmVudCBvbmUgKGlmIGFueSkuCisgICAgIDs7IElmIHRoZXJlIGFyZSBhbnkgb3RoZXIg Y2xpZW50cywgcHJvbXB0IHRoZSB1c2VyIGJlZm9yZSBraWxsaW5nCisgICAgIDs7IEVtYWNz LiAgT3RoZXIgY2xpZW50cyBtaWdodCBiZSBvbiBkaWZmZXJlbnQgKHBvc3NpYmx5IHJlbW90 ZSkKKyAgICAgOzsgZGlzcGxheXMsIHNvIGl0IGNhbiBiZSBoYXJkIGZvciB1c2VycyB0byB0 ZWxsIG9uIHRoZWlyIG93bi4KKyAgICAgKChzZXEtc29tZSAobGFtYmRhIChwcm9jKQorICAg ICAgICAgICAgICAgICAgKHVubGVzcyAoZXEgcHJvYyB0aGlzLWNsaWVudCkKKyAgICAgICAg ICAgICAgICAgICAgKHNlcS1zb21lICMnYnVmZmVyLWxpdmUtcAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKHByb2Nlc3MtZ2V0IHByb2MgJ2J1ZmZlcnMpKSkpCisgICAgICAg ICAgICAgICAgc2VydmVyLWNsaWVudHMpCisgICAgICAoeWVzLW9yLW5vLXAgIlRoaXMgRW1h Y3Mgc2Vzc2lvbiBoYXMgb3RoZXIgY2xpZW50czsgZXhpdCBhbnl3YXk/ICIpKQorICAgICA7 OyBJZiB0aGUgdXNlciBpcyBpbiBhIGNsaWVudCBmcmFtZSwgcHJvbXB0IGlmIHRoZXJlIGFy ZSBhbnkKKyAgICAgOzsgZnJhbWVzIGNyZWF0ZWQgYnkgdGhlIG1haW4gRW1hY3MgcHJvY2Vz cy4gIExpa2UgaW4gdGhlIGNhc2UKKyAgICAgOzsgYWJvdmUsIHRob3NlIGZyYW1lcyBtaWdo dCBiZSBvbiBkaWZmZXJlbnQgZGlzcGxheXMuCisgICAgICgoYW5kIChwcm9jZXNzcCB0aGlz LWNsaWVudCkKKyAgICAgICAgICAgOzsgRG9uJ3QgY291bnQgdGhlIGluaXRpYWwgZnJhbWUg d2hlbiBpbiBkYWVtb24gbW9kZS4KKyAgICAgICAgICAgKDwgKGlmIChkYWVtb25wKSAxIDAp CisgICAgICAgICAgICAgIChzZXEtY291bnQKKyAgICAgICAgICAgICAgIChsYW1iZGEgKGZy YW1lKQorICAgICAgICAgICAgICAgICAobm90IChwcm9jZXNzcCAoZnJhbWUtcGFyYW1ldGVy IGZyYW1lICdjbGllbnQpKSkpCisgICAgICAgICAgICAgICAoZnJhbWUtbGlzdCkpKSkKKyAg ICAgICh5ZXMtb3Itbm8tcCAiVGhpcyBFbWFjcyBzZXNzaW9uIGhhcyBub24tY2xpZW50IGZy YW1lczsgZXhpdCBhbnl3YXk/ICIpKQorICAgICA7OyBPdGhlcndpc2UsIHdlIGNhbiBraWxs IEVtYWNzIHdpdGhvdXQgcHJvbXB0aW5nLgorICAgICAodCB0KSkpKQogCiAoZGVmdW4gc2Vy dmVyLWtpbGwtYnVmZmVyICgpCiAgICJSZW1vdmUgdGhlIGN1cnJlbnQgYnVmZmVyIGZyb20g aXRzIGNsaWVudHMnIGJ1ZmZlciBsaXN0LgotLSAKMi4yNS4xCgo= --------------FT1ttZEE0UrVtkPsIua64HoQ-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 10 12:59:57 2022 Received: (at 58404) by debbugs.gnu.org; 10 Oct 2022 16:59:57 +0000 Received: from localhost ([127.0.0.1]:49718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohw8D-00029v-HJ for submit@debbugs.gnu.org; Mon, 10 Oct 2022 12:59:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohw8B-00029h-Pm for 58404@debbugs.gnu.org; Mon, 10 Oct 2022 12:59:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36102) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohw86-0008CO-H2; Mon, 10 Oct 2022 12:59:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=TR1l0fR1YaDLlP43V/wGsganVv5pIyaT0jlVMB22748=; b=lbijgySDNVhC oSew9W5Ni6y45hy+3xhhdrJPQL2bmfPTnGVfxaMK9cXNPnAbwDQG4Qh601hUpAJRd/x+TJ6IKmIIF XjSRimjU+JdbJq8HW6WOtxJCdzKVUp7rK4avXfmsGym32k/i5VKzxsCrGc+/NHUsvjUnozU28TcxF YkX+2L28rrH/x99cdTs43atCUzlNKsRkfZW+tiX58KZaWhNyxVAkkpEke63V5QcWFyjg5VIiyMZ/A 8rO8Y9SABqxTzxrl/b93BzSt9lNehVtqdHM2nJAS/+7wG3cb4Qd78eB+a68ajEUpoY8yMzA3lGMCl Y0NELyt9O283RHpRkPJrHQ==; Received: from [87.69.77.57] (port=2628 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohw85-0005mR-Up; Mon, 10 Oct 2022 12:59:50 -0400 Date: Mon, 10 Oct 2022 19:59:57 +0300 Message-Id: <834jwbhawi.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: (message from Jim Porter on Mon, 10 Oct 2022 09:43:55 -0700) Subject: Re: bug#58404: 29.0.50; [PATCH] When killing Emacs from the last client, don't warn about the session having clients References: <20194da7-2318-46db-7536-bbd9e3ddf945@gmail.com> <83k058i4y2.fsf@gnu.org> <02eb7516-bccc-16ab-84f2-4688849bfba8@gmail.com> <83tu4cgivn.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58404 Cc: 58404@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 10 Oct 2022 09:43:55 -0700 > Cc: 58404@debbugs.gnu.org > From: Jim Porter > > Here's why I think prompting then makes sense: when you're in an > emacsclient frame and there are other non-client frames (i.e. ones > "owned" by the main Emacs process), that looks very similar to the user > as when you have a second emacsclient running. No, there's a very fundamental difference between the two. When there are client frames showing buffers, for each client buffer there's a process waiting, the process which requested the buffer to be edited. That's why we prompt: we don't want to fail those waiting processes. Non-client frames don't have this problem. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 10 13:49:14 2022 Received: (at 58404) by debbugs.gnu.org; 10 Oct 2022 17:49:14 +0000 Received: from localhost ([127.0.0.1]:49829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohwtu-0001bm-DX for submit@debbugs.gnu.org; Mon, 10 Oct 2022 13:49:14 -0400 Received: from mail-pf1-f179.google.com ([209.85.210.179]:43853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohwtr-0001bW-PQ for 58404@debbugs.gnu.org; Mon, 10 Oct 2022 13:49:12 -0400 Received: by mail-pf1-f179.google.com with SMTP id 204so11349320pfx.10 for <58404@debbugs.gnu.org>; Mon, 10 Oct 2022 10:49:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=XPIqlRwlhP6HMyJh+aZ4+d6470cktzsD6/uhoGJUeuE=; b=A41sW3X2rjQPHGQiXTk0Eq54dIsxeOQZvY0xQRt39qYhSe6E1cmLQ4PLLAgprmCq4q gbhCSvkMBxWe+JwdUxz97CuWBadtzCF1eK4Z0LdKsINmI0ZckKBq4bg8+a3dmsy+0tdS 13T5i2cLVe1fkmh9KTECzTLgZe9liyPJVq6k1BAOlEjkAnAzyuF99+LiWMGjmK6epZ9n jEq2UKJXqywRxBrYFkDtHCCYxPYQSjeadYjQZcDcd9ZmTL6VIj+h+P6Qznd6/N/IfSM5 CRtxnFozKqCq8O8itNpd2AyiooiGSu4X4iteMf6LFBgF40g16t/hP4Ln8E8uk/kbtkup OS5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XPIqlRwlhP6HMyJh+aZ4+d6470cktzsD6/uhoGJUeuE=; b=r7dnstwJAbEJz7rPCGTz6o2Hh+zA6XLw/Sjo/IkcGPwp9Mb0pJ1Sw+omTTgn12qB/+ 69EjmIwoXc0WxF+0nQaAYSOCql6iPlrLaxhFW8QliCNa1+lhVczb/zwdY6a89UrkQMZn rSdepcvYpPq0/d/F3HnW3zfj1p/29MogJINCHf0OrSA7+Pi6CaeNrEj88Q/csyY+bmns e6eIZR/T2jO/bvucp68wnefM23h/2sRHLca0RAMwtG0Z+H0h/BHg/4dAFhHgn2Xhe9rk rafeX5DGRHf1bRqrTJDVLgMgULl6rjUJSfHPza8XJqinX6Xl0rWMQUkJLCBjD0n7uZ3M wkBw== X-Gm-Message-State: ACrzQf0SMMUYUPaLHxxUDm9YXdBNwnmSG/Hb3hX5SkJQbIltRe5W9Hbn Zw68rFLwTtCzCBIr7/H7e6Q= X-Google-Smtp-Source: AMsMyM5zavXYmn5tCVy0Z2Vux3RDiHWF/OXsukshcXcM1p/L2wTbxpCxxvC3EXUZQ9dDCbE/DJ4sfw== X-Received: by 2002:a05:6a00:1a44:b0:528:6af7:ff4a with SMTP id h4-20020a056a001a4400b005286af7ff4amr20756767pfv.78.1665424145766; Mon, 10 Oct 2022 10:49:05 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id o66-20020a17090a0a4800b002033b3875eesm6379203pjo.20.2022.10.10.10.49.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 10:49:04 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------UJ3uT9uQ4viKdlQzs6aUlZ0a" Message-ID: <53e0022a-ed95-cfad-fa09-a0d6bacdf86b@gmail.com> Date: Mon, 10 Oct 2022 10:49:05 -0700 MIME-Version: 1.0 Subject: Re: bug#58404: 29.0.50; [PATCH] When killing Emacs from the last client, don't warn about the session having clients Content-Language: en-US To: Eli Zaretskii References: <20194da7-2318-46db-7536-bbd9e3ddf945@gmail.com> <83k058i4y2.fsf@gnu.org> <02eb7516-bccc-16ab-84f2-4688849bfba8@gmail.com> <83tu4cgivn.fsf@gnu.org> <834jwbhawi.fsf@gnu.org> From: Jim Porter In-Reply-To: <834jwbhawi.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58404 Cc: 58404@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------UJ3uT9uQ4viKdlQzs6aUlZ0a Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/10/2022 9:59 AM, Eli Zaretskii wrote: >> Date: Mon, 10 Oct 2022 09:43:55 -0700 >> Cc: 58404@debbugs.gnu.org >> From: Jim Porter >> >> Here's why I think prompting then makes sense: when you're in an >> emacsclient frame and there are other non-client frames (i.e. ones >> "owned" by the main Emacs process), that looks very similar to the user >> as when you have a second emacsclient running. > > No, there's a very fundamental difference between the two. When there > are client frames showing buffers, for each client buffer there's a > process waiting, the process which requested the buffer to be edited. > That's why we prompt: we don't want to fail those waiting processes. > > Non-client frames don't have this problem. Ok, I think that makes sense. I was hesitant about removing prompts too aggressively, since I didn't want to open users up to losing some Emacs state without prompting when they would have gotten a prompt before. However, you've convinced me that we don't need to worry about non-client frames since they don't have processes waiting on them. (Maybe some users would want more prompts in case they accidentally kill Emacs, but they can always add to 'kill-emacs-query-functions'.) Attached is a new patch that removes the prompt when called from the last remaining client. I also expanded the docstring to explain why the prompt is there. --------------UJ3uT9uQ4viKdlQzs6aUlZ0a Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-prompt-when-killing-an-Emacs-client-if-it-s-th.patch" Content-Disposition: attachment; filename*0="0001-Don-t-prompt-when-killing-an-Emacs-client-if-it-s-th.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBlYTk1YjQwOWU4OWMxZDg3MDE2YTM2YTkyMDcwYTU5MmI4YjJlNGQwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgOSBPY3QgMjAyMiAxNTo1MzoyNyAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIERvbid0IHByb21wdCB3aGVuIGtpbGxpbmcgYW4gRW1hY3MgY2xpZW50IGlmIGl0J3Mg dGhlIGxhc3QKIGNsaWVudAoKKiBsaXNwL3NlcnZlci5lbCAoc2VydmVyLWtpbGwtZW1hY3Mt cXVlcnktZnVuY3Rpb24pOiBJZ25vcmUgdGhlCmN1cnJlbnQgY2xpZW50IChpZiBhbnkpIHdo ZW4gY2hlY2tpbmcgZm9yIGxpdmUgY2xpZW50cyAoYnVnIzU4NDA0KS4KLS0tCiBsaXNwL3Nl cnZlci5lbCB8IDE5ICsrKysrKysrKysrKy0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxMiBp bnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avc2VydmVy LmVsIGIvbGlzcC9zZXJ2ZXIuZWwKaW5kZXggM2NhYTMzNWM0ZS4uMTUxMTgwNjdlNSAxMDA2 NDQKLS0tIGEvbGlzcC9zZXJ2ZXIuZWwKKysrIGIvbGlzcC9zZXJ2ZXIuZWwKQEAgLTE1ODks MTQgKzE1ODksMTkgQEAgc2VydmVyLWRvbmUKICAgICAoc2VydmVyLWJ1ZmZlci1kb25lIChj dXJyZW50LWJ1ZmZlcikpKSkKIAogKGRlZnVuIHNlcnZlci1raWxsLWVtYWNzLXF1ZXJ5LWZ1 bmN0aW9uICgpCi0gICJBc2sgYmVmb3JlIGV4aXRpbmcgRW1hY3MgaWYgaXQgaGFzIGxpdmUg Y2xpZW50cy4KKyAgIkFzayBiZWZvcmUgZXhpdGluZyBFbWFjcyBpZiBpdCBoYXMgb3RoZXIg bGl2ZSBjbGllbnRzLgogQSBcImxpdmUgY2xpZW50XCIgaXMgYSBjbGllbnQgd2l0aCBhdCBs ZWFzdCBvbmUgbGl2ZSBidWZmZXIKLWFzc29jaWF0ZWQgd2l0aCBpdC4iCi0gIChvciAobm90 IChzZXEtc29tZSAobGFtYmRhIChwcm9jKQotICAgICAgICAgICAgICAgICAgICAgICAoc2Vx LXNvbWUgIydidWZmZXItbGl2ZS1wCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAocHJvY2Vzcy1nZXQgcHJvYyAnYnVmZmVycykpKQotICAgICAgICAgICAgICAgICAgICAg c2VydmVyLWNsaWVudHMpKQotICAgICAgKHllcy1vci1uby1wICJUaGlzIEVtYWNzIHNlc3Np b24gaGFzIGNsaWVudHM7IGV4aXQgYW55d2F5PyAiKSkpCithc3NvY2lhdGVkIHdpdGggaXQu ICBUaGVzZSBjbGllbnRzIHdlcmUgKHByb2JhYmx5KSBzdGFydGVkIGJ5CitleHRlcm5hbCBw cm9jZXNzZXMgdGhhdCBhcmUgd2FpdGluZyBmb3Igc29tZSBidWZmZXJzIHRvIGJlCitlZGl0 ZWQuICBJZiB0aGVyZSBhcmUgYW55IG90aGVyIGNsaWVudHMsIHdlIGRvbid0IHdhbnQgdG8g ZmFpbAordGhlaXIgd2FpdGluZyBwcm9jZXNzZXMsIHNvIGFzayB0aGUgdXNlciB0byBiZSBz dXJlLiIKKyAgKGxldCAoKHRoaXMtY2xpZW50IChmcmFtZS1wYXJhbWV0ZXIgbmlsICdjbGll bnQpKSkKKyAgICAob3IgKG5vdCAoc2VxLXNvbWUgKGxhbWJkYSAocHJvYykKKyAgICAgICAg ICAgICAgICAgICAgICAgICAodW5sZXNzIChlcSBwcm9jIHRoaXMtY2xpZW50KQorICAgICAg ICAgICAgICAgICAgICAgICAgICAgKHNlcS1zb21lICMnYnVmZmVyLWxpdmUtcAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChwcm9jZXNzLWdldCBwcm9jICdidWZm ZXJzKSkpKQorICAgICAgICAgICAgICAgICAgICAgICBzZXJ2ZXItY2xpZW50cykpCisgICAg ICAgICAgKHllcy1vci1uby1wICJUaGlzIEVtYWNzIHNlc3Npb24gaGFzIG90aGVyIGNsaWVu dHM7IGV4aXQgYW55d2F5PyAiKSkpKQogCiAoZGVmdW4gc2VydmVyLWtpbGwtYnVmZmVyICgp CiAgICJSZW1vdmUgdGhlIGN1cnJlbnQgYnVmZmVyIGZyb20gaXRzIGNsaWVudHMnIGJ1ZmZl ciBsaXN0LgotLSAKMi4yNS4xCgo= --------------UJ3uT9uQ4viKdlQzs6aUlZ0a-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 10 13:57:59 2022 Received: (at 58404) by debbugs.gnu.org; 10 Oct 2022 17:57:59 +0000 Received: from localhost ([127.0.0.1]:49843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohx2N-0001oZ-DU for submit@debbugs.gnu.org; Mon, 10 Oct 2022 13:57:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohx2L-0001oL-3n for 58404@debbugs.gnu.org; Mon, 10 Oct 2022 13:57:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40850) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohx2F-0004Le-T1; Mon, 10 Oct 2022 13:57:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vod5fpzPOXshW6Pu7uSL9+WoRKzwl0qQgOxLXUqL9XY=; b=LQbHGPR1z+u+ yON3wMLw7XU7LWnbb2d4OZ1ZYnTEbNWHDLXnOygbaSevR9sXbh7rCBmKAl/wBMyrAWVd6yaGi8DNZ uZKHY5wDXn7VBjaAA3pO1FUCw/y0P4y5jtpXZLqp1qJrs8hbB8kHcLn2bahgOBqxtTQplPdgM441J u0NyPgTtNLSmL6KV4OJm4oobeeupu/6vQkqAJbAmHQN86rJimy1nbKjY786mKDcv2m/HMBrW9X/qh pPy2ggPVNmwQgsBgBcoBHRMMEsGLQ+eN1vn+lpUpt02xmXRunUt7qwRHmda1Oq4RAccHXcdkP5Olf 3UBTpuEgQZ1bVq6Q9IFCcA==; Received: from [87.69.77.57] (port=2252 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohx2F-0003rM-Aq; Mon, 10 Oct 2022 13:57:51 -0400 Date: Mon, 10 Oct 2022 20:57:58 +0300 Message-Id: <8335bvh87t.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <53e0022a-ed95-cfad-fa09-a0d6bacdf86b@gmail.com> (message from Jim Porter on Mon, 10 Oct 2022 10:49:05 -0700) Subject: Re: bug#58404: 29.0.50; [PATCH] When killing Emacs from the last client, don't warn about the session having clients References: <20194da7-2318-46db-7536-bbd9e3ddf945@gmail.com> <83k058i4y2.fsf@gnu.org> <02eb7516-bccc-16ab-84f2-4688849bfba8@gmail.com> <83tu4cgivn.fsf@gnu.org> <834jwbhawi.fsf@gnu.org> <53e0022a-ed95-cfad-fa09-a0d6bacdf86b@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58404 Cc: 58404@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 10 Oct 2022 10:49:05 -0700 > Cc: 58404@debbugs.gnu.org > From: Jim Porter > > Attached is a new patch that removes the prompt when called from the > last remaining client. I also expanded the docstring to explain why the > prompt is there. LGTM, thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 10 19:09:22 2022 Received: (at 58404-done) by debbugs.gnu.org; 10 Oct 2022 23:09:22 +0000 Received: from localhost ([127.0.0.1]:50208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oi1ti-0003KK-GR for submit@debbugs.gnu.org; Mon, 10 Oct 2022 19:09:22 -0400 Received: from mail-pg1-f180.google.com ([209.85.215.180]:45601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oi1td-0003K3-65 for 58404-done@debbugs.gnu.org; Mon, 10 Oct 2022 19:09:21 -0400 Received: by mail-pg1-f180.google.com with SMTP id r18so11357532pgr.12 for <58404-done@debbugs.gnu.org>; Mon, 10 Oct 2022 16:09:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=wHRnb0ZVp8Siq2282Q4TIKThNY8V40Vof9OYZi9dlyQ=; b=nM4LprArEAhfGf9AxySM3dg20Jmrfk1PcEyFGNim01/FuRXJWsrPNbMnIs9pr0XD2b XKAic9hrFIwYEcmeBOmghBxGNz5gKjwJNuKv8ytqofJu3RXzUwXbHkVDa5lwu0OKJVRA 14ptCBD+8TX61sgAaXXB4irBKQedj2Cf+rX5ilMVYnFQHbdNXda8llPTBW/90m87ynrI 5tiMs/i43KmPb9ahck58THSyAbL1bEniaZVqwJmoldatQPSGE62pb1apFFxwZgbM/7jU SZmmpY6KGqvYHZ8FOZR2QcveoWyZfe8rzNvja8rEwByr2I5Gikpw5B7iB0OzYXfFdfLm aEMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wHRnb0ZVp8Siq2282Q4TIKThNY8V40Vof9OYZi9dlyQ=; b=Q6t9ss+5fLfD8qyrlkfKn9TWG09TlbsEZtcwI0+dJsKcob1VNYo4UI/GPrWcHa3J2F NDdAEU30zlWo088Gugm9YEoxKk4jw9JoN6XmNznqTy36ZALZ/KrpOQIBQX5CO+HKVmch rubrd1kVgz6VHpGLUDuS4HuyERQ0ptmL0ugNAlDTwPpy/Oa4rw0rIWOONeXpZPcJ5Hlv v4J/EUp4RyYdRVhXCVDCFyhpf9Mk1V7JsOTlaaeSvUEDf5wenLsZJh+Anps5oENTZXSy dkDpYV4FFrTAdTfggADT75zr7YVnoVuX2iCmWoM8acOzFjxVcQgJymZEBSwFA1Cif0gM qIlA== X-Gm-Message-State: ACrzQf05NE1nh4zARoAsM567808wP2NbN4o5rt263pd8OhwMiNrPwSTP Q0AZlz+qAhmaXKRj+QXNele12zZB04I= X-Google-Smtp-Source: AMsMyM6mnmi6AprXSx7MPTKqrkcMzWG2pTmjCZFJa2kor4pcxWkTCURNF6ibmjOXKJnTCpu9OuF6fQ== X-Received: by 2002:a05:6a00:218c:b0:561:bd69:dca6 with SMTP id h12-20020a056a00218c00b00561bd69dca6mr22310835pfi.83.1665443350062; Mon, 10 Oct 2022 16:09:10 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id i72-20020a639d4b000000b0044ed37dbca8sm6643424pgd.2.2022.10.10.16.09.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 16:09:09 -0700 (PDT) Message-ID: Date: Mon, 10 Oct 2022 16:09:08 -0700 MIME-Version: 1.0 Subject: Re: bug#58404: 29.0.50; [PATCH] When killing Emacs from the last client, don't warn about the session having clients Content-Language: en-US To: Eli Zaretskii References: <20194da7-2318-46db-7536-bbd9e3ddf945@gmail.com> <83k058i4y2.fsf@gnu.org> <02eb7516-bccc-16ab-84f2-4688849bfba8@gmail.com> <83tu4cgivn.fsf@gnu.org> <834jwbhawi.fsf@gnu.org> <53e0022a-ed95-cfad-fa09-a0d6bacdf86b@gmail.com> <8335bvh87t.fsf@gnu.org> From: Jim Porter In-Reply-To: <8335bvh87t.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58404-done Cc: 58404-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 10/10/2022 10:57 AM, Eli Zaretskii wrote: >> Date: Mon, 10 Oct 2022 10:49:05 -0700 >> Cc: 58404@debbugs.gnu.org >> From: Jim Porter >> >> Attached is a new patch that removes the prompt when called from the >> last remaining client. I also expanded the docstring to explain why the >> prompt is there. > > LGTM, thanks. Thanks, merged as ebc19f56aaeb98b834eea1ce8768ca13bed8578c. Closing this bug. From unknown Sun Jun 15 08:26:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 08 Nov 2022 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator