From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 09 12:56:35 2022 Received: (at submit) by debbugs.gnu.org; 9 Oct 2022 16:56:35 +0000 Received: from localhost ([127.0.0.1]:44852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohZbP-00044T-FU for submit@debbugs.gnu.org; Sun, 09 Oct 2022 12:56:35 -0400 Received: from lists.gnu.org ([209.51.188.17]:60696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohZbN-00044L-7O for submit@debbugs.gnu.org; Sun, 09 Oct 2022 12:56:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46088) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohZbN-0006d2-1D for guix-patches@gnu.org; Sun, 09 Oct 2022 12:56:33 -0400 Received: from knopi.disroot.org ([178.21.23.139]:55104) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohZbK-0007XI-TB for guix-patches@gnu.org; Sun, 09 Oct 2022 12:56:32 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 3BCD94C9DF; Sun, 9 Oct 2022 18:56:27 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id E14WS_bSqHCd; Sun, 9 Oct 2022 18:56:26 +0200 (CEST) From: "(" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1665334574; bh=LKq8ChA5N3BFo77WmJRyqSp1nI7Ws8IazFpuXKaXglg=; h=From:To:Cc:Subject:Date; b=fcN+1PU098R6Jmn/xInWbcyNN9GA3CnpF065o34tVKr9fVxnHAGJcOq0/MZP5N+j3 fN+6NGTzZOPdqOLqdyDTVC7WMOy9Q1baKjLblc4JYU3ctgJLmpia5arGRkJdehLKXZ C+SowpNxJEbn5/kfV5NhjqORMbAIo4rF8is3V7/+/Fe+Nb3T9vwzt5YoeBK0edgkG8 903H1RMBtSwtpRkYS9+kUx7Ji1F20c8eh4QDW2MoLqwspKFX46eEd/z43Y5F6brkJ/ FaAdFnNh9w7VwDQh4vwMo9s/jtUnO/tnKTuBU1CN95X4P3ERR02jjJYQmWjbFCZt1D NTewIZ/pVGfYw== To: guix-patches@gnu.org Subject: [PATCH 0/2] gnu: emacs-password-store: Refer directly to password-store. Date: Sun, 9 Oct 2022 17:56:08 +0100 Message-Id: <20221009165608.16412-1-paren@disroot.org> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=178.21.23.139; envelope-from=paren@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit Cc: "\(" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This patchset removes a propagated external command, which, as we all know, are malicious parasites that have no purpose in life but undermining the benefits of Guix. ( (2): gnu: emacs-password-store: Refer directly to password-store. gnu: emacs-ivy-pass: Don't propagate password-store. gnu/packages/emacs-xyz.scm | 64 +++++++++++++++++++++----------------- 1 file changed, 36 insertions(+), 28 deletions(-) -- 2.38.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 09 12:57:59 2022 Received: (at 58397) by debbugs.gnu.org; 9 Oct 2022 16:57:59 +0000 Received: from localhost ([127.0.0.1]:44873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohZck-00047x-T5 for submit@debbugs.gnu.org; Sun, 09 Oct 2022 12:57:59 -0400 Received: from knopi.disroot.org ([178.21.23.139]:45648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohZci-00047i-JH for 58397@debbugs.gnu.org; Sun, 09 Oct 2022 12:57:57 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 09C514C9FD; Sun, 9 Oct 2022 18:57:55 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KcAFw32_yZ4j; Sun, 9 Oct 2022 18:57:53 +0200 (CEST) From: "(" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1665334672; bh=B36rHmQO5mZNn9bErohSkifJ54c6SWTGI/vDEOBbNHk=; h=From:To:Cc:Subject:Date; b=HdjbxyVlfwa0vI2OevwzwjjFAVEDtXsC/ny2Ekd0nOzVV3lsexltei6p1tGStERTt iUM+CPNLy/M+mw09I+Fxy3vTkxRsFkIvuXJ4AeEx5uASNi7P0yquzcLJW0Lgq/70Xq QKk4pcii4txR0FjfOBEqrYafYR6R8iEQFi8+KmwS1boWDtldHPG/FxAoFpZLdRvo8J sFK5aNnd/8ZMud3Q4Xn9RRbmDndf0b9zchFuyji066piTb6J7fGP2cRkvL4Tkxhxtn kpzxZZswr+rcVEMQIawSRivkXIdTQWG4IEwmrG2Rk42pi1kpnN5Df5e7HoYeIPtRC8 7ssf3t/ZEI/Eg== To: 58397@debbugs.gnu.org Subject: [PATCH 1/2] gnu: emacs-password-store: Refer directly to password-store. Date: Sun, 9 Oct 2022 17:57:48 +0100 Message-Id: <20221009165749.16619-1-paren@disroot.org> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/emacs-xyz.scm (emacs-password-store)[arguments]: Use gexp style. <#:phases>{'extract-el-file}: New phase. [propagated-inputs]: Move it... [inputs]: ...here. --- gnu/pack [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 FROM_ONE_CHAR Bogus FROM name -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-Debbugs-Envelope-To: 58397 Cc: "\(" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) * gnu/packages/emacs-xyz.scm (emacs-password-store)[arguments]: Use gexp style. <#:phases>{'extract-el-file}: New phase. [propagated-inputs]: Move it... [inputs]: ...here. --- gnu/packages/emacs-xyz.scm | 35 ++++++++++++++++++++++------------- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 8134a19d56..6f415dc7b1 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -18918,24 +18918,33 @@ (define-public emacs-password-store (uri (git-reference (url "git://git.zx2c4.com/password-store") (commit commit))) + (file-name (git-file-name name version)) (sha256 (base32 - "0ni62f4pq96g0i0q66bch1dl9k4zqwhg7xaf746k3gbbqxcdh3vi")) - (file-name (git-file-name name version)))) + "0ni62f4pq96g0i0q66bch1dl9k4zqwhg7xaf746k3gbbqxcdh3vi")))) (build-system emacs-build-system) (arguments - `(#:phases - (modify-phases %standard-phases - (add-after 'unpack 'extract-el-file - (lambda _ - (copy-file "contrib/emacs/password-store.el" "password-store.el") - (delete-file-recursively "contrib") - (delete-file-recursively "man") - (delete-file-recursively "src") - (delete-file-recursively "tests")))))) + (list #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'extract-el-file + (lambda _ + (copy-file "contrib/emacs/password-store.el" + "password-store.el") + (delete-file-recursively "contrib") + (delete-file-recursively "man") + (delete-file-recursively "src") + (delete-file-recursively "tests"))) + (add-after 'extract-el-file 'patch-executables + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "password-store.el" + (("\\(executable-find \"pass\"\\)") + (string-append + "\"" + (search-input-file inputs "bin/pass") + "\"")))))))) + (inputs (list password-store)) (propagated-inputs - (list emacs-auth-source-pass emacs-s emacs-with-editor - password-store)) + (list emacs-auth-source-pass emacs-s emacs-with-editor)) (home-page "https://git.zx2c4.com/password-store/tree/contrib/emacs") (synopsis "Password store (pass) support for Emacs") (description -- 2.38.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 09 12:57:59 2022 Received: (at 58397) by debbugs.gnu.org; 9 Oct 2022 16:57:59 +0000 Received: from localhost ([127.0.0.1]:44875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohZcl-00047z-7g for submit@debbugs.gnu.org; Sun, 09 Oct 2022 12:57:59 -0400 Received: from knopi.disroot.org ([178.21.23.139]:45752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohZci-00047j-JJ for 58397@debbugs.gnu.org; Sun, 09 Oct 2022 12:57:57 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id A97FF4C8D7; Sun, 9 Oct 2022 18:57:55 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2zx1xNekVMzj; Sun, 9 Oct 2022 18:57:54 +0200 (CEST) From: "(" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1665334673; bh=77a7TKUofAtJ/sUPThU12mI19RNznlYaFxV2ZOSUyfw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=dfiH+wcCH0aZWhhbNsb/8kyGj/ZMxZV/yJ+EpA+WfH1CK+KOzBafAeOWvy2nGDZIG Oo8LCp5uSzpQs7Wu99LFTa2CDQxkbViL86WB6q9wEzWUpzUHI8yHIoJlTdwxtOXb2N R6wlzpLqsOv1qleb7yY2aOggUOQzQptPf2YRHyb6zSIH/G8aJ2lwVgAealPESL9X7X Mi/bfF1IE4JOFuRglNzNQIRgxI4cTJY4/jhLHqgM9GSLWlkrQE8N4KIaFLcJsZsYiK JQLy6RrK9+/U46ickbIoTPUfeLM0wKS08GvaoTvUas8KjiRCGCsnnzQOgAsQuoVXpy 5Hk1aBSRMKJdA== To: 58397@debbugs.gnu.org Subject: [PATCH 2/2] gnu: emacs-ivy-pass: Don't propagate password-store. Date: Sun, 9 Oct 2022 17:57:49 +0100 Message-Id: <20221009165749.16619-2-paren@disroot.org> In-Reply-To: <20221009165749.16619-1-paren@disroot.org> References: <20221009165749.16619-1-paren@disroot.org> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/emacs-xyz.scm (emacs-ivy-pass)[propagated-inputs] : Delete it. [synopsis, description]: Use @command when referring to pass. --- gnu/packages/emacs-xyz.scm | 29 ++++++++ [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 FROM_ONE_CHAR Bogus FROM name -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-Debbugs-Envelope-To: 58397 Cc: "\(" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) * gnu/packages/emacs-xyz.scm (emacs-ivy-pass)[propagated-inputs] : Delete it. [synopsis, description]: Use @command when referring to pass. --- gnu/packages/emacs-xyz.scm | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 6f415dc7b1..27494f2a37 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -10535,23 +10535,22 @@ (define-public emacs-ivy-pass (package (name "emacs-ivy-pass") (version (git-version "0.1" revision commit)) - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/ecraven/ivy-pass") - (commit commit))) - (file-name (git-file-name name version)) - (sha256 - (base32 - "18crb4zh2pjf0cmv3b913m9vfng27girjwfqc3mk7vqd1r5a49yk")))) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/ecraven/ivy-pass") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "18crb4zh2pjf0cmv3b913m9vfng27girjwfqc3mk7vqd1r5a49yk")))) (build-system emacs-build-system) - (propagated-inputs - (list emacs-ivy emacs-password-store password-store)) + (propagated-inputs (list emacs-ivy emacs-password-store)) (home-page "https://github.com/ecraven/ivy-pass") - (synopsis "Ivy interface for password store (pass)") - (description "This package provides an Ivy interface for working with -the password store @code{pass}.") + (synopsis "Ivy interface to @code{pass}") + (description + "This package provides an Ivy interface for working with the +password store (@command{pass}) in Emacs.") (license license:gpl3)))) (define-public emacs-ivy-yasnippet -- 2.38.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 10 12:12:24 2022 Received: (at submit) by debbugs.gnu.org; 10 Oct 2022 16:12:24 +0000 Received: from localhost ([127.0.0.1]:49632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohvOB-0000vb-Qa for submit@debbugs.gnu.org; Mon, 10 Oct 2022 12:12:24 -0400 Received: from lists.gnu.org ([209.51.188.17]:53914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohvO9-0000vH-Ct for submit@debbugs.gnu.org; Mon, 10 Oct 2022 12:12:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohvO9-0007uk-4a for guix-patches@gnu.org; Mon, 10 Oct 2022 12:12:21 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:57783) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohvO7-0006XN-5D for guix-patches@gnu.org; Mon, 10 Oct 2022 12:12:20 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 260A160013; Mon, 10 Oct 2022 16:12:13 +0000 (UTC) From: Nicolas Goaziou To: "( via Guix-patches" via Subject: Re: [bug#58397] [PATCH 1/2] gnu: emacs-password-store: Refer directly to password-store. References: <20221009165608.16412-1-paren@disroot.org> <20221009165749.16619-1-paren@disroot.org> Date: Mon, 10 Oct 2022 18:12:09 +0200 In-Reply-To: <20221009165749.16619-1-paren@disroot.org> (guix-patches@gnu.org's message of "Sun, 9 Oct 2022 17:57:48 +0100") Message-ID: <87czazvesm.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.195; envelope-from=mail@nicolasgoaziou.fr; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: "\(" , 58397-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, "( via Guix-patches" via writes: Thank you. Applied with the following change. > + (add-after 'extract-el-file 'patch-executables > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "password-store.el" > + (("\\(executable-find \"pass\"\\)") > + (string-append > + "\"" > + (search-input-file inputs "bin/pass") > + "\"")))))))) I used `emacs-substitute-variable' instead of substitute*. Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 10 12:26:31 2022 Received: (at submit) by debbugs.gnu.org; 10 Oct 2022 16:26:31 +0000 Received: from localhost ([127.0.0.1]:49672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohvbq-0001Ip-QG for submit@debbugs.gnu.org; Mon, 10 Oct 2022 12:26:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:38014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohvbp-0001Ih-1w for submit@debbugs.gnu.org; Mon, 10 Oct 2022 12:26:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohvbo-0004sM-S4 for guix-patches@gnu.org; Mon, 10 Oct 2022 12:26:28 -0400 Received: from knopi.disroot.org ([178.21.23.139]:50908) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohvbl-0000xq-Q6 for guix-patches@gnu.org; Mon, 10 Oct 2022 12:26:28 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 286F84C97D; Mon, 10 Oct 2022 18:26:23 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id lP8mqwLZtQPZ; Mon, 10 Oct 2022 18:26:22 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1665419022; bh=wVmotDeOFP/2yTT3oGrS5aNO1PcZUq4Lxqz2NPGG0t0=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Pu353L8RWyINCAMiWFdHV9khhTbyTw+b+hztpiUc1XeXlD5+Z6ZLL4E5+I9K4iLsB QRy1Fi+5SSV3cwGEOT0pKt2voboZ7c0vDNS97Wq7i7CvRhcg6XjBmpouguH5F886rF 4Hi2JE+dJ5Q1vkKistrShMQZz0uTZfUPqjgJIF/90rEsnPCbNXIETff8GSY2U437eZ seVRUWeCmRgiUNzPZCA+t1zhU8ux4VwNcxa9Ul4j99LDzcK36iNcDa4FzB2w+7rfVK qwdD8ZSnoEo6WywzNRM+h2nWiHqCcDPUHm32hQMUeMB1PEJCgKuoskOjsNAn6OCD6/ mpQLXsFXijDNQ== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 10 Oct 2022 17:23:41 +0100 Message-Id: From: "(" To: "Nicolas Goaziou" , "( via Guix-patches via" Subject: Re: [bug#58397] [PATCH 1/2] gnu: emacs-password-store: Refer directly to password-store. References: <20221009165608.16412-1-paren@disroot.org> <20221009165749.16619-1-paren@disroot.org> <87czazvesm.fsf@nicolasgoaziou.fr> In-Reply-To: <87czazvesm.fsf@nicolasgoaziou.fr> Received-SPF: pass client-ip=178.21.23.139; envelope-from=paren@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit Cc: 58397-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hey Nicolas, On Mon Oct 10, 2022 at 5:12 PM BST, Nicolas Goaziou wrote: > Thank you. Applied with the following change. Thanks! :) > I used `emacs-substitute-variable' instead of substitute*. Ah, I didn't know that existed; thanks! I've never touched Emacs packaging before. -- ( From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 10 12:27:37 2022 Received: (at submit) by debbugs.gnu.org; 10 Oct 2022 16:27:37 +0000 Received: from localhost ([127.0.0.1]:49680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohvcv-0001Kv-G9 for submit@debbugs.gnu.org; Mon, 10 Oct 2022 12:27:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:42398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohvct-0001Kn-UZ for submit@debbugs.gnu.org; Mon, 10 Oct 2022 12:27:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohvct-0005yX-04 for guix-patches@gnu.org; Mon, 10 Oct 2022 12:27:35 -0400 Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]:47935) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohvcd-00014Q-Pu for guix-patches@gnu.org; Mon, 10 Oct 2022 12:27:32 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 16297240011; Mon, 10 Oct 2022 16:27:13 +0000 (UTC) From: Nicolas Goaziou To: "( via Guix-patches" via Subject: Re: [bug#58397] [PATCH 2/2] gnu: emacs-ivy-pass: Don't propagate password-store. References: <20221009165749.16619-1-paren@disroot.org> <20221009165749.16619-2-paren@disroot.org> Date: Mon, 10 Oct 2022 18:27:09 +0200 In-Reply-To: <20221009165749.16619-2-paren@disroot.org> (guix-patches@gnu.org's message of "Sun, 9 Oct 2022 17:57:49 +0100") Message-ID: <878rlnve3m.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:4b98:dc4:8::221; envelope-from=mail@nicolasgoaziou.fr; helo=relay1-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: "\(" , 58397-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, "( via Guix-patches" via writes: > * gnu/packages/emacs-xyz.scm (emacs-ivy-pass)[propagated-inputs] > : Delete it. > [synopsis, description]: Use @command when referring to pass. Thank you. Applied with the following changes. > - (source > - (origin > - (method git-fetch) > - (uri (git-reference > - (url "https://github.com/ecraven/ivy-pass") > - (commit commit))) > - (file-name (git-file-name name version)) > - (sha256 > - (base32 > - "18crb4zh2pjf0cmv3b913m9vfng27girjwfqc3mk7vqd1r5a49yk")))) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/ecraven/ivy-pass") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "18crb4zh2pjf0cmv3b913m9vfng27girjwfqc3mk7vqd1r5a49yk")))) This change is not warranted, so I removed it. > (build-system emacs-build-system) > - (propagated-inputs > - (list emacs-ivy emacs-password-store password-store)) > + (propagated-inputs (list emacs-ivy emacs-password-store)) I think the newline removal isn't either. > (home-page "https://github.com/ecraven/ivy-pass") > - (synopsis "Ivy interface for password store (pass)") > - (description "This package provides an Ivy interface for working with > -the password store @code{pass}.") > + (synopsis "Ivy interface to @code{pass}") > + (description > + "This package provides an Ivy interface for working with the > +password store (@command{pass}) in Emacs.") I used @code here too, since you're probably referring to the project's name. Regards, -- Nicolas Goaziou From unknown Fri Aug 15 17:23:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 08 Nov 2022 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator