GNU bug report logs - #58384
copy-build-system assumes that strip-flags, strip-directories is a S-exp, but it isn't.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#58384: closed (copy-build-system assumes that strip-flags,
 strip-directories is a S-exp, but it isn't.)
Date: Sun, 09 Oct 2022 16:55:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 09 Oct 2022 18:54:30 +0200
with message-id <87fsfx5455.fsf_-_ <at> gnu.org>
and subject line Re: bug#58384: copy-build-system assumes that strip-flags, strip-directories is a S-exp, but it isn't.
has caused the debbugs.gnu.org bug report #58384,
regarding copy-build-system assumes that strip-flags, strip-directories is a S-exp, but it isn't.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
58384: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58384
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Maxime Devos <maximedevos <at> telenet.be>
To: bug-guix <at> gnu.org
Subject: copy-build-system assumes that strip-flags, strip-directories is a
 S-exp, but it isn't.
Date: Sat, 8 Oct 2022 20:52:04 +0200

[Message part 3 (text/plain, inline)]

Hi,

In commit 
https://git.savannah.gnu.org/cgit/guix.git/commit/?h=core-updates&id=ccc2658e2a111590ec25e308946e47a24d357785, 
the default 'strip-flags' and 'strip-directories' argument were changed 
from a S-exp to %strip-flags and %strip-directories from (guix 
build-system gnu).

This is fine, except for copy-build doing (sexp->gexp ...) on those, 
even though %strip-flags etc. are G-exps, not S-exps, causing errors like

> ice-9/read.scm:126:4: In procedure read-expr*:
> /gnu/store/abb0wz0223bjsxkw9av768szz955m2xh-openjpeg-data-2021.09.26-builder:1:2504: Unknown # object: "#<"
> builder for `/gnu/store/qbc93ywsbm3bwwiqn7h8fv124i1yqh53-openjpeg-data-2021.09.26.drv' failed with exit code 1
> derivation '/gnu/store/qbc93ywsbm3bwwiqn7h8fv124i1yqh53-openjpeg-data-2021.09.26.drv' offloaded to '141.80.167.174' failed: build of `/gnu/store/qbc93ywsbm3bwwiqn7h8fv124i1yqh53-openjpeg-data-2021.09.26.drv' failed


Changing '(sexp->gexp strip-flags)' to 'strip-flags' and likewise for 
'strip-directories' should fix things (unverified).

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 58384-done <at> debbugs.gnu.org
Subject: Re: bug#58384: copy-build-system assumes that strip-flags,
 strip-directories is a S-exp, but it isn't.
Date: Sun, 09 Oct 2022 18:54:30 +0200

Hi,

Maxime Devos <maximedevos <at> telenet.be> skribis:

> This fixes a bug introduced in ccc2658e2a111590ec25e308946e47a24d357785,
> reported at <https://issues.guix.gnu.org/issue/58384>.
>
> Tested with "./pre-inst-env guix build openjpeg-data".
>
> Fixes: https://issues.guix.gnu.org/issue/58384
>
> * guix/build-system/copy.scm (copy-build): 'strip-flags' and
> '#:strip-directories' are G-exps, not S-exps, so don't use sexp->gexp.
> * guix/build-system/cmake.scm (copy-build): Likewise.
> * guix/build-system/glib-or-gtk.scm
> (glib-or-gtk-build,glib-or-gtk-cross-build): Likewise.
> * guix/build-system/maven.scm (maven-build): Likewise.
> * guix/build-system/meson.scm
> (meson-build,meson-cross-build): Likewise.

Oops.  Applied, thanks for the quick fix!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.