GNU bug report logs - #58383
29.0.50; Make it easier to invert vc-prepare-patches-separately

Previous Next

Full log

Message #70 received at 58383 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 58383 <at> debbugs.gnu.org, spwhitton <at> spwhitton.name
Subject: Re: bug#58383: 29.0.50; Make it easier to invert
 vc-prepare-patches-separately
Date: Sun, 13 Nov 2022 18:52:11 +0200

> From: Philip Kaludercic <philipk <at> posteo.net>
> Cc: spwhitton <at> spwhitton.name,  58383 <at> debbugs.gnu.org
> Date: Sun, 13 Nov 2022 16:45:26 +0000
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Can we take this opportunity to get rid of the passive voice and
> > clarify the doc string, please?
> 
> Done:

Thanks, and the same with package-vc-prepare-patch, please?

Btw, this kind of reformatting:

> -SUBJECT and REVISIONS are passed on to `vc-prepare-patch', which see.
> -PKG must be a package description.
> -Interactively, prompt for PKG, SUBJECT, and REVISIONS.  However,
> -if the current buffer has marked commit log entries, REVISIONS
> -are the tags of the marked entries, see `log-view-get-marked'."
> +SUBJECT and REVISIONS are passed on to `vc-prepare-patch', which
> +see.  PKG must be a package description.  Interactively, prompt
> +for PKG, SUBJECT, and REVISIONS.  When invoked with a numerical
> +prefix argument, the last N revisions will be used.  When invoked
> +interactively in a Log View buffer with marked revisions, those
> +revisions will be used."

is IMO for the worse: when the sentence starting with "Interactively"
begins a new line, it stands out, which helps users find the most
relevant parts faster.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.