From unknown Wed Jun 18 23:18:20 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#58383 <58383@debbugs.gnu.org> To: bug#58383 <58383@debbugs.gnu.org> Subject: Status: 29.0.50; Make it easier to invert vc-prepare-patches-separately Reply-To: bug#58383 <58383@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:18:20 +0000 retitle 58383 29.0.50; Make it easier to invert vc-prepare-patches-separate= ly reassign 58383 emacs submitter 58383 Sean Whitton severity 58383 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 08 13:49:38 2022 Received: (at submit) by debbugs.gnu.org; 8 Oct 2022 17:49:38 +0000 Received: from localhost ([127.0.0.1]:41406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohDxC-000429-6N for submit@debbugs.gnu.org; Sat, 08 Oct 2022 13:49:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:44438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohDxB-000422-5o for submit@debbugs.gnu.org; Sat, 08 Oct 2022 13:49:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohDxA-00034a-Ps for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2022 13:49:37 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:53489) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohDx7-0001FC-3p for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2022 13:49:36 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 63A235C00D2 for ; Sat, 8 Oct 2022 13:49:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 08 Oct 2022 13:49:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t= 1665251372; x=1665337772; bh=QNuImbjBN1a/ipNLjeqnSZnEJEUvxuJ+Fr4 tF66EkUE=; b=m2ORF8YQs4XN4J0XSfWksdj/m4jmHpAaUk83dNk2bYc4oeHlGbI d7isBTv+7Nkh4JzbyrWcLvdjEF0CDipx77IK/MYYMsYQLDyaf3DE0O8xyjzI8gk3 vrtZNZXDGBh1kbFYo9g3WeuZKuBy2JCESSfpf+rINsSAdCBnYH69ltgxkJxaoL2U EVT9TPl1y0rf82n0VRRzkJ4raN0xNSlH5RifjBEP2x7VsiTDkjD1eLZvypz/5OV7 rWNbzc0mVrX5jdDoDinVxJh3YtOY6pd25t3PrpNd0WVlNJbWGFDGqCaEXzupkMAE MiTV2DBlKzH1kN5ZVSwPfJhkdl0J9zRyktg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665251372; x= 1665337772; bh=QNuImbjBN1a/ipNLjeqnSZnEJEUvxuJ+Fr4tF66EkUE=; b=h VDgx/Ycrqs4i1miWOW1U+ZCSS9iB2SSWZoIOjNE6aL1k4t16rUfNICt7tWE4w8sU /+nuwObm2f5x8jHM+VChVef6wcLU7UCgzOONIPTZc6nEYa3e460mgFySHsRKic3H fxnX5ezTkk9RuZxGrXcD2iB6yDv6ISTv11x9jmMXBwQ0ekrW+kxJwBOEbQiHD4D5 WzXuStxvyt6C1BFPIgh6skh/0lSXlHjM4pRqzGpxHE/jVsfLb/gDuJdGc+YrUF1W Zkhb5h6fnqI8ox0a8MMwaAMEBQ+LcOcI3u6jQ+kVLG6qkvV+FMw1YrkhTU7pJB1u EBUqti4i4HPW1TtLtr9Fg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeiledgudduhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgfgggtsehttddttd dtredtnecuhfhrohhmpefuvggrnhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehs phifhhhithhtohhnrdhnrghmvgeqnecuggftrfgrthhtvghrnhepfffgheeggffgheeuvd ethfekuddtgffgtdeukeegkedttefftdeghfdvgfdtjeelnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhih htthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Sat, 8 Oct 2022 13:49:31 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id B38BF7F3E1F; Sat, 8 Oct 2022 10:49:29 -0700 (MST) From: Sean Whitton To: bug-gnu-emacs@gnu.org Subject: 29.0.50; Make it easier to invert vc-prepare-patches-separately Date: Sat, 08 Oct 2022 10:49:29 -0700 Message-ID: <87mta6b3yu.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=66.111.4.27; envelope-from=spwhitton@spwhitton.name; helo=out3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, How about a prefix argument to vc-prepare-patch to invert one's usual setting for vc-prepare-patches-separately? Most people who contribute to more than one project regularly will want to use both. On the other hand, having a numeric prefix argument mean "send patches correspoding to the top N revisions of the current branch" would be very convenient. Perhaps these two could be combined by using a negative number to mean also invert? -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 09 08:55:05 2022 Received: (at 58383) by debbugs.gnu.org; 9 Oct 2022 12:55:05 +0000 Received: from localhost ([127.0.0.1]:42308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohVph-0003lp-9F for submit@debbugs.gnu.org; Sun, 09 Oct 2022 08:55:05 -0400 Received: from mout02.posteo.de ([185.67.36.66]:52119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohVpb-0003lG-NS for 58383@debbugs.gnu.org; Sun, 09 Oct 2022 08:55:03 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id AAB42240101 for <58383@debbugs.gnu.org>; Sun, 9 Oct 2022 14:54:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665320093; bh=ICWqNQEWqsuSGPmuK7zrAOVVeLbC0wuSy66smNENqf0=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=GBxObUeDtTELgk06aiyoDxV46MahYJ1CTicLHKdZhnZVnWZrYj0K/s3ulUpa9wugk m5gk8Kaxgnol0nnc4r4GToIrF/8Sj2/KdiTXetuYv1HA6YI7KqpHXORLjagBvbHlSC 6JBNGOAGh8+pbh87pfV6nf2D1atHMrB+dag6rSP9T870g6dBe57EWdF3xvrdiBgfeC FLq9nct1+ffoIUlAClohp4EgJbGZ0doL2+QdXr5q0nw/pV1PKShteJYDPls+pIc8Rk YxIAwgu4zjsAWs/QGCXK8gFkI+RBsck61wSaX+2DKjZEV+6GJ3Hnyg1YPG2kuEeC0i DrR+GbYaCnnQg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MlhpN5TKnz6tpH; Sun, 9 Oct 2022 14:54:51 +0200 (CEST) From: Philip Kaludercic To: Sean Whitton Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <87mta6b3yu.fsf@melete.silentflame.com> (Sean Whitton's message of "Sat, 08 Oct 2022 10:49:29 -0700") References: <87mta6b3yu.fsf@melete.silentflame.com> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Sun, 09 Oct 2022 12:54:51 +0000 Message-ID: <87edvh2m3o.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Sean Whitton writes: > Hello, > > How about a prefix argument to vc-prepare-patch to invert one's usual > setting for vc-prepare-patches-separately? Most people who contribute > to more than one project regularly will want to use both. How would this be preferable to setting `vc-prepare-patches-separately' as a directory local variable? That way you don't have to remember to use a prefix argument whenever invoking `vc-prepare-patch'. > On the other hand, having a numeric prefix argument mean "send patches > correspoding to the top N revisions of the current branch" would be very > convenient. Perhaps these two could be combined by using a negative > number to mean also invert? This is the usual problem with numeric prefix arguments. You don't get that much expressivity with just an integer. That is why I would hesitate to assign any particular interpretation to prefix arguments, before considering and weighing the options. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 13 09:48:31 2022 Received: (at control) by debbugs.gnu.org; 13 Oct 2022 13:48:32 +0000 Received: from localhost ([127.0.0.1]:60116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiyZb-0005Ms-N2 for submit@debbugs.gnu.org; Thu, 13 Oct 2022 09:48:31 -0400 Received: from mail-oi1-f169.google.com ([209.85.167.169]:40929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiyZX-0005Ln-63 for control@debbugs.gnu.org; Thu, 13 Oct 2022 09:48:27 -0400 Received: by mail-oi1-f169.google.com with SMTP id l5so1763644oif.7 for ; Thu, 13 Oct 2022 06:48:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=K5ajZ+ikblRRDOi7MhFToVN/ntawFY7D5SGREEEdJNU=; b=eZqK23JRksAloCmBIDL2qDFoHkMrWapeGf2YQ+yqo3kn/F6Vjf3RGLSJ5G9GZ+ZsH+ 9MC5D/936jyKK8zz8pMpUgqYz1WCUv9NZutvCDM2mckdxsx66PBy2VKHBGD7bNgW2WxA lqF7ZW+FVOAHAhyWzP/jPJ8ZhvMhCRdAuQZAab5GK+5NYDJDmcLOXWBbQ5n+jYJEtuHa 2UzsRo9W21gnYcNjC3Ap0kDATDCOWM+VCEmNAHTkwE3+TzLD00Kp/fTob0JHC89li3tW K8IfhQsw5ji6tnq0z2uB5aABDmyt3bmaHpd7kpjm0oMt2nL65goCuo1aH+1pkgJvbYns E6iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=K5ajZ+ikblRRDOi7MhFToVN/ntawFY7D5SGREEEdJNU=; b=T617mJDIszppDZkQbMgdHJjyjLrtGpOLTvrtStlue6QlM2bKB6RkwNgO0dCkh/GqJx QtcM7VPnTm5yOIfFNH+1vRAqexx8LYg9YCSTcevKtzuRvcOk/dQ1jeqJ5pDWXjo/JSAS 2XJXhc+zv0J+5agkL/6bX66ROTH6XQCCg6aqFZ/1NVgJOA/OKvOGKvgjCrz06NfOqFQz KxPc0V7tmc/NEneQTh+gM2IB6xrt1U30uxc3lGm9ERPwi6ufDIZdBeH/aZqW8qD3gWKo HrW1wqBAWgO7Gf4pdNf44qTCfHU5g5Vaq0ngJcAvDX2Ywbtg/7NznSbiYfWq26XvRA8b 6IDw== X-Gm-Message-State: ACrzQf3d5iVcqrU85gu0aeYqC/84fgYoBhsW7tNudLH0KfUYRur3ebPd OBh8LpxYHzcWtypdHMWWzjGeTKrNIA6c9j4ZW0ivo3AR X-Google-Smtp-Source: AMsMyM7KqfnEFsygKUrSkXE5INXdhiC5Lvxjok+P0D05c8ynFv/4HXOHKdGIDMAvqSXg/TcAnJ0y9D7i3mBU+9R6AkE= X-Received: by 2002:a05:6808:d51:b0:354:fecd:6d11 with SMTP id w17-20020a0568080d5100b00354fecd6d11mr1467626oik.92.1665668901827; Thu, 13 Oct 2022 06:48:21 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Oct 2022 15:48:21 +0200 From: Stefan Kangas X-Hashcash: 1:20:221013:control@debbugs.gnu.org::IVvJBq0Ts2AE5Of1:1vBf MIME-Version: 1.0 Date: Thu, 13 Oct 2022 15:48:21 +0200 Message-ID: Subject: control message for bug #58383 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 58383 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 04 18:21:34 2022 Received: (at 58383) by debbugs.gnu.org; 4 Nov 2022 22:21:34 +0000 Received: from localhost ([127.0.0.1]:54979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1or549-0008S3-T8 for submit@debbugs.gnu.org; Fri, 04 Nov 2022 18:21:34 -0400 Received: from mout02.posteo.de ([185.67.36.66]:40295) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1or547-0008Rp-MU for 58383@debbugs.gnu.org; Fri, 04 Nov 2022 18:21:32 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id BF9E0240101 for <58383@debbugs.gnu.org>; Fri, 4 Nov 2022 23:21:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667600485; bh=pzP+erNwoEt7vyioTKzsPqxjRr4/LRqW2GFPryjxCD4=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=EWhF7I1b3cAxlaN1TDaUPz5F6B7bnQLzk+oMCO+3Fk5QagxqQF9s69qfV+TGmwyEV iUcLad+ashqvUuqTvaTfNs9SWLIPU2h4hZUYSMEM2/kmaH+8Fpt/5loRfb0zyQm/9q NqhcDV1AG7omRQr6TLYcSrnp/+ac64srAIVpJMDnM3EyycT3PX6VieR1dAgzee2tyz OhYmbA4wAhJqbOZzJhcZ+sgP2zyCb+U71FLbkaiOFQNTbfGseT4Qvt9m2C2mJ7mY22 oIPBR9opHcjtRXDvlIwnIhOF8ZNSprzi2vtmLHUiUFxUTEyXRx5QuYEBmAzFXezgTS KifJFKcIMZPXg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N3w850qfGz6tnW; Fri, 4 Nov 2022 23:21:22 +0100 (CET) From: Philip Kaludercic To: Sean Whitton Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <87edvh2m3o.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 09 Oct 2022 12:54:51 +0000") References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> Autocrypt: addr=philipk@posteo.net; keydata= mQGNBGLfygUBDADVznbke6w0n9nE42xb+ZggbBy0IYRkkru/K+NA67523YTl2DoR2a5OMW90w7L9 KDtX2Mp34JN/6jVOSVC07VUbHVu6/exoGKixkiTpGhBPy5tUUJoxQKqLrzVQhN3fIyvg1oyHXKZm QGkUeevV0wjj4++xfjmcP235YvDh3TF8HC9t5KxIQIbhWnQm4ZyDkpWWS2CmdNttlj2+eH+51WLL bgx2bcwTmqrs079Q3hgF3yh44bBEmp9MgFjiZldOY2my0/ZSeucRxYmiM0vbJEBQgZV/MvA3gTxe 7ibV3ii7AyoYA8FiFDP98S/R2y5Nfq3ez9B7qeqtpSNseQHOU7h8Y5VV01a71ZszENAmbbwsldb9 j+HRLke7rn6mswDZl1qA/9ZFRzliFOdQtS1878XjraY+h5jfjvxaFVK23prGGVrrKv0LPWavoFUr nsjeHEZhYezBKhC2PwvRtXm01S3rkNbwm9pj0tfLSDW+1pT+6eZWptfQCXF2oEvgfKSTASUAEQEA AbQmUGhpbGlwIEthbHVkZXJjaWMgPHBoaWxpcGtAcG9zdGVvLm5ldD6JAdQEEwEKAD4WIQRxJuHe LwzjXHcL7QHyw8xRPbifZgUCYt/KBQIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAK CRDyw8xRPbifZkH+DACmCKmhrYgcv2i6dj3vRCVINaLtKUODTna/wAmP20WRKPhqvqvKNUx/wzpT aZrXIxpxOU2xawRWeHhWUktxS+W9L3xTACeR0gf5gomCxD9RuBTIohzWDkQt5rk8QwLqx5rAy5zo feXujnDCXkZtodo1m54cY2kUFF/WIYRrciL/EBzpcizybMJFwx4HxSBlGRkdwnSH9Dzo+4U+8ctB xDfTvQ7cK/0+Qz/TvKjUK8LXLN1/rJTmqpRDv+Odx9LaxutGGoXeLwmhhgpRhvUS8EsqHGF37Zxe AV/ybdVU4NHXVecZAhSgOXX4EHDa7NjhTihx9Id478aQycOKf3CiI6Z8AgcR/iKE4bD4osh2cqQB +JIBtktImxJ1vFsehdQVjdLPWqlr/1weMHM4xH/4VtCLOl5mO3K+fUWxQ/DGLXeQVZ+hilITSKMl YVH/7he26WGd9FRJR25t9uTSgL2YIG8xYppKXueyK/5zjHq05UZRFKiFuPTE4Daoemqx86vYlui5 AY0EYt/KBQEMANvhe1fPQ3BHBcE2GfdX9kVXV0uAP+2Be2DxKWPJI1SqZbrS4wSUsDdd2+2m4YMX E3d+K9Z6IqBcr5gMFSN9QKGEo91FYYgnqvtnd6n9sEAScfNri2GVJzlmXAtEAWeVlv83cu0v0Gsw rSKkxZfMxt+EodtN0aswf5SAy77t28NZUw4fk/0o0AlIMjByVcDkipn7N02gLHjYsvMGFFtM3Zqg Fps8ix3XytSg3Pf8hIVhXFGkBs/iN6dGeIs8wVWBsB7azdqE84uUSRAcS4ymqUE6KxsbNo4x8RAx 9Pt2fcL5bWURAZB+83dk8NVmoQdtY+d4JUV9RAKM/Qg/qtE0fVxcZnj8YmxB1NzLf0UxgHuGYtaq HWrB80CROxMzK7fH8yDRnQKHT2gJYMMQjzMwakSSk8bNJDGBTvAbnxSbYMUC3FR4Pz3pSAbsaSz6 LY0QHDRlroBpyJHatrtKh9Uf9nV0wPIKgZfaH2mhiU17/N6wx0W12cBhrTDRoSnTYIgvQQARAQAB iQG8BBgBCgAmFiEEcSbh3i8M41x3C+0B8sPMUT24n2YFAmLfygUCGwwFCQPCZwAACgkQ8sPMUT24 n2b4ogv/Z5HKvWT2hB238G0ZrUxBptNdQHSG3VwfghN30KH7AEW8ZxsDn3zckn/jXxob4VyhUC8d zZdBQstsNgl+NZ7S2JYRUEsIpoRiHnQFJnfPpt6YZMVNYHJkuh7zRIQGji4OoS8j9QdUHsJnQDia xElXx2vwcBTRZBybcNC+3scGgFBzAcrI4AhYjKZBj5lvKMTrWhK+o4bVdFaYTJDIq37MM3IQLzFF oPIB1C525V916wVYSVl7+RQ1T/mf9oX9kZcYVTC0g4KBEEDI4SGK0i5sKDLfBp4c91AFlUo/J8nC hUMWblnpfCC7epUEbrms0ZQE7RFLgy7YCLZ9Fx2JfV6gx9n9vH7kI605uLnTHgkw3uED/CKfVlbW v0Yrtvi0rUMunLnlySIpXItkSIK+PCqTMdLJ3rBe0ALPgbKN6Lu+yxfe0eaAmFbrNZFI0xp40403 gDwhwoq742fLwbxPSldSeb8A93KRg/8e92CMwKVYtxoADeoksMq10iid4POQl2vw Date: Fri, 04 Nov 2022 22:21:22 +0000 Message-ID: <87k04al5st.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philip Kaludercic writes: > Sean Whitton writes: > >> Hello, >> >> How about a prefix argument to vc-prepare-patch to invert one's usual >> setting for vc-prepare-patches-separately? Most people who contribute >> to more than one project regularly will want to use both. > > How would this be preferable to setting `vc-prepare-patches-separately' > as a directory local variable? That way you don't have to remember to > use a prefix argument whenever invoking `vc-prepare-patch'. > >> On the other hand, having a numeric prefix argument mean "send patches >> correspoding to the top N revisions of the current branch" would be very >> convenient. Perhaps these two could be combined by using a negative >> number to mean also invert? > > This is the usual problem with numeric prefix arguments. You don't get > that much expressivity with just an integer. > > That is why I would hesitate to assign any particular interpretation to > prefix arguments, before considering and weighing the options. Ping? From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 06 16:44:22 2022 Received: (at 58383) by debbugs.gnu.org; 6 Nov 2022 21:44:22 +0000 Received: from localhost ([127.0.0.1]:60830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ornRG-0002gA-Cx for submit@debbugs.gnu.org; Sun, 06 Nov 2022 16:44:22 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:53201) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ornRB-0002fs-HP for 58383@debbugs.gnu.org; Sun, 06 Nov 2022 16:44:21 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 69C475C007D; Sun, 6 Nov 2022 16:44:10 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 06 Nov 2022 16:44:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1667771050; x=1667857450; bh=UF 51zUN4smJdc5w0NYCzKR2gSuaYCSvseExVOi5enZU=; b=G7r0RLF6OzbB/Vm040 2zVP9uqFCFvSJMWrWpsnfU1xqGSxpDzr9R6ALz16mj8+s9beQiqnxLQ52F0pyIo9 ND9qmB5JEhfE8tB3EE6p733WEpjBe1COfA5j4cI84VYr6hHheZz+l9nF912X5Vby GjCs4vyKVDDEJet8QroYYTlzfQrg7XqI7BUJ//yGVIdl/I2NGSni8QYlC9ZwmRUy Bi88gko561pEJKMR3+wtiUpuu0psYpCePYfqqdDPTh156WY9mL5LPesnezvb+GFL RBmJOLwIPK4wSPiybnGMijabofCxhkFpgS48lGSDT7S/lGo4E55YD/sN5Fk3wizL AwuA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1667771050; x=1667857450; bh=UF51zUN4smJdc5w0NYCzKR2gSuaY CSvseExVOi5enZU=; b=cx6ouK4wMa/bHkRzfIPPwkMKWpvYG//pD3eIGikkUY0B pE7iVCSth5wPtA9SiS4q8u321+e8r4OLX5Dc8RYDlIUDMlSKVcdLz0l+A0JqwqUV 0RrWJTU5xLP1FqZtcWA6AXKPdzNx4CUWTHxnloMHHvsQfYMGesVJodQO7uLeyZy0 hJFBGV7nAamEPNPAYlm+WO8uxKNG4zdiG2fZwJfAm1xrv8U5F5iTiUAYGZmbophe 10Ys5uUbi1jIYuUl0v16W3yBBSplhlZF0Pqmq+msRB8zdjs9jT7xZC4aFpjqiQu0 /2BL/3WA6PSSA8iHM+F86dL8Dqbt4VTLtHUpSN338Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrvdeigddugeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 6 Nov 2022 16:44:10 -0500 (EST) Received: by melete.silentflame.com (Postfix, from userid 1000) id 065E47E442B; Sun, 6 Nov 2022 14:44:08 -0700 (MST) From: Sean Whitton To: Philip Kaludercic Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <87k04al5st.fsf@posteo.net> (Philip Kaludercic's message of "Fri, 04 Nov 2022 22:21:22 +0000") References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87k04al5st.fsf@posteo.net> Date: Sun, 06 Nov 2022 14:44:08 -0700 Message-ID: <87iljrbvx3.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Philip, Not sure what input is wanted from me. Happy to think through anything in particular you were waiting to hear from me about? -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 06 16:49:34 2022 Received: (at 58383) by debbugs.gnu.org; 6 Nov 2022 21:49:34 +0000 Received: from localhost ([127.0.0.1]:60835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ornWI-0002r1-2y for submit@debbugs.gnu.org; Sun, 06 Nov 2022 16:49:34 -0500 Received: from mout02.posteo.de ([185.67.36.66]:34949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ornWD-0002qj-79 for 58383@debbugs.gnu.org; Sun, 06 Nov 2022 16:49:33 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 0620D240101 for <58383@debbugs.gnu.org>; Sun, 6 Nov 2022 22:49:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667771363; bh=VL59StwcgEJKx6hzcmztnUYQjbRnfLOdm0/c4rOlS/E=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=LH2/XkdNI6A6b3kksBtSrI3MmnXTod87POoig8MOjRhjCV1pnysQShrOTpwJusKD1 EDhZeT53bV+1tIrQw9ytCErcSRKDEmY8ywZM24meBGjCV7234TgoagY2FN+Ophhjxs dSZBz4NvhV7KqNlyPoHZtVsFQ2zIIwYHwkKOC6z+koqzKnOYaru2cG5mKg1Q3sBQb1 WrumTH7f6TuRISnjgskhKJtbY+ePvzaTP8Qk3LMsqU4HPonQB1Ydp9BzOqBpKPuxBG WelgGm5jbu7vW3SLiB29pTu3uesyEaECsv6uzhEZLi1rZyXBT+/0reFamfGyhw2uOd 6AqlkoYeL1z3Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N57LB1fW0z6tnX; Sun, 6 Nov 2022 22:49:21 +0100 (CET) From: Philip Kaludercic To: Sean Whitton Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <87iljrbvx3.fsf@melete.silentflame.com> (Sean Whitton's message of "Sun, 06 Nov 2022 14:44:08 -0700") References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87k04al5st.fsf@posteo.net> <87iljrbvx3.fsf@melete.silentflame.com> Autocrypt: addr=philipk@posteo.net; keydata= mQGNBGLfygUBDADVznbke6w0n9nE42xb+ZggbBy0IYRkkru/K+NA67523YTl2DoR2a5OMW90w7L9 KDtX2Mp34JN/6jVOSVC07VUbHVu6/exoGKixkiTpGhBPy5tUUJoxQKqLrzVQhN3fIyvg1oyHXKZm QGkUeevV0wjj4++xfjmcP235YvDh3TF8HC9t5KxIQIbhWnQm4ZyDkpWWS2CmdNttlj2+eH+51WLL bgx2bcwTmqrs079Q3hgF3yh44bBEmp9MgFjiZldOY2my0/ZSeucRxYmiM0vbJEBQgZV/MvA3gTxe 7ibV3ii7AyoYA8FiFDP98S/R2y5Nfq3ez9B7qeqtpSNseQHOU7h8Y5VV01a71ZszENAmbbwsldb9 j+HRLke7rn6mswDZl1qA/9ZFRzliFOdQtS1878XjraY+h5jfjvxaFVK23prGGVrrKv0LPWavoFUr nsjeHEZhYezBKhC2PwvRtXm01S3rkNbwm9pj0tfLSDW+1pT+6eZWptfQCXF2oEvgfKSTASUAEQEA AbQmUGhpbGlwIEthbHVkZXJjaWMgPHBoaWxpcGtAcG9zdGVvLm5ldD6JAdQEEwEKAD4WIQRxJuHe LwzjXHcL7QHyw8xRPbifZgUCYt/KBQIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAK CRDyw8xRPbifZkH+DACmCKmhrYgcv2i6dj3vRCVINaLtKUODTna/wAmP20WRKPhqvqvKNUx/wzpT aZrXIxpxOU2xawRWeHhWUktxS+W9L3xTACeR0gf5gomCxD9RuBTIohzWDkQt5rk8QwLqx5rAy5zo feXujnDCXkZtodo1m54cY2kUFF/WIYRrciL/EBzpcizybMJFwx4HxSBlGRkdwnSH9Dzo+4U+8ctB xDfTvQ7cK/0+Qz/TvKjUK8LXLN1/rJTmqpRDv+Odx9LaxutGGoXeLwmhhgpRhvUS8EsqHGF37Zxe AV/ybdVU4NHXVecZAhSgOXX4EHDa7NjhTihx9Id478aQycOKf3CiI6Z8AgcR/iKE4bD4osh2cqQB +JIBtktImxJ1vFsehdQVjdLPWqlr/1weMHM4xH/4VtCLOl5mO3K+fUWxQ/DGLXeQVZ+hilITSKMl YVH/7he26WGd9FRJR25t9uTSgL2YIG8xYppKXueyK/5zjHq05UZRFKiFuPTE4Daoemqx86vYlui5 AY0EYt/KBQEMANvhe1fPQ3BHBcE2GfdX9kVXV0uAP+2Be2DxKWPJI1SqZbrS4wSUsDdd2+2m4YMX E3d+K9Z6IqBcr5gMFSN9QKGEo91FYYgnqvtnd6n9sEAScfNri2GVJzlmXAtEAWeVlv83cu0v0Gsw rSKkxZfMxt+EodtN0aswf5SAy77t28NZUw4fk/0o0AlIMjByVcDkipn7N02gLHjYsvMGFFtM3Zqg Fps8ix3XytSg3Pf8hIVhXFGkBs/iN6dGeIs8wVWBsB7azdqE84uUSRAcS4ymqUE6KxsbNo4x8RAx 9Pt2fcL5bWURAZB+83dk8NVmoQdtY+d4JUV9RAKM/Qg/qtE0fVxcZnj8YmxB1NzLf0UxgHuGYtaq HWrB80CROxMzK7fH8yDRnQKHT2gJYMMQjzMwakSSk8bNJDGBTvAbnxSbYMUC3FR4Pz3pSAbsaSz6 LY0QHDRlroBpyJHatrtKh9Uf9nV0wPIKgZfaH2mhiU17/N6wx0W12cBhrTDRoSnTYIgvQQARAQAB iQG8BBgBCgAmFiEEcSbh3i8M41x3C+0B8sPMUT24n2YFAmLfygUCGwwFCQPCZwAACgkQ8sPMUT24 n2b4ogv/Z5HKvWT2hB238G0ZrUxBptNdQHSG3VwfghN30KH7AEW8ZxsDn3zckn/jXxob4VyhUC8d zZdBQstsNgl+NZ7S2JYRUEsIpoRiHnQFJnfPpt6YZMVNYHJkuh7zRIQGji4OoS8j9QdUHsJnQDia xElXx2vwcBTRZBybcNC+3scGgFBzAcrI4AhYjKZBj5lvKMTrWhK+o4bVdFaYTJDIq37MM3IQLzFF oPIB1C525V916wVYSVl7+RQ1T/mf9oX9kZcYVTC0g4KBEEDI4SGK0i5sKDLfBp4c91AFlUo/J8nC hUMWblnpfCC7epUEbrms0ZQE7RFLgy7YCLZ9Fx2JfV6gx9n9vH7kI605uLnTHgkw3uED/CKfVlbW v0Yrtvi0rUMunLnlySIpXItkSIK+PCqTMdLJ3rBe0ALPgbKN6Lu+yxfe0eaAmFbrNZFI0xp40403 gDwhwoq742fLwbxPSldSeb8A93KRg/8e92CMwKVYtxoADeoksMq10iid4POQl2vw Date: Sun, 06 Nov 2022 21:49:20 +0000 Message-ID: <87cz9zoisf.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Sean Whitton writes: > Hello Philip, > > Not sure what input is wanted from me. Happy to think through anything > in particular you were waiting to hear from me about? I was wondering if you had any comments on my last message: Sean Whitton writes: > Hello, > > How about a prefix argument to vc-prepare-patch to invert one's usual > setting for vc-prepare-patches-separately? Most people who contribute > to more than one project regularly will want to use both. How would this be preferable to setting `vc-prepare-patches-separately' as a directory local variable? That way you don't have to remember to use a prefix argument whenever invoking `vc-prepare-patch'. > On the other hand, having a numeric prefix argument mean "send patches > correspoding to the top N revisions of the current branch" would be > very > convenient. Perhaps these two could be combined by using a negative > number to mean also invert? This is the usual problem with numeric prefix arguments. You don't get that much expressivity with just an integer. That is why I would hesitate to assign any particular interpretation to prefix arguments, before considering and weighing the options. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 07 18:06:37 2022 Received: (at 58383) by debbugs.gnu.org; 7 Nov 2022 23:06:37 +0000 Received: from localhost ([127.0.0.1]:35661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osBCP-0007D8-E3 for submit@debbugs.gnu.org; Mon, 07 Nov 2022 18:06:37 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:57499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osBCN-0007Cv-Gq for 58383@debbugs.gnu.org; Mon, 07 Nov 2022 18:06:36 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 16D7D5C0103; Mon, 7 Nov 2022 18:06:30 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 07 Nov 2022 18:06:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1667862390; x=1667948790; bh=OP PjtdrOd2gsx6Zpffk6htjUKXnWOvcFr582Gfh/ssM=; b=l3+52Gudhwgmz9XaXb L3Sb3ZA4IvEPhpQnP+yS2YDSdgoK/E/Bgh8iemn/ceCP7k1cqE2HKiMYmQ7qyZUh +xXUZRJvT7bGvtUfTGQ2qk/P4M9rIKKFp6g4Os/OCwH8lc/5EZGAi8nR3wHbqqAI JC2IlmV7c4pObbuyGxf2z2lvNdagqDS2aW3gjJV+nFkzyV9DpGzShYCiJNUem8fb gEPIM0BnALEK/R4YegreTaczW9RaNVIYe6o4Fp72fUo4g//4Glkfi262+vz+ehcJ 6uUqS0cXbr6fbbHvimX22gRs9HlccmuBsvAWzjyfLVzecBWIJUATcRqtL/och/ls q4QQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1667862390; x=1667948790; bh=OPPjtdrOd2gsx6Zpffk6htjUKXnW OvcFr582Gfh/ssM=; b=fMBFhemjHgcEgFT8IuPXB+IKDOcIHTVRTbbQPvKRxq+l EPosUjSFnEjBIcAPgQeTKYS7eeczGg0liMYMJB73PoyP90daSz7Y07bLQb76OxTf cyNAJ8Qsuv7xntjtioF6P26s7jNi6/Vvkbd7zBCm4/huXUu1fYbMyaB7EPrOPpaD Hs3ZLPoYXDuKugOQtRxhAgI/K4TjlGIfnJescC8csqtFSgVLOgMyrPbDQiwhrZYZ IX9qD7Asay9r2uaba8C+hPYGI5CPwarXYDtoD2lYoQrZ45sN9hJc7pNDW3w+0C1/ Ois1Be6oSNGxJRzvSQyXzQSDtf06IX3D+mmlHPYFjQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrvdelgddtjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedukeeg geelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Nov 2022 18:06:29 -0500 (EST) Received: by melete.silentflame.com (Postfix, from userid 1000) id 0BD487E5F21; Mon, 7 Nov 2022 16:06:29 -0700 (MST) From: Sean Whitton To: Philip Kaludercic Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <87edvh2m3o.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 09 Oct 2022 12:54:51 +0000") References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> Date: Mon, 07 Nov 2022 16:06:29 -0700 Message-ID: <87v8nq4b62.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Sun 09 Oct 2022 at 12:54PM GMT, Philip Kaludercic wrote: > Sean Whitton writes: > >> Hello, >> >> How about a prefix argument to vc-prepare-patch to invert one's usual >> setting for vc-prepare-patches-separately? Most people who contribute >> to more than one project regularly will want to use both. > > How would this be preferable to setting `vc-prepare-patches-separately' > as a directory local variable? That way you don't have to remember to > use a prefix argument whenever invoking `vc-prepare-patch'. Makes sense. >> On the other hand, having a numeric prefix argument mean "send patches >> correspoding to the top N revisions of the current branch" would be very >> convenient. Perhaps these two could be combined by using a negative >> number to mean also invert? > > This is the usual problem with numeric prefix arguments. You don't get > that much expressivity with just an integer. > > That is why I would hesitate to assign any particular interpretation to > prefix arguments, before considering and weighing the options. Well, any other options in mind? Varying the -N argument to git-format-patch/git-send-email is what I find myself using the most. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 08 15:31:26 2022 Received: (at 58383) by debbugs.gnu.org; 8 Nov 2022 20:31:26 +0000 Received: from localhost ([127.0.0.1]:38272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osVFl-0002Xj-Uh for submit@debbugs.gnu.org; Tue, 08 Nov 2022 15:31:26 -0500 Received: from mout01.posteo.de ([185.67.36.65]:57627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osVFk-0002XU-4a for 58383@debbugs.gnu.org; Tue, 08 Nov 2022 15:31:24 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id E79A5240026 for <58383@debbugs.gnu.org>; Tue, 8 Nov 2022 21:31:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667939477; bh=G3iD2hgvI1Jci5ZtF8/jQ8hrRx91BhfurqjkAXnvfXo=; h=From:To:Cc:Subject:Date:From; b=jhGf6NA/HNvKCr3vR1fmAbQJGSZmqEKwO2zLtI0lbmGs4r/hBXCucJYehOMhHzOOx EmBCqlICozb+/AFEbtFBHlIH9PhtNgwfuAkl/BrIfzz13/5ZCYsJ4GNw7MEGNirCZP QoTk4cjqIZODrMaAYq8L5JIoMs0N6+tAMDXY2hRjtnOT4XAdcVm8nxzxmjxnMHJcQW cpWKuTHr20AuyJ1Zsewr2DpvM2W3739O3h1Z1TGFKPVmH12VLoqq/yOM48h76Ckm+i YE9TGV/4FqeKGWPDph/UtN02erSfQQ1W6F0+GF503NGxb7lZBiIedeisHthSJO72zc Bs0cOgcPZrD3A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N6KW65ZX7z6tm4; Tue, 8 Nov 2022 21:31:14 +0100 (CET) From: Philip Kaludercic To: Sean Whitton Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <87v8nq4b62.fsf@melete.silentflame.com> (Sean Whitton's message of "Mon, 07 Nov 2022 16:06:29 -0700") References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> Date: Tue, 08 Nov 2022 20:31:14 +0000 Message-ID: <87cz9xgpd9.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sean Whitton writes: >>> On the other hand, having a numeric prefix argument mean "send patches >>> correspoding to the top N revisions of the current branch" would be very >>> convenient. Perhaps these two could be combined by using a negative >>> number to mean also invert? >> >> This is the usual problem with numeric prefix arguments. You don't get >> that much expressivity with just an integer. >> >> That is why I would hesitate to assign any particular interpretation to >> prefix arguments, before considering and weighing the options. > > Well, any other options in mind? Varying the -N argument to > git-format-patch/git-send-email is what I find myself using the most. The issue is finding a way for this to be expressed VC-generically. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 08 16:00:40 2022 Received: (at 58383) by debbugs.gnu.org; 8 Nov 2022 21:00:40 +0000 Received: from localhost ([127.0.0.1]:38293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osVi4-0003GG-8S for submit@debbugs.gnu.org; Tue, 08 Nov 2022 16:00:40 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60295) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osVi2-0003G4-J3 for 58383@debbugs.gnu.org; Tue, 08 Nov 2022 16:00:39 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 03F715C0035; Tue, 8 Nov 2022 16:00:33 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 08 Nov 2022 16:00:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1667941232; x=1668027632; bh=3c hUdfMsMMFgn3zmqjZViZQSJpx9j99jDsgszEi2nwg=; b=Pp/hx9+wbDi9HQFvAr OnmndcTiS5o32qn4R00cH0drhbLm29o5cblH776IdM4LwdzS9hlF7LGKj5bDj/U8 PG7dK+ke6CPWWXxisyARdwPLxQWwralMTMcDt+Grzz60XqnL9XlWyhHuzcQCF2He N1iolnpBIeM3Ue9QAdS0eVWx2El4eXdDM2cZluvvF3/HVx5/aQgLaGSIFwjsO1IV miqXv1WwEy/Oj2etYsGnFocQRoIxxcvYo2KcFL5jmAS/BikkUlPI+XnMKr77RVKU N+R8krWjzER7Ik0LHvsDYghIRPEo5FbBIZI+wtyOmYInci8k0na6Zdx4b4Xad89O GwZQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1667941232; x=1668027632; bh=3chUdfMsMMFgn3zmqjZViZQSJpx9 j99jDsgszEi2nwg=; b=CxiYpvcB8Un9pdk+AeRtj6/5MGhh3pdJkHs+s+PvZloO 3RSOdufQmTslxvykzpaQGVJnLXsGrOJIBpN2CUwO8blzRFwFBehaEFEI3lSbhWCZ 4nauN8q50HdfnTIL/1kDRKseDUIFd6kIyKoNP0I6N9Yq9m3zB8R39vK8IHCUEyx5 tq1Rbv8jujUHj5dpry4Cu5M3K6c/REpX5EaDsIn40fiEjYKeb1mz8mTn/fVbck55 6rePyz7Fe5rE6DwJIyRwd82c5KAiz+j+vFcs4jk6/BhASSA4NmQSTfoCrgYKkwhr nvrFX9/hIn1Yx8Is6/kFd8YuCcT0gIKEXyqZPeGQLw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrfedtgddugeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 8 Nov 2022 16:00:32 -0500 (EST) Received: by melete.silentflame.com (Postfix, from userid 1000) id 4CC9F7E6125; Tue, 8 Nov 2022 14:00:31 -0700 (MST) From: Sean Whitton To: Philip Kaludercic Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <87cz9xgpd9.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 08 Nov 2022 20:31:14 +0000") References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> Date: Tue, 08 Nov 2022 14:00:31 -0700 Message-ID: <87sfityxe8.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Tue 08 Nov 2022 at 08:31PM GMT, Philip Kaludercic wrote: > Sean Whitton writes: > >>>> On the other hand, having a numeric prefix argument mean "send patches >>>> correspoding to the top N revisions of the current branch" would be very >>>> convenient. Perhaps these two could be combined by using a negative >>>> number to mean also invert? >>> >>> This is the usual problem with numeric prefix arguments. You don't get >>> that much expressivity with just an integer. >>> >>> That is why I would hesitate to assign any particular interpretation to >>> prefix arguments, before considering and weighing the options. >> >> Well, any other options in mind? Varying the -N argument to >> git-format-patch/git-send-email is what I find myself using the most. > > The issue is finding a way for this to be expressed VC-generically. s/expressed/implemented/, right? -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 09 03:29:09 2022 Received: (at 58383) by debbugs.gnu.org; 9 Nov 2022 08:29:09 +0000 Received: from localhost ([127.0.0.1]:38983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osgSK-0007uU-PO for submit@debbugs.gnu.org; Wed, 09 Nov 2022 03:29:09 -0500 Received: from mout01.posteo.de ([185.67.36.65]:54309) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osgSI-0007u0-Tj for 58383@debbugs.gnu.org; Wed, 09 Nov 2022 03:29:07 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 05A85240028 for <58383@debbugs.gnu.org>; Wed, 9 Nov 2022 09:29:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667982541; bh=WTrp8GYZIDJpG2uDvsFYxDXeXIg+CCC/HkS1JgKVr84=; h=From:To:Cc:Subject:Date:From; b=d2okgsasmbx2/U3SF9dfxRlY7KQp2+2/784SonQ9jDpKvKiTergdnX1+gbgmNqZtY YG6zD0/jXq54OEE5nvot6tBllQVk2RJ/1s1F//0aIf+JkoqPqi2DIXrufmlWAFVety wQdqmdF1hX0VT42AzBkWIShpsSSAfqKQ7cI1Hg+kPchHls/DNpmnDRpJCuM3hAnOfo 9U5G/bwvWyK4wJad+6Tsd/qgibWl8GLPyS6uijI70CO0SLU0kJtZyJgZEEoygjXLff vyVdeyAZvY/nchenfBuGlrod6D1WbC5VV2iupd/X/28ERCyBPgfxHn6f6NjhlZ25F7 AEIa19nLQj3Rw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N6dRH6DsMz6tm4; Wed, 9 Nov 2022 09:28:59 +0100 (CET) From: Philip Kaludercic To: Sean Whitton Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <87sfityxe8.fsf@melete.silentflame.com> (Sean Whitton's message of "Tue, 08 Nov 2022 14:00:31 -0700") References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> Date: Wed, 09 Nov 2022 08:28:59 +0000 Message-ID: <87sfisedkk.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sean Whitton writes: > Hello, > > On Tue 08 Nov 2022 at 08:31PM GMT, Philip Kaludercic wrote: > >> Sean Whitton writes: >> >>>>> On the other hand, having a numeric prefix argument mean "send patches >>>>> correspoding to the top N revisions of the current branch" would be very >>>>> convenient. Perhaps these two could be combined by using a negative >>>>> number to mean also invert? >>>> >>>> This is the usual problem with numeric prefix arguments. You don't get >>>> that much expressivity with just an integer. >>>> >>>> That is why I would hesitate to assign any particular interpretation to >>>> prefix arguments, before considering and weighing the options. >>> >>> Well, any other options in mind? Varying the -N argument to >>> git-format-patch/git-send-email is what I find myself using the most. >> >> The issue is finding a way for this to be expressed VC-generically. > > s/expressed/implemented/, right? I meant expressed, but I don't remember what I meant ^^ So let's say implement. What we could do is just call `previous-revision' for the backend N times, but with what file? From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 09 11:36:48 2022 Received: (at 58383) by debbugs.gnu.org; 9 Nov 2022 16:36:48 +0000 Received: from localhost ([127.0.0.1]:40694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oso4G-0001nb-1q for submit@debbugs.gnu.org; Wed, 09 Nov 2022 11:36:48 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:49973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oso4D-0001nN-Dl for 58383@debbugs.gnu.org; Wed, 09 Nov 2022 11:36:46 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 0B107320046E; Wed, 9 Nov 2022 11:36:38 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 09 Nov 2022 11:36:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1668011798; x=1668098198; bh=/R WAIyfYnzxDyma66TS6g5iHDzBvwkZ14gsV/QwHaWg=; b=nQyWFxdFsBf7RV5DnM zYktTT4qX52higx6L+UhNjkW3Pt9F4hlRsKlEMuAg4tNAXZJ71SUzqdagHBublwY h62+TedAKJTVD/f3NxD0eFBxGN/yM8BEnLj7+2H/bBNdYp4PbMiyx/IBK6rYBm4S GAVm3fCvzxk09dQvVMU/J4F/1dbSFe7jRuAkEWFY4ddMt8sIebZEBLlrjCsAT+3r T8wKGh5zVuUS4A15SONuCqCLHYzduexuTWmgD0o4vSBLyljiWoqW0poOFzvApeW0 AmWmazUS/UHrLujJ+Bri/HM5Gn0KV2PIuKrRZCdXVvqa91UKdpzTwCoJ96c7jBmn kv9A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668011798; x=1668098198; bh=/RWAIyfYnzxDyma66TS6g5iHDzBv wkZ14gsV/QwHaWg=; b=lhtAZ+VQqQ1pDE6hBe8GqBup0wGrtn9tVQbL0k7GUz7C qEsipGlm7AhVg3ToflsNt4qiTCebIi1qdZDYMv1xoLvmuShqiKzmA4rAD1INMw55 S1rEfdIeUCK8xE2ag4ZU7LoxywivuREflJYthBYnJBCMLKmt4tFMdU9DOX7Id2Ci Kk2qasqEQn1CqlUwXxJqZEcklQs+TBzim1LALZ/OuW39vuTzumtLXeyyVUXv9olu CL4PCZifQvsXKvMyq/y+CC0sTYtrIUUDiko++b2AQW2zbgl9sMB6qXdKEFOL+8Bb 6B8YLTZnP5QBshBg//51FrLDUtj9190oWyqcnkgfAw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrfedvgdeltdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedukeeg geelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 9 Nov 2022 11:36:37 -0500 (EST) Received: by melete.silentflame.com (Postfix, from userid 1000) id 9A3B17E63E6; Wed, 9 Nov 2022 09:36:36 -0700 (MST) From: Sean Whitton To: Philip Kaludercic Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <87sfisedkk.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 09 Nov 2022 08:28:59 +0000") References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> <87sfisedkk.fsf@posteo.net> Date: Wed, 09 Nov 2022 09:36:36 -0700 Message-ID: <87educytij.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Wed 09 Nov 2022 at 08:28AM GMT, Philip Kaludercic wrote: > Sean Whitton writes: > >> Hello, >> >> On Tue 08 Nov 2022 at 08:31PM GMT, Philip Kaludercic wrote: >> >>> Sean Whitton writes: >>> >>>>>> On the other hand, having a numeric prefix argument mean "send patches >>>>>> correspoding to the top N revisions of the current branch" would be very >>>>>> convenient. Perhaps these two could be combined by using a negative >>>>>> number to mean also invert? >>>>> >>>>> This is the usual problem with numeric prefix arguments. You don't get >>>>> that much expressivity with just an integer. >>>>> >>>>> That is why I would hesitate to assign any particular interpretation to >>>>> prefix arguments, before considering and weighing the options. >>>> >>>> Well, any other options in mind? Varying the -N argument to >>>> git-format-patch/git-send-email is what I find myself using the most. >>> >>> The issue is finding a way for this to be expressed VC-generically. >> >> s/expressed/implemented/, right? > > I meant expressed, but I don't remember what I meant ^^ > > So let's say implement. What we could do is just call > `previous-revision' for the backend N times, but with what file? I don't know, but the meaning of "the past N checked-in revisions of the whole tree" is what we need to agree upon, then it's just coding. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 09 12:46:59 2022 Received: (at 58383) by debbugs.gnu.org; 9 Nov 2022 17:46:59 +0000 Received: from localhost ([127.0.0.1]:40831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ospAA-0003bs-QK for submit@debbugs.gnu.org; Wed, 09 Nov 2022 12:46:59 -0500 Received: from mout01.posteo.de ([185.67.36.65]:35925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ospA9-0003bd-2Q for 58383@debbugs.gnu.org; Wed, 09 Nov 2022 12:46:57 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 87E0A240028 for <58383@debbugs.gnu.org>; Wed, 9 Nov 2022 18:46:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668016011; bh=GlpSC2D/OoLAg4Jmkxndh3xAiYxXQn3JhxXCm4LwB9k=; h=From:To:Cc:Subject:Date:From; b=ZZVPUzUht6PrjEbFAh6FYNiX5m8dNMkst9M2l+eea+c43Pg1wZPOfz7eTN/I4xM3f 5cc7w9xQ80OumWXdVjTHNsry1P2UajP/iKLHEtvRI7CLVtGLWhc6Z55QOtFNaFSklJ nECbnNRXrp2Ixk59uTw/2MDuuL1IGzjkl3zHa4z1Z/jhx0BW5KAlZMFM6Jy3Ls18H7 AcD5Mu4maxyjyBhjBwcUKuGRlgkcxfMt5j1/9MFqKLxJCfSaHMK0ut16deHYJWz+1L wAYYRHwA6xGTk5i5z1QwgYkoDeI3wIMbRaHhT2TGCAJ5QFKMgPCdSPmy4Ulxvib7VV svFJXz3iU2/bg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N6spy5Vcrz6tpy; Wed, 9 Nov 2022 18:46:50 +0100 (CET) From: Philip Kaludercic To: Sean Whitton Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <87educytij.fsf@melete.silentflame.com> (Sean Whitton's message of "Wed, 09 Nov 2022 09:36:36 -0700") References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> <87sfisedkk.fsf@posteo.net> <87educytij.fsf@melete.silentflame.com> Date: Wed, 09 Nov 2022 17:46:50 +0000 Message-ID: <87iljo9g1h.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sean Whitton writes: > Hello, > > On Wed 09 Nov 2022 at 08:28AM GMT, Philip Kaludercic wrote: > >> Sean Whitton writes: >> >>> Hello, >>> >>> On Tue 08 Nov 2022 at 08:31PM GMT, Philip Kaludercic wrote: >>> >>>> Sean Whitton writes: >>>> >>>>>>> On the other hand, having a numeric prefix argument mean "send patches >>>>>>> correspoding to the top N revisions of the current branch" would be very >>>>>>> convenient. Perhaps these two could be combined by using a negative >>>>>>> number to mean also invert? >>>>>> >>>>>> This is the usual problem with numeric prefix arguments. You don't get >>>>>> that much expressivity with just an integer. >>>>>> >>>>>> That is why I would hesitate to assign any particular interpretation to >>>>>> prefix arguments, before considering and weighing the options. >>>>> >>>>> Well, any other options in mind? Varying the -N argument to >>>>> git-format-patch/git-send-email is what I find myself using the most. >>>> >>>> The issue is finding a way for this to be expressed VC-generically. >>> >>> s/expressed/implemented/, right? >> >> I meant expressed, but I don't remember what I meant ^^ >> >> So let's say implement. What we could do is just call >> `previous-revision' for the backend N times, but with what file? > > I don't know, but the meaning of "the past N checked-in revisions of the > whole tree" is what we need to agree upon, then it's just coding. The critical edge-case here is what happens when branches are merged. Do you pick a random branch or collect all the patches. Or do you raise an error, but then how do you detect that vc-generically. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 09 15:57:06 2022 Received: (at 58383) by debbugs.gnu.org; 9 Nov 2022 20:57:06 +0000 Received: from localhost ([127.0.0.1]:41042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oss89-00029A-Rg for submit@debbugs.gnu.org; Wed, 09 Nov 2022 15:57:06 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:39961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oss87-00028e-A3 for 58383@debbugs.gnu.org; Wed, 09 Nov 2022 15:57:04 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 2E4095C0124; Wed, 9 Nov 2022 15:56:56 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 09 Nov 2022 15:56:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1668027416; x=1668113816; bh=aX jQ6ZuEEAiQrpg5cKDE567oMhygcbPKSr7VgpmOQpA=; b=uyzwH2tzJn6UrAtJo8 sarnzfoCF2/ze6bXiXklfRJJpt+VPA0wqKjMS0wV8c3a+Y2Wt0il8JCWPmqX6NVf hXyc1dj5FK75ntXOixwrbi4r3UMUcN3oY1lCQ0wfSH1+1gByLr2T8zhOEMv1jfgX JycCB3z0sS522CXpK9imWA0DEt2Mse3pBi3YG4028+Wor1gmU2PO7iQ150NMIRHe Kq8OLHgvVeihepPqsMqom2cg+Uoj/WD4ZnCb7rHfMpZk9vpglQmT4rr4nKVlU2x7 g1Zak01rcSKrDILIefg+Qpf6EkreY60WoBFXpcZBFFDEu89Sa6FFjCboSQmBJNin zASw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668027416; x=1668113816; bh=aXjQ6ZuEEAiQrpg5cKDE567oMhyg cbPKSr7VgpmOQpA=; b=JdVj8OHpOeaH1svpFVNSfQMoGd00MJedj5OnsF6gTcfc 8oHkp8VUhKM45auGVJrbYxa8t/XqL40iT67bcZQYmL0/XATcTE7nmCbEEi/PQi32 +yEOQQHNZf6PsL/Nw9VE5gxuuLofz6/lKcb6GIZDFgkxlLbHVJI/C2slU1lJGPVJ sGsCSsi+g7gp3Jf62N71hvizPWNLGKvk+an2KczMKYscguQqcuuOlPY3Jjx8UfFI V3S84N4dpBIrv0iCXqi+MITcQrlSyijl0uNdDymILZNbF+syoEWtIHiu9+5kOZcN z6tLimygDpuc51vecAmeh55AuuWFt4s8kpZdIgzP0g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrfedvgddugeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 9 Nov 2022 15:56:55 -0500 (EST) Received: by melete.silentflame.com (Postfix, from userid 1000) id 1B5117E6268; Wed, 9 Nov 2022 13:56:55 -0700 (MST) From: Sean Whitton To: Philip Kaludercic Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <87iljo9g1h.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 09 Nov 2022 17:46:50 +0000") References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> <87sfisedkk.fsf@posteo.net> <87educytij.fsf@melete.silentflame.com> <87iljo9g1h.fsf@posteo.net> Date: Wed, 09 Nov 2022 13:56:55 -0700 Message-ID: <875yfnzw14.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Wed 09 Nov 2022 at 05:46PM GMT, Philip Kaludercic wrote: > The critical edge-case here is what happens when branches are merged. > Do you pick a random branch or collect all the patches. Or do you raise > an error, but then how do you detect that vc-generically. Typically you wouldn't want to format patches across a merge, so I would suggest raising an error. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 15:14:15 2022 Received: (at 58383) by debbugs.gnu.org; 10 Nov 2022 20:14:15 +0000 Received: from localhost ([127.0.0.1]:44483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otDwF-0002d5-3h for submit@debbugs.gnu.org; Thu, 10 Nov 2022 15:14:15 -0500 Received: from mout02.posteo.de ([185.67.36.66]:39185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otDw9-0002co-W9 for 58383@debbugs.gnu.org; Thu, 10 Nov 2022 15:14:13 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id D7A87240101 for <58383@debbugs.gnu.org>; Thu, 10 Nov 2022 21:14:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668111243; bh=X77Elua09BoDvRjPHkEKjoMKykMHjQ/0SaWL/osLHMY=; h=From:To:Cc:Subject:Date:From; b=Md6JN40XWsPCxtajJW0EmuNx+Idjjs6Rvdil8C0h84E/kSxJmzr2IDthDbza3KY1o x42+lYMqiuptbnF/IklmG2Ronm9IIETiZNx6dswglSzNNEu8czC0wjKyHROykebSYM BPK3EZ3Qf81dgTnMqk0vtZRT0ov8YyluPhz96pEFNE3vlgZ0ZmXDDCuklNnfGdPEGv VU+4pU9jQ0fuhqjXHu+FG3HVIi1nwJH+Ctsrhpe/Nh6sD0KIEP2KFJlu9BFDp6U93E Jca6tI8582mHVJymKzS5U/LPa2qRrdFsGzNhI3PDuIUc1nfd4Ie/1exLLzynreU8bM vWWX5hgBvq6TA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N7Y2M0pl8z9rxD; Thu, 10 Nov 2022 21:14:01 +0100 (CET) From: Philip Kaludercic To: Sean Whitton Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <875yfnzw14.fsf@melete.silentflame.com> (Sean Whitton's message of "Wed, 09 Nov 2022 13:56:55 -0700") References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> <87sfisedkk.fsf@posteo.net> <87educytij.fsf@melete.silentflame.com> <87iljo9g1h.fsf@posteo.net> <875yfnzw14.fsf@melete.silentflame.com> Date: Thu, 10 Nov 2022 20:14:02 +0000 Message-ID: <87v8nm5zzp.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sean Whitton writes: > Hello, > > On Wed 09 Nov 2022 at 05:46PM GMT, Philip Kaludercic wrote: > >> The critical edge-case here is what happens when branches are merged. >> Do you pick a random branch or collect all the patches. Or do you raise >> an error, but then how do you detect that vc-generically. > > Typically you wouldn't want to format patches across a merge, so I would > suggest raising an error. And this is something I don't think can be /expressed/ using vc, because while I can collect a number of revisions using `previous-revision', there is no general way to verify if a commit is a merge commit. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 19:07:17 2022 Received: (at 58383) by debbugs.gnu.org; 11 Nov 2022 00:07:18 +0000 Received: from localhost ([127.0.0.1]:44668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otHZl-00088e-JN for submit@debbugs.gnu.org; Thu, 10 Nov 2022 19:07:17 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:55669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otHZf-00088L-Uy for 58383@debbugs.gnu.org; Thu, 10 Nov 2022 19:07:16 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id CC2FA5C00FD; Thu, 10 Nov 2022 19:07:04 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 10 Nov 2022 19:07:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1668125224; x=1668211624; bh=gI H9Ju4aJwvMAn3rvrzRhDHNWzVtPUcDnYgQuZ+Xmig=; b=ha3wODguWWwU7tujzQ L97SkIMtjdPrJ6ldjE0qA/ctPhey9P72GkuTPqY1opwbK0qCODNh0zFYCj9H/1fC A0nOQBH98M6WdKMSq4WygqdqZ42oN9sCcjhRZLF6dCrMybtNQZIExsWyug9khsVP rQOPATp7nSydx/IHeD+B1bx9qKs1uQLrTWh6BieqKYkL7MSoPmKoNHmC5+xJko+0 4VxMoJFs60Hjpj3TlSZh28vgjrz4sUMPG5+EfGVNovWQPPqtmhH77AMCNv3toaRf 267ANLZH2f2ZLFvh2tSWoI5UqiQuHvj/nsoZxwStxjQ6pdgZq3mDebSabuNsK/4J bMJQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668125224; x=1668211624; bh=gIH9Ju4aJwvMAn3rvrzRhDHNWzVt PUcDnYgQuZ+Xmig=; b=U7+bpMFR0+bEb2j4FinSYBOEsyS2Drj2Jyxz4dH26VJE 6uVJp4PaMQU5OJdPVEDhVjrPRt7Joy8lV0wNdPN4YhpPoWawjfRAd0PlIelVMLbM yxdHpvaYRgaJyoXvMeZ00V4Y53gKcAMzsgqLQ7BfWtLXy4XEXnaHmQT9VKX+ze0t 5V7be4yuI2LG+BNrwqYwxd2LoPvmaVsU7w2YAEuZ0oPlN+k7QT0+nfYaOgRVJIrO t2toB6bigIcUSMEXoK6fzM+LGZv6rq9wHaWk+mvxp6tmaxIbMXaTo4OGM8Yyqdrx LYHYseol/W+nk/rNkRb/nUGd0ofxQq/1X6UrT+/ing== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrfeehgddulecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedukeeg geelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 10 Nov 2022 19:07:04 -0500 (EST) Received: by melete.silentflame.com (Postfix, from userid 1000) id 32CB57E6C8B; Thu, 10 Nov 2022 17:07:03 -0700 (MST) From: Sean Whitton To: Philip Kaludercic Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <87v8nm5zzp.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 10 Nov 2022 20:14:02 +0000") References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> <87sfisedkk.fsf@posteo.net> <87educytij.fsf@melete.silentflame.com> <87iljo9g1h.fsf@posteo.net> <875yfnzw14.fsf@melete.silentflame.com> <87v8nm5zzp.fsf@posteo.net> Date: Thu, 10 Nov 2022 17:07:03 -0700 Message-ID: <87pmduwdzs.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Thu 10 Nov 2022 at 08:14PM GMT, Philip Kaludercic wrote: > Sean Whitton writes: > >> Hello, >> >> On Wed 09 Nov 2022 at 05:46PM GMT, Philip Kaludercic wrote: >> >>> The critical edge-case here is what happens when branches are merged. >>> Do you pick a random branch or collect all the patches. Or do you raise >>> an error, but then how do you detect that vc-generically. >> >> Typically you wouldn't want to format patches across a merge, so I would >> suggest raising an error. > > And this is something I don't think can be /expressed/ using vc, because > while I can collect a number of revisions using `previous-revision', > there is no general way to verify if a commit is a merge commit. Can we do that part on a VCS-by-VCS basis? Default to just calling previous-revision and hoping for the best, but giving vc-git.el a chance to raise an error. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 11 01:32:18 2022 Received: (at 58383) by debbugs.gnu.org; 11 Nov 2022 06:32:18 +0000 Received: from localhost ([127.0.0.1]:44947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otNaL-0005OF-QZ for submit@debbugs.gnu.org; Fri, 11 Nov 2022 01:32:18 -0500 Received: from mout01.posteo.de ([185.67.36.65]:50259) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otNaI-0005O1-WE for 58383@debbugs.gnu.org; Fri, 11 Nov 2022 01:32:16 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id A50CF240027 for <58383@debbugs.gnu.org>; Fri, 11 Nov 2022 07:32:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668148328; bh=VpmMOgdjeZl5y1zesRiq2Giz7/B4j7wb6fnKgZqHOos=; h=From:To:Cc:Subject:Date:From; b=OWrkd/FWmbYMa0+T+bY0NCpxHYGGxCimK7hJIf1/2f77A0IKEvS4yujjLHqtk2i0x Zux9CCU3g6OuVs9pYVFKiLIrod+wMQWfaUlSHcBac9AGVM8pVx79vKQ3B1BhkEkX+T 3avMvtpMHgRevn5eu9Lwv8wt83GB5cnFigW8TWtvQOG/o+2+5ZPP+JoANki9nHXjIE 3HuEr3P/5bYt/uGnHlV/fxYAZOocmmw4wTN5OS4EEhGA3JP7mh977WhvwOsuGyILeW N5GIiLcHZNe7PpTx5h2ljF8WkV2sXd4e9wCUTrgVo4rMFibbyOq2KzYCJG5VAZarS4 MQ0V/JEGC+x6w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N7plW6YcVz9rxN; Fri, 11 Nov 2022 07:32:06 +0100 (CET) From: Philip Kaludercic To: Sean Whitton Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <87pmduwdzs.fsf@melete.silentflame.com> (Sean Whitton's message of "Thu, 10 Nov 2022 17:07:03 -0700") References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> <87sfisedkk.fsf@posteo.net> <87educytij.fsf@melete.silentflame.com> <87iljo9g1h.fsf@posteo.net> <875yfnzw14.fsf@melete.silentflame.com> <87v8nm5zzp.fsf@posteo.net> <87pmduwdzs.fsf@melete.silentflame.com> Date: Fri, 11 Nov 2022 06:32:06 +0000 Message-ID: <87bkpexaqh.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sean Whitton writes: >>> Typically you wouldn't want to format patches across a merge, so I would >>> suggest raising an error. >> >> And this is something I don't think can be /expressed/ using vc, because >> while I can collect a number of revisions using `previous-revision', >> there is no general way to verify if a commit is a merge commit. > > Can we do that part on a VCS-by-VCS basis? Default to just calling > previous-revision and hoping for the best, but giving vc-git.el a chance > to raise an error. I guess that would be possible, though it will probably require a new VC method :/ The new `prepare-patch' takes a revision, so it doesn't make sense to pass it a number and have it return multiple patches. Perhaps it will be easier/cleaner to just accept that avoiding merge revisions is the users responsibility. But just to have mentioned it: Do you know that you can mark revisions in log-view and then vc-prepare-patches will use these as the default input when prompting for revisions? From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 11 02:34:47 2022 Received: (at 58383) by debbugs.gnu.org; 11 Nov 2022 07:34:47 +0000 Received: from localhost ([127.0.0.1]:44988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otOYp-0006vg-35 for submit@debbugs.gnu.org; Fri, 11 Nov 2022 02:34:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otOYn-0006vI-CZ for 58383@debbugs.gnu.org; Fri, 11 Nov 2022 02:34:45 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otOYi-0005Bn-4G; Fri, 11 Nov 2022 02:34:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ULCvFn3LENzxidf85MrWH2i040w1FoZ4/c3HIy6b7Ww=; b=Pceg90Lt6zkN Lc7slaEllu9PREHUUAf41vwf434Ykb9voLwYMM21cdK1nwyU1blXTGMMnFFuSUpLdyuVePNIprP81 MAIWRyXHowPh8DdFCiaADoDaz+94m4HUPrcZnBtVHEqhDSpRbBt1l9PUwfJkGozo9QZAGYBXbGB1e XcLqavbdceZydXfWlQpqjazOVD2GWleXIQRxAt3phxrrcmQdAsXg67WUDLxNpe4M/zUPxT19cPr2x Tzi/6TpEB+N4rYJe9TTpvhjXPvlHMrSzxJ5AulZE0ShB6XS/SqAj1KBfQXOYILL3RwyOYq1wxF/j1 DBcITT5EGg98OeWs7F93rg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otOYg-00088X-Sm; Fri, 11 Nov 2022 02:34:39 -0500 Date: Fri, 11 Nov 2022 09:34:42 +0200 Message-Id: <83v8nmosfh.fsf@gnu.org> From: Eli Zaretskii To: Sean Whitton In-Reply-To: <87pmduwdzs.fsf@melete.silentflame.com> (message from Sean Whitton on Thu, 10 Nov 2022 17:07:03 -0700) Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> <87sfisedkk.fsf@posteo.net> <87educytij.fsf@melete.silentflame.com> <87iljo9g1h.fsf@posteo.net> <875yfnzw14.fsf@melete.silentflame.com> <87v8nm5zzp.fsf@posteo.net> <87pmduwdzs.fsf@melete.silentflame.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58383 Cc: philipk@posteo.net, 58383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 58383@debbugs.gnu.org > From: Sean Whitton > Date: Thu, 10 Nov 2022 17:07:03 -0700 > > >> On Wed 09 Nov 2022 at 05:46PM GMT, Philip Kaludercic wrote: > >> > >>> The critical edge-case here is what happens when branches are merged. > >>> Do you pick a random branch or collect all the patches. Or do you raise > >>> an error, but then how do you detect that vc-generically. > >> > >> Typically you wouldn't want to format patches across a merge, so I would > >> suggest raising an error. > > > > And this is something I don't think can be /expressed/ using vc, because > > while I can collect a number of revisions using `previous-revision', > > there is no general way to verify if a commit is a merge commit. > > Can we do that part on a VCS-by-VCS basis? Default to just calling > previous-revision and hoping for the best, but giving vc-git.el a chance > to raise an error. Please don't forget that Git's notion and implementation of merge-commits is (AFAIR) quite unique. I'm not sure there's another VCS which handles merge-commits like Git does. So when you build your notion of what merge-commit is and how to deal with it in the context of this issue, I think it is best to study what the other VCSes do, before you base the design on what Git does. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 11 15:54:04 2022 Received: (at 58383) by debbugs.gnu.org; 11 Nov 2022 20:54:04 +0000 Received: from localhost ([127.0.0.1]:46838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otb2K-0001ia-CX for submit@debbugs.gnu.org; Fri, 11 Nov 2022 15:54:04 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:39857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otb2H-0001i2-Ea for 58383@debbugs.gnu.org; Fri, 11 Nov 2022 15:54:02 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 5BC995C0075; Fri, 11 Nov 2022 15:53:55 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 11 Nov 2022 15:53:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1668200035; x=1668286435; bh=Um zL3KpzKykfVqhO1EnA4V4N6JZXalGnWecuLu9YoSU=; b=zqCw+mRBmc83kkTTEj 7QaIane8NFN1z9svQ/zn1MA1z6uVebeb3TkDdimYrq/R1NbYMbkz0033tZ6iZ7dz RJayy2b36gPK/yMB9nPIaNsbXhX3ZbOsA3/LxzyO7BixohXBprPugqFBoYjV6Ptr jArr1RN5MWgvXg2CWJDRmoyzynKQhAEp4ROyEkwjaGFrXRqCEhroy2w+fW+aLzNC XhVtOcnA85OWOehktbYUPMrYbMbExBkGePEHRXGt51smRwDva8AqcoMoMef0NeyL C730Gt5uDQEhFTICEmEMxblfJ2EVMyQaSFEFYmwbUrDf6g3laIf0Yro4yOYuH3xY vngA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668200035; x=1668286435; bh=UmzL3KpzKykfVqhO1EnA4V4N6JZX alGnWecuLu9YoSU=; b=YtZj0Mqn6uDNrJ7yjluy7Q5FM1/UrFgI+roi0hOqhOCg OZDhyQHt27Oy1iLZ9MUaMpJWVnGgCK+uC6SYWE5J44ykYk4VEOh+sLTzgrfGo0fF dJ7i4nkCzaF9kPxW+FtxZk++rtphAw35RLimL6JKAlJ1hSkuFxlMlCKsQ4ppqDMm +AiKGcdZ2oEA2zQcLIoWwKotXoA9PImzwbE3hgMSgAB+wUx99ZDrQ/RHUohqOcYw xiyioYLaoYegcuZnTVVKAkPve2hRL6BqgPoPOa/pC6fQT2HaTrx5gbmtjEljqIi9 I3t3fkb20RPZaEK26cvWEXixo8lr10OtOCjM/u5aNg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrfeeigddugeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 11 Nov 2022 15:53:54 -0500 (EST) Received: by melete.silentflame.com (Postfix, from userid 1000) id 825A87E704D; Fri, 11 Nov 2022 13:53:53 -0700 (MST) From: Sean Whitton To: Philip Kaludercic Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <87bkpexaqh.fsf@posteo.net> (Philip Kaludercic's message of "Fri, 11 Nov 2022 06:32:06 +0000") References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> <87sfisedkk.fsf@posteo.net> <87educytij.fsf@melete.silentflame.com> <87iljo9g1h.fsf@posteo.net> <875yfnzw14.fsf@melete.silentflame.com> <87v8nm5zzp.fsf@posteo.net> <87pmduwdzs.fsf@melete.silentflame.com> <87bkpexaqh.fsf@posteo.net> Date: Fri, 11 Nov 2022 13:53:53 -0700 Message-ID: <87wn81us9q.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Fri 11 Nov 2022 at 06:32AM GMT, Philip Kaludercic wrote: > Sean Whitton writes: > >>>> Typically you wouldn't want to format patches across a merge, so I would >>>> suggest raising an error. >>> >>> And this is something I don't think can be /expressed/ using vc, because >>> while I can collect a number of revisions using `previous-revision', >>> there is no general way to verify if a commit is a merge commit. >> >> Can we do that part on a VCS-by-VCS basis? Default to just calling >> previous-revision and hoping for the best, but giving vc-git.el a chance >> to raise an error. > > I guess that would be possible, though it will probably require a new > VC method :/ The new `prepare-patch' takes a revision, so it doesn't > make sense to pass it a number and have it return multiple patches. > > Perhaps it will be easier/cleaner to just accept that avoiding merge > revisions is the users responsibility. Sounds reasonable -- it can always be enhanced later in a way that's backwards-compatible. > But just to have mentioned it: Do you know that you can mark revisions > in log-view and then vc-prepare-patches will use these as the default > input when prompting for revisions? Yeah, but marking in those buffers is way more awkward than marking in, e.g., dired, and I usually know how many commits I want to send without looking at the log. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 13 08:56:55 2022 Received: (at 58383) by debbugs.gnu.org; 13 Nov 2022 13:56:56 +0000 Received: from localhost ([127.0.0.1]:50235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouDTj-0004ca-9S for submit@debbugs.gnu.org; Sun, 13 Nov 2022 08:56:55 -0500 Received: from mout01.posteo.de ([185.67.36.65]:49105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouDTf-0004c8-Fg for 58383@debbugs.gnu.org; Sun, 13 Nov 2022 08:56:53 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 1CE74240027 for <58383@debbugs.gnu.org>; Sun, 13 Nov 2022 14:56:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668347805; bh=yJzWpvKOEMyf57WSlup1u/Qfm12pzB//VosuE4QB8U8=; h=From:To:Cc:Subject:Date:From; b=FKDlMg7RW1YBevvJaE4286Z2ZOkLPYjBq/lgXAPwNokGgCI/XmIlEbcQKTUYHjt6q aKKyx0aZ3V3Qa9y0Zgg745mz4zSjHru5jyt8fgmlWaQxghA/NykDmUGaJo19jgNjOR +UHgkUfPGnBe8fH/McsH0h0C8jXGdHnnAUEiKspDzKot3JkAVtPAb2XvpHIznJa7QB lKf9s+mDceNsOp9MOoy1Pur7eUs6/C7z8PH4+E6t3LlqRbVofc+Nuk0F6ZUtVH/Chu uHghNh3vBHzJzoTphqysq8jaxgNfzOoh+AWV4T1kG34CpefphsPTJkmx7tmH6q80jD 2wsLGIZ0RK/pQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N9DWc1T0Yz9rxP; Sun, 13 Nov 2022 14:56:44 +0100 (CET) From: Philip Kaludercic To: Sean Whitton Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <87wn81us9q.fsf@melete.silentflame.com> (Sean Whitton's message of "Fri, 11 Nov 2022 13:53:53 -0700") References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> <87sfisedkk.fsf@posteo.net> <87educytij.fsf@melete.silentflame.com> <87iljo9g1h.fsf@posteo.net> <875yfnzw14.fsf@melete.silentflame.com> <87v8nm5zzp.fsf@posteo.net> <87pmduwdzs.fsf@melete.silentflame.com> <87bkpexaqh.fsf@posteo.net> <87wn81us9q.fsf@melete.silentflame.com> Date: Sun, 13 Nov 2022 13:56:38 +0000 Message-ID: <87a64vvtyh.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Sean Whitton writes: > Hello, > > On Fri 11 Nov 2022 at 06:32AM GMT, Philip Kaludercic wrote: > >> Sean Whitton writes: >> >>>>> Typically you wouldn't want to format patches across a merge, so I would >>>>> suggest raising an error. >>>> >>>> And this is something I don't think can be /expressed/ using vc, because >>>> while I can collect a number of revisions using `previous-revision', >>>> there is no general way to verify if a commit is a merge commit. >>> >>> Can we do that part on a VCS-by-VCS basis? Default to just calling >>> previous-revision and hoping for the best, but giving vc-git.el a chance >>> to raise an error. >> >> I guess that would be possible, though it will probably require a new >> VC method :/ The new `prepare-patch' takes a revision, so it doesn't >> make sense to pass it a number and have it return multiple patches. >> >> Perhaps it will be easier/cleaner to just accept that avoiding merge >> revisions is the users responsibility. > > Sounds reasonable -- it can always be enhanced later in a way that's > backwards-compatible. > >> But just to have mentioned it: Do you know that you can mark revisions >> in log-view and then vc-prepare-patches will use these as the default >> input when prompting for revisions? > > Yeah, but marking in those buffers is way more awkward than marking in, > e.g., dired, and I usually know how many commits I want to send without > looking at the log. How does the following look like: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 513fbb23fe..0b8a8d83e3 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -3391,14 +3391,24 @@ vc-prepare-patch as the default subject for the message (and it will be prompted for when called interactively). Otherwise a separate message will be composed for each revision, with SUBJECT derived from the -invidividual commits. - -When invoked interactively in a Log View buffer with marked -revisions, those revisions will be used." +invidividual commits. When invoked with a numerical prefix +argument, the last N revisions will be used. When invoked +interactively in a Log View buffer with marked revisions, those +revisions will be used." (interactive (let ((revs (vc-read-multiple-revisions "Revisions: " nil nil nil - (or (and-let* ((revs (log-view-get-marked))) + (or (and-let* ((arg current-prefix-arg) + (fs (vc-deduce-fileset t))) + (cl-loop with file = (caadr fs) + repeat (prefix-numeric-value arg) + for rev = (vc-working-revision file) + then (vc-call-backend + (car fs) 'previous-revision + file rev) + when rev collect it into revs + finally return (mapconcat #'identity revs ","))) + (and-let* ((revs (log-view-get-marked))) (mapconcat #'identity revs ",")) (and-let* ((file (buffer-file-name))) (vc-working-revision file))))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 13 11:07:15 2022 Received: (at 58383) by debbugs.gnu.org; 13 Nov 2022 16:07:16 +0000 Received: from localhost ([127.0.0.1]:52383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouFVr-00028C-Fr for submit@debbugs.gnu.org; Sun, 13 Nov 2022 11:07:15 -0500 Received: from mout01.posteo.de ([185.67.36.65]:54095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouFVn-00027w-Dd for 58383@debbugs.gnu.org; Sun, 13 Nov 2022 11:07:13 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 7CBAD240027 for <58383@debbugs.gnu.org>; Sun, 13 Nov 2022 17:07:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668355625; bh=W4KDOpd8lxyIb5cOsXNMzEccBR1tOQRELBSW0t9aNuY=; h=From:To:Cc:Subject:Date:From; b=FmChklsB2TPRD4Q8POpvKBiA35zZWUuY+/fhyIVqGTkS+RZG9KKqRziwcsD6aRFyp LbiI1QeDPBHQoA1Aq+8SxI8w9CYHVNuBk1H5F+BgIyJotar00CJb+uy5RdJcoYpFrs 7LTyic23t63KmKJ2IN0K64TKCdwqWDpOYJT3oNNdJ60Y0A/IuiFjE9Dl0QO5j/EfK3 zJSZ6WP9aoA+ZUYNTZJ+n2d/29xQFOreaEqZL1L3rcdSzi3re9/V0NkwDDdxm2aDCx dMFzZN/eIIcxe0i2avOZzhX1WXBG/iolf1PfLzspMOO1MbTiBOYia7WZcNidcrBnR0 9dGVMj1XPMFWw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N9HQ02hdTz9rxG; Sun, 13 Nov 2022 17:07:03 +0100 (CET) From: Philip Kaludercic To: Sean Whitton Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <87a64vvtyh.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 13 Nov 2022 14:56:38 +0100") References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> <87sfisedkk.fsf@posteo.net> <87educytij.fsf@melete.silentflame.com> <87iljo9g1h.fsf@posteo.net> <875yfnzw14.fsf@melete.silentflame.com> <87v8nm5zzp.fsf@posteo.net> <87pmduwdzs.fsf@melete.silentflame.com> <87bkpexaqh.fsf@posteo.net> <87wn81us9q.fsf@melete.silentflame.com> <87a64vvtyh.fsf@posteo.net> Date: Sun, 13 Nov 2022 16:06:58 +0000 Message-ID: <87mt8uvnx9.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Philip Kaludercic writes: > How does the following look like: I have prepared a proper patch: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Have-vc-prepare-patch-handle-prefix-arguments.patch >From 724b85acd34e4e5dd6e8cb521eb03eda08ff105a Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Sun, 13 Nov 2022 17:05:20 +0100 Subject: [PATCH] Have 'vc-prepare-patch' handle prefix arguments. * lisp/emacs-lisp/package-vc.el (package-vc-prepare-patch): Use 'vc-prepare-patch-prompt-revisions'. * lisp/vc/vc.el (vc-prepare-patch-prompt-revisions): Extract common function and handle prefix arguments. (vc-prepare-patch): Pull logic out to 'vc-prepare-patch-prompt-revisions'. --- lisp/emacs-lisp/package-vc.el | 14 ++++++------ lisp/vc/vc.el | 40 +++++++++++++++++++++++++---------- 2 files changed, 36 insertions(+), 18 deletions(-) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index 664629d156..37ef35edad 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -733,17 +733,17 @@ package-vc-rebuild ;;;###autoload (defun package-vc-prepare-patch (pkg subject revisions) "Send patch for REVISIONS to maintainer of the package PKG using SUBJECT. -SUBJECT and REVISIONS are passed on to `vc-prepare-patch', which see. -PKG must be a package description. -Interactively, prompt for PKG, SUBJECT, and REVISIONS. However, -if the current buffer has marked commit log entries, REVISIONS -are the tags of the marked entries, see `log-view-get-marked'." +SUBJECT and REVISIONS are passed on to `vc-prepare-patch', which +see. PKG must be a package description. Interactively, prompt +for PKG, SUBJECT, and REVISIONS. When invoked with a numerical +prefix argument, the last N revisions will be used. When invoked +interactively in a Log View buffer with marked revisions, those +revisions will be used." (interactive (list (package-vc--read-package-desc "Package to prepare a patch for: " t) (and (not vc-prepare-patches-separately) (read-string "Subject: " "[PATCH] " nil nil t)) - (or (log-view-get-marked) - (vc-read-multiple-revisions "Revisions: ")))) + (vc-prepare-patch-prompt-revisions))) (vc-prepare-patch (package-maintainers pkg t) subject revisions)) diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 513fbb23fe..f49f5d3307 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -3384,6 +3384,30 @@ vc-default-prepare-patch (vc-root-dir)))) :buffer (current-buffer))))) +(defun vc-prepare-patch-prompt-revisions () + "Prompt the user for a list revisions. +Prepare a default value, depending on the current context. With +a numerical prefix argument, use the last N revisions as the +default value. If the current buffer is a log-view buffer, use +the marked commits. Otherwise fall back to the working revision +of the current file." + (vc-read-multiple-revisions + "Revisions: " nil nil nil + (or (and-let* ((arg current-prefix-arg) + (fs (vc-deduce-fileset t))) + (cl-loop with file = (caadr fs) + repeat (prefix-numeric-value arg) + for rev = (vc-working-revision file) + then (vc-call-backend + (car fs) 'previous-revision + file rev) + when rev collect it into revs + finally return (mapconcat #'identity revs ","))) + (and-let* ((revs (log-view-get-marked))) + (mapconcat #'identity revs ",")) + (and-let* ((file (buffer-file-name))) + (vc-working-revision file))))) + ;;;###autoload (defun vc-prepare-patch (addressee subject revisions) "Compose an Email sending patches for REVISIONS to ADDRESSEE. @@ -3391,18 +3415,12 @@ vc-prepare-patch as the default subject for the message (and it will be prompted for when called interactively). Otherwise a separate message will be composed for each revision, with SUBJECT derived from the -invidividual commits. - -When invoked interactively in a Log View buffer with marked -revisions, those revisions will be used." +invidividual commits. When invoked with a numerical prefix +argument, the last N revisions will be used. When invoked +interactively in a Log View buffer with marked revisions, those +revisions will be used." (interactive - (let ((revs (vc-read-multiple-revisions - "Revisions: " nil nil nil - (or (and-let* ((revs (log-view-get-marked))) - (mapconcat #'identity revs ",")) - (and-let* ((file (buffer-file-name))) - (vc-working-revision file))))) - to) + (let ((revs (vc-prepare-patch-prompt-revisions)) to) (require 'message) (while (null (setq to (completing-read-multiple (format-prompt -- 2.35.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 13 11:35:44 2022 Received: (at 58383) by debbugs.gnu.org; 13 Nov 2022 16:35:44 +0000 Received: from localhost ([127.0.0.1]:52409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouFxQ-0002qK-14 for submit@debbugs.gnu.org; Sun, 13 Nov 2022 11:35:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouFxO-0002q8-DZ for 58383@debbugs.gnu.org; Sun, 13 Nov 2022 11:35:42 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouFxJ-0006Dr-7J; Sun, 13 Nov 2022 11:35:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qOxIJcKR6Ek8nPvznNAkIj2bnqAlFNkWzg6DQbgxQ44=; b=f3ND/PYb/UXJ 93086ZUo9Uw0YyXmn7G2Lv0ozTqmtBIBcld5XjxFTnGL/W+OyOlLJApBN/ooQH6Plf50ygW9lbezy vAJvQN6HYKJZTIXwmsr2a69rfSdQuka7rX2d8pwEUhRnQzF/pdniCdV2m+JAgwnm2nXIHxiA2JWCS lhh/X0C5/55naCm+XuGFAYYKBK8rtXjjSiHM7nTawynmAZEL+3HMQYTmSwsL+YAssl8BLQSihY25H jn/9bOSXkIVcnVHyoanY2a+x/xtDGfqnBACMLkl4PJO8FCMOBHAwEqUn9IdDO490SGrNfVjlvMVHB s6zICKjUntqz5kYXQRO4kg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouFxA-0000CI-A4; Sun, 13 Nov 2022 11:35:36 -0500 Date: Sun, 13 Nov 2022 18:35:37 +0200 Message-Id: <83bkpalsme.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87a64vvtyh.fsf@posteo.net> (message from Philip Kaludercic on Sun, 13 Nov 2022 13:56:38 +0000) Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> <87sfisedkk.fsf@posteo.net> <87educytij.fsf@melete.silentflame.com> <87iljo9g1h.fsf@posteo.net> <875yfnzw14.fsf@melete.silentflame.com> <87v8nm5zzp.fsf@posteo.net> <87pmduwdzs.fsf@melete.silentflame.com> <87bkpexaqh.fsf@posteo.net> <87wn81us9q.fsf@melete.silentflame.com> <87a64vvtyh.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org, spwhitton@spwhitton.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 58383@debbugs.gnu.org > From: Philip Kaludercic > Date: Sun, 13 Nov 2022 13:56:38 +0000 > > --- a/lisp/vc/vc.el > +++ b/lisp/vc/vc.el > @@ -3391,14 +3391,24 @@ vc-prepare-patch > as the default subject for the message (and it will be prompted > for when called interactively). Otherwise a separate message > will be composed for each revision, with SUBJECT derived from the > -invidividual commits. > - > -When invoked interactively in a Log View buffer with marked > -revisions, those revisions will be used." > +invidividual commits. When invoked with a numerical prefix > +argument, the last N revisions will be used. When invoked > +interactively in a Log View buffer with marked revisions, those > +revisions will be used." Can we take this opportunity to get rid of the passive voice and clarify the doc string, please? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 13 11:45:37 2022 Received: (at 58383) by debbugs.gnu.org; 13 Nov 2022 16:45:37 +0000 Received: from localhost ([127.0.0.1]:52419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouG6y-00034h-FA for submit@debbugs.gnu.org; Sun, 13 Nov 2022 11:45:36 -0500 Received: from mout02.posteo.de ([185.67.36.66]:50833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouG6v-00034U-Qm for 58383@debbugs.gnu.org; Sun, 13 Nov 2022 11:45:35 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 56343240105 for <58383@debbugs.gnu.org>; Sun, 13 Nov 2022 17:45:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668357928; bh=gEcL9C6188RGUdetXsgPTxjxRPnIOR3Si0kg2oDR7Ek=; h=From:To:Cc:Subject:Date:From; b=k/upJK4CMD06WqvE3OzsFuzv5qHy8gp9OZs3uB2DbOLq+VAY+6mgp/WnWTAXjbLLO qrcjZaY//YJHX2vGxRJxkfUMpB3ZTMwDPiYkVOLxIrQnlafsVdceI5p8qJM8/jqpN8 mEBVkKzfeo7OVSRueZr2Ery3LllSmEj9IPV82C13Tq745Bd9y5cFLJC2rqV2Pz90nJ xq0Pw1/9VdKfeNQYrQeTTUrpuxQojPSLVrkN1oDA5+fZR+BtUNuAORMMYn8oOEJvOo jTyJ4US8pSTR9Ji7eEUuksuaAGEOQKd0xN4bjHhoYh+7D9rCk9bn5EcSc5U65Ml/dG LcZKDfX6hOwSA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N9JGG4Qf9z6tmJ; Sun, 13 Nov 2022 17:45:26 +0100 (CET) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <83bkpalsme.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 13 Nov 2022 18:35:37 +0200") References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> <87sfisedkk.fsf@posteo.net> <87educytij.fsf@melete.silentflame.com> <87iljo9g1h.fsf@posteo.net> <875yfnzw14.fsf@melete.silentflame.com> <87v8nm5zzp.fsf@posteo.net> <87pmduwdzs.fsf@melete.silentflame.com> <87bkpexaqh.fsf@posteo.net> <87wn81us9q.fsf@melete.silentflame.com> <87a64vvtyh.fsf@posteo.net> <83bkpalsme.fsf@gnu.org> Date: Sun, 13 Nov 2022 16:45:26 +0000 Message-ID: <87fsemvm55.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org, spwhitton@spwhitton.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: > Can we take this opportunity to get rid of the passive voice and > clarify the doc string, please? Done: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Have-vc-prepare-patch-handle-prefix-arguments.patch >From 454c8c6ebb69c3cd3f671f7700ded14826492ce1 Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Sun, 13 Nov 2022 17:05:20 +0100 Subject: [PATCH] Have 'vc-prepare-patch' handle prefix arguments. * lisp/emacs-lisp/package-vc.el (package-vc-prepare-patch): Use 'vc-prepare-patch-prompt-revisions'. * lisp/vc/vc.el (vc-prepare-patch-prompt-revisions): Extract common function and handle prefix arguments. (vc-prepare-patch): Pull logic out to 'vc-prepare-patch-prompt-revisions'. --- lisp/emacs-lisp/package-vc.el | 14 +++++------ lisp/vc/vc.el | 47 ++++++++++++++++++++++++----------- 2 files changed, 39 insertions(+), 22 deletions(-) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index 664629d156..37ef35edad 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -733,17 +733,17 @@ package-vc-rebuild ;;;###autoload (defun package-vc-prepare-patch (pkg subject revisions) "Send patch for REVISIONS to maintainer of the package PKG using SUBJECT. -SUBJECT and REVISIONS are passed on to `vc-prepare-patch', which see. -PKG must be a package description. -Interactively, prompt for PKG, SUBJECT, and REVISIONS. However, -if the current buffer has marked commit log entries, REVISIONS -are the tags of the marked entries, see `log-view-get-marked'." +SUBJECT and REVISIONS are passed on to `vc-prepare-patch', which +see. PKG must be a package description. Interactively, prompt +for PKG, SUBJECT, and REVISIONS. When invoked with a numerical +prefix argument, the last N revisions will be used. When invoked +interactively in a Log View buffer with marked revisions, those +revisions will be used." (interactive (list (package-vc--read-package-desc "Package to prepare a patch for: " t) (and (not vc-prepare-patches-separately) (read-string "Subject: " "[PATCH] " nil nil t)) - (or (log-view-get-marked) - (vc-read-multiple-revisions "Revisions: ")))) + (vc-prepare-patch-prompt-revisions))) (vc-prepare-patch (package-maintainers pkg t) subject revisions)) diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 513fbb23fe..f71783db97 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -3384,25 +3384,42 @@ vc-default-prepare-patch (vc-root-dir)))) :buffer (current-buffer))))) +(defun vc-prepare-patch-prompt-revisions () + "Prompt the user for a list revisions. +Prepare a default value, depending on the current context. With +a numerical prefix argument, use the last N revisions as the +default value. If the current buffer is a log-view buffer, use +the marked commits. Otherwise fall back to the working revision +of the current file." + (vc-read-multiple-revisions + "Revisions: " nil nil nil + (or (and-let* ((arg current-prefix-arg) + (fs (vc-deduce-fileset t))) + (cl-loop with file = (caadr fs) + repeat (prefix-numeric-value arg) + for rev = (vc-working-revision file) + then (vc-call-backend + (car fs) 'previous-revision + file rev) + when rev collect it into revs + finally return (mapconcat #'identity revs ","))) + (and-let* ((revs (log-view-get-marked))) + (mapconcat #'identity revs ",")) + (and-let* ((file (buffer-file-name))) + (vc-working-revision file))))) + ;;;###autoload (defun vc-prepare-patch (addressee subject revisions) "Compose an Email sending patches for REVISIONS to ADDRESSEE. -If `vc-prepare-patches-separately' is nil, SUBJECT will be used -as the default subject for the message (and it will be prompted -for when called interactively). Otherwise a separate message -will be composed for each revision, with SUBJECT derived from the -invidividual commits. - -When invoked interactively in a Log View buffer with marked -revisions, those revisions will be used." +If `vc-prepare-patches-separately' is nil, use SUBJECT as the +default subject for the message, or prompt a subject when invoked +interactively. Otherwise compose a separate message for each +revision, with SUBJECT derived from each revision subject. When +invoked with a numerical prefix argument, use the last N +revisions. When invoked interactively in a Log View buffer with +marked revisions, use those these." (interactive - (let ((revs (vc-read-multiple-revisions - "Revisions: " nil nil nil - (or (and-let* ((revs (log-view-get-marked))) - (mapconcat #'identity revs ",")) - (and-let* ((file (buffer-file-name))) - (vc-working-revision file))))) - to) + (let ((revs (vc-prepare-patch-prompt-revisions)) to) (require 'message) (while (null (setq to (completing-read-multiple (format-prompt -- 2.35.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 13 11:52:10 2022 Received: (at 58383) by debbugs.gnu.org; 13 Nov 2022 16:52:10 +0000 Received: from localhost ([127.0.0.1]:52432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouGDJ-0003HD-Qz for submit@debbugs.gnu.org; Sun, 13 Nov 2022 11:52:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouGDH-0003Gy-K9 for 58383@debbugs.gnu.org; Sun, 13 Nov 2022 11:52:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouGDC-0000Og-Cl; Sun, 13 Nov 2022 11:52:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6I1v+1pC4rHVzua8i9y66GLNr+3FAMbsfv91X0Zkq6I=; b=R9GnszFDrQfW 7Fryel34tYW53W+I2k5qqWPyjzkF6HxDUNtcqkO3a0/lSN1GAwNbmoxYAHFIrljH5rw7A4d5HWwsb 8ZpnXrH9Ps9TnuYX7C0bN3d+S3uQgI63FH8lrYqrJom7uJVO/BQUCUgQ7LtPj7NWVv4z/EPEuYKGb QczTGbXikizAWs8eFO35+Qq4ANgSivRMYJXbLVvtI/4FsKPD5/27SD28LKU/UCdyvujAOW7dQ6oMY Upyod17bpoZPGJ6lm65K7F8fiye/LkGUoOu0uLsSGTw5OntSvzVFv1XjvJhxC1A9AcL0C2DzEC255 OhAJgOTIAf9Ebca5jlJ+QA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouGDB-0007mW-SQ; Sun, 13 Nov 2022 11:52:02 -0500 Date: Sun, 13 Nov 2022 18:52:11 +0200 Message-Id: <837czylrus.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87fsemvm55.fsf@posteo.net> (message from Philip Kaludercic on Sun, 13 Nov 2022 16:45:26 +0000) Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> <87sfisedkk.fsf@posteo.net> <87educytij.fsf@melete.silentflame.com> <87iljo9g1h.fsf@posteo.net> <875yfnzw14.fsf@melete.silentflame.com> <87v8nm5zzp.fsf@posteo.net> <87pmduwdzs.fsf@melete.silentflame.com> <87bkpexaqh.fsf@posteo.net> <87wn81us9q.fsf@melete.silentflame.com> <87a64vvtyh.fsf@posteo.net> <83bkpalsme.fsf@gnu.org> <87fsemvm55.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org, spwhitton@spwhitton.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: spwhitton@spwhitton.name, 58383@debbugs.gnu.org > Date: Sun, 13 Nov 2022 16:45:26 +0000 > > Eli Zaretskii writes: > > > Can we take this opportunity to get rid of the passive voice and > > clarify the doc string, please? > > Done: Thanks, and the same with package-vc-prepare-patch, please? Btw, this kind of reformatting: > -SUBJECT and REVISIONS are passed on to `vc-prepare-patch', which see. > -PKG must be a package description. > -Interactively, prompt for PKG, SUBJECT, and REVISIONS. However, > -if the current buffer has marked commit log entries, REVISIONS > -are the tags of the marked entries, see `log-view-get-marked'." > +SUBJECT and REVISIONS are passed on to `vc-prepare-patch', which > +see. PKG must be a package description. Interactively, prompt > +for PKG, SUBJECT, and REVISIONS. When invoked with a numerical > +prefix argument, the last N revisions will be used. When invoked > +interactively in a Log View buffer with marked revisions, those > +revisions will be used." is IMO for the worse: when the sentence starting with "Interactively" begins a new line, it stands out, which helps users find the most relevant parts faster. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 13 13:17:53 2022 Received: (at 58383) by debbugs.gnu.org; 13 Nov 2022 18:17:53 +0000 Received: from localhost ([127.0.0.1]:52508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouHYG-0007c3-W5 for submit@debbugs.gnu.org; Sun, 13 Nov 2022 13:17:53 -0500 Received: from mout02.posteo.de ([185.67.36.66]:46851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouHYE-0007bm-AL for 58383@debbugs.gnu.org; Sun, 13 Nov 2022 13:17:51 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 922F7240101 for <58383@debbugs.gnu.org>; Sun, 13 Nov 2022 19:17:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668363464; bh=2xx9TKghbHBCQuIrBGNkcXiQnHlCJR+A7PwOBn+mpZo=; h=From:To:Cc:Subject:Date:From; b=jKpwFhp46TtNQhWluxTYotzwHTMFuAdFr6ZRFLPOfKOmqM2x6GFnrPH3Ecq+oEz1D 3vVBIk6KLfAslcqQbj2tNqNBTtd3ZgvllRlUh6fVQOgxGBK4rFt1n/8fkhczBiIP80 VPRW9q9iL+5JwOzA071E3l8kStENCmU3Z6FWtPxuw9gCgiFpGEvIC9HUrMm2Arg/og wC1/Py6uq6XpLKKRXNPsUUL+Xiciflve7Ad86vXMRD7E1pNDLabAeW1vPwC0HHRcEk u7BfLPbDhdjbXgUVbP14tOY/bxXqH5jWV8E35nzQC7HoorkC6hJ7INUxKicf/dsk1d hcq6Y6Nh/1huw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N9LJl4Q1yz9rxG; Sun, 13 Nov 2022 19:17:43 +0100 (CET) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <837czylrus.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 13 Nov 2022 18:52:11 +0200") References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> <87sfisedkk.fsf@posteo.net> <87educytij.fsf@melete.silentflame.com> <87iljo9g1h.fsf@posteo.net> <875yfnzw14.fsf@melete.silentflame.com> <87v8nm5zzp.fsf@posteo.net> <87pmduwdzs.fsf@melete.silentflame.com> <87bkpexaqh.fsf@posteo.net> <87wn81us9q.fsf@melete.silentflame.com> <87a64vvtyh.fsf@posteo.net> <83bkpalsme.fsf@gnu.org> <87fsemvm55.fsf@posteo.net> <837czylrus.fsf@gnu.org> Date: Sun, 13 Nov 2022 18:17:43 +0000 Message-ID: <87edu6u3aw.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org, spwhitton@spwhitton.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: spwhitton@spwhitton.name, 58383@debbugs.gnu.org >> Date: Sun, 13 Nov 2022 16:45:26 +0000 >> >> Eli Zaretskii writes: >> >> > Can we take this opportunity to get rid of the passive voice and >> > clarify the doc string, please? >> >> Done: > > Thanks, and the same with package-vc-prepare-patch, please? > > Btw, this kind of reformatting: > >> -SUBJECT and REVISIONS are passed on to `vc-prepare-patch', which see. >> -PKG must be a package description. >> -Interactively, prompt for PKG, SUBJECT, and REVISIONS. However, >> -if the current buffer has marked commit log entries, REVISIONS >> -are the tags of the marked entries, see `log-view-get-marked'." >> +SUBJECT and REVISIONS are passed on to `vc-prepare-patch', which >> +see. PKG must be a package description. Interactively, prompt >> +for PKG, SUBJECT, and REVISIONS. When invoked with a numerical >> +prefix argument, the last N revisions will be used. When invoked >> +interactively in a Log View buffer with marked revisions, those >> +revisions will be used." > > is IMO for the worse: when the sentence starting with "Interactively" > begins a new line, it stands out, which helps users find the most > relevant parts faster. Addressed both issues here: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Have-vc-prepare-patch-handle-prefix-arguments.patch >From aeadd1555c4d75f63b0c115737d9f465534af687 Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Sun, 13 Nov 2022 17:05:20 +0100 Subject: [PATCH] Have 'vc-prepare-patch' handle prefix arguments. * lisp/emacs-lisp/package-vc.el (package-vc-prepare-patch): Use 'vc-prepare-patch-prompt-revisions'. * lisp/vc/vc.el (vc-prepare-patch-prompt-revisions): Extract common function and handle prefix arguments. (vc-prepare-patch): Pull logic out to 'vc-prepare-patch-prompt-revisions'. --- lisp/emacs-lisp/package-vc.el | 18 ++++++------- lisp/vc/vc.el | 48 ++++++++++++++++++++++++----------- 2 files changed, 42 insertions(+), 24 deletions(-) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index 664629d156..156e7576f6 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -731,20 +731,20 @@ package-vc-rebuild (package-vc--unpack-1 pkg-desc (package-desc-dir pkg-desc))) ;;;###autoload -(defun package-vc-prepare-patch (pkg subject revisions) +(defun package-vc-prepare-patch (pkg-desc subject revisions) "Send patch for REVISIONS to maintainer of the package PKG using SUBJECT. -SUBJECT and REVISIONS are passed on to `vc-prepare-patch', which see. -PKG must be a package description. -Interactively, prompt for PKG, SUBJECT, and REVISIONS. However, -if the current buffer has marked commit log entries, REVISIONS -are the tags of the marked entries, see `log-view-get-marked'." +The function uses `vc-prepare-patch', passing SUBJECT and +REVISIONS directly. PKG-DESC must be a package description. +Interactively, prompt for PKG-DESC, SUBJECT, and REVISIONS. When +invoked with a numerical prefix argument, use the last N +revisions. When invoked interactively in a Log View buffer with +marked revisions, use those." (interactive (list (package-vc--read-package-desc "Package to prepare a patch for: " t) (and (not vc-prepare-patches-separately) (read-string "Subject: " "[PATCH] " nil nil t)) - (or (log-view-get-marked) - (vc-read-multiple-revisions "Revisions: ")))) - (vc-prepare-patch (package-maintainers pkg t) + (vc-prepare-patch-prompt-revisions))) + (vc-prepare-patch (package-maintainers pkg-desc t) subject revisions)) (provide 'package-vc) diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 513fbb23fe..2314672bb8 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -3384,25 +3384,43 @@ vc-default-prepare-patch (vc-root-dir)))) :buffer (current-buffer))))) +(defun vc-prepare-patch-prompt-revisions () + "Prompt the user for a list revisions. +Prepare a default value, depending on the current context. With +a numerical prefix argument, use the last N revisions as the +default value. If the current buffer is a log-view buffer, use +the marked commits. Otherwise fall back to the working revision +of the current file." + (vc-read-multiple-revisions + "Revisions: " nil nil nil + (or (and-let* ((arg current-prefix-arg) + (fs (vc-deduce-fileset t))) + (cl-loop with file = (caadr fs) + repeat (prefix-numeric-value arg) + for rev = (vc-working-revision file) + then (vc-call-backend + (car fs) 'previous-revision + file rev) + when rev collect it into revs + finally return (mapconcat #'identity revs ","))) + (and-let* ((revs (log-view-get-marked))) + (mapconcat #'identity revs ",")) + (and-let* ((file (buffer-file-name))) + (vc-working-revision file))))) + ;;;###autoload (defun vc-prepare-patch (addressee subject revisions) "Compose an Email sending patches for REVISIONS to ADDRESSEE. -If `vc-prepare-patches-separately' is nil, SUBJECT will be used -as the default subject for the message (and it will be prompted -for when called interactively). Otherwise a separate message -will be composed for each revision, with SUBJECT derived from the -invidividual commits. - -When invoked interactively in a Log View buffer with marked -revisions, those revisions will be used." +If `vc-prepare-patches-separately' is nil, use SUBJECT as the +default subject for the message, or prompt a subject when invoked +interactively. Otherwise compose a separate message for each +revision, with SUBJECT derived from each revision subject. +When invoked with a numerical prefix argument, use the last N +revisions. +When invoked interactively in a Log View buffer with +marked revisions, use those these." (interactive - (let ((revs (vc-read-multiple-revisions - "Revisions: " nil nil nil - (or (and-let* ((revs (log-view-get-marked))) - (mapconcat #'identity revs ",")) - (and-let* ((file (buffer-file-name))) - (vc-working-revision file))))) - to) + (let ((revs (vc-prepare-patch-prompt-revisions)) to) (require 'message) (while (null (setq to (completing-read-multiple (format-prompt -- 2.35.1 --=-=-= Content-Type: text/plain That being said, the patch now relies on changes made in scratch/package-vc-fixes. I can "backport" it onto master, or push it in a few days when the issues related to that branch are resolved. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 14 07:41:55 2022 Received: (at 58383) by debbugs.gnu.org; 14 Nov 2022 12:41:55 +0000 Received: from localhost ([127.0.0.1]:49088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouYmh-0007FI-4M for submit@debbugs.gnu.org; Mon, 14 Nov 2022 07:41:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouYme-0007F6-Sn for 58383@debbugs.gnu.org; Mon, 14 Nov 2022 07:41:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouYmZ-0002V3-50; Mon, 14 Nov 2022 07:41:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GvSN/8UBB8NnzAnpuRWupGAEaffB2mxauP3jFOg+DG0=; b=ntgZCZK/yJbN BV6RGLdZy3pX7qg6XsYRnASPUX5jh9NZpF6IBSwQRZcodvEEVyNaXKf/KjzAoIxJagCMxDNdPH3VR bH9vR6XYEQy8yxyfUk1222gdWjsN6obS21lBn9w0DmTmJq5uFUb0O/disP0kJt0rIun+VKGNUcIDc NjOuqm23+Mj4x3fOHnrLT+aGPPzRPcGW9Owry4Rs8RfK6pPsskKDQ3KLAmojH6IDDefgkcPNIQ+7y NtDy1OvgbFVSUUMrj/Nu//7RXJRbx3wzAA7+X/gHwJvQ8DHgoUGNL1jFZ6+bAdZCMa6HII8hX8nEf tiCQDdFAJudqlOd2m1H0QA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouYmW-0003Et-I5; Mon, 14 Nov 2022 07:41:46 -0500 Date: Mon, 14 Nov 2022 14:41:55 +0200 Message-Id: <83pmdpk8rw.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87edu6u3aw.fsf@posteo.net> (message from Philip Kaludercic on Sun, 13 Nov 2022 18:17:43 +0000) Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> <87sfisedkk.fsf@posteo.net> <87educytij.fsf@melete.silentflame.com> <87iljo9g1h.fsf@posteo.net> <875yfnzw14.fsf@melete.silentflame.com> <87v8nm5zzp.fsf@posteo.net> <87pmduwdzs.fsf@melete.silentflame.com> <87bkpexaqh.fsf@posteo.net> <87wn81us9q.fsf@melete.silentflame.com> <87a64vvtyh.fsf@posteo.net> <83bkpalsme.fsf@gnu.org> <87fsemvm55.fsf@posteo.net> <837czylrus.fsf@gnu.org> <87edu6u3aw.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58383 Cc: 58383@debbugs.gnu.org, spwhitton@spwhitton.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: spwhitton@spwhitton.name, 58383@debbugs.gnu.org > Date: Sun, 13 Nov 2022 18:17:43 +0000 > > Addressed both issues here: Thanks! From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 15 19:04:23 2022 Received: (at 58383) by debbugs.gnu.org; 16 Nov 2022 00:04:23 +0000 Received: from localhost ([127.0.0.1]:55529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ov5uh-0006hX-4q for submit@debbugs.gnu.org; Tue, 15 Nov 2022 19:04:23 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:49617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ov5ub-0006hA-Of for 58383@debbugs.gnu.org; Tue, 15 Nov 2022 19:04:21 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B590F5C020A; Tue, 15 Nov 2022 19:04:11 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 15 Nov 2022 19:04:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1668557051; x=1668643451; bh=tJ A6+5fdGW4hEG0d89K+yfoU5asD1TEtLpdcHATyoIw=; b=EOh2sfUSXycL1qdWHb fs2cChtMUhMYEcBEHBdd3XR+WylQdzYyKHqYJuV1OR2bwutwHYPcVSgLanMH8MFD XucQ7BcEMLhUQej9JaNxRSmLQcA57tebqd9CyhFZQNe5lRXYB2PddQ/ELT9rCWXX Gsle4+VJGrzEvG6S+ShXcZb6v47ojhQTWNYSkE0HfSI6at3H/5IZnZlIXYpQL2xc YHHyiOn18M8vGd/RUy4mLqbbKzzZ3j5Q9DtCXZFOMW0bW0KkSwEA2qnumRE1zk0Q qoGJFtV/9Up+1qhPt2ziTFbPFIObf280KD8zI0rm8XDnkF7sm86TtmASg5/5d7WB sokA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668557051; x=1668643451; bh=tJA6+5fdGW4hEG0d89K+yfoU5asD 1TEtLpdcHATyoIw=; b=ZQCEq0EC7sLywXK1bVE8rp8hYOuXKSYsfsTEdNOpbcJ5 IiGitT51eyJb+OLnUknEy+9S+Xirk5BqF/h3gH5jesLY0J5B1615SGBmlWWpHdL1 L7kLv42t0wT0WHf5KowSW4o/qcTC1FlTVj3S3WaPRlOySk5D7rmn78LNf1MGireR MuF+BV6wjXtPOS5B3CYqcgJwK4PTkOvFljVBpvolYz/GlpzQSAjPrGcYJIBJcHoH TcmX8MW+9UYOTJMeThEg70EYafRJRg+bd2yMRAoORBJCVCoYa5j/LyFHmFbxzlTC lXoprbEfVjLCiRIQF40FDOMGJgn/38exQUPqxKrglg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgeehgddujecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedukeeg geelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Nov 2022 19:04:11 -0500 (EST) Received: by melete.silentflame.com (Postfix, from userid 1000) id 2FDA77E8314; Tue, 15 Nov 2022 17:04:10 -0700 (MST) From: Sean Whitton To: Philip Kaludercic Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <87edu6u3aw.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 13 Nov 2022 18:17:43 +0000") References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> <87sfisedkk.fsf@posteo.net> <87educytij.fsf@melete.silentflame.com> <87iljo9g1h.fsf@posteo.net> <875yfnzw14.fsf@melete.silentflame.com> <87v8nm5zzp.fsf@posteo.net> <87pmduwdzs.fsf@melete.silentflame.com> <87bkpexaqh.fsf@posteo.net> <87wn81us9q.fsf@melete.silentflame.com> <87a64vvtyh.fsf@posteo.net> <83bkpalsme.fsf@gnu.org> <87fsemvm55.fsf@posteo.net> <837czylrus.fsf@gnu.org> <87edu6u3aw.fsf@posteo.net> Date: Tue, 15 Nov 2022 17:04:10 -0700 Message-ID: <87leobrchx.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 58383 Cc: Eli Zaretskii , 58383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Just based on reviewing the docstrings, lgtm. Thank you for your interest in my idea. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 16 02:50:31 2022 Received: (at 58383-done) by debbugs.gnu.org; 16 Nov 2022 07:50:31 +0000 Received: from localhost ([127.0.0.1]:55905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovDBn-0003qN-2P for submit@debbugs.gnu.org; Wed, 16 Nov 2022 02:50:31 -0500 Received: from mout01.posteo.de ([185.67.36.65]:47563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovDBk-0003q6-8u for 58383-done@debbugs.gnu.org; Wed, 16 Nov 2022 02:50:28 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id B3EBF240033 for <58383-done@debbugs.gnu.org>; Wed, 16 Nov 2022 08:50:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668585022; bh=hGXDPWF1mesEbxVyzwGUnL59WAKlBlJV6NvtN8rD6Rk=; h=From:To:Cc:Subject:Date:From; b=ExkykTDs5tVGpgcxM1+Vt8IJfwcNSefykBiBiKaBwGOCgsgjFmHkXtCtAckx9Mf+F 4XwyknL3zQxJMxqewjfuZuzjXi1DL2k6o+vjhV7JAJuj1zM5lHUlpX+UFLk6ifZxjM o9aTX91pGm5AcTtgjlMorJHoMoYXl5BHKkWNtqGvZD47AbavfaXXvjkTuoM3rkwKRX ugYAouY9D+MY2Pu8TY0SIfUoDku3V3D3ulCXCKlBbBci5g3vpmI0nlSIWcAhV6eTwj 840WHIsxFMBBianHAFvyTSyMFDp3njcT0rLvuFmplyo46GINYBpwcw21PLQKMblRUo xzupU9yKiaFHg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NBwFT4LXjz6tqF; Wed, 16 Nov 2022 08:50:21 +0100 (CET) From: Philip Kaludercic To: Sean Whitton Subject: Re: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately In-Reply-To: <87leobrchx.fsf@melete.silentflame.com> (Sean Whitton's message of "Tue, 15 Nov 2022 17:04:10 -0700") References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> <87sfisedkk.fsf@posteo.net> <87educytij.fsf@melete.silentflame.com> <87iljo9g1h.fsf@posteo.net> <875yfnzw14.fsf@melete.silentflame.com> <87v8nm5zzp.fsf@posteo.net> <87pmduwdzs.fsf@melete.silentflame.com> <87bkpexaqh.fsf@posteo.net> <87wn81us9q.fsf@melete.silentflame.com> <87a64vvtyh.fsf@posteo.net> <83bkpalsme.fsf@gnu.org> <87fsemvm55.fsf@posteo.net> <837czylrus.fsf@gnu.org> <87edu6u3aw.fsf@posteo.net> <87leobrchx.fsf@melete.silentflame.com> Date: Wed, 16 Nov 2022 07:50:21 +0000 Message-ID: <87edu38hj6.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58383-done Cc: Eli Zaretskii , 58383-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Sean Whitton writes: > Hello, > > Just based on reviewing the docstrings, lgtm. Thank you for your > interest in my idea. Great, I'll close the issue then. The patch will be pushed along with some package-vc related changes in the next new days. From unknown Wed Jun 18 23:18:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 14 Dec 2022 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator