From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 08 12:51:07 2022 Received: (at submit) by debbugs.gnu.org; 8 Oct 2022 16:51:07 +0000 Received: from localhost ([127.0.0.1]:41358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohD2Y-0002X9-Oa for submit@debbugs.gnu.org; Sat, 08 Oct 2022 12:51:06 -0400 Received: from lists.gnu.org ([209.51.188.17]:33364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohD2T-0002Wm-TI for submit@debbugs.gnu.org; Sat, 08 Oct 2022 12:51:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohD2T-0005bw-N0 for guix-patches@gnu.org; Sat, 08 Oct 2022 12:51:01 -0400 Received: from mail.mmer.org ([178.22.65.174]:52742) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohD2S-0006kg-3M for guix-patches@gnu.org; Sat, 08 Oct 2022 12:51:01 -0400 Received: from mail.mmer.org (localhost [127.0.0.1]) by mail.mmer.org (OpenSMTPD) with ESMTP id 95e04c34 for ; Sat, 8 Oct 2022 16:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=mmer.org; h=from:to :subject:date:message-id:mime-version:content-transfer-encoding; s=dkim; bh=jza6BdWodyh/gbwewJySylTwgmdnoSeofGhJ0YxPQvY=; b=qs3+ Q23uPLbHp8PUR6X2lUzuPHWpX4vRB1GuL2+Ei53M0y9TI8X5d8Mzd29hPd6AFqBM ZDQrZYaq2kUYIPCsu3JGcgG8JPXrjJg+/R3TZLCLaSh4SRDHpvR+OVbIo9+1DZAw l+ImVPPh6fk5sSvdqBd8rOR05KWVq+Vb5jxit8M= Received: from delta (j74210.upc-j.chello.nl [24.132.74.210]) by mail.mmer.org (OpenSMTPD) with ESMTPSA id 7459747d (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Sat, 8 Oct 2022 16:50:54 +0000 (UTC) From: Alexey Abramov To: guix-patches@gnu.org Subject: [PATCH 0/3] guile-netlink: Add support for bonds Date: Sat, 8 Oct 2022 18:50:43 +0200 Message-Id: <20221008165043.13177-1-levenson@mmer.org> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=178.22.65.174; envelope-from=levenson@mmer.org; helo=mail.mmer.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) With these patches, guile-netlink can be used to build bonds. bond-type-args function accepts keys that people would be set to bond interfaces via 'ip link set'. 'ip link help bond' shows the list of all passable settings. Only few of them are implemented right now. Master field was also added to 'link-set' in order to bind interfaces to their masters in case of bonding. Alexey Abramov (3): link: Pass correct attribute and a payload to rename a link link: Allow to bound interfaces to bonds link: Add partial support for bond interfaces ip/link.scm | 77 ++++++++++++++++++++++++++++++++++++++++++-- netlink/constant.scm | 30 +++++++++++++++++ 2 files changed, 104 insertions(+), 3 deletions(-) -- 2.36.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 08 12:53:34 2022 Received: (at 58382) by debbugs.gnu.org; 8 Oct 2022 16:53:34 +0000 Received: from localhost ([127.0.0.1]:41364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohD4w-0002ba-6f for submit@debbugs.gnu.org; Sat, 08 Oct 2022 12:53:34 -0400 Received: from mail.mmer.org ([178.22.65.174]:45374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohD4u-0002bF-1L for 58382@debbugs.gnu.org; Sat, 08 Oct 2022 12:53:32 -0400 Received: from mail.mmer.org (localhost [127.0.0.1]) by mail.mmer.org (OpenSMTPD) with ESMTP id feee73c9 for <58382@debbugs.gnu.org>; Sat, 8 Oct 2022 16:53:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=mmer.org; h=from:to :subject:date:message-id:mime-version:content-transfer-encoding; s=dkim; bh=x5/o+8BrNNeLuOAu/59OfR/mOLWzb83Jrw3mWhBPIV4=; b=u3xa ycJOtyYMHDFK2I0xnU6iusHaICXAp58ZPCTLB3dztJO3NpDOIK9Ou56yHqLlIXqm FdPodkeN4QumsxoKs3p05i4rlFs0p7CFCNsLxv0GligYXePIrqArp1kkBO5oZO7U QLiY0cSo0IqSn9T+Na3+t+XsilBU6EITuQCHXf8= Received: from delta (j74210.upc-j.chello.nl [24.132.74.210]) by mail.mmer.org (OpenSMTPD) with ESMTPSA id 889eb1da (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for <58382@debbugs.gnu.org>; Sat, 8 Oct 2022 16:53:26 +0000 (UTC) From: Alexey Abramov To: 58382@debbugs.gnu.org Subject: [PATCH 1/3] link: Pass correct attribute and a payload to rename a link Date: Sat, 8 Oct 2022 18:53:12 +0200 Message-Id: <20221008165314.14056-1-levenson@mmer.org> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58382 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * ip/link.scm(link-set): Send IFLA_IFNAME attribute with a new desired interfaces name. --- ip/link.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ip/link.scm b/ip/link.scm index ecd1072..521cffa 100644 --- a/ip/link.scm +++ b/ip/link.scm @@ -211,8 +211,8 @@ criteria." '()) ,@(if name (list - (make-route-attr IFLA_TXQLEN - (make-u32-route-attr txqueuelen))) + (make-route-attr IFLA_IFNAME + (make-string-route-attr name))) '()) ,@(if address (list -- 2.36.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 08 12:53:36 2022 Received: (at 58382) by debbugs.gnu.org; 8 Oct 2022 16:53:36 +0000 Received: from localhost ([127.0.0.1]:41367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohD4y-0002bt-HP for submit@debbugs.gnu.org; Sat, 08 Oct 2022 12:53:36 -0400 Received: from mail.mmer.org ([178.22.65.174]:45374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohD4v-0002bF-6m for 58382@debbugs.gnu.org; Sat, 08 Oct 2022 12:53:33 -0400 Received: from mail.mmer.org (localhost [127.0.0.1]) by mail.mmer.org (OpenSMTPD) with ESMTP id b740648e for <58382@debbugs.gnu.org>; Sat, 8 Oct 2022 16:53:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=mmer.org; h=from:to :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; s=dkim; bh=5zmk2sw9V8vlz1bQZian6GCwN nfeAZtbQGdrH9a98iM=; b=xCdBuwBWenk2hIvboCF/1IoFCOLNaO5DF90u1ayUl 5mae1rVZH2crsns3e4AIGFuvCGeV3WKvG8vJCxIhmcPFHgnBrRIrbg9Io4GOJ/Dk 6VY6E+OOZGi7S19EDhxfHogvLfmD0GzsBmoXK9Hethv2uOY584pBccpg97thMT4c E0= Received: from delta (j74210.upc-j.chello.nl [24.132.74.210]) by mail.mmer.org (OpenSMTPD) with ESMTPSA id e18c368c (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for <58382@debbugs.gnu.org>; Sat, 8 Oct 2022 16:53:26 +0000 (UTC) From: Alexey Abramov To: 58382@debbugs.gnu.org Subject: [PATCH 2/3] link: Allow to bound interfaces to bonds Date: Sat, 8 Oct 2022 18:53:13 +0200 Message-Id: <20221008165314.14056-2-levenson@mmer.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20221008165314.14056-1-levenson@mmer.org> References: <20221008165314.14056-1-levenson@mmer.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58382 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * ip/link.scm (link-set): Add new argument `master'. It is suppose to be a name of the master interface to which our current device has to be bound. --- ip/link.scm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ip/link.scm b/ip/link.scm index 521cffa..70ab79f 100644 --- a/ip/link.scm +++ b/ip/link.scm @@ -164,7 +164,8 @@ criteria." (trailers-on #f) (trailers-off #f) (carrier-on #f) (carrier-off #f) (txqueuelen #f) (name #f) (address #f) - (broadcast #f) (mtu #f) (netns #f)) + (broadcast #f) (mtu #f) (netns #f) + (master #f)) (define request-num (random 65535)) (define id (if (number? device) device (link-name->index device))) (define netnsfd (cond @@ -229,6 +230,11 @@ criteria." (make-route-attr IFLA_MTU (make-u32-route-attr mtu))) '()) + ,@(if master + (list + (make-route-attr IFLA_MASTER + (make-u32-route-attr (link-name->index master)))) + '()) ,@(if netns (list (make-route-attr IFLA_NET_NS_FD -- 2.36.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 08 12:53:37 2022 Received: (at 58382) by debbugs.gnu.org; 8 Oct 2022 16:53:37 +0000 Received: from localhost ([127.0.0.1]:41369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohD4y-0002bw-R4 for submit@debbugs.gnu.org; Sat, 08 Oct 2022 12:53:37 -0400 Received: from mail.mmer.org ([178.22.65.174]:45374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohD4w-0002bF-0F for 58382@debbugs.gnu.org; Sat, 08 Oct 2022 12:53:34 -0400 Received: from mail.mmer.org (localhost [127.0.0.1]) by mail.mmer.org (OpenSMTPD) with ESMTP id 8aea12e8 for <58382@debbugs.gnu.org>; Sat, 8 Oct 2022 16:53:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=mmer.org; h=from:to :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; s=dkim; bh=X6Rube3fSc60OJbqK4+UG6cI2 mkmuo8bU9tsRtqppfQ=; b=MF0vmEHLB8cRRZsUhlKE6C6ianEnlSDfZhJ0lvFeA j4k7vgh1LJ5buDi0qfkZP8TB78Oc3pST5P5GFagaH6hU0BkArSeHo0mscvK4n4dD HaAZn8M3KXdd/nahfFRIykdv/7ZMBDofpKupMgK50w+fziZF9pr6nf4IbL5T9dcB 9M= Received: from delta (j74210.upc-j.chello.nl [24.132.74.210]) by mail.mmer.org (OpenSMTPD) with ESMTPSA id f2037dae (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for <58382@debbugs.gnu.org>; Sat, 8 Oct 2022 16:53:26 +0000 (UTC) From: Alexey Abramov To: 58382@debbugs.gnu.org Subject: [PATCH 3/3] link: Add partial support for bond interfaces Date: Sat, 8 Oct 2022 18:53:14 +0200 Message-Id: <20221008165314.14056-3-levenson@mmer.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20221008165314.14056-1-levenson@mmer.org> References: <20221008165314.14056-1-levenson@mmer.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58382 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * ip/link.scm (link-add): Support specific arguments for `bond' type link. (bond-type-args): New function. Implement mode, miimon and lacp-rate configuration for bonds. (alist->keyword+value): New function. * netlink/constant.scm: Define bond specific information. Define constants for bond modes. --- ip/link.scm | 65 ++++++++++++++++++++++++++++++++++++++++++++ netlink/constant.scm | 30 ++++++++++++++++++++ 2 files changed, 95 insertions(+) diff --git a/ip/link.scm b/ip/link.scm index 70ab79f..f6144c0 100644 --- a/ip/link.scm +++ b/ip/link.scm @@ -249,6 +249,70 @@ criteria." (close-socket sock) (answer-ok? (last answer))))) +(define* (bond-type-args #:key (mode #f) (miimon #f) (lacp-active #f) (lacp-rate #f) + (primary #f) (primary-reselect #f)) + `(,@(if mode + (list + (make-route-attr IFLA_BOND_MODE + (match mode + ("balance-rr" (make-u8-route-attr BOND_MODE_ROUNDROBIN)) + ("active-backup" (make-u8-route-attr BOND_MODE_ACTIVEBACKUP)) + ("balance-xor" (make-u8-route-attr BOND_MODE_XOR)) + ("broadcast" (make-u8-route-attr BOND_MODE_BROADCAST)) + ("802.3ad" (make-u8-route-attr BOND_MODE_8023AD)) + ("balance-tlb" (make-u8-route-attr BOND_MODE_TLB)) + ("balance-alb" (make-u8-route-attr BOND_MODE_ALB)) + (_ (raise (condition + (&message + (message "Bond field `mode' can be defined as balance-rr|active-backup|balance-xor|broadcast|802.3ad|balance-tlb|balance-alb" )))))))) + '()) + ,@(if miimon + (list + (make-route-attr IFLA_BOND_MIIMON + (make-u32-route-attr miimon))) + '()) + ,@(if primary + (list + (make-route-attr IFLA_BOND_PRIMARY + (make-u32-route-attr (link-name->index primary)))) + '()) + ,@(if primary-reselect + (list + (make-route-attr IFLA_BOND_PRIMARY_RESELECT + (match primary-reselect + ("always" (make-u8-route-attr BOND_PRIMARY_RESELECT_ALWAYS)) + ("better" (make-u8-route-attr BOND_PRIMARY_RESELECT_BETTER)) + ("failure" (make-u8-route-attr BOND_PRIMARY_RESELECT_FAILURE)) + (_ (raise (condition + (&message + (message "Bond field `primary-reselect' can be defined as always|better|failure" )))))))) + '()) + ,@(if lacp-active + (list + (make-route-attr IFLA_BOND_AD_LACP_ACTIVE + (match lacp-active + ("on" (make-u8-route-attr BOND_AD_LACP_ACTIVE_ON)) + ("off" (make-u8-route-attr BOND_AD_LACP_ACTIVE_OFF)) + (_ (raise (condition + (&message + (message "Bond field `lacp-active' can be defined as off|on" )))))))) + '()) + ,@(if lacp-rate + (list + (make-route-attr IFLA_BOND_AD_LACP_RATE + (match lacp-rate + ("slow" (make-u8-route-attr 0)) + ("fast" (make-u8-route-attr 1)) + (_ (raise (condition + (&message + (message "Bond field `lacp-rate' can be defined as slow|fast")))))))) + '()))) + +(define (alist->keyword+value alist) + (fold (match-lambda* + (((k . v) r) + (cons* (symbol->keyword k) v r))) '() alist)) + (define* (link-add name type #:key (type-args '())) (define request-num (random 65535)) (define type-data @@ -268,6 +332,7 @@ criteria." (make-string-route-attr (assoc-ref type-args 'peer))))))) '()))) + ("bond" (apply bond-type-args (alist->keyword+value type-args))) ;; TODO: unsupported for now (_ '()))) (define message diff --git a/netlink/constant.scm b/netlink/constant.scm index ce5e15e..7c72fc1 100644 --- a/netlink/constant.scm +++ b/netlink/constant.scm @@ -82,6 +82,36 @@ IFLA_VLAN_UNSPEC IFLA_VLAN_ID IFLA_VLAN_FLAGS IFLA_VLAN_EGRESS_QOS IFLA_VLAN_INGRESS_QOS IFLA_VLAN_PROTOCOL) +(define-enum int->bond-linkinfo + IFLA_BOND_UNSPEC IFLA_BOND_MODE IFLA_BOND_ACTIVE_SLAVE IFLA_BOND_MIIMON + IFLA_BOND_UPDELAY IFLA_BOND_DOWNDELAY IFLA_BOND_USE_CARRIER IFLA_BOND_ARP_INTERVAL + IFLA_BOND_ARP_IP_TARGET IFLA_BOND_ARP_VALIDATE IFLA_BOND_ARP_ALL_TARGETS + IFLA_BOND_PRIMARY IFLA_BOND_PRIMARY_RESELECT IFLA_BOND_FAIL_OVER_MAC IFLA_BOND_XMIT_HASH_POLICY + IFLA_BOND_RESEND_IGMP IFLA_BOND_NUM_PEER_NOTIF IFLA_BOND_ALL_SLAVES_ACTIVE + IFLA_BOND_MIN_LINKS IFLA_BOND_LP_INTERVAL IFLA_BOND_PACKETS_PER_SLAVE + IFLA_BOND_AD_LACP_RATE IFLA_BOND_AD_SELECT IFLA_BOND_AD_INFO IFLA_BOND_AD_ACTOR_SYS_PRIO + IFLA_BOND_AD_USER_PORT_KEY IFLA_BOND_AD_ACTOR_SYSTEM IFLA_BOND_TLB_DYNAMIC_LB + IFLA_BOND_PEER_NOTIF_DELAY IFLA_BOND_AD_LACP_ACTIVE IFLA_BOND_MISSED_MAX IFLA_BOND_NS_IP6_TARGET) + +;; see iproute2/ip/iplink_bond.c for mode_tbl +(define-public BOND_MODE_ROUNDROBIN 0) +(define-public BOND_MODE_ACTIVEBACKUP 1) +(define-public BOND_MODE_XOR 2) +(define-public BOND_MODE_BROADCAST 3) +(define-public BOND_MODE_8023AD 4) +(define-public BOND_MODE_TLB 5) +;; TLB + RLB (receive load balancing) +(define-public BOND_MODE_ALB 6) + +;; see iproute2/ip/iplink_bond.c primary_reselect_tbl +(define-public BOND_PRIMARY_RESELECT_ALWAYS 0) +(define-public BOND_PRIMARY_RESELECT_BETTER 1) +(define-public BOND_PRIMARY_RESELECT_FAILURE 2) + +;; see iproute2/ip/iplink_bond.c for lacp_active_tbl +(define-public BOND_AD_LACP_ACTIVE_OFF 0) +(define-public BOND_AD_LACP_ACTIVE_ON 1) + (define-enum int->addr-attr-kind IFA_UNSPEC IFA_ADDRESS IFA_LOCAL IFA_LABEL IFA_BROADCAST IFA_ANYCAST IFA_CACHEINFO IFA_MULTICAST IFA_FLAGS -- 2.36.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 09 09:45:31 2022 Received: (at 58382-done) by debbugs.gnu.org; 9 Oct 2022 13:45:31 +0000 Received: from localhost ([127.0.0.1]:42336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohWcU-0004xK-NS for submit@debbugs.gnu.org; Sun, 09 Oct 2022 09:45:30 -0400 Received: from lepiller.eu ([89.234.186.109]:56378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohWcR-0004xB-Vi for 58382-done@debbugs.gnu.org; Sun, 09 Oct 2022 09:45:28 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 3575c3c6; Sun, 9 Oct 2022 13:45:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=SpJQsq6FewPR e0Im/dJEIlvrNeeAy8w7FsYyfjoe018=; b=L1HeQmu0MetRHLbHAzXXY+sdslk9 gU53Iq4mPMcyYoeFvqPUnsmh4e81ps+kDfUz9Ww206ZT36u5wUBsta0GBxyBL9oo ajf/KpV+jLKWGgpfsqnv9IN/JCsfaYKZLPfWO8FpaCCqBvWR2h58qn7Kscjw+glr VLLrfsDzuTsfaQuXtu8PWvlmIB0O9FE+tiUu4Mrb+ZQMA119XGsRMB2Q3q1QQ3nm y0Z9zs7gzm5gTX8vZMyiYsW0vl3uTG8p6ejXGN+K3JeqAmwOYfymGPEsQZ5NDdTC GiMUFJdKFDNYbxt2mjsi6THS3N501VSIkfTSBgUR080exkU3h57wBqKaOQ== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 690e8cbe (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sun, 9 Oct 2022 13:45:25 +0000 (UTC) Date: Sun, 9 Oct 2022 15:45:09 +0200 From: Julien Lepiller To: Alexey Abramov Subject: Re: [bug#58382] [PATCH 0/3] guile-netlink: Add support for bonds Message-ID: <20221009154509.424df1c8@sybil.lepiller.eu> In-Reply-To: <20221008165043.13177-1-levenson@mmer.org> References: <20221008165043.13177-1-levenson@mmer.org> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58382-done Cc: 58382-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Le Sat, 8 Oct 2022 18:50:43 +0200, Alexey Abramov via Guix-patches via a =C3=A9crit : > With these patches, guile-netlink can be used to build bonds. > bond-type-args function accepts keys that people would be set to bond > interfaces via 'ip link set'. 'ip link help bond' shows the list of > all passable settings. Only few of them are implemented right now. >=20 > Master field was also added to 'link-set' in order to bind interfaces > to their masters in case of bonding. >=20 > Alexey Abramov (3): > link: Pass correct attribute and a payload to rename a link > link: Allow to bound interfaces to bonds > link: Add partial support for bond interfaces >=20 > ip/link.scm | 77 > ++++++++++++++++++++++++++++++++++++++++++-- netlink/constant.scm | > 30 +++++++++++++++++ 2 files changed, 104 insertions(+), 3 > deletions(-) >=20 Thanks, applied to guile-netlink :) I adjusted the commit messages a bit, and used define-enum for bond mode. I didn't test though, so I hope it works :) From unknown Tue Jun 17 22:21:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 07 Nov 2022 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator