From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 08 08:08:46 2022 Received: (at submit) by debbugs.gnu.org; 8 Oct 2022 12:08:46 +0000 Received: from localhost ([127.0.0.1]:38488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oh8dK-0000Qw-18 for submit@debbugs.gnu.org; Sat, 08 Oct 2022 08:08:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:37256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oh8dI-0000Qp-3s for submit@debbugs.gnu.org; Sat, 08 Oct 2022 08:08:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oh8dH-000086-Ue for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2022 08:08:43 -0400 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:36751) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oh8dG-0007Rq-3k for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2022 08:08:43 -0400 Received: by mail-pl1-x641.google.com with SMTP id c24so6721491plo.3 for ; Sat, 08 Oct 2022 05:08:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=tP+iEiX/0EWIAzbcQGPsetrbcgvwhRz1M1B3lypbfUE=; b=mI+9OAmCTdsjk7TKPVuWaJuyqjGtfRbVgi46pP+4A8krH4QnHIKUajoNV8JyuozYr4 VBuFXOCe4ZQMArd3L7Kgpwe54Z4TXR6fLRCA8h9vMlFW+VlIFZtr/JI0jfP4SfDdMmqh hmxIlNc5e4GxDF7TB7TUSqmVrqo1pRUlVEkO/2HiN+ae/2ltb+v/0Ckf35zEYfoqtP95 u4XwfWcUGjemYk8ezmhEJ8PQL14cnnz3QTlDCxcw+hZMVkcOFSbvvkiOc3adAClFmELC n+VqYWMbQE3gVoYoV/1dkJM/uy0/1IF5Im92CRXEXjN63oo4fRxibK/a2IIDk5IN9N2h 85EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tP+iEiX/0EWIAzbcQGPsetrbcgvwhRz1M1B3lypbfUE=; b=1E7FA7E9cwj1WfWiQFPFKFFf3tA1DCnDl/Q4kLoHOF0dOc41V6lgaWVvg9Ox1KLyMT ubuzKQzzB3RHM8kJQDUg1ci4VU3g2KSAa4mKavovYGIUxWLC2iJ/UuXL3JR5DyI8XZ/H ddQv19m7S6kMnTim8qE1Bm74jtESLW+GgdjX3B6yCsPe4isXocwn7sAH87l1RY83Bevb 1tDwcbxAhf3xT76F4JKNxPaawS2+qYIvIN9/R6HYfJO45JBLn/nQbEMh/RTLGsjdDHnf G9EngMryVjmKNC5OZxJ/HUX577ybjUmTwINybEhAJJIWB3ZDOuNQDSEJ4yKoKpwBnF2w riPQ== X-Gm-Message-State: ACrzQf18EKTb3lxst8SGnB66UQ+MOnuTK6h4++yN3AjoAteBBb10/cKf zAJr7Ks5eyhrSGgyjRP4ZaqMuMX9U2I= X-Google-Smtp-Source: AMsMyM514v+4sgx3ogp1Aqq2eRKIQWIVp268Fimn1jBfqrhc8QEAgnDbowLnVThRHOwYtHq2I+lSiQ== X-Received: by 2002:a17:902:ce85:b0:181:33f0:f60b with SMTP id f5-20020a170902ce8500b0018133f0f60bmr1675631plg.174.1665230919679; Sat, 08 Oct 2022 05:08:39 -0700 (PDT) Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id n15-20020a170902e54f00b001785fa792f4sm3226787plf.243.2022.10.08.05.08.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Oct 2022 05:08:38 -0700 (PDT) From: Visuwesh To: bug-gnu-emacs@gnu.org Subject: [PATCH] Fix misleading prompt in vc-git-create-tag Date: Sat, 08 Oct 2022 17:38:36 +0530 Message-ID: <87bkqmbjqz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::641; envelope-from=visuweshm@gmail.com; helo=mail-pl1-x641.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Tags: patch The prompt shows a default value but it is not actually passed to vc-read-revision. Attached patch fixes that. In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, Motif Version 2.3.8, cairo version 1.16.0) of 2022-10-06 built on astatine Repository revision: e1d63eda4be2e2de8f1610fb76a1e0eec67a6c42 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Debian GNU/Linux bookworm/sid Configured using: 'configure --with-x-toolkit=motif' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Fix-misleading-prompt-in-vc-git-create-tag.patch >From 404f1715f155d1ffb9ea65cf17bf4e5aa1b7bbd5 Mon Sep 17 00:00:00 2001 From: Visuwesh Date: Sat, 8 Oct 2022 17:37:16 +0530 Subject: [PATCH] Fix misleading prompt in vc-git-create-tag * lisp/vc/vc-git.el (vc-git-create-tag): Actually pass the DEFAULT argument to vc-read-revision. --- lisp/vc/vc-git.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index f9dae8b9ea..ea06ccaf87 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1635,7 +1635,7 @@ vc-git-create-tag (start-point (when branchp (vc-read-revision (format-prompt "Start point" (car (vc-git-branches))) - (list dir) 'Git)))) + (list dir) 'Git (car (vc-git-branches)))))) (and (or (zerop (vc-git-command nil t nil "update-index" "--refresh")) (y-or-n-p "Modified files exist. Proceed? ") (user-error (format "Can't create %s with modified files" -- 2.37.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 08 09:14:12 2022 Received: (at 58378) by debbugs.gnu.org; 8 Oct 2022 13:14:13 +0000 Received: from localhost ([127.0.0.1]:38601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oh9ee-000262-Lk for submit@debbugs.gnu.org; Sat, 08 Oct 2022 09:14:12 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oh9ec-00025n-Jm for 58378@debbugs.gnu.org; Sat, 08 Oct 2022 09:14:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vX6V1/djcLuVD4IisKMJ561QxpgN9CFg8GUj0qwbX1M=; b=VaVh95UpVd/dNfgRr6/tjpdw/R sWZv21LzVMooBcboqpIh6aKszZi7DXAlInDHVMKV3neAzstckoJuhc1RxoWSLYvGhZb4NPFVfYc1M NjTJubRnArFc85jFbrrHfwlhuHOiWSg9JOWqxiWRhJkBa08lOTi/08himJrmEJneUXW4=; Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oh9eU-00006L-CG; Sat, 08 Oct 2022 15:14:04 +0200 From: Lars Ingebrigtsen To: Visuwesh Subject: Re: bug#58378: [PATCH] Fix misleading prompt in vc-git-create-tag In-Reply-To: <87bkqmbjqz.fsf@gmail.com> (Visuwesh's message of "Sat, 08 Oct 2022 17:38:36 +0530") References: <87bkqmbjqz.fsf@gmail.com> X-Now-Playing: Joni Mitchell's _Ladies of the Canyon_: "Woodstock" Date: Sat, 08 Oct 2022 15:14:01 +0200 Message-ID: <877d1atq3q.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Visuwesh writes: > The prompt shows a default value but it is not actually passed to > vc-read-revision. Attached patch fixes that. Thanks; pushed to Emacs 29. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58378 Cc: 58378@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Visuwesh writes: > The prompt shows a default value but it is not actually passed to > vc-read-revision. Attached patch fixes that. Thanks; pushed to Emacs 29. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 08 09:14:17 2022 Received: (at control) by debbugs.gnu.org; 8 Oct 2022 13:14:17 +0000 Received: from localhost ([127.0.0.1]:38604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oh9ei-00026J-U4 for submit@debbugs.gnu.org; Sat, 08 Oct 2022 09:14:17 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oh9eg-00025t-Oy for control@debbugs.gnu.org; Sat, 08 Oct 2022 09:14:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ajNMQnX5U2jlDxZcN+qB76VeNjV/GfRlsZYg0R2Y0Ds=; b=KMtH/jKtR3/OU/2ezRCCwKuXmf kLoI0clumFK4zIRc3vEthI5W1oF0yyOJ/1uhuWnOYroEJhpJXHfzOURFS/3V+hZ1waeGBTMC0d1pW SI2+ilugPHCcZ/aGJIYoiKTc6e59yeRnMlVUAj6rVCjmYLSiCmHea8RoBvt6LXWAjm9E=; Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oh9eY-00006V-SC for control@debbugs.gnu.org; Sat, 08 Oct 2022 15:14:09 +0200 Date: Sat, 08 Oct 2022 15:14:06 +0200 Message-Id: <875ygutq3l.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #58378 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 58378 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 58378 29.1 quit From unknown Fri Jun 20 20:12:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 06 Nov 2022 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator