GNU bug report logs - #58376
[PATCH] Set the PARENTS argument for language environments

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58376 in the body.
You can then email your comments to 58376 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Set the PARENTS argument for language environments
Date: Sat, 8 Oct 2022 16:42:50 +0530

[Message part 1 (text/plain, inline)]

I had previously neglected to add the PARENTS argument to
set-language-info-alist due to being ignorant of its function.
This now has been corrected.

Please review the patch.
Thanks.

[Message part 2 (text/html, inline)]

Message #8 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: 58376 <at> debbugs.gnu.org
Subject: Re: [PATCH] Set the PARENTS argument for language environments
Date: Sat, 8 Oct 2022 16:45:58 +0530

[Message part 1 (text/plain, inline)]

On Sat, Oct 8, 2022 at 4:42 PM समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
wrote:

> I had previously neglected to add the PARENTS argument to
> set-language-info-alist due to being ignorant of its function.
> This now has been corrected.
>
> Please review the patch.
> Thanks.
>

[Message part 2 (text/html, inline)]

[0001-Set-the-PARENTS-argument-for-language-environments-b.patch (text/x-patch, attachment)]

Message #11 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 58376 <at> debbugs.gnu.org
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sat, 08 Oct 2022 17:46:34 +0300

> From: समीर सिंह Sameer Singh
>  <lumarzeli30 <at> gmail.com>
> Date: Sat, 8 Oct 2022 16:45:58 +0530
> 
> On Sat, Oct 8, 2022 at 4:42 PM समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com> wrote:
> 
>  I had previously neglected to add the PARENTS argument to set-language-info-alist due to being
>  ignorant of its function.
>  This now has been corrected.

Thanks.  However, the PARENTS argument of set-language-info-alist can
be a list.  Did you consider the possibility that we might want some
of these language environments to have more than one parent?  (I don't
myself have an opinion on this, I'm just asking.)

Message #14 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58376 <at> debbugs.gnu.org
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sat, 8 Oct 2022 21:48:26 +0530

[Message part 1 (text/plain, inline)]

Maybe Kharoshthi could also have "Indian" and Gothic could have "European".

Also can we move Cham, Tai Viet and Northern Thai in Misc?

On Sat, Oct 8, 2022 at 8:16 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh
> >  <lumarzeli30 <at> gmail.com>
> > Date: Sat, 8 Oct 2022 16:45:58 +0530
> >
> > On Sat, Oct 8, 2022 at 4:42 PM समीर सिंह Sameer Singh <
> lumarzeli30 <at> gmail.com> wrote:
> >
> >  I had previously neglected to add the PARENTS argument to
> set-language-info-alist due to being
> >  ignorant of its function.
> >  This now has been corrected.
>
> Thanks.  However, the PARENTS argument of set-language-info-alist can
> be a list.  Did you consider the possibility that we might want some
> of these language environments to have more than one parent?  (I don't
> myself have an opinion on this, I'm just asking.)
>

[Message part 2 (text/html, inline)]

Message #17 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 58376 <at> debbugs.gnu.org
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sat, 08 Oct 2022 21:16:26 +0300

> From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> Date: Sat, 8 Oct 2022 21:48:26 +0530
> Cc: 58376 <at> debbugs.gnu.org
> 
> Maybe Kharoshthi could also have "Indian" and Gothic could have "European".

I just asked, I have no opinion on that.

> Also can we move Cham, Tai Viet and Northern Thai in Misc?

Why to Misc?  I could understand moving Cham to Indian and Tai Viet to
Thai.  Misc is not really appropriate for scripts whose similar
scripts are already in some file.

Message #20 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58376 <at> debbugs.gnu.org
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sun, 9 Oct 2022 00:46:10 +0530

[Message part 1 (text/plain, inline)]

>
> Why to Misc?  I could understand moving Cham to Indian and Tai Viet to
> Thai.  Misc is not really appropriate for scripts whose similar
> scripts are already in some file.


Cham should not be moved to Indian, it inherits its script from India, but
is not an Indian language.
I'll leave them as it is.

For Kharoshthi and Gothic how to define the PARENTS argument so that it
does not overwrite the previous entries in the menu?
I am defining it like this:

(set-language-info-alist
 "Kharoshthi" '((charset unicode)
       (coding-system utf-8)
       (coding-priority utf-8)
       (input-method . "kharoshthi")
                (sample-text . "Kharoṣṭhī (𐨑𐨪𐨆𐨛𐨁) 𐨣𐨨𐨲𐨪𐨆
𐨐𐨪𐨅𐨨𐨁")
       (documentation . "\
Language environment for Gāndhārī, Sanskrit, and other languages
using the Kharoṣṭhī script."))
 '("Misc"
   "Indian"))

On Sat, Oct 8, 2022 at 11:46 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> > Date: Sat, 8 Oct 2022 21:48:26 +0530
> > Cc: 58376 <at> debbugs.gnu.org
> >
> > Maybe Kharoshthi could also have "Indian" and Gothic could have
> "European".
>
> I just asked, I have no opinion on that.
>
> > Also can we move Cham, Tai Viet and Northern Thai in Misc?
>
> Why to Misc?  I could understand moving Cham to Indian and Tai Viet to
> Thai.  Misc is not really appropriate for scripts whose similar
> scripts are already in some file.
>

[Message part 2 (text/html, inline)]

Message #23 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 58376 <at> debbugs.gnu.org
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sun, 09 Oct 2022 11:29:33 +0300

> From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> Date: Sun, 9 Oct 2022 00:46:10 +0530
> Cc: 58376 <at> debbugs.gnu.org
> 
> For Kharoshthi and Gothic how to define the PARENTS argument so that it does not overwrite the previous
> entries in the menu?

What do you mean by "overwrite"?  What happens if you use a list of
more than one PARENTS?

Message #26 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58376 <at> debbugs.gnu.org
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sun, 9 Oct 2022 15:58:48 +0530

[Message part 1 (text/plain, inline)]

On Sun, Oct 9, 2022 at 1:59 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> > Date: Sun, 9 Oct 2022 00:46:10 +0530
> > Cc: 58376 <at> debbugs.gnu.org
> >
> > For Kharoshthi and Gothic how to define the PARENTS argument so that it
> does not overwrite the previous
> > entries in the menu?
>
> What do you mean by "overwrite"?  What happens if you use a list of
> more than one PARENTS?
>

If I do something like:

(set-language-info-alist
 "Kharoshthi" '((charset unicode)
       (coding-system utf-8)
       (coding-priority utf-8)
       (input-method . "kharoshthi")
                (sample-text . "Kharoṣṭhī (𐨑𐨪𐨆𐨛𐨁) 𐨣𐨨𐨲𐨪𐨆
𐨐𐨪𐨅𐨨𐨁")
       (documentation . "\
Language environment for Gāndhārī, Sanskrit, and other languages
using the Kharoṣṭhī script."))
 '("Misc" "Indian"))

Then compile and open emacs -Q
Now opening Options>Multilingual Environment>Set Language Environment>Indian
It only has the Kharoshthi entry
Options>Multilingual Environment>Set Language Environment>Misc now also has
an Indian submenu with only Kharoshthi entry.

[Message part 2 (text/html, inline)]

Message #29 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 58376 <at> debbugs.gnu.org
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sun, 09 Oct 2022 16:22:36 +0300

> From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> Date: Sun, 9 Oct 2022 15:58:48 +0530
> Cc: 58376 <at> debbugs.gnu.org
> 
>  > From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
>  > Date: Sun, 9 Oct 2022 00:46:10 +0530
>  > Cc: 58376 <at> debbugs.gnu.org
>  > 
>  > For Kharoshthi and Gothic how to define the PARENTS argument so that it does not overwrite the
>  previous
>  > entries in the menu?
> 
>  What do you mean by "overwrite"?  What happens if you use a list of
>  more than one PARENTS?
> 
> If I do something like:
> 
> (set-language-info-alist
>  "Kharoshthi" '((charset unicode)
>        (coding-system utf-8)
>        (coding-priority utf-8)
>        (input-method . "kharoshthi")
>                 (sample-text . "Kharoṣṭhī (𐨑𐨪𐨆𐨛𐨁) 𐨣𐨨𐨲𐨪𐨆 𐨐𐨪𐨅𐨨𐨁")
>        (documentation . "\
> Language environment for Gāndhārī, Sanskrit, and other languages
> using the Kharoṣṭhī script."))
>  '("Misc" "Indian"))
> 
> Then compile and open emacs -Q
> Now opening Options>Multilingual Environment>Set Language Environment>Indian
> It only has the Kharoshthi entry
> Options>Multilingual Environment>Set Language Environment>Misc now also has an Indian submenu with
> only Kharoshthi entry.

Hmm...  Either we don't understand what PARENTS mean (could it mean a
hierarchy of several menu levels?), or there is a bug.

If you want to work on that, please do; otherwise I'll just install
your original patch.

Message #32 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58376 <at> debbugs.gnu.org
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sun, 9 Oct 2022 19:29:21 +0530

[Message part 1 (text/plain, inline)]

You can install the original patch for now, I'll look into this later.

Also can we copy Microsoft keyboard layout for input methods?

Thanks

On Sun, Oct 9, 2022 at 6:52 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> > Date: Sun, 9 Oct 2022 15:58:48 +0530
> > Cc: 58376 <at> debbugs.gnu.org
> >
> >  > From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> >  > Date: Sun, 9 Oct 2022 00:46:10 +0530
> >  > Cc: 58376 <at> debbugs.gnu.org
> >  >
> >  > For Kharoshthi and Gothic how to define the PARENTS argument so that
> it does not overwrite the
> >  previous
> >  > entries in the menu?
> >
> >  What do you mean by "overwrite"?  What happens if you use a list of
> >  more than one PARENTS?
> >
> > If I do something like:
> >
> > (set-language-info-alist
> >  "Kharoshthi" '((charset unicode)
> >        (coding-system utf-8)
> >        (coding-priority utf-8)
> >        (input-method . "kharoshthi")
> >                 (sample-text . "Kharoṣṭhī (𐨑𐨪𐨆𐨛𐨁) 𐨣𐨨𐨲𐨪𐨆
> 𐨐𐨪𐨅𐨨𐨁")
> >        (documentation . "\
> > Language environment for Gāndhārī, Sanskrit, and other languages
> > using the Kharoṣṭhī script."))
> >  '("Misc" "Indian"))
> >
> > Then compile and open emacs -Q
> > Now opening Options>Multilingual Environment>Set Language
> Environment>Indian
> > It only has the Kharoshthi entry
> > Options>Multilingual Environment>Set Language Environment>Misc now also
> has an Indian submenu with
> > only Kharoshthi entry.
>
> Hmm...  Either we don't understand what PARENTS mean (could it mean a
> hierarchy of several menu levels?), or there is a bug.
>
> If you want to work on that, please do; otherwise I'll just install
> your original patch.
>

[Message part 2 (text/html, inline)]

Message #37 received at 58376-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 58376-done <at> debbugs.gnu.org
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sun, 09 Oct 2022 17:23:43 +0300

> From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> Date: Sun, 9 Oct 2022 19:29:21 +0530
> Cc: 58376 <at> debbugs.gnu.org
> 
> You can install the original patch for now, I'll look into this later.

Done.

> Also can we copy Microsoft keyboard layout for input methods?

How do you mean "copy keyboard layout"?  We don't produce keyboard, so
what kind of "copy" is relevant?

Message #40 received at 58376-done <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58376-done <at> debbugs.gnu.org
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sun, 9 Oct 2022 20:16:53 +0530

[Message part 1 (text/plain, inline)]

On Sun, Oct 9, 2022 at 7:53 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> > Date: Sun, 9 Oct 2022 19:29:21 +0530
> > Cc: 58376 <at> debbugs.gnu.org
> >
> > You can install the original patch for now, I'll look into this later.
>
> Done.
>
> > Also can we copy Microsoft keyboard layout for input methods?
>
> How do you mean "copy keyboard layout"?  We don't produce keyboard, so
> what kind of "copy" is relevant?
>

I meant to say that can we have the same input methods as microsoft?
Do they have some copyright on them or is it okay to copy?
I needed them for input methods like Armenian and Syriac.
From here:
https://learn.microsoft.com/en-us/globalization/windows-keyboard-layouts

[Message part 2 (text/html, inline)]

Message #43 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>, 58376 <at> debbugs.gnu.org
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sun, 09 Oct 2022 20:20:36 +0530

[Message part 1 (text/plain, inline)]

[ஞாயிறு அக்டோபர் 09, 2022] Eli Zaretskii wrote:

>> If I do something like:
>> 
>> (set-language-info-alist
>>  "Kharoshthi" '((charset unicode)
>>        (coding-system utf-8)
>>        (coding-priority utf-8)
>>        (input-method . "kharoshthi")
>>                 (sample-text . "Kharoṣṭhī (𐨑𐨪𐨆𐨛𐨁) 𐨣𐨨𐨲𐨪𐨆 𐨐𐨪𐨅𐨨𐨁")
>>        (documentation . "\
>> Language environment for Gāndhārī, Sanskrit, and other languages
>> using the Kharoṣṭhī script."))
>>  '("Misc" "Indian"))
>> 
>> Then compile and open emacs -Q
>> Now opening Options>Multilingual Environment>Set Language Environment>Indian
>> It only has the Kharoshthi entry
>> Options>Multilingual Environment>Set Language Environment>Misc now also has an Indian submenu with
>> only Kharoshthi entry.
>
> Hmm...  Either we don't understand what PARENTS mean (could it mean a
> hierarchy of several menu levels?), or there is a bug.
>
> If you want to work on that, please do; otherwise I'll just install
> your original patch.

Attached patch puts the "Kharosthi" item in both Indian and Misc
submenus without overwriting.

[set-language-info-alist.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

The problem is that when looping, the variables setup-map and
describe-map gets outdated and causes the overwrite.  The solution I
came up with was to update them both to their default after each
iteration.  This involved moving the keymap-setting forms to a separate
function.

Message #46 received at 58376-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>, Richard Stallman <rms <at> gnu.org>
Cc: 58376-done <at> debbugs.gnu.org
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sun, 09 Oct 2022 17:55:53 +0300

> From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> Date: Sun, 9 Oct 2022 20:16:53 +0530
> Cc: 58376-done <at> debbugs.gnu.org
> 
>  > Also can we copy Microsoft keyboard layout for input methods?
> 
>  How do you mean "copy keyboard layout"?  We don't produce keyboard, so
>  what kind of "copy" is relevant?
> 
> I meant to say that can we have the same input methods as microsoft?
> Do they have some copyright on them or is it okay to copy?
> I needed them for input methods like Armenian and Syriac.
> From here: https://learn.microsoft.com/en-us/globalization/windows-keyboard-layouts 

I don't think placement of characters on keys is copyrightable, but
IANAL.  Richard, is there a problem here?

Message #49 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>, 58376 <at> debbugs.gnu.org
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sun, 09 Oct 2022 20:36:16 +0530

[ஞாயிறு அக்டோபர் 09, 2022] Visuwesh wrote:

> [ஞாயிறு அக்டோபர் 09, 2022] Eli Zaretskii wrote:
>
>>> If I do something like:
>>> 
>>> (set-language-info-alist
>>>  "Kharoshthi" '((charset unicode)
>>>        (coding-system utf-8)
>>>        (coding-priority utf-8)
>>>        (input-method . "kharoshthi")
>>>                 (sample-text . "Kharoṣṭhī (𐨑𐨪𐨆𐨛𐨁) 𐨣𐨨𐨲𐨪𐨆 𐨐𐨪𐨅𐨨𐨁")
>>>        (documentation . "\
>>> Language environment for Gāndhārī, Sanskrit, and other languages
>>> using the Kharoṣṭhī script."))
>>>  '("Misc" "Indian"))
>>> 
>>> Then compile and open emacs -Q
>>> Now opening Options>Multilingual Environment>Set Language Environment>Indian
>>> It only has the Kharoshthi entry
>>> Options>Multilingual Environment>Set Language Environment>Misc now also has an Indian submenu with
>>> only Kharoshthi entry.
>>
>> Hmm...  Either we don't understand what PARENTS mean (could it mean
>> a
>> hierarchy of several menu levels?), or there is a bug.
>>
>> If you want to work on that, please do; otherwise I'll just install
>> your original patch.
>
> Attached patch puts the "Kharosthi" item in both Indian and Misc
> submenus without overwriting.
>
>
>
> The problem is that when looping, the variables setup-map and
> describe-map gets outdated and causes the overwrite.  The solution I
> came up with was to update them both to their default after each
> iteration.  This involved moving the keymap-setting forms to a
> separate
> function.

Hmm, I seethat the function can be cleaned up further.  I will do it
after my dinner.

Message #52 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>, 58376 <at> debbugs.gnu.org
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sun, 09 Oct 2022 21:00:24 +0530

[Message part 1 (text/plain, inline)]

[ஞாயிறு அக்டோபர் 09, 2022] Visuwesh wrote:

>> Attached patch puts the "Kharosthi" item in both Indian and Misc
>> submenus without overwriting.
>>
>>
>>
>> The problem is that when looping, the variables setup-map and
>> describe-map gets outdated and causes the overwrite.  The solution I
>> came up with was to update them both to their default after each
>> iteration.  This involved moving the keymap-setting forms to a
>> separate
>> function.
>
> Hmm, I seethat the function can be cleaned up further.  I will do it
> after my dinner.

Please find attached.

[0001-Fix-set-language-info-alist-when-multiple-PARENTS-ar.patch (text/x-diff, attachment)]

Message #55 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 58376 <at> debbugs.gnu.org
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Mon, 10 Oct 2022 19:36:59 +0530

[Message part 1 (text/plain, inline)]

Can you resend the patch?
This one fails to apply.

On Sun, Oct 9, 2022 at 9:00 PM Visuwesh <visuweshm <at> gmail.com> wrote:

> [ஞாயிறு அக்டோபர் 09, 2022] Visuwesh wrote:
>
> >> Attached patch puts the "Kharosthi" item in both Indian and Misc
> >> submenus without overwriting.
> >>
> >>
> >>
> >> The problem is that when looping, the variables setup-map and
> >> describe-map gets outdated and causes the overwrite.  The solution I
> >> came up with was to update them both to their default after each
> >> iteration.  This involved moving the keymap-setting forms to a
> >> separate
> >> function.
> >
> > Hmm, I seethat the function can be cleaned up further.  I will do it
> > after my dinner.
>
> Please find attached.
>
>

[Message part 2 (text/html, inline)]

Message #58 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 58376 <at> debbugs.gnu.org
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Mon, 10 Oct 2022 20:02:58 +0530

[Message part 1 (text/plain, inline)]

[திங்கள் அக்டோபர் 10, 2022] समीर सिंह Sameer Singh wrote:

> On Sun, Oct 9, 2022 at 9:00 PM Visuwesh <visuweshm <at> gmail.com> wrote:
>
>  [ஞாயிறு அக்டோபர் 09, 2022] Visuwesh wrote:
>
>  >> Attached patch puts the "Kharosthi" item in both Indian and Misc
>  >> submenus without overwriting.
>  >>
>  >>
>  >>
>  >> The problem is that when looping, the variables setup-map and
>  >> describe-map gets outdated and causes the overwrite.  The solution I
>  >> came up with was to update them both to their default after each
>  >> iteration.  This involved moving the keymap-setting forms to a
>  >> separate
>  >> function.
>  >
>  > Hmm, I seethat the function can be cleaned up further.  I will do it
>  > after my dinner.
>
>  Please find attached.
>
>
> Can you resend the patch?
> This one fails to apply.

Hmm weird, the patch applies cleanly for me if I download a fresh copy of
mule-cmds.el from https://git.savannah.gnu.org/cgit/emacs.git/plain/lisp/international/mule-cmds.el.
How about the attached?

[pp (text/x-diff, attachment)]

Message #61 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 58376 <at> debbugs.gnu.org
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Mon, 10 Oct 2022 20:08:42 +0530

[Message part 1 (text/plain, inline)]

This one says: "error: corrupt patch at line 8"

The previous one said:
error: patch failed: lisp/international/mule-cmds.el:1208
error: lisp/international/mule-cmds.el: patch does not apply

On Mon, Oct 10, 2022 at 8:03 PM Visuwesh <visuweshm <at> gmail.com> wrote:

> [திங்கள் அக்டோபர் 10, 2022] समीर सिंह Sameer Singh wrote:
>
> > On Sun, Oct 9, 2022 at 9:00 PM Visuwesh <visuweshm <at> gmail.com> wrote:
> >
> >  [ஞாயிறு அக்டோபர் 09, 2022] Visuwesh wrote:
> >
> >  >> Attached patch puts the "Kharosthi" item in both Indian and Misc
> >  >> submenus without overwriting.
> >  >>
> >  >>
> >  >>
> >  >> The problem is that when looping, the variables setup-map and
> >  >> describe-map gets outdated and causes the overwrite.  The solution I
> >  >> came up with was to update them both to their default after each
> >  >> iteration.  This involved moving the keymap-setting forms to a
> >  >> separate
> >  >> function.
> >  >
> >  > Hmm, I seethat the function can be cleaned up further.  I will do it
> >  > after my dinner.
> >
> >  Please find attached.
> >
> >
> > Can you resend the patch?
> > This one fails to apply.
>
> Hmm weird, the patch applies cleanly for me if I download a fresh copy of
> mule-cmds.el from
> https://git.savannah.gnu.org/cgit/emacs.git/plain/lisp/international/mule-cmds.el
> .
> How about the attached?
>
>

[Message part 2 (text/html, inline)]

Message #64 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 58376 <at> debbugs.gnu.org
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Mon, 10 Oct 2022 21:29:03 +0530

[திங்கள் அக்டோபர் 10, 2022] समीर सिंह Sameer Singh wrote:

> This one says: "error: corrupt patch at line 8"
>
> The previous one said:
> error: patch failed: lisp/international/mule-cmds.el:1208
> error: lisp/international/mule-cmds.el: patch does not apply
>

I have no idea why that is the case, and my network connection is too
slow to freshly clone the Emacs repo again.  Can you replace the old
definition of `set-language-info-alist' with the following two forms
instead?

(defun set-language-info-setup-keymap (lang-env alist describe-map setup-map)
  "Setup menu items for LANG-ENV.
See `set-language-info-alist' for details of other arguments."
  (let ((doc (assq 'documentation alist)))
    (when doc
      (define-key-after describe-map (vector (intern lang-env))
	(cons lang-env 'describe-specified-language-support))))
  (define-key-after setup-map (vector (intern lang-env))
    (cons lang-env 'setup-specified-language-environment)))

(defun set-language-info-alist (lang-env alist &optional parents)
  "Store ALIST as the definition of language environment LANG-ENV.
ALIST is an alist of KEY and INFO values.  See the documentation of
`language-info-alist' for the meanings of KEY and INFO.

Optional arg PARENTS is a list of parent menu names; it specifies
where to put this language environment in the
Describe Language Environment and Set Language Environment menus.
For example, (\"European\") means to put this language environment
in the European submenu in each of those two menus."
  (cond ((symbolp lang-env)
	 (setq lang-env (symbol-name lang-env)))
	((stringp lang-env)
	 (setq lang-env (purecopy lang-env))))
  (if parents
      (while parents
	(let (describe-map setup-map parent-symbol parent prompt)
	  (if (symbolp (setq parent-symbol (car parents)))
	      (setq parent (symbol-name parent))
	    (setq parent parent-symbol parent-symbol (intern parent)))
	  (setq describe-map (lookup-key describe-language-environment-map (vector parent-symbol)))
	  ;; This prompt string is for define-prefix-command, so
	  ;; that the map it creates will be suitable for a menu.
	  (or describe-map (setq prompt (format "%s Environment" parent)))
	  (unless describe-map
	    (setq describe-map (intern (format "describe-%s-environment-map"
					       (downcase parent))))
	    (define-prefix-command describe-map nil prompt)
	    (define-key-after describe-language-environment-map (vector parent-symbol)
	      (cons parent describe-map)))
	  (setq setup-map (lookup-key setup-language-environment-map (vector parent-symbol)))
	  (unless setup-map
	    (setq setup-map (intern (format "setup-%s-environment-map"
					    (downcase parent))))
	    (define-prefix-command setup-map nil prompt)
	    (define-key-after setup-language-environment-map (vector parent-symbol)
	      (cons parent setup-map)))
	  (setq parents (cdr parents))
          (set-language-info-setup-keymap lang-env alist (symbol-value describe-map) (symbol-value setup-map))))
    (set-language-info-setup-keymap lang-env alist
                                    describe-language-environment-map setup-language-environment-map))
  (dolist (elt alist)
    (set-language-info-internal lang-env (car elt) (cdr elt)))
  (if (equal lang-env current-language-environment)
      (set-language-environment lang-env)))

Message #67 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 58376 <at> debbugs.gnu.org
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Tue, 11 Oct 2022 00:08:11 +0530

[Message part 1 (text/plain, inline)]

Thanks, it works this way.
I have created a patch for you, if the ones provided by you do not apply.

I have also created a separate patch adding multiple PARENTs to Kharoshthi
and Gothic.

On Mon, Oct 10, 2022 at 9:29 PM Visuwesh <visuweshm <at> gmail.com> wrote:

> [திங்கள் அக்டோபர் 10, 2022] समीर सिंह Sameer Singh wrote:
>
> > This one says: "error: corrupt patch at line 8"
> >
> > The previous one said:
> > error: patch failed: lisp/international/mule-cmds.el:1208
> > error: lisp/international/mule-cmds.el: patch does not apply
> >
>
> I have no idea why that is the case, and my network connection is too
> slow to freshly clone the Emacs repo again.  Can you replace the old
> definition of `set-language-info-alist' with the following two forms
> instead?
>
> (defun set-language-info-setup-keymap (lang-env alist describe-map
> setup-map)
>   "Setup menu items for LANG-ENV.
> See `set-language-info-alist' for details of other arguments."
>   (let ((doc (assq 'documentation alist)))
>     (when doc
>       (define-key-after describe-map (vector (intern lang-env))
>         (cons lang-env 'describe-specified-language-support))))
>   (define-key-after setup-map (vector (intern lang-env))
>     (cons lang-env 'setup-specified-language-environment)))
>
> (defun set-language-info-alist (lang-env alist &optional parents)
>   "Store ALIST as the definition of language environment LANG-ENV.
> ALIST is an alist of KEY and INFO values.  See the documentation of
> `language-info-alist' for the meanings of KEY and INFO.
>
> Optional arg PARENTS is a list of parent menu names; it specifies
> where to put this language environment in the
> Describe Language Environment and Set Language Environment menus.
> For example, (\"European\") means to put this language environment
> in the European submenu in each of those two menus."
>   (cond ((symbolp lang-env)
>          (setq lang-env (symbol-name lang-env)))
>         ((stringp lang-env)
>          (setq lang-env (purecopy lang-env))))
>   (if parents
>       (while parents
>         (let (describe-map setup-map parent-symbol parent prompt)
>           (if (symbolp (setq parent-symbol (car parents)))
>               (setq parent (symbol-name parent))
>             (setq parent parent-symbol parent-symbol (intern parent)))
>           (setq describe-map (lookup-key describe-language-environment-map
> (vector parent-symbol)))
>           ;; This prompt string is for define-prefix-command, so
>           ;; that the map it creates will be suitable for a menu.
>           (or describe-map (setq prompt (format "%s Environment" parent)))
>           (unless describe-map
>             (setq describe-map (intern (format
> "describe-%s-environment-map"
>                                                (downcase parent))))
>             (define-prefix-command describe-map nil prompt)
>             (define-key-after describe-language-environment-map (vector
> parent-symbol)
>               (cons parent describe-map)))
>           (setq setup-map (lookup-key setup-language-environment-map
> (vector parent-symbol)))
>           (unless setup-map
>             (setq setup-map (intern (format "setup-%s-environment-map"
>                                             (downcase parent))))
>             (define-prefix-command setup-map nil prompt)
>             (define-key-after setup-language-environment-map (vector
> parent-symbol)
>               (cons parent setup-map)))
>           (setq parents (cdr parents))
>           (set-language-info-setup-keymap lang-env alist (symbol-value
> describe-map) (symbol-value setup-map))))
>     (set-language-info-setup-keymap lang-env alist
>                                     describe-language-environment-map
> setup-language-environment-map))
>   (dolist (elt alist)
>     (set-language-info-internal lang-env (car elt) (cdr elt)))
>   (if (equal lang-env current-language-environment)
>       (set-language-environment lang-env)))
>

[Message part 2 (text/html, inline)]

[0001-Fix-set-language-info-alist-when-multiple-PARENTS-ar.patch (text/x-patch, attachment)]

[0001-Add-multiple-PARENTs-to-Kharoshthi-and-Gothic-bug-58.patch (text/x-patch, attachment)]

Message #70 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58376 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sun, 30 Oct 2022 13:52:22 +0530

[Message part 1 (text/plain, inline)]

Looks like, these patches have not yet been merged, it seems like they were
forgotten among other things,
therefore please install them.

Thanks

On Tue, Oct 11, 2022 at 12:08 AM समीर सिंह Sameer Singh <
lumarzeli30 <at> gmail.com> wrote:

> Thanks, it works this way.
> I have created a patch for you, if the ones provided by you do not apply.
>
> I have also created a separate patch adding multiple PARENTs to Kharoshthi
> and Gothic.
>
> On Mon, Oct 10, 2022 at 9:29 PM Visuwesh <visuweshm <at> gmail.com> wrote:
>
>> [திங்கள் அக்டோபர் 10, 2022] समीर सिंह Sameer Singh wrote:
>>
>> > This one says: "error: corrupt patch at line 8"
>> >
>> > The previous one said:
>> > error: patch failed: lisp/international/mule-cmds.el:1208
>> > error: lisp/international/mule-cmds.el: patch does not apply
>> >
>>
>> I have no idea why that is the case, and my network connection is too
>> slow to freshly clone the Emacs repo again.  Can you replace the old
>> definition of `set-language-info-alist' with the following two forms
>> instead?
>>
>> (defun set-language-info-setup-keymap (lang-env alist describe-map
>> setup-map)
>>   "Setup menu items for LANG-ENV.
>> See `set-language-info-alist' for details of other arguments."
>>   (let ((doc (assq 'documentation alist)))
>>     (when doc
>>       (define-key-after describe-map (vector (intern lang-env))
>>         (cons lang-env 'describe-specified-language-support))))
>>   (define-key-after setup-map (vector (intern lang-env))
>>     (cons lang-env 'setup-specified-language-environment)))
>>
>> (defun set-language-info-alist (lang-env alist &optional parents)
>>   "Store ALIST as the definition of language environment LANG-ENV.
>> ALIST is an alist of KEY and INFO values.  See the documentation of
>> `language-info-alist' for the meanings of KEY and INFO.
>>
>> Optional arg PARENTS is a list of parent menu names; it specifies
>> where to put this language environment in the
>> Describe Language Environment and Set Language Environment menus.
>> For example, (\"European\") means to put this language environment
>> in the European submenu in each of those two menus."
>>   (cond ((symbolp lang-env)
>>          (setq lang-env (symbol-name lang-env)))
>>         ((stringp lang-env)
>>          (setq lang-env (purecopy lang-env))))
>>   (if parents
>>       (while parents
>>         (let (describe-map setup-map parent-symbol parent prompt)
>>           (if (symbolp (setq parent-symbol (car parents)))
>>               (setq parent (symbol-name parent))
>>             (setq parent parent-symbol parent-symbol (intern parent)))
>>           (setq describe-map (lookup-key
>> describe-language-environment-map (vector parent-symbol)))
>>           ;; This prompt string is for define-prefix-command, so
>>           ;; that the map it creates will be suitable for a menu.
>>           (or describe-map (setq prompt (format "%s Environment" parent)))
>>           (unless describe-map
>>             (setq describe-map (intern (format
>> "describe-%s-environment-map"
>>                                                (downcase parent))))
>>             (define-prefix-command describe-map nil prompt)
>>             (define-key-after describe-language-environment-map (vector
>> parent-symbol)
>>               (cons parent describe-map)))
>>           (setq setup-map (lookup-key setup-language-environment-map
>> (vector parent-symbol)))
>>           (unless setup-map
>>             (setq setup-map (intern (format "setup-%s-environment-map"
>>                                             (downcase parent))))
>>             (define-prefix-command setup-map nil prompt)
>>             (define-key-after setup-language-environment-map (vector
>> parent-symbol)
>>               (cons parent setup-map)))
>>           (setq parents (cdr parents))
>>           (set-language-info-setup-keymap lang-env alist (symbol-value
>> describe-map) (symbol-value setup-map))))
>>     (set-language-info-setup-keymap lang-env alist
>>                                     describe-language-environment-map
>> setup-language-environment-map))
>>   (dolist (elt alist)
>>     (set-language-info-internal lang-env (car elt) (cdr elt)))
>>   (if (equal lang-env current-language-environment)
>>       (set-language-environment lang-env)))
>>
>

[Message part 2 (text/html, inline)]

Message #73 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 58376 <at> debbugs.gnu.org, visuweshm <at> gmail.com
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sun, 30 Oct 2022 10:43:04 +0200

> From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> Date: Sun, 30 Oct 2022 13:52:22 +0530
> Cc: 58376 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
> 
> Looks like, these patches have not yet been merged, it seems like they were forgotten among other things,
> therefore please install them.

Thanks for the reminder.

However, the second part of those patches makes little sense to me: if
these languages are considered to be part of "Indian" languages, why
leave them in "Misc"?  "Misc" is for languages that have no "parent"
family.

Message #76 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58376 <at> debbugs.gnu.org, visuweshm <at> gmail.com
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sun, 30 Oct 2022 15:00:44 +0530

[Message part 1 (text/plain, inline)]

>
> However, the second part of those patches makes little sense to me: if
> these languages are considered to be part of "Indian" languages, why
> leave them in "Misc"?  "Misc" is for languages that have no "parent"
> family.


Kharoshthi is different from the Brahmic scripts in that it is not derived
from Brahmi but instead from Aramaic.
It was also used in regions not present in modern India.
But it was used to write Indian languages, therefore it made sense to me to
include it in both Indian and Misc.

On Sun, Oct 30, 2022 at 2:13 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> > Date: Sun, 30 Oct 2022 13:52:22 +0530
> > Cc: 58376 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
> >
> > Looks like, these patches have not yet been merged, it seems like they
> were forgotten among other things,
> > therefore please install them.
>
> Thanks for the reminder.
>
> However, the second part of those patches makes little sense to me: if
> these languages are considered to be part of "Indian" languages, why
> leave them in "Misc"?  "Misc" is for languages that have no "parent"
> family.
>

[Message part 2 (text/html, inline)]

Message #79 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 58376 <at> debbugs.gnu.org, visuweshm <at> gmail.com
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sun, 30 Oct 2022 12:20:02 +0200

> From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> Date: Sun, 30 Oct 2022 15:00:44 +0530
> Cc: 58376 <at> debbugs.gnu.org, visuweshm <at> gmail.com
> 
>  However, the second part of those patches makes little sense to me: if
>  these languages are considered to be part of "Indian" languages, why
>  leave them in "Misc"?  "Misc" is for languages that have no "parent"
>  family.
> 
> Kharoshthi is different from the Brahmic scripts in that it is not derived from Brahmi but instead from Aramaic.
> It was also used in regions not present in modern India.
> But it was used to write Indian languages, therefore it made sense to me to include it in both Indian and Misc. 

I'm okay with "Indian".  It's "Misc" that I question.  Would it be
okay to have these only in "Indian"?

Message #82 received at 58376 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58376 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sun, 30 Oct 2022 16:01:35 +0530

[Message part 1 (text/plain, inline)]

Yes, that would be okay too.

On Sun, Oct 30, 2022, 3:50 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> > Date: Sun, 30 Oct 2022 15:00:44 +0530
> > Cc: 58376 <at> debbugs.gnu.org, visuweshm <at> gmail.com
> >
> >  However, the second part of those patches makes little sense to me: if
> >  these languages are considered to be part of "Indian" languages, why
> >  leave them in "Misc"?  "Misc" is for languages that have no "parent"
> >  family.
> >
> > Kharoshthi is different from the Brahmic scripts in that it is not
> derived from Brahmi but instead from Aramaic.
> > It was also used in regions not present in modern India.
> > But it was used to write Indian languages, therefore it made sense to me
> to include it in both Indian and Misc.
>
> I'm okay with "Indian".  It's "Misc" that I question.  Would it be
> okay to have these only in "Indian"?
>

[Message part 2 (text/html, inline)]

Message #85 received at 58376-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 58376-done <at> debbugs.gnu.org, visuweshm <at> gmail.com
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sun, 30 Oct 2022 13:18:00 +0200

> From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> Date: Sun, 30 Oct 2022 16:01:35 +0530
> Cc: 58376 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
> 
> Yes, that would be okay too.

Thanks, done, and closing the bug.

Message #88 received at 58376-done <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58376-done <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
Subject: Re: bug#58376: [PATCH] Set the PARENTS argument for language
 environments
Date: Sun, 30 Oct 2022 16:49:06 +0530

[Message part 1 (text/plain, inline)]

Thanks!

On Sun, Oct 30, 2022, 4:48 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> > Date: Sun, 30 Oct 2022 16:01:35 +0530
> > Cc: 58376 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
> >
> > Yes, that would be okay too.
>
> Thanks, done, and closing the bug.
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.