From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 08 06:34:28 2022 Received: (at submit) by debbugs.gnu.org; 8 Oct 2022 10:34:28 +0000 Received: from localhost ([127.0.0.1]:38368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oh7A0-0004KW-Pc for submit@debbugs.gnu.org; Sat, 08 Oct 2022 06:34:28 -0400 Received: from lists.gnu.org ([209.51.188.17]:52880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oh79z-0004KP-8E for submit@debbugs.gnu.org; Sat, 08 Oct 2022 06:34:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oh79y-0001IE-Oh for bug-guix@gnu.org; Sat, 08 Oct 2022 06:34:23 -0400 Received: from lepiller.eu ([2a00:5884:8208::1]:45460) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oh79t-0001xW-Bx for bug-guix@gnu.org; Sat, 08 Oct 2022 06:34:22 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id faf85fb3 for ; Sat, 8 Oct 2022 10:34:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:subject:message-id:mime-version:content-type :content-transfer-encoding; s=dkim; bh=x4lnaf2M5UWPqHY2ZC0lB6xQQ M8hHME6epZbSqGXl6s=; b=Htw6yvRJ20h/tSeYRvUIFeVkomXTYwkQ5aH5UvAbg aHuGRwX4fsrAPE1BcjkNsIU/wiSb575bEhl8UQ4ckyRJ3CyXSslh3aAskuzVVf7H 55XY64kQbuh1wjMEB8J/MRCc+eUUZ8xWo94cOvpliTh9lSJYNLEis8Y0lRdsmpOA 6na6u85YMVaLZvqx+2J7pa0+zkTj0o2a124boC6YhFUNhcm00JHkVRYeXWBAjRpT faqlFQ5HqudWZ5LXw5mIZiDZKfOODM5k6yObPI73naL64/5Ye+oXv7N8kqyjLVFT d1zROuapyZUNa1RmT2Zy2TYC/qY7//A21cSOhLRZHt2CA== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 3f372364 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Sat, 8 Oct 2022 10:34:08 +0000 (UTC) Date: Sat, 08 Oct 2022 12:34:08 +0200 From: Julien Lepiller To: bug-guix@gnu.org Subject: Installer does not show what is being downloaded User-Agent: K-9 Mail for Android Message-ID: <960E16D9-C67D-42E0-B3DE-75CA3041F738@lepiller.eu> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=----BPF8OUWD6F4XFBQ40KRCN5Q5SPHPCJ Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:5884:8208::1; envelope-from=julien@lepiller.eu; helo=lepiller.eu X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) ------BPF8OUWD6F4XFBQ40KRCN5Q5SPHPCJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I installed Guix on a new drive, so I tried the installer from the latest i= mage=2E After reviewing the system config, the installer goes to a black sc= reen where guix output is shown=2E Although I can see messages about substi= tutes being updated, and how much will be downloaded, all download lines ar= e replaced with a seemingly random number of dots: substitute: mise =C3=A0 jour des substituts depuis =C2=AB=E2=80=A6=C2=BB= =2E=2E=2E 100=2E0 % 4=2E5 Mo seront t=C3=A9l=C3=A9charg=C3=A9s=2E =2E =2E=2E=2E =2E =2E =2E=2E=2E=2E=2E=2E Maybe this is related to the translation? ------BPF8OUWD6F4XFBQ40KRCN5Q5SPHPCJ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable I installed Guix on a new drive, so I tried the = installer from the latest image=2E After reviewing the system config, the i= nstaller goes to a black screen where guix output is shown=2E Although I ca= n see messages about substitutes being updated, and how much will be downlo= aded, all download lines are replaced with a seemingly random number of dot= s:

substitute: mise =C3=A0 jour des substituts depuis =C2=AB=E2=80= =A6=C2=BB=2E=2E=2E 100=2E0 %
4=2E5 Mo seront t=C3=A9l=C3=A9charg=C3=A9s= =2E
=2E
=2E=2E=2E
=2E
=2E
=2E=2E=2E=2E=2E=2E

Maybe th= is is related to the translation? ------BPF8OUWD6F4XFBQ40KRCN5Q5SPHPCJ-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 08 14:09:38 2022 Received: (at 58375) by debbugs.gnu.org; 8 Oct 2022 18:09:38 +0000 Received: from localhost ([127.0.0.1]:41425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohEGX-0004WW-LL for submit@debbugs.gnu.org; Sat, 08 Oct 2022 14:09:37 -0400 Received: from jpoiret.xyz ([206.189.101.64]:53984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohEGV-0004WO-4a for 58375@debbugs.gnu.org; Sat, 08 Oct 2022 14:09:36 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id B0807185311; Sat, 8 Oct 2022 18:09:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1665252573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qSwWNOPzHNdg/UYfyFhA3DQy581JiBlAkFRAY8XrHAU=; b=uG3KZROnzsKf3jtogIidmrmcbSFLcGKlsGsvaK48ItKTocnPuUcRuMll8rdqrBx3JofT0p QUmBdqrQLyF6NaN+V4cI8F6CDzgP8ARbSWr/5K14141ooFgWkXcHDgB7ic1hvi1iHUNGLD HErPn8/NrOsj9ydwH/Klg+gml8KbzGDBibGEE+7H9T7c5l2Ce9IxY091JV6w0txABmWhVE 99q971JCLLX7osOkATbagmYZ91XP1AyNVUKOuLJbMiYrqt2HpU+gdoBAzdEt7ET7OXUtpp gPmhtC8lA3yWap0+qjKuXHOzXsbuGJM7RDYhjmwH5L1+IQVzif6QF6adzf/qHw== From: Josselin Poiret To: Julien Lepiller , 58375@debbugs.gnu.org Subject: Re: bug#58375: Installer does not show what is being downloaded In-Reply-To: <960E16D9-C67D-42E0-B3DE-75CA3041F738@lepiller.eu> References: <960E16D9-C67D-42E0-B3DE-75CA3041F738@lepiller.eu> Date: Sat, 08 Oct 2022 20:09:33 +0200 Message-ID: <87sfjy4276.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spamd-Bar: / X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Julien, Julien Lepiller writes: > I installed Guix on a new drive, so I tried the installer from the latest image. After reviewing the system config, the installer goes to a black screen [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 FROM_SUSPICIOUS_NTLD From abused NTLD X-Debbugs-Envelope-To: 58375 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Julien, Julien Lepiller writes: > I installed Guix on a new drive, so I tried the installer from the latest image. After reviewing the system config, the installer goes to a black screen [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD 0.0 FROM_SUSPICIOUS_NTLD From abused NTLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Hi Julien, Julien Lepiller writes: > I installed Guix on a new drive, so I tried the installer from the latest= image. After reviewing the system config, the installer goes to a black sc= reen where guix output is shown. Although I can see messages about substitu= tes being updated, and how much will be downloaded, all download lines are = replaced with a seemingly random number of dots: > > substitute: mise =C3=A0 jour des substituts depuis =C2=AB=E2=80=A6=C2=BB.= .. 100.0 % > 4.5 Mo seront t=C3=A9l=C3=A9charg=C3=A9s. > . > ... > . > . > ...... > > Maybe this is related to the translation? I agree that this does look pretty bad, but this is because we capture the guix command output to a log file so that we're able to include it in the installer dump if anything goes wrong. Guix detects it's not talking directly to a terminal and so doesn't try to use terminal specific escape codes to display the download progress. I don't know how we could improve on that front though, since in general capturing the guix command output helps with debugging issues. Best, --=20 Josselin Poiret From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 09 12:56:52 2022 Received: (at 58375) by debbugs.gnu.org; 9 Oct 2022 16:56:52 +0000 Received: from localhost ([127.0.0.1]:44860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohZbg-000458-4m for submit@debbugs.gnu.org; Sun, 09 Oct 2022 12:56:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohZbf-00044n-17 for 58375@debbugs.gnu.org; Sun, 09 Oct 2022 12:56:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46308) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohZbR-0007ZG-Ed; Sun, 09 Oct 2022 12:56:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=rS7GFnwoG5Nyg2+wdcj0f8O+ATWvZc6ZJVyw+YJt2sg=; b=ZQkU3j6u/tmeMD8B98p9 Nam7U9SsXMLccmdmZ6PI0DqWePwDerPzf8apmgrBE1vM410LSV0VTmQdP8IIJf5B/6AlnmysimPs0 YXQ34zZOw6PdfFuRQ4HoO66M3og+NP5I7rDnFuU/jhsLekEXG5XB99Iedz1ZjAt3JbD+/g9hCw7Yf EscDq3SlscgmEveucFSwUQp+qgMFHme+dW4xIPqutCJ01YzuHSPqovLjh6FgZqbQMWOJJmBFVsQVA hKbf2li/ZkUTu3rQI5ggor3Oy2AQDp0zWU9sW7DBCKacPaYwKLBn7iGHCC6W3+7maJDSoKNdOdg8c 1U04+0CboPDjyw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:59869 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohZbR-0003pf-1D; Sun, 09 Oct 2022 12:56:37 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Josselin Poiret Subject: Re: bug#58375: Installer does not show what is being downloaded References: <960E16D9-C67D-42E0-B3DE-75CA3041F738@lepiller.eu> <87sfjy4276.fsf@jpoiret.xyz> Date: Sun, 09 Oct 2022 18:56:35 +0200 In-Reply-To: <87sfjy4276.fsf@jpoiret.xyz> (Josselin Poiret's message of "Sat, 08 Oct 2022 20:09:33 +0200") Message-ID: <87bkql541o.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 58375 Cc: Julien Lepiller , 58375@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Hello! Josselin Poiret skribis: > Julien Lepiller writes: >> I installed Guix on a new drive, so I tried the installer from the lates= t image. After reviewing the system config, the installer goes to a black s= creen where guix output is shown. Although I can see messages about substit= utes being updated, and how much will be downloaded, all download lines are= replaced with a seemingly random number of dots: >> >> substitute: mise =C3=A0 jour des substituts depuis =C2=AB=E2=80=A6=C2=BB= ... 100.0 % >> 4.5 Mo seront t=C3=A9l=C3=A9charg=C3=A9s. >> . >> ... >> . >> . >> ...... >> >> Maybe this is related to the translation? > > I agree that this does look pretty bad, but this is because we capture > the guix command output to a log file so that we're able to include it > in the installer dump if anything goes wrong. Guix detects it's not > talking directly to a terminal and so doesn't try to use terminal > specific escape codes to display the download progress. I don't know > how we could improve on that front though, since in general capturing > the guix command output helps with debugging issues. This is a duplicate of , marked as important. I think capturing all the output as-is is overkill; one option I suggested in the bug report above is to syslog specific events of interest during =E2=80=98guix system init=E2=80=99. Thoughts? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 09 12:56:52 2022 Received: (at control) by debbugs.gnu.org; 9 Oct 2022 16:56:52 +0000 Received: from localhost ([127.0.0.1]:44858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohZbf-000456-UE for submit@debbugs.gnu.org; Sun, 09 Oct 2022 12:56:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohZbe-00044m-TE for control@debbugs.gnu.org; Sun, 09 Oct 2022 12:56:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33030) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohZbY-0007Ze-8u for control@debbugs.gnu.org; Sun, 09 Oct 2022 12:56:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=O/IGYay9+VExiIcaUfPb1BBfVxsj7dI0zHMzyBf9TF4=; b=UQIa7ch19w+5Kz fSzKzXcQ15z27KU8u7xspGXpDsPiFvtbCQWVgIA/If54T/cbX3AzGh9wwFT1hflxrh2p6B0eDTX// lmSJXbwZFy61qnrmDcFk0RZ7Az/G6hPRI+Xx3Nv3T5jny0+6w2z2tPDiW6YkVUnKPUICwaZ0HhIE8 F5Xt1RBalmgNP6ZHaZRkWPSm5khFBML8b4sWEhrGUE9DHsLJHcnzHeO+uaechsuWV0b7nlMFmfhiF gxfvHjoHmgnsSQj/myAtmHbOT8DMBKgDO1396dLShXsVTyxUIzq3RTyKEGVYLWYs9U03yDcHuoGRq ryORlI2xcUlvhy0t6b1A==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:54437 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohZbX-0003rV-GM for control@debbugs.gnu.org; Sun, 09 Oct 2022 12:56:44 -0400 Date: Sun, 09 Oct 2022 18:56:41 +0200 Message-Id: <87a665541i.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #58375 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) severity 58375 important quit From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 09 12:56:59 2022 Received: (at control) by debbugs.gnu.org; 9 Oct 2022 16:56:59 +0000 Received: from localhost ([127.0.0.1]:44864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohZbn-00045b-H9 for submit@debbugs.gnu.org; Sun, 09 Oct 2022 12:56:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohZbm-00045L-Dg for control@debbugs.gnu.org; Sun, 09 Oct 2022 12:56:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35730) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohZbg-0007au-Mu for control@debbugs.gnu.org; Sun, 09 Oct 2022 12:56:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=apOyAmOHc/Bd14mo04/y+wG/Zs/hBMHb4hmi/MeD5DA=; b=McBuDtFVmmxBi0 xPPpJUOKJHiMHVg69VgVb4sr7K7AYJEGdWw/t938yTGBfaV7vznG00arohJAjVFy1trfdInpBxv/W tkdfHLBMgbIheFjWUl49KvegjLpj1Z+NvIYcWZMvt0CVys/sy3RffOV6dQStjfNs+eFk33Z0Th0Bx GiG6zb5zz3Oii3TeY5RW517w5N9ELPfiCdUS/uKmOnvAKazLS0vffKjxmHWRw0xEW96wna+JBswQr qaD2sz+tqEYIeLRxixDk2aMTE417Jwix9s9WB/dnEBd6N3QGq7pWqQs4FB+t52hWX9plBVK+rDYTZ 1ryG9s27mk1ag/ypcMmg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:53068 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohZbg-0003tK-8X for control@debbugs.gnu.org; Sun, 09 Oct 2022 12:56:52 -0400 Date: Sun, 09 Oct 2022 18:56:51 +0200 Message-Id: <878rlp5418.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #55360 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) merge 55360 58375 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 13 03:04:40 2022 Received: (at 58375) by debbugs.gnu.org; 13 Oct 2022 07:04:40 +0000 Received: from localhost ([127.0.0.1]:59244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oisGm-0006PI-DQ for submit@debbugs.gnu.org; Thu, 13 Oct 2022 03:04:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oisGh-0006Ox-B8; Thu, 13 Oct 2022 03:04:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47824) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oisGZ-0000Kk-QG; Thu, 13 Oct 2022 03:04:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=3ugSvfXff1YuNEnDZ8sKVUbqEb+yytPunv/FFbTVeYs=; b=idd0u3iV/4yNuLXRNP84 kwGF78ClNFuWfQ4Tu0Qruseflut0rri9HSGH9N1Z+EADJi0FdU9ZLla5SEDwKBkeMli/f5XsK0MZX j5IntgQZlyuCDa+O39LrFQGHhww3Ss/Kg9FykFz88F6AhsJzfxLqqcLbdWC3yXzvZRGpTiWpBWPCo LtuLV+7XjGMjtukraj4U2hFXP/qrc7a8r46nDgbH8GC+EyPpvlTYbikQL04jsJYFNJNtjByX0Wdm4 TQoZwFGEAu0eX6Z+sN+t0ezRyz52zNM1FxF+fiskUhgwP/DN3eM7OnW6vBb11ueNhidLNJPwuImkH uwnh/dpHYhk9Fg==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2775.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2775]:59700 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oisGG-0008Or-Ab; Thu, 13 Oct 2022 03:04:26 -0400 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#58375: Installer does not show what is being downloaded References: <87pmkko21t.fsf@gnu.org> <87y1wqw5tx.fsf@gnu.org> Date: Thu, 13 Oct 2022 09:04:02 +0200 In-Reply-To: <87y1wqw5tx.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Mon, 18 Jul 2022 21:58:50 +0200") Message-ID: <87lepk5hnh.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58375 Cc: Josselin Poiret , 55360@debbugs.gnu.org, 58375@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey Ludo! > I=E2=80=99m not sure it=E2=80=99s a good idea for =E2=80=98guix system in= it=E2=80=99: we=E2=80=99d be logging > mostly progress bars, package names, and the likes to syslog=E2=80=94not = super > useful. So I=E2=80=99d suggest not capturing stdout of =E2=80=98guix sys= tem init=E2=80=99. In the bug report https://issues.guix.gnu.org/57983 capturing the 'guix system init' output highlighted a "guix substitute" crash. So it does seem like a useful mechanism, especially while 56005 is still open. Now the current situation is also not really acceptable. What about hiding the "guix system init" output completely and display a progress bar page instead? Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 13 09:22:11 2022 Received: (at 58375) by debbugs.gnu.org; 13 Oct 2022 13:22:11 +0000 Received: from localhost ([127.0.0.1]:59939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiyA7-0004VE-4v for submit@debbugs.gnu.org; Thu, 13 Oct 2022 09:22:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiyA4-0004Uv-J7; Thu, 13 Oct 2022 09:22:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47012) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiy9z-0003ey-6H; Thu, 13 Oct 2022 09:22:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=DFSdyUBeDGpkIGR1Qnb9pzynxf9qLRN7rtzghbtYR3s=; b=nL29Zx8x2xP8HBbEykJ2 wTZg4JwROyxb7xi0tHY34PeJpvKGuL+qgj8i1Jwr+xVGo+A1044T0eRgBLNMPnkH3NTsmDis76cJE Rd530rhaU+tAo+2LbkL8nbFUv59wagdguybsRKGApmNVkjd2b+kiZcMSdvRZMPlv6b+ih/VSU7W0F p9ram6MUiH3pgYCDlwNt+wpHSkoaY7X5YUsWZApC3ZCe6PACKQQsix0hxbi/DUaMMYO6wF+TkJh0j hQp9E0a+gX6DLH8Srrmx9uEadjioZvMgu6HuZHdAQ0aJF9cAHFsED6YVq+OtztStAlMhwRGgN9CtU eDgsUWhKZ69cXg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:51868 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiy9s-0006sB-Ai; Thu, 13 Oct 2022 09:21:59 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#58375: Installer does not show what is being downloaded References: <87pmkko21t.fsf@gnu.org> <87y1wqw5tx.fsf@gnu.org> <87lepk5hnh.fsf_-_@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Duodi 22 =?utf-8?Q?Vend=C3=A9miaire?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour de la =?utf-8?Q?P=C3=AAche?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 13 Oct 2022 15:21:53 +0200 In-Reply-To: <87lepk5hnh.fsf_-_@gnu.org> (Mathieu Othacehe's message of "Thu, 13 Oct 2022 09:04:02 +0200") Message-ID: <87zgdzq2oe.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58375 Cc: Josselin Poiret , 55360@debbugs.gnu.org, 58375@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Mathieu Othacehe skribis: >> I=E2=80=99m not sure it=E2=80=99s a good idea for =E2=80=98guix system i= nit=E2=80=99: we=E2=80=99d be logging >> mostly progress bars, package names, and the likes to syslog=E2=80=94not= super >> useful. So I=E2=80=99d suggest not capturing stdout of =E2=80=98guix sy= stem init=E2=80=99. > > In the bug report https://issues.guix.gnu.org/57983 capturing the 'guix > system init' output highlighted a "guix substitute" crash. So it does > seem like a useful mechanism, especially while 56005 is still open. Hmm right. is not installer-specific, so it=E2=80=99s annoying that we have to prepare for th= at, but we can=E2=80=99t deny such bugs exist and prevent installation. If we really want to capture the output of =E2=80=98guix system init=E2=80= =99, then we need to open a pseudo-terminal with =E2=80=98openpty=E2=80=99 & co. instead= of =E2=80=98pipe=E2=80=99 in =E2=80=98run-external-command-with-handler=E2=80=99. That may be relativel= y easy actually. But then I think this should be used sparsely, maybe only for =E2=80=98guix system init=E2=80=99. > Now the current situation is also not really acceptable. Nope. :-) > What about hiding the "guix system init" output completely and display > a progress bar page instead? I don=E2=80=99t think we can do that (with grafts, only part of the build p= lan is known upfront so we don=E2=80=99t even know beforehand how many items wi= ll be built/downloaded). Also, I think there are two strategies: either we run =E2=80=98guix system init=E2=80=99, in which case we let its output through, or we integrate =E2= =80=98guix system init=E2=80=99 functionality in the installer so we have more fine-gr= ain control over the process, in which case we could also have more graphical output or something. That second solution is a lot of work, though. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 14 11:44:41 2022 Received: (at 58375) by debbugs.gnu.org; 14 Oct 2022 15:44:41 +0000 Received: from localhost ([127.0.0.1]:38383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojMrY-0007Ri-Lv for submit@debbugs.gnu.org; Fri, 14 Oct 2022 11:44:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojMrW-0007RP-CH; Fri, 14 Oct 2022 11:44:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojMrN-000454-5M; Fri, 14 Oct 2022 11:44:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=fkR9vMg9G4UMYdCbRM4yvWrJz0zSsN7OSxK0cD4/fhs=; b=UGF+J25hLZR5BdXdCDdA 3u8YwVy2cACadWNQ0VE3HIC5vdzS86JeDg9vG2kIe5meQcMbfKYmz6qRNg3cNpfh/g90cv5aGdpVS Yl8+E/80Yy08fVfJZYt/1J4E7m+uzSTK7vQmVAVN8rp0R3Med2u8NYSS3JIFtntTTiucUVNLy+xKh 2M2QZypOdtlwTeYjxjkg1oRMRT6pGQkibEqMvv9IUgDjUDyiW37ZQDAMID+OSFcRjYndN1FodNcTZ aXcH9HuFugADGFZhyhBkst/rpusa/qbfav4B9y+CkI3hSn5yVwaA2gjwxG4UalO6qqB5G/YMwX8iF bb3zTVHEBjaTeg==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2775.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2775]:48042 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojMrM-0004z1-GB; Fri, 14 Oct 2022 11:44:28 -0400 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#58375: Installer does not show what is being downloaded References: <87pmkko21t.fsf@gnu.org> <87y1wqw5tx.fsf@gnu.org> <87lepk5hnh.fsf_-_@gnu.org> <87zgdzq2oe.fsf@gnu.org> Date: Fri, 14 Oct 2022 17:44:24 +0200 In-Reply-To: <87zgdzq2oe.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Thu, 13 Oct 2022 15:21:53 +0200") Message-ID: <871qrabeav.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58375 Cc: Josselin Poiret , 55360@debbugs.gnu.org, 58375@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hey, > If we really want to capture the output of =E2=80=98guix system init=E2= =80=99, then we > need to open a pseudo-terminal with =E2=80=98openpty=E2=80=99 & co. inste= ad of =E2=80=98pipe=E2=80=99 in > =E2=80=98run-external-command-with-handler=E2=80=99. That may be relativ= ely easy > actually. So I implemented your proposal. It seems to be working quite well. As discussed on #guix, we could avoid to dump the download bars to the syslog if the "guix system init" command succeeds. However, it seems quite tricky in the current implementation where the syslog dumping is actually a hook (%syslog-line-hook). Fixing this issue, I also realized that when the "guix system init" command fails, the user is only offered to resume the installation or restart it. In cases where "guix system init" failed because of a network issue, or because a partition was too small, restarting/resuming seems like the right thing to do. However, when the installer failed because "guix system init" crashed or segfaulted, restarting/resuming won't probably help, and dumping the crash is probably the best way to get help. That's why I added in a second patch, a new button "Report the failure" to the "run-install-failed-page". Thanks, Mathieu --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-installer-Run-the-guix-system-init-command-in-a-PTY.patch >From c6286404e9c4c0dc302c3d398a8f27b050cf4ce0 Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Fri, 14 Oct 2022 17:28:27 +0200 Subject: [PATCH 1/2] installer: Run the "guix system init" command in a PTY. Fixes: * gnu/installer/utils.scm (run-external-command-with-handler/tty): New procedure. (run-external-command-with-line-hooks, run-command): Add a TTY? argument. * gnu/installer/final.scm (install-system): Call run-command with TTY? argument set to #true. --- gnu/installer/final.scm | 2 +- gnu/installer/utils.scm | 50 +++++++++++++++++++++++++++++++++-------- 2 files changed, 42 insertions(+), 10 deletions(-) diff --git a/gnu/installer/final.scm b/gnu/installer/final.scm index 3f6dacc490..044f79372b 100644 --- a/gnu/installer/final.scm +++ b/gnu/installer/final.scm @@ -211,7 +211,7 @@ (define (assert-exit x) (setenv "PATH" "/run/current-system/profile/bin/") - (set! ret (run-command install-command))) + (set! ret (run-command install-command #:tty? #t))) (lambda () ;; Restart guix-daemon so that it does no keep the MNT namespace ;; alive. diff --git a/gnu/installer/utils.scm b/gnu/installer/utils.scm index 5fd2e2d425..061493e6a7 100644 --- a/gnu/installer/utils.scm +++ b/gnu/installer/utils.scm @@ -20,6 +20,7 @@ (define-module (gnu installer utils) #:use-module (gnu services herd) #:use-module (guix utils) + #:use-module ((guix build syscalls) #:select (openpty login-tty)) #:use-module (guix build utils) #:use-module (guix i18n) #:use-module (srfi srfi-1) @@ -45,6 +46,7 @@ (define-module (gnu installer utils) nearest-exact-integer read-percentage run-external-command-with-handler + run-external-command-with-handler/tty run-external-command-with-line-hooks run-command run-command-in-installer @@ -124,10 +126,37 @@ (define dummy-pipe (close-port input) (close-pipe dummy-pipe))) -(define (run-external-command-with-line-hooks line-hooks command) +(define (run-external-command-with-handler/tty handler command) + "Run command specified by the list COMMAND in a child operating in a +pseudoterminal with output handler HANDLER. HANDLER is a procedure taking an +input port, to which the command will write its standard output and error. +Returns the integer status value of the child process as returned by waitpid." + (define-values (controller inferior) + (openpty)) + + (match (primitive-fork) + (0 + (catch #t + (lambda () + (close-fdes controller) + (login-tty inferior) + (apply execlp (car command) command)) + (lambda _ + (primitive-exit 127)))) + (pid + (close-fdes inferior) + (let* ((port (fdopen controller "r0")) + (result (false-if-exception + (handler port)))) + (close-port port) + (cdr (waitpid pid)))))) + +(define* (run-external-command-with-line-hooks line-hooks command + #:key (tty? #false)) "Run command specified by the list COMMAND in a child, processing each -output line with the procedures in LINE-HOOKS. Returns the integer status -value of the child process as returned by waitpid." +output line with the procedures in LINE-HOOKS. If TTY is set to #true, the +COMMAND will be run in a pseudoterminal. Returns the integer status value of +the child process as returned by waitpid." (define (handler input) (and (and=> (get-line input) @@ -136,14 +165,17 @@ (define (handler input) #f (begin (for-each (lambda (f) (f line)) (append line-hooks - %default-installer-line-hooks)) + %default-installer-line-hooks)) #t)))) (handler input))) - (run-external-command-with-handler handler command)) + (if tty? + (run-external-command-with-handler/tty handler command) + (run-external-command-with-handler handler command))) -(define* (run-command command) +(define* (run-command command #:key (tty? #f)) "Run COMMAND, a list of strings. Return true if COMMAND exited -successfully, #f otherwise." +successfully, #f otherwise. If TTY is set to #true, the COMMAND will be run +in a pseudoterminal." (define (pause) (format #t (G_ "Press Enter to continue.~%")) (send-to-clients '(pause)) @@ -154,8 +186,8 @@ (define (pause) (installer-log-line "running command ~s" command) (define result (run-external-command-with-line-hooks - (list %display-line-hook) - command)) + (list %display-line-hook) command + #:tty? tty?)) (define exit-val (status:exit-val result)) (define term-sig (status:term-sig result)) (define stop-sig (status:stop-sig result)) -- 2.37.3 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0002-installer-Propose-the-user-to-report-a-guix-system-i.patch >From 159b82a013cad8c3c698031cce9ee07956153da3 Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Fri, 14 Oct 2022 17:33:28 +0200 Subject: [PATCH 2/2] installer: Propose the user to report a "guix system init" failure. * gnu/installer/newt/final.scm (run-install-failed-page): Add a "Report the failure" button. --- gnu/installer/newt/final.scm | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/gnu/installer/newt/final.scm b/gnu/installer/newt/final.scm index 7c3f73ee82..6e55be5067 100644 --- a/gnu/installer/newt/final.scm +++ b/gnu/installer/newt/final.scm @@ -80,16 +80,21 @@ (define (run-install-success-page) (define (run-install-failed-page) (match (current-clients) (() - (match (choice-window + (match (ternary-window (G_ "Installation failed") (G_ "Resume") (G_ "Restart the installer") + (G_ "Report the failure") (G_ "The final system installation step failed. You can resume from \ a specific step, or restart the installer.")) (1 (abort-to-prompt 'installer-step 'abort)) (2 ;; Keep going, the installer will be restarted later on. - #t))) + #t) + (3 (raise + (condition + (&message + (message "User abort."))))))) (_ (send-to-clients '(installation-failure)) #t))) -- 2.37.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 18 11:18:23 2022 Received: (at 58375) by debbugs.gnu.org; 18 Oct 2022 15:18:23 +0000 Received: from localhost ([127.0.0.1]:53789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okoM7-0007gy-Tp for submit@debbugs.gnu.org; Tue, 18 Oct 2022 11:18:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okoLr-0007gB-L2; Tue, 18 Oct 2022 11:18:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49452) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okoLl-0006Jn-So; Tue, 18 Oct 2022 11:17:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=/kSe6w2Cm36fLYagT5nqSB5UV6ylkOgU95xK3KcF49w=; b=Gvem/dLEK4jqtlGoNsRs EYBnSj4pCjAacFYj8DZdLQlHLWxr6FWIKCqgtCgCOqOoZ3mWAx3TruZC3xQt0fe/CD/m3LHIT0PYz bzn899uIxWb4oP8dpWIFYoqEmrm81KbFmTWFltkh30te5pybINXzdxDh2211X4DwV/CnFvK9uKgV3 AomrJV4tw4XhNAVY4Bc70vQrqb2mOLcW4ifr/2MSgAxj+t2Z/1nSoVITEFirj8aR+FpQyoYrWlKvM Js+PpZ/DMUIxJKR+pNUaV6pcYfaX2NqmKijyb3KnyNDctyFRy4k36WetWf+3z5ToTbgTVh9X9hILi N8C3wX/2wzaxWg==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=41874 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okoLk-0004N5-Oe; Tue, 18 Oct 2022 11:17:48 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#58375: Installer does not show what is being downloaded References: <87pmkko21t.fsf@gnu.org> <87y1wqw5tx.fsf@gnu.org> <87lepk5hnh.fsf_-_@gnu.org> <87zgdzq2oe.fsf@gnu.org> <871qrabeav.fsf_-_@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Septidi 27 =?utf-8?Q?Vend=C3=A9miaire?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Piment X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 18 Oct 2022 17:17:47 +0200 In-Reply-To: <871qrabeav.fsf_-_@gnu.org> (Mathieu Othacehe's message of "Fri, 14 Oct 2022 17:44:24 +0200") Message-ID: <87czapma90.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58375 Cc: Josselin Poiret , 55360@debbugs.gnu.org, 58375@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Mathieu, Mathieu Othacehe skribis: > So I implemented your proposal. It seems to be working quite well. As > discussed on #guix, we could avoid to dump the download bars to the > syslog if the "guix system init" command succeeds. However, it seems > quite tricky in the current implementation where the syslog dumping is > actually a hook (%syslog-line-hook). Yes. I haven=E2=80=99t actually tested the patch but it LGTM. One thing to chec= k is whether =E2=80=98terminal-window-size=E2=80=99 returns something sensible f= or the pseudo-terminal; it could be that we need an extra ioctl so the pseudo-terminal has the same size as the actual terminal. > Fixing this issue, I also realized that when the "guix system init" > command fails, the user is only offered to resume the installation or > restart it. > > In cases where "guix system init" failed because of a network issue, or > because a partition was too small, restarting/resuming seems like the > right thing to do. > > However, when the installer failed because "guix system init" crashed or > segfaulted, restarting/resuming won't probably help, and dumping the > crash is probably the best way to get help. That's why I added in a > second patch, a new button "Report the failure" to the > "run-install-failed-page". Neat! > From c6286404e9c4c0dc302c3d398a8f27b050cf4ce0 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Fri, 14 Oct 2022 17:28:27 +0200 > Subject: [PATCH 1/2] installer: Run the "guix system init" command in a P= TY. > > Fixes: > > * gnu/installer/utils.scm (run-external-command-with-handler/tty): New > procedure. > (run-external-command-with-line-hooks, run-command): Add a TTY? argument. > * gnu/installer/final.scm (install-system): Call run-command with TTY? > argument set to #true. LGTM, modulo the terminal size issue mentioned above. > From 159b82a013cad8c3c698031cce9ee07956153da3 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Fri, 14 Oct 2022 17:33:28 +0200 > Subject: [PATCH 2/2] installer: Propose the user to report a "guix system > init" failure. > > * gnu/installer/newt/final.scm (run-install-failed-page): Add a "Report t= he > failure" button. LGTM. Thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 20 10:40:22 2022 Received: (at 58375-done) by debbugs.gnu.org; 20 Oct 2022 14:40:23 +0000 Received: from localhost ([127.0.0.1]:35898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1olWic-0000L2-Hc for submit@debbugs.gnu.org; Thu, 20 Oct 2022 10:40:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1olWiZ-0000Kh-Iv; Thu, 20 Oct 2022 10:40:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35130) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olWiT-0004S7-9X; Thu, 20 Oct 2022 10:40:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=xq8qCLhr/yT7fmIPsPynd2yaLg2UsCANvV6zqIAXLaM=; b=mw9gkFMy1U+waSOzdta/ RoNFNCt0wOo/BrDMpJn1R1NvcpC91J/cs4tNDCv8VL1HxodwJCdeWaADh3dBMm5cbJ7U+d+umK7GO 4MtS06CJDDsnaBH112vOIGVN8QFbI4wEBXa3B5f4/KkxoFTPJRHhHQRsm+2qc/uGLVKi4LrFIPhut GaZiT3suMwTqJ4rMRP8iHm91tctS8j8z5bSMMkt+mgak6b2OGf+EUNhNnAU0CBoQVLUN0AxFL2o+Y WEDWmyYOWWRXSRzMZDTZwzby54r6E2Sm5ySbqYjEGWNCX/E6oAlPdi7FaHHSWT3+GFNDSeusBpsFT Ki/5p6sjd62V1w==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2775.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2775]:59608 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olWiR-0002Mf-RD; Thu, 20 Oct 2022 10:40:12 -0400 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#58375: Installer does not show what is being downloaded References: <87pmkko21t.fsf@gnu.org> <87y1wqw5tx.fsf@gnu.org> <87lepk5hnh.fsf_-_@gnu.org> <87zgdzq2oe.fsf@gnu.org> <871qrabeav.fsf_-_@gnu.org> <87czapma90.fsf@gnu.org> Date: Thu, 20 Oct 2022 16:40:08 +0200 In-Reply-To: <87czapma90.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Tue, 18 Oct 2022 17:17:47 +0200") Message-ID: <875ygepnhz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58375-done Cc: Josselin Poiret , 55360-done@debbugs.gnu.org, 58375-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey, Thanks for having a look! > I haven=E2=80=99t actually tested the patch but it LGTM. One thing to ch= eck is > whether =E2=80=98terminal-window-size=E2=80=99 returns something sensible= for the > pseudo-terminal; it could be that we need an extra ioctl so the > pseudo-terminal has the same size as the actual terminal. Well it returns 0 for all fields, but I tested on several screen sizes and everything seems fine so I went ahead. While testing I noticed two new issues though: 1. When the disk is GPT partitionned there is no confirmation page in "run-label-page". Something I missed in #57232. 2. When there is an exception in run-external-command-with-handler/tty for instance, the backtrace page is displayed in the PTY and the keyboard shortcuts do not work anymore. I'll address point 1 shortly but could use some advice for point 2. Thanks, Mathieu From unknown Fri Jun 20 18:23:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 18 Nov 2022 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator