From unknown Sat Jun 14 18:06:01 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#58365 <58365@debbugs.gnu.org> To: bug#58365 <58365@debbugs.gnu.org> Subject: Status: [PATCH 0/6] Support #:tests? in guile-build-system Reply-To: bug#58365 <58365@debbugs.gnu.org> Date: Sun, 15 Jun 2025 01:06:01 +0000 retitle 58365 [PATCH 0/6] Support #:tests? in guile-build-system reassign 58365 guix-patches submitter 58365 Maxime Devos severity 58365 normal tag 58365 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 07 16:48:03 2022 Received: (at submit) by debbugs.gnu.org; 7 Oct 2022 20:48:03 +0000 Received: from localhost ([127.0.0.1]:37514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oguGJ-0003ls-6X for submit@debbugs.gnu.org; Fri, 07 Oct 2022 16:48:03 -0400 Received: from lists.gnu.org ([209.51.188.17]:44980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oguGG-0003lO-VZ for submit@debbugs.gnu.org; Fri, 07 Oct 2022 16:48:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oguGD-0000EU-Lp for guix-patches@gnu.org; Fri, 07 Oct 2022 16:48:00 -0400 Received: from albert.telenet-ops.be ([2a02:1800:110:4::f00:1a]:34038) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oguGB-0002DP-0K for guix-patches@gnu.org; Fri, 07 Oct 2022 16:47:57 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by albert.telenet-ops.be with bizsmtp id V8np2800920ykKC068npJU; Fri, 07 Oct 2022 22:47:49 +0200 Message-ID: Date: Fri, 7 Oct 2022 22:47:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-US To: "guix-patches@gnu.org" From: Maxime Devos Subject: [PATCH 0/6] Support #:tests? in guile-build-system Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------o80Ktxkc4psFMldSGTgbQ4Nm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1665175669; bh=+fHMLpYqhRD9r1Yha0HUjGWi0iOLHTKRAxek90BuTBM=; h=Date:To:From:Subject; b=UiQxVuMjd5iGkaVjWd1OPN3dwl9mUdFzesoLNmfyH4uaxlmyi/JoCQPTg4BasT7QE iZIiySwRXI+XCOC+ThORVltlwjkTTucH+NNFWfgHnysC4SnMsVYcHZCjqJvcl77UC3 qFlTfLUsOmEh2o20h2wf3cBH4yMy8tKL8SMFzkQUzg0s2BHJygVSkaGuJ9h+2PD7Qg 6BIw94VbaZq59Wvdfl3mgellBGMM3OaLNxIj9r7ZSN8nt9yQAx2Tx0Caus1S923IcQ o60agfBVf1eAU43a/NGLwhL9h85gU1tYOBPRvyErNuTMSBDbnI9avPlf2kO33IJHlP 9PtoBWLl16cOA== Received-SPF: pass client-ip=2a02:1800:110:4::f00:1a; envelope-from=maximedevos@telenet.be; helo=albert.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------o80Ktxkc4psFMldSGTgbQ4Nm Content-Type: multipart/mixed; boundary="------------RcoaLWqS4SDLHHTPd4lIHcwA"; protected-headers="v1" From: Maxime Devos To: "guix-patches@gnu.org" Message-ID: Subject: [PATCH 0/6] Support #:tests? in guile-build-system --------------RcoaLWqS4SDLHHTPd4lIHcwA Content-Type: multipart/mixed; boundary="------------0tFClC5Th0YvGSKzPLwAZzVU" --------------0tFClC5Th0YvGSKzPLwAZzVU Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 Rml4ZXM6IDxodHRwczovL2lzc3Vlcy5ndWl4LmdudS5vcmcvNTgzMzc+DQoNCmd1aWxlLWJ1 aWxkLXN5c3RlbSBjYW4ndCBndWVzcyB3aGVyZSB0aGUgdGVzdHMgYXJlIGxvY2F0ZWQsIHNv IGN1cnJlbnRseSANCml0J3Mgb3B0LWluLCB2aWEgIzp0ZXN0LXNjcmlwdC4gIEFmdGVyIHRo aXMgcGF0Y2ggc2VyaWVzLCBpdCBpcyANCmN1cnJlbnRseSBvbmx5IHVzZWQgYnkgZ3VpbGUt ZmZpLWZmdHcsIGJ1dCBvdGhlciBndWlsZS1idWlsZC1zeXN0ZW0gDQpwYWNrYWdlcyB0aGF0 IHVzZSBTUkZJLTY0IGNvdWxkIHBvdGVudGlhbGx5IHVzZSBpdCB0b28gKGUuZy4gDQpndWls ZS1zcmZpLTExNywgd2hpY2ggaXMgbm90IHBhY2thZ2VzIG9yIGV2ZW4gcmVsZWFzZWQgeWV0 KS4NCg0KKiBGaXJzdCBjb21taXQ6IHBhY2thZ2UgYSB0ZXN0IGRyaXZlciwgZm9yIG5pY2Vy IG91dHB1dCBhbmQgZm9yIHByb3BlciANCmV4aXQgc3RhdHVzLiAgSSBjb3BpZWQgdGVzdC1k cml2ZXIuc2NtIHRvIGF1eC1maWxlcyBzdWNoIHRoYXQgDQp0ZXN0LWRyaXZlci5zY20gY2Fu IGJlIGNoYW5nZWQgd2l0aG91dCB3b3JyeWluZyBhYm91dCByZWJ1aWxkcy4gIE9UT0gsIA0K aXQgaXNuJ3QgbW9kaWZpZWQgdGhhdCBvZnRlbiwgc28gdGhhdCBjb3VsZCBiZSBsZWZ0IG91 dC4NCg0KQWxzbywgY29weWluZyB0ZXN0LWRyaXZlci5zY20gY2F1c2VzIHRoZSBmb2xsb3dp bmc6DQoNCmd1aXggYnVpbGQ6IHdhcm5pbmc6IGZhaWxlZCB0byBsb2FkICcoZ251IHBhY2th Z2VzIGF1eC1maWxlcyB0ZXN0LWRyaXZlciknOg0Kbm8gY29kZSBmb3IgbW9kdWxlIChnbnUg cGFja2FnZXMgYXV4LWZpbGVzIHRlc3QtZHJpdmVyKQ0KaGludDogRmlsZSANCmAvaG9tZS9h bnRpcG9kZS9zb3VyY2UtY29kZS9ndWl4LW1hc3Rlci9nbnUvcGFja2FnZXMvYXV4LWZpbGVz L3Rlc3QtZHJpdmVyLnNjbScgDQpzaG91bGQgcHJvYmFibHkgc3RhcnQgd2l0aDoNCg0KICAg ICAgKGRlZmluZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBhdXgtZmlsZXMgdGVzdC1kcml2ZXIp KQ0KDQpXaGF0ZXZlciBjb2RlIGRvZXMgdGhpcyBsb2FkaW5nLCBzaG91bGQgcHJvYmFibHkg YmUgbW9kaWZpZWQgdG8gbm90IGxvYWQgDQp0aGluZ3MgdW5kZXIgYXV4LWZpbGVzLg0KDQpH b2luZyBieSAiZ2l0IGxvZyIsIHRoZSB1cHN0cmVhbSBvZiB0aGlzIHRlc3QgZHJpdmVyIGlz IEd1aXggaXRzZWxmLg0KDQoqIFNlY29uZCBjb21taXQ6IGFkZCBzdXBwb3J0IGZvciAjOnRl c3RzPywgdXNpbmcgdGhlIHRlc3QgZHJpdmVyLg0KKiBUaGlyZCBjb21taXQ6IHVzZSBpdCBp biBndWlsZS1mZmktZmZ0dy4NCiogRm91cnRoIGFuZCBmaWZ0aCBjb21taXQ6IGNsZWFudXAg b2YgZ3VpbGUtZmZpLWZmdHcuDQoqIFNpeHRoIGNvbW1pdDogYWRqdXN0IGd1aWxlLWFjLWQt YnVzIHRvIG5ldyAnY2hlY2snIHBoYXNlDQoNCk9ubHkgdGhlIGluaXRpYWwgY29tbWl0IGlz IHJlcXVpcmVkIGZvciBhZGRpbmcgc3VwcG9ydCBmb3IgdGVzdHMuDQoNCkknbGwgbGVhdmUg YnVpbGRpbmcgZGVwZW5kZW5jaWVzIHRvIDxodHRwczovL3FhLmd1aXguZ251Lm9yZy8+Lg0K DQpHcmVldGluZ3MsDQpNYXhpbWUuDQo= --------------0tFClC5Th0YvGSKzPLwAZzVU Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------0tFClC5Th0YvGSKzPLwAZzVU-- --------------RcoaLWqS4SDLHHTPd4lIHcwA-- --------------o80Ktxkc4psFMldSGTgbQ4Nm Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCY0CQdQUDAAAAAAAKCRBJ4+4iGRcl7qp3 AP92NhTKOc4LEmG/jlrvadTQ1Rw0JtoF+TB6BUaalu67aQD/TKJqB4FGlxSCuQyFL/naEIykxhlF cwuT4TFiicfgzAc= =JAdH -----END PGP SIGNATURE----- --------------o80Ktxkc4psFMldSGTgbQ4Nm-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 07 16:53:59 2022 Received: (at 58365) by debbugs.gnu.org; 7 Oct 2022 20:53:59 +0000 Received: from localhost ([127.0.0.1]:37539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oguM3-0003vf-JR for submit@debbugs.gnu.org; Fri, 07 Oct 2022 16:53:59 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:40962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oguM0-0003v7-LH for 58365@debbugs.gnu.org; Fri, 07 Oct 2022 16:53:57 -0400 Received: from localhost.localdomain ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by laurent.telenet-ops.be with bizsmtp id V8tu2800920ykKC018tvFV; Fri, 07 Oct 2022 22:53:55 +0200 From: Maxime Devos To: 58365@debbugs.gnu.org Subject: [PATCH 6/6] guile-ac-d-bus: Don't duplicate 'check' phase. Date: Fri, 7 Oct 2022 22:53:52 +0200 Message-Id: <20221007205352.1282-6-maximedevos@telenet.be> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221007205352.1282-1-maximedevos@telenet.be> References: <20221007205352.1282-1-maximedevos@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1665176035; bh=aZbjeuw+7bvIRoCctY7daLGCA6VyxP9bmLoo1omsXfE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=G5HpgZFR750JTGuCBiPuQo/hLW/KFDpXTnzEyNSW/tH7xL8PbUaNrWWEszQZYDUrF MSMEMkRsF08fmOBqFTwsev3X/2GsZaeDSQdDL+fn09ChyifYbhIgmSxBGChvRn7uXE g0wel2qCCNAFMlycEVn72zRgBjOrXChUsWZSNJfYwJdf7YJuAK9lhGS/Z+3rqWcmG7 3pP6p5v49MRWe8cgcljTOOfCRjVCXsfrX/x/8c8S+I2XQ/eu4LFInL9mO2doPP4kHE tk70kgN/xQ7ceuorpk2O7T5VihojOfCxJ6imiCnEx1e2DK1Ixx4XwEFDGx0W+36Ybo FYLB/G72/OfaA== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58365 Cc: Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Now guile-build-system has a 'check' phase, the 'check' phase is duplicated. It's harmless, but let's not. * gnu/packages/guile-xyz.scm (guile-ac-d-bus)[arguments]<#:phases>{check}: Instead of adding the phase, replace it. --- gnu/packages/guile-xyz.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm index 711e2eade9..0339bf8281 100644 --- a/gnu/packages/guile-xyz.scm +++ b/gnu/packages/guile-xyz.scm @@ -3911,7 +3911,7 @@ (define (guile-sls->sls file) (lambda _ (with-directory-excursion "docs" (invoke "makeinfo" "ac-d-bus")))) - (add-after 'build-doc 'check + (replace 'check (lambda* (#:key (tests? #t) #:allow-other-keys) (when tests? ;; There is no locale for the ö character, which crashes -- 2.37.3 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 07 16:54:00 2022 Received: (at 58365) by debbugs.gnu.org; 7 Oct 2022 20:54:00 +0000 Received: from localhost ([127.0.0.1]:37541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oguM3-0003vo-Sb for submit@debbugs.gnu.org; Fri, 07 Oct 2022 16:54:00 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:40936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oguM0-0003v3-LF for 58365@debbugs.gnu.org; Fri, 07 Oct 2022 16:53:57 -0400 Received: from localhost.localdomain ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by laurent.telenet-ops.be with bizsmtp id V8tu2800920ykKC018tvFN; Fri, 07 Oct 2022 22:53:55 +0200 From: Maxime Devos To: 58365@debbugs.gnu.org Subject: [PATCH 3/6] guile-ffi-fftw: Respect #:tests?. Date: Fri, 7 Oct 2022 22:53:49 +0200 Message-Id: <20221007205352.1282-3-maximedevos@telenet.be> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221007205352.1282-1-maximedevos@telenet.be> References: <20221007205352.1282-1-maximedevos@telenet.be> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1665176035; bh=Pt16bfvbWzVx0zCQnYB8P2GrRgrIbjiB9pyjCoQQ130=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=gxaBnc9piH7YE9waFl3imL6FzFqVhAj44S2Y5/ZHMqpda2jfBcqOQIPOyuFoQdPNZ LajCYrLNCziORzIwAX9Mj3bwf8TdARXIa11T8tsfa2zTPHTSDh3JTjxLXS/n4dvqg8 Rp4lrzex6Mrk1lfuU6NBk98pQalMdq8wzCwLPu6dCcdkgxzs200rNFhnRZFklWPlJv xDkWxeZZ3EYRTS+Fk+r23RNB/NIrH1dsMrpoflCxbJkvjXJ2BJNg4LaHHNKZIyDtB3 0X6VTQunge0NZc3nZ2pAtJPZSo6tbQd9AYa9mP2WkLPA2TJ2sDMViHZwX3a+E1TpNw CZYTO6S96ROrQ== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58365 Cc: Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/guile-xyz.scm (guile-ffi-fftw)[arguments]<#:test-script>: Set it. [arguments]{#:phases}{check}: Remove custom phase. [native-inputs]: Add native-input required by uncustomised 'check' phase. --- gnu/packages/guile-xyz.scm | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm index 56f0bb8acc..2ab5683d19 100644 --- a/gnu/packages/guile-xyz.scm +++ b/gnu/packages/guile-xyz.scm @@ -3682,6 +3682,7 @@ (define-public guile-ffi-fftw (build-system guile-build-system) (arguments `(#:source-directory "mod" + #:test-script "../test/test-ffi-fftw.scm" #:phases (modify-phases %standard-phases (add-after 'unpack 'prepare-build @@ -3689,11 +3690,8 @@ (define-public guile-ffi-fftw (substitute* "mod/ffi/fftw.scm" (("\\(getenv \"GUILE_FFI_FFTW_LIBFFTW3_PATH\"\\)") (format #f "\"~a/lib\"" (assoc-ref inputs "fftw")))) - #t)) - (add-after 'build 'check - (lambda _ - (invoke "guile" "-L" "mod" - "-s" "test/test-ffi-fftw.scm")))))) + #t))))) + (native-inputs (list guile-test-driver)) (inputs (list fftw guile-2.2)) (home-page "https://github.com/lloda/guile-ffi-fftw/") -- 2.37.3 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 07 16:54:00 2022 Received: (at 58365) by debbugs.gnu.org; 7 Oct 2022 20:54:00 +0000 Received: from localhost ([127.0.0.1]:37543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oguM4-0003vu-6S for submit@debbugs.gnu.org; Fri, 07 Oct 2022 16:54:00 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:40956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oguM0-0003v5-LG for 58365@debbugs.gnu.org; Fri, 07 Oct 2022 16:53:58 -0400 Received: from localhost.localdomain ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by laurent.telenet-ops.be with bizsmtp id V8tu2800920ykKC018tvFT; Fri, 07 Oct 2022 22:53:55 +0200 From: Maxime Devos To: 58365@debbugs.gnu.org Subject: [PATCH 5/6] guile-ffi-fftw: Update to new Guile version. Date: Fri, 7 Oct 2022 22:53:51 +0200 Message-Id: <20221007205352.1282-5-maximedevos@telenet.be> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221007205352.1282-1-maximedevos@telenet.be> References: <20221007205352.1282-1-maximedevos@telenet.be> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1665176035; bh=2VkR/tVMkgTqcl8CyakIQxHRwHrIUSTt/wvK348qVpQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=IWIaKvM/Ensa94KISTbOyo1U73STM7nWeFv0Dm5U20XI+zpv+IKL/iTYX2aKwP/rd ktPQFrE4Bw1l+LgOzgZXOcp0kZO7z170imk4uF0oleeOofrVPgPI4wyLMOoitwI6PS pKGEOUFFxgHrhvUuOQWfEkw9YLK3znDubmNSyI83twYwZrU3oxqJSweR+WyeWeqDs6 ZsIojMNpkKlPP0LDZADqTJJSeQCZRUgXyxgGCMfJVMWfXdIkjB2tq7JiQpLfSHFY59 fPfvVhvLvtcq3nKMJplRcrBP8wHaNFCnCRal13p4PWmMF/JEnM9fU9Xks7xejd5Y54 rMYYp82A4/wTg== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58365 Cc: Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) It seems to build (including tests) fine and there are no dependents, so it appears safe to update to a newer Guile version. * gnu/packages/guile-xyz.scm (guile-ffi-fftw)[inputs]{guile-2.2}: Replace by guile-3.0. --- gnu/packages/guile-xyz.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm index a664e37968..711e2eade9 100644 --- a/gnu/packages/guile-xyz.scm +++ b/gnu/packages/guile-xyz.scm @@ -3693,7 +3693,7 @@ (define-public guile-ffi-fftw (dirname (search-input-file inputs "lib/libfftw3.so")))))))))) (native-inputs (list guile-test-driver)) - (inputs (list fftw guile-2.2)) + (inputs (list fftw guile-3.0)) (home-page "https://github.com/lloda/guile-ffi-fftw/") (synopsis "Access FFTW through Guile's FFI") (description -- 2.37.3 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 07 16:54:01 2022 Received: (at 58365) by debbugs.gnu.org; 7 Oct 2022 20:54:01 +0000 Received: from localhost ([127.0.0.1]:37545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oguM4-0003w6-HF for submit@debbugs.gnu.org; Fri, 07 Oct 2022 16:54:01 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:40930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oguM0-0003v2-L2 for 58365@debbugs.gnu.org; Fri, 07 Oct 2022 16:53:58 -0400 Received: from localhost.localdomain ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by laurent.telenet-ops.be with bizsmtp id V8tu2800920ykKC018tvFL; Fri, 07 Oct 2022 22:53:55 +0200 From: Maxime Devos To: 58365@debbugs.gnu.org Subject: [PATCH 2/6] build-system/guile: Run SRFI-64 tests. Date: Fri, 7 Oct 2022 22:53:48 +0200 Message-Id: <20221007205352.1282-2-maximedevos@telenet.be> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221007205352.1282-1-maximedevos@telenet.be> References: <20221007205352.1282-1-maximedevos@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1665176035; bh=TWP8pWUy6TlUor/aXGtz1XUdfD0vWzqHuG48lxids1M=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=XpW1CFO+OAN3fKGnJAUVQMIEq8MmNMFx/1NMoadgCG1oLz3LNpeCVXw3/DpTm6UGZ ciG8CmgVIXtlpPjWIvRz1EHN5dk83QjQrKI5fp8/7sb0K818jDqh8dOlRf3WNV1/5n fceIX0CpElLpIeF77DHgbtZmn5w5Kn8qtZAmpRPacrzQa6kIcWycsgscWI5q4k8dT7 ve0wkBr3Jo/tQaygnq1Y0KZqkSXkEMcuR0zPj1pnYAb5+7E2QNaW/INXBEKXP/WDh4 L02Yl0Dr98rQqAsSgQCaXncjKw98asdc9A/0RXsIxDf/rH1HMKK44gJimFjZnV/B2i Y87BtPwli7gbQ== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58365 Cc: Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) The build system needs a hint for the location of the test suite(s), but aside from that tests are now run automatically. I expect having multiple test suites to be the exception, so I used 'test-script' instead of 'test-scripts'. Fixes: * guix/build-system/guile.scm (guile-build): Pass on 'tests?', 'test-script' and 'test-arguments'. (guile-cross-build): Likewise. * guix/build/guile-build-system.scm (guile-check): New phase. (%standard-phases)[check]: Use it. * doc/guix.texi (Build Systems)[guile-build-system]: Document new behaviour. --- doc/guix.texi | 15 ++++++++--- guix/build-system/guile.scm | 13 +++++++++ guix/build/guile-build-system.scm | 44 +++++++++++++++++++++++++++++-- 3 files changed, 67 insertions(+), 5 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 08dab8e5b1..858bcec96f 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -9022,13 +9022,22 @@ code and that are so lean that they don't even have a makefile, let alone a @file{configure} script. It compiles Scheme code using @command{guild compile} (@pxref{Compilation,,, guile, GNU Guile Reference Manual}) and installs the @file{.scm} and @file{.go} files in the right place. It also -installs documentation. +installs documentation and runs SRFI-64 test suites. + +Test suites cannot be found automatically; the location of the test +suite can be set with the @code{#:test-script} argument (as a string). +If there are multiple test scripts, this argument can be set to a staged +list of locations. Sometimes some tests need to be skipped, if so, +@code{#:test-arguments} can be a staged list with extra arguments to +pass to the test driver (see @code{test-driver.scm --help} for details). This build system supports cross-compilation by using the @option{--target} option of @samp{guild compile}. -Packages built with @code{guile-build-system} must provide a Guile package in -their @code{native-inputs} field. +Packages built with @code{guile-build-system} must provide a Guile +package in their @code{native-inputs} field. Additionally, if +@code{#:test-script} is used, a test driver (usually +@code{guile-test-driver}) must be provided. @end defvr @defvr {Scheme Variable} julia-build-system diff --git a/guix/build-system/guile.scm b/guix/build-system/guile.scm index 36a88e181a..75d62fe403 100644 --- a/guix/build-system/guile.scm +++ b/guix/build-system/guile.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2018-2019, 2021-2022 Ludovic Courtès +;;; Copyright © 2022 Maxime Devos ;;; ;;; This file is part of GNU Guix. ;;; @@ -78,6 +79,9 @@ (define %compile-flags (define* (guile-build name inputs #:key source + (tests? #true) + (test-script #false) + (test-arguments ''()) (guile #f) (phases '%standard-phases) (outputs '("out")) @@ -98,6 +102,9 @@ (define builder (guile-build #:name #$name #:source #+source + #:tests? #$tests? + #:test-script #$test-script + #:test-arguments #$test-arguments #:source-directory #$source-directory #:scheme-file-regexp #$scheme-file-regexp #:not-compiled-file-regexp #$not-compiled-file-regexp @@ -122,6 +129,9 @@ (define* (guile-cross-build name build-inputs target-inputs host-inputs (guile #f) source + (tests? #false) + (test-script #false) + (test-arguments ''()) (outputs '("out")) (search-paths '()) (native-search-paths '()) @@ -149,6 +159,9 @@ (define %outputs #$(outputs->gexp outputs)) (guile-build #:source #+source + #:tests? #$tests? + #:test-script #$test-script + #:test-arguments #$test-arguments #:system #$system #:target #$target #:outputs %outputs diff --git a/guix/build/guile-build-system.scm b/guix/build/guile-build-system.scm index 32a431d347..838cb13089 100644 --- a/guix/build/guile-build-system.scm +++ b/guix/build/guile-build-system.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2018, 2019 Ludovic Courtès +;;; Copyright © 2022 Maxime Devos ;;; ;;; This file is part of GNU Guix. ;;; @@ -19,8 +20,10 @@ (define-module (guix build guile-build-system) #:use-module ((guix build gnu-build-system) #:prefix gnu:) #:use-module (guix build utils) + #:use-module (rnrs exceptions) #:use-module (srfi srfi-1) #:use-module (srfi srfi-26) + #:use-module (srfi srfi-34) #:use-module (ice-9 match) #:use-module (ice-9 popen) #:use-module (ice-9 rdelim) @@ -29,7 +32,8 @@ (define-module (guix build guile-build-system) #:use-module (guix build utils) #:export (target-guile-effective-version %standard-phases - guile-build)) + guile-build + guile-check)) (define* (target-guile-effective-version #:optional guile) "Return the effective version of GUILE or whichever 'guile' is in $PATH. @@ -201,6 +205,42 @@ (define* (build #:key outputs inputs native-inputs source-files)) #t)) +(define* (guile-check #:key tests? test-script (test-arguments '()) + (source-directory ".") + native-inputs inputs + #:allow-other-keys) + (when tests? + ;; Let Guile find the source code of newly compiled modules, + ;; otherwise the modules won't be found even if Guile knows + ;; where the compiled code is. + (setenv "GUILE_LOAD_PATH" + (string-append source-directory + (match (getenv "GUILE_LOAD_PATH") + (#f "") + (path (string-append ":" path))))) + (for-each + (lambda (test-script) + (guard (c ((invoke-error? c) + (when (equal? (list (invoke-error-exit-status c) + (invoke-error-term-signal c) + (invoke-error-stop-signal c)) + '(127 #false #false)) + (display "hint: Make sure 'guile-test-driver' is in\ + 'native-inputs'.\n" + (current-error-port))) + (raise-continuable c))) + (apply invoke "test-driver.scm" + (string-append "--test-name=" test-script) test-arguments))) + (match test-script + ;; Tests can be separated over multiple files. + ((? list? test-scripts) test-scripts) + ((? string? test-script) (list test-script)) + (#false + (format (current-error-port) + "warning: location of test suite is unknown; not running\ + tests~%") + '()))))) + (define* (install-documentation #:key outputs (documentation-file-regexp %documentation-file-regexp) @@ -222,7 +262,7 @@ (define %standard-phases (replace 'build build) (add-after 'build 'install-documentation install-documentation) - (delete 'check) + (replace 'check guile-check) (delete 'strip) (delete 'validate-runpath) (delete 'install))) -- 2.37.3 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 07 16:54:01 2022 Received: (at 58365) by debbugs.gnu.org; 7 Oct 2022 20:54:01 +0000 Received: from localhost ([127.0.0.1]:37547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oguM5-0003wC-4X for submit@debbugs.gnu.org; Fri, 07 Oct 2022 16:54:01 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:40946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oguM0-0003v4-LX for 58365@debbugs.gnu.org; Fri, 07 Oct 2022 16:53:58 -0400 Received: from localhost.localdomain ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by laurent.telenet-ops.be with bizsmtp id V8tu2800920ykKC018tvFR; Fri, 07 Oct 2022 22:53:55 +0200 From: Maxime Devos To: 58365@debbugs.gnu.org Subject: [PATCH 4/6] guile-ffi-fftw: Modernise style. Date: Fri, 7 Oct 2022 22:53:50 +0200 Message-Id: <20221007205352.1282-4-maximedevos@telenet.be> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221007205352.1282-1-maximedevos@telenet.be> References: <20221007205352.1282-1-maximedevos@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1665176035; bh=lG2k5hn/qrsrgU1bAoLtbakH1bjt9nR7foNGcsSmVdg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=CosOHsRJbYGaqP18bWdkP0z67a79c6lDcXlq8xV/IyktxK1ZNKS6txJBxz7zKjafP pxeAWy4liVjYPVg55BJajg9JNTsHOR2jTg4CosuVe8CJ3Jc9l/WK2w7EePmZM4YguX RxDTf+qWdGfBYnvtbPo/rUP49Rx61agwVueRH2HkuHvFsxqVrFtTQf1spuFjUxeCHj uT0lh9nIrRDQq6DARC58mv3rA9QxmhxhlMxsDmHPigOUQI9HJ6d2xr0O5M54hGAhAO ejQ+3CGiMCKbFK8IJ74kMnDl9FqhIxHuZuyPJkwy7zbKZuQXP8dkvnMNHOjm0vf3Wh 3a3UgQXWC6BPQ== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58365 Cc: Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) The 'object->string' change is more a personal thing. "guix style" adds modify-phases on the same line as #:phases, causing the 80-columns limit to be exceeded, so it has been partially ignored. * gnu/packages/guile-xyz.scm (guile-ffi-fftw)[arguments]<#:test-script>: Set it. [arguments]{#:phases}{check}: Remove custom phase. [native-inputs]: Add native-input required by uncustomised 'check' phase. --- gnu/packages/guile-xyz.scm | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm index 2ab5683d19..a664e37968 100644 --- a/gnu/packages/guile-xyz.scm +++ b/gnu/packages/guile-xyz.scm @@ -3681,22 +3681,23 @@ (define-public guile-ffi-fftw "08j40a5p6a8pgvhffmzb5rfdnrav2mksy3gfjkdqy93jfj1z5afg")))) (build-system guile-build-system) (arguments - `(#:source-directory "mod" - #:test-script "../test/test-ffi-fftw.scm" - #:phases - (modify-phases %standard-phases - (add-after 'unpack 'prepare-build - (lambda* (#:key inputs #:allow-other-keys) - (substitute* "mod/ffi/fftw.scm" - (("\\(getenv \"GUILE_FFI_FFTW_LIBFFTW3_PATH\"\\)") - (format #f "\"~a/lib\"" (assoc-ref inputs "fftw")))) - #t))))) + (list #:source-directory "mod" + #:test-script "../test/test-ffi-fftw.scm" + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'prepare-build + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "mod/ffi/fftw.scm" + (("\\(getenv \"GUILE_FFI_FFTW_LIBFFTW3_PATH\"\\)") + (object->string + (dirname + (search-input-file inputs "lib/libfftw3.so")))))))))) (native-inputs (list guile-test-driver)) - (inputs - (list fftw guile-2.2)) + (inputs (list fftw guile-2.2)) (home-page "https://github.com/lloda/guile-ffi-fftw/") (synopsis "Access FFTW through Guile's FFI") - (description "This is a minimal set of Guile FFI bindings for the FFTW + (description + "This is a minimal set of Guile FFI bindings for the FFTW library's ‘guru interface’. It provides two functions: @code{fftw-dft! rank sign in out} and @code{fftw-dft rank sign in}. These bindings being minimal, there is no support for computing & reusing plans, or split r/i transforms, or -- 2.37.3 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 07 16:54:03 2022 Received: (at 58365) by debbugs.gnu.org; 7 Oct 2022 20:54:03 +0000 Received: from localhost ([127.0.0.1]:37549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oguM5-0003wM-GR for submit@debbugs.gnu.org; Fri, 07 Oct 2022 16:54:03 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:40926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oguM0-0003v1-L1 for 58365@debbugs.gnu.org; Fri, 07 Oct 2022 16:53:59 -0400 Received: from localhost.localdomain ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by laurent.telenet-ops.be with bizsmtp id V8tu2800920ykKC018tuFH; Fri, 07 Oct 2022 22:53:55 +0200 From: Maxime Devos To: 58365@debbugs.gnu.org Subject: [PATCH 1/6] gnu: Add guile-test-driver. Date: Fri, 7 Oct 2022 22:53:47 +0200 Message-Id: <20221007205352.1282-1-maximedevos@telenet.be> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1665176035; bh=PkKo1n9bMrITQ3JXlqu6Tv7ujg4NH68MqDLJm3M2yZc=; h=From:To:Cc:Subject:Date; b=S96SfXOySs0L84SFNQZ3UhZqyTtvBTkQRmDOFvnB13haOAk6ZCRQ/r1S/R9vXVp2l eCaI4QY4O+bxy6gRyZVdkJlSdQYKl9S/PaPkcHeD5IpcXwpC3RyPA2lrzdzm8CNQYr ING5U11V+IR/s6cYCMs9jTipojeWj/YK6cQh8WCTnmbPVEwjffCGHSHaOaHmp21qtR s5zw1/Sma5Mh1My6gqPVVZ2Hph6s72IE1s6zqPQyRZ6zw3fLXW1AUVAvPqRsawQDqK B6QDmLMsVqs/N5+5xJUEIXmb4jRuLOIsCWw+HO9asazIgBv2KzR0klO8vS/KtoOTMq PmCHnV1Hu9rkA== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58365 Cc: Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) A copy is made of test-driver.scm to avoid potentially surprising rebuilds when changes are made. * gnu/packages/guile.scm (guile-test-driver): New variable. * gnu/packages/aux-files/test-driver.scm: New file. * Makefile.am (AUX_FILES): Register it. * build-aux/test-driver.scm: Add a note. --- Makefile.am | 3 +- build-aux/test-driver.scm | 2 + gnu/packages/aux-files/test-driver.scm | 284 +++++++++++++++++++++++++ gnu/packages/guile.scm | 39 +++- 4 files changed, 326 insertions(+), 2 deletions(-) create mode 100755 gnu/packages/aux-files/test-driver.scm diff --git a/Makefile.am b/Makefile.am index bfabf0bf2e..e1f1a4573e 100644 --- a/Makefile.am +++ b/Makefile.am @@ -427,7 +427,8 @@ AUX_FILES = \ gnu/packages/aux-files/python/sanity-check.py \ gnu/packages/aux-files/python/sitecustomize.py \ gnu/packages/aux-files/renpy/renpy.in \ - gnu/packages/aux-files/run-in-namespace.c + gnu/packages/aux-files/run-in-namespace.c \ + gnu/packages/aux-files/test-driver.scm # Templates, examples. EXAMPLES = \ diff --git a/build-aux/test-driver.scm b/build-aux/test-driver.scm index 1cdd4ff8f7..7ff8d45031 100755 --- a/build-aux/test-driver.scm +++ b/build-aux/test-driver.scm @@ -2,6 +2,8 @@ exec guile --no-auto-compile -e main -s "$0" "$@" !# ;;;; test-driver.scm - Guile test driver for Automake testsuite harness +;;;; When update this code, consider updating +;;;; gnu/packages/aux-files/test-driver.scm as well. (define script-version "2021-02-02.05") ;UTC diff --git a/gnu/packages/aux-files/test-driver.scm b/gnu/packages/aux-files/test-driver.scm new file mode 100755 index 0000000000..1cdd4ff8f7 --- /dev/null +++ b/gnu/packages/aux-files/test-driver.scm @@ -0,0 +1,284 @@ +#!/bin/sh +exec guile --no-auto-compile -e main -s "$0" "$@" +!# +;;;; test-driver.scm - Guile test driver for Automake testsuite harness + +(define script-version "2021-02-02.05") ;UTC + +;;; Copyright © 2015, 2016 Mathieu Lirzin +;;; Copyright © 2021 Maxim Cournoyer +;;; +;;; This program is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; This program is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with this program. If not, see . + +;;;; Commentary: +;;; +;;; This script provides a Guile test driver using the SRFI-64 Scheme API for +;;; test suites. SRFI-64 is distributed with Guile since version 2.0.9. +;;; +;;;; Code: + +(use-modules (ice-9 format) + (ice-9 getopt-long) + (ice-9 pretty-print) + (ice-9 regex) + (srfi srfi-1) + (srfi srfi-19) + (srfi srfi-26) + (srfi srfi-64)) + +(define (show-help) + (display "Usage: + test-driver --test-name=NAME --log-file=PATH --trs-file=PATH + [--expect-failure={yes|no}] [--color-tests={yes|no}] + [--select=REGEXP] [--exclude=REGEXP] [--errors-only={yes|no}] + [--enable-hard-errors={yes|no}] [--brief={yes|no}}] + [--show-duration={yes|no}] [--] + TEST-SCRIPT [TEST-SCRIPT-ARGUMENTS] +The '--test-name' option is mandatory. The '--select' and '--exclude' options +allow selecting or excluding individual test cases via a regexp, respectively. +The '--errors-only' option can be set to \"yes\" to limit the logged test case +metadata to only those test cases that failed. When set to \"yes\", the +'--brief' option disables printing the individual test case result to the +console. When '--show-duration' is set to \"yes\", the time elapsed per test +case is shown.\n")) + +(define %options + '((test-name (value #t)) + (log-file (value #t)) + (trs-file (value #t)) + (select (value #t)) + (exclude (value #t)) + (errors-only (value #t)) + (color-tests (value #t)) + (expect-failure (value #t)) ;XXX: not implemented yet + (enable-hard-errors (value #t)) ;not implemented in SRFI-64 + (brief (value #t)) + (show-duration (value #t)) + (help (single-char #\h) (value #f)) + (version (single-char #\V) (value #f)))) + +(define (option->boolean options key) + "Return #t if the value associated with KEY in OPTIONS is \"yes\"." + (and=> (option-ref options key #f) (cut string=? <> "yes"))) + +(define* (test-display field value #:optional (port (current-output-port)) + #:key pretty?) + "Display \"FIELD: VALUE\\n\" on PORT." + (if pretty? + (begin + (format port "~A:~%" field) + (pretty-print value port #:per-line-prefix "+ ")) + (format port "~A: ~S~%" field value))) + +(define* (result->string symbol #:key colorize?) + "Return SYMBOL as an upper case string. Use colors when COLORIZE is #t." + (let ((result (string-upcase (symbol->string symbol)))) + (if colorize? + (string-append (case symbol + ((pass) "") ;green + ((xfail) "") ;light green + ((skip) "") ;blue + ((fail xpass) "") ;red + ((error) "")) ;magenta + result + "") ;no color + result))) + + +;;; +;;; SRFI 64 custom test runner. +;;; + +(define* (test-runner-gnu test-name #:key color? brief? errors-only? + show-duration? + (out-port (current-output-port)) + (trs-port (%make-void-port "w")) + select exclude) + "Return an custom SRFI-64 test runner. TEST-NAME is a string specifying the +file name of the current the test. COLOR? specifies whether to use colors. +When BRIEF? is true, the individual test cases results are masked and only the +summary is shown. ERRORS-ONLY? reduces the amount of test case metadata +logged to only that of the failed test cases. OUT-PORT and TRS-PORT must be +output ports. OUT-PORT defaults to the current output port, while TRS-PORT +defaults to a void port, which means no TRS output is logged. SELECT and +EXCLUDE may take a regular expression to select or exclude individual test +cases based on their names." + + (define test-cases-start-time (make-hash-table)) + + (define (test-on-test-begin-gnu runner) + ;; Procedure called at the start of an individual test case, before the + ;; test expression (and expected value) are evaluated. + (let ((test-case-name (test-runner-test-name runner)) + (start-time (current-time time-monotonic))) + (hash-set! test-cases-start-time test-case-name start-time))) + + (define (test-skipped? runner) + (eq? 'skip (test-result-kind runner))) + + (define (test-failed? runner) + (not (or (test-passed? runner) + (test-skipped? runner)))) + + (define (test-on-test-end-gnu runner) + ;; Procedure called at the end of an individual test case, when the result + ;; of the test is available. + (let* ((results (test-result-alist runner)) + (result? (cut assq <> results)) + (result (cut assq-ref results <>)) + (test-case-name (test-runner-test-name runner)) + (start (hash-ref test-cases-start-time test-case-name)) + (end (current-time time-monotonic)) + (time-elapsed (time-difference end start)) + (time-elapsed-seconds (+ (time-second time-elapsed) + (* 1e-9 (time-nanosecond time-elapsed))))) + (unless (or brief? (and errors-only? (test-skipped? runner))) + ;; Display the result of each test case on the console. + (format out-port "~a: ~a - ~a ~@[[~,3fs]~]~%" + (result->string (test-result-kind runner) #:colorize? color?) + test-name test-case-name + (and show-duration? time-elapsed-seconds))) + + (unless (and errors-only? (not (test-failed? runner))) + (format #t "test-name: ~A~%" (result 'test-name)) + (format #t "location: ~A~%" + (string-append (result 'source-file) ":" + (number->string (result 'source-line)))) + (test-display "source" (result 'source-form) #:pretty? #t) + (when (result? 'expected-value) + (test-display "expected-value" (result 'expected-value))) + (when (result? 'expected-error) + (test-display "expected-error" (result 'expected-error) #:pretty? #t)) + (when (result? 'actual-value) + (test-display "actual-value" (result 'actual-value))) + (when (result? 'actual-error) + (test-display "actual-error" (result 'actual-error) #:pretty? #t)) + (format #t "result: ~a~%" (result->string (result 'result-kind))) + (newline)) + + (format trs-port ":test-result: ~A ~A [~,3fs]~%" + (result->string (test-result-kind runner)) + (test-runner-test-name runner) time-elapsed-seconds))) + + (define (test-on-group-end-gnu runner) + ;; Procedure called by a 'test-end', including at the end of a test-group. + (let ((fail (or (positive? (test-runner-fail-count runner)) + (positive? (test-runner-xpass-count runner)))) + (skip (or (positive? (test-runner-skip-count runner)) + (positive? (test-runner-xfail-count runner))))) + ;; XXX: The global results need some refinements for XPASS. + (format trs-port ":global-test-result: ~A~%" + (if fail "FAIL" (if skip "SKIP" "PASS"))) + (format trs-port ":recheck: ~A~%" + (if fail "yes" "no")) + (format trs-port ":copy-in-global-log: ~A~%" + (if (or fail skip) "yes" "no")) + (when brief? + ;; Display the global test group result on the console. + (format out-port "~A: ~A~%" + (result->string (if fail 'fail (if skip 'skip 'pass)) + #:colorize? color?) + test-name)) + #f)) + + (let ((runner (test-runner-null))) + (test-runner-on-test-begin! runner test-on-test-begin-gnu) + (test-runner-on-test-end! runner test-on-test-end-gnu) + (test-runner-on-group-end! runner test-on-group-end-gnu) + (test-runner-on-bad-end-name! runner test-on-bad-end-name-simple) + runner)) + + +;;; +;;; SRFI 64 test specifiers. +;;; +(define (test-match-name* regexp) + "Return a test specifier that matches a test name against REGEXP." + (lambda (runner) + (string-match regexp (test-runner-test-name runner)))) + +(define (test-match-name*/negated regexp) + "Return a negated test specifier version of test-match-name*." + (lambda (runner) + (not (string-match regexp (test-runner-test-name runner))))) + +;;; XXX: test-match-all is a syntax, which isn't convenient to use with a list +;;; of test specifiers computed at run time. Copy this SRFI 64 internal +;;; definition here, which is the procedural equivalent of 'test-match-all'. +(define (%test-match-all . pred-list) + (lambda (runner) + (let ((result #t)) + (let loop ((l pred-list)) + (if (null? l) + result + (begin + (if (not ((car l) runner)) + (set! result #f)) + (loop (cdr l)))))))) + + +;;; +;;; Entry point. +;;; + +(define (main . args) + (let* ((opts (getopt-long (command-line) %options)) + (option (cut option-ref opts <> <>))) + (cond + ((option 'help #f) (show-help)) + ((option 'version #f) (format #t "test-driver.scm ~A~%" script-version)) + (else + (let* ((log (and=> (option 'log-file #f) (cut open-file <> "w0"))) + (trs (and=> (option 'trs-file #f) (cut open-file <> "wl"))) + (out (duplicate-port (current-output-port) "wl")) + (test-name (option 'test-name #f)) + (select (option 'select #f)) + (exclude (option 'exclude #f)) + (test-specifiers (filter-map + identity + (list (and=> select test-match-name*) + (and=> exclude test-match-name*/negated)))) + (test-specifier (apply %test-match-all test-specifiers)) + (color-tests (if (assoc 'color-tests opts) + (option->boolean opts 'color-tests) + #t))) + (when log + (redirect-port log (current-output-port)) + (redirect-port log (current-warning-port)) + (redirect-port log (current-error-port))) + (test-with-runner + (test-runner-gnu test-name + #:color? color-tests + #:brief? (option->boolean opts 'brief) + #:errors-only? (option->boolean opts 'errors-only) + #:show-duration? (option->boolean + opts 'show-duration) + #:out-port out #:trs-port trs) + (test-apply test-specifier + (lambda _ + (load-from-path test-name)))) + (and=> log close-port) + (and=> trs close-port) + (close-port out)))) + (exit 0))) + +;;; Local Variables: +;;; eval: (add-hook 'write-file-functions 'time-stamp) +;;; time-stamp-start: "(define script-version \"" +;;; time-stamp-format: "%:y-%02m-%02d.%02H" +;;; time-stamp-time-zone: "UTC" +;;; time-stamp-end: "\") ;UTC" +;;; End: + +;;;; test-driver.scm ends here. diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm index fcdf75051c..b847ee6be4 100644 --- a/gnu/packages/guile.scm +++ b/gnu/packages/guile.scm @@ -16,7 +16,7 @@ ;;; Copyright © 2018 Eric Bavier ;;; Copyright © 2019 Taylan Kammer ;;; Copyright © 2020, 2021, 2022 Efraim Flashner -;;; Copyright © 2021 Maxime Devos +;;; Copyright © 2021, 2022 Maxime Devos ;;; Copyright © 2021 Timothy Sample ;;; ;;; This file is part of GNU Guix. @@ -60,9 +60,11 @@ (define-module (gnu packages guile) #:use-module (gnu packages version-control) #:use-module (guix packages) #:use-module (guix download) + #:use-module (guix gexp) #:use-module (guix git-download) #:use-module (guix build-system gnu) #:use-module (guix build-system guile) + #:use-module (guix build-system trivial) #:use-module (guix deprecation) #:use-module (guix utils)) @@ -961,4 +963,39 @@ (define-public guile-lzma libraries, like Guile-zlib.") (license license:gpl3+))) +(define-public guile-test-driver + (package + (name "guile-test-driver") + ;; (define script-version ...) in the source code + (version "2021-01-02.05") + ;; 'search-auxiliary-file' could be used here, but that causes warnings. + (source (local-file "../../gnu/packages/aux-files/test-driver.scm")) + (build-system gnu-build-system) + (inputs (list guile-3.0)) + (arguments + (list #:phases + #~(modify-phases %standard-phases + (delete 'configure) + (delete 'check) + (delete 'install) ; no point in separating build and install + (replace 'build + (lambda _ + (define destination + (string-append #$output "/bin/test-driver.scm")) + (mkdir-p (dirname destination)) + (copy-file #$source destination) + (substitute* destination + (("/bin/sh") + ;; Reference to Guile will be patched by patch-shebangs. + "/bin/guile \\") + (("^exec guile(.*)$") "--no-auto-compile -e main -s\n")) + (chmod destination #o500)))))) + (home-page "https://www.gnu.org/software/guix") + (synopsis "Guile test driver for SRFI-64 test suites") + (description "This package, also known as @file{test-driver.scm}, provides +a Guile test driver using the SRFI-64 Scheme API for test suites. Unlike the +default test runner, its output is consistent with other test drivers used +by Automake.") + (license license:gpl3+))) + ;;; guile.scm ends here base-commit: 31a56967e2869c916b7a5e8ee570e8e10f0210a5 prerequisite-patch-id: 2712efb97bf33985fd0658e4dd8e936dc08be5fe prerequisite-patch-id: 9d2409b480a8bff0fef029b4b095922d4957e06f prerequisite-patch-id: 51a32abca3efec1ba67ead59b8694c5ea3129ad3 prerequisite-patch-id: 9092927761a340c07a99f5f3ed314a6add04cdee prerequisite-patch-id: d0af09fbd5ee0ef60bdee53b87d729e46c1db2ca prerequisite-patch-id: 4fee177b2d8c9478c6a7b8ce1ca9072942f39863 prerequisite-patch-id: c2b101598fa5b6f93470ae41d51a983dcb931b04 prerequisite-patch-id: 8fe65a852a4463203ea6b92abb3968bd819475b1 prerequisite-patch-id: 7585c78056095ec991615cbbe877e06f713aada9 prerequisite-patch-id: a9fb1bf1718ad8de6fc26d97a7dc5baf41dc38bd prerequisite-patch-id: 1e5c9ef57d1df286042f4ae3eb420394c8b3b045 -- 2.37.3 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 18 08:37:26 2022 Received: (at 58365) by debbugs.gnu.org; 18 Oct 2022 12:37:26 +0000 Received: from localhost ([127.0.0.1]:51453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oklqY-0000dl-EA for submit@debbugs.gnu.org; Tue, 18 Oct 2022 08:37:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oklqQ-0000dN-4Q for 58365@debbugs.gnu.org; Tue, 18 Oct 2022 08:37:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33772) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oklqI-0002iN-0z; Tue, 18 Oct 2022 08:37:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=627oRkED+9UlBQx8TQb4gt0wfH5s+YGiLdQNDLX1XsQ=; b=ok3L0doC0dHX5IlkkACE sOdP359AP1gRni73hRj1O+w1CHG+2KzzNBX2bRbFIP3HUPHk80IB2NkS5+ut+l3UNuG51L/YByba+ M4Voon9sL0FO24Zevdd9K7xMt5ejNTU+5UjoPhRf2TYD/rwW+z470YfFTJi7IOdMfUztQ50K1LC8q LRLeA0Qgb3OvG3S6gw/I0xDcEy7qht0QEjZ+1KXrfYe5zmfqRlnDcDNofINI9zLIcAbDPIob4QGA3 XYreTBVJ2wZl1zeSxnW5oQ9nJIcIWs7TEg/Wq9RZMxuFy+vCBz1WxhB34nQHYH5VGxGNn9F9m7Cvz 2OPa7icNQXwbIQ==; Received: from [193.50.110.209] (port=50484 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oklpy-0001YD-Bn; Tue, 18 Oct 2022 08:37:08 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxime Devos Subject: Re: bug#58365: [PATCH 0/6] Support #:tests? in guile-build-system References: <20221007205352.1282-1-maximedevos@telenet.be> Date: Tue, 18 Oct 2022 14:36:48 +0200 In-Reply-To: <20221007205352.1282-1-maximedevos@telenet.be> (Maxime Devos's message of "Fri, 7 Oct 2022 22:53:47 +0200") Message-ID: <87sfjlnw9r.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58365 Cc: 58365@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Maxime Devos skribis: > A copy is made of test-driver.scm to avoid potentially surprising rebuilds > when changes are made. > > * gnu/packages/guile.scm (guile-test-driver): New variable. > * gnu/packages/aux-files/test-driver.scm: New file. > * Makefile.am (AUX_FILES): Register it. > * build-aux/test-driver.scm: Add a note. I very much like the idea of supporting #:tests? in =E2=80=98guile-build-system=E2=80=99, but I=E2=80=99m skeptical about this = approach. The reason I=E2=80=99m skeptical is because =E2=80=98test-driver.scm=E2=80= =99 is written as an Automake test driver (it follows the =E2=80=9Cprotocol=E2=80=9D defined by = Automake) for tests that use SRFI-64=E2=80=94that=E2=80=99s a specific kind of tool, and = one approach to writing test suites in Guile. I guess all I=E2=80=99m saying is that I doubt this is widely applicable, w= hich the diff seems to confirm: > 4 files changed, 326 insertions(+), 2 deletions(-) Perhaps at this stage there really isn=E2=80=99t much we can factorize, aft= er all. It would be nice to fix this, but that=E2=80=99s probably work to be = done upstream=E2=80=94for example, by adding a =E2=80=9Cguild test=E2=80=9D comm= and. We can even beta-test such a command as an external project before including it in Guile proper. WDYT? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 18 09:31:15 2022 Received: (at 58365) by debbugs.gnu.org; 18 Oct 2022 13:31:15 +0000 Received: from localhost ([127.0.0.1]:51610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okmgb-0004Ko-Sb for submit@debbugs.gnu.org; Tue, 18 Oct 2022 09:31:14 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:36236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okmgO-0004KG-2l for 58365@debbugs.gnu.org; Tue, 18 Oct 2022 09:31:12 -0400 Received: from [192.168.167.79] ([213.119.141.138]) by michel.telenet-ops.be with bizsmtp id ZRWw280062zMhxh06RWwaM; Tue, 18 Oct 2022 15:30:58 +0200 Message-ID: Date: Tue, 18 Oct 2022 15:30:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Content-Language: en-US To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= References: <20221007205352.1282-1-maximedevos@telenet.be> <87sfjlnw9r.fsf_-_@gnu.org> From: Maxime Devos Subject: Re: bug#58365: [PATCH 0/6] Support #:tests? in guile-build-system In-Reply-To: <87sfjlnw9r.fsf_-_@gnu.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------dB0H6QB2TUCLxgiR9ED4BhH0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1666099858; bh=nIycpRiAH9PfWNHYIZtXnwAD7+UxrVEbzyyz+nLSh7s=; h=Date:To:Cc:References:From:Subject:In-Reply-To; b=S1dyvcFX37OgJMoDRDqlfjMhGpu6R8BiBR5R2Ovjbxj8MC/qIyou+M/EGIVY5Dxfb eCpnP6aDGGI6DJwZLMaMA4vgy8hTbVYfI3WA4T2CkMkhAFZhPjm3aUiyJWWdd30CFm 5JSYl+AAQi1gH41K2QfsjsU1zupe2IIpDQTxZrr9n2cLc28CU/Ue6DKUKFRzradaiN vSrJManFxUAfhdzDXUB844NC40wWtcXqBxbN6R/mnk838kDOaykfjk7SWlW7tb6sdE l9dpmipeUSc6VIFwcnpTp1JwG5/dbrRKbYokO1CK9tKzMpfj/QI6GPd2bG9oHyJVqI Lbh9EwzxpeQWA== X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 58365 Cc: 58365@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------dB0H6QB2TUCLxgiR9ED4BhH0 Content-Type: multipart/mixed; boundary="------------OPcJgTTgf800gvvpC5VXjHQJ"; protected-headers="v1" From: Maxime Devos To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= Cc: 58365@debbugs.gnu.org Message-ID: Subject: Re: bug#58365: [PATCH 0/6] Support #:tests? in guile-build-system References: <20221007205352.1282-1-maximedevos@telenet.be> <87sfjlnw9r.fsf_-_@gnu.org> In-Reply-To: <87sfjlnw9r.fsf_-_@gnu.org> --------------OPcJgTTgf800gvvpC5VXjHQJ Content-Type: multipart/mixed; boundary="------------T6bg0RBy6Lb05XS0RrDiNL3k" --------------T6bg0RBy6Lb05XS0RrDiNL3k Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQoNCk9uIDE4LTEwLTIwMjIgMTQ6MzYsIEx1ZG92aWMgQ291cnTDqHMgd3JvdGU6DQo+IEhl bGxvLA0KPiANCj4gTWF4aW1lIERldm9zIDxtYXhpbWVkZXZvc0B0ZWxlbmV0LmJlPiBza3Jp YmlzOg0KPiANCj4+IEEgY29weSBpcyBtYWRlIG9mIHRlc3QtZHJpdmVyLnNjbSB0byBhdm9p ZCBwb3RlbnRpYWxseSBzdXJwcmlzaW5nIHJlYnVpbGRzDQo+PiB3aGVuIGNoYW5nZXMgYXJl IG1hZGUuDQo+Pg0KPj4gKiBnbnUvcGFja2FnZXMvZ3VpbGUuc2NtIChndWlsZS10ZXN0LWRy aXZlcik6IE5ldyB2YXJpYWJsZS4NCj4+ICogZ251L3BhY2thZ2VzL2F1eC1maWxlcy90ZXN0 LWRyaXZlci5zY206IE5ldyBmaWxlLg0KPj4gKiBNYWtlZmlsZS5hbSAoQVVYX0ZJTEVTKTog UmVnaXN0ZXIgaXQuDQo+PiAqIGJ1aWxkLWF1eC90ZXN0LWRyaXZlci5zY206IEFkZCBhIG5v dGUuDQo+IA0KPiBJIHZlcnkgbXVjaCBsaWtlIHRoZSBpZGVhIG9mIHN1cHBvcnRpbmcgIzp0 ZXN0cz8gaW4NCj4g4oCYZ3VpbGUtYnVpbGQtc3lzdGVt4oCZLCBidXQgSeKAmW0gc2tlcHRp Y2FsIGFib3V0IHRoaXMgYXBwcm9hY2guDQo+IA0KPiBUaGUgcmVhc29uIEnigJltIHNrZXB0 aWNhbCBpcyBiZWNhdXNlIOKAmHRlc3QtZHJpdmVyLnNjbeKAmSBpcyB3cml0dGVuIGFzIGFu DQo+IEF1dG9tYWtlIHRlc3QgZHJpdmVyIChpdCBmb2xsb3dzIHRoZSDigJxwcm90b2NvbOKA nSBkZWZpbmVkIGJ5IEF1dG9tYWtlKQ0KDQpJdCBpcyBwZXJmZWN0bHkgdXNhYmxlIG91dHNp ZGUgQXV0b21ha2UsIGFzIHRoaXMgcGF0Y2ggc2VyaWVzIA0KZGVtb25zdHJhdGVzIC0tIGl0 IGRvZXMgbm90IGRlcGVuZCBvbiBhbnkgQXV0b21ha2UgZGV0YWlscy4NCg0KQWxzbywgdGhl IGFsdGVybmF0aXZlIHdvdWxkIGJlIHRvIGRvICJndWlsZSAtbCB0aGUtdGVzdC1zdWl0ZS5z Y20iIA0KZGlyZWN0bHkgKHdpdGhvdXQgYSB0ZXN0IHJ1bm5lcikgLS0gd2hpbGUgc29tZXRp bWVzIHRoaXMgd29ya3MsIA0Kc29tZXRpbWVzIHRoZSBTUkZJLTY0IGltcGxlbWVudGF0aW9u IHJlYWxseSBjYXJlcyB0aGF0IHRoZXJlIGlzIGFjdHVhbGx5IA0Kc29tZSB0ZXN0IHJ1bm5l ciAoSSBnb3QgYSBmYWlsdXJlIGZvciBzb21lIHVucGFja2FnZWQgU2NoZW1lIGxpYnJhcnkg DQp3aGVuIHJ1bm5pbmcgaXQgd2l0aG91dCB0ZXN0LWRyaXZlci5zY20pLCBhbmQgYWRkaXRp b25hbGx5IElNTyB0aGUgDQpvdXRwdXQgb2YgImd1aWxlIC1sIHRoZS10ZXN0LXN1aXRlLnNj bSIgaXNuJ3QgdmVyeSBuaWNlLCB0aGUgDQp0ZXN0LWRyaXZlci5zY20gaGFzIG11Y2ggbW9y ZSBuaWNlIG91dHB1dCBhbmQgaXMgbW9yZSBjb25zaXN0ZW50IHdpdGggDQpvdGhlciBwYWNr YWdlcycgdGVzdCBvdXRwdXQuDQoNCihBIHRoaXJkIGFsdGVybmF0aXZlIHdvdWxkIGJlIHRv IGlnbm9yZSB0aGUgdGVzdHMgYWx0b2dldGhlciwgYnV0IA0KcnVubmluZyB0ZXN0cyBpcyBn b29kIGFuZCBJIGhhdmUgc29tZSBwYXRjaGVzIGZvciBhZGRpbmcgc3VwcG9ydCBmb3IgdGhl IA0KdGVzdHMuKQ0KDQo+IGZvciB0ZXN0cyB0aGF0IHVzZSBTUkZJLTY04oCUDQoNClRoYXQn cyB0aGUgc3RhbmRhcmQgU2NoZW1lIEFQSSBmb3IgdGVzdCBzdWl0ZXMgaW4gU2NoZW1lIC0t IHdpZGVseSANCmFwcGxpY2FibGUuICAoVGhlcmUncyBhbHNvIFNSRkktNzgsIGJ1dCB0aGF0 J3MgY3VycmVudGx5IHVuc3VwcG9ydGVkIGJ5IA0KR3VpbGUsIHNvIGl0J3MgY3VycmVudGx5 IG5vdCByZWxldmFudCBmb3IgZ3VpbGUtYnVpbGQtc3lzdGVtLikNCg0KPiB0aGF04oCZcyBh IHNwZWNpZmljIGtpbmQgb2YgdG9vbCwgYW5kIG9uZSBhcHByb2FjaA0KPiB0byB3cml0aW5n IHRlc3Qgc3VpdGVzIGluIEd1aWxlLg0KDQpJdCdzIHRoZSBvbmx5IGFwcHJvYWNoIHRvIG15 IGtub3dsZWRnZSwgYXNpZGUgZnJvbSAnbGV0J3MganVzdCBwdXQgYSANCmJ1bmNoIG9mICh3 aGVuIHdyb25nPyAoZXJyb3IgLi4uKSkgaW4gYSBzY3JpcHQgYW5kIGRvICdndWlsZSAtbCAN CnRoZS1zY3JpcHQuc2NtJyBvciByZWltcGxlbWVudCBvdXIgb3duIHRoaW5nLCBidXQgdGhh dCdzIG5vdCBhIG5pY2UgDQphcHByb2FjaCwgSSB3b3VsZCByYXRoZXIgbWFrZSBpdCBwb3Nz aWJsZSB0byB1c2UgdGhlIG1vcmUtc3RhbmRhcmQgYW5kIA0KbmljZXIgKGV2ZW4gdGhvdWdo IGl0J3Mgc29tZXdoYXQgc3RhdGVmdWwpIFNSRkktNjQuDQoNCkFsc28sIEkgZG9uJ3Qgc2Vl IHdoYXQncyB3cm9uZyB3aXRoICdzcGVjaWZpYyBraW5kIG9mIHRvb2xzJyAtLSBzaG91bGQg DQp3ZSByZW1vdmUgJ25tbCcgdGhlbiBiZWNhdXNlIGl0J3Mgc3VwZXItc3BlY2lmaWMgdG8g b3BlbnR0ZD8gIEFuZCBldmVuIA0KaWYgdGhlcmUgZXhpc3RzIGFub3RoZXIgdG9vbCB0aGF0 IHdvdWxkIGZpdCBoZXJlLCB3aHkgd291bGQgdGhhdCBtYXR0ZXI/IA0KSSBtZWFuLCB0aGUg J2djYycgYXBwcm9hY2ggdG8gY29tcGlsaW5nIEMgd2Fzbid0IHJlamVjdGVkIGluIEd1aXgg ZXZlbiANCnRob3VnaCBpdCdzIGp1c3QgJ29uZScgYXBwcm9hY2ggdG8gY29tcGlsaW5nIEMg LS0gZm9yIGV4YW1wbGUsICdjbGFuZycgDQppcyBhbm90aGVyIGFwcHJvYWNoLg0KDQpJZiBz b21lb25lIGhhcyBhbm90aGVyIGFwcHJvYWNoIHRvIHJ1bm5pbmcgU1JGSS02NCB0ZXN0IHN1 aXRlcyBpbiANCmd1aWxlLWJ1aWxkLXN5c3RlbSwgdGhleSBjYW4gcHJvcG9zZSBpdCBhbmQg aXQgY2FuIGJlIGRpc2N1c3NlZCB3aGljaCANCm9uZSB3b3VsZCBiZSBiZXR0ZXIgZm9yIGd1 aWxlLWJ1aWxkLXN5c3RlbS4NCg0KQWRkaXRpb25hbGx5LCBhIG5pdHBpY2sgLS0gdGVzdC1k cml2ZXIuc2NtIGlzIGFuIGFwcHJvYWNoIHRvIHJ1bm5pbmcgDQooU1JGSS02NCkgdGVzdCBz dWl0ZXMsIG5vdCBmb3Igd3JpdGluZyB0aGVtLCBmb3Igd3JpdGluZyB0ZXN0IHN1aXRlcywg DQpTUkZJLTY0IGlzIGFuIGFwcHJvYWNoLg0KDQo+IEkgZ3Vlc3MgYWxsIEnigJltIHNheWlu ZyBpcyB0aGF0IEkgZG91YnQgdGhpcyBpcyB3aWRlbHkgYXBwbGljYWJsZSwgd2hpY2gNCj4g dGhlIGRpZmYgc2VlbXMgdG8gY29uZmlybToNCj4gDQo+PiAgIDQgZmlsZXMgY2hhbmdlZCwg MzI2IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQoNCkkgZG9uJ3QgaG93IHlvdSBn ZXQgZnJvbSB0aGUgZGlmZiB0aGF0IGl0IGlzbid0IHdpZGVseSBhcHBsaWNhYmxlIC0tIGl0 IA0KaXMgYXBwbGljYWJsZSB0byBldmVyeSBwYWNrYWdlIHRoYXQgaGFzIGEgU1JGSS02NCB0 ZXN0IHN1aXRlIGFuZCB1c2VzIA0KZ3VpbGUtYnVpbGQtc3lzdGVtLiAgSSBqdXN0IGRpZG4n dCBjaGVjayBldmVyeSBndWlsZS1idWlsZC1zeXN0ZW0gdGhpbmcgDQpmb3Igd2hldGhlciBp dCBoYXMgYSBTUkZJLTY0IHRlc3Qgc3VpdGUuICBBbmQgb25jZSBtb3JlIFNjaGVtZSBsaWJy YXJpZXMgDQphcmUgcGFja2FnZWQgKGVzcGVjaWFsbHkgU2NoZW1lIGxpYnJhcmllcyBub3Qg d3JpdHRlbiB3aXRoIEd1aWxlIGluIA0KbWluZCwgd2hlcmUgZ251LWJ1aWxkLXN5c3RlbSBp cyBsaWtlbHkgaW5hcHBsaWNhYmxlKSwgcHJlc3VtYWJseSB3ZSANCndvdWxkIGdldCBtb3Jl IHBhY2thZ2VzIHdoZXJlIHRoaXMgcGF0Y2ggc2VyaWVzIGNhbiBydW4gdGVzdHMuDQoNCkFk ZGl0aW9uYWxseSwgaGF2ZSB5b3UgY29uc2lkZXJlZCB0aGF0IG9uZSBwb3NzaWJsZSByZWFz b24gZm9yIGxhY2sgb2YgDQpTUkZJLTY0IHRlc3Qgc3VpdGVzIGluIGd1aWxlLWJ1aWxkLXN5 c3RlbSBwYWNrYWdlcywgaXMgdGhhdCBwcmV2aW91c2x5IA0KdGhlcmUgd2FzIG5vIGdvb2Qg bWV0aG9kIHRvIHJ1biB0aG9zZSB0ZXN0IHN1aXRlcywgc28gKGZvciBzb21lb25lIHVzaW5n IA0KR3VpeCBhbmQgR3VpbGUpIHdyaXRpbmcgdGhlbSB3b3VsZCBiZSBwb2ludGxlc3M/DQoN Cj4gUGVyaGFwcyBhdCB0aGlzIHN0YWdlIHRoZXJlIHJlYWxseSBpc27igJl0IG11Y2ggd2Ug Y2FuIGZhY3Rvcml6ZSwgYWZ0ZXINCj4gYWxsLiAgSXQgd291bGQgYmUgbmljZSB0byBmaXgg dGhpcywNCg0KSSBkb24ndCBzZWUgYW55IHByb2JsZW0gdG8gZml4IG9yIGFueXRoaW5nIHRv IGZhY3Rvcml6ZS4gIFdoYXQgaXMgdGhpcyANCid0aGlzJyB5b3UgYXJlIHJlZmVycmluZyB0 bz8NCg0KPiBidXQgdGhhdOKAmXMgcHJvYmFibHkgd29yayB0byBiZSBkb25lDQo+IHVwc3Ry ZWFt4oCUZm9yIGV4YW1wbGUsIGJ5IGFkZGluZyBhIOKAnGd1aWxkIHRlc3TigJ0gY29tbWFu ZC4NCg0KR29pbmcgYnkgImdpdCBsb2cgYnVpbGQtYXV4L3Rlc3QtZHJpdmVyLnNjbSIsIEd1 aXggaXMgdGhlIHVwc3RyZWFtLCBub3QgDQpHdWlsZSwgdGhvdWdoIEkgc3VwcG9zZSBpdCBj b3VsZCBldmVudHVhbGx5IGJlIG1vdmVkIHRvIEd1aWxlIGlmIGRlc2lyZWQgDQpieSBib3Ro Lg0KDQo+IFdlIGNhbiBldmVuDQo+IGJldGEtdGVzdCBzdWNoIGEgY29tbWFuZCBhcyBhbiBl eHRlcm5hbCBwcm9qZWN0IGJlZm9yZSBpbmNsdWRpbmcgaXQgaW4NCj4gR3VpbGUgcHJvcGVy LiA+DQo+IFdEWVQ/DQoNCkkgdGhpbmsgaXQgYWxyZWFkeSBoYXMgc2VlbiBwbGVudHkgb2Yg dGVzdGluZyAtLSBpbiBHdWl4LCBpbiANCnNjaGVtZS1nbnVuZXQsIEkgdGhpbmsgSSd2ZSBh bHNvIHNlZW4gaXQgdXNlZCBpbiB0aGUgR251VExTIGJpbmRpbmdzLCANCmxpa2VseSBieSBt b3N0IG90aGVyIEd1aWxlIHByb2dyYW1zIHRoYXQgdXNlIGdudS1idWlsZC1zeXN0ZW0gYW5k IGhhdmUgYSANCnRlc3Qgc3VpdGUgYXMgd2VsbC4NCg0KSSBtZWFuLCBpdCBleGlzdGVkIHNp bmNlIDIwMTUgYWNjb3JkaW5nIHRvICJnaXQgbG9nIiwgdGhhdCdzIDcgeWVhcnMgb2YgDQp0 ZXN0aW5nLCBzZWVtcyBwbGVudHkgdG8gbWUsIGFuZCBpdCBhbHNvIGhhcyBiZWVuIHVzZWQg YnkgdmFyaW91cyBwcm9qZWN0cy4NCg0KR3JlZXRpbmdzLA0KTWF4aW1lLg0K --------------T6bg0RBy6Lb05XS0RrDiNL3k Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------T6bg0RBy6Lb05XS0RrDiNL3k-- --------------OPcJgTTgf800gvvpC5VXjHQJ-- --------------dB0H6QB2TUCLxgiR9ED4BhH0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCY06qkAUDAAAAAAAKCRBJ4+4iGRcl7gys AQCmuldDUSg3Suyz55raaC9KSPKTaTtAgbgiO55dukbDBgEAm77mXV3soI8ni4b52v0pPbiFcGdy Oguqhg/mhLCKkwQ= =Vx3G -----END PGP SIGNATURE----- --------------dB0H6QB2TUCLxgiR9ED4BhH0-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 18 11:45:27 2022 Received: (at 58365) by debbugs.gnu.org; 18 Oct 2022 15:45:27 +0000 Received: from localhost ([127.0.0.1]:53844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okomU-0001I7-Te for submit@debbugs.gnu.org; Tue, 18 Oct 2022 11:45:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okomR-0000tC-EK for 58365@debbugs.gnu.org; Tue, 18 Oct 2022 11:45:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49838) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okomM-0002XQ-1R; Tue, 18 Oct 2022 11:45:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=pf/y/q41nq34+IRoOaNdh1YzQQ+VBE5e4LCeUVizGes=; b=BtYxF8DM91+4fWeGl+wl +LRwdbMzkoVHPwXgIpojfIvz0bC1sXuHONm0qgURk2EhilVGd2VBLd8K5EXIYc4HlJx+/EpMvxmS5 NmMowtrw1JkJO2u3LNvTGwE5sb9ow7YzPOYWQPSi5ibBdweBnJELpnK+758rU63jLjZpggux4KEqj iMj40Qgba3Ec0sOk3rb7GFQvq3auSgtRoaClhHwoZ0Ddom+0Cyb9GKgQw2ajIZS+EaBDl/zBijMS3 L2+pXXC9tDjfOVifF501Ivrv8JUua5vV+F/8wpYbBlMqZDkPCCLWxQ9fqddEsEGS3DhCJeQ5yY+IA 2AZfvP0R28iJZg==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=51494 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okom5-0001FS-BG; Tue, 18 Oct 2022 11:45:15 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxime Devos Subject: Re: bug#58365: [PATCH 0/6] Support #:tests? in guile-build-system References: <20221007205352.1282-1-maximedevos@telenet.be> <87sfjlnw9r.fsf_-_@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Septidi 27 =?utf-8?Q?Vend=C3=A9miaire?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Piment X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 18 Oct 2022 17:44:55 +0200 In-Reply-To: (Maxime Devos's message of "Tue, 18 Oct 2022 15:30:56 +0200") Message-ID: <878rldkufc.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58365 Cc: 58365@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Maxime, That=E2=80=99s quite a wall of text that you sent. :-) Let me try to clarify what I think can be a fruitful way forward. Again, I agree with the goal you have here, I=E2=80=99m just proposing a different strategy. To me, the problem that we have is lack of a standard way to run tests in Guile packages that don=E2=80=99t use Autotools. That, in turn, leads to duplication in package definitions=E2=80=94whether it=E2=80=99s =E2=80=98ch= eck=E2=80=99 phases in Guix or something similar in Debian and other distros. Instead of addressing it downstream (in Guix), my suggestion would be to address it upstream=E2=80=94that is, to promote one way to run SRFI-64 test suites, for example with a new =E2=80=9Cguild test=E2=80=9D command. That =E2=80=9Cguild test=E2=80=9D command would probably be very similar to =E2=80=98build-aux/test-driver.scm=E2=80=99. As you note, this script is b= attle-tested and provides useful functionality. If we would turn it into a (scripts test) module, that =E2=80=98guild=E2=80=99 would pick up, then we=E2=80=99d= have a good start. With proper documentation, programmers who use Guile would have an incentive to use this method; packagers would benefit because the default =E2=80=98check=E2=80=99 phase would boil down to invoking =E2=80=9C= guild test=E2=80=9D. I hope this clarifies my proposal. WDYT? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 19 19:34:34 2023 Received: (at 58365) by debbugs.gnu.org; 20 Nov 2023 00:34:34 +0000 Received: from localhost ([127.0.0.1]:52276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4sFE-0003zB-SP for submit@debbugs.gnu.org; Sun, 19 Nov 2023 19:34:33 -0500 Received: from andre.telenet-ops.be ([2a02:1800:120:4::f00:15]:58468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4sF9-0003yt-6P for 58365@debbugs.gnu.org; Sun, 19 Nov 2023 19:34:31 -0500 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by andre.telenet-ops.be with bizsmtp id CQaH2B00B20ykKC01QaJCa; Mon, 20 Nov 2023 01:34:19 +0100 Message-ID: <8a38968e-e3bb-9444-8b98-756f0178fe42@telenet.be> Date: Mon, 20 Nov 2023 01:34:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= References: <20221007205352.1282-1-maximedevos@telenet.be> <87sfjlnw9r.fsf_-_@gnu.org> <878rldkufc.fsf@gnu.org> From: Maxime Devos Subject: Re: bug#58365: [PATCH 0/6] Support #:tests? in guile-build-system In-Reply-To: <878rldkufc.fsf@gnu.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------KuAJevFzwqyF31GIrzJ8kV6Q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r23; t=1700440459; bh=iTu+ypg90+yEmBFuY1AxvpxVQI8MAa9BAy3ILNyLmf4=; h=Date:To:Cc:References:From:Subject:In-Reply-To; b=fyLJcOmiRWrwbCvCbVh9Or57M6cG2lwmYvDm0aCneoa1a6WHrXN5u0BXUGkVQHh9b TN9C1OHZjtkKDMuNkDDiSxem2Ltk/g8lAjBpw7hvvGUAi0LnSn9aAKbEH/SJakkP2/ G8u03dq40hgfwRNdfHhBxC63E9E1Wg90MW36fxiqrTJum2s6xsnyS0t7CyCdhqalYq qTZ+aILTDNKT+weFOIK3LGf2vMqjHIMZOJFeCkEBhaGQt5uSvmdDIXNUYjoDePODQo f3BAyCoWYPvX6p8rBwVaRfd9RM4OhJZsvoMMP0iXbVOVZ9Y5fr9pQjOIVGAZlFtiBL b0Qs1lUMn3SLw== X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 58365 Cc: 58365@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.9 (---) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------KuAJevFzwqyF31GIrzJ8kV6Q Content-Type: multipart/mixed; boundary="------------DF6Alq4gp9ZMat8rLbls04Pu"; protected-headers="v1" From: Maxime Devos To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= Cc: 58365@debbugs.gnu.org Message-ID: <8a38968e-e3bb-9444-8b98-756f0178fe42@telenet.be> Subject: Re: bug#58365: [PATCH 0/6] Support #:tests? in guile-build-system References: <20221007205352.1282-1-maximedevos@telenet.be> <87sfjlnw9r.fsf_-_@gnu.org> <878rldkufc.fsf@gnu.org> In-Reply-To: <878rldkufc.fsf@gnu.org> --------------DF6Alq4gp9ZMat8rLbls04Pu Content-Type: multipart/mixed; boundary="------------n6vRdGRKDpYCqwgdc8adQw7x" --------------n6vRdGRKDpYCqwgdc8adQw7x Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 SGksDQoNCk9wIDE4LTEwLTIwMjIgb20gMTc6NDQgc2NocmVlZiBMdWRvdmljIENvdXJ0w6hz Og0KPiBIaSBNYXhpbWUsDQo+IA0KPiBUaGF04oCZcyBxdWl0ZSBhIHdhbGwgb2YgdGV4dCB0 aGF0IHlvdSBzZW50LiAgOi0pDQoNCkdvaW5nIGJ5IHRoZSBkZWZpbml0aW9uIGF0DQrigJho dHRwczovL2VuLndpa2lwZWRpYS5vcmcvd2lraS9XaWtpcGVkaWE6V2FsbF9vZl90ZXh04oCZ LCBpdCBpc24ndCAtLSBpdCANCmlzIG5vdCBpbnRlbnRpb25hbGx5IGRpc3J1cHRpdmUgKG5l aXRoZXIgdW5pbnRlbnRpb25hbGx5IGRpc3J1cHRpdmUpLCBpdCANCmlzIG5vdCBhbiBhdHRl bXB0IGF0IG92ZXJ3aGVsbWVuaW5nLCBpdCBpcyBub3QgaXJyZWxldmFudCBhbmQgQUZBSUNU IGl0IA0KaXMgbm90IGR1ZSB0byBhbiB1bmF3YXJlbmVzcyBvZiBnb29kIHByYWN0aWNlcy4N Cg0KVGhlIG9ubHkg4oCYd2FsbC1vZi10ZXh04oCZIHByb3BlcnR5IGl0IG1pZ2h0IGhhdmUg aXMgaXRzIGxlbmd0aC4NCg0KU28sIHlvdSdyZSBhcHBhcmVudGx5IGlnbm9yaW5nIGFsbCB3 aGF0IEkgd3JvdGUgcHJldmlvdXNseT8NCg0KPiBMZXQgbWUgdHJ5IHRvIGNsYXJpZnkgd2hh dCBJIHRoaW5rIGNhbiBiZSBhIGZydWl0ZnVsIHdheSBmb3J3YXJkLg0KPiBBZ2FpbiwgSSBh Z3JlZSB3aXRoIHRoZSBnb2FsIHlvdSBoYXZlIGhlcmUsIEnigJltIGp1c3QgcHJvcG9zaW5n IGENCj4gZGlmZmVyZW50IHN0cmF0ZWd5Lg0KPiANCj4gVG8gbWUsIHRoZSBwcm9ibGVtIHRo YXQgd2UgaGF2ZSBpcyBsYWNrIG9mIGEgc3RhbmRhcmQgd2F5IHRvIHJ1biB0ZXN0cw0KPiBp biBHdWlsZSBwYWNrYWdlcyB0aGF0IGRvbuKAmXQgdXNlIEF1dG90b29scy4gIFRoYXQsIGlu IHR1cm4sIGxlYWRzIHRvDQo+IGR1cGxpY2F0aW9uIGluIHBhY2thZ2UgZGVmaW5pdGlvbnPi gJR3aGV0aGVyIGl04oCZcyDigJhjaGVja+KAmSBwaGFzZXMgaW4gR3VpeA0KPiBvciBzb21l dGhpbmcgc2ltaWxhciBpbiBEZWJpYW4gYW5kIG90aGVyIGRpc3Ryb3MuDQoNCkVyciwgdGhp cyBpcyB0aGUgc2FtZSBmb3IgQXV0b3Rvb2xzIEd1aWxlIHBhY2thZ2VzIC0tIEF1dG90b29s cyBHdWlsZSANCnBhY2thZ2VzIGhhdmUgdG8gY29weSB0ZXN0LWRyaXZlci5zY20gdG9vIChv ciBkbyAoZXhpdCAxKS1zdHlsZSB0ZXN0cywgDQpidXQgdGhvc2UgYXJlbid0IHJlYWxseSB0 aGUgdGVzdHMgdGhpcyBwYXRjaCBzZXJpZXMpLiAgWW91IGNhbiBkcm9wIHRoZSANCnF1YWxp ZmllciDigJgNCg0KQWxzbywgdGhlcmUgaXMsIGluIGZhY3QgYSBzdGFuZGFyZCB3YXkgdG8g cnVuIHRlc3RzIGluIEd1aWxlIHBhY2thZ2VzOiANCmNvcHkgdGhlIHRlc3QtZHJpdmVyLnNj bSAoYW5kIGluIGNhc2Ugb2YgQXV0b3Rvb2xzLCBwYXJ0cyBvZiB0aGUgDQpNYWtlZmlsZS5h bSBmcm9tIGFub3RoZXIgR3VpbGUgcGFja2FnZSkuDQoNCldoaWxlIHRoaXMgZG9lcyBzb3Vu ZCBsaWtlIF9hXyBwcm9ibGVtLCBpdCBpcyBub3QgYSBwcm9ibGVtIHRoaXMgcGF0Y2ggDQpz ZXJpZXMgaXMgYWJvdXQgYW5kIGhlbmNlIG5vdCBfdGhlXyBwcm9ibGVtIChzZWUgbGF0ZXIg Zm9yIGRldGFpbHMpLg0KDQo+IEluc3RlYWQgb2YgYWRkcmVzc2luZyBpdCBkb3duc3RyZWFt IChpbiBHdWl4KSwgbXkgc3VnZ2VzdGlvbiB3b3VsZCBiZSB0bw0KPiBhZGRyZXNzIGl0IHVw c3RyZWFt4oCUdGhhdCBpcywgdG8gcHJvbW90ZSBvbmUgd2F5IHRvIHJ1biBTUkZJLTY0IHRl c3QNCj4gc3VpdGVzLCBmb3IgZXhhbXBsZSB3aXRoIGEgbmV3IOKAnGd1aWxkIHRlc3TigJ0g Y29tbWFuZC4NCg0KQnV0IEd1aXggaXMgdGhlIHVwc3RyZWFtIChJIG1lbnRpb25lZCB0aGlz IGluIHRoZSBmaXJzdCBlLW1haWwgKikgLS0gDQpBRkFJQ1QsIEd1aXggaGFzIHRoZSBsYXRl c3QgdmVyc2lvbiBvZiB0ZXN0LWRyaXZlci5zY20sIGFuZCBBRkFJQ1QgR3VpeCANCmlzIHdo ZXJlIHRlc3QtZHJpdmVyLnNjbSArIHBhcnRzIG9mIE1ha2VmaWxlLmFtIGlzIGNvcGllZCBm cm9tLg0KDQooKikgYW5kIGFsc28gcmlnaHQgaW4gdGhlIGUtbWFpbCB5b3Ugd2VyZSByZXNw b25kaW5nIHRvOg0KDQo+IEdvaW5nIGJ5ICJnaXQgbG9nIGJ1aWxkLWF1eC90ZXN0LWRyaXZl ci5zY20iLCBHdWl4IGlzIHRoZSB1cHN0cmVhbSwgbm90IA0KPiBHdWlsZSwgdGhvdWdoIEkg c3VwcG9zZSBpdCBjb3VsZCBldmVudHVhbGx5IGJlIG1vdmVkIHRvIEd1aWxlIGlmIGRlc2ly ZWQgDQo+IGJ5IGJvdGguDQoNClNlZSwgSSBjYW4gbWFrZSBjbGFpbXMgdG9vLiAgVGhlIGRp ZmZlcmVuY2UgaXMgdGhhdCB5b3UgbXVsdGlwbHkgdGltZXMgDQpjbGFpbWVkIHRoaW5ncyBf d2l0aG91dF8gZXZpZGVuY2Ugd2hlcmVhcyB3aGVuIEkgY2xhaW1lZCB0aGUgY29udHJhcnkg DQpfd2l0aF8gZXZpZGVuY2UuDQoNCi4uLiBkaWQgeW91IGV2ZW4gcmVhZCBpdD8gIE15IOKA mHdhbGwgb2YgdGV4dOKAmSB3YXNuJ3QgZm9yIHNob3cuDQoNCj4gVGhhdCDigJxndWlsZCB0 ZXN04oCdIGNvbW1hbmQgd291bGQgcHJvYmFibHkgYmUgdmVyeSBzaW1pbGFyIHRvDQo+IOKA mGJ1aWxkLWF1eC90ZXN0LWRyaXZlci5zY23igJkuICBBcyB5b3Ugbm90ZSwgdGhpcyBzY3Jp cHQgaXMgYmF0dGxlLXRlc3RlZA0KPiBhbmQgcHJvdmlkZXMgdXNlZnVsIGZ1bmN0aW9uYWxp dHkuICBJZiB3ZSB3b3VsZCB0dXJuIGl0IGludG8gYSAoc2NyaXB0cw0KPiB0ZXN0KSBtb2R1 bGUsIHRoYXQg4oCYZ3VpbGTigJkgd291bGQgcGljayB1cCwgdGhlbiB3ZeKAmWQgaGF2ZSBh IGdvb2Qgc3RhcnQuDQo+IFdpdGggcHJvcGVyIGRvY3VtZW50YXRpb24sIHByb2dyYW1tZXJz IHdobyB1c2UgR3VpbGUgd291bGQgaGF2ZSBhbg0KPiBpbmNlbnRpdmUgdG8gdXNlIHRoaXMg bWV0aG9kOyBwYWNrYWdlcnMgd291bGQgYmVuZWZpdCBiZWNhdXNlIHRoZQ0KPiBkZWZhdWx0 IOKAmGNoZWNr4oCZIHBoYXNlIHdvdWxkIGJvaWwgZG93biB0byBpbnZva2luZyDigJxndWls ZCB0ZXN04oCdLg0KPiANCj4gSSBob3BlIHRoaXMgY2xhcmlmaWVzIG15IHByb3Bvc2FsLiAg V0RZVD8NCg0KSSB0aGluayB0aGF0IGlzIGEgY2xlYXIgcHJvcG9zYWwsIEknbSBub3QgaW50 ZXJlc3RlZCBpbiBpbXBsZW1lbnRpbmcgaXQsIA0KSSBjb25zaWRlciBpdCBvdXQtb2Ytc2Nv cGUgYW5kIHNvbWV0aGluZyB0aGF0IGNvdWxkIGJlIGRvbmUgc2VwYXJhdGVseSANCmZyb20g dGhpcyBwYXRjaCBzZXJpZXMsIGFuZCBJIHdvbid0IGRvIGl0LCBubyBtYXR0ZXIgdGhhdCB5 b3UgYXJlIA0KcHJlc2VudGluZyBpdCBhcyBpZiBpdCB3ZXJlIG5hdHVyYWwgZm9yIG1lIHRv IGRvIHNvIC0tIEknbSBub3QgcGFpZCANCmVub3VnaCBmb3IgdGhpcyBhbmQgZG9uJ3Qgd2Fu dCB5b3VyIG1vbmV5Lg0KDQpGaW5kaW5nIHdobyBzaG91bGQgYmUgdGhlIHVwc3RyZWFtIG9m IHRlc3QtZHJpdmVyLnNjbSBvciBmaW5kaW5nIGEgbmV3IA0KaG9tZSBmb3IgdGVzdC1kcml2 ZXIuc2NtIGlzIG5vdCBhdCBhbGwgdGhlIHBvaW50IG9mIHRoaXMgcGF0Y2ggc2VyaWVzIC0t IA0KdGhlIHBvaW50IGlzIHRvIHN1cHBvcnQgIzp0ZXN0cz8gaW4gZ3VpbGUtYnVpbGQtc3lz dGVtLCBhbmQgZm9yIHRoYXQgYSANCnRlc3QgZHJpdmVyIGlzIG5lZWRlZCwgYW5kIGxvb2ss IHRoZXJlIGlzIGEgdGVzdCBkcml2ZXIgcmlnaHQgaGVyZSBpbiANCnRoZSBHdWl4IHJlcG8s IGxldCdzIHBhY2thZ2UgaXQgc28gdGhhdCBpdCBiZWNvbWVzIGF2YWlsYWJsZSB0byB0aGUg DQpidWlsZC90ZXN0IGNvZGUgb2YgZ3VpbGUtYnVpbGQtc3lzdGVtIChhbmQgYXMgYSBib251 cywgaXQgbWFrZXMgDQp0ZXN0LWRyaXZlci5zY20gbW9yZSBkaXNjb3ZlcmFibGUpLg0KDQpJ T1csIGdvaW5nIGJhY2sgdG8geW91ciDigJhJJ20ganVzdCBwcm9wb3NpbmcgYSBkaWZmZXJl bnQgc3RyYXRlZ3nigJkgDQpjb21tZW50IC0tIHlvdSBhcmVuJ3QgcHJvcG9zaW5nIGEgZGlm ZmVyZW50IHN0cmF0ZWd5IGZvciB0aGUgcGF0Y2ggDQpzZXJpZXMsIHlvdSBhcmUgcHJvcG9z aW5nIHNvbWV0aGluZyBzdXBwbGVtZW50YWwsIGFuZCB0aGF0IOKAmHNvbWV0aGluZyANCnN1 cHBsZW1lbnRhbOKAmSBpcyBzb21ldGhpbmcgZm9yIGd1aWxlLWRldmVsQCwgbm90IGd1aXhA Lg0KDQpCZXN0IHJlZ2FyZHMgKGV4Y2VwdCB0byBMdWRvICgqKSksDQpNYXhpbWUgRGV2b3MN Cg0KKCopIGJlY2F1c2Ugb2YgdGhlIHVuY29uc3RydWN0aXZlIGFuZCBkaXNyZXNwZWN0ZnVs IFBNcywgYW5kIG90aGVyIHJlYXNvbnMNCg== --------------n6vRdGRKDpYCqwgdc8adQw7x Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------n6vRdGRKDpYCqwgdc8adQw7x-- --------------DF6Alq4gp9ZMat8rLbls04Pu-- --------------KuAJevFzwqyF31GIrzJ8kV6Q Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCZVqphAUDAAAAAAAKCRBJ4+4iGRcl7vwy AP9+rVPeLKPh1pkrdh66Q+vdMC/+3aXt0pj7RppnC8sWlwEAuGC8UozaCc2uUchYGY0iFGBoaFKr ykcQ7rvtLbuhtAA= =//Kc -----END PGP SIGNATURE----- --------------KuAJevFzwqyF31GIrzJ8kV6Q-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 19 19:41:23 2023 Received: (at 58365) by debbugs.gnu.org; 20 Nov 2023 00:41:23 +0000 Received: from localhost ([127.0.0.1]:52281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4sLr-00048h-H3 for submit@debbugs.gnu.org; Sun, 19 Nov 2023 19:41:23 -0500 Received: from michel.telenet-ops.be ([2a02:1800:110:4::f00:18]:55248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4sLo-00048T-LF for 58365@debbugs.gnu.org; Sun, 19 Nov 2023 19:41:21 -0500 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by michel.telenet-ops.be with bizsmtp id CQhB2B00520ykKC06QhBb8; Mon, 20 Nov 2023 01:41:12 +0100 Message-ID: <7f81995d-b3a1-fa59-5651-86f5768d5797@telenet.be> Date: Mon, 20 Nov 2023 01:41:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#58365: [PATCH 0/6] Support #:tests? in guile-build-system Content-Language: en-US From: Maxime Devos To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= References: <20221007205352.1282-1-maximedevos@telenet.be> <87sfjlnw9r.fsf_-_@gnu.org> <878rldkufc.fsf@gnu.org> <8a38968e-e3bb-9444-8b98-756f0178fe42@telenet.be> In-Reply-To: <8a38968e-e3bb-9444-8b98-756f0178fe42@telenet.be> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------NHva0XZW0pL0IHJoQu0G7Mlj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r23; t=1700440872; bh=i0LIATchyjlSsvcPdZTUKmGOUg5AsyAE7Wk3kk3oQWU=; h=Date:Subject:From:To:Cc:References:In-Reply-To; b=kz3vQ48/n/uQRTZcZ8qWfkNlyuf8MRxr7pMO53yhMHSj4gaXqHbczho2OL+Ch429u 4/9/J5XmHka/gz3pjAilW1ZVQXgmiGe3Jw/k83kdnL3WZRmS1CdwwGu3n6FHOOtC7U fHAFQ/dq7CU1Ta2yXiLbygR1i0l/gBkp1LXiU/wkbEkMBThCPPteIO0MYezkjf8Jm7 9giP2LY/nyByEFxck5/SoiEavpadHIPMYJifWbzyt1LBDpbPNAuS3XaE23C4WugNI+ cxr6RlmWkZ/HwvURV8CmVvMGG7nEjbWo3ADiTaUErLW9miW/w9CoUopWc2KKfzLDAS L/8g0oXOqHrWA== X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 58365 Cc: 58365@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.9 (---) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------NHva0XZW0pL0IHJoQu0G7Mlj Content-Type: multipart/mixed; boundary="------------lNRt8QGpkUMYAz1oByJyWQ08"; protected-headers="v1" From: Maxime Devos To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= Cc: 58365@debbugs.gnu.org Message-ID: <7f81995d-b3a1-fa59-5651-86f5768d5797@telenet.be> Subject: Re: bug#58365: [PATCH 0/6] Support #:tests? in guile-build-system References: <20221007205352.1282-1-maximedevos@telenet.be> <87sfjlnw9r.fsf_-_@gnu.org> <878rldkufc.fsf@gnu.org> <8a38968e-e3bb-9444-8b98-756f0178fe42@telenet.be> In-Reply-To: <8a38968e-e3bb-9444-8b98-756f0178fe42@telenet.be> --------------lNRt8QGpkUMYAz1oByJyWQ08 Content-Type: multipart/mixed; boundary="------------iS6bW0dqVmVNhw0Vw8TOfF0o" --------------iS6bW0dqVmVNhw0Vw8TOfF0o Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 KFNvbWUgY29udGV4dCBJIGZvcmdvdCB0byBpbmNsdWRlOikNCg0KQXJvdW5kIHRoZSBzYW1l IHRpbWUgYXQgdGhlIGxhc3QgcHJldmlvdXMgbWVzc2FnZSAgb24gdGVjaG5pY2FsIG1hdHRl cnMgDQooaHR0cHM6Ly9pc3N1ZXMuZ3VpeC5nbnUub3JnLzU4MzY1IzkpLCBMdWRvJyBzZW50 IGEgUE0gb24gc29tZSANCm5vbi10ZWNobmljYWwgbWF0dGVycywgYW5kIEkgYW5zd2VyZWQg dG8gdGhlIFBNIGluc3RlYWQgb2YgNTgzNjUsIA0KbGVhdmluZyB0aGUgdGVjaG5pY2FsIG1h dHRlcnMgbWVzc2FnZSB1bnJlcGxpZWQuICBTbywgbm93LCBhdCBsYXN0LCBhIHJlcGx5Lg0K --------------iS6bW0dqVmVNhw0Vw8TOfF0o Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------iS6bW0dqVmVNhw0Vw8TOfF0o-- --------------lNRt8QGpkUMYAz1oByJyWQ08-- --------------NHva0XZW0pL0IHJoQu0G7Mlj Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCZVqrJgUDAAAAAAAKCRBJ4+4iGRcl7lCH AQCkusi79r0B/7FptpsFqRoCkzyBMWfzPpqggv1P/NeEdAD/RE9WfV+LRhz95LbufAIjNi521cgj LQEd7oXIOknx9AE= =5tRr -----END PGP SIGNATURE----- --------------NHva0XZW0pL0IHJoQu0G7Mlj-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 03 04:17:41 2023 Received: (at 58365) by debbugs.gnu.org; 3 Dec 2023 09:17:41 +0000 Received: from localhost ([127.0.0.1]:59116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9ibd-0004gZ-48 for submit@debbugs.gnu.org; Sun, 03 Dec 2023 04:17:41 -0500 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:51509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9ibb-0004gK-A5 for 58365@debbugs.gnu.org; Sun, 03 Dec 2023 04:17:40 -0500 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-332f90a375eso2784462f8f.3 for <58365@debbugs.gnu.org>; Sun, 03 Dec 2023 01:17:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701595043; x=1702199843; darn=debbugs.gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=uiP6bpNRlBd/oV/YiJ1tf2eFOmi8zkkpa4KzmvFypLk=; b=Ey8blcrtnMG4At0MBftoq9ydRbcly+CCbJNL85gnAEp1EPKZThh7B97RJ5uu0fAsc3 pi0tvIyxuahpZZoNpOiqV5zeTSkgClRXHvGnfryIAAp2KbTPIUs6Kji+3dCd/fFWXc8v uDymWI3gmbnSf+1MXVdQVIRC4mxRzepXfsblXdGTU4xCyHkBz9bh5chSu7N5H9H/cbzc sUnq9U267Q8hiwymGj6e4FGuYhPQ8w/2aYMNxKebJkwPoIulxSZyTC/QIJIJ95kjswMp gG3RG0mkFgEpL1oNjhpAAXDHRo+UIT849q15F15wKTQTF7Gc7hDijovSX9xHDlgr3jV2 /xeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701595043; x=1702199843; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uiP6bpNRlBd/oV/YiJ1tf2eFOmi8zkkpa4KzmvFypLk=; b=aJfD9u0zwoXyqGw8lr/7QbajkI3CbcKkM3Xm0as2VGVbkGrfibG/JPTwuiagFa2CKw 5YAOP7H7/BU7ZqNo20SVIN9lQWXecLvsfRqNaRdDdAKouNcvXtpddQnv4vkVq7t9CeKo Iad59670DGUu3on1qJS9VhYJHTKLxrArYTX9g3wE4lzhALSDNEnnNkpSewef6EvMAtCr PaulWcapzrIyCT7AlS35UX4QsEIPNgSCTnd08+NXm95bT7Fw2dIuUq+FqLDTwJs+8jU5 HtpgayxqjmQOHsymm4upo/UYBqfvcRRAx7orFcLsTpn9aZRziKbAsTH9ea6DVvk7/sbd FSew== X-Gm-Message-State: AOJu0Yxswc1svWHlrP7UVqiQ9VrHs7tjQViGaSpSQCeMjgk/qJZ/ksnT zD823fAYJ7s3odw9QqVmlc0= X-Google-Smtp-Source: AGHT+IHylWbsRi74D0MPWP2z+Nuksohtt+tpkggPWo47x86KlfHs5kkzf/mzHdgq8UdP7//2qr8HrA== X-Received: by 2002:a5d:674c:0:b0:333:152d:641c with SMTP id l12-20020a5d674c000000b00333152d641cmr2271733wrw.26.1701595043347; Sun, 03 Dec 2023 01:17:23 -0800 (PST) Received: from localhost ([188.120.129.233]) by smtp.gmail.com with ESMTPSA id cp6-20020a056000400600b003334520e49bsm799426wrb.53.2023.12.03.01.17.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Dec 2023 01:17:22 -0800 (PST) Date: Sun, 3 Dec 2023 11:17:21 +0200 From: Efraim Flashner To: Maxime Devos Subject: Re: bug#58365: [PATCH 0/6] Support #:tests? in guile-build-system Message-ID: Mail-Followup-To: Efraim Flashner , Maxime Devos , Ludovic =?utf-8?Q?Court=C3=A8s?= , 58365@debbugs.gnu.org References: <20221007205352.1282-1-maximedevos@telenet.be> <87sfjlnw9r.fsf_-_@gnu.org> <878rldkufc.fsf@gnu.org> <8a38968e-e3bb-9444-8b98-756f0178fe42@telenet.be> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mKiFUPDel/W6m6K7" Content-Disposition: inline In-Reply-To: <8a38968e-e3bb-9444-8b98-756f0178fe42@telenet.be> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 58365 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 58365@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --mKiFUPDel/W6m6K7 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Top posting to make sure it is read: Maxime: I understand this has been going back and forth for over a year now and has been very frustrating, but parts of this email are unnecessary. As a maintainer I haven't done enough to try to ease tensions and find an equitable solution and for that I apologize. Ludo: Based on the publicly available emails I'm not seeing why this was held in limbo for so long. For plenty of packages we have a policy of writing a patch, submitting it upstream if possible, and carrying it until we can drop it. Currently I'm not seeing this as so much different as either that case or some of the other files we carry in gnu/packages/aux-files. To everyone: Please keep in mind if you feel the need to remove the mailing list from the reply chain if it is because it is something that really, truly, doesn't need to be sent to everyone or because you'd rather have it hidden from view. I am liberally removing parts of the email as I respond below: On Mon, Nov 20, 2023 at 01:34:12AM +0100, Maxime Devos wrote: > Hi, >=20 > Op 18-10-2022 om 17:44 schreef Ludovic Court=C3=A8s: > > Let me try to clarify what I think can be a fruitful way forward. > > Again, I agree with the goal you have here, I=E2=80=99m just proposing a > > different strategy. Noted > > To me, the problem that we have is lack of a standard way to run tests > > in Guile packages that don=E2=80=99t use Autotools. That, in turn, lea= ds to > > duplication in package definitions=E2=80=94whether it=E2=80=99s =E2=80= =98check=E2=80=99 phases in Guix > > or something similar in Debian and other distros. Noted > Err, this is the same for Autotools Guile packages -- Autotools Guile > packages have to copy test-driver.scm too (or do (exit 1)-style tests, but > those aren't really the tests this patch series). You can drop the > qualifier =E2=80=98 >=20 > Also, there is, in fact a standard way to run tests in Guile packages: co= py > the test-driver.scm (and in case of Autotools, parts of the Makefile.am f= rom > another Guile package). >=20 > While this does sound like _a_ problem, it is not a problem this patch > series is about and hence not _the_ problem (see later for details). Noted. Referring back to duplicated code above from Ludo, I wonder about using the test-driver script by default vs adding it per-package, but I don't have a good handle on how many packages are waiting to use it. > > Instead of addressing it downstream (in Guix), my suggestion would be to > > address it upstream=E2=80=94that is, to promote one way to run SRFI-64 = test > > suites, for example with a new =E2=80=9Cguild test=E2=80=9D command. >=20 > But Guix is the upstream (I mentioned this in the first e-mail *) -- AFAI= CT, > Guix has the latest version of test-driver.scm, and AFAICT Guix is where > test-driver.scm + parts of Makefile.am is copied from. >=20 > (*) and also right in the e-mail you were responding to: Sounds like Guix is the upstream of test-driver.scm and guile, as the upstream language in this build-system, could absorb it and make it available through 'guild test'. > > Going by "git log build-aux/test-driver.scm", Guix is the upstream, not > > Guile, though I suppose it could eventually be moved to Guile if desired > > by both. > > > That =E2=80=9Cguild test=E2=80=9D command would probably be very simila= r to > > =E2=80=98build-aux/test-driver.scm=E2=80=99. As you note, this script = is battle-tested > > and provides useful functionality. If we would turn it into a (scripts > > test) module, that =E2=80=98guild=E2=80=99 would pick up, then we=E2=80= =99d have a good start. > > With proper documentation, programmers who use Guile would have an > > incentive to use this method; packagers would benefit because the > > default =E2=80=98check=E2=80=99 phase would boil down to invoking =E2= =80=9Cguild test=E2=80=9D. > >=20 > > I hope this clarifies my proposal. WDYT? Sounds like a good long-term plan. That said, it is something to work out at a later date, not in this patch series. > I think that is a clear proposal, I'm not interested in implementing it, I > consider it out-of-scope and something that could be done separately from > this patch series. Noted > Finding who should be the upstream of test-driver.scm or finding a new ho= me > for test-driver.scm is not at all the point of this patch series -- the > point is to support #:tests? in guile-build-system, and for that a test > driver is needed, and look, there is a test driver right here in the Guix > repo, let's package it so that it becomes available to the build/test code > of guile-build-system (and as a bonus, it makes test-driver.scm more > discoverable). Sounds reasonable. > IOW, going back to your =E2=80=98I'm just proposing a different strategy= =E2=80=99 comment -- > you aren't proposing a different strategy for the patch series, you are > proposing something supplemental, and that =E2=80=98something supplementa= l=E2=80=99 is > something for guile-devel@, not guix@. I ignored this the first time through because it has to do with the guile-build-system and that's not something I've ever looked at. It sounds like the best *long term* option is to move this upstream to guile or to package it separately in its own repository. Seeing as it's been a year since this thread started I don't see that as a reason to hold anything up. In the immediate term, it looks like this patch set (which I haven't tested, but noticed the patches seem to be in the wrong order) would bring testing to the guile packages, which everyone agrees is a Good Thing=E2=84=A2. Lets get it fixed up and merged and any other bits can be worked on at a later date. If no one else comes forward to make sure that all the pieces work the way they're supposed to I will take care of it myself in about a week. In the mean time, please try to keep the conversation at least civil, and remember that we're all bound by the Code of Conduct while involved with Guix. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --mKiFUPDel/W6m6K7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmVsR50ACgkQQarn3Mo9 g1HOdg//Q2/tJdMWSDlzw/xQujuqJ6EBEoI406Z/XvYNbIQxmMUwOPiJNFbyooKi r5T068KUGpvRCsg61hW8JrkFaEhCGic33irwyC70SlPiDKodEDnYl6GMk/+4ggOg PoS/Q1/MucnBWIT4cj1fPKqlbHq2Umtgl0YKjd8E94zJeYaQX6C3OBgW/CVn4eKs TR3iI+jDCEXkwClGFDwysbZsLQfY1kNgFVFI3A7mumZLbc+zw5zEA+xC57uzT0CQ Y4IFQU9saQLUCwjeIwFepBo6Ofz+8T9fXB30jPQ7Ako7nP6wAG0R8QL/SL6M058G UnL+sj83eMjvMiOR30XN6Abuo7yEWgFnYV3G7kr0Y+R+Im1k/4AU0O9a4c6zfPop PO5U0735gPX2nfT+C0DfCYcsiuBfzEIc9UAIxw3mXT+s6kGpPMJRuW6dqNBeecV5 QjzV5qANYNH1CoT4CfJhs4HQXo1ojMacTPRivlFkhnfcVMLy8v6WN19Gr7TK2vbG Umfkzdq+7HShRGKAVqyTbTNogqThIslLikshJERafq68oOt8L4eqLaVXlEkP889Z b3WxsxErd0Uqg7ELIAZYr8rcEumLoCqfFurjtQHW/3D5cSkaDUFxWsfwVR5vpXUi lkgxVkXuuiDx2+Zk2Ekj4FTir4N22f9UK9aW5C509VIM/Htx9p4= =bK7B -----END PGP SIGNATURE----- --mKiFUPDel/W6m6K7--