From unknown Sun Jun 22 22:44:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#5831: 23.1.94; htmlfontify's `hfy-which-etags' not finding etags "standalone" Resent-From: MON KEY Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Apr 2010 18:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 5831 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 5831@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.127032011415754 (code B ref -1); Sat, 03 Apr 2010 18:42:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Apr 2010 18:41:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ny8I5-000463-Lt for submit@debbugs.gnu.org; Sat, 03 Apr 2010 14:41:53 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ny8I3-00045y-OC for submit@debbugs.gnu.org; Sat, 03 Apr 2010 14:41:52 -0400 Received: from lists.gnu.org ([199.232.76.165]:39964) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ny8Hz-0006lN-Ln for submit@debbugs.gnu.org; Sat, 03 Apr 2010 14:41:47 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ny8Hz-0000cK-0K for bug-gnu-emacs@gnu.org; Sat, 03 Apr 2010 14:41:47 -0400 Received: from [140.186.70.92] (port=44465 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ny8Hx-0000c4-O8 for bug-gnu-emacs@gnu.org; Sat, 03 Apr 2010 14:41:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ny8Ht-00088K-SF for bug-gnu-emacs@gnu.org; Sat, 03 Apr 2010 14:41:45 -0400 Received: from mail-gw0-f41.google.com ([74.125.83.41]:58762) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ny8Ht-000882-PX for bug-gnu-emacs@gnu.org; Sat, 03 Apr 2010 14:41:41 -0400 Received: by gwb15 with SMTP id 15so2494160gwb.0 for ; Sat, 03 Apr 2010 11:41:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.91.6 with HTTP; Sat, 3 Apr 2010 11:41:40 -0700 (PDT) Date: Sat, 3 Apr 2010 14:41:40 -0400 X-Google-Sender-Auth: 29a15702a374c8c3 Received: by 10.150.120.33 with SMTP id s33mr4394772ybc.50.1270320100823; Sat, 03 Apr 2010 11:41:40 -0700 (PDT) Message-ID: From: MON KEY Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) `hfy-which-etags' fails when the etags executable in path is of type "standalone" (not sure if this w32 specific): (shell-command-to-string (concat hfy-etags-bin " --version")) (executable-find hfy-etags-bin) ;=> "/emacs-23.1.94/bin/etags.exe" (executable-find "etags") ;=> "/emacs-23.1.94/bin/etags.exe" (equal (executable-find hfy-etags-bin) (executable-find "etags")) ;=> t (shell-command-to-string (concat hfy-etags-bin " --version"))) ;=> "etags (standalone 17.38.1.4) ; | Copyright (C) 2010 Free Software Foundation, Inc. ; | This program is distributed under the terms in ETAGS.README" Its unlikey we wouldn't have an etags in path... On a GNU/Linux evaluating same I get: (shell-command-to-string (concat hfy-etags-bin " --version")) ;=> "etags (GNU Emacs 23.1.90) ; | Copyright (C) 2009 Free Software Foundation, Inc. ; | This program is distributed under the terms in ETAGS.README" and `hfy-which-etags' conditional _does_ match this etags exectuable. `hfy-which-etags' conditional string-match evaluations should have a rule to match a ``standalone'' etags. The problem is that when `hfy-which-etags' returns false it causes `hfy-etags-cmd' to fail: (cdr (assoc (hfy-which-etags) hfy-etags-cmd-alist)) ;=> nil if we add a new rule to `hfy-which-etags' conditional: ((string-match "standalone" v) "emacs etags") then we get the appropriate shell script template: (cdr (assoc (hfy-which-etags) hfy-etags-cmd-alist)) ;=> for src in `find . -type f`; ; | do ; | ETAGS=%s; ; | { ... lots more ellided ... } This won't change htmlfontify's reliance on a POSIX friendly shell (nor should it). However, the user shouldn't be restricted from using this library _because_ she is using the executable distributed _with_ her local Emacs... Patch follows: ;;; ============================== *** lisp/htmlfontify.el 2010-03-10 20:20:34.000000000 -0500 --- buffer-content-3664ZIc 2010-04-03 14:28:32.493000000 -0400 *************** *** 391,397 **** (defun hfy-which-etags () "Return a string indicating which flavour of etags we are using." (let ((v (shell-command-to-string (concat hfy-etags-bin " --version")))) ! (cond ((string-match "exube" v) "exuberant ctags") ((string-match "GNU E" v) "emacs etags" )) )) (defcustom hfy-etags-cmd --- 391,398 ---- (defun hfy-which-etags () "Return a string indicating which flavour of etags we are using." (let ((v (shell-command-to-string (concat hfy-etags-bin " --version")))) ! (cond ((string-match "standalone" v) "exuberant ctags") ! ((string-match "exube" v) "exuberant ctags") ((string-match "GNU E" v) "emacs etags" )) )) (defcustom hfy-etags-cmd ;;; ============================== /s_P\ From unknown Sun Jun 22 22:44:37 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: MON KEY Subject: bug#5831: closed (Re: bug#5831: 23.1.94; htmlfontify's `hfy-which-etags' not finding etags "standalone") Message-ID: References: <99d35kp7tv.fsf@fencepost.gnu.org> X-Gnu-PR-Message: they-closed 5831 X-Gnu-PR-Package: emacs Reply-To: 5831@debbugs.gnu.org Date: Thu, 31 May 2012 17:43:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1338486182-27836-1" This is a multi-part message in MIME format... ------------=_1338486182-27836-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #5831: 23.1.94; htmlfontify's `hfy-which-etags' not finding etags "standal= one" which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 5831@debbugs.gnu.org. --=20 5831: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D5831 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1338486182-27836-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 5831-done) by debbugs.gnu.org; 31 May 2012 17:42:41 +0000 Received: from localhost ([127.0.0.1]:52154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sa9OS-0007EM-Et for submit@debbugs.gnu.org; Thu, 31 May 2012 13:42:41 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:37060 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sa9O8-0007Dv-F4 for 5831-done@debbugs.gnu.org; Thu, 31 May 2012 13:42:39 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Sa9Ma-0008Bb-6I; Thu, 31 May 2012 13:40:44 -0400 From: Glenn Morris To: 5831-done@debbugs.gnu.org Subject: Re: bug#5831: 23.1.94; htmlfontify's `hfy-which-etags' not finding etags "standalone" References: X-Spook: satellite imagery Blowfish Qaddafi CESID lock picking X-Ran: R*IEi5n0*48Qz/*P?<+_Sbw/'1*!H0m0:u-:J"oCS67bD2Q@l1kXHWk/P|YFQ2xnh^Kjr- X-Hue: yellow X-Attribution: GM Date: Thu, 31 May 2012 13:40:44 -0400 In-Reply-To: (MON KEY's message of "Sat, 3 Apr 2010 14:41:40 -0400") Message-ID: <99d35kp7tv.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 5831-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Version: 23.3 I guess this will have been fixed by this change: 2011-02-02 Eli Zaretskii * makefile.w32-in (ETAGS_CFLAGS, CTAGS_CFLAGS): Add ``-DVERSION="\"$(VERSION)\"" -DEMACS_NAME="\"GNU Emacs\""''. ------------=_1338486182-27836-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 Apr 2010 18:41:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ny8I5-000463-Lt for submit@debbugs.gnu.org; Sat, 03 Apr 2010 14:41:53 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ny8I3-00045y-OC for submit@debbugs.gnu.org; Sat, 03 Apr 2010 14:41:52 -0400 Received: from lists.gnu.org ([199.232.76.165]:39964) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ny8Hz-0006lN-Ln for submit@debbugs.gnu.org; Sat, 03 Apr 2010 14:41:47 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ny8Hz-0000cK-0K for bug-gnu-emacs@gnu.org; Sat, 03 Apr 2010 14:41:47 -0400 Received: from [140.186.70.92] (port=44465 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ny8Hx-0000c4-O8 for bug-gnu-emacs@gnu.org; Sat, 03 Apr 2010 14:41:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ny8Ht-00088K-SF for bug-gnu-emacs@gnu.org; Sat, 03 Apr 2010 14:41:45 -0400 Received: from mail-gw0-f41.google.com ([74.125.83.41]:58762) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ny8Ht-000882-PX for bug-gnu-emacs@gnu.org; Sat, 03 Apr 2010 14:41:41 -0400 Received: by gwb15 with SMTP id 15so2494160gwb.0 for ; Sat, 03 Apr 2010 11:41:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.91.6 with HTTP; Sat, 3 Apr 2010 11:41:40 -0700 (PDT) Date: Sat, 3 Apr 2010 14:41:40 -0400 X-Google-Sender-Auth: 29a15702a374c8c3 Received: by 10.150.120.33 with SMTP id s33mr4394772ybc.50.1270320100823; Sat, 03 Apr 2010 11:41:40 -0700 (PDT) Message-ID: Subject: 23.1.94; htmlfontify's `hfy-which-etags' not finding etags "standalone" From: MON KEY To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) `hfy-which-etags' fails when the etags executable in path is of type "standalone" (not sure if this w32 specific): (shell-command-to-string (concat hfy-etags-bin " --version")) (executable-find hfy-etags-bin) ;=> "/emacs-23.1.94/bin/etags.exe" (executable-find "etags") ;=> "/emacs-23.1.94/bin/etags.exe" (equal (executable-find hfy-etags-bin) (executable-find "etags")) ;=> t (shell-command-to-string (concat hfy-etags-bin " --version"))) ;=> "etags (standalone 17.38.1.4) ; | Copyright (C) 2010 Free Software Foundation, Inc. ; | This program is distributed under the terms in ETAGS.README" Its unlikey we wouldn't have an etags in path... On a GNU/Linux evaluating same I get: (shell-command-to-string (concat hfy-etags-bin " --version")) ;=> "etags (GNU Emacs 23.1.90) ; | Copyright (C) 2009 Free Software Foundation, Inc. ; | This program is distributed under the terms in ETAGS.README" and `hfy-which-etags' conditional _does_ match this etags exectuable. `hfy-which-etags' conditional string-match evaluations should have a rule to match a ``standalone'' etags. The problem is that when `hfy-which-etags' returns false it causes `hfy-etags-cmd' to fail: (cdr (assoc (hfy-which-etags) hfy-etags-cmd-alist)) ;=> nil if we add a new rule to `hfy-which-etags' conditional: ((string-match "standalone" v) "emacs etags") then we get the appropriate shell script template: (cdr (assoc (hfy-which-etags) hfy-etags-cmd-alist)) ;=> for src in `find . -type f`; ; | do ; | ETAGS=%s; ; | { ... lots more ellided ... } This won't change htmlfontify's reliance on a POSIX friendly shell (nor should it). However, the user shouldn't be restricted from using this library _because_ she is using the executable distributed _with_ her local Emacs... Patch follows: ;;; ============================== *** lisp/htmlfontify.el 2010-03-10 20:20:34.000000000 -0500 --- buffer-content-3664ZIc 2010-04-03 14:28:32.493000000 -0400 *************** *** 391,397 **** (defun hfy-which-etags () "Return a string indicating which flavour of etags we are using." (let ((v (shell-command-to-string (concat hfy-etags-bin " --version")))) ! (cond ((string-match "exube" v) "exuberant ctags") ((string-match "GNU E" v) "emacs etags" )) )) (defcustom hfy-etags-cmd --- 391,398 ---- (defun hfy-which-etags () "Return a string indicating which flavour of etags we are using." (let ((v (shell-command-to-string (concat hfy-etags-bin " --version")))) ! (cond ((string-match "standalone" v) "exuberant ctags") ! ((string-match "exube" v) "exuberant ctags") ((string-match "GNU E" v) "emacs etags" )) )) (defcustom hfy-etags-cmd ;;; ============================== /s_P\ ------------=_1338486182-27836-1-- From unknown Sun Jun 22 22:44:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#5831: 23.1.94; htmlfontify's `hfy-which-etags' not finding etags "standalone" Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 May 2012 17:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5831 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: rgm@gnu.org, 5831@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 5831-submit@debbugs.gnu.org id=B5831.133848710529205 (code B ref 5831); Thu, 31 May 2012 17:59:01 +0000 Received: (at 5831) by debbugs.gnu.org; 31 May 2012 17:58:25 +0000 Received: from localhost ([127.0.0.1]:52166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sa9dg-0007b0-Mo for submit@debbugs.gnu.org; Thu, 31 May 2012 13:58:24 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:58968) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sa9df-0007ap-HC for 5831@debbugs.gnu.org; Thu, 31 May 2012 13:58:24 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0M4W00C00F2MP500@a-mtaout20.012.net.il> for 5831@debbugs.gnu.org; Thu, 31 May 2012 20:56:41 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.210.75]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M4W00BFAF6HX7D0@a-mtaout20.012.net.il>; Thu, 31 May 2012 20:56:41 +0300 (IDT) Date: Thu, 31 May 2012 20:56:53 +0300 From: Eli Zaretskii In-reply-to: <99d35kp7tv.fsf@fencepost.gnu.org> X-012-Sender: halo1@inter.net.il Message-id: <83ehq01bfe.fsf@gnu.org> References: <99d35kp7tv.fsf@fencepost.gnu.org> X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > From: Glenn Morris > Date: Thu, 31 May 2012 13:40:44 -0400 > > Version: 23.3 > > I guess this will have been fixed by this change: > > 2011-02-02 Eli Zaretskii > > * makefile.w32-in (ETAGS_CFLAGS, CTAGS_CFLAGS): Add > ``-DVERSION="\"$(VERSION)\"" -DEMACS_NAME="\"GNU Emacs\""''. Yes.