From unknown Thu Aug 14 18:39:52 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#58292 <58292@debbugs.gnu.org> To: bug#58292 <58292@debbugs.gnu.org> Subject: Status: [Patch] [GNU ELPA] rcirc-color: Fix bad minor mode definition Reply-To: bug#58292 <58292@debbugs.gnu.org> Date: Fri, 15 Aug 2025 01:39:52 +0000 retitle 58292 [Patch] [GNU ELPA] rcirc-color: Fix bad minor mode definition reassign 58292 emacs submitter 58292 Thuna severity 58292 normal tag 58292 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 04 13:38:52 2022 Received: (at submit) by debbugs.gnu.org; 4 Oct 2022 17:38:52 +0000 Received: from localhost ([127.0.0.1]:55116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oflsa-0004un-3N for submit@debbugs.gnu.org; Tue, 04 Oct 2022 13:38:52 -0400 Received: from lists.gnu.org ([209.51.188.17]:47656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oflsX-0004ue-E1 for submit@debbugs.gnu.org; Tue, 04 Oct 2022 13:38:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oflsX-00089v-97 for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2022 13:38:49 -0400 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:44959) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oflsV-0001Q5-0Z for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2022 13:38:48 -0400 Received: by mail-ed1-x536.google.com with SMTP id g27so2955080edf.11 for ; Tue, 04 Oct 2022 10:38:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=WZrH8YYdr1AUKMgyyDTV5n8sul05llRsYYkU46Bc3AA=; b=odKpuYXPFHrEhTqwsypeUjtImexGyxKmiwUj7m0xLCxqdp6fTRMdem0YeAxR+0V+6f E8cIj11EED+jE4H6Mgpqz+YkycETjek5fzfpBKWuxlWiv67VT1/bBR1mEEarYeDhTlH7 5IekBZhkyHwvlQZeHj+UfuWSUv42yLpfW8d7rrv+D306UFcstaxqwyHdA6+qpJtHPf6B lFW1UTFmwZgYHoa3GBEiIvKTFYnPT3Q36ALkQPosOKOUXRWazqv1onOUGwudm0YbTMZL 2/On0GZ5qNgs4NJCsy8D7K587KA5SxUgk1Medf6KaLPYQ4hXiOJcH0fcsGHSGvmpo03H ozlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=WZrH8YYdr1AUKMgyyDTV5n8sul05llRsYYkU46Bc3AA=; b=EnUzJAF69APxXU08HjxqZq6MOIq5qW4iv43ff72Kwq7oTZICf1kSfsVVuPxNAHgNuh O/+9aw0sEf75Iqc7C/LxMfz/7pEFibgbwYyKbm2WhNVnzdIpK8lSbVphRrgd1mOyPT8/ rTKdeOqCLLr13aKFjDJsxvFsZ3nqQ8X7LmUm7hFw3PE7Q4eIsfIpiX97rGdypsrliKeb so22O14+AQKtzymEi/yTXZPl3b9RyFJ+N+L8/DBnuSvu1HJ0Lhat49XueJ+EzN93gRJ4 IAfGWB9sx50trEJI87WvBTPsv8K6RGWGkm+I/PwdseXLSUfA2MIru50dgtSXP52YV3Xe 14kA== X-Gm-Message-State: ACrzQf2u/XttILij7HVzyoVg85ZbeFQmGX9YzPuiF0Vv7CRdlzwZBBoM a2/TzfBeBD1z9qVWtJHymKqrTIiEOZ0= X-Google-Smtp-Source: AMsMyM6+q2ppSDiX+US8KN3LXw4nuSG+R4EHtdqAImYJP9WYLsNWDbZ5f1gqRpJZ+QpYMTBNJ18+8A== X-Received: by 2002:a05:6402:540d:b0:450:bda7:f76e with SMTP id ev13-20020a056402540d00b00450bda7f76emr24668952edb.249.1664905124473; Tue, 04 Oct 2022 10:38:44 -0700 (PDT) Received: from thuna ([90.147.71.176]) by smtp.gmail.com with ESMTPSA id r9-20020aa7cb89000000b0045920b019a9sm2062067edt.95.2022.10.04.10.38.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 10:38:43 -0700 (PDT) From: Thuna To: bug-gnu-emacs@gnu.org Subject: [Patch] [GNU ELPA] rcirc-color: Fix bad minor mode definition Date: Tue, 04 Oct 2022 19:38:39 +0200 Message-ID: <87edvnpjz4.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=thuna.cing@gmail.com; helo=mail-ed1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Currently, `define-minor-mode' signals an error upon evaluation. Looking into it, it seems that is because there are not keyword arguments given to it, which causes a problem according the docstring of `define-minor-mode': > If you provide BODY, then you must provide at least one keyword > argument (e.g. =E2=80=98:lighter nil=E2=80=98). This patch should fix the issue. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-bad-minor-mode-definition.patch Content-Description: The patch >From 2c9ed7ccdf13396bec67bc4d411495dde64f1e98 Mon Sep 17 00:00:00 2001 From: Thuna Date: Tue, 4 Oct 2022 19:31:48 +0200 Subject: [PATCH] Fix bad minor mode definition * rcirc-color.el (rcirc-color-mode): Add a keyword argument to prevent BODY from being interpreted as the variable value. --- rcirc-color.el | 1 + 1 file changed, 1 insertion(+) diff --git a/rcirc-color.el b/rcirc-color.el index a197fb82a2..b7baa5c0c5 100644 --- a/rcirc-color.el +++ b/rcirc-color.el @@ -176,6 +176,7 @@ commands." ;;;###autoload (define-minor-mode rcirc-color-mode "Enable the highlighting of nicknames." + :lighter nil (cond (rcirc-color-mode (advice-add 'rcirc-facify :around #'rcirc-color--facify) -- 2.35.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 04 15:05:10 2022 Received: (at 58292) by debbugs.gnu.org; 4 Oct 2022 19:05:10 +0000 Received: from localhost ([127.0.0.1]:55216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofnE6-00077t-1X for submit@debbugs.gnu.org; Tue, 04 Oct 2022 15:05:10 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofnE2-00077E-QM for 58292@debbugs.gnu.org; Tue, 04 Oct 2022 15:05:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ob1H34GGbyk2dUNhZ+ItTR2AjC+HIXjfv2cNKihd3Hs=; b=RSjgCRKGKv3q/0naTtrj/sw8t9 KB+bk1uv25F7Fft8l2e5D/ummnzQ9QspaJKMrhCLWnY9f+XvXsz7NjOSj1V3hKqA6/CdS8DDW+nkY 1kiSViBTaL/ocbGg+cEkFRHS9o+mff59OnDYbuhoBxxQdYh+3+pGb4nSC9d90TUGI7RI=; Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ofnDs-0007SN-TG; Tue, 04 Oct 2022 21:04:59 +0200 From: Lars Ingebrigtsen To: Thuna Subject: Re: bug#58292: [Patch] [GNU ELPA] rcirc-color: Fix bad minor mode definition In-Reply-To: <87edvnpjz4.fsf@gmail.com> (Thuna's message of "Tue, 04 Oct 2022 19:38:39 +0200") References: <87edvnpjz4.fsf@gmail.com> X-Now-Playing: Jane Siberry's _The Speckless Sky_: "Vladimir * Vladimir" Date: Tue, 04 Oct 2022 21:04:55 +0200 Message-ID: <87r0zn5s14.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Thuna writes: > Currently, `define-minor-mode' signals an error upon evaluation. > Looking into it, it seems that is because there are not keyword > arguments given to it, which causes a problem according the docst [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58292 Cc: 58292@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thuna writes: > Currently, `define-minor-mode' signals an error upon evaluation. > Looking into it, it seems that is because there are not keyword > arguments given to it, which causes a problem according the docstring of > `define-minor-mode': >> If you provide BODY, then you must provide at least one keyword >> argument (e.g. =E2=80=98:lighter nil=E2=80=98). > > This patch should fix the issue. Looks like this was fixed earlier today by: commit c206181d57c235b0a5f788b974d98e9cf1f7c4ec Author: Philip Kaludercic AuthorDate: Mon Oct 3 15:15:18 2022 +0200 Commit: Philip Kaludercic CommitDate: Tue Oct 4 20:01:44 2022 +0200 * rcirc-color.el (rcirc-color-mode): Add :global t =20=20=20=20 Without at least one keyword argument, the body in interpreted as the an expression setting the initial value of the `rcirc-color-mode' via the legacy syntax from Emacs 21. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 04 15:05:13 2022 Received: (at control) by debbugs.gnu.org; 4 Oct 2022 19:05:14 +0000 Received: from localhost ([127.0.0.1]:55219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofnE9-000789-Fx for submit@debbugs.gnu.org; Tue, 04 Oct 2022 15:05:13 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofnE7-00077h-Ce for control@debbugs.gnu.org; Tue, 04 Oct 2022 15:05:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=k0dJUVNTxPYQ2S85gdlrCh2tjIq6EKXJ8U6oHziVYhQ=; b=ful1VPO6fL6MZnIKo/H5mID7Tm CcDfZ80FKklii3h2629YZDswfLZi3Si61j/p3NrN80RdzjcPpmiaTE0nETP3HpOO6E66blu5pj4o8 DcvgmJgEIiX1yZNwNZsmPsmab4dObChVy2CL692EPrndjFjqPAGwxp+SSoNh5e3qPpMw=; Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ofnDz-0007Sk-Hf for control@debbugs.gnu.org; Tue, 04 Oct 2022 21:05:05 +0200 Date: Tue, 04 Oct 2022 21:05:02 +0200 Message-Id: <87pmf75s0x.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #58292 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 58292 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 58292 29.1 quit From unknown Thu Aug 14 18:39:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 02 Nov 2022 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator