Subject: Re: bug#58292: [Patch] [GNU ELPA] rcirc-color: Fix bad minor mode definition

From: Lars Ingebrigtsen <[email-masked]>
Date: Tue, 04 Oct 2022 21:04:55 +0200

Thuna <[email-masked]> writes:

> Currently, `define-minor-mode' signals an error upon evaluation.
> Looking into it, it seems that is because there are not keyword
> arguments given to it, which causes a problem according the docstring of
> `define-minor-mode':
>> If you provide BODY, then you must provide at least one keyword
>> argument (e.g. ‘:lighter nil‘).
>
> This patch should fix the issue.

Looks like this was fixed earlier today by:

commit c206181d57c235b0a5f788b974d98e9cf1f7c4ec
Author:     Philip Kaludercic <[email-masked]>
AuthorDate: Mon Oct 3 15:15:18 2022 +0200
Commit:     Philip Kaludercic <[email-masked]>
CommitDate: Tue Oct 4 20:01:44 2022 +0200

    * rcirc-color.el (rcirc-color-mode): Add :global t
    
    Without at least one keyword argument, the body in interpreted as the
    an expression setting the initial value of the `rcirc-color-mode' via
    the legacy syntax from Emacs 21.