GNU bug report logs - #5829
23.1.94; variable `hfy-rgb-load-path' in lisp/hfy-cmap.el missing "etc/rgb.txt"

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5829 in the body.
You can then email your comments to 5829 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: MON KEY <monkey <at> sandpframing.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.1.94; variable `hfy-rgb-load-path' in lisp/hfy-cmap.el missing 
	"etc/rgb.txt"
Date: Sat, 3 Apr 2010 12:33:56 -0400

Variable `hfy-rgb-load-path' in lisp/hfy-cmap.el missing "etc/rgb.txt"
This may be needed on w32 systems.

`hfy-rgb-load-path' should also add etc/rgb.txt to its loadpath
e.g. with something such as:

(expand-file-name "etc"
  (file-name-directory (directory-file-name exec-directory)))

;;; ==============================

In GNU Emacs 23.1.94.1 (i386-mingw-nt5.1.2600)
 of 2010-03-23 on G41R2F1
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags
-Ic:/imagesupport/include'

In GNU Emacs 23.1.94.1 (i386-mingw-nt5.1.2600)
 of 2010-03-23 on G41R2F1
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags
-Ic:/imagesupport/include'

Message #8 received at 5829 <at> debbugs.gnu.org (full text, mbox):

From: Jason Rumney <jasonr <at> gnu.org>
To: MON KEY <monkey <at> sandpframing.com>
Cc: 5829 <at> debbugs.gnu.org
Subject: Re: bug#5829: 23.1.94;
	variable `hfy-rgb-load-path' in lisp/hfy-cmap.el missing "etc/rgb.txt"
Date: Sun, 04 Apr 2010 01:41:50 +0800

MON KEY <monkey <at> sandpframing.com> writes:

> Variable `hfy-rgb-load-path' in lisp/hfy-cmap.el missing "etc/rgb.txt"
> This may be needed on w32 systems.

Why does hfy-cmap need to use rbg.txt instead of color-name-rgb-alist?

Message #11 received at 5829 <at> debbugs.gnu.org (full text, mbox):

From: MON KEY <monkey <at> sandpframing.com>
To: Jason Rumney <jasonr <at> gnu.org>
Cc: 5829 <at> debbugs.gnu.org
Subject: Re: bug#5829: 23.1.94; variable `hfy-rgb-load-path' in 
	lisp/hfy-cmap.el missing "etc/rgb.txt"
Date: Sat, 3 Apr 2010 15:41:16 -0400

On Sat, Apr 3, 2010 at 1:41 PM, Jason Rumney <jasonr <at> gnu.org> wrote:
>
> Why does hfy-cmap need to use rbg.txt instead of color-name-rgb-alist?
>

Indeed. I don't disagree.
There is also that nice big list of rgb values in :FILE src/w32fns.c

Maybe a better question is to ask why:

(length color-name-rgb-alist)
 ;=>657

(length hfy-fallback-colour-map)
 ;=>752

(length w32-color-map)
 ;=> 783

(assoc-string "deepskyblue" color-name-rgb-alist)
 ;=> ("deepskyblue" 0 49087 65535)

(assoc-string "deep sky blue" color-name-rgb-alist)
 ;=> nil

(assoc-string "deepskyblue" hfy-fallback-colour-map)
 ;=> nil

(assoc-string "deep sky blue" hfy-fallback-colour-map)
 ;=> ("deep sky blue" 0 49087 65535)

(assoc-string "deepskyblue" w32-color-map)
 ;=>nil

(assoc-string "deep sky blue" w32-color-map)
;=> ("deep sky blue" . 16760576)

(xw-color-values "deep sky blue")
;=> (0 49087 65535)

(xw-color-values "deep sky blue")
;=> (0 49087 65535)


FWIW I have no opinion whatsoever as to whether this is good or bad w/re to
hfy-cmap/htmlfontify.el/W32 compatibility.

I do however find it frustrating that there are so may _different_ disparate
`color specs' (re)provided throughout various Emacs packages (as distributed and
otherwise) -- i don't believe this is necessarily a W32 specific problem.
I'm sure we're all guilty of duplicating pre-existing code already provided, but
this one just seems to continually resurface. Come to think of it hasn't color
spec code duplication been discussed recently on emacs-devel?

/s_P\

Message #16 received at 5829-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 5829-done <at> debbugs.gnu.org
Subject: Re: bug#5829: 23.1.94;
	variable `hfy-rgb-load-path' in lisp/hfy-cmap.el missing "etc/rgb.txt"
Date: Sat, 09 Jul 2011 20:38:05 -0400

Never answered, AFAICS.

Jason Rumney wrote:

> Why does hfy-cmap need to use rbg.txt instead of color-name-rgb-alist?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.