GNU bug report logs - #58272
27.1; incorrect args to fileloop-initialize in tags--compat-initialize

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58272 in the body.
You can then email your comments to 58272 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Peter Hull <peterhull90 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.1; incorrect args to fileloop-initialize in tags--compat-initialize
Date: Mon, 3 Oct 2022 13:21:00 +0100

[Message part 1 (text/plain, inline)]

I think the function tags--compat-initialize in etags.el is calling
fileloop-initialize in fileloop.el with the second and thirds arguments
swapped.

[etags.el, line 1786]
(defun tags--compat-initialize (initialize)
  (fileloop-initialize
   (tags--compat-files initialize)
   (if tags-loop-operate
       (lambda () (tags-loop-eval tags-loop-operate))
     (lambda () (message "Scanning file %s...found" buffer-file-name) nil))
   (lambda () (tags-loop-eval tags-loop-scan))))

whereas:

[fileloop.el, line 62]
(defun fileloop-initialize (files scan-function operate-function) ... )

These files are dated 2020 and 2022 respectively and I believe they are the
latest (full version info below)

Simply modifying tags--compat-initialize by swapping the second and third
args in the call to fileloop-initialize would fix this I think.

I found this because po-tags-search in po-mode.el doesn't work properly for
me, and it requires etags for its operation.

Thanks,
Peter

---

In GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24,
cairo version 1.16.0)
 of 2021-03-27, modified by Debian built on x86-conova-01
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux 11 (bullseye)

Recent messages:
Saving file /home/peter/Projects/po-mode/po-mode-0.21/po-mode.el...
Wrote /home/peter/Projects/po-mode/po-mode-0.21/po-mode.el
Mark saved where search started [2 times]
Mark set
Saving file /home/peter/Projects/po-mode/po-mode-0.21/po-mode.el...
Wrote /home/peter/Projects/po-mode/po-mode-0.21/po-mode.el
Mark saved where search started
Mark set
Beginning of buffer
Making completion list...

Configured using:
 'configure --build x86_64-linux-gnu --prefix=/usr
 --sharedstatedir=/var/lib --libexecdir=/usr/lib
 --localstatedir=/var/lib --infodir=/usr/share/info
 --mandir=/usr/share/man --enable-libsystemd --with-pop=yes
 --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/27.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/27.1/site-lisp:/usr/share/emacs/site-lisp
 --with-sound=alsa --without-gconf --with-mailutils --build
 x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib
 --libexecdir=/usr/lib --localstatedir=/var/lib
 --infodir=/usr/share/info --mandir=/usr/share/man --enable-libsystemd
 --with-pop=yes
 --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/27.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/27.1/site-lisp:/usr/share/emacs/site-lisp
 --with-sound=alsa --without-gconf --with-mailutils --with-cairo
 --with-x=yes --with-x-toolkit=gtk3 --with-toolkit-scroll-bars
 'CFLAGS=-g -O2
 -ffile-prefix-map=/build/emacs-LlFm6W/emacs-27.1+1=.
-fstack-protector-strong
 -Wformat -Werror=format-security -Wall' 'CPPFLAGS=-Wdate-time
 -D_FORTIFY_SOURCE=2' LDFLAGS=-Wl,-z,relro'

Configured features:
XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY
INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF
ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD
JSON PDUMPER LCMS2 GMP

Important settings:
  value of $LANG: en_GB.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Emacs-Lisp

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
/usr/share/emacs/site-lisp/elpa/po-mode-0.21/po-mode-pkg hides
/usr/share/emacs/site-lisp/elpa-src/po-mode-0.21/po-mode-pkg
/usr/share/emacs/site-lisp/elpa/po-mode-0.21/po-mode hides
/usr/share/emacs/site-lisp/elpa-src/po-mode-0.21/po-mode
/usr/share/emacs/site-lisp/elpa/po-mode-0.21/po-mode-autoloads hides
/usr/share/emacs/site-lisp/elpa-src/po-mode-0.21/po-mode-autoloads
/home/peter/.emacs.d/elpa/seq-2.23/seq hides
/usr/share/emacs/27.1/lisp/emacs-lisp/seq

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
format-spec rfc822 mml mml-sec epa epg epg-config gnus-util rmail
rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils bookmark text-property-search pp po-mode
compile comint ansi-color etags pcase derived fileloop generator
misearch multi-isearch pulse jka-compr thingatpt xref project ring
eieio-opt cl-extra speedbar sb-image ezimage dframe find-func help-fns
radix-tree help-mode paredit edmacro kmacro time-date finder-inf rx info
package easymenu browse-url url-handlers url-parse auth-source cl-seq
eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map
url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
timer select scroll-bar mouse jit-lock font-lock syntax facemenu
font-core term/tty-colors frame minibuffer cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote threads dbusbind
inotify lcms2 dynamic-setting system-font-setting font-render-setting
cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 146016 17995)
 (symbols 48 11549 1)
 (strings 32 36340 3464)
 (string-bytes 1 1161312)
 (vectors 16 25254)
 (vector-slots 8 990642 131250)
 (floats 8 50 154)
 (intervals 56 10340 302)
 (buffers 1000 19))

[Message part 2 (text/html, inline)]

Message #8 received at 58272 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Peter Hull <peterhull90 <at> gmail.com>
Cc: 58272 <at> debbugs.gnu.org
Subject: Re: bug#58272: 27.1; incorrect args to fileloop-initialize in
 tags--compat-initialize
Date: Tue, 04 Oct 2022 14:31:55 +0200

Peter Hull <peterhull90 <at> gmail.com> writes:

> I think the function tags--compat-initialize in etags.el is calling fileloop-initialize in
> fileloop.el with the second and thirds arguments swapped.

Yes, looks like it.  I've now fixed this in Emacs 29.

Message #13 received at 58272 <at> debbugs.gnu.org (full text, mbox):

From: Peter Hull <peterhull90 <at> gmail.com>
To: 58272 <at> debbugs.gnu.org
Subject: Thanks
Date: Tue, 4 Oct 2022 15:39:09 +0100

Thank you for the rapid response, that's wonderful. I'm prepared for a
wait until Emacs 29 shows up on Debian though!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.