From unknown Sun Jun 22 04:23:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58270: 29.0.50; vc-tor/TRAMP issue Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Oct 2022 12:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58270 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 58270@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16648002568513 (code B ref -1); Mon, 03 Oct 2022 12:31:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Oct 2022 12:30:56 +0000 Received: from localhost ([127.0.0.1]:49267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofKb1-0002DF-Ts for submit@debbugs.gnu.org; Mon, 03 Oct 2022 08:30:56 -0400 Received: from lists.gnu.org ([209.51.188.17]:47572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofKaz-0002D1-MJ for submit@debbugs.gnu.org; Mon, 03 Oct 2022 08:30:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofKZv-0005wd-5Q for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2022 08:29:54 -0400 Received: from mout01.posteo.de ([185.67.36.65]:43649) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofKZk-0005eE-7S for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2022 08:29:45 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id E3DB424002E for ; Mon, 3 Oct 2022 14:29:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1664800162; bh=nXny6rcMOgcv+Ug946SdhzsNeQiTQrXMsSVePr0fqyc=; h=From:To:Subject:Autocrypt:Date:From; b=rG3WPuUi0gFIwHhV+BILXJw/mhjsf+dt60MSqWwz4XEw9alEaBLSuHBziZMd0hDNr z7WIdYJ6cSBJ7m04n8YSRCaJIWQh3xw3Z6EdOg7d8mihLOpndzmVyvTGON04ZSHHOy THuF97f64uB1Cw0YvqWGtPggauSsn6LzNPctDvmsNlAlpcC8sijmIEOvK7wleccjhr G2p3m0w3w5Wrhr54tB6Dj2Go34c66iWEC6IcF6M0zVcbMaq0Dn5W/gFgTftx0Wkew8 nck16Clg8kdFdBYGQlgZ2fW7EEGNU0Bog7ARovurAF+Igq64UsZOtNTQcmCaU3YHru owCVv08ao9/Fw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Mh0Wk1rslz6tnc for ; Mon, 3 Oct 2022 14:29:19 +0200 (CEST) From: Philip Kaludercic Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Mon, 03 Oct 2022 12:29:14 +0000 Message-ID: <87pmf9gkf9.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable If connecting to a remote server and accessing a file under version control, this error message appears if "torsocks" is not installed: env: =E2=80=98torsocks=E2=80=99: No such file or directory I guess this patch would fix the issue: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/vc/vc-dispatcher.el b/lisp/vc/vc-dispatcher.el index dc3ed52650..4348e42722 100644 --- a/lisp/vc/vc-dispatcher.el +++ b/lisp/vc/vc-dispatcher.el @@ -346,7 +346,7 @@ vc-do-command (vc-setup-buffer buffer)) (cl-destructuring-bind (command file-or-list flags) (funcall vc-filter-command-function command file-or-list flags) - (when vc-tor + (when (and vc-tor (executable-find "torsocks")) (push command flags) (setq command "torsocks")) (let* (;; FIXME: file-relative-name can return a bogus result --=-=-= Content-Type: text/plain but then a user could be deceived into thinking that VC is using tor even if it actually isn't the case. Perhaps adding a warning would be enough? Or could vc-tor be given an option to only activate if possible? I also have the interesting case that I was accessing a file version controlled under RCS, so no network communication was going to be necessary in the first place. In GNU Emacs 29.0.50 (build 8, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.17.6) of 2022-09-30 built on rhea Repository revision: 7c455f41186f1acbd8c68fec39fc4d3f5fa7bc60 Repository branch: local System Description: Fedora Linux 36 (Workstation Edition) Configured using: 'configure --with-pgtk --with-imagemagick' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ IMAGEMAGICK JPEG JSON LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS XIM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: ELisp/l Minor modes in effect: outline-minor-mode: t flymake-mode: t yas-minor-mode: t flyspell-mode: t repeat-mode: t display-battery-mode: t display-time-mode: t diff-hl-flydiff-mode: t diff-hl-mode: t winner-mode: t windmove-mode: t corfu-history-mode: t corfu-mode: t vertico-multiform-mode: t vertico-mode: t electric-pair-mode: t shell-dirtrack-mode: t recentf-mode: t save-place-mode: t savehist-mode: t pixel-scroll-precision-mode: t pixel-scroll-mode: t xterm-mouse-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t file-name-shadow-mode: t context-menu-mode: t global-font-lock-mode: t font-lock-mode: t size-indication-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/philip/.config/emacs/site-lisp/flymake-proselint/flymake-proselint hides /home/philip/.config/emacs/elpa/flymake-proselint-0.3.0/flymake-proselint /home/philip/.config/emacs/site-lisp/emacs-inspector/inspector hides /home/philip/.config/emacs/elpa/inspector-0.8/inspector /home/philip/.config/emacs/site-lisp/emacs-inspector/inspector-tests hides /home/philip/.config/emacs/elpa/inspector-0.8/inspector-tests /home/philip/.config/emacs/site-lisp/rcirc-color/rcirc-color hides /home/philip/.config/emacs/elpa/rcirc-color-0.4.3/rcirc-color /home/philip/.config/emacs/elpa/transient-0.3.7/transient hides /home/philip/Source/emacs/lisp/transient Features: (shadow sort autocrypt-message autocrypt ecomplete mail-extr gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range gnus-win emacsbug message rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader find-func orderless vertico-directory vertico-flat vc-filewise grep char-fold misearch multi-isearch vc-fossil vc-src vc-sccs vc-svn vc-cvs vc-rcs vc-hg vc-bzr copyright vc-backup vc-git flymake-proselint yank-media mhtml-mode css-mode smie eww xdg url-queue shr pixel-fill kinsoku url-file svg puny mm-url color js imenu cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs sgml-mode facemenu dom dired-aux gnus-dired buffer-env compat noutline outline so-long derived checkdoc flymake-proc flymake warnings yasnippet-snippets cl-extra yasnippet flyspell ispell auth-source-pass repeat project battery dbus xml shell-command+ thingatpt dired-x time sendmail rfc2047 rfc2045 ietf-drums gnus nnheader gnus-util mail-utils range mm-util mail-prsvr finder-inf diff-hl-flydiff diff diff-hl log-view pcvs-util vc-dir ewoc vc dired dired-loaddefs vc-dispatcher diff-mode easy-mmode hippie-exp winner windmove corfu-history corfu vertico-multiform vertico elec-pair tramp-cache time-stamp tramp-sh tramp tramp-loaddefs trampver tramp-integration cus-edit pp icons files-x tramp-compat rx shell pcomplete parse-time iso8601 time-date ls-lisp format-spec recentf tree-widget wid-edit saveplace savehist pixel-scroll cua-base xt-mouse modus-operandi-theme modus-themes cus-load setup site-lisp auto-site compile text-property-search comint osc ansi-color autoload loaddefs-gen lisp-mnt auctex-autoloads tex-site buffer-env-autoloads consult-autoloads compat-autoloads corfu-autoloads crdt-autoloads debbugs-autoloads diff-hl-autoloads ef-themes-autoloads embark-autoloads flylisp-autoloads flymake-proselint-autoloads focus-autoloads geiser-chibi-autoloads geiser-guile-autoloads geiser-impl help-fns radix-tree help-mode geiser-custom geiser-base ring geiser-autoloads inspector-autoloads keycast-autoloads magit-autoloads rcirc-color-autoloads slime-autoloads transient-autoloads vc-fossil-autoloads vertico-autoloads which-key-autoloads info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core password-cache json subr-x cl-macs pcase map byte-opt gv bytecomp byte-compile cconv url-vars cl-loaddefs cl-lib rmc iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win term/common-win pgtk-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk pgtk multi-tty make-network-process emacs) Memory information: ((conses 16 386377 117773) (symbols 48 29817 1) (strings 32 107857 4487) (string-bytes 1 3461241) (vectors 16 55033) (vector-slots 8 1438249 137301) (floats 8 436 881) (intervals 56 2283 0) (buffers 1000 27)) --=-=-=-- From unknown Sun Jun 22 04:23:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58270: 29.0.50; vc-tor/TRAMP issue Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Oct 2022 17:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58270 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Philip Kaludercic Cc: 58270@debbugs.gnu.org Received: via spool by 58270-submit@debbugs.gnu.org id=B58270.166481689114789 (code B ref 58270); Mon, 03 Oct 2022 17:09:02 +0000 Received: (at 58270) by debbugs.gnu.org; 3 Oct 2022 17:08:11 +0000 Received: from localhost ([127.0.0.1]:51641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofOvI-0003qO-8f for submit@debbugs.gnu.org; Mon, 03 Oct 2022 13:08:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofOvD-0003pm-GU for 58270@debbugs.gnu.org; Mon, 03 Oct 2022 13:08:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34052) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofOv8-00076H-7Y; Mon, 03 Oct 2022 13:07:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LPr5G8WCkcsLMQZywFmK89NQDs1zh5G+ExNUvqCsY1E=; b=kJ7Nw4FJgamY RCryKY4LxeAxpKeQqXjpZ66g/sjoMkPS33KKdJfgMPnuS34QaNmgWGG5wX+3zGeEjSjfUDZUgE9gh nIeTGBgUMmgRHVeCzc0NgHL1ieM7mPtBtdTssJd4tMj7dB6X+vPWvqLFgCO4ONZbsyY+QwCyOYf5e XUF4Lba95ovOvCEUa6eIxbIqF7EiOhtzZI+2zod8pEFt8uATo8vyTwxyvTgJkfxBLrT2kjlf4I4f4 YqdhkhDfNaUjwpE7Tf9PgpAAW38eHdi+kJ4cOPB2vzTLSrNQHwl3/i7xg4YO7mA24OKGAqjVogWF5 HZa+K4vcykszBJQfZ891ZA==; Received: from [87.69.77.57] (port=3638 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofOv7-0002aF-L9; Mon, 03 Oct 2022 13:07:57 -0400 Date: Mon, 03 Oct 2022 20:07:52 +0300 Message-Id: <83tu4kygwn.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87pmf9gkf9.fsf@posteo.net> (message from Philip Kaludercic on Mon, 03 Oct 2022 12:29:14 +0000) References: <87pmf9gkf9.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Date: Mon, 03 Oct 2022 12:29:14 +0000 > > I also have the interesting case that I was accessing a file version > controlled under RCS, so no network communication was going to be > necessary in the first place. That's a separate problem, I think: we shouldn't use torsocks for VCSes that are always local, like RCS and SRC. From unknown Sun Jun 22 04:23:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58270: 29.0.50; vc-tor/TRAMP issue Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Oct 2022 17:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58270 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Philip Kaludercic Cc: 58270@debbugs.gnu.org Received: via spool by 58270-submit@debbugs.gnu.org id=B58270.166481718715251 (code B ref 58270); Mon, 03 Oct 2022 17:14:02 +0000 Received: (at 58270) by debbugs.gnu.org; 3 Oct 2022 17:13:07 +0000 Received: from localhost ([127.0.0.1]:51645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofP07-0003xv-8F for submit@debbugs.gnu.org; Mon, 03 Oct 2022 13:13:07 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofP05-0003xQ-MN for 58270@debbugs.gnu.org; Mon, 03 Oct 2022 13:13:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xVx8L9rUyMtXe1OjopI8IFGyWo9Ct2qc69BWh1wdvzg=; b=QQt4XbbWjP84KStCDzD/WZREnz YqupQhIlRwTJOBMGDp7DU4V9IMcD81Vkfluppzc86OB8dpRs7JFe/KgGE1mlzIYZSQlqG2prLp0IE J3DAWr0MAeIX2usaiR/lueE97MSkQTBUJAKBTOCo+iwqFIlJPrAnbJ5Mx15Hfv/WvmQw=; Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ofOzw-00031V-Co; Mon, 03 Oct 2022 19:12:58 +0200 From: Lars Ingebrigtsen In-Reply-To: <87pmf9gkf9.fsf@posteo.net> (Philip Kaludercic's message of "Mon, 03 Oct 2022 12:29:14 +0000") References: <87pmf9gkf9.fsf@posteo.net> X-Now-Playing: Tuxedomoon's _Holy Wars_: "Hugging the Earth" Date: Mon, 03 Oct 2022 19:12:54 +0200 Message-ID: <87r0zo6dbd.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philip Kaludercic writes: > but then a user could be deceived into thinking that VC is using tor > even if it actually isn't the case. Perhaps adding a warning would be > enough? Or could vc-tor be given an option to only acti [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Philip Kaludercic writes: > but then a user could be deceived into thinking that VC is using tor > even if it actually isn't the case. Perhaps adding a warning would be > enough? Or could vc-tor be given an option to only activate if > possible? I think signalling an error here would be appropriate. Eli Zaretskii writes: >> I also have the interesting case that I was accessing a file version >> controlled under RCS, so no network communication was going to be >> necessary in the first place. > > That's a separate problem, I think: we shouldn't use torsocks for > VCSes that are always local, like RCS and SRC. Indeed. So I think this entire torsocks thing is on the wrong level altogether -- it should be pushed down into the backends instead of being in vc-dispatcher.el.