From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 03 10:22:00 2010 Received: (at submit) by debbugs.gnu.org; 3 Apr 2010 14:22:00 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ny4EZ-0000z2-HM for submit@debbugs.gnu.org; Sat, 03 Apr 2010 10:22:00 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ny3mF-0000nv-Vy for submit@debbugs.gnu.org; Sat, 03 Apr 2010 09:52:44 -0400 Received: from lists.gnu.org ([199.232.76.165]:45115) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ny3mA-0003bo-Ru for submit@debbugs.gnu.org; Sat, 03 Apr 2010 09:52:38 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ny3mA-0000pA-DJ for bug-coreutils@gnu.org; Sat, 03 Apr 2010 09:52:38 -0400 Received: from [140.186.70.92] (port=45152 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ny3m9-0000nP-6J for bug-coreutils@gnu.org; Sat, 03 Apr 2010 09:52:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.0 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ny3m7-0001q5-LK for bug-coreutils@gnu.org; Sat, 03 Apr 2010 09:52:37 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:43188) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ny3m7-0001po-Fl for bug-coreutils@gnu.org; Sat, 03 Apr 2010 09:52:35 -0400 Received: from themisto.ext.pengutronix.de ([92.198.50.58] helo=localhost.localdomain) by metis.ext.pengutronix.de with esmtp (Exim 4.71) (envelope-from ) id 1Ny3ly-0006Bb-0B; Sat, 03 Apr 2010 15:52:27 +0200 From: Marc Kleine-Budde To: bug-coreutils@gnu.org Date: Sat, 3 Apr 2010 15:52:18 +0200 Message-Id: <1270302738-18780-1-git-send-email-mkl@pengutronix.de> X-Mailer: git-send-email 1.7.0.3 X-SA-Exim-Connect-IP: 92.198.50.58 X-SA-Exim-Mail-From: mkl@pengutronix.de Subject: [PATCH] tail: include sys/vfs.h X-SA-Exim-Version: 4.2.1 (built Sat, 01 Aug 2009 12:09:26 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) X-PTX-Original-Recipient: bug-coreutils@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 03 Apr 2010 10:21:58 -0400 Cc: Marc Kleine-Budde X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.3 (-----) Hello, the latest coreutils release 8.4 and current git master fail during the (cross-) compilation of tail. The used components are: gcc-4.3.2 glibc-2.8 binutils-2.18 The following patch fixes the commit. It's against git master, but should apply on 8.4, too. Please review and consider inclusion. Cheers, Marc >From ebf1ab5bcba6f6b82bb8f0a62c949858e2a9d5cc Mon Sep 17 00:00:00 2001 From: Marc Kleine-Budde Date: Sat, 3 Apr 2010 14:42:29 +0200 Subject: [PATCH] tail: include sys/vfs.h This patch fixes the following error: tail.c: In function 'fremote': tail.c:882: error: storage size of 'buf' isn't known tail.c:883: warning: implicit declaration of function 'fstatfs' Signed-off-by: Marc Kleine-Budde --- src/tail.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/tail.c b/src/tail.c index 02c4a1a..d0bc957 100644 --- a/src/tail.c +++ b/src/tail.c @@ -57,6 +57,9 @@ # if HAVE_SYS_STATFS_H # include # endif +# if HAVE_SYS_VFS_H +# include +# endif #endif /* The official name of this program (e.g., no `g' prefix). */ -- 1.7.0.3 From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 04 03:16:23 2010 Received: (at 5827) by debbugs.gnu.org; 4 Apr 2010 07:16:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NyK4F-0004AQ-4S for submit@debbugs.gnu.org; Sun, 04 Apr 2010 03:16:23 -0400 Received: from smtp3-g21.free.fr ([212.27.42.3]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NyK4C-0004AL-Nv for 5827@debbugs.gnu.org; Sun, 04 Apr 2010 03:16:22 -0400 Received: from smtp3-g21.free.fr (localhost [127.0.0.1]) by smtp3-g21.free.fr (Postfix) with ESMTP id 62AD1818036 for <5827@debbugs.gnu.org>; Sun, 4 Apr 2010 09:16:13 +0200 (CEST) Received: from mx.meyering.net (mx.meyering.net [82.230.74.64]) by smtp3-g21.free.fr (Postfix) with ESMTP id 82E13818089 for <5827@debbugs.gnu.org>; Sun, 4 Apr 2010 09:16:11 +0200 (CEST) Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id E4023EC38; Sun, 4 Apr 2010 09:16:10 +0200 (CEST) From: Jim Meyering To: Marc Kleine-Budde Subject: Re: bug#5827: [PATCH] tail: include sys/vfs.h In-Reply-To: <1270302738-18780-1-git-send-email-mkl@pengutronix.de> (Marc Kleine-Budde's message of "Sat, 3 Apr 2010 15:52:18 +0200") References: <1270302738-18780-1-git-send-email-mkl@pengutronix.de> Date: Sun, 04 Apr 2010 09:16:10 +0200 Message-ID: <87ochz3cxx.fsf@meyering.net> Lines: 48 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 5827 Cc: 5827@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) Marc Kleine-Budde wrote: > the latest coreutils release 8.4 and current git master fail during the > (cross-) compilation of tail. The used components are: > > gcc-4.3.2 > glibc-2.8 > binutils-2.18 > > The following patch fixes the commit. It's against git master, but should > apply on 8.4, too. ... > # if HAVE_SYS_STATFS_H > # include > # endif > +# if HAVE_SYS_VFS_H > +# include > +# endif > #endif I'd like to take a slightly more conservative approach, including sys/vfs.h only when sys/statfs.h is not available. Does this work for you? >From 98dacf492e2e6f2153455cb4179058578cee20ff Mon Sep 17 00:00:00 2001 From: Marc Kleine-Budde Date: Sun, 4 Apr 2010 09:15:07 +0200 Subject: [PATCH] tail: include sys/vfs.h (if possible) when sys/statfs.h is absent * src/tail.c [HAVE_INOTIFY && !HAVE_SYS_STATFS_H]: Include . --- src/tail.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/tail.c b/src/tail.c index 02c4a1a..9e95dee 100644 --- a/src/tail.c +++ b/src/tail.c @@ -56,6 +56,8 @@ # include "fs.h" # if HAVE_SYS_STATFS_H # include +# elif HAVE_SYS_VFS_H +# include # endif #endif -- 1.7.0.4.529.g78fb From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 04 10:30:23 2010 Received: (at 5827) by debbugs.gnu.org; 4 Apr 2010 14:30:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NyQqE-0007u3-Ka for submit@debbugs.gnu.org; Sun, 04 Apr 2010 10:30:23 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NyMSG-00051m-9j for 5827@debbugs.gnu.org; Sun, 04 Apr 2010 05:49:21 -0400 Received: from themisto.ext.pengutronix.de ([92.198.50.58] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.71) (envelope-from ) id 1NyMRs-0001o9-Vo; Sun, 04 Apr 2010 11:49:16 +0200 Message-ID: <4BB8607D.4000406@pengutronix.de> Date: Sun, 04 Apr 2010 11:48:45 +0200 From: Marc Kleine-Budde Organization: Pengutronix User-Agent: Thunderbird 2.0.0.24 (X11/20100317) MIME-Version: 1.0 To: Jim Meyering References: <1270302738-18780-1-git-send-email-mkl@pengutronix.de> <87ochz3cxx.fsf@meyering.net> In-Reply-To: <87ochz3cxx.fsf@meyering.net> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig0F9B1EFD1C98499F0916D626" X-SA-Exim-Connect-IP: 92.198.50.58 X-SA-Exim-Mail-From: mkl@pengutronix.de X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on metis.extern.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.2 required=4.5 tests=AWL,BAYES_00, T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham version=3.3.0 Subject: Re: bug#5827: [PATCH] tail: include sys/vfs.h X-SA-Exim-Version: 4.2.1 (built Sat, 01 Aug 2009 12:09:26 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) X-PTX-Original-Recipient: 5827@debbugs.gnu.org X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: 5827 X-Mailman-Approved-At: Sun, 04 Apr 2010 10:30:17 -0400 Cc: 5827@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0F9B1EFD1C98499F0916D626 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hey Jim, Jim Meyering wrote: > Marc Kleine-Budde wrote: >> the latest coreutils release 8.4 and current git master fail during th= e >> (cross-) compilation of tail. The used components are: >> >> gcc-4.3.2 >> glibc-2.8 >> binutils-2.18 >> >> The following patch fixes the commit. It's against git master, but sho= uld >> apply on 8.4, too. > ... >> # if HAVE_SYS_STATFS_H >> # include >> # endif >> +# if HAVE_SYS_VFS_H >> +# include >> +# endif >> #endif >=20 > I'd like to take a slightly more conservative approach, > including sys/vfs.h only when sys/statfs.h is not available. > Does this work for you? Thanks, works, even with older gcc/glibc combinations. >>>From 98dacf492e2e6f2153455cb4179058578cee20ff Mon Sep 17 00:00:00 2001 > From: Marc Kleine-Budde > Date: Sun, 4 Apr 2010 09:15:07 +0200 > Subject: [PATCH] tail: include sys/vfs.h (if possible) when sys/statfs.= h is absent >=20 > * src/tail.c [HAVE_INOTIFY && !HAVE_SYS_STATFS_H]: Include .= Tested-by: Marc Kleine-Budde > --- > src/tail.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) >=20 > diff --git a/src/tail.c b/src/tail.c > index 02c4a1a..9e95dee 100644 > --- a/src/tail.c > +++ b/src/tail.c > @@ -56,6 +56,8 @@ > # include "fs.h" > # if HAVE_SYS_STATFS_H > # include > +# elif HAVE_SYS_VFS_H > +# include > # endif > #endif >=20 > -- > 1.7.0.4.529.g78fb cheers, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --------------enig0F9B1EFD1C98499F0916D626 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAku4YIUACgkQjTAFq1RaXHNvSgCfRMdVVSbBynKwDIUNYi+lpBmV JfwAnjXYvDRPHjDjXQG6Xs//zSuZbQti =9zAr -----END PGP SIGNATURE----- --------------enig0F9B1EFD1C98499F0916D626-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 05 05:43:47 2010 Received: (at 5827-done) by debbugs.gnu.org; 5 Apr 2010 09:43:47 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NyiqR-0006Nd-AR for submit@debbugs.gnu.org; Mon, 05 Apr 2010 05:43:47 -0400 Received: from smtp3-g21.free.fr ([212.27.42.3]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NyiqO-0006NY-MH for 5827-done@debbugs.gnu.org; Mon, 05 Apr 2010 05:43:46 -0400 Received: from smtp3-g21.free.fr (localhost [127.0.0.1]) by smtp3-g21.free.fr (Postfix) with ESMTP id C9334818155 for <5827-done@debbugs.gnu.org>; Mon, 5 Apr 2010 11:43:38 +0200 (CEST) Received: from mx.meyering.net (mx.meyering.net [82.230.74.64]) by smtp3-g21.free.fr (Postfix) with ESMTP id EBA5281811B for <5827-done@debbugs.gnu.org>; Mon, 5 Apr 2010 11:43:35 +0200 (CEST) Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id C234EA1F; Mon, 5 Apr 2010 11:43:35 +0200 (CEST) From: Jim Meyering To: Marc Kleine-Budde Subject: Re: bug#5827: [PATCH] tail: include sys/vfs.h In-Reply-To: <4BB8607D.4000406@pengutronix.de> (Marc Kleine-Budde's message of "Sun, 04 Apr 2010 11:48:45 +0200") References: <1270302738-18780-1-git-send-email-mkl@pengutronix.de> <87ochz3cxx.fsf@meyering.net> <4BB8607D.4000406@pengutronix.de> Date: Mon, 05 Apr 2010 11:43:35 +0200 Message-ID: <87r5muw7y0.fsf@meyering.net> Lines: 10 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 5827-done Cc: 5827-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) Marc Kleine-Budde wrote: ... >> I'd like to take a slightly more conservative approach, >> including sys/vfs.h only when sys/statfs.h is not available. >> Does this work for you? > > Thanks, works, even with older gcc/glibc combinations. Thanks. Pushed, along with a gnulib update. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 05 08:06:22 2010 Received: (at 5827-done) by debbugs.gnu.org; 5 Apr 2010 12:06:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nyl4P-0007iO-Bm for submit@debbugs.gnu.org; Mon, 05 Apr 2010 08:06:22 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NyjGs-0006XY-AW for 5827-done@debbugs.gnu.org; Mon, 05 Apr 2010 06:11:07 -0400 Received: from themisto.ext.pengutronix.de ([92.198.50.58] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.71) (envelope-from ) id 1NyjGV-0000PD-9q; Mon, 05 Apr 2010 12:11:02 +0200 Message-ID: <4BB9B720.2010500@pengutronix.de> Date: Mon, 05 Apr 2010 12:10:40 +0200 From: Marc Kleine-Budde Organization: Pengutronix User-Agent: Thunderbird 2.0.0.24 (X11/20100317) MIME-Version: 1.0 To: Jim Meyering References: <1270302738-18780-1-git-send-email-mkl@pengutronix.de> <87ochz3cxx.fsf@meyering.net> <4BB8607D.4000406@pengutronix.de> <87r5muw7y0.fsf@meyering.net> In-Reply-To: <87r5muw7y0.fsf@meyering.net> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig7DA7691CB07FF3D651113545" X-SA-Exim-Connect-IP: 92.198.50.58 X-SA-Exim-Mail-From: mkl@pengutronix.de X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on metis.extern.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.2 required=4.5 tests=AWL,BAYES_00, T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham version=3.3.0 Subject: Re: bug#5827: [PATCH] tail: include sys/vfs.h X-SA-Exim-Version: 4.2.1 (built Sat, 01 Aug 2009 12:09:26 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) X-PTX-Original-Recipient: 5827-done@debbugs.gnu.org X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 5827-done X-Mailman-Approved-At: Mon, 05 Apr 2010 08:06:20 -0400 Cc: 5827-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.1 (---) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7DA7691CB07FF3D651113545 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Jim Meyering wrote: > Marc Kleine-Budde wrote: > ... >>> I'd like to take a slightly more conservative approach, >>> including sys/vfs.h only when sys/statfs.h is not available. >>> Does this work for you? >> Thanks, works, even with older gcc/glibc combinations. >=20 > Thanks. > Pushed, along with a gnulib update. \o/ I have to thank you for the quick bugfix. cheers, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --------------enig7DA7691CB07FF3D651113545 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAku5tyAACgkQjTAFq1RaXHNX7gCfdMw93p/775qbKrWFM90zYem6 R3oAnjasMb8Lwf92xT13VsjwZ+IBasw6 =PaMX -----END PGP SIGNATURE----- --------------enig7DA7691CB07FF3D651113545-- From unknown Mon Jun 23 18:28:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 04 May 2010 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator