GNU bug report logs - #58265
29.0.50; [PATCH] $HOME adjustment for 'ert-remote-temporary-file-directory' is wrong

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#58265: closed (29.0.50; [PATCH] $HOME adjustment for
 'ert-remote-temporary-file-directory' is wrong)
Date: Tue, 04 Oct 2022 00:45:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 3 Oct 2022 17:44:18 -0700
with message-id <e8d19c98-e379-ce2e-5995-043d999f6fdf <at> gmail.com>
and subject line Re: bug#58265: 29.0.50; [PATCH] $HOME adjustment for 'ert-remote-temporary-file-directory' is wrong
has caused the debbugs.gnu.org bug report #58265,
regarding 29.0.50; [PATCH] $HOME adjustment for 'ert-remote-temporary-file-directory' is wrong
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
58265: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58265
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; [PATCH] $HOME adjustment for
 'ert-remote-temporary-file-directory' is wrong
Date: Sun, 2 Oct 2022 18:32:32 -0700

[Message part 3 (text/plain, inline)]

I tried to use 'ert-remote-temporary-file-directory' in a test for an 
external package, but it ended up breaking some existing tests simply by 
requiring both tramp and ert-x. These tests indirectly used 'cd' (by way 
of 'compilation-start'), which triggered the failure.

Steps to reproduce:

  $ mkdir -p ~/src
  $ emacs -Q --batch -l tramp -l ert-x --eval '(cd "~/src/")'

Result:

  Error: error ("No such directory: ~/src/")
    mapbacktrace(#f(compiled-function (evald func args flags) 
#<bytecode 0xc43976fdbae86a5>))
    debug-early-backtrace()
    debug-early(error (error "No such directory: ~/src/"))
    error("No such directory: %s" "~/src/")
    cd("~/src")
    eval((cd "~/src") t)
    command-line-1(("-l" "tramp" "-l" "ert-x" "--eval" "(cd \"~/src/\")"))
    command-line()
    normal-top-level()
  No such directory: ~/src/

Looking at ert-x.el, I think this is because 
'ert-remote-temporary-file-directory' does some fixup on $HOME, but it 
was too aggressive. See attached.

[0001-Fix-logic-of-HOME-adjustment-for-ert-remote-temporar.patch (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 58265-done <at> debbugs.gnu.org
Subject: Re: bug#58265: 29.0.50; [PATCH] $HOME adjustment for
 'ert-remote-temporary-file-directory' is wrong
Date: Mon, 3 Oct 2022 17:44:18 -0700

On 10/3/2022 2:17 AM, Lars Ingebrigtsen wrote:
> Jim Porter <jporterbugs <at> gmail.com> writes:
> 
>> Looking at ert-x.el, I think this is because
>> 'ert-remote-temporary-file-directory' does some fixup on $HOME, but it
>> was too aggressive. See attached.
> 
> Looks good to me; please go ahead and push.

Thanks. Pushed as 43eaa05ff2265ae33f71b73670a8a150a7a716ae. Closing this 
bug now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.