From unknown Tue Aug 19 02:59:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58256: Possible mistake in recent `dired-do-flagged-delete' change Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: stephen.berman@gmx.net, bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Oct 2022 18:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58256 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 58256@debbugs.gnu.org Cc: Stephen Berman X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Stephen Berman Received: via spool by submit@debbugs.gnu.org id=B.166473614325323 (code B ref -1); Sun, 02 Oct 2022 18:43:01 +0000 Received: (at submit) by debbugs.gnu.org; 2 Oct 2022 18:42:23 +0000 Received: from localhost ([127.0.0.1]:48049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1of3ux-0006aN-4L for submit@debbugs.gnu.org; Sun, 02 Oct 2022 14:42:23 -0400 Received: from lists.gnu.org ([209.51.188.17]:52228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1of3uv-0006aE-Gk for submit@debbugs.gnu.org; Sun, 02 Oct 2022 14:42:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1of3uv-00048w-CF for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2022 14:42:21 -0400 Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]:37381) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1of3ut-00081z-Iz for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2022 14:42:20 -0400 Received: by mail-oi1-x233.google.com with SMTP id s125so9630156oie.4 for ; Sun, 02 Oct 2022 11:42:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date; bh=s5j02i7rPjRX6DcwMiqXvuldPE3ueoOn9pkc2NwHSrQ=; b=OICac6HfUP30dNcmZaQlRUFISf57bNGKaMemTIxgGwYIJ7UTqQ95MaoceEbTlZmiZv fXn1C+X8XbApieTT22/SCXcQ4ZSoeMcrzKQDcTa9iEEOzxDBttliarY5j+j7Neg64jh/ VKUKi3K/CGBgxbbZ/5vOiVNBZ6aTPrquJDs+elndvobAcn7Ocmlqbu5yuwnBURXmH+fJ vUDde4S9J3eKB13rWV5GCpi3gslDAF/yEPe/rEgb1aPITy8VScgVftWBw9/kDH9qQBKK WvRXWuwCQpEsccNiDWl3GAFfYF+vc9v4o0u5QmkYiYwkNxDKKpEkycK3mXuCsaqOWEuy M50g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date; bh=s5j02i7rPjRX6DcwMiqXvuldPE3ueoOn9pkc2NwHSrQ=; b=xBgs8tr0IDz5F+P+6d+H/58vf2AJoXrhty0th5yZYG4b25pjg5ppgZQ6wzSM/KBlHh f5Rg+tfMKSNn/ufRotzzpssKq3IyZV7XpvLdOU328KjVdvwFvrMEa17ExnvUnyq4u3SK gXy7hPKyQsOXNBSIA80PzEVZZXygZJtfpjjJP4ixJpjhAYZN1RcmPGSH6xJtIcfRIDz3 3S0eAxCCfO2kBJ5pKmazdzGxvAluOwBVwzMKt4LyiubHHqFIRkVR8AyBdB9Xeh9n9Rxy 8jkmRsHvbCmK/jm21iFDrYUW0UAK6XZG4ABqQ2Yf6mKfsLJkurkk/Ija5KYlOpZA6fju YpCA== X-Gm-Message-State: ACrzQf3aen+QUtCcMd9xVhVQH0Y2nqeE+WKSTx4qr+Hr5DK3f8OVWRbU +mimIK3c7Wby/y6aqPf/2iRdh62L9KxQdVE6mpQq2S29 X-Google-Smtp-Source: AMsMyM7ANEtJsT97V1o62nxcP2KKbdiM1rRMpj9i7nkP9LsuXXgYPMolsL3YzjJQs72QYZanakZIMkQ11Y6eQ1FTefc= X-Received: by 2002:a05:6808:1186:b0:353:b77a:a481 with SMTP id j6-20020a056808118600b00353b77aa481mr502963oil.199.1664736138124; Sun, 02 Oct 2022 11:42:18 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 2 Oct 2022 20:42:17 +0200 From: Stefan Kangas X-Hashcash: 1:20:221002:bug-gnu-emacs@gnu.org::zI0a9ZHAnBj7xVSY:3j/C MIME-Version: 1.0 Date: Sun, 2 Oct 2022 20:42:17 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::233; envelope-from=stefankangas@gmail.com; helo=mail-oi1-x233.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) It seems like there might be a mistake in the `dired-do-flagged-delete' of this commit: commit 194d54a929a83fede75d618b104acd1b544feb10 Author: Stephen Berman Date: Fri Jun 4 12:01:41 2021 +0200 Fix placement of point in Dired deletion operations It seems like there is a `dolist' that will always run on the empty list. Was perhaps the below the intended change? If so, I wonder how this code would have worked without that `dolist' so far, and if that line could just be removed instead? diff --git a/lisp/dired.el b/lisp/dired.el index b9e89292e2..358e815c88 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -3664,16 +3664,17 @@ dired-do-flagged-delete case-fold-search markers) (if (save-excursion (goto-char (point-min)) (re-search-forward regexp nil t)) - (dired-internal-do-deletions - (nreverse - ;; this can't move point since ARG is nil - (dired-map-over-marks (cons (dired-get-filename) - (let ((m (point-marker))) - (push m markers) - m)) - nil)) - nil t) - (dolist (m markers) (set-marker m nil)) + (progn + (dired-internal-do-deletions + (nreverse + ;; this can't move point since ARG is nil + (dired-map-over-marks (cons (dired-get-filename) + (let ((m (point-marker))) + (push m markers) + m)) + nil)) + nil t) + (dolist (m markers) (set-marker m nil))) (or nomessage (message "(No deletions requested)"))))) From unknown Tue Aug 19 02:59:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58256: Possible mistake in recent `dired-do-flagged-delete' change Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Oct 2022 19:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58256 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 58256@debbugs.gnu.org Cc: Stephen Berman Received: via spool by 58256-submit@debbugs.gnu.org id=B58256.16647382554736 (code B ref 58256); Sun, 02 Oct 2022 19:18:01 +0000 Received: (at 58256) by debbugs.gnu.org; 2 Oct 2022 19:17:35 +0000 Received: from localhost ([127.0.0.1]:48075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1of4T1-0001EK-AB for submit@debbugs.gnu.org; Sun, 02 Oct 2022 15:17:35 -0400 Received: from mail-oa1-f47.google.com ([209.85.160.47]:40912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1of4Sz-0001E5-II for 58256@debbugs.gnu.org; Sun, 02 Oct 2022 15:17:34 -0400 Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-131fd187e35so7206265fac.7 for <58256@debbugs.gnu.org>; Sun, 02 Oct 2022 12:17:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date; bh=L6vsT34gCg8XKaZM0Ep9fjISxWeD29sx8G/b1AmEC70=; b=fR/P5OeByC/85tMxtRBwb7vPZim+ZsHPn78LhaaOHi2WRScmwdC0o16SqSU9RA4GGv EV3QZ3EaLUUORBFFtf1BUhng7zB87H3Rwv/GHfBzTkLpyx61OrS3L5BvfmymKyFPSzdT Kbv1rOoiBrawzmi4ApYgHLA+L3SUg2jKd9aGz5IkmcGX9UKrE7+Ze2VIS+1PHnQaAOEa UtaH6jvntsJHEa2eJ2y6Ppf9Czn6kogsZZFGpOBPZJkW/nGDqWF9vGisj5FR7U3vSSDb AVFsEhHvw2JXVxHad08jFbNHRpv+rrEk5wl+QoLIdAnSdps4LOQk9J4lYYs4+C+Dx2v5 /IbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date; bh=L6vsT34gCg8XKaZM0Ep9fjISxWeD29sx8G/b1AmEC70=; b=FpI0tAjDQJBfwt9HHW082BzfE3fET+viVjAc1ZDXqhfGJi6VThBgzWlTDjQOs9Lifp ijwWgY1nH34rSh/Td5H/5egySPc4EX8fdTQvEeY1HLZdTdQ+Ot4l2ZIF7B+g5G1YmSLS oJyRdXt8R06UapMi71hTVnjgzqC6aHWoZUaXxEbZp7r3HehkTb+AETTECIMcbxcX//8e gzY45VyEY2mYyU3zHvcxwrvSPTqEqgZznGTq7ZogWyK4Inm87Vm/aZmwx3RAP4mmZP9f eteTzo3v1G/JTXEAEoH6AvkP32wmfFubla4LGLsUAVyaOogsYx+nTAWE1UPFe3u32+MO 1DoA== X-Gm-Message-State: ACrzQf2oa8H0NRu8a8WHIEX0qMa1NGeU/kc6gw1bQfBhWVKQ3isiapAA TrY2cupNUHAR0vjw02TkAG2mFjXNYgaD0edNwCc776rI X-Google-Smtp-Source: AMsMyM5IjTpkQVQwUmR65iLTA+Jzy/yOnfSel0OntYwPboBtE8wNe3Y2dQjhmDbdZTK4sN+S+J4Tcr/y5h8xaEA6dq0= X-Received: by 2002:a05:6870:d38e:b0:132:7895:e135 with SMTP id k14-20020a056870d38e00b001327895e135mr376350oag.199.1664738247986; Sun, 02 Oct 2022 12:17:27 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 2 Oct 2022 19:17:27 +0000 From: Stefan Kangas In-Reply-To: (Stefan Kangas's message of "Sun, 2 Oct 2022 20:42:17 +0200") References: X-Hashcash: 1:20:221002:stephen.berman@gmx.net::GbGbpEgNULTk2OJO:47FJ MIME-Version: 1.0 Date: Sun, 2 Oct 2022 19:17:27 +0000 Message-ID: Content-Type: multipart/mixed; boundary="000000000000ea860305ea121325" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000ea860305ea121325 Content-Type: text/plain; charset="UTF-8" Stefan Kangas writes: > If so, I wonder how this code would have worked without that `dolist' so > far, and if that line could just be removed instead? The command seems to be working correctly with the attached patch. Am I missing something here? --000000000000ea860305ea121325 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-lisp-dired.el-dired-do-flagged-delete-Simplify.patch" Content-Disposition: attachment; filename="0001-lisp-dired.el-dired-do-flagged-delete-Simplify.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: b1b8d96a0832ae36_0.1 RnJvbSA2NTAwYjI3MTY1OGE3YTcxZmY4ODU2YjJmNDIzZDg3NTU3MzA3YmJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDIgT2N0IDIwMjIgMjE6MDg6NDAgKzAyMDAKU3ViamVjdDogW1BBVENIXSAq IGxpc3AvZGlyZWQuZWwgKGRpcmVkLWRvLWZsYWdnZWQtZGVsZXRlKTogU2ltcGxpZnkuCgotLS0K IGxpc3AvZGlyZWQuZWwgfCAxMiArKystLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2Vy dGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9kaXJlZC5lbCBiL2xp c3AvZGlyZWQuZWwKaW5kZXggYjllODkyOTJlMi4uN2QzOTQwODMyYSAxMDA2NDQKLS0tIGEvbGlz cC9kaXJlZC5lbAorKysgYi9saXNwL2RpcmVkLmVsCkBAIC0zNjYxLDE5ICszNjYxLDEzIEBAIGRp cmVkLWRvLWZsYWdnZWQtZGVsZXRlCiAgIChpbnRlcmFjdGl2ZSkKICAgKGxldCogKChkaXJlZC1t YXJrZXItY2hhciBkaXJlZC1kZWwtbWFya2VyKQogCSAocmVnZXhwIChkaXJlZC1tYXJrZXItcmVn ZXhwKSkKLQkgY2FzZS1mb2xkLXNlYXJjaCBtYXJrZXJzKQorICAgICAgICAgY2FzZS1mb2xkLXNl YXJjaCkKICAgICAoaWYgKHNhdmUtZXhjdXJzaW9uIChnb3RvLWNoYXIgKHBvaW50LW1pbikpCiAJ CQkocmUtc2VhcmNoLWZvcndhcmQgcmVnZXhwIG5pbCB0KSkKLQkoZGlyZWQtaW50ZXJuYWwtZG8t ZGVsZXRpb25zCisgICAgICAgIChkaXJlZC1pbnRlcm5hbC1kby1kZWxldGlvbnMKICAgICAgICAg IChucmV2ZXJzZQotCSAgOzsgdGhpcyBjYW4ndCBtb3ZlIHBvaW50IHNpbmNlIEFSRyBpcyBuaWwK LQkgIChkaXJlZC1tYXAtb3Zlci1tYXJrcyAoY29ucyAoZGlyZWQtZ2V0LWZpbGVuYW1lKQotICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobGV0ICgobSAocG9pbnQtbWFya2Vy KSkpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHB1c2ggbSBtYXJr ZXJzKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG0pKQotCQkJICAg ICAgICBuaWwpKQorICAgICAgICAgIChkaXJlZC1tYXAtb3Zlci1tYXJrcyAoY29ucyAoZGlyZWQt Z2V0LWZpbGVuYW1lKSAocG9pbnQtbWFya2VyKSkgbmlsKSkKIAkgbmlsIHQpCi0gICAgICAoZG9s aXN0IChtIG1hcmtlcnMpIChzZXQtbWFya2VyIG0gbmlsKSkKICAgICAgIChvciBub21lc3NhZ2UK IAkgIChtZXNzYWdlICIoTm8gZGVsZXRpb25zIHJlcXVlc3RlZCkiKSkpKSkKIAotLSAKMi4zMC4y Cgo= --000000000000ea860305ea121325-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 02 15:17:37 2022 Received: (at control) by debbugs.gnu.org; 2 Oct 2022 19:17:37 +0000 Received: from localhost ([127.0.0.1]:48078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1of4T3-0001EY-Ls for submit@debbugs.gnu.org; Sun, 02 Oct 2022 15:17:37 -0400 Received: from mail-oi1-f178.google.com ([209.85.167.178]:34619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1of4T2-0001E9-Km for control@debbugs.gnu.org; Sun, 02 Oct 2022 15:17:36 -0400 Received: by mail-oi1-f178.google.com with SMTP id m81so9666940oia.1 for ; Sun, 02 Oct 2022 12:17:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date; bh=zsSIwvVodGCTNtpuy4gGbWXs+fEO/cadw8fDk7xu7io=; b=H8n+ViqnF38b70z0AgVxJQjytVAM6xWp5S5Wi5xgc5Ud1oJYVdKHdMqGQCi3B31C30 FjUgBoWUVIh+WwZhDTMBoXZ46PWLYoFL5yBsIKK3wyNGCjgJNt4jZAlfPsTB3Qu187Uv lcR1emw0WLEJVvjyjtVzMEzLUKaNv0tu8J1ln8RBgOFFCu7RMy7Jazm7SXRP2aJPhKRu UWJgokcQz/azyQlXNkmyg7EHn4dQS+koNCOVCX0x5jxpKPCex4ejqqGEp7m6HeGRejYp CN2JVKK/57pZY5Dv0u8Tc48YbcjBrEfbuPMIn0F0tMsOhLH2aw+Oj+PZJTrups1Klvk4 I+ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date; bh=zsSIwvVodGCTNtpuy4gGbWXs+fEO/cadw8fDk7xu7io=; b=I9ah8YuR738TJo2Dz3vKjMU+KMEe9r4KnQtiIboyboN9TxaI6L6JN68NCShVcbJtu+ YHyfzDknqeRNssFkiUbTvbBqDd7KzfSk9yGMpIgTIjl7PUm9rsG1y2iVujLpqjf6mMxD TkQ/DJ3Ghn5Zavu6Z9hyvEQCSpH+WYNEJjylFiZy9+FNcs13ZMaDZlrVLLfK0igaIfaY pfOdy4be1k6qUDIqYVBac2qLCnBbqPRJf8cNLzISTtQBFB72jhBbKtGejQ+1ccS0NY0f jCO1esDIH2aiT1/wiLJ0Kx3quCeJMQMadyBgS+0rQvL44V9hoZWKPq86KnXNqneqifxL EjUg== X-Gm-Message-State: ACrzQf2wrQUintew05fRDTOaAZ9XxZocEs2lc/TBtBKo13VaBX7MSb5N 3hrzNqX1n8WJqRPD7ItZ3Y3Bb5YdYju9Cxq6dbxdmKFc X-Google-Smtp-Source: AMsMyM53krzIvoe6j/jMxs39JItEB0DTmjb050FQGcmDjdI0CSZV4+maQmi2DVfM/GInKns+hgEX2HhbsTjlQulJunU= X-Received: by 2002:a05:6808:1186:b0:353:b77a:a481 with SMTP id j6-20020a056808118600b00353b77aa481mr532170oil.199.1664738251031; Sun, 02 Oct 2022 12:17:31 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 2 Oct 2022 19:17:30 +0000 From: Stefan Kangas X-Hashcash: 1:20:221002:control@debbugs.gnu.org::A+EC5APrHcUAXKoE:1R76 MIME-Version: 1.0 Date: Sun, 2 Oct 2022 19:17:30 +0000 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 58256 + patch thanks Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.178 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.178 listed in list.dnswl.org] 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) tags 58256 + patch thanks From unknown Tue Aug 19 02:59:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58256: Possible mistake in recent `dired-do-flagged-delete' change Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Oct 2022 20:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58256 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 58256@debbugs.gnu.org Received: via spool by 58256-submit@debbugs.gnu.org id=B58256.166474358621834 (code B ref 58256); Sun, 02 Oct 2022 20:47:02 +0000 Received: (at 58256) by debbugs.gnu.org; 2 Oct 2022 20:46:26 +0000 Received: from localhost ([127.0.0.1]:48184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1of5r0-0005g6-4Z for submit@debbugs.gnu.org; Sun, 02 Oct 2022 16:46:26 -0400 Received: from mout.gmx.net ([212.227.15.18]:43575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1of5qy-0005ft-La for 58256@debbugs.gnu.org; Sun, 02 Oct 2022 16:46:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1664743576; bh=ygpgsQcbAu1MiVDyTcbmRzhp2uU4XvbJRW56qvah8rk=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=cbijzAbE5jG2NpJf8Hf0C3Llh+wgmb6m/5T2caWIsU6Sv/tp1q63s3QtOtxaC2/eW v2O7GZqgmsBC3kjvNszcqqNQvvRGBd2HoJgp5Zv93aaHplgjC31APokGJOFNu+WmnA JKhtAs0NCIgc29HXSgDmvM/+4qwVCFfC6xXQbwL0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobelfs2 ([89.246.38.124]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MgvvT-1p8MFx1K9d-00hLZl; Sun, 02 Oct 2022 22:46:16 +0200 From: Stephen Berman In-Reply-To: (Stefan Kangas's message of "Sun, 2 Oct 2022 20:42:17 +0200") References: Date: Sun, 02 Oct 2022 22:46:15 +0200 Message-ID: <871qrqt0mg.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:LzlFufFMby0TGP7LkSe3y2doTdDUkxg1cdAX0uTDP0hoTT42hyR 4bstllWMdJdx4bK3CCWrRtZikJU0S0nvmOXAKg1Lu3kt9juk9xoA9nikG68HqKx4XTlLt02 hvT2tj6Cc4ceia2SzagwOYcDsD4l+A+tjm7tltFlYiCbxkv1LCEvAU0VuIpNHtb4fgZataX WwfC1ddHsu5ytRPGNvAvg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:K4otAOC7Vt4=:7t95eaSEAsFUCNfKiTaBhf uZxric0/uifR7OW1WEyQ0iSvpRBBXBaW//iSPjuchvJy3HMoQChx+Kb0ZIqhi2qTBN0No+WQ7 rRq67S1tLfvLSl+xTv75tNA8Hm1/5VTcTE+uO6J6MZZqnYiudsq5snOdf3EqEtMmS7peNcRLR LUoGbfQfLySSIXTxfgaizTXL4wLFa5yp7rnxibp25m5nF5u7FgEnzOZ9PkfqFXbPfEkI+dNR0 5iz8Itscp/HR/hMtUJwyzmjQY7kxEoYzA/dkzk259Vl/OpL30hdWK8D52BbhD1XsRdulkjbWh XCiWZ3+LIp3NJNesjUnWMmo7VDU0+nlFeUH4uNyQzCyTyFtG6ZO3jaW/ePbaagG+VANgPhL+F od0YW6ozUFlCgkecSHISPYBHPJimxrtbvzNX6ggXiIoek6OVR/K2NySu7y41ebxYsrL8v/jL5 s2LM6acjC4o5Y8fyYZc0a3gm6yWxadEDbvbADuya9gzM3VqiNhzzX+1fgbLzmScGIF8blZ4Se hm401zaOiwZJjgPyD19Pm6lp59DMdH5NA0fQNrj1nw8F7ljQmVllAnZo4CbbXK0JHyTRT2E8q qadGALimKhQQrIlU1S3lROrilq4TOIWDGkvAoCkhgvX/Ro7biNMmANFXm2dFn6bDf1m5tPlNr D1wWXS/wBYQIOKYIdroUQ3go5KpoWtTh2T6ENHqMHq4KMKQzVGJck7AisEvqRs+yE11nDA9TA aZFY2sLLA63Im2q6J5UQKbzAg/9s5HZ41UoxQyWGMmmyJxpyUSAANKGPBtbG7j2s2mXplMjbn +K1Hw1SEVe7Te/NQ7dkhZbvqq7gFTKTJqOvjcDUvElE9INtOgOlYug68mT9E2J279n/kOIVFc o/4d/PELUybiX2Gk5ilScSHqcaj8IYiO/EOTm+jUT+k60gBex72rIqFygw0lNGSheDcs6rltR SwYDx1GxehBZEYNvCgUDzbc/+M+19esdM8ZyHXezKcQ0dbHKpz603UywL1wjUgQhgKV60DKk3 B2xDEkIVS5tqKa6qJ2e/KZzHw6yXeaICa2p5gJYLuk6+6m8wP/4ZahirA8lNuJTCnoXO2tCZo RsztvCCxyLsPrp328AmsaqY8rMacWqlInNsUHe3rNQFcGD/c7PRPjTeyhDIizjKpVpHbguwWH Ci8G5U6Laum+T/2HY0/9WsYEH1 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, 2 Oct 2022 20:42:17 +0200 Stefan Kangas wrote: > It seems like there might be a mistake in the `dired-do-flagged-delete' > of this commit: > > commit 194d54a929a83fede75d618b104acd1b544feb10 > Author: Stephen Berman > Date: Fri Jun 4 12:01:41 2021 +0200 > > Fix placement of point in Dired deletion operations > > It seems like there is a `dolist' that will always run on the empty > list. Was perhaps the below the intended change? Yeah, it looks like I mistakenly put the dolist in the 'else' clause instead of the 'then' clause. Thanks for catching that. On Sun, 2 Oct 2022 19:17:27 +0000 Stefan Kangas wrote: > Stefan Kangas writes: > >> If so, I wonder how this code would have worked without that `dolist' so >> far, and if that line could just be removed instead? > > The command seems to be working correctly with the attached patch. > > Am I missing something here? I think doing it that way leaves the markers in the buffer, though probably for typical use cases that's not a problem, and it is simpler that way (as I noted when I posted my patch). I guess the same simplification can be applied to `dired-do-delete' as well. Steve Berman From unknown Tue Aug 19 02:59:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58256: Possible mistake in recent `dired-do-flagged-delete' change Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Oct 2022 22:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58256 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stephen Berman Cc: 58256@debbugs.gnu.org Received: via spool by 58256-submit@debbugs.gnu.org id=B58256.16647498218009 (code B ref 58256); Sun, 02 Oct 2022 22:31:02 +0000 Received: (at 58256) by debbugs.gnu.org; 2 Oct 2022 22:30:21 +0000 Received: from localhost ([127.0.0.1]:48279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1of7TZ-000256-2d for submit@debbugs.gnu.org; Sun, 02 Oct 2022 18:30:21 -0400 Received: from mail-oo1-f42.google.com ([209.85.161.42]:38778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1of7TX-00024f-Du for 58256@debbugs.gnu.org; Sun, 02 Oct 2022 18:30:20 -0400 Received: by mail-oo1-f42.google.com with SMTP id z9-20020a4a4909000000b0047651b95fbdso5711258ooa.5 for <58256@debbugs.gnu.org>; Sun, 02 Oct 2022 15:30:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date; bh=83MvBiTFWTBMPBxsjO+gKzfHHNF1GEScP9jbZxoi4m0=; b=H42QK4udJie+Yk1IBySrVwz6LBIwfB2xdV8+a9FTbogVf25sKdfSbpWo88k1gHU+nw 94WNVZuofqec1/aQcL2I9V2wMc+7/D6Y+T7VvE24IW5T2cNNfvA49sq1A2IrR+fYtGGk ItfVNLOEwTl6Q5KUZtUlSkUAiHPluy2BvjEzyqNtDye4B1fgghbO0fjEc0i0n7+pcBp7 53fdDrP8yGR4ChUGXcD7WQvBKYeWD5zY7b/yPib2r5DP94shcfgGpkLNRWCVu704aFC6 2l6ftxEQflKepOAsWwpLW1HWM8OJcOTuLTeORbHFRfo1nXMYrwcd+LFhhEDfl9Z4ktkJ GgrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date; bh=83MvBiTFWTBMPBxsjO+gKzfHHNF1GEScP9jbZxoi4m0=; b=XK8XLaUYS3efeQajTWHMZ9qkf63bUEagA4QUgd8bauFD2QXwAgb5hvdiy3924js85v o8khLJkwinYFOWoAHwEfuEBBSX9vCR/T76/Mn2IdH+GHODG4KF8zJh6J0GTC40+Cw46o 0WNI8ankXu8w15Ce0W1dmdLFjr9HvSzYloLJSGTe513vfY5Y3LZKhc2/siz+SVIqQoJ3 fkPfdGuZqYO5w3MlJ0BgTKN6z1Ito3DznhrrPlOQnYUzv374k+xoq+UfhuQe5OW/WAsw A/T/ib3FrbIrzXQ83goFEvgaTPaOCnFOnVhUd0LHIK5mNiqsyLvXUDHAYxxSRsmyUbxG CgFw== X-Gm-Message-State: ACrzQf3Dkh7+XcxMdtEnDkHQLNZNqR+ppUAfN7biqn0Q9HT5lQ9+zpr6 f/dywjb73imf4UM9ON0wNGFaj7SO1qbwid1o/sw= X-Google-Smtp-Source: AMsMyM7tL2P6tUbOJQdKrxSlAZfYHN13zhfvQhly4MGBjeOdomK7cHSQ/aZw/OM90l4JbVjhv/QCqXTlrvtKAIbRlJE= X-Received: by 2002:a9d:7c89:0:b0:655:dfb1:331c with SMTP id q9-20020a9d7c89000000b00655dfb1331cmr6790424otn.224.1664749813807; Sun, 02 Oct 2022 15:30:13 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 3 Oct 2022 00:30:13 +0200 From: Stefan Kangas In-Reply-To: <871qrqt0mg.fsf@gmx.net> References: <871qrqt0mg.fsf@gmx.net> X-Hashcash: 1:20:221002:58256@debbugs.gnu.org::kU/GQVumJHrjO3ta:2Ymz MIME-Version: 1.0 Date: Mon, 3 Oct 2022 00:30:13 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 58256 29.1 thanks Stephen Berman writes: > Yeah, it looks like I mistakenly put the dolist in the 'else' clause > instead of the 'then' clause. Thanks for catching that. [...] > I think doing it that way leaves the markers in the buffer, though > probably for typical use cases that's not a problem, and it is simpler > that way (as I noted when I posted my patch). I guess the same > simplification can be applied to `dired-do-delete' as well. OK. Let's stick with the more correct way and actually delete the markers. I've done this in commit 0d0d59b32c, and I'm closing this bug report.