GNU bug report logs - #58222
[PATCH] elisp/guix-repl: remove reference of non existent variable

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58222 in the body.
You can then email your comments to 58222 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Abhiseck Paira <abhiseckpaira <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] elisp/guix-repl: remove reference of non existent variable
Date: Sat, 01 Oct 2022 18:00:12 +0530

* elisp/guix-repl.el (guix-start-repl): the variable
`geiser-repl-company-p' is used but this variable was removed from
geiser in the commit "18faa0b Suggestive patch for simplified
completion".  So remove its reference.
---
This patch is for emacs-guix (guix.el, Emacs interface for Guix).  I was
told that Guix has taken over the development of this package.  I hope
this is the right place to send this patch, as I couldn't find a better
place.

 elisp/guix-repl.el | 1 -
 1 file changed, 1 deletion(-)

diff --git a/elisp/guix-repl.el b/elisp/guix-repl.el
index 5dd446f..bf1dc82 100644
--- a/elisp/guix-repl.el
+++ b/elisp/guix-repl.el
@@ -328,7 +328,6 @@ this address (it should be defined by
                geiser-guile--debugger-prompt-regexp))
         (geiser-repl--startup impl address)
         (geiser-repl--autodoc-mode 1)
-        (geiser-company--setup geiser-repl-company-p)
         (add-hook 'comint-output-filter-functions
                   'guix-repl-output-filter
                   nil t)
-- 
2.37.3


-- 
Abhiseck Paira
E34E 825B 979E EB9F 8505  F80E E93D 353B 7740 0709
https://paira.in

Message #10 received at 58222-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Abhiseck Paira <abhiseckpaira <at> disroot.org>
Cc: 58222-done <at> debbugs.gnu.org
Subject: Re: bug#58222: [PATCH] elisp/guix-repl: remove reference of non
 existent variable
Date: Sun, 09 Oct 2022 22:13:04 +0200

Hi,

Abhiseck Paira <abhiseckpaira <at> disroot.org> skribis:

> * elisp/guix-repl.el (guix-start-repl): the variable
> `geiser-repl-company-p' is used but this variable was removed from
> geiser in the commit "18faa0b Suggestive patch for simplified
> completion".  So remove its reference.

A similar patch was applied in commit
6f5c2c3a0161a4eb99585211e2934c5f7010f249 of Emacs-Guix on Savannah,
thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.