GNU bug report logs - #58202
[PATCH] Move point to end of line after indent for sieve-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58202 in the body.
You can then email your comments to 58202 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Helmert III <ajak <at> gentoo.org>
To: bug-gnu-emacs <at> gnu.org
Cc: John Helmert III <ajak <at> gentoo.org>
Subject: [PATCH] Move point to end of line after indent for sieve-mode
Date: Fri, 30 Sep 2022 13:07:28 -0500

* lisp/net/sieve-mode.el: move pointer to end of line after indenting

---
 lisp/net/sieve-mode.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/net/sieve-mode.el b/lisp/net/sieve-mode.el
index f62af03534..80532fc1ba 100644
--- a/lisp/net/sieve-mode.el
+++ b/lisp/net/sieve-mode.el
@@ -200,7 +200,8 @@ Turning on Sieve mode runs `sieve-mode-hook'."
     (let ((depth (car (syntax-ppss))))
       (when (looking-at "[ \t]*}")
         (setq depth (1- depth)))
-      (indent-line-to (* 2 depth)))))
+      (indent-line-to (* 2 depth))))
+  (end-of-line))
 
 (provide 'sieve-mode)
 
-- 
2.37.3

Message #8 received at 58202 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: John Helmert III <ajak <at> gentoo.org>
Cc: 58202 <at> debbugs.gnu.org
Subject: Re: bug#58202: [PATCH] Move point to end of line after indent for
 sieve-mode
Date: Sat, 01 Oct 2022 14:52:23 +0200

John Helmert III <ajak <at> gentoo.org> writes:

> * lisp/net/sieve-mode.el: move pointer to end of line after indenting

I'm not very familiar with sieve-mode, but moving the pointer to the end
of the line after indenting is pretty unusual for a mode.  Why should
sieve-mode do this?

Message #13 received at 58202 <at> debbugs.gnu.org (full text, mbox):

From: John Helmert III <ajak <at> gentoo.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 58202 <at> debbugs.gnu.org
Subject: Re: bug#58202: [PATCH] Move point to end of line after indent for
 sieve-mode
Date: Sat, 1 Oct 2022 09:54:17 -0500

[Message part 1 (text/plain, inline)]

On Sat, Oct 01, 2022 at 02:52:23PM +0200, Lars Ingebrigtsen wrote:
> John Helmert III <ajak <at> gentoo.org> writes:
> 
> > * lisp/net/sieve-mode.el: move pointer to end of line after indenting
> 
> I'm not very familiar with sieve-mode, but moving the pointer to the end
> of the line after indenting is pretty unusual for a mode.  Why should
> sieve-mode do this?

Without doing this, the point ends up at the beginning of an indented
line, before any added indentation spacing.

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 58202 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: John Helmert III <ajak <at> gentoo.org>
Cc: 58202 <at> debbugs.gnu.org
Subject: Re: bug#58202: [PATCH] Move point to end of line after indent for
 sieve-mode
Date: Sun, 02 Oct 2022 14:06:50 +0200

John Helmert III <ajak <at> gentoo.org> writes:

> Without doing this, the point ends up at the beginning of an indented
> line, before any added indentation spacing.

But with it, if you hit TAB in the middle of a line, you'll end up at
the end of the line.

I've now pushed a different fix to Emacs 29 that makes TAB work like in
other modes.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.