From unknown Sun Jul 20 09:47:23 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#58169 <58169@debbugs.gnu.org> To: bug#58169 <58169@debbugs.gnu.org> Subject: Status: 29.0.50; comint-fl-mode fontifies the output Reply-To: bug#58169 <58169@debbugs.gnu.org> Date: Sun, 20 Jul 2025 16:47:23 +0000 retitle 58169 29.0.50; comint-fl-mode fontifies the output reassign 58169 emacs submitter 58169 Augusto Stoffel severity 58169 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 29 12:25:07 2022 Received: (at submit) by debbugs.gnu.org; 29 Sep 2022 16:25:07 +0000 Received: from localhost ([127.0.0.1]:39384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odwLT-0001iy-6M for submit@debbugs.gnu.org; Thu, 29 Sep 2022 12:25:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:36206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odwLR-0001iq-3K for submit@debbugs.gnu.org; Thu, 29 Sep 2022 12:25:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49196) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odwLQ-0004g1-1O for bug-gnu-emacs@gnu.org; Thu, 29 Sep 2022 12:25:04 -0400 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]:37815) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odwLO-0001a3-4n for bug-gnu-emacs@gnu.org; Thu, 29 Sep 2022 12:25:03 -0400 Received: by mail-ed1-x52d.google.com with SMTP id a41so2686066edf.4 for ; Thu, 29 Sep 2022 09:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date; bh=YXBYDIW+aht42MSWlLbPgCcy+iGqop+YZ9BJ16ONaXs=; b=a8zhrayB9MFBuvp0DzQJy3gi1MbPZYWMZmSoZFKqqbyYhPrdbdVVRZBW9lLVBrw7Yv WLCs0q8QLrI+5lI0/gM0dGWlYdIj4h5eKMyszU5LzOMIIOqcG76xf8g7gLRVtJ3abpjm EYRHgUMDv6w37cvobK5k9JL5K3lv8OwlCvKJB75AcLLXTbXAMQTmb1s22bHdoR1SaTYb 8z8cbEo28+gxxBbbtezeJslySWojVGk4C27tWHW8pGuTL0aqrTKFs3YNDHZbgSv0CySl Drh4wkDtcLOQ/YDABqOOkIvWhesAeuxEsQztflEufh5uXlDu1ZIKxOFF/QimqnqhSeZm idWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date; bh=YXBYDIW+aht42MSWlLbPgCcy+iGqop+YZ9BJ16ONaXs=; b=khOb7pTxMqBN17O6hMs1YFxZs55hXR5EjjcovmAjf72wku2zY0PGDI4igu/E/ciyq3 fM8PRsOm2JBV8Y9ek+dX9RN/YuoZqOkI7krDWkXUSO/BUMMmrW9eHZ6FXP4zGFbLbJuv BFwM+XjGsjTSy9A/KbPQDRQlmk+w/St0LIjlBEyjXIiefOi+7OSMT0vJEmxmDd0/uhWO 69hn+vb6vtUBiz1YBCCgjZRA0KzaCnwfxFWsemzCSnRkzCIkNmq7JHv4zxRoz7lkxJYK GkILZzhx1HVtwkx7Ha+iQblx65n9dzdn0PO9e2F43G516YPTWrKYdDBohS8bQLMBsJ6a DiEA== X-Gm-Message-State: ACrzQf09fNhgKrFhMiJQlIYSDmM2Td0s87nrGVTAhlFSNNiTYzGFal/E yAYHI+ofhaNkIiCaI4F6WMpPq2ICr/0= X-Google-Smtp-Source: AMsMyM7/vgvl2fV3LZ7Q/trjy1C0VytRBtEOpdBzCTWn8MYxQIuE+O5SKu0Urwko/RYyZ8cV/VdTwA== X-Received: by 2002:a05:6402:5406:b0:452:1560:f9d4 with SMTP id ev6-20020a056402540600b004521560f9d4mr4136256edb.333.1664468700276; Thu, 29 Sep 2022 09:25:00 -0700 (PDT) Received: from ars3 ([2a02:8109:8ac0:56d0::89aa]) by smtp.gmail.com with ESMTPSA id 12-20020a170906328c00b007867dcd3f15sm4090860ejw.104.2022.09.29.09.24.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 09:24:59 -0700 (PDT) From: Augusto Stoffel To: bug-gnu-emacs@gnu.org Subject: 29.0.50; comint-fl-mode fontifies the output X-Debbugs-Cc: Miha =?utf-8?B?UmlodGFyxaFpxI0=?= Date: Thu, 29 Sep 2022 18:24:58 +0200 Message-ID: <87h70qcfmt.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::52d; envelope-from=arstoffel@gmail.com; helo=mail-ed1-x52d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On emacs -Q, calling M-x shell and typing, say echo '#123' prints some text with font-lock-comment-face. Similarly echo '`123`' prints text with the `sh-quoted-exec` face. I wouldn't expect these faces to be there, since the output is just output, not a comment or a quoted exec. If I turn off comint-fl-mode, then the output is not fontified. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 29 21:55:58 2022 Received: (at 58169) by debbugs.gnu.org; 30 Sep 2022 01:55:58 +0000 Received: from localhost ([127.0.0.1]:39976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oe5Fu-0007nt-Dt for submit@debbugs.gnu.org; Thu, 29 Sep 2022 21:55:58 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:35493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oe5Fq-0007nd-Q9 for 58169@debbugs.gnu.org; Thu, 29 Sep 2022 21:55:57 -0400 Received: by mail-pf1-f195.google.com with SMTP id i6so3007203pfb.2 for <58169@debbugs.gnu.org>; Thu, 29 Sep 2022 18:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date; bh=B+/x89kHfpQe9ZxpHa7hA+ekrlWZgTtrSOPGTaNlhrY=; b=cU7gGGuOGGB1MOu2cGuhHHN3xktgU6ieF8xInciXRrhy1eNEgG8cli9oDI9+xy9x+1 QbnyR7mg2Mh3XqzACrIFLKxh8dyYBJnvkembMeryjKFwSoocVF2M510AsuejtF64o3lw aRFFALDBsBgrx9qt7vhgIPRvgMnErlRilQppAoMuZlRVvPeETWkZbTuik8RrhY7jsUUX S9NbXzEpT3UmhBcm19FffTFcnPTEf9mXT+fQ00dAVlup4U99A8g4FXsW33SzmHjpR+Bx VzCGio23+T3Sx+GDsi8MMetESiQeLG+UfJHoTCqknlqGcBQ9tKRfdDoFQwkBePrpWHTW GHHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=B+/x89kHfpQe9ZxpHa7hA+ekrlWZgTtrSOPGTaNlhrY=; b=7MvJYqllAiDlK3r0WYmztHptnnNreh2tXYk3F/ID+jtgFNd5vGu534OPRnVWYCe7lW 1fZx8pt7dxCyAXL1Ww9g80pPqKulyypgZKCVFmzMgTsTwnbsDJfn7V9DWaUyLegCgX9L uBO2WFJ4xuwcvuBrCvMvJe/QcvkEgku1vQfQlGq7gQeuJ3apMsLyqKp2CeBitJ1FbxZi +eMmJVp/TfIoV1CLfHO+70IU/X0tABUB1CVJw/h9AKrOVSXpYbQHCzO8bcXaVmDHWRA1 oydvDxYP/2LP28pj88UeVlJwd8hwZHwLmOgt8YXutO0bkrHhGXP6N7+mwqQuWA0Hc7Vt 3K+g== X-Gm-Message-State: ACrzQf0lzq4dwrWyBIDwpM5TDOiH/HW/DYGEgt6eRUSOxRHSTyO5hBaa ScXidw2nwDqH1MLn1kb26C0= X-Google-Smtp-Source: AMsMyM5mRmIPFH6vMmXICKV/aStfLwMwRrBX9j/CByAEYTQmgIcXfAqlC07m9ievmVcYHSwxwN3NiA== X-Received: by 2002:a05:6a00:1907:b0:557:e83b:1671 with SMTP id y7-20020a056a00190700b00557e83b1671mr6602966pfi.65.1664502948901; Thu, 29 Sep 2022 18:55:48 -0700 (PDT) Received: from localhost ([14.139.216.98]) by smtp.gmail.com with ESMTPSA id w18-20020a170902e89200b00176b3d7db49sm635751plg.0.2022.09.29.18.55.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 18:55:48 -0700 (PDT) From: Visuwesh To: Augusto Stoffel Subject: Re: bug#58169: 29.0.50; comint-fl-mode fontifies the output In-Reply-To: <87h70qcfmt.fsf@gmail.com> (Augusto Stoffel's message of "Thu, 29 Sep 2022 18:24:58 +0200") References: <87h70qcfmt.fsf@gmail.com> Date: Fri, 30 Sep 2022 07:25:39 +0530 Message-ID: <871qrt8w2s.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Quickly hijacking this bug report to say: can we please announce comint-fl-mode in NEWS, and say how to turn it off? I was confused when M-x shell randomly started to fontify the input line despite me [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [14.139.216.98 listed in zen.spamhaus.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (visuweshm[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.210.195 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.210.195 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 58169 Cc: 58169@debbugs.gnu.org, Miha =?utf-8?B?UmlodGFyxaFpxI0=?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Quickly hijacking this bug report to say: can we please announce comint-fl-mode in NEWS, and say how to turn it off? I was confused when M-x shell randomly started to fontify the input line despite me [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.210.195 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.210.195 listed in list.dnswl.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [14.139.216.98 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (visuweshm[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Quickly hijacking this bug report to say: can we please announce comint-fl-mode in NEWS, and say how to turn it off? I was confused when M-x shell randomly started to fontify the input line despite me disabling every font-lock related thing in *shell* buffers. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 30 01:58:19 2022 Received: (at 58169) by debbugs.gnu.org; 30 Sep 2022 05:58:19 +0000 Received: from localhost ([127.0.0.1]:40291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oe92Q-0005o4-W0 for submit@debbugs.gnu.org; Fri, 30 Sep 2022 01:58:19 -0400 Received: from kamnitnik.top ([209.250.245.214]:53290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oe92M-0005nq-VK for 58169@debbugs.gnu.org; Fri, 30 Sep 2022 01:58:18 -0400 From: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kamnitnik.top; s=mail; t=1664517491; bh=Z2hnO5BjM58tNckt/uKBt32sVSOVMrY9BesX9nWGDWk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=fYua7OjCgQEb+DSwyN8Y0jSNbW7bSChGVOpY7a4CfqDTifnxJomxgf3f6FuHX+09D 8Uejd/9PxMPa8/00hkxUYJDEr/ew4acm/f83QSIL7K23J2+nXcZZAafQz1EHGfWtjA YjnTUkmu04gBKleWNBqR4WSuKfH86H73YDLPWf1d+uSCfeNffRJUZvVfCbfEPJ7a9B Izg0G5ge66eVrGlnKvvnC0luX9zA/9vlOVpNNNyLIJV3itaVdUji3R1VyLWAKyMdpZ BrYwZjaih0N30QiOs4/nMmnJzZnnpFpYqQfBwLYq04bTPUwUgB65PNSlagI3/JuztT l9gL1QVHuOfjQ== To: Visuwesh , Augusto Stoffel Subject: Re: bug#58169: 29.0.50; comint-fl-mode fontifies the output In-Reply-To: <871qrt8w2s.fsf@gmail.com> References: <87h70qcfmt.fsf@gmail.com> <871qrt8w2s.fsf@gmail.com> Date: Fri, 30 Sep 2022 07:58:09 +0200 Message-ID: <8735c976a6.fsf@miha-pc> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Visuwesh writes: > Quickly hijacking this bug report to say: can we please announce > comint-fl-mode in NEWS, and say how to turn it off? I was confused when > M-x shell randomly started to fontify the input line desp [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: kamnitnik.top (top)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 FROM_SUSPICIOUS_NTLD From abused NTLD X-Debbugs-Envelope-To: 58169 Cc: 58169@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Visuwesh writes: > Quickly hijacking this bug report to say: can we please announce > comint-fl-mode in NEWS, and say how to turn it off? I was confused when > M-x shell randomly started to fontify the input line desp [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: kamnitnik.top (top)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD 0.0 FROM_SUSPICIOUS_NTLD From abused NTLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Visuwesh writes: > Quickly hijacking this bug report to say: can we please announce > comint-fl-mode in NEWS, and say how to turn it off? I was confused when > M-x shell randomly started to fontify the input line despite me > disabling every font-lock related thing in *shell* buffers. Thanks for reporting, I'll have time to work one these issues in the afternoon. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 30 09:38:58 2022 Received: (at 58169) by debbugs.gnu.org; 30 Sep 2022 13:38:58 +0000 Received: from localhost ([127.0.0.1]:40870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeGEE-000147-G3 for submit@debbugs.gnu.org; Fri, 30 Sep 2022 09:38:58 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeGEB-00013p-NB for 58169@debbugs.gnu.org; Fri, 30 Sep 2022 09:38:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BZNY/dF9RQyK5MZrjOhgqlAQ8OxVxDXPaePUvgYQyao=; b=qrTCgWbuznuEyJl1mzY5jMzxZb CdmKEcq8yKzE87hSKevplXpaBmfoygQM5kD40Oy/0qK0OOjYQkyXhms+VB0s6Y65YMvoOUko1vhjv tA9cJIdldBzAZScfNVp+5QydbZ5WCk+T0ZSHZl0DCBMPLYUg1vEGgrk6OuUgLGKQqz0Y=; Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oeGE3-0000YA-0o; Fri, 30 Sep 2022 15:38:49 +0200 From: Lars Ingebrigtsen To: Subject: Re: bug#58169: 29.0.50; comint-fl-mode fontifies the output In-Reply-To: <8735c976a6.fsf@miha-pc> (miha@kamnitnik.top's message of "Fri, 30 Sep 2022 07:58:09 +0200") References: <87h70qcfmt.fsf@gmail.com> <871qrt8w2s.fsf@gmail.com> <8735c976a6.fsf@miha-pc> X-Now-Playing: Lafaristo feat Ayaman (produced by Dj Skothane)'s _L'Esprit de Nyege 2020_: "Muntu Wami Ngibambe" Date: Fri, 30 Sep 2022 15:38:44 +0200 Message-ID: <87edvt56e3.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: writes: >> Quickly hijacking this bug report to say: can we please announce >> comint-fl-mode in NEWS, and say how to turn it off? I was confused when >> M-x shell randomly started to fontify the input line d [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 58169 Cc: 58169@debbugs.gnu.org, Augusto Stoffel , Visuwesh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) writes: >> Quickly hijacking this bug report to say: can we please announce >> comint-fl-mode in NEWS, and say how to turn it off? I was confused when >> M-x shell randomly started to fontify the input line despite me >> disabling every font-lock related thing in *shell* buffers. > > Thanks for reporting, I'll have time to work one these issues in the > afternoon. And I think we should probably rename it to `comint-font-lock-mode', because the current name is obscure. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 30 14:25:02 2022 Received: (at 58169) by debbugs.gnu.org; 30 Sep 2022 18:25:02 +0000 Received: from localhost ([127.0.0.1]:42895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeKh3-0006zC-Fq for submit@debbugs.gnu.org; Fri, 30 Sep 2022 14:25:01 -0400 Received: from kamnitnik.top ([209.250.245.214]:56240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeKh1-0006yw-8H for 58169@debbugs.gnu.org; Fri, 30 Sep 2022 14:25:00 -0400 From: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kamnitnik.top; s=mail; t=1664562298; bh=u7ZHQ7xAQf7GmPCYhBC5viv/13oZ0ZMlWu0Gw1nFC24=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=lZaPGZqgFyncoss2ml4HHRfalsmg+oEmVA4yGYx2hcKFJ6tBuZYhxzy80Rz6UkXjA i1ennpMFTwaW/1eUJPlhyLRzaaSMvCjsRxanDIc9jFi1H+GS2vqSR47wOgJ2eOEvpX QgDslMXX2Eq0VGX71IV5Zucc7fq2UKGw4qh26pnbE6fChwugoEQq/BDwU4u3vX4tNg ZXdXivqFTfE+Oz1OOr9l6FmHy2nlg3fSXq1gF2m8EZU5vJQQchmbFJ1CsGDmKDiQOd Bkh2Q//5OyGYJViSpeL+auSbqQJLfD5Naj8lGGgT+dQnhQOkEBV2PFize/CkVAQSjb lKRmEcW1kYU4Q== To: Lars Ingebrigtsen Subject: Re: bug#58169: 29.0.50; comint-fl-mode fontifies the output In-Reply-To: <87edvt56e3.fsf@gnus.org> References: <87h70qcfmt.fsf@gmail.com> <871qrt8w2s.fsf@gmail.com> <8735c976a6.fsf@miha-pc> <87edvt56e3.fsf@gnus.org> Date: Fri, 30 Sep 2022 20:38:54 +0200 Message-ID: <87o7uwu2pt.fsf@miha-pc> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Lars Ingebrigtsen writes: > writes: > >>> Quickly hijacking this bug report to say: can we please announce >>> comint-fl-mode in NEWS, and say how to turn it off? I was confused when >>> M-x shell randomly [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: kamnitnik.top (top)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 FROM_SUSPICIOUS_NTLD From abused NTLD X-Debbugs-Envelope-To: 58169 Cc: 58169@debbugs.gnu.org, Augusto Stoffel , Visuwesh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Lars Ingebrigtsen writes: > writes: > >>> Quickly hijacking this bug report to say: can we please announce >>> comint-fl-mode in NEWS, and say how to turn it off? I was confused when >>> M-x shell randomly [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: kamnitnik.top (top)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD 0.0 FROM_SUSPICIOUS_NTLD From abused NTLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > writes: > >>> Quickly hijacking this bug report to say: can we please announce >>> comint-fl-mode in NEWS, and say how to turn it off? I was confused when >>> M-x shell randomly started to fontify the input line despite me >>> disabling every font-lock related thing in *shell* buffers. >> >> Thanks for reporting, I'll have time to work one these issues in the >> afternoon. > > And I think we should probably rename it to `comint-font-lock-mode', > because the current name is obscure. I went with 'comint-fontify-input-mode'. I also made two more descriptive variable aliases. Patches attached --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-comint-fl-Prevent-fontification-of-output-as-input.patch Content-Transfer-Encoding: quoted-printable From=20ddbad11131d0bfcdef33666c028f3d7070cefc31 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Miha=3D20Rihtar=3DC5=3DA1i=3DC4=3D8D?=3D Date: Fri, 30 Sep 2022 20:07:03 +0200 Subject: [PATCH 1/2] comint-fl: Prevent fontification of output as input * lisp/comint.el (comint-output-filter): Inhibit jit-lock fontification of inserted process output before marking it with the 'output' filed property (bug#58169). =2D-- lisp/comint.el | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/lisp/comint.el b/lisp/comint.el index e7d2136c84..15c9388ea4 100644 =2D-- a/lisp/comint.el +++ b/lisp/comint.el @@ -2150,24 +2150,26 @@ comint-output-filter ;; insert-before-markers is a bad thing. XXX ;; Luckily we don't have to use it any more, we use ;; window-point-insertion-type instead. =2D (insert string) + (make-local-variable 'jit-lock-mode) + (let ((jit-lock-mode nil)) + (insert string) =20 =2D ;; Advance process-mark =2D (set-marker (process-mark process) (point)) + ;; Advance process-mark + (set-marker (process-mark process) (point)) =20 =2D (unless comint-inhibit-carriage-motion + (unless comint-inhibit-carriage-motion ;; Interpret any carriage motion characters (newline, backspace) (comint-carriage-motion comint-last-output-start (point))) =20 =2D ;; Run these hooks with point where the user had it. =2D (goto-char saved-point) =2D (run-hook-with-args 'comint-output-filter-functions string) =2D (set-marker saved-point (point)) + ;; Run these hooks with point where the user had it. + (goto-char saved-point) + (run-hook-with-args 'comint-output-filter-functions string) + (set-marker saved-point (point)) =20 =2D (goto-char (process-mark process)) ; In case a filter moved it. + (goto-char (process-mark process)) ; In case a filter moved it. =20 =2D (unless comint-use-prompt-regexp =2D (comint--mark-as-output comint-last-output-start (point))) + (unless comint-use-prompt-regexp + (comint--mark-as-output comint-last-output-start (point)))) =20 ;; Highlight the prompt, where we define `prompt' to mean ;; the most recent output that doesn't end with a newline. =2D-=20 2.37.2 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0002-comint-fl-New-descriptive-aliases-and-NEWS.patch Content-Transfer-Encoding: quoted-printable From=20f6d07520aaa2156957962397c59093d6b1c4acd7 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Miha=3D20Rihtar=3DC5=3DA1i=3DC4=3D8D?=3D Date: Fri, 30 Sep 2022 20:28:15 +0200 Subject: [PATCH 2/2] comint-fl: New descriptive aliases and NEWS * lisp/comint.el (comint-fontify-input-mode): New alias for 'comint-fl-mode' (bug#58169). * lisp/ielm.el (ielm-fontify-input-enable): New alias for 'ielm-comint-fl-enable'. * lisp/shell.el (shell-fontify-input-enable): New alias for 'shell-comint-fl-enable'. * etc/NEWS: Mention the new modes and how to turn them disable or enable them. =2D-- etc/NEWS | 14 ++++++++++++++ lisp/comint.el | 2 ++ lisp/ielm.el | 2 ++ lisp/shell.el | 2 ++ 4 files changed, 20 insertions(+) diff --git a/etc/NEWS b/etc/NEWS index aad1a17ae7..bce6a72481 100644 =2D-- a/etc/NEWS +++ b/etc/NEWS @@ -1214,6 +1214,14 @@ When nil, this prevents comint from deleting the cur= rent input when inserting previous input using ''. The default is t, to preserve past behavior. =20 +--- +*** New minor mode 'comint-fontify-input-mode'. +This minor mode is enabled by default in "*shell*" and "*ielm*" +buffers. It fontifies input text according to 'shell-mode' or +'emacs-lisp-mode' font-lock rules. Customize the user options +'shell-fontify-input-enable' and 'ielm-fontify-input-enable' to nil if +you don't want to enable input fontification by default. + ** Mwheel =20 --- @@ -2513,6 +2521,12 @@ behavior, customize the new 'eshell-lisp-form-nil-is= -failure' option. Enabling this will automatically kill a "*shell*" buffer as soon as the shell session terminates. =20 +--- +*** New minor mode 'shell-highlight-undef-mode' +Customize 'shell-highlight-undef-enable' to t if you want to enable +this minor mode in "*shell*" buffers. It will highlight undefined +commands with a warning face as you type. + ** Calc =20 +++ diff --git a/lisp/comint.el b/lisp/comint.el index 15c9388ea4..3d7218b868 100644 =2D-- a/lisp/comint.el +++ b/lisp/comint.el @@ -3978,6 +3978,8 @@ comint--indirect-buffer =20 (defvar-local comint--fl-saved-jit-lock-contextually nil) =20 +(defalias 'comint-fontify-input-mode #'comint-fl-mode) + (define-minor-mode comint-fl-mode "Enable input fontification in the current comint buffer. This minor mode is useful if the current major mode derives from diff --git a/lisp/ielm.el b/lisp/ielm.el index ad41cb1f6b..33a5fc8440 100644 =2D-- a/lisp/ielm.el +++ b/lisp/ielm.el @@ -483,6 +483,8 @@ ielm-comint-fl-enable :safe 'booleanp :version "29.1") =20 +(defvaralias 'ielm-fontify-input-enable 'ilem-comint-fl-enable) + (defcustom ielm-indirect-setup-hook nil "Hook run in an indirect buffer for input fontification. Input fontification and indentation of an IELM buffer, if diff --git a/lisp/shell.el b/lisp/shell.el index 18bb372242..33dcb248ab 100644 =2D-- a/lisp/shell.el +++ b/lisp/shell.el @@ -308,6 +308,8 @@ shell-input-autoexpand (const :tag "on" t)) :group 'shell) =20 +(defvaralias 'shell-fontify-input-enable 'shell-comint-fl-enable) + (defcustom shell-comint-fl-enable t "Enable fontification of input in shell buffers. This variable only has effect when the shell is started. Use the =2D-=20 2.37.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAEBCAAxFiEEmxVnesoT5rQXvVXnswkaGpIVmT8FAmM3N74THG1paGFAa2Ft bml0bmlrLnRvcAAKCRCzCRoakhWZP4r+EADAqfjrfVdETp4S4qccJnN5eIAA4X6+ VgMrENUbVM4pxeU4OQWJ9NKUPsyvKCOmX5XMJK5FjkwMaZ+kF/L/Q1D2mpYoprV1 PqIFnT1sUblG0hMDaz7KTHY1Ra45C3Hi5Fs7oMHeBLC2Ausqh5WwqoP3jMlN/+aL pG9bUK2KPFuzDHU5CsY9OqimraQ+J4lS6yVU+bzlUGGUWJthvUSKXlxyQxXxXpcL 2eExFhZxXrSEvFcaNrqwUKJmi70RAbmtUwcLePw1cBnK7bZpOERoXbbrlThbxAtb zYo8vw6bAXptdZFvmrae+N9VjtunxbWoUpJylGPQaZCX/5rPui/m6I0Fza0mJ8fY o/CU3/obo2EX62d7lEfnP14to2M9YMwTrMp6BHdbhhgC5WIwLf7iek1KG9RLvSqk Bh/UdMb6Vt8W0YruJSsHrwOeUubKCM/iymnmjFy3hEvrLzLTFpfpWZUb/ucZCNti vGBXGnju1rVl2xBl+9F/11dnTM9u13lwHBw+OjNdacB0YUkvAl4OjwThPGRJgj+A dXEZiIDdQx5Mky+BijR/onvc+s6BoT5md3j27RLgsZL8u0gX0WAQBCDb7A5gaDed o9u9+0CHYYAMN9rYh9AAxEmQluQSoNnblOLrGArz+BKTXJUVcJLxHPa2BdPKf/2M ZLXIIYpH5Ib93g== =7u58 -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 30 14:27:09 2022 Received: (at 58169) by debbugs.gnu.org; 30 Sep 2022 18:27:09 +0000 Received: from localhost ([127.0.0.1]:42899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeKj7-00072S-6c for submit@debbugs.gnu.org; Fri, 30 Sep 2022 14:27:09 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeKj3-00071u-8T for 58169@debbugs.gnu.org; Fri, 30 Sep 2022 14:27:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yNtm4ExlLYrGhIvTAQux6RQqohiENZjCW0wvJrod154=; b=FIpu7ydSXKUQgK6HXKcB7TPXWK gVODxmFdMUWPt2CTajGve46n+hSpaEuyjsCe4xklfAUCeDURXA304vTV/aC/ljzVP0S0onD114KjT diVQ0Yd7CrddVWRUqy3DC4jgda7AT1LF8q41Bx9j9s3EK0WJpWKdgzLd342YoA7MUgDs=; Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oeKiu-000325-3s; Fri, 30 Sep 2022 20:26:58 +0200 From: Lars Ingebrigtsen To: Subject: Re: bug#58169: 29.0.50; comint-fl-mode fontifies the output In-Reply-To: <87o7uwu2pt.fsf@miha-pc> (miha@kamnitnik.top's message of "Fri, 30 Sep 2022 20:38:54 +0200") References: <87h70qcfmt.fsf@gmail.com> <871qrt8w2s.fsf@gmail.com> <8735c976a6.fsf@miha-pc> <87edvt56e3.fsf@gnus.org> <87o7uwu2pt.fsf@miha-pc> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEVFOiGTciXGtELR 1J3///8VdpLZAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YJHhIaGuPyZF0AAAGuSURBVDjLZZQBlsMg CERh9wJALhD1Ao3e/247jJo2XV5f++J3GCBaEc+QqJ+BBfHIX8P3WJEkCIqDxV7vWC8AiXNPabci wglKOCS1vRUL0L3eHr1kAiOAzRuMUmq0CUA8Qd3mS2EiAQmWNggCWLHmVllCj63Asilc2mfvhlm4 K6r6BJABIBEyYRBvACeT1cSMUnfhUBSCPofKiUZLgHJAaMItmWECw/Axfp1eJHUpTCyKxhyab9A6 albomL08AQRCResEwVRwtlrQe4JrKhpA0YKj0DotRt0mli+9rHJY9MqVYEZg1m66HsZJEByKj2xH b4W4/eQ82anokk+geUKyUnsAbKsE+XqUNjegIg+kxHoRCdR4PutgWdMmZCpy0NWPaz5m1VgUVowz YT5W5vmxSdD3gQQTZRy0wVyaH8PtCTxB+LhOJtAJUlA8eruaGIFT5vmV12u8LEHmJaD30XGjXqYW ecDd5St+Oo4mjkcxfQIdSQfwl+Z3nEh3jHYuoGsSvGm2VvgnsGbEu/6CcIx7u2apvNHXBjtdFso7 aOvpEfle0N/RvoHM5vRfi+/4A5hnX60xskv5AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTA5LTMw VDE4OjI2OjI2KzAwOjAwHJ6g8QAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wOS0zMFQxODoyNjoy NiswMDowMG3DGE0AAAAASUVORK5CYII= X-Now-Playing: DAF DOS's _Allein, zu zweit, mit telefon_: "Ex-KFS" Date: Fri, 30 Sep 2022 20:26:55 +0200 Message-ID: <87a66g4t1s.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: writes: > +(defalias 'comint-fontify-input-mode #'comint-fl-mode) Thanks, but why aliases instead of just renaming the functions and variables? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 58169 Cc: 58169@debbugs.gnu.org, Augusto Stoffel , Visuwesh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) writes: > +(defalias 'comint-fontify-input-mode #'comint-fl-mode) Thanks, but why aliases instead of just renaming the functions and variables? From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 30 15:08:38 2022 Received: (at 58169) by debbugs.gnu.org; 30 Sep 2022 19:08:38 +0000 Received: from localhost ([127.0.0.1]:42967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeLNF-00085X-Lf for submit@debbugs.gnu.org; Fri, 30 Sep 2022 15:08:38 -0400 Received: from kamnitnik.top ([209.250.245.214]:56378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeLNC-00085N-AC for 58169@debbugs.gnu.org; Fri, 30 Sep 2022 15:08:36 -0400 From: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kamnitnik.top; s=mail; t=1664564911; bh=6qL+7j9XkgpitGjlYW7sc7G6IZS4ajTXCESnFFKx6BU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=UEWlcJ4BADTABQ0D0EFlJcXQPvkHL1pWij/G4tR8GfuQ7jfJN5+XY/rvGApP1/Mhq KsRWacORMDqaAZMRpRkdqrPJbsMQURWuEDa/IqeaziAhqOMdqWkboym3nME8MKoa2p O1ufQMV5mDkoVldpIyKlVMxoj562ko/QzNb0Dg/Vn3E2copVuWBZCF47PELlJ4ARuE nc6FuTeKR/wqyB11E1FVk3DxqMRCe6SYhO1aR0K8m7D3oIzKG58m2mGdbbRB6GIp9H U1BuFGjr7qifk5BvMrYU/LM/IDebed40CsfXbZ4hu5PVNyfd80P8TDGMtGCGvc9+g2 C8bG2sNpuBptw== To: Lars Ingebrigtsen Subject: Re: bug#58169: 29.0.50; comint-fl-mode fontifies the output In-Reply-To: <87a66g4t1s.fsf@gnus.org> References: <87h70qcfmt.fsf@gmail.com> <871qrt8w2s.fsf@gmail.com> <8735c976a6.fsf@miha-pc> <87edvt56e3.fsf@gnus.org> <87o7uwu2pt.fsf@miha-pc> <87a66g4t1s.fsf@gnus.org> Date: Fri, 30 Sep 2022 21:22:27 +0200 Message-ID: <87leq0u0p8.fsf@miha-pc> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Lars Ingebrigtsen writes: > writes: > >> +(defalias 'comint-fontify-input-mode #'comint-fl-mode) > > Thanks, but why aliases instead of just renaming the functions and > variables? Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: kamnitnik.top (top)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 FROM_SUSPICIOUS_NTLD From abused NTLD X-Debbugs-Envelope-To: 58169 Cc: 58169@debbugs.gnu.org, Augusto Stoffel , Visuwesh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Lars Ingebrigtsen writes: > writes: > >> +(defalias 'comint-fontify-input-mode #'comint-fl-mode) > > Thanks, but why aliases instead of just renaming the functions and > variables? Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: kamnitnik.top (top)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD 0.0 FROM_SUSPICIOUS_NTLD From abused NTLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > writes: > >> +(defalias 'comint-fontify-input-mode #'comint-fl-mode) > > Thanks, but why aliases instead of just renaming the functions and > variables? I originally thought that the function names could become too long. But now I tried it and it's not so bad, so here are the revised patches attached. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-comint-fl-Prevent-fontification-of-output-as-input.patch Content-Transfer-Encoding: quoted-printable From=20ddbad11131d0bfcdef33666c028f3d7070cefc31 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Miha=3D20Rihtar=3DC5=3DA1i=3DC4=3D8D?=3D Date: Fri, 30 Sep 2022 20:07:03 +0200 Subject: [PATCH 1/2] comint-fl: Prevent fontification of output as input * lisp/comint.el (comint-output-filter): Inhibit jit-lock fontification of inserted process output before marking it with the 'output' filed property (bug#58169). =2D-- lisp/comint.el | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/lisp/comint.el b/lisp/comint.el index e7d2136c84..15c9388ea4 100644 =2D-- a/lisp/comint.el +++ b/lisp/comint.el @@ -2150,24 +2150,26 @@ comint-output-filter ;; insert-before-markers is a bad thing. XXX ;; Luckily we don't have to use it any more, we use ;; window-point-insertion-type instead. =2D (insert string) + (make-local-variable 'jit-lock-mode) + (let ((jit-lock-mode nil)) + (insert string) =20 =2D ;; Advance process-mark =2D (set-marker (process-mark process) (point)) + ;; Advance process-mark + (set-marker (process-mark process) (point)) =20 =2D (unless comint-inhibit-carriage-motion + (unless comint-inhibit-carriage-motion ;; Interpret any carriage motion characters (newline, backspace) (comint-carriage-motion comint-last-output-start (point))) =20 =2D ;; Run these hooks with point where the user had it. =2D (goto-char saved-point) =2D (run-hook-with-args 'comint-output-filter-functions string) =2D (set-marker saved-point (point)) + ;; Run these hooks with point where the user had it. + (goto-char saved-point) + (run-hook-with-args 'comint-output-filter-functions string) + (set-marker saved-point (point)) =20 =2D (goto-char (process-mark process)) ; In case a filter moved it. + (goto-char (process-mark process)) ; In case a filter moved it. =20 =2D (unless comint-use-prompt-regexp =2D (comint--mark-as-output comint-last-output-start (point))) + (unless comint-use-prompt-regexp + (comint--mark-as-output comint-last-output-start (point)))) =20 ;; Highlight the prompt, where we define `prompt' to mean ;; the most recent output that doesn't end with a newline. =2D-=20 2.37.2 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0002-Rename-comint-fl-to-comint-fontify-input-and-mention.patch Content-Transfer-Encoding: quoted-printable From=20734d2b840618e323f8676f74e152b6c85a68a020 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Miha=3D20Rihtar=3DC5=3DA1i=3DC4=3D8D?=3D Date: Fri, 30 Sep 2022 20:28:15 +0200 Subject: [PATCH 2/2] Rename comint-fl-* to comint-fontify-input-* and menti= on it in NEWS * lisp/comint.el (comint-fontify-input-mode): (comint--fontify-input-saved-jit-lock-contextually): (comint--fontify-input-on): (comint--fontify-input-off): (comint--fontify-input-ppss-flush-indirect): (comint--fontify-input-fontify-region): Replace comint-fl-* with comint-fontify-input-*. * lisp/ielm.el (ielm-fontify-input-enable): (ielm-fontify-input-enable): (ielm-indirect-setup-hook): (inferior-emacs-lisp-mode): Replace comint-fl-* with comint-fontify-input-*. * lisp/shell.el (shell-comint-fl-enable): (shell-mode): Replace comint-fl-* with comint-fontify-input-*. * etc/NEWS: Mention the new modes and how to disable or enable them (bug#58169). =2D-- etc/NEWS | 14 ++++++++++++++ lisp/comint.el | 46 +++++++++++++++++++++++----------------------- lisp/ielm.el | 10 +++++----- lisp/shell.el | 33 +++++++++++++++++---------------- 4 files changed, 59 insertions(+), 44 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index aad1a17ae7..bce6a72481 100644 =2D-- a/etc/NEWS +++ b/etc/NEWS @@ -1214,6 +1214,14 @@ When nil, this prevents comint from deleting the cur= rent input when inserting previous input using ''. The default is t, to preserve past behavior. =20 +--- +*** New minor mode 'comint-fontify-input-mode'. +This minor mode is enabled by default in "*shell*" and "*ielm*" +buffers. It fontifies input text according to 'shell-mode' or +'emacs-lisp-mode' font-lock rules. Customize the user options +'shell-fontify-input-enable' and 'ielm-fontify-input-enable' to nil if +you don't want to enable input fontification by default. + ** Mwheel =20 --- @@ -2513,6 +2521,12 @@ behavior, customize the new 'eshell-lisp-form-nil-is= -failure' option. Enabling this will automatically kill a "*shell*" buffer as soon as the shell session terminates. =20 +--- +*** New minor mode 'shell-highlight-undef-mode' +Customize 'shell-highlight-undef-enable' to t if you want to enable +this minor mode in "*shell*" buffers. It will highlight undefined +commands with a warning face as you type. + ** Calc =20 +++ diff --git a/lisp/comint.el b/lisp/comint.el index 15c9388ea4..a70a75c648 100644 =2D-- a/lisp/comint.el +++ b/lisp/comint.el @@ -1945,7 +1945,7 @@ comint-send-input (when comint-highlight-input (add-text-properties beg end '( font-lock-face comint-highlight-in= put =2D comint--fl-inhibit-fontification= t + comint--fontify-input-inhibit-font= ification t front-sticky t ))) (unless comint-use-prompt-regexp ;; Give old user input a field property of `input', to @@ -3976,9 +3976,9 @@ comint-indirect-setup-hook (defvar-local comint--indirect-buffer nil "Indirect buffer used for input fontification.") =20 =2D(defvar-local comint--fl-saved-jit-lock-contextually nil) +(defvar-local comint--fontify-input-saved-jit-lock-contextually nil) =20 =2D(define-minor-mode comint-fl-mode +(define-minor-mode comint-fontify-input-mode "Enable input fontification in the current comint buffer. This minor mode is useful if the current major mode derives from `comint-mode' and if `comint-indirect-setup-function' is set. @@ -3993,71 +3993,71 @@ comint-fl-mode non-nil. Input fontification isn't compatible with this setting." :lighter nil =2D (if comint-fl-mode + (if comint-fontify-input-mode (let ((success nil)) (unwind-protect (progn =2D (comint--fl-on) + (comint--fontify-input-on) (setq success t)) (unless success =2D (setq comint-fl-mode nil) =2D (comint--fl-off)))) =2D (comint--fl-off))) + (setq comint-fontify-input-mode nil) + (comint--fontify-input-off)))) + (comint--fontify-input-off))) =20 =2D(defun comint--fl-on () +(defun comint--fontify-input-on () "Enable input fontification in the current comint buffer." =2D (comint--fl-off) + (comint--fontify-input-off) =20 (when comint-use-prompt-regexp (error "Input fontification is incompatible with `comint-use-prompt-regexp'"= )) =20 (add-function :around (local 'font-lock-fontify-region-function) =2D #'comint--fl-fontify-region) + #'comint--fontify-input-fontify-region) ;; `before-change-functions' are only run in the current buffer and ;; not in its indirect buffers, which means that we must manually ;; flush ppss cache (add-hook 'before-change-functions =2D #'comint--fl-ppss-flush-indirect 99 t) + #'comint--fontify-input-ppss-flush-indirect 99 t) =20 ;; Set up contextual fontification (unless (booleanp jit-lock-contextually) =2D (setq comint--fl-saved-jit-lock-contextually + (setq comint--fontify-input-saved-jit-lock-contextually jit-lock-contextually) (setq-local jit-lock-contextually t) (when jit-lock-mode (jit-lock-mode t)))) =20 =2D(defun comint--fl-off () +(defun comint--fontify-input-off () "Disable input fontification in the current comint buffer." (remove-function (local 'font-lock-fontify-region-function) =2D #'comint--fl-fontify-region) + #'comint--fontify-input-fontify-region) (remove-hook 'before-change-functions =2D #'comint--fl-ppss-flush-indirect t) + #'comint--fontify-input-ppss-flush-indirect t) =20 ;; Reset contextual fontification =2D (when comint--fl-saved-jit-lock-contextually + (when comint--fontify-input-saved-jit-lock-contextually (setq-local jit-lock-contextually =2D comint--fl-saved-jit-lock-contextually) =2D (setq comint--fl-saved-jit-lock-contextually nil) + comint--fontify-input-saved-jit-lock-contextually) + (setq comint--fontify-input-saved-jit-lock-contextually nil) (when jit-lock-mode (jit-lock-mode t))) =20 (font-lock-flush)) =20 =2D(defun comint--fl-ppss-flush-indirect (beg &rest rest) +(defun comint--fontify-input-ppss-flush-indirect (beg &rest rest) (when-let ((buf (comint-indirect-buffer t))) (with-current-buffer buf (when (memq #'syntax-ppss-flush-cache before-change-functions) (apply #'syntax-ppss-flush-cache beg rest))))) =20 =2D(defun comint--fl-fontify-region (fun beg end verbose) +(defun comint--fontify-input-fontify-region (fun beg end verbose) "Fontify process output and user input in the current comint buffer. First, fontify the region between BEG and END using FUN. Then fontify only the input text in the region with the help of an indirect buffer. VERBOSE is passed to the fontify-region functions. Skip fontification of input regions with non-nil =2D`comint--fl-inhibit-fontification' text property." +`comint--fontify-input-inhibit-fontification' text property." (pcase (funcall fun beg end verbose) (`(jit-lock-bounds ,beg1 . ,end1) (setq beg beg1 end end1))) @@ -4069,7 +4069,7 @@ comint--fl-fontify-region (comint--intersect-regions nil (lambda (beg end) (unless (get-text-property =2D beg 'comint--fl-inhibit-fontification) + beg 'comint--fontify-input-inhibit-fontification) (font-lock-fontify-region beg end verbose))) beg end))) (`((jit-lock-bounds ,beg1 . ,_) . (jit-lock-bounds ,_ . ,end1)) diff --git a/lisp/ielm.el b/lisp/ielm.el index ad41cb1f6b..fd41afa243 100644 =2D-- a/lisp/ielm.el +++ b/lisp/ielm.el @@ -474,11 +474,11 @@ ielm-set-pm =20 ;;; Input fontification =20 =2D(defcustom ielm-comint-fl-enable t +(defcustom ielm-fontify-input-enable t "Enable fontification of input in ielm buffers. This variable only has effect when creating an ielm buffer. Use =2Dthe command `comint-fl-mode' to toggle fontification of input in =2Dan already existing ielm buffer." +the command `comint-fontify-input-mode' to toggle fontification +of input in an already existing ielm buffer." :type 'boolean :safe 'booleanp :version "29.1") @@ -556,8 +556,8 @@ inferior-emacs-lisp-mode :syntax-table emacs-lisp-mode-syntax-table :after-hook (and (null comint-use-prompt-regexp) =2D ielm-comint-fl-enable =2D (comint-fl-mode)) + ielm-fontify-input-enable + (comint-fontify-input-mode)) =20 (setq comint-prompt-regexp (concat "^" (regexp-quote ielm-prompt))) (setq-local paragraph-separate "\\'") diff --git a/lisp/shell.el b/lisp/shell.el index 18bb372242..641f274045 100644 =2D-- a/lisp/shell.el +++ b/lisp/shell.el @@ -308,10 +308,11 @@ shell-input-autoexpand (const :tag "on" t)) :group 'shell) =20 =2D(defcustom shell-comint-fl-enable t +(defcustom shell-fontify-input-enable t "Enable fontification of input in shell buffers. This variable only has effect when the shell is started. Use the =2Dcommand `comint-fl-mode' to toggle fontification of input." +command `comint-fontify-input-mode' to toggle fontification of +input." :type 'boolean :group 'shell :safe 'booleanp @@ -623,8 +624,8 @@ shell-mode :interactive nil :after-hook (unless comint-use-prompt-regexp =2D (if shell-comint-fl-enable =2D (comint-fl-mode)) + (if shell-fontify-input-enable + (comint-fontify-input-mode)) (if shell-highlight-undef-enable (shell-highlight-undef-mode))) =20 @@ -1664,8 +1665,8 @@ shell-highlight-undef-matcher (if buf (buffer-local-value 'default-directory buf) default-directory))) (cond =2D ;; Don't highlight command output. Mostly useful if =2D ;; `comint-fl-mode' is disabled. + ;; Don't fontify command output. Mostly useful if + ;; `comint-fontify-input-mode' is disabled. ((text-property-any beg (point) 'field 'output) nil) ((member cmd shell-highlight-undef-aliases) @@ -1696,7 +1697,7 @@ sh-other-keywords (define-minor-mode shell-highlight-undef-mode "Highlight undefined shell commands and aliases. This minor mode is mostly useful in `shell-mode' buffers and =2Dworks better if `comint-fl-mode' is enabled." +works better if `comint-fontify-input-mode' is enabled." :init-value nil (if shell--highlight-undef-indirect (progn @@ -1706,7 +1707,7 @@ shell-highlight-undef-mode (with-current-buffer buf (font-lock-remove-keywords nil shell-highlight-undef-keywords)= ))) (font-lock-remove-keywords nil shell-highlight-undef-keywords)) =2D (remove-hook 'comint-fl-mode-hook + (remove-hook 'comint-fontify-input-mode-hook #'shell-highlight-undef-mode-restart t) =20 (when shell-highlight-undef-mode @@ -1722,9 +1723,9 @@ shell-highlight-undef-mode (concat "\\(" "[;(){}`|&]" =2D (if comint-fl-mode =2D ;; `comint-fl-mode' already puts point-min on end of =2D ;; prompt + (if comint-fontify-input-mode + ;; `comint-fontify-input-mode' already puts + ;; point-min on end of prompt "" (concat "\\|" comint-prompt-regexp)) "\\|^" @@ -1740,7 +1741,7 @@ shell-highlight-undef-mode (lambda () (setq shell-highlight-undef-regexp regexp) (font-lock-add-keywords nil shell-highlight-undef-keywords t= )))) =2D (cond (comint-fl-mode + (cond (comint-fontify-input-mode (setq shell--highlight-undef-indirect setup) (if-let ((buf (comint-indirect-buffer t))) (with-current-buffer buf @@ -1748,7 +1749,7 @@ shell-highlight-undef-mode (add-hook 'comint-indirect-setup-hook setup nil t))) (t (funcall setup)))) =20 =2D (add-hook 'comint-fl-mode-hook + (add-hook 'comint-fontify-input-mode-hook #'shell-highlight-undef-mode-restart nil t)) =20 (font-lock-flush)) @@ -1756,9 +1757,9 @@ shell-highlight-undef-mode (defun shell-highlight-undef-mode-restart () "If `shell-highlight-undef-mode' is on, restart it. `shell-highlight-undef-mode' performs its setup differently =2Ddepending on `comint-fl-mode'. It's useful to call this function =2Dwhen switching `comint-fl-mode' in order to make =2D`shell-highlight-undef-mode' redo its setup." +depending on `comint-fontify-input-mode'. It's useful to call +this function when switching `comint-fontify-input-mode' in order +to make `shell-highlight-undef-mode' redo its setup." (when shell-highlight-undef-mode (shell-highlight-undef-mode 1))) =20 =2D-=20 2.37.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAEBCAAxFiEEmxVnesoT5rQXvVXnswkaGpIVmT8FAmM3QfMTHG1paGFAa2Ft bml0bmlrLnRvcAAKCRCzCRoakhWZP/NaEACZalaEIAFv2uadb8aITBzzzB89P8gH uI3PMlSiVBg+3M/SRxkmF0yAH0FPquODyDRa0hBYJOkNUHZ9IABdZRsMh43r64B3 HgM4UdlXhaKWoNHZmYTGOSGt+MeIY2Dq9/Klap2zgjuDlzkYNG2EFka5rrIBYPR/ 838q/yMYTjUJ3kj5mp+TQu3veiVW4lpssWZXbuijp77D2md6udU6M7XoPamhEeqM knQJwn1Q2ZtoCAO+UKHA3ZM8EVT/3Egf2+EmGZeABzZkTsLezhzLbIBjVWaIUoF0 KJaDeEI6cMGlrXPAhWKs/VdPMeIwOItdof1B5QK9kI2emjvIZQfe32i7CThEp428 6/+0GkF3IxTXyFVueQ5c8rc23LaCdva9C3DjfuxwH2owz0OWWMnSMaBDyqs2VpbV YOwEw/8Z821KOg25UcvfZ/rAncjKJ08HLZSeGsC7e8KjQFpw1+JSYBiO4Oklt0E5 pM4dmFo4ZWMSsPfnv1aX54DHKPco0Ju9GMCuHmkaql4INVYvbvkdAX4HWJV8/kOG EdWmhD5lUM+KvlBDc+5PQTcOgwA7Q1eXYtqBA6GWOKtJM+a6XTNk4zy4NOv1fEEN RpoLKofEtDZgd28Yw+LoBy/2HkH/l8816rATKxe4nT0igRjAy+zWzUrjY77MNXfs cMQjDWiCpeLXhg== =2hUJ -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 30 15:15:03 2022 Received: (at 58169) by debbugs.gnu.org; 30 Sep 2022 19:15:03 +0000 Received: from localhost ([127.0.0.1]:42976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeLTT-0008Fi-Ej for submit@debbugs.gnu.org; Fri, 30 Sep 2022 15:15:03 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeLTQ-0008Et-O5 for 58169@debbugs.gnu.org; Fri, 30 Sep 2022 15:15:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=C67TT85bu6x/ZZqngCYFaV5IT20/F29Rf2GSN4heV5k=; b=r2L2AbDmUpK09yH4E/uPJ8bi71 gt8oEnVbxjKNttivUtRLcxZoDKkrf/jjaMHtY9pzvsKOe5LaQRS/X0S7R8bp1KDIlYtp7y3kiuSbD pZtvVRqJ4v2tvLwfgx7YV2oDPwwX6Wd8+LKnEIZNQpBCStA5Y1HIbKKXFdmqj4oyx9iU=; Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oeLTH-0003PS-A4; Fri, 30 Sep 2022 21:14:53 +0200 From: Lars Ingebrigtsen To: Subject: Re: bug#58169: 29.0.50; comint-fl-mode fontifies the output In-Reply-To: <87leq0u0p8.fsf@miha-pc> (miha@kamnitnik.top's message of "Fri, 30 Sep 2022 21:22:27 +0200") References: <87h70qcfmt.fsf@gmail.com> <871qrt8w2s.fsf@gmail.com> <8735c976a6.fsf@miha-pc> <87edvt56e3.fsf@gnus.org> <87o7uwu2pt.fsf@miha-pc> <87a66g4t1s.fsf@gnus.org> <87leq0u0p8.fsf@miha-pc> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEVFOiGTciXGtELR 1J3///8VdpLZAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YJHhMOKARJiL8AAAGuSURBVDjLZZQBlsMg CERh9wJALhD1Ao3e/247jJo2XV5f++J3GCBaEc+QqJ+BBfHIX8P3WJEkCIqDxV7vWC8AiXNPabci wglKOCS1vRUL0L3eHr1kAiOAzRuMUmq0CUA8Qd3mS2EiAQmWNggCWLHmVllCj63Asilc2mfvhlm4 K6r6BJABIBEyYRBvACeT1cSMUnfhUBSCPofKiUZLgHJAaMItmWECw/Axfp1eJHUpTCyKxhyab9A6 albomL08AQRCResEwVRwtlrQe4JrKhpA0YKj0DotRt0mli+9rHJY9MqVYEZg1m66HsZJEByKj2xH b4W4/eQ82anokk+geUKyUnsAbKsE+XqUNjegIg+kxHoRCdR4PutgWdMmZCpy0NWPaz5m1VgUVowz YT5W5vmxSdD3gQQTZRy0wVyaH8PtCTxB+LhOJtAJUlA8eruaGIFT5vmV12u8LEHmJaD30XGjXqYW ecDd5St+Oo4mjkcxfQIdSQfwl+Z3nEh3jHYuoGsSvGm2VvgnsGbEu/6CcIx7u2apvNHXBjtdFso7 aOvpEfle0N/RvoHM5vRfi+/4A5hnX60xskv5AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTA5LTMw VDE5OjE0OjQwKzAwOjAw+aDz9QAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wOS0zMFQxOToxNDo0 MCswMDowMIj9S0kAAAAASUVORK5CYII= X-Now-Playing: DAF DOS's _Allein, zu zweit, mit telefon_: "Jesus Vs. Machiavelli" Date: Fri, 30 Sep 2022 21:14:48 +0200 Message-ID: <877d1kk72v.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: writes: > I originally thought that the function names could become too long. But > now I tried it and it's not so bad, so here are the revised patches > attached. Thanks; pushed to Emacs 29. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 58169 Cc: 58169@debbugs.gnu.org, Augusto Stoffel , Visuwesh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) writes: > I originally thought that the function names could become too long. But > now I tried it and it's not so bad, so here are the revised patches > attached. Thanks; pushed to Emacs 29. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 30 15:15:19 2022 Received: (at control) by debbugs.gnu.org; 30 Sep 2022 19:15:20 +0000 Received: from localhost ([127.0.0.1]:42979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeLTj-0008GG-N8 for submit@debbugs.gnu.org; Fri, 30 Sep 2022 15:15:19 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeLTi-0008G2-CX for control@debbugs.gnu.org; Fri, 30 Sep 2022 15:15:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+JmovvAeCjsYV/oI0I1uksw34ABzlVFgkmwdfcqg5r0=; b=qk/TTrHbq/2d325v0H4B4IP7EM MiHHG199mU9JewGrbeC4d4Z16BiMMI/MOt1u50+pKm51YGNcvmjmLnHHc8D2pd+YWtrj5Zq695zFg R+LvHLzmzu3E+xddnKxJuYG6Qb+lTj+/xbUsAsyg5yjiYevD8CDRMq6VXce+I03M8Eg8=; Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oeLTa-0003Pl-Fv for control@debbugs.gnu.org; Fri, 30 Sep 2022 21:15:12 +0200 Date: Fri, 30 Sep 2022 21:15:10 +0200 Message-Id: <875yh4k729.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #58169 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 58169 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 58169 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 01 10:43:20 2022 Received: (at 58169) by debbugs.gnu.org; 1 Oct 2022 14:43:20 +0000 Received: from localhost ([127.0.0.1]:45515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oedi3-0001Hp-RU for submit@debbugs.gnu.org; Sat, 01 Oct 2022 10:43:20 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:8885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oedi1-0001Hd-RU for 58169@debbugs.gnu.org; Sat, 01 Oct 2022 10:43:18 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7D408440C13; Sat, 1 Oct 2022 10:43:12 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0A5F1440714; Sat, 1 Oct 2022 10:43:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1664635391; bh=SGeFA/DnGZ3lM5kFksYpor2LKhxuzdu5VLvvs26rsLg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=HhNRfeTSh7qxT5/qX4TBm9zgk4Ph/TE3p5yrsMN/jtu6CiOp9QXdzHrtxKFRyLlJm WmoaArbNFcze7RqWSeYxQ59O699fOgkkRoaw2WfpO87MmHEG+b5Ufq4OvXgGgXOlxx dYEZaYkl7zkpBKcBqCbU3LKwV2hMJ3i3C+hMHpS0CStEOQyPjdcSih0kd6NdoZyOmk /qAid0K7NUizBY/Q8cAJIpzJCp4Ogb4NE0WIS45KRWOMujMqlRyTQpijKaCwP9gVGF OjFx+Rd27Qq6PtUtsyeIpFxVDgUPpgxUoM2HwgtVOWKiLhPuwVu1cMWv3EIODFthLG LZ/WTUJaIdLYA== Received: from pastel (65-110-220-202.cpe.pppoe.ca [65.110.220.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C82E7120744; Sat, 1 Oct 2022 10:43:10 -0400 (EDT) From: Stefan Monnier To: Subject: Re: bug#58169: 29.0.50; comint-fl-mode fontifies the output In-Reply-To: <87leq0u0p8.fsf@miha-pc> (miha@kamnitnik.top's message of "Fri, 30 Sep 2022 21:22:27 +0200") Message-ID: References: <87h70qcfmt.fsf@gmail.com> <871qrt8w2s.fsf@gmail.com> <8735c976a6.fsf@miha-pc> <87edvt56e3.fsf@gnus.org> <87o7uwu2pt.fsf@miha-pc> <87a66g4t1s.fsf@gnus.org> <87leq0u0p8.fsf@miha-pc> Date: Sat, 01 Oct 2022 10:43:09 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58169 Cc: 58169@debbugs.gnu.org, Lars Ingebrigtsen , Augusto Stoffel , Visuwesh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > @@ -2150,24 +2150,26 @@ comint-output-filter > ;; insert-before-markers is a bad thing. XXX > ;; Luckily we don't have to use it any more, we use > ;; window-point-insertion-type instead. > - (insert string) > + (make-local-variable 'jit-lock-mode) > + (let ((jit-lock-mode nil)) > + (insert string) Yuck! Oh, and this will fail to do what it intends if the user has set `font-lock-support-mode` t nil: don't confuse font-lock and jit-lock. Also, I suspect that the above is not sufficient if you edit earlier parts of the buffer (presumably previous inputs) which may cause later parts to be *re*fontified. A better way might be to change the font-lock rules to skip any text that is marked as being output (e.g. by testing if the `field` property is set to `output`). Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 06 14:23:50 2022 Received: (at 58169) by debbugs.gnu.org; 6 Oct 2022 18:23:50 +0000 Received: from localhost ([127.0.0.1]:33528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogVXC-0001HZ-4M for submit@debbugs.gnu.org; Thu, 06 Oct 2022 14:23:50 -0400 Received: from kamnitnik.top ([209.250.245.214]:55558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogVX7-0001HM-1J for 58169@debbugs.gnu.org; Thu, 06 Oct 2022 14:23:48 -0400 From: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kamnitnik.top; s=mail; t=1665080623; bh=V7nAa4Wu97ys9vdm8Oet9ejfWfrV/74HEqQAHprNA/k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=YAIXsnpVwAJe5yepTilnm6b80jhBO14NtLvkiGlsI3KAZoq/jgPz2WV1zY7l0Bj6n m18kk7YYDwVe2WdIEWV5XFmV0tXAhhtqcP1PJCGIJBXG1JmZDNbOvmO3ii5EmhJDVt Aapa8mfDsN1NS5cASAlwcIhUUaseRb4e8UrAnpZpLDttzZiA+vERHI9oGctG5AeMbn UsyOZN/3FAyX6GNxPA/lkwTVUbmd9cC9S3NS7NKSIy2eU8ayIJsBlvVLRnxRZkA6ey Y7aHE0NzBDKpwFt6W12mabEtODN7ZKiZbEvsBZzppan9g9ReJfTrwzETjmCeJpsUxU fsraB7yaJ1Hkw== To: Stefan Monnier Subject: Re: bug#58169: 29.0.50; comint-fl-mode fontifies the output In-Reply-To: References: <87h70qcfmt.fsf@gmail.com> <871qrt8w2s.fsf@gmail.com> <8735c976a6.fsf@miha-pc> <87edvt56e3.fsf@gnus.org> <87o7uwu2pt.fsf@miha-pc> <87a66g4t1s.fsf@gnus.org> <87leq0u0p8.fsf@miha-pc> Date: Thu, 06 Oct 2022 20:37:49 +0200 Message-ID: <871qrku7b6.fsf@miha-pc> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: >> @@ -2150, 24 +2150, 26 @@ comint-output-filter >> ;; insert-before-markers is a bad thing. XXX >> ; ; Luckily we don't have to use it any more, we use >> ; ; window-point-insertion-type instead. >> - ( [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: kamnitnik.top (top)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 FROM_SUSPICIOUS_NTLD From abused NTLD X-Debbugs-Envelope-To: 58169 Cc: 58169@debbugs.gnu.org, Lars Ingebrigtsen , Augusto Stoffel , Visuwesh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: >> @@ -2150,24 +2150,26 @@ comint-output-filter >> ;; insert-before-markers is a bad thing. XXX >> ;; Luckily we don't have to use it any more, we use >> ;; window-point-insertion-type instead. >> - ( [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: kamnitnik.top (top)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD 0.0 FROM_SUSPICIOUS_NTLD From abused NTLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --=-=-= Content-Type: text/plain Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: >> @@ -2150,24 +2150,26 @@ comint-output-filter >> ;; insert-before-markers is a bad thing. XXX >> ;; Luckily we don't have to use it any more, we use >> ;; window-point-insertion-type instead. >> - (insert string) >> + (make-local-variable 'jit-lock-mode) >> + (let ((jit-lock-mode nil)) >> + (insert string) > > Yuck! > Oh, and this will fail to do what it intends if the user has set > `font-lock-support-mode` t nil: don't confuse font-lock and jit-lock. > > Also, I suspect that the above is not sufficient if you edit earlier > parts of the buffer (presumably previous inputs) which may cause later > parts to be *re*fontified. > > A better way might be to change the font-lock rules to skip any text > that is marked as being output (e.g. by testing if the `field` property > is set to `output`). > > > Stefan Thanks for feedback, discussion continued at https://lists.gnu.org/r/emacs-devel/2022-10/msg00005.html. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAEBCAAxFiEEmxVnesoT5rQXvVXnswkaGpIVmT8FAmM/IH0THG1paGFAa2Ft bml0bmlrLnRvcAAKCRCzCRoakhWZP5qbD/4jfdbuWybyKdshqgZ6r4A2epLZrD7q GFqwEdMa9th6lKn0quKM7bdkgZ0VuGWmYpFLbvQmtdDs3x/iqFGDREwTzNeBG+98 H9avHxT7aRaeUJavQPcS/2E0TMEGmsNLVqC97yvw1lFfs5sgVDHSLTiBGuz6ZHlO uNHF/BC8ZFT1xD4cut7DqbR3t4J9gETueGLwxWBwIUTffZOavXA4W5y4T8iYVUdV TnzEE1yJW1DLf8uBZqzG8vC0ISXZJKA6i1kGVW1RQxAnDZVYBgt66Kw/QG0HERFd /2I3IFQFLxpm845K5xblc/lnX4uLnWP+5jhcKDUjvptbVRJCYY+MUird5vzAV/Ma OvJRrYTM8eDRTaS30lijZLeSsIdsMK4SFrV631awyv6An9dpl1cdJxAhH+P373Qm VmVlilS9otzEA9duumkhwKY+xaFJhfKXPyLO2mHSr3Y/HCRPHrsjcZST6GcU/g0p E6Y3thyW1TAcQyVPAx+YkycTiOp1d7kx3wA5uZg0pu44yILXayAM73J9lqg33dOG bom+PB8jUFWETfLRu8WcLr7frEKYBLdtq/dg2y7QBHOtGS1NiofvJLevx8qeceJc +yHh6wnR8LPLSsEcplp+KzFlgV4HzFodjXaayWN+lOc7k6BINJDgG5z0BOwmW+X7 kdWbCo4aM2g4ZA== =25Bi -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jul 20 09:47:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 04 Nov 2022 11:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator