GNU bug report logs - #58165
[Patch] [GNU ELPA] rcirc-color: Allow recoloring nicks

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#58165: closed ([Patch] [GNU ELPA] rcirc-color: Allow
 recoloring nicks)
Date: Fri, 30 Sep 2022 11:25:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 30 Sep 2022 11:24:23 +0000
with message-id <87a66hxfyw.fsf <at> posteo.net>
and subject line Re: bug#58165: [Patch] [GNU ELPA] rcirc-color: Allow recoloring nicks
has caused the debbugs.gnu.org bug report #58165,
regarding [Patch] [GNU ELPA] rcirc-color: Allow recoloring nicks
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
58165: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58165
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Thuna <thuna.cing <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [Patch] [GNU ELPA] rcirc-color: Allow recoloring nicks
Date: Thu, 29 Sep 2022 16:58:21 +0200

[Message part 3 (text/plain, inline)]

I think rcirc-color should allow a nick to be "recolored" with the
command `/color nick', instead of signalling an error as it does now.

This is useful, for example, when two similar nicks are assigned the
same color but there's no specific color you want to reassign to either
of them.

[0001-rcirc-color-Select-a-random-color-on-color-nick.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Philip Kaludercic <philipk <at> posteo.net>
To: Thuna <thuna.cing <at> gmail.com>
Cc: 58165-done <at> debbugs.gnu.org
Subject: Re: bug#58165: [Patch] [GNU ELPA] rcirc-color: Allow recoloring nicks
Date: Fri, 30 Sep 2022 11:24:23 +0000

Thuna <thuna.cing <at> gmail.com> writes:

>> While at it one could replace the `foreground-color', since (elisp)
>> Special Properties says:
>>
>>         • A cons cell of the form ‘(foreground-color . COLOR-NAME)’ or
>>           ‘(background-color . COLOR-NAME)’.  This specifies the
>>           foreground or background color, similar to ‘(:foreground
>>           COLOR-NAME)’ or ‘(:background COLOR-NAME)’.  This form is
>>           supported for backward compatibility only, and should be
>>           avoided.
>
> I avoided it on the off chance something would break, but I don't mind
> either way.

I think I can do this.

>> Also, it would be nice to also reformat the code using a let* block.
>> Something like
>>
>>         (let* ((index (random (length rcirc-colors)))
>>                (color (elt rcirc-colors index))
>>                (face (cons 'foreground-color color)))
>>           (puthash nick face rcirc-color-mapping))
>
> Seems ok to me.

I'll pull your patch and make this change in a subsequent commit.

So thank you for the patch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.