GNU bug report logs - #58162
[PATCH] gnu: Add qdmr

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58162 in the body.
You can then email your comments to 58162 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ryan Tolboom <ryan <at> using.tech>
To: guix-patches <at> gnu.org
Cc: Ryan Tolboom <ryan <at> using.tech>
Subject: [PATCH] gnu: Add qdmr
Date: Wed, 28 Sep 2022 21:57:26 -0400

---
 gnu/packages/radio.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/radio.scm b/gnu/packages/radio.scm
index 2968f9d390..72a8b726e5 100644
--- a/gnu/packages/radio.scm
+++ b/gnu/packages/radio.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan <at> gmail.com>
 ;;; Copyright © 2022 Sheng Yang <styang <at> fastmail.com>
 ;;; Copyright © 2022 Greg Hogan <code <at> greghogan.com>
+;;; Copyright © 2022 Ryan Tolboom <ryan <at> using.tech>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -89,6 +90,7 @@ (define-module (gnu packages radio)
   #:use-module (gnu packages readline)
   #:use-module (gnu packages ruby)
   #:use-module (gnu packages sdl)
+  #:use-module (gnu packages serialization)
   #:use-module (gnu packages sphinx)
   #:use-module (gnu packages swig)
   #:use-module (gnu packages tcl)
@@ -2668,3 +2670,42 @@ (define-public gnss-sdr
 position fixes) the signals of the BeiDou, Galileo, GLONASS and GPS Global
 Navigation Satellite System.")
     (license license:gpl3+)))
+
+(define-public qdmr
+  (package
+    (name "qdmr")
+    (version "0.10.3")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                     (url "https://github.com/hmatuschek/qdmr")
+                     (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "037vkwk974zrwacxafslkb3mbw9258v9sdpwdvb23msjzbc3snrn"))))
+    (build-system cmake-build-system)
+    (native-inputs (list qttools-5))
+    (inputs (list qtbase-5 qtserialport qtlocation yaml-cpp libusb))
+    (arguments
+     `(#:tests? #f ;No tests
+       #:phases (modify-phases %standard-phases
+                  (add-after 'unpack 'fix-paths
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (substitute* "lib/CMakeLists.txt"
+                        (("DESTINATION \"/etc/udev/")
+                         (string-append "DESTINATION \""
+                                        (assoc-ref outputs "out") "/lib/udev/"))))))))
+    (synopsis "GUI application and command line tool to program DMR radios")
+    (description
+     "qdmr is a graphical user interface (GUI) application that allows one to
+program several types of DMR radios.  To this end, it aims at being a more
+universal codeplug programming software (CPS) compared to the device and even
+revision specific CPSs provided by the manufacturers.  The goal of this project
+is to provide a single, comfortable, well-documented and platform-independent
+CPS for several types of (mainly Chinese) DMR radios.
+
+To install the qdmr udev rules, you must extend @code{udev-service-type} with this
+package.  E.g.: @code{(udev-rules-service 'qdmr qdmr)}")
+    (home-page "https://dm3mat.darc.de/qdmr/")
+    (license license:gpl3+)))
-- 
2.37.3

Message #8 received at 58162 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Ryan Tolboom" <ryan <at> using.tech>, <58162 <at> debbugs.gnu.org>
Subject: Re: [bug#58162] [PATCH] gnu: Add qdmr
Date: Thu, 29 Sep 2022 18:50:57 +0100

Hey!

On Thu Sep 29, 2022 at 2:57 AM BST, Ryan Tolboom wrote:
> +    (native-inputs (list qttools-5))
> +    (inputs (list qtbase-5 qtserialport qtlocation yaml-cpp libusb))

Usually inputs and native-inputs come after arguments.

> +    (arguments
> +     `(#:tests? #f ;No tests
> +       #:phases (modify-phases %standard-phases
> +                  (add-after 'unpack 'fix-paths
> +                    (lambda* (#:key outputs #:allow-other-keys)
> +                      (substitute* "lib/CMakeLists.txt"
> +                        (("DESTINATION \"/etc/udev/")
> +                         (string-append "DESTINATION \""
> +                                        (assoc-ref outputs "out") "/lib/udev/"))))))))

Try using the new gexp style for arguments:

  (arguments
   (list #:tests? #f ;no tests
         #:phases
         #~(modify-phases %standard-phases
             (add-after 'unpack 'patch-paths
               (lambda _
                 (substitute* "lib/CMakeLists.txt"
                   (("(DESTINATION \")/etc/udev/" _ directive)
                    (string-append directive #$output "/lib/udev/"))))))))

> +    (description
> +     "qdmr is a graphical user interface (GUI) application that allows one to
> +program several types of DMR radios.  To this end, it aims at being a more
> +universal codeplug programming software (CPS) compared to the device and even
> +revision specific CPSs provided by the manufacturers.  The goal of this project
> +is to provide a single, comfortable, well-documented and platform-independent
> +CPS for several types of (mainly Chinese) DMR radios.
> +
> +To install the qdmr udev rules, you must extend @code{udev-service-type} with this
> +package.  E.g.: @code{(udev-rules-service 'qdmr qdmr)}")

IMO this is too long and markety :) Also, I don't think you should mention
services in a package description.

> +    (home-page "https://dm3mat.darc.de/qdmr/")

Home-page usually goes directly before synopsis.

    -- (

Message #11 received at 58162 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Tolboom <ryan <at> using.tech>
To: 58162 <at> debbugs.gnu.org
Cc: Ryan Tolboom <ryan <at> using.tech>
Subject: [PATCH] gnu: Add qdmr
Date: Thu, 29 Sep 2022 17:12:20 -0400

---
 gnu/packages/radio.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/radio.scm b/gnu/packages/radio.scm
index 2968f9d390..5237d48fbe 100644
--- a/gnu/packages/radio.scm
+++ b/gnu/packages/radio.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan <at> gmail.com>
 ;;; Copyright © 2022 Sheng Yang <styang <at> fastmail.com>
 ;;; Copyright © 2022 Greg Hogan <code <at> greghogan.com>
+;;; Copyright © 2022 Ryan Tolboom <ryan <at> using.tech>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -89,6 +90,7 @@ (define-module (gnu packages radio)
   #:use-module (gnu packages readline)
   #:use-module (gnu packages ruby)
   #:use-module (gnu packages sdl)
+  #:use-module (gnu packages serialization)
   #:use-module (gnu packages sphinx)
   #:use-module (gnu packages swig)
   #:use-module (gnu packages tcl)
@@ -2668,3 +2670,40 @@ (define-public gnss-sdr
 position fixes) the signals of the BeiDou, Galileo, GLONASS and GPS Global
 Navigation Satellite System.")
     (license license:gpl3+)))
+
+(define-public qdmr
+  (package
+    (name "qdmr")
+    (version "0.10.3")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                     (url "https://github.com/hmatuschek/qdmr")
+                     (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "037vkwk974zrwacxafslkb3mbw9258v9sdpwdvb23msjzbc3snrn"))))
+    (build-system cmake-build-system)
+    (arguments
+     (list #:tests? #f ;no tests
+           #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'patch-paths
+                 (lambda _
+                   (substitute* "lib/CMakeLists.txt"
+                     (("(DESTINATION \")/etc/udev/" _ directive)
+                      (string-append directive #$output "/lib/udev/"))))))))
+    (inputs (list qtbase-5 qtserialport qtlocation yaml-cpp libusb))
+    (native-inputs (list qttools-5))
+    (home-page "https://dm3mat.darc.de/qdmr/")
+    (synopsis "GUI application and command line tool to program DMR radios")
+    (description
+     "qdmr is a graphical user interface (GUI) application that allows one to
+program several types of DMR radios.  It is comparable to the Customer
+Programming Software (CPS) bundled with these radios but aims to be a more
+universal tool.
+
+To install the qdmr udev rules, you must extend @code{udev-service-type} with this
+package.  E.g.: @code{(udev-rules-service 'qdmr qdmr)}")
+    (license license:gpl3+)))
-- 
2.37.3

Message #14 received at 58162 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Tolboom <ryan <at> using.tech>
To: "(" <paren <at> disroot.org>
Cc: 58162 <at> debbugs.gnu.org
Subject: Re: [bug#58162] [PATCH] gnu: Add qdmr
Date: Thu, 29 Sep 2022 17:20:16 -0400

Hello,

Thank you very much for your comments! I apologize for my brevity, I'm
still trying to work out the whole 'git send-email' workflow so my
patches arrive without comments. I did leave some comments through the
web interface, but I'm not seeing them show up.

I was using the 'Hello World' package example initially:
https://guix.gnu.org/cookbook/en/html_node/A-_0060_0060Hello-World_0027_0027-package.html
Do you think I should submit a patch to move home-page to the correct
place in that example?

Regarding the description, I was on the fence about it. I took it from
the GitHub page for the project and wasn't quite sure if it was too
wordy. Also regarding mentioning services in the description, several
other packages in radio.scm do it as well: rtl-sdr, airspyhf, hackrf,
and rfcat. I actually found it quite useful when setting things up,
does it have to be removed?

Anyway the new patch implements all your changes, which BTW
g-expressions are really neat, with the exception of removing the
service line from the description.

Let me know your thoughts,

Ryan


On Thu, Sep 29, 2022 at 1:51 PM ( <paren <at> disroot.org> wrote:
>
> Hey!
>
> On Thu Sep 29, 2022 at 2:57 AM BST, Ryan Tolboom wrote:
> > +    (native-inputs (list qttools-5))
> > +    (inputs (list qtbase-5 qtserialport qtlocation yaml-cpp libusb))
>
> Usually inputs and native-inputs come after arguments.
>
> > +    (arguments
> > +     `(#:tests? #f ;No tests
> > +       #:phases (modify-phases %standard-phases
> > +                  (add-after 'unpack 'fix-paths
> > +                    (lambda* (#:key outputs #:allow-other-keys)
> > +                      (substitute* "lib/CMakeLists.txt"
> > +                        (("DESTINATION \"/etc/udev/")
> > +                         (string-append "DESTINATION \""
> > +                                        (assoc-ref outputs "out") "/lib/udev/"))))))))
>
> Try using the new gexp style for arguments:
>
>   (arguments
>    (list #:tests? #f ;no tests
>          #:phases
>          #~(modify-phases %standard-phases
>              (add-after 'unpack 'patch-paths
>                (lambda _
>                  (substitute* "lib/CMakeLists.txt"
>                    (("(DESTINATION \")/etc/udev/" _ directive)
>                     (string-append directive #$output "/lib/udev/"))))))))
>
> > +    (description
> > +     "qdmr is a graphical user interface (GUI) application that allows one to
> > +program several types of DMR radios.  To this end, it aims at being a more
> > +universal codeplug programming software (CPS) compared to the device and even
> > +revision specific CPSs provided by the manufacturers.  The goal of this project
> > +is to provide a single, comfortable, well-documented and platform-independent
> > +CPS for several types of (mainly Chinese) DMR radios.
> > +
> > +To install the qdmr udev rules, you must extend @code{udev-service-type} with this
> > +package.  E.g.: @code{(udev-rules-service 'qdmr qdmr)}")
>
> IMO this is too long and markety :) Also, I don't think you should mention
> services in a package description.
>
> > +    (home-page "https://dm3mat.darc.de/qdmr/")
>
> Home-page usually goes directly before synopsis.
>
>     -- (



-- 
Ryan Tolboom
Using Tech LLC

Message #17 received at 58162 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Ryan Tolboom" <ryan <at> using.tech>, <58162 <at> debbugs.gnu.org>
Subject: Re: [bug#58162] [PATCH] gnu: Add qdmr
Date: Thu, 29 Sep 2022 22:21:58 +0100

v2 LGTM :)

    -- (

Message #22 received at 58162-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Ryan Tolboom <ryan <at> using.tech>
Cc: "\(" <paren <at> disroot.org>, 58162-done <at> debbugs.gnu.org
Subject: Re: [bug#58162] [PATCH] gnu: Add qdmr
Date: Fri, 30 Sep 2022 10:56:20 +0000

[Message part 1 (text/plain, inline)]

Patch pushed as df485be2f7d939b5c2b83a3a467cdff4d5a93851 with
a completed commit message.
Thanks.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.