GNU bug report logs - #58141
[Eglot] Default eglot-diagnostic-tag-unnecessary-face is problematic

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Augusto Stoffel <arstoffel <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [Eglot] Default eglot-diagnostic-tag-unnecessary-face is problematic
Date: Wed, 28 Sep 2022 13:39:25 +0200

[Message part 1 (text/plain, inline)]

Or at least I really dislike the default value, which looks like this:

[Screenshot from 2022-09-28 13-16-40.png (image/png, inline)]

[Message part 3 (text/plain, inline)]

When I first saw this face appearing, I had no idea what was going on.
That this is a Flymake warning is unexpected, since there's nothing
squiggly about it.  Moreover, it overrides all other font-locking, which
presumably still has meaningful information.  Finally, I think it's hard
to be sure the result is readable in all custom themes, even all
reasonable ones.

In general, I would argue that “creative” decorations should be left off
by default.  So concretely in this case my suggestion would be to let
eglot-diagnostic-*-face inherit from one of the good old Flymake faces.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.