Subject: Re: bug#58141: [Eglot] Default eglot-diagnostic-tag-unnecessary-face is problematic'

From: Augusto Stoffel <[email-masked]>
Date: Thu, 23 Feb 2023 19:55:20 +0100

On Thu, 23 Feb 2023 at 11:59, João Távora wrote:

> I'm not a fan of hardcoding colors in Eglot, since that needs themes
> to update for the new face.  Supporting the optional underline is
> probably fine, though.

Okay, but the current choice (inherit from shadow) is also not a safe
one with respect to themes.  So I'd say the next best thing is to make
that face inherit from flymake-note or flymake-warning.