Subject: Re: bug#58141: [Eglot] Default eglot-diagnostic-tag-unnecessary-face is problematic'

From: Augusto Stoffel <[email-masked]>
Date: Sat, 18 Feb 2023 16:00:45 +0100

This was a while back, but in any case this is my suggestion for this
face.  I haven't seen eglot-diagnostic-tag-deprecated-face appear in
nature so I'm not sure how well it works.

>From 0772f1b46af4e1745d417db0a62b6de64575face Mon Sep 17 00:00:00 2001
From: Augusto Stoffel <[email-masked]>
Date: Sat, 18 Feb 2023 15:58:23 +0100
Subject: [PATCH] Improve eglot-diagnostic-tag-unnecessary-face

* progmodes/elgot.el (eglot-diagnostic-tag-unnecessary-face): Use wavy
underline, as in all other Flymake faces.
---
 lisp/progmodes/eglot.el | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 6d192d9b333..8075412411e 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -324,7 +324,10 @@ eglot-mode-line
   "Face for package-name in Eglot's mode line.")
 
 (defface eglot-diagnostic-tag-unnecessary-face
-  '((t (:inherit shadow)))
+  '((((supports :underline (:style wave)))
+     :underline (:style wave :color "gray"))
+    (t
+     :inherit flymake-note))
   "Face used to render unused or unnecessary code.")
 
 (defface eglot-diagnostic-tag-deprecated-face
-- 
2.39.2