From unknown Sun Aug 17 04:16:18 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#58131 <58131@debbugs.gnu.org> To: bug#58131 <58131@debbugs.gnu.org> Subject: Status: [PATCH] docview: new customization options for imenu Reply-To: bug#58131 <58131@debbugs.gnu.org> Date: Sun, 17 Aug 2025 11:16:18 +0000 retitle 58131 [PATCH] docview: new customization options for imenu reassign 58131 emacs submitter 58131 Jose A Ortega Ruiz severity 58131 normal tag 58131 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 27 22:21:40 2022 Received: (at submit) by debbugs.gnu.org; 28 Sep 2022 02:21:40 +0000 Received: from localhost ([127.0.0.1]:57097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odMhf-00008K-Rw for submit@debbugs.gnu.org; Tue, 27 Sep 2022 22:21:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:50422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odMhd-000082-8x for submit@debbugs.gnu.org; Tue, 27 Sep 2022 22:21:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odMhd-0008Io-46 for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 22:21:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35656) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odMhc-0003Ti-7M; Tue, 27 Sep 2022 22:21:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=kkP+eRc81JLwcNV4jdf336qFvGrlnbF1RggPjvwqncM=; b=jQAbVSL8eNsXUk uxWTj6Mf/f+jyJ9BlP5ivzxTfnvup8kysfBHkhYbkXa8otOaXvQBHmF9cL0AkSuzFG2eUSmGHvBgr dcbH3qxBSFiycRwhXaWswHImtvkqWb8iFVUGr1oiHNCLWYPFjsdpNYMHTehxq9vkYMc/p7Zw7wBvr JJU9StlAU922Bq39fazZlP6xquoFseRiYV7IYenqbUXf3gV0lGDhLpgfgZYi9w45Y8EnO6SxmetZk EZu10H6xfbV4WIHxWGxwzGwEtWt/1CotMOzPlwlA3moGrnSCaCBHRUFPQzfzdWAw5ql9P8/KEHfg7 ETg1xgnlKVOZ/S8iBFfQ==; Received: from cpc103048-sgyl39-2-0-cust502.18-2.cable.virginm.net ([92.233.85.247]:59948 helo=rivendell.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odMhb-0006lX-T0; Tue, 27 Sep 2022 22:21:36 -0400 Received: from localhost (rivendell.localdomain [local]) by rivendell.localdomain (OpenSMTPD) with ESMTPA id 7acfdc48; Wed, 28 Sep 2022 02:21:31 +0000 (UTC) From: Jose A Ortega Ruiz To: bug-gnu-emacs@gnu.org Subject: [PATCH] docview: new customization options for imenu X-Attribution: jao X-Clacks-Overhead: GNU Terry Pratchett X-URL: Date: Wed, 28 Sep 2022 03:21:31 +0100 Message-ID: <87fsgcb5n8.fsf@mail.jao.io> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Tags: patch A follow up to bug#58103 with a little fix for section title extraction and a couple of easy to implement customizable options. I've tried to document them clearly enough in the docstrings and then just mention their existence in the manual: is that a good practice or do we prefer some duplication? Cheers, jao In GNU Emacs 29.0.50 (build 20, x86_64-pc-linux-gnu, cairo version 1.16.0) of 2022-09-27 built on rivendell Repository revision: 7368cdd359325cb6ed83688178ae4b4eaf22f4d5 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Debian GNU/Linux bookworm/sid Configured using: 'configure --prefix=/usr/local/stow/emacs29 --with-x-toolkit=no --with-imagemagick -C' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-docview-new-customization-options-for-imenu.patch >From a434024c4e452b4f2495921832b00e801568939e Mon Sep 17 00:00:00 2001 From: Jose A Ortega Ruiz Date: Wed, 28 Sep 2022 03:02:57 +0100 Subject: [PATCH] docview: new customization options for imenu * doc/emacs/misc.texi (DocView Navigation): * lisp/doc-view.el (doc-view-imenu-title-format, doc-view-imenu-flatten): (doc-view--imenu-subtree): customizable format for imenu entry titles, and flag to disable nested submenus. * lisp/doc-view.el (doc-view--pdf-outline): clean up whitespace markers '\r' and '\t' in imenu item titles. --- doc/emacs/misc.texi | 9 +++++++-- lisp/doc-view.el | 29 +++++++++++++++++++++++++---- 2 files changed, 32 insertions(+), 6 deletions(-) diff --git a/doc/emacs/misc.texi b/doc/emacs/misc.texi index 04f7f2e921..cef2580f3b 100644 --- a/doc/emacs/misc.texi +++ b/doc/emacs/misc.texi @@ -585,11 +585,16 @@ DocView Navigation @code{doc-view-resolution}. @vindex doc-view-imenu-enabled +@vindex doc-view-imenu-flatten +@vindex doc-view-imenu-format When the @command{mutool} program is available, DocView will use it to generate entries for an outline menu, making it accessible via the @code{imenu} facility (@pxref{Imenu}). To disable this functionality -even when @command{mutool} can be found on your system, customize -the variable @code{doc-view-imenu-enabled} to the @code{nil} value. +even when @command{mutool} can be found on your system, customize the +variable @code{doc-view-imenu-enabled} to the @code{nil} value. You +can further customize how @code{imenu} items are formatted and +displayed using the variables @code{doc-view-imenu-format} and +@code{doc-view-flatten}. @node DocView Searching @subsection DocView Searching diff --git a/lisp/doc-view.el b/lisp/doc-view.el index fa583df12b..9e3bb6e46c 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -219,6 +219,23 @@ doc-view-imenu-enabled :type 'boolean :version "29.1") +(defcustom doc-view-imenu-title-format "%t (%p)" + "Format string for document section titles in imenu. + +The special markers '%t' and '%p' are replaced by the section +title and page number in this format string, which uses +`format-spec'. + +For instance, setting this variable to \"%t\" will produce items +showing only titles and no page number." + :type 'string + :version "29.1") + +(defcustom doc-view-imenu-flatten nil + "Whether to generate a flat list of sections instead of a nested tree." + :type 'boolean + :version "29.1") + (defcustom doc-view-svg-background "white" "Background color for svg images. See `doc-view-mupdf-use-svg'." @@ -1898,7 +1915,8 @@ doc-view--pdf-outline (goto-char (point-min)) (while (re-search-forward doc-view--outline-rx nil t) (push `((level . ,(length (match-string 1))) - (title . ,(match-string 2)) + (title . ,(replace-regexp-in-string "\\\\[rt]" " " + (match-string 2))) (page . ,(string-to-number (match-string 3)))) outline))) (nreverse outline))) @@ -1911,11 +1929,14 @@ doc-view--imenu-subtree level. Returns that imenu alist together with any other pending outline entries at an upper level." (let ((level (alist-get 'level (car outline))) + (nested (not doc-view-imenu-flatten)) (index nil)) - (while (and (car outline) (<= level (alist-get 'level (car outline)))) + (while (and (car outline) + (or nested (<= level (alist-get 'level (car outline))))) (let-alist (car outline) - (let ((title (format "%s (%s)" .title .page))) - (if (> .level level) + (let ((title (format-spec doc-view-imenu-title-format + `((?t . ,.title) (?p . ,.page))))) + (if (and nested (> .level level)) (let ((sub (doc-view--imenu-subtree outline act)) (fst (car index))) (setq index (cdr index)) -- 2.37.2 --=-=-= Content-Type: text/plain -- Too often we enjoy the comfort of opinion without the discomfort of thought. -John F. Kennedy, 35th US president (1917-1963) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 07:08:43 2022 Received: (at 58131) by debbugs.gnu.org; 28 Sep 2022 11:08:43 +0000 Received: from localhost ([127.0.0.1]:60352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odUvj-000414-8x for submit@debbugs.gnu.org; Wed, 28 Sep 2022 07:08:43 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odUvh-00040n-CO for 58131@debbugs.gnu.org; Wed, 28 Sep 2022 07:08:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fassjvFqBU6fe9nplSEtn3HN4QSgJuPu6YYHfKs+zkw=; b=M/b0X26QGzTR2uV+YHCmC5h2DK 8Ksbg/MN0PjjH5HUb0DzPSGgqURJ/0LCWWbQxGewwC4ebj2ucTm70Dmwgiwi5q629PaAocZjgSb4P qFMLyl9u1cidVeEEFNjtbpGqEzdupWC2ktyxu68Hj3jdznRUzsMySnliLhCDUjkFpev8=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odUvZ-00032J-AA; Wed, 28 Sep 2022 13:08:35 +0200 From: Lars Ingebrigtsen To: Jose A Ortega Ruiz Subject: Re: bug#58131: [PATCH] docview: new customization options for imenu In-Reply-To: <87fsgcb5n8.fsf@mail.jao.io> (Jose A. Ortega Ruiz's message of "Wed, 28 Sep 2022 03:21:31 +0100") References: <87fsgcb5n8.fsf@mail.jao.io> X-Now-Playing: Julie Driscoll's _1969_: "Those That We Love" Date: Wed, 28 Sep 2022 13:08:30 +0200 Message-ID: <87v8p7ycwh.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Jose A Ortega Ruiz writes: > A follow up to bug#58103 with a little fix for section title extraction > and a couple of easy to implement customizable options. I've tried to > document them clearly enough in the docstrings and t [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58131 Cc: 58131@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jose A Ortega Ruiz writes: > A follow up to bug#58103 with a little fix for section title extraction > and a couple of easy to implement customizable options. I've tried to > document them clearly enough in the docstrings and then just mention > their existence in the manual: is that a good practice or do we prefer > some duplication? It varies -- we don't want the manual to grow unbounded, so sometimes we just mention variables if they're auxiliary things like this. So I think you have the right balance here, and I pushed it to Emacs 29. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 07:08:49 2022 Received: (at control) by debbugs.gnu.org; 28 Sep 2022 11:08:49 +0000 Received: from localhost ([127.0.0.1]:60355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odUvo-00041O-H1 for submit@debbugs.gnu.org; Wed, 28 Sep 2022 07:08:48 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odUvl-00040u-RH for control@debbugs.gnu.org; Wed, 28 Sep 2022 07:08:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TsNmzT3cA9aiecXFmvQM4hnEwWH8177wz5Eaws0fXvI=; b=qoyYoQFUsP7eax8dREett+0cf+ NwqlrzBCEMGUB3Cpy2p5kbqgHU9C8einFyQFhZImAcfoxA9v2Rz7KYh7DAzhpIXq6HxEer5s9ZWNg 7UkbrqAsvmzN74xMUJa/iJGsZU7mx6+0JdPCeLqoFcqhesLdK3wnschViisLVXLWfmII=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odUve-00032Q-7m for control@debbugs.gnu.org; Wed, 28 Sep 2022 13:08:40 +0200 Date: Wed, 28 Sep 2022 13:08:37 +0200 Message-Id: <87tu4rycwa.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #58131 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 58131 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 58131 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 08:34:14 2022 Received: (at 58131) by debbugs.gnu.org; 28 Sep 2022 12:34:14 +0000 Received: from localhost ([127.0.0.1]:60479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odWGT-0002Ar-QN for submit@debbugs.gnu.org; Wed, 28 Sep 2022 08:34:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odWGS-0002Af-Nx for 58131@debbugs.gnu.org; Wed, 28 Sep 2022 08:34:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34358) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odWGM-0007H6-Fd; Wed, 28 Sep 2022 08:34:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=n/14BZOB5zQXNCQag5uih47/eUI35Z4DnjD3jKfDS7A=; b=ICIVN0Q1y1Nn WXaSCeHLQznPAOqldZyCmbiceEIO7zLzxoaAY92YkJfpgNeMMl7H21IBaIXwxxxnqfIHrSIJvzeou d4M5aQXNMIma+kLbsL7RkApD+pOMrE+Mnnx5ZB/NyjYzAItPN0OQ/a4n8wJuDiTe/iCqdkFxzx4JW GPROFtn8D6BIIVAQhN7Yf/7m1EQ8ve7yeebZO4amIQl4+jkEJJCPL4CFgYaBfTmhug0OFDVU5hpIc vSDysbDPce5Jyqpz67N3uVVGoptieRof4NQgIg2Pwk2a1zhcyDVc3EQ7sQRAqeQQZlqqyOCm7k3Db 9YyBVtXwZZoFSdBEYWX/wA==; Received: from [87.69.77.57] (port=4789 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odWGL-0006aw-GY; Wed, 28 Sep 2022 08:34:05 -0400 Date: Wed, 28 Sep 2022 15:34:01 +0300 Message-Id: <83k05nisp2.fsf@gnu.org> From: Eli Zaretskii To: Jose A Ortega Ruiz In-Reply-To: <87fsgcb5n8.fsf@mail.jao.io> (message from Jose A Ortega Ruiz on Wed, 28 Sep 2022 03:21:31 +0100) Subject: Re: bug#58131: [PATCH] docview: new customization options for imenu References: <87fsgcb5n8.fsf@mail.jao.io> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58131 Cc: 58131@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jose A Ortega Ruiz > Date: Wed, 28 Sep 2022 03:21:31 +0100 > > A follow up to bug#58103 with a little fix for section title extraction > and a couple of easy to implement customizable options. I've tried to > document them clearly enough in the docstrings and then just mention > their existence in the manual: is that a good practice or do we prefer > some duplication? It's a possibility. But if you have nothing of essence to say about a variable, why mention it in the manual at all? We don't need to mention every user option in the manual, only the important ones. We expect users who want to use a package to review its options (e.g., bu "M-x customize-group") and decide which ones they want to change from the default. > +(defcustom doc-view-imenu-title-format "%t (%p)" > + "Format string for document section titles in imenu. > + > +The special markers '%t' and '%p' are replaced by the section > +title and page number in this format string, which uses > +`format-spec'. Will users immediately understand what you mean by "document section title" here? If no, perhaps a sentence explaining what that is would be beneficial. > +(defcustom doc-view-imenu-flatten nil > + "Whether to generate a flat list of sections instead of a nested tree." This doesn't mention imenu in the doc string; should it? From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 10:06:19 2022 Received: (at 58131) by debbugs.gnu.org; 28 Sep 2022 14:06:19 +0000 Received: from localhost ([127.0.0.1]:34026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odXhb-0007Az-5O for submit@debbugs.gnu.org; Wed, 28 Sep 2022 10:06:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odXhY-0007Am-SF for 58131@debbugs.gnu.org; Wed, 28 Sep 2022 10:06:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50152) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odXhT-0007mR-BP for 58131@debbugs.gnu.org; Wed, 28 Sep 2022 10:06:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=qoit3BiOtGD2VLVpZ2ytcOQLJOftK6nLClGt+XG1WjY=; b=j2YXDyrMKYxfWQmg6aJq OpvHvzGqsBEjQzScUfYlmYB1AMFij5XN3qisOrVUd9eHx0Zk25aDLbCYzGsriT1lUpVKk/EBKBfrA KoQFs1PBhsFTMk3pmg9Op2weUR2Muu4Fcu0yEUeXrYa9+rwr1NMqgRSvRWtVJM97TNkbcnREgH5Xm 5cXeNXKh0rkNrQbusY/RNsi0qH4siZhnVqHK7190sqE5imm7MxlzyNZ7ww9LvI861uxuWFd+U/eUV xCC8ZIzGiQgWhtI2w6YaynGx45YHfAem6n5A+/ksldqZGC4WkOPFhhRMfnRol8nJv755C58ALWKLM JUnXBVbUBDJWHA==; Received: from cpc103048-sgyl39-2-0-cust502.18-2.cable.virginm.net ([92.233.85.247]:33824 helo=rivendell.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odXhB-0001tK-MK; Wed, 28 Sep 2022 10:06:02 -0400 Received: from localhost (rivendell.localdomain [local]) by rivendell.localdomain (OpenSMTPD) with ESMTPA id 8d53953c; Wed, 28 Sep 2022 14:05:50 +0000 (UTC) From: Jose A Ortega Ruiz To: Eli Zaretskii Subject: Re: bug#58131: [PATCH] docview: new customization options for imenu In-Reply-To: <83k05nisp2.fsf@gnu.org> References: <87fsgcb5n8.fsf@mail.jao.io> <83k05nisp2.fsf@gnu.org> X-Attribution: jao X-Clacks-Overhead: GNU Terry Pratchett X-URL: Date: Wed, 28 Sep 2022 15:05:50 +0100 Message-ID: <87a66j7fwh.fsf@mail.jao.io> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58131 Cc: 58131@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Wed, Sep 28 2022, Eli Zaretskii wrote: >> From: Jose A Ortega Ruiz >> Date: Wed, 28 Sep 2022 03:21:31 +0100 >> >> A follow up to bug#58103 with a little fix for section title extraction >> and a couple of easy to implement customizable options. I've tried to >> document them clearly enough in the docstrings and then just mention >> their existence in the manual: is that a good practice or do we prefer >> some duplication? > > It's a possibility. But if you have nothing of essence to say about a > variable, why mention it in the manual at all? We don't need to > mention every user option in the manual, only the important ones. We > expect users who want to use a package to review its options (e.g., bu > "M-x customize-group") and decide which ones they want to change from > the default. That makes sense. In this case, there's just 3 variables related to the functionality, and my impression is that they provide options that users often will want... which might be taken yet as an argument for /not/ adding them to the manual, now that i think of it :) >> +(defcustom doc-view-imenu-title-format "%t (%p)" >> + "Format string for document section titles in imenu. >> + >> +The special markers '%t' and '%p' are replaced by the section >> +title and page number in this format string, which uses >> +`format-spec'. > > Will users immediately understand what you mean by "document section > title" here? If no, perhaps a sentence explaining what that is would > be beneficial. I would say they will: in the context of a docview imenu for a PDF document, there's little else it could reasonably be. But i'm biased: do you think otherwise? >> +(defcustom doc-view-imenu-flatten nil >> + "Whether to generate a flat list of sections instead of a nested tree." > > This doesn't mention imenu in the doc string; should it? Given that the name of the variable does, i think mentioning it would just make that first sentence longer without adding too much information. But again, as the implementor of the functionality, everything feels "obvious" to me. Thanks, jao -- Lying to ourselves is more deeply ingrained than lying to others. -Fyodor Dostoevsky, novelist (1821-1881) From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 10:25:35 2022 Received: (at 58131) by debbugs.gnu.org; 28 Sep 2022 14:25:35 +0000 Received: from localhost ([127.0.0.1]:34034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odY0F-0007cl-2k for submit@debbugs.gnu.org; Wed, 28 Sep 2022 10:25:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odY09-0007cU-Rz for 58131@debbugs.gnu.org; Wed, 28 Sep 2022 10:25:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50514) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odY04-0003E6-Li; Wed, 28 Sep 2022 10:25:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XjZeueXZ/kHbw18ACvNBVxB85yiw1nkcwDc3JDYybDk=; b=IVxBL30vZxdZ 3y7Q0BkpVQjUkjmaMQW7FD8RamxsdNIJoWqayxeLPuNqVuB270c+8HfLOiWmvkpmf7YnQpmCZ7rwT 3gyV5avFcG90I2qqmihByN3dMzQrhz5RIBLy27akSUGutfrWYL6FrKvTVYBfvFZ8tj4KU4TlveKMP 67UDzuxq6teM/gLS/hMj77WBVO+ew24EGGAC8sigVrjtWKZC5HwCpCE6ixi3J5iTHxGl3/8W9yNtd 7uEtnjGyOU5UodXasTdjxDc/YRgbVegtW+175fC5CRL2mY8OvIybZbSMwk8kr+EKIUDJEupcGI2oP AAg93UanGBV52ECTMeg/cQ==; Received: from [87.69.77.57] (port=3803 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odY04-0006x6-4F; Wed, 28 Sep 2022 10:25:24 -0400 Date: Wed, 28 Sep 2022 17:25:19 +0300 Message-Id: <83edvvinjk.fsf@gnu.org> From: Eli Zaretskii To: Jose A Ortega Ruiz In-Reply-To: <87a66j7fwh.fsf@mail.jao.io> (message from Jose A Ortega Ruiz on Wed, 28 Sep 2022 15:05:50 +0100) Subject: Re: bug#58131: [PATCH] docview: new customization options for imenu References: <87fsgcb5n8.fsf@mail.jao.io> <83k05nisp2.fsf@gnu.org> <87a66j7fwh.fsf@mail.jao.io> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58131 Cc: 58131@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jose A Ortega Ruiz > Cc: 58131@debbugs.gnu.org > Date: Wed, 28 Sep 2022 15:05:50 +0100 > > >> +(defcustom doc-view-imenu-title-format "%t (%p)" > >> + "Format string for document section titles in imenu. > >> + > >> +The special markers '%t' and '%p' are replaced by the section > >> +title and page number in this format string, which uses > >> +`format-spec'. > > > > Will users immediately understand what you mean by "document section > > title" here? If no, perhaps a sentence explaining what that is would > > be beneficial. > > I would say they will: in the context of a docview imenu for a PDF > document, there's little else it could reasonably be. But i'm biased: do > you think otherwise? FWIW, I couldn't understand what that means. How does being in the context of docview imenu for a PDF document help understanding that here? "Document section title" is general enough terminology. Using a "construct state" here doesn't help, either. > >> +(defcustom doc-view-imenu-flatten nil > >> + "Whether to generate a flat list of sections instead of a nested tree." > > > > This doesn't mention imenu in the doc string; should it? > > Given that the name of the variable does, i think mentioning it would > just make that first sentence longer without adding too much > information. But again, as the implementor of the functionality, > everything feels "obvious" to me. My suggestion is Whether to flatten the list of sections in an imenu or show it nested. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 11:14:28 2022 Received: (at 58131) by debbugs.gnu.org; 28 Sep 2022 15:14:28 +0000 Received: from localhost ([127.0.0.1]:34206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odYlY-0002iS-12 for submit@debbugs.gnu.org; Wed, 28 Sep 2022 11:14:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odYlV-0002iE-A3 for 58131@debbugs.gnu.org; Wed, 28 Sep 2022 11:14:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58002) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odYlO-0005TS-Av; Wed, 28 Sep 2022 11:14:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=kD8lY/4j94OmsJXTpPmFU6mHSFH/mcu90My0Z0r+BoE=; b=Snh8P7TmzGI18f+zy7we YrGK/4WdC9PQLB2G55NVQQpSBxZA9LMJXfowf3lWW2N8LVtVIHS3tX1TLJ6r+EuVIWtqirOdpu6HJ 6dkz85fzHDzgKCcuT8jcZo06dk80ChWb0mFTecYlpNGghyk6c4UKc2GP/Gkirek5b2XtPYjBR2ENe 4rXSFteh7t/n5IZkuziUPbwjMkihcRKCJogS0PGT8MsQyGrh5wPc1P+smdiiEWITiPrEJoos6Oraz Cno/F5Zn2sKKQQtu5guWZC64Fl5MYykas6gSNM5FpIR7TijCvNIOBn1JRW2fJ279YCZdX3GU5wDuA N79Fkq9to3FYNQ==; Received: from cpc103048-sgyl39-2-0-cust502.18-2.cable.virginm.net ([92.233.85.247]:47728 helo=rivendell.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odYlN-0006hO-Rj; Wed, 28 Sep 2022 11:14:18 -0400 Received: from localhost (rivendell.localdomain [local]) by rivendell.localdomain (OpenSMTPD) with ESMTPA id 8f0e5aeb; Wed, 28 Sep 2022 15:14:13 +0000 (UTC) From: Jose A Ortega Ruiz To: Eli Zaretskii Subject: Re: bug#58131: [PATCH] docview: new customization options for imenu In-Reply-To: <83edvvinjk.fsf@gnu.org> References: <87fsgcb5n8.fsf@mail.jao.io> <83k05nisp2.fsf@gnu.org> <87a66j7fwh.fsf@mail.jao.io> <83edvvinjk.fsf@gnu.org> X-Attribution: jao X-Clacks-Overhead: GNU Terry Pratchett X-URL: Date: Wed, 28 Sep 2022 16:14:13 +0100 Message-ID: <877d1n7cqi.fsf@mail.jao.io> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58131 Cc: 58131@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Wed, Sep 28 2022, Eli Zaretskii wrote: >> From: Jose A Ortega Ruiz >> Cc: 58131@debbugs.gnu.org >> Date: Wed, 28 Sep 2022 15:05:50 +0100 >> >> >> +(defcustom doc-view-imenu-title-format "%t (%p)" >> >> + "Format string for document section titles in imenu. >> >> + >> >> +The special markers '%t' and '%p' are replaced by the section >> >> +title and page number in this format string, which uses >> >> +`format-spec'. >> > >> > Will users immediately understand what you mean by "document section >> > title" here? If no, perhaps a sentence explaining what that is would >> > be beneficial. >> >> I would say they will: in the context of a docview imenu for a PDF >> document, there's little else it could reasonably be. But i'm biased: do >> you think otherwise? > > FWIW, I couldn't understand what that means. > > How does being in the context of docview imenu for a PDF document help > understanding that here? "Document section title" is general enough > terminology. Using a "construct state" here doesn't help, either. To me, the context is that this is read by a user of the functionality, wanting to fine-tune it (i rarely start exploring a functionality by reading the docstring of one of its customizable variables). Barring that: the Imenu section of the manual calls the items being formatted here simply "definitions". If we assume that the user knows about imenu in general, one could have: "Format string for the imenu definitions extracted from documents." Or, perhaps, trying to provide the missing context for not-yet-users: "Format string for the section titles extracted by imenu from docview documents." Any better? >> >> +(defcustom doc-view-imenu-flatten nil >> >> + "Whether to generate a flat list of sections instead of a nested tree." >> > >> > This doesn't mention imenu in the doc string; should it? >> >> Given that the name of the variable does, i think mentioning it would >> just make that first sentence longer without adding too much >> information. But again, as the implementor of the functionality, >> everything feels "obvious" to me. > > My suggestion is > > Whether to flatten the list of sections in an imenu or show it nested. Sounds better to me too, yes. Thanks, jao -- Nothing so soothes our vanity as a display of greater vanity in others; it makes us vain, in fact, of our modesty. -Louis Kronenberger, writer (1904-1980) From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 11:50:11 2022 Received: (at 58131) by debbugs.gnu.org; 28 Sep 2022 15:50:11 +0000 Received: from localhost ([127.0.0.1]:34281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odZK6-0003e7-RG for submit@debbugs.gnu.org; Wed, 28 Sep 2022 11:50:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odZK5-0003dt-7f for 58131@debbugs.gnu.org; Wed, 28 Sep 2022 11:50:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42446) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odZJz-0005ME-AC; Wed, 28 Sep 2022 11:50:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8R1kZSjGqL+U9m67MBHe2XHDyNGoij/Xf6lBVH8IAnY=; b=hF6I0RwGbyDa HYTNUChAalwJ0gZf/JdNoJQuZpczs+leDnTGqRS0ryEv3V9DkUlX47H9e9R6BXOk29UjOe18KVSrI DMa40PQ57qLCc/ldllrI21UjHJWUYAnwEK4RV5UgoeQ651Km+zPDdTPU2rjxMcj/c1Sp0B2lkDyYL LEtAXcXMhII74bDs1oFOrh0MCKX41jdQ8bFh31W7r8HA3IU6vFM8VbG6eu8eo2D8RHeDWIsSG1K1b JXEBtzWzcWIlZE6qIKpFezxTLCl9nCASkDLoKl3UgiRUgpLXZyfXBFacaT7pgFzBQ0KXNiRD7TSNh XGIj2YW8kume4ghleVw8DQ==; Received: from [87.69.77.57] (port=1041 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odZJy-0000xF-Js; Wed, 28 Sep 2022 11:50:03 -0400 Date: Wed, 28 Sep 2022 18:49:58 +0300 Message-Id: <83bkqzijmh.fsf@gnu.org> From: Eli Zaretskii To: Jose A Ortega Ruiz In-Reply-To: <877d1n7cqi.fsf@mail.jao.io> (message from Jose A Ortega Ruiz on Wed, 28 Sep 2022 16:14:13 +0100) Subject: Re: bug#58131: [PATCH] docview: new customization options for imenu References: <87fsgcb5n8.fsf@mail.jao.io> <83k05nisp2.fsf@gnu.org> <87a66j7fwh.fsf@mail.jao.io> <83edvvinjk.fsf@gnu.org> <877d1n7cqi.fsf@mail.jao.io> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58131 Cc: 58131@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jose A Ortega Ruiz > Cc: 58131@debbugs.gnu.org > Date: Wed, 28 Sep 2022 16:14:13 +0100 > > >> I would say they will: in the context of a docview imenu for a PDF > >> document, there's little else it could reasonably be. But i'm biased: do > >> you think otherwise? > > > > FWIW, I couldn't understand what that means. > > > > How does being in the context of docview imenu for a PDF document help > > understanding that here? "Document section title" is general enough > > terminology. Using a "construct state" here doesn't help, either. > > To me, the context is that this is read by a user of the functionality, > wanting to fine-tune it (i rarely start exploring a functionality by > reading the docstring of one of its customizable variables). Think about the various Help commands, such as 'apropos': they show the doc strings or just their first sentence entirely out of any context. Users who invoke such commands should be capable to understand at a glance whether the command/variable is something they should examine further. So having important keywords in there helps immensely to make such triage steps much faster and more efficient. > Barring that: the Imenu section of the manual calls the items being > formatted here simply "definitions". If we assume that the user knows > about imenu in general, one could have: > > "Format string for the imenu definitions extracted from documents." > > Or, perhaps, trying to provide the missing context for not-yet-users: > > "Format string for the section titles extracted by imenu from docview documents." > > Any better? Yes, thanks. My suggestion is a very minor variation of the latter: Format spec for imenu's display of section titles from docview documents. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 11:56:31 2022 Received: (at 58131) by debbugs.gnu.org; 28 Sep 2022 15:56:31 +0000 Received: from localhost ([127.0.0.1]:34288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odZQD-0003nD-Nx for submit@debbugs.gnu.org; Wed, 28 Sep 2022 11:56:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odZPz-0003mn-5c for 58131@debbugs.gnu.org; Wed, 28 Sep 2022 11:56:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52328) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odZPt-0006uw-BL; Wed, 28 Sep 2022 11:56:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=z6phbEjhf40s9I2rWAXLvJuTXX91lPR5k5jmFONeNjc=; b=WnPdcTdH6DY7MHvdBtNM 6LT2EbXFk92EaOisKY3nXTHyx+tQ+amvVEBKjjKshIxV0Pm2wcOTWTc4i4RRZ4kJ09MvGV4sQ55Vt b5KlIqcTSpZ7ewMCiBK5bAfD5YbdvIVd7fQ185Bm+NsYcuyhJe23t5wXoSivEXlk2KqWWAzOhI+HU h23e9wQsZUL7gKtg0e8knvWMmzDaL6Xrvdus8uPgMxrqjQIGoRzHJBYVii2EEXCn+0r9VXygJYqvG cTimifHeHi6cr5sQHRY8xwMgDef5j9WO1sG1FfSSsaFDCJB81z5vHR+BxuoCnGTV7/mtAvNN9olFT DK8jyxSeOysXrg==; Received: from cpc103048-sgyl39-2-0-cust502.18-2.cable.virginm.net ([92.233.85.247]:56788 helo=rivendell.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odZPm-00024s-Fm; Wed, 28 Sep 2022 11:56:09 -0400 Received: from localhost (rivendell.localdomain [local]) by rivendell.localdomain (OpenSMTPD) with ESMTPA id 74424194; Wed, 28 Sep 2022 15:55:56 +0000 (UTC) From: Jose A Ortega Ruiz To: Eli Zaretskii Subject: Re: bug#58131: [PATCH] docview: new customization options for imenu In-Reply-To: <83bkqzijmh.fsf@gnu.org> References: <87fsgcb5n8.fsf@mail.jao.io> <83k05nisp2.fsf@gnu.org> <87a66j7fwh.fsf@mail.jao.io> <83edvvinjk.fsf@gnu.org> <877d1n7cqi.fsf@mail.jao.io> <83bkqzijmh.fsf@gnu.org> X-Attribution: jao X-Clacks-Overhead: GNU Terry Pratchett X-URL: Date: Wed, 28 Sep 2022 16:55:56 +0100 Message-ID: <874jwr7asz.fsf@mail.jao.io> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58131 Cc: 58131@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Wed, Sep 28 2022, Eli Zaretskii wrote: [...] > Think about the various Help commands, such as 'apropos': they show > the doc strings or just their first sentence entirely out of any > context. Users who invoke such commands should be capable to > understand at a glance whether the command/variable is something they > should examine further. So having important keywords in there helps > immensely to make such triage steps much faster and more efficient. Excellent point, thanks. [...] >> Any better? > > Yes, thanks. My suggestion is a very minor variation of the latter: > > Format spec for imenu's display of section titles from docview documents. Looks good to me. Would you like a patch with the two new strings or is it quicker if you directly commit a change by yourself? Cheers, jao --=20 All parts should go together without forcing. You must remember that the parts you are reassembling were disassembled by you. Therefore, if you can=E2=80=99t get them together again, there must be a reason. By all means, do not use a hammer. =E2=80=94IBM Manual, 1925 From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 12:01:58 2022 Received: (at 58131) by debbugs.gnu.org; 28 Sep 2022 16:01:59 +0000 Received: from localhost ([127.0.0.1]:34325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odZVW-0003xw-Kj for submit@debbugs.gnu.org; Wed, 28 Sep 2022 12:01:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odZVU-0003xj-8g for 58131@debbugs.gnu.org; Wed, 28 Sep 2022 12:01:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53822) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odZVP-00006s-1i; Wed, 28 Sep 2022 12:01:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NKiOO/KyzbTcuUzuPDwwphky0ed/Xd3NeWPseIMI0VM=; b=L9EmUampLutw IRmM3Nts6b7ZQUauyZZP4qBnDajMQuqcYv+9O1n7aBl+ddwwpfuVYPoj1CrJSImkSSZbgEVAOzvaJ ESGJxNYV16JSdNXwyjFVMj1IuAHF4vj0Wo5tgkARDbPZBLfxDL2JghshwgCgMk9TN1kur79icmM72 tQ8QIfUXu57hFSMtYGJbBgmC4T/Sx075cCo0dp25KJq0VBkiocvB0MkPFnxWc0CO2EPv/hjl5MayQ DNGaeAYOv99OaIBvWFY8Y91oyKDv8XjOJj9s1LnR/xAFtd7A04yq0kTimXlBPdiV4mMHDqk4YpafO cufjUxhRaLOJEdQqae+C/Q==; Received: from [87.69.77.57] (port=1771 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odZVO-0002KE-9T; Wed, 28 Sep 2022 12:01:50 -0400 Date: Wed, 28 Sep 2022 19:01:46 +0300 Message-Id: <838rm3ij2t.fsf@gnu.org> From: Eli Zaretskii To: Jose A Ortega Ruiz In-Reply-To: <874jwr7asz.fsf@mail.jao.io> (message from Jose A Ortega Ruiz on Wed, 28 Sep 2022 16:55:56 +0100) Subject: Re: bug#58131: [PATCH] docview: new customization options for imenu References: <87fsgcb5n8.fsf@mail.jao.io> <83k05nisp2.fsf@gnu.org> <87a66j7fwh.fsf@mail.jao.io> <83edvvinjk.fsf@gnu.org> <877d1n7cqi.fsf@mail.jao.io> <83bkqzijmh.fsf@gnu.org> <874jwr7asz.fsf@mail.jao.io> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58131 Cc: 58131@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jose A Ortega Ruiz > Cc: 58131@debbugs.gnu.org > Date: Wed, 28 Sep 2022 16:55:56 +0100 > > Looks good to me. Would you like a patch with the two new strings or is > it quicker if you directly commit a change by yourself? No need, I made these changes already. Thanks for the feedback. From unknown Sun Aug 17 04:16:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 27 Oct 2022 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator