GNU bug report logs - #5813
remove __DJGPP__ version tests

Previous Next

Package: emacs;

Reported by: Dan Nicolaescu <dann <at> gnu.org>

Date: Wed, 31 Mar 2010 19:34:01 UTC

Severity: normal

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5813 in the body.
You can then email your comments to 5813 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#5813; Package emacs. (Wed, 31 Mar 2010 19:34:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Dan Nicolaescu <dann <at> gnu.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 31 Mar 2010 19:34:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: remove __DJGPP__ version tests
Date: Wed, 31 Mar 2010 15:33:03 -0400

Are the __DJGPP__ version tests still needed?
Can we assume __DJGPP__ >= 2 is true?

Any reason not to remove them?
Reply sent to Eli Zaretskii <eliz <at> gnu.org>:
You have taken responsibility. (Thu, 01 Apr 2010 15:38:02 GMT) Full text and rfc822 format available.
Notification sent to Dan Nicolaescu <dann <at> gnu.org>:
bug acknowledged by developer. (Thu, 01 Apr 2010 15:38:02 GMT) Full text and rfc822 format available.

Message #10 received at 5813-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: 5813-done <at> debbugs.gnu.org
Subject: Re: bug#5813: remove __DJGPP__ version tests
Date: Thu, 01 Apr 2010 18:37:28 +0300

> From: Dan Nicolaescu <dann <at> gnu.org>
> Date: Wed, 31 Mar 2010 15:33:03 -0400
> 
> Are the __DJGPP__ version tests still needed?
> Can we assume __DJGPP__ >= 2 is true?
> 
> Any reason not to remove them?

Yes, it's time to forget about DJGPP < 2.  Thanks for pointing this
out.

I removed all the tests for __DJGPP__.  There are still 3 tests for
__DJGPP_MINOR__, but they are in MSDOS-specific files (dosfns.c and
msdos.c).  I also updated CPP-DEFINES accordingly.

Message #11 received at 5813-done <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 5813-done <at> debbugs.gnu.org
Subject: Re: bug#5813: remove __DJGPP__ version tests
Date: Thu, 01 Apr 2010 19:26:43 -0400

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Dan Nicolaescu <dann <at> gnu.org>
>> Date: Wed, 31 Mar 2010 15:33:03 -0400
>> 
>> Are the __DJGPP__ version tests still needed?
>> Can we assume __DJGPP__ >= 2 is true?
>> 
>> Any reason not to remove them?
>
> Yes, it's time to forget about DJGPP < 2.  Thanks for pointing this
> out.
>
> I removed all the tests for __DJGPP__.  There are still 3 tests for
> __DJGPP_MINOR__, but they are in MSDOS-specific files (dosfns.c and
> msdos.c).  I also updated CPP-DEFINES accordingly.

Can you please also remove comments like:
/* Demacs 1.1.1 91/10/16 HIRANO Satoshi */
that have about zero use now.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 30 Apr 2010 11:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 15 years and 113 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.