From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 27 07:51:57 2022 Received: (at submit) by debbugs.gnu.org; 27 Sep 2022 11:51:57 +0000 Received: from localhost ([127.0.0.1]:53193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1od981-0006KH-CE for submit@debbugs.gnu.org; Tue, 27 Sep 2022 07:51:57 -0400 Received: from lists.gnu.org ([209.51.188.17]:35626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1od97y-0006K7-3V for submit@debbugs.gnu.org; Tue, 27 Sep 2022 07:51:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1od97T-00026I-2i for bug-guix@gnu.org; Tue, 27 Sep 2022 07:51:41 -0400 Received: from mx1.riseup.net ([198.252.153.129]:35914) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1od97Q-0006PW-RU for bug-guix@gnu.org; Tue, 27 Sep 2022 07:51:22 -0400 Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4McHyM35BKzDqVS; Tue, 27 Sep 2022 11:51:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1664279478; bh=h8a3TWzK6g4pqQuMm8W1hDqmzW0aqR2ISgzcyh5zFLk=; h=From:To:Cc:Subject:Date:From; b=I7YEecQ97YzpHpMGXo0lJ2TT299Cb173LJdBl+DU5DgF/UcTxBBc/e6DZIym6Sesu s4cH/TZgzX1PMCDOK6vvtgBouZX6zIfkZSxh6+q837MyxiKtOFcWrF3s6ScDevImHs ELwDDEb8BLhHsAx/zvY0F1vc2oN3j5ugnEPoRJS4= X-Riseup-User-ID: 1892281332701C09077C0EF436AF6E70A3CEF6398B035765FBA8F63730038972 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4McHyL42Jrz5vYk; Tue, 27 Sep 2022 11:51:06 +0000 (UTC) From: Csepp To: Bug reports for GNU Guix Subject: OPAM importer fails in lookup-node Date: Tue, 27 Sep 2022 13:33:56 +0200 Message-ID: <87sfkd11eh.fsf@riseup.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=198.252.153.129; envelope-from=raingloom@riseup.net; helo=mx1.riseup.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: julien@lepiller.eu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) The specific error is this: Wrong number of values returned to continuation (expected 2) It is caused by opam->guix-package silencing intermediate errors by using and-let* (the poor person's Maybe monad) and returning #f when the receiving side expects two return values. Initial reproducer: guix import opam -r mirage Also happens with opam-monorepo. Cc-ing Julien whom might know why the code is structured this way? It's not like the calling side can handle a falsy return and the error is not detected early either, so the user doesn't even know what is causing it. Can I just turn it all into errors? Or maybe we can use the condition system? From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 27 11:43:25 2022 Received: (at submit) by debbugs.gnu.org; 27 Sep 2022 15:43:25 +0000 Received: from localhost ([127.0.0.1]:56584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odCk1-0002qu-3J for submit@debbugs.gnu.org; Tue, 27 Sep 2022 11:43:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:52188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odCjz-0002qo-FF for submit@debbugs.gnu.org; Tue, 27 Sep 2022 11:43:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odCjx-0000sp-9D for bug-guix@gnu.org; Tue, 27 Sep 2022 11:43:23 -0400 Received: from lepiller.eu ([2a00:5884:8208::1]:44804) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odCju-000731-PW for bug-guix@gnu.org; Tue, 27 Sep 2022 11:43:21 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 9a7f76f1; Tue, 27 Sep 2022 15:42:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:subject:in-reply-to:references:message-id:mime-version :content-type:content-transfer-encoding; s=dkim; bh=kGHQA2SLKB3c Kn75Nh+QBUQjtv0JqZ9mptqI+wVRJGM=; b=nqZLDIdEcs5127EYc6ahHKLHYAY5 6dypy0leg4NE+rWiy//+oltpkZtIB0NHl9KC9C8f5AmE0Rngb27IBikQstPTmd7O q2i32rAbeoB7hVR3Q4DEq5XdrFW0jYbN5GHT4vjoXaYxVf0tF/FFUoVeD4vtT8GM NHwGBqUztXdVlTuDNSHKv5AEMkNkyZNlQz8ejcm06KhpfUA/AC9wdIyh3Bfh//Iq MSYVILpw4hA2HJgEPrzaoq3IN7EfFc5Iu5ji/vrKJ+Rvceb9WaRNb0YqMSegUhgB OkcCY9Ajyn0e558y7+FIx2KDslDkfbQ0u5XUJo+gfbp0xxfqpnBwSQMtwA== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id a382e312 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Tue, 27 Sep 2022 15:42:08 +0000 (UTC) Date: Tue, 27 Sep 2022 17:42:06 +0200 From: Julien Lepiller To: Csepp , Bug reports for GNU Guix Subject: Re: OPAM importer fails in lookup-node User-Agent: K-9 Mail for Android In-Reply-To: <87sfkd11eh.fsf@riseup.net> References: <87sfkd11eh.fsf@riseup.net> Message-ID: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=----G48S72FG81P3ZS3LK4I6ZJPTS8TSBL Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:5884:8208::1; envelope-from=julien@lepiller.eu; helo=lepiller.eu X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) ------G48S72FG81P3ZS3LK4I6ZJPTS8TSBL Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable It's probably because other importers are structured that way=2E I'd be in = favor of changing that and using the condition system=2E Le 27 septembre 2022 13:33:56 GMT+02:00, Csepp a = =C3=A9crit=C2=A0: >The specific error is this: >Wrong number of values returned to continuation (expected 2) >It is caused by opam->guix-package silencing intermediate errors by >using and-let* (the poor person's Maybe monad) and returning #f when the >receiving side expects two return values=2E > >Initial reproducer: >guix import opam -r mirage > >Also happens with opam-monorepo=2E > >Cc-ing Julien whom might know why the code is structured this way? It's >not like the calling side can handle a falsy return and the error is not >detected early either, so the user doesn't even know what is causing it= =2E >Can I just turn it all into errors? Or maybe we can use the condition >system? > ------G48S72FG81P3ZS3LK4I6ZJPTS8TSBL Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable It's probably because other importers are structur= ed that way=2E I'd be in favor of changing that and using the condition sys= tem=2E

Le 27 septembre 2022 13:33:56 GMT+= 02:00, Csepp <raingloom@riseup=2Enet> a =C3=A9crit=C2=A0:
The specific error is this:
Wrong nu=
mber of values returned to continuation (expected 2)
It is caused by opa=
m->guix-package silencing intermediate errors by
using and-let* (the =
poor person's Maybe monad) and returning #f when the
receiving side expe=
cts two return values=2E

Initial reproducer:
guix import opam -r =
mirage

Also happens with opam-monorepo=2E

Cc-ing Julien whom =
might know why the code is structured this way?  It's
not like the calli=
ng side can handle a falsy return and the error is not
detected early ei=
ther, so the user doesn't even know what is causing it=2E
Can I just tur=
n it all into errors?  Or maybe we can use the condition
system?

=
------G48S72FG81P3ZS3LK4I6ZJPTS8TSBL-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 27 14:31:42 2022 Received: (at 58112) by debbugs.gnu.org; 27 Sep 2022 18:31:42 +0000 Received: from localhost ([127.0.0.1]:56799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odFMs-0003Ab-7B for submit@debbugs.gnu.org; Tue, 27 Sep 2022 14:31:42 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:39519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odFMp-0003AM-0H for 58112@debbugs.gnu.org; Tue, 27 Sep 2022 14:31:41 -0400 Received: by mail-wr1-f52.google.com with SMTP id cc5so16302545wrb.6 for <58112@debbugs.gnu.org>; Tue, 27 Sep 2022 11:31:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date; bh=b+aeEPYmXdNGK9qs13SCsqxfYwbnKtmgFuxVKIlw8RE=; b=CMgBD/hGyh2mLgjnt2o05h2ULXCUo7DOpQQQEdd+zYJtjqHyJZltx1YYcw8DjB1zci HbzRlHbyaoKo1mHNcyNeh3jA4+lex46JzGqSuSSLANgIc2mVC6qNHUTXN69B9JRMZDjM jJMyaOBh6ZXp3hD2JpLzM/hwDQynpxzVbsSZ/9j8GlbxNLY/uW4du7Ucel9wub0Z1nlz wvclmPsBrMrvhX+bH33L58bmHddajZih5Soc/Hd0is+MUbew0M0Nd3nzY3EoR/JUu6nz gvafrekCFsHe45U1w1q4CCAcdUW8ZIIGXdDrR0MY0vCKQ/ZG7w8J78V4CRsp1eN6eXLY 1Q0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=b+aeEPYmXdNGK9qs13SCsqxfYwbnKtmgFuxVKIlw8RE=; b=d/0iFcsQw4KTkpA+5PqQ7LTXez8kH1EfFAZODchIqMADAwiw0NmCQ2d/A2oLlz3bZF NbEp15CUMeWzhvoemo80kF7gfu0yZZxrB2b8dMiUzhbV9akA1o34/OAifhjqGBzogLGt D1ik0cTmZ0kMc+FimSJbfFQ0pxnyrzaIpxnw4ZOnqq1gqXOFLa+IGcUFEF2i383qNW6/ /oV+F07HvRYCjrlc7WqCC6JY+8kO+JqZXSh+ra4tTxXiC7Wh1jUru4RdsRZezZbktn44 yG6gITIqccB92tPmlEaT33XUY2lz3gZDJ8RgZ7BiXTwzIe2NbosO1zgfSUmE4CEe0tUx 4aCw== X-Gm-Message-State: ACrzQf0NpU2oX7wap+/sUb7/yId7Da6qEnvtXxWgWZ1zeLV0wo80Ueed HOjPoP6T/RHxSHnkPwOr5VE= X-Google-Smtp-Source: AMsMyM5AFSZ2ziym3M03tAetH41kbA5DZFN9pcoHSJZNuUMClSxNj8aDVNiPnz/4frNsyhrUJaFVYg== X-Received: by 2002:adf:e601:0:b0:228:60f6:2512 with SMTP id p1-20020adfe601000000b0022860f62512mr18309874wrm.334.1664303492915; Tue, 27 Sep 2022 11:31:32 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id m17-20020a7bce11000000b003b4931eb435sm16588633wmc.26.2022.09.27.11.31.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 11:31:32 -0700 (PDT) From: zimoun To: Csepp , 58112@debbugs.gnu.org Subject: Re: bug#58112: OPAM importer fails in lookup-node In-Reply-To: <87sfkd11eh.fsf@riseup.net> References: <87sfkd11eh.fsf@riseup.net> Date: Tue, 27 Sep 2022 15:47:57 +0200 Message-ID: <86mtaludwy.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, On Tue, 27 Sep 2022 at 13:33, Csepp wrote: > The specific error is this: > Wrong number of values returned to continuation (expected 2) > It is caused by opam->guix-package silencing intermediate er [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 1.1 DATE_IN_PAST_03_06 Date: is 3 to 6 hours before Received: date 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (zimon.toutoune[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.52 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.52 listed in wl.mailspike.net] X-Debbugs-Envelope-To: 58112 Cc: julien@lepiller.eu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Hi, On Tue, 27 Sep 2022 at 13:33, Csepp wrote: > The specific error is this: > Wrong number of values returned to continuation (expected 2) > It is caused by opam->guix-package silencing intermediate errors by > using and-let* (the poor person's Maybe monad) and returning #f when the > receiving side expects two return values. > > Initial reproducer: > guix import opam -r mirage I have not checked for opam, but it reminds me fixes in other importers. 5278cab3dc * scripts: import: gem: Fix recursive error handling. 7229b0e858 * import: cran: Return multiple values for unknown packages. 1fe81b349c * import: elpa: Return multiple values for unknown packages. 6bb92098b4 * import: hackage: Return multiple values for unknown packages. And the bug#44115 report [1] mentioned opam but indeed the fix probably fell in the crack. :-) Do you want to give a try? 1: https://issues.guix.gnu.org/44115 Cheers, simon