GNU bug report logs - #58111
[PATCH] Add support for the Adlam script

Previous Next

Full log

Message #11 received at 58111 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 58111 <at> debbugs.gnu.org
Subject: Re: bug#58111: [PATCH] Add support for the Adlam script
Date: Tue, 27 Sep 2022 15:05:45 +0200

>>>>> On Tue, 27 Sep 2022 16:52:22 +0530, समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com> said:


    समीर> * lisp/language/misc-lang.el ("Adlam"): New language environment.
    समीर> Add composition rules for Adlam. Add sample text and input method.

Two spaces after full stop.

    समीर> @@ -1229,10 +1229,9 @@ to edit such sequences by allowing point to "enter" the sequence.
    समीर>  *** Support for many old scripts and writing systems.
    समीर>  Emacs now supports and has language-environments and input methods for
    समीर>  several dozens of old scripts that were used in the past for various
    समीर> -languages in South and South-East Asia.  For each such script Emacs
    समीर> -now has font-selection and character composition rules, a language
    समीर> -environment, and an input method.  The newly-added scripts and the
    समीर> -corresponding language environments are:
    समीर> +languages.  For each such script Emacs now has font-selection and character
    समीर> +composition rules, a language environment, and an input method.  The newly-added
    समीर> +scripts and the corresponding language environments are:

I think this text should be re-wrapped ('M-q')

    समीर> +(quail-define-package
    समीर> + "adlam" "Adlam" "𞤀" t "Adlam input method.
    समीर> +
    समीर> + `\\=`' is used to switch levels instead of Alt-Gr.

Are the `' necessary around the "\\=" ?

The rest looks good to a limited Latin-1 person such as myself :-)

Thanks for doing this.

Robert
-- 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.