GNU bug report logs - #58092
29.0.50; [PATCH] Add log-edit-summary-separator face

Previous Next

Full log

Message #40 received at 58092 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, Robert Pluim <rpluim <at> gmail.com>,
 Dmitry Gutov <dgutov <at> yandex.ru>, Protesilaos Stavrou <info <at> protesilaos.com>,
 58092 <at> debbugs.gnu.org
Subject: Re: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face
Date: Tue, 27 Sep 2022 17:49:42 -0700

Hello,

On Tue 27 Sep 2022 at 12:15PM -04, Stefan Kangas wrote:

> Sean Whitton <spwhitton <at> spwhitton.name> writes:
>
>>>> amend no. revert yes, but itʼs overkill for just a commit message issue. You
>>>> can always run 'make change-history' and fix it in the resulting
>>>> ChangeLog file (see admin/notes/repo for the details)
>>>
>>> Please don't do that, it will make merging more tricky later.
>>
>> Hmm, so it's never okay to do that?  Or is it to be saved for the more
>> egregrious errors?
>
> It's easier for me (or whoever is charge of merging and/or releases) if
> we don't do that, so I'd prefer it if we could reserve it for
> particularly nasty mistakes.
>
> However, if it has to be done, please do it in two separate commits: one
> that generates the ChangeLog and one that fixes the mistake.

Thanks.  I've updated admin/notes/repo with this information.

-- 
Sean Whitton

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.